[GitHub] coveralls commented on issue #3494: Removing dependency on pythrifthiveapi
coveralls commented on issue #3494: Removing dependency on pythrifthiveapi URL: https://github.com/apache/incubator-superset/pull/3494#issuecomment-330434370 [](https://coveralls.io/builds/13329431) Coverage remained the same at 69.432% when pulling **e8a0a73f6db39e6a9f5c22fd2df1636882e76201 on mistercrunch:pythrifthiveapi** into **c5252d0f43621999030d3dcf3d2e8bfee5452510 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3494: Removing dependency on pythrifthiveapi
coveralls commented on issue #3494: Removing dependency on pythrifthiveapi URL: https://github.com/apache/incubator-superset/pull/3494#issuecomment-330434371 [](https://coveralls.io/builds/13329431) Coverage remained the same at 69.432% when pulling **e8a0a73f6db39e6a9f5c22fd2df1636882e76201 on mistercrunch:pythrifthiveapi** into **c5252d0f43621999030d3dcf3d2e8bfee5452510 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3493: Adding missing future imports
coveralls commented on issue #3493: Adding missing future imports URL: https://github.com/apache/incubator-superset/pull/3493#issuecomment-330434160 [](https://coveralls.io/builds/13329406) Coverage increased (+0.03%) to 69.459% when pulling **b78fc9abc208c109b0fade5f7832db614a5739f3 on mistercrunch:future** into **c5252d0f43621999030d3dcf3d2e8bfee5452510 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch opened a new pull request #3494: Removing dependency on pythrifthiveapi
mistercrunch opened a new pull request #3494: Removing dependency on pythrifthiveapi URL: https://github.com/apache/incubator-superset/pull/3494 Since the latest pyhive, we don't need pythrifthiveapi as they ship with the latest version. There's actually a conflict between the new pyhive and pythrifthiveapi and this fixes it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch opened a new pull request #3493: Adding missing future imports
mistercrunch opened a new pull request #3493: Adding missing future imports URL: https://github.com/apache/incubator-superset/pull/3493 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #3474: [heatmap] account for bounds = 0
mistercrunch commented on issue #3474: [heatmap] account for bounds = 0 URL: https://github.com/apache/incubator-superset/pull/3474#issuecomment-330426518 treating as a hotfix & mergin' This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #3474: [heatmap] account for bounds = 0
mistercrunch closed pull request #3474: [heatmap] account for bounds = 0 URL: https://github.com/apache/incubator-superset/pull/3474 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #3480: Improve code quality
mistercrunch closed pull request #3480: Improve code quality URL: https://github.com/apache/incubator-superset/pull/3480 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3480: Improve code quality
coveralls commented on issue #3480: Improve code quality URL: https://github.com/apache/incubator-superset/pull/3480#issuecomment-330416816 [](https://coveralls.io/builds/13328455) Coverage decreased (-0.01%) to 69.432% when pulling **f64cf8dee681c05efd03948550b76838935401c2 on timifasubaa:improve_code_quality** into **c3c9ceb1cc3fc70670257f8f652f083cde2ea14d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa commented on issue #3480: Improve code quality
timifasubaa commented on issue #3480: Improve code quality URL: https://github.com/apache/incubator-superset/pull/3480#issuecomment-330415478 Removed changes whose previous state was already pep8 compliant or I thought did not bring much benefit. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Yuanmu93 commented on issue #3485: ImportError: cannot import TableModelView from superset.connectors.sqla.views in superset.views.core.py
Yuanmu93 commented on issue #3485: ImportError: cannot import TableModelView from superset.connectors.sqla.views in superset.views.core.py URL: https://github.com/apache/incubator-superset/issues/3485#issuecomment-330400538 @xrmx Thank you for your reply! I'm trying to cteate a MultipleView class with TableModelView and DashboardModelView.The MultipleView can render them on the same page. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3474: [heatmap] account for bounds = 0
coveralls commented on issue #3474: [heatmap] account for bounds = 0 URL: https://github.com/apache/incubator-superset/pull/3474#issuecomment-330400447 [](https://coveralls.io/builds/13327666) Coverage remained the same at 69.442% when pulling **a54e81e373ac713142673c1ca320caff17128573 on mistercrunch:heatmap_bounds** into **c3c9ceb1cc3fc70670257f8f652f083cde2ea14d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3491: Remove repeated line
coveralls commented on issue #3491: Remove repeated line URL: https://github.com/apache/incubator-superset/pull/3491#issuecomment-330399115 [](https://coveralls.io/builds/13327608) Coverage decreased (-0.005%) to 69.437% when pulling **4e767727028e8e4dc7ea2337d89ff94d9c05f184 on timifasubaa:remove_repeated_line** into **c3c9ceb1cc3fc70670257f8f652f083cde2ea14d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3491: Remove repeated line
coveralls commented on issue #3491: Remove repeated line URL: https://github.com/apache/incubator-superset/pull/3491#issuecomment-330399116 [](https://coveralls.io/builds/13327608) Coverage decreased (-0.005%) to 69.437% when pulling **4e767727028e8e4dc7ea2337d89ff94d9c05f184 on timifasubaa:remove_repeated_line** into **c3c9ceb1cc3fc70670257f8f652f083cde2ea14d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhunwicks opened a new pull request #3492: Initial commit of PandasConnector - see #3302
rhunwicks opened a new pull request #3492: Initial commit of PandasConnector - see #3302 URL: https://github.com/apache/incubator-superset/pull/3492 Here is an initial draft of PandasConnector for consideration, as discussed in #3302. It is not complete, but it shows the general approach. I have created contrib.tests.connectors which implements a BaseConnectorTestCase which I am using to make sure that the results returned by PandasConnector are consistent with those from SqlaTable. If we get to the point where this PR can be merged, then we will probably want to refactor to put BaseConnectorTestCase and SqlaConnectorTestCase into the main tests directory and just leave the PandasConnectorTestCase in the contrib directory. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3490: Remove repeated line
coveralls commented on issue #3490: Remove repeated line URL: https://github.com/apache/incubator-superset/pull/3490#issuecomment-330397223 [](https://coveralls.io/builds/13327470) Coverage decreased (-0.005%) to 69.437% when pulling **0f2b817c6d81e4ee3934ca75d54009430082bcea on timifasubaa:quick_fix** into **c3c9ceb1cc3fc70670257f8f652f083cde2ea14d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa closed pull request #3490: Remove repeated line
timifasubaa closed pull request #3490: Remove repeated line URL: https://github.com/apache/incubator-superset/pull/3490 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa opened a new pull request #3491: Remove repeated line
timifasubaa opened a new pull request #3491: Remove repeated line URL: https://github.com/apache/incubator-superset/pull/3491 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa opened a new pull request #3490: Remove repeated line
timifasubaa opened a new pull request #3490: Remove repeated line URL: https://github.com/apache/incubator-superset/pull/3490 Removed repeated line. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3474: [heatmap] account for bounds = 0
coveralls commented on issue #3474: [heatmap] account for bounds = 0 URL: https://github.com/apache/incubator-superset/pull/3474#issuecomment-330395133 [](https://coveralls.io/builds/13327369) Coverage remained the same at 69.442% when pulling **a59a0c83427985d336c2ecf64e5ce37142afbb7a on mistercrunch:heatmap_bounds** into **c3c9ceb1cc3fc70670257f8f652f083cde2ea14d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3480: Improve code quality
coveralls commented on issue #3480: Improve code quality URL: https://github.com/apache/incubator-superset/pull/3480#issuecomment-330394338 [](https://coveralls.io/builds/13327296) Coverage decreased (-0.01%) to 69.432% when pulling **edfc8590d9f8c0b48cebb3e8bed745705f332c47 on timifasubaa:improve_code_quality** into **c3c9ceb1cc3fc70670257f8f652f083cde2ea14d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3473: Feature: Paired t-test table visualization
coveralls commented on issue #3473: Feature: Paired t-test table visualization URL: https://github.com/apache/incubator-superset/pull/3473#issuecomment-330392550 [](https://coveralls.io/builds/13327122) Coverage increased (+0.1%) to 69.579% when pulling **35b466fa938e3de1a6aef769e7b7902db4728fc5 on Mogball:mogball/feature/paired-ttest-viz** into **c3c9ceb1cc3fc70670257f8f652f083cde2ea14d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3473: Feature: Paired t-test table visualization
coveralls commented on issue #3473: Feature: Paired t-test table visualization URL: https://github.com/apache/incubator-superset/pull/3473#issuecomment-330363790 [](https://coveralls.io/builds/13324873) Coverage decreased (-0.02%) to 69.424% when pulling **8328017c7183de6d129def67e824f5ea3a7ab97b on Mogball:mogball/feature/paired-ttest-viz** into **c3c9ceb1cc3fc70670257f8f652f083cde2ea14d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3473: Feature: Paired t-test table visualization
coveralls commented on issue #3473: Feature: Paired t-test table visualization URL: https://github.com/apache/incubator-superset/pull/3473#issuecomment-330363786 [](https://coveralls.io/builds/13324873) Coverage decreased (-0.02%) to 69.424% when pulling **8328017c7183de6d129def67e824f5ea3a7ab97b on Mogball:mogball/feature/paired-ttest-viz** into **c3c9ceb1cc3fc70670257f8f652f083cde2ea14d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhunwicks commented on issue #3302: Create a PandasDatasource
rhunwicks commented on issue #3302: Create a PandasDatasource URL: https://github.com/apache/incubator-superset/issues/3302#issuecomment-330360525 @mistercrunch when is the order of records returned by the `query` function significant? Looking at `SqlaTable.query()`, I think that: * if `columns` is set then `orderby` is used to determine the order * if `groupby` is set then the `main_metric_expr` is used (in descending order) to order the groups * if there are metrics (and therefore `columns == []`) but no `groupby` then there is no `order by` and the rows will be returned in the order of the SQL groups, which will include the `__timestamp` column even when `groupby == []`, Is it important that when `is_timeseries == True` the rows are returned in `__timestamp` order? I assume not, because then we have both `is_timeseries` and `groupby` then `SqlaTable` still returns the rows by `main_metrics_expr` in descending order, rather than by either `__timestamp` or `groupby`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhunwicks commented on issue #3302: Create a PandasDatasource
rhunwicks commented on issue #3302: Create a PandasDatasource URL: https://github.com/apache/incubator-superset/issues/3302#issuecomment-330360525 @mistercrunch when is the order of records returned by the `query` function significant? Looking at `SqlaTable.query()`, I think that: * if `columns` is set then `orderby` is used to determine the order * if 'groupby` is set then the `main_metric_expr` is used (in descending order) to order the groups * if there are metrics (and therefore `columns == []`) but no `groupby` then there is no `order by` and the rows will be returned in the order of the SQL groups, which will include the `__timestamp` column even when `groupby == []`, Is it important that when `is_timeseries == True` the rows are returned in `__timestamp` order? I assume not, because then we have both `is_timeseries` and `groupby` then `SqlaTable` still returns the rows by `main_metrics_expr` in descending order, rather than by either `__timestamp` or `groupby`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3473: Feature: Paired t-test table visualization
coveralls commented on issue #3473: Feature: Paired t-test table visualization URL: https://github.com/apache/incubator-superset/pull/3473#issuecomment-330358678 [](https://coveralls.io/builds/13324576) Coverage decreased (-0.02%) to 69.424% when pulling **8328017c7183de6d129def67e824f5ea3a7ab97b on Mogball:mogball/feature/paired-ttest-viz** into **c3c9ceb1cc3fc70670257f8f652f083cde2ea14d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3473: Feature: Paired t-test table visualization
coveralls commented on issue #3473: Feature: Paired t-test table visualization URL: https://github.com/apache/incubator-superset/pull/3473#issuecomment-330358680 [](https://coveralls.io/builds/13324576) Coverage decreased (-0.02%) to 69.424% when pulling **8328017c7183de6d129def67e824f5ea3a7ab97b on Mogball:mogball/feature/paired-ttest-viz** into **c3c9ceb1cc3fc70670257f8f652f083cde2ea14d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3473: Feature: Paired t-test table visualization
coveralls commented on issue #3473: Feature: Paired t-test table visualization URL: https://github.com/apache/incubator-superset/pull/3473#issuecomment-330354876 [](https://coveralls.io/builds/13324261) Coverage decreased (-0.02%) to 69.424% when pulling **5d47cc2b1ecfc2b3355ce2f8378527fc42797c64 on Mogball:mogball/feature/paired-ttest-viz** into **c3c9ceb1cc3fc70670257f8f652f083cde2ea14d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3473: Feature: Paired t-test table visualization
coveralls commented on issue #3473: Feature: Paired t-test table visualization URL: https://github.com/apache/incubator-superset/pull/3473#issuecomment-330354872 [](https://coveralls.io/builds/13324261) Coverage decreased (-0.02%) to 69.424% when pulling **5d47cc2b1ecfc2b3355ce2f8378527fc42797c64 on Mogball:mogball/feature/paired-ttest-viz** into **c3c9ceb1cc3fc70670257f8f652f083cde2ea14d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #3489: Publish Superset dashboard online and remote login
xrmx commented on issue #3489: Publish Superset dashboard online and remote login URL: https://github.com/apache/incubator-superset/issues/3489#issuecomment-330343176 You have to bind superset to something else than localhost (see superset runserver --help), or better put an http proxy like nginx before it. There should be plenty of examples of nginx proxying a flask application on the internet. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3488: Add option that enable or disable multi selection on Filter Box Component
coveralls commented on issue #3488: Add option that enable or disable multi selection on Filter Box Component URL: https://github.com/apache/incubator-superset/pull/3488#issuecomment-330331595 [](https://coveralls.io/builds/13322669) Coverage remained the same at 69.442% when pulling **7b7bfec20a2796668e2c7469283b5359b8ea78bd on ymatagne:add_mono_select_to_filter_box** into **c3c9ceb1cc3fc70670257f8f652f083cde2ea14d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3488: Add option that enable or disable multi selection on Filter Box Component
coveralls commented on issue #3488: Add option that enable or disable multi selection on Filter Box Component URL: https://github.com/apache/incubator-superset/pull/3488#issuecomment-330331595 [](https://coveralls.io/builds/13322669) Coverage decreased (-0.4%) to 69.082% when pulling **7b7bfec20a2796668e2c7469283b5359b8ea78bd on ymatagne:add_mono_select_to_filter_box** into **c3c9ceb1cc3fc70670257f8f652f083cde2ea14d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] idealworld opened a new issue #3489: Publish Superset dashboard online and remote login
idealworld opened a new issue #3489: Publish Superset dashboard online and remote login URL: https://github.com/apache/incubator-superset/issues/3489 - [x ] I have checked the superset logs for python stacktraces and included it here as text if any - [x ] I have reproduced the issue with at least the latest released version of superset - [x ] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version 0.19.1 ### Expected results from localhost:8088 to 192.xxx.x.x ### Explaination Hi Superset team, I apologize in advance if this seems to be a silly question to ask. I have superset running on my local linux (centos) and I would like to host it on this machine. Ideally, I would like to create an IP address, so people could remotely login to the superset dashboard that I published. I am really new at this and would appreciate any help or guidance. Thanks in advance. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3488: Add option that enable or disable multi selection on Filter Box Component
coveralls commented on issue #3488: Add option that enable or disable multi selection on Filter Box Component URL: https://github.com/apache/incubator-superset/pull/3488#issuecomment-330317326 [](https://coveralls.io/builds/13321811) Coverage remained the same at 69.442% when pulling **313088e1cfdc80bde603ef69488bfa68821c62ba on ymatagne:add_mono_select_to_filter_box** into **c3c9ceb1cc3fc70670257f8f652f083cde2ea14d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3488: Add option that enable or disable multi selection on Filter Box Component
coveralls commented on issue #3488: Add option that enable or disable multi selection on Filter Box Component URL: https://github.com/apache/incubator-superset/pull/3488#issuecomment-330317329 [](https://coveralls.io/builds/13321811) Coverage remained the same at 69.442% when pulling **313088e1cfdc80bde603ef69488bfa68821c62ba on ymatagne:add_mono_select_to_filter_box** into **c3c9ceb1cc3fc70670257f8f652f083cde2ea14d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3487: Bugfix: nvd3 tooltips do not disappear
coveralls commented on issue #3487: Bugfix: nvd3 tooltips do not disappear URL: https://github.com/apache/incubator-superset/pull/3487#issuecomment-330314425 [](https://coveralls.io/builds/13321667) Coverage remained the same at 69.442% when pulling **ca449f8087548f0286f7433af06f99fab3763bd8 on Mogball:mogball/bugfix/nvd3_tooltips** into **c3c9ceb1cc3fc70670257f8f652f083cde2ea14d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3487: Bugfix: nvd3 tooltips do not disappear
coveralls commented on issue #3487: Bugfix: nvd3 tooltips do not disappear URL: https://github.com/apache/incubator-superset/pull/3487#issuecomment-330314426 [](https://coveralls.io/builds/13321667) Coverage remained the same at 69.442% when pulling **ca449f8087548f0286f7433af06f99fab3763bd8 on Mogball:mogball/bugfix/nvd3_tooltips** into **c3c9ceb1cc3fc70670257f8f652f083cde2ea14d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ymatagne opened a new pull request #3488: Add option that enable or disable multi selection on Filter Box Component
ymatagne opened a new pull request #3488: Add option that enable or disable multi selection on Filter Box Component URL: https://github.com/apache/incubator-superset/pull/3488 Hi, I need to add mono select filter in my dashboard. So I added option field on Filter Box's Component for enable or disable multi choice. By default, Filter Box works with multi choice. Have a great day. Yan This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3478: Feature: option to disable dashboard refresh staggering
coveralls commented on issue #3478: Feature: option to disable dashboard refresh staggering URL: https://github.com/apache/incubator-superset/pull/3478#issuecomment-330310714 [](https://coveralls.io/builds/13321423) Coverage increased (+0.3%) to 69.442% when pulling **963b9cbd72eba86275cc6ca24a420b5cebc6734b on Mogball:mogball/feature/dashboard_loading** into **6fe93e18c79eeab470f0297014ad9453552e31aa on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3478: Feature: option to disable dashboard refresh staggering
coveralls commented on issue #3478: Feature: option to disable dashboard refresh staggering URL: https://github.com/apache/incubator-superset/pull/3478#issuecomment-330310715 [](https://coveralls.io/builds/13321423) Coverage increased (+0.3%) to 69.442% when pulling **963b9cbd72eba86275cc6ca24a420b5cebc6734b on Mogball:mogball/feature/dashboard_loading** into **6fe93e18c79eeab470f0297014ad9453552e31aa on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3478: Feature: option to disable dashboard refresh staggering
coveralls commented on issue #3478: Feature: option to disable dashboard refresh staggering URL: https://github.com/apache/incubator-superset/pull/3478#issuecomment-330310713 [](https://coveralls.io/builds/13321423) Coverage increased (+0.3%) to 69.442% when pulling **963b9cbd72eba86275cc6ca24a420b5cebc6734b on Mogball:mogball/feature/dashboard_loading** into **6fe93e18c79eeab470f0297014ad9453552e31aa on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Mogball opened a new pull request #3487: Bugfix: nvd3 tooltips do not disappear
Mogball opened a new pull request #3487: Bugfix: nvd3 tooltips do not disappear URL: https://github.com/apache/incubator-superset/pull/3487 Addresses https://github.com/apache/incubator-superset/issues/3471 NVD3 tooltips remain in DOM when switching to another viz in explore view, and sometimes they aren't hidden. Added a `MutationObserver` to detect viz type change and then perform cleanup of tooltips. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dmigo commented on issue #2148: Impersonate database user when running queries
dmigo commented on issue #2148: Impersonate database user when running queries URL: https://github.com/apache/incubator-superset/issues/2148#issuecomment-330305524 We may close it now, I guess. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #3434: Feature/Fix: times_series limit for Druid
mistercrunch closed pull request #3434: Feature/Fix: times_series limit for Druid URL: https://github.com/apache/incubator-superset/pull/3434 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #3480: Improve code quality
mistercrunch commented on issue #3480: Improve code quality URL: https://github.com/apache/incubator-superset/pull/3480#issuecomment-330299282 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Mogball commented on issue #3478: Feature: option to disable dashboard refresh staggering
Mogball commented on issue #3478: Feature: option to disable dashboard refresh staggering URL: https://github.com/apache/incubator-superset/pull/3478#issuecomment-330297017 @mistercrunch Added to docs This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #3486: Getting datatype with its dialect
mistercrunch closed pull request #3486: Getting datatype with its dialect URL: https://github.com/apache/incubator-superset/pull/3486 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #3404: Feature: "Impersonate user" setting on Datasource
mistercrunch closed pull request #3404: Feature: "Impersonate user" setting on Datasource URL: https://github.com/apache/incubator-superset/pull/3404 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #3484: Create CsvResponse to manage csv exports encoding
mistercrunch closed pull request #3484: Create CsvResponse to manage csv exports encoding URL: https://github.com/apache/incubator-superset/pull/3484 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #3469: Improve the installation docs
mistercrunch closed pull request #3469: Improve the installation docs URL: https://github.com/apache/incubator-superset/pull/3469 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #3478: Feature: option to disable dashboard refresh staggering
mistercrunch commented on issue #3478: Feature: option to disable dashboard refresh staggering URL: https://github.com/apache/incubator-superset/pull/3478#issuecomment-330283658 These 2 new configuration elements (`stagger_refresh`, `stagger_refresh`) need to be documented. Currently the best place for that is `faq.rst` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3486: Getting datatype with its dialect
coveralls commented on issue #3486: Getting datatype with its dialect URL: https://github.com/apache/incubator-superset/pull/3486#issuecomment-330283532 [](https://coveralls.io/builds/13319989) Coverage remained the same at 69.142% when pulling **ff5d56f5689768842ca164f7fa169693dc7df213 on datinho:dialect_types** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #3475: viz: fix reversed stats_logger label
mistercrunch closed pull request #3475: viz: fix reversed stats_logger label URL: https://github.com/apache/incubator-superset/pull/3475 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #3477: docs: athena can be installed from pypi
mistercrunch closed pull request #3477: docs: athena can be installed from pypi URL: https://github.com/apache/incubator-superset/pull/3477 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #3476: Miscvizcleanups
mistercrunch closed pull request #3476: Miscvizcleanups URL: https://github.com/apache/incubator-superset/pull/3476 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #3486: Getting datatype with its dialect
xrmx commented on issue #3486: Getting datatype with its dialect URL: https://github.com/apache/incubator-superset/pull/3486#issuecomment-330279944 It's not clear if it does fix the issue for you? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] datinho opened a new pull request #3486: Getting datatype with its dialect
datinho opened a new pull request #3486: Getting datatype with its dialect URL: https://github.com/apache/incubator-superset/pull/3486 Related to issue https://github.com/apache/incubator-superset/issues/2382 to fix datatype with relative dialect. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] datinho commented on issue #2382: impala can't render element of type
datinho commented on issue #2382: impala can't render element of type URL: https://github.com/apache/incubator-superset/issues/2382#issuecomment-330275099 On thread https://github.com/zzzeek/sqlalchemy/pull/381 I've simulated the code to retrieve the 'datatype'. I'll produce a pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #3485: ImportError: cannot import TableModelView from superset.connectors.sqla.views in superset.views.core.py
xrmx commented on issue #3485: ImportError: cannot import TableModelView from superset.connectors.sqla.views in superset.views.core.py URL: https://github.com/apache/incubator-superset/issues/3485#issuecomment-330254177 What are you trying to do? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Yuanmu93 opened a new issue #3485: ImportError: cannot import TableModelView from superset.connectors.sqla.views in superset.views.core.py
Yuanmu93 opened a new issue #3485: ImportError: cannot import TableModelView from superset.connectors.sqla.views in superset.views.core.py URL: https://github.com/apache/incubator-superset/issues/3485 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and included it here as text if any - [ ] I have reproduced the issue with at least the latest released version of superset - [ ] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version 0.19.1 ### Content I am going to import TableModelView from **superset.connectors.sqla.views** in **superset.views.core.py**. However, I get a ImportError: can not import name 'TableModelView'. How can I fix it, Thanks a lot! ### Expected results Should import TableModelView. ### Actual results Getting ImportError: can not import name TableModelView. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3484: Create CsvResponse to manage csv exports encoding
coveralls commented on issue #3484: Create CsvResponse to manage csv exports encoding URL: https://github.com/apache/incubator-superset/pull/3484#issuecomment-330252062 [](https://coveralls.io/builds/13317906) Coverage increased (+0.009%) to 69.151% when pulling **0edfc923b2d816537ad1aabedba7fb73f67b9b9c on JulieRossi:manage_csv_encoding** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] RobinDavid commented on issue #3483: ModelView flask-appbuilder "style" on a separate db (SQLALCHEMY_BINDS)
RobinDavid commented on issue #3483: ModelView flask-appbuilder "style" on a separate db (SQLALCHEMY_BINDS) URL: https://github.com/apache/incubator-superset/issues/3483#issuecomment-330245603 I am not asking help for flask-appbuilder. It works fine on flask-appbuilder. I am trying to integrate standard ModelView in superset which is based on flask-appbuilder. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] monothorn commented on issue #2173: error during installation
monothorn commented on issue #2173: error during installation URL: https://github.com/apache/incubator-superset/issues/2173#issuecomment-330229418 For those it still didn't work, try using the flag --no-cache-dir as shown `pip --no-cache-dir install superset` hope it helps! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] macfly1202 closed issue #3482: r
macfly1202 closed issue #3482: r URL: https://github.com/apache/incubator-superset/issues/3482 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] macfly1202 opened a new issue #3482: r
macfly1202 opened a new issue #3482: r URL: https://github.com/apache/incubator-superset/issues/3482 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and included it here as text if any - [ ] I have reproduced the issue with at least the latest released version of superset - [ ] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version ### Expected results ### Actual results ### Steps to reproduce This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] macfly1202 commented on issue #3482: r
macfly1202 commented on issue #3482: r URL: https://github.com/apache/incubator-superset/issues/3482#issuecomment-330213878 Faulty keyboard typing - to delete This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] macfly1202 closed issue #3482: r
macfly1202 closed issue #3482: r URL: https://github.com/apache/incubator-superset/issues/3482 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] macfly1202 opened a new issue #3482: r
macfly1202 opened a new issue #3482: r URL: https://github.com/apache/incubator-superset/issues/3482 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and included it here as text if any - [ ] I have reproduced the issue with at least the latest released version of superset - [ ] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version ### Expected results ### Actual results ### Steps to reproduce This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhunwicks commented on issue #617: expression in table columns is converted to literal column twice
rhunwicks commented on issue #617: expression in table columns is converted to literal column twice URL: https://github.com/apache/incubator-superset/issues/617#issuecomment-330206275 As @yejianye pointed out this issue also breaks 'week' and 'month' time grains on SQLite but the fix that was applied only applies to column expressions, so I think that time grains are still broken for SQLite. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Jie-Yang opened a new issue #3481: dashboard is missing in the dashboards list, but accessible via link.
Jie-Yang opened a new issue #3481: dashboard is missing in the dashboards list, but accessible via link. URL: https://github.com/apache/incubator-superset/issues/3481 A dashboard is missing in the dashboard list, but user can access via the dashboard link. I have config a user in Superset only have access to certain dashboards, but these dashboards are not listed out in the dashboard lists, even the user can access via link. I must do something wrong, but have no clue where? ### Superset version 0.19.1 ### Expected results Dashboard appears in the dashboards list ### Actual results One dashboard is missing from the list, but user can access it by hitting the link of the dashboard directly. I have no clue how this happen, please let me know if you have any recommendations? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] JulieRossi commented on issue #1519: Choose encoding when export csv
JulieRossi commented on issue #1519: Choose encoding when export csv URL: https://github.com/apache/incubator-superset/issues/1519#issuecomment-330189604 Yes I noticed this too ... I am planning on issuing a new PR (today) to fix this using flask Response encoding. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] JulieRossi commented on issue #1519: Choose encoding when export csv
JulieRossi commented on issue #1519: Choose encoding when export csv URL: https://github.com/apache/incubator-superset/issues/1519#issuecomment-330189604 Yes I noticed this too ... I am planning on issuing a new PR to fix this using flask Response encoding. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ashdaka commented on issue #1519: Choose encoding when export csv
ashdaka commented on issue #1519: Choose encoding when export csv URL: https://github.com/apache/incubator-superset/issues/1519#issuecomment-330187976 I tried to adding the CSV_ENCODING in config.py like #3441, In Python3.5 it doesn't work?however in Python2.7 it works well. It seems that Pandas IO tool "to_csv" ignores encoding argument in Python3. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #2382: impala can't render element of type
xrmx commented on issue #2382: impala can't render element of type URL: https://github.com/apache/incubator-superset/issues/2382#issuecomment-330179718 @datinho if the sqlalchemy backend names itself `impala` the correct engine spec would be used. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] datinho commented on issue #2382: impala can't render element of type
datinho commented on issue #2382: impala can't render element of type
URL:
https://github.com/apache/incubator-superset/issues/2382#issuecomment-330178228
When a table is added and has type like INT or STRING the datatype returned
is 'UNKNOWN'
`datatype = "{}".format(col.type).upper()`
It seems the format don't use the 'impyla' dialect when the SQLAlchemy URI
prefix is 'impala://'
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] xrmx commented on a change in pull request #3480: Improve code quality
xrmx commented on a change in pull request #3480: Improve code quality URL: https://github.com/apache/incubator-superset/pull/3480#discussion_r139346953 ## File path: superset/__init__.py ## @@ -20,14 +20,12 @@ from superset.connectors.connector_registry import ConnectorRegistry from superset import utils, config # noqa - Review comment: Doesn't look like an improvement to me This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #3479: hi,i cannot pip install pymssql on windows ,please help me ,thanks a lot .
xrmx commented on issue #3479: hi,i cannot pip install pymssql on windows ,please help me ,thanks a lot . URL: https://github.com/apache/incubator-superset/issues/3479#issuecomment-330142144 You should ask to the pymssql people, not here. FYI superset is not supported on windows. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
