[GitHub] vnnw opened a new issue #3516: How to make Table View/ Pivot Table order by time?

2017-09-22 Thread git 
vnnw opened a new issue #3516: How to make Table View/ Pivot Table order by 
time?
URL: https://github.com/apache/incubator-superset/issues/3516
 
 
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [ ] I have checked the superset logs for python stacktraces and included 
it here as text if any
   - [ ] I have reproduced the issue with at least the latest released version 
of superset
   - [ ] I have checked the issue tracker for the same issue and I haven't 
found one similar
   
   
   ### Superset version
   0.19.1
   
   ### Expected results
   Table View displays data table order by _timestamp instead of metrics[0] by 
default, or allow us to customize it.
   
   ### Actual results
   order by metrics[0] and no options to change it.
   
   ### Steps to reproduce
   Create a table view/ pivot table, and in GROUP BY section check Include 
Time. See an example as below (I have to click on __timestamp to make the chart 
order by time):
   
   The default display:
   
![image](https://user-images.githubusercontent.com/4979571/30769073-6cd674d8-9fd7-11e7-9125-237ee16ce437.png)
   
   What I expect:
   
   
![image](https://user-images.githubusercontent.com/4979571/30769044-ef3a3690-9fd6-11e7-8a0b-a341aa3cb028.png)
   
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Mogball opened a new issue #3515: More control over Druid metadata refresh features

2017-09-22 Thread git 
Mogball opened a new issue #3515: More control over Druid metadata refresh 
features
URL: https://github.com/apache/incubator-superset/issues/3515
 
 
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [x] I have checked the superset logs for python stacktraces and included 
it here as text if any
   - [x] I have reproduced the issue with at least the latest released version 
of superset
   - [x] I have checked the issue tracker for the same issue and I haven't 
found one similar
   
   
   ### Superset version
   0.19.3
   
   Periodic metadata refreshing was mentioned in 
https://github.com/apache/incubator-superset/issues/619.
   
   There should also be a feature to only check for new Druid datasources, 
instead of only being able to force refresh everything. A small `refresh` 
button next to each datasource would also be nice.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] stevekaeser commented on issue #2731: Give users the rights to change their password

2017-09-22 Thread git 
stevekaeser commented on issue #2731: Give users the rights to change their 
password
URL: 
https://github.com/apache/incubator-superset/issues/2731#issuecomment-331557102
 
 
   I was able to work around this issue by creating a separate role that has 
these permissions:
   
   ```
   can this form post on ResetMyPasswordView,
   can this form get on ResetMyPasswordView,
   can this form post on UserInfoEditView,
   can this form get on UserInfoEditView,
   resetmypassword on UserDBModelView,
   can edit on UserDBModelView,
   can userinfo on UserDBModelView,
   userinfoedit on UserDBModelView
   ```
   Then I added that role to all the non-admin users which allowed them to 
view/edit their profile and change their own passwords.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3513: Feature: query string API endpoint

2017-09-22 Thread git 
coveralls commented on issue #3513: Feature: query string API endpoint
URL: 
https://github.com/apache/incubator-superset/pull/3513#issuecomment-331550457
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13395634/badge)](https://coveralls.io/builds/13395634)
   
   Coverage increased (+0.3%) to 69.879% when pulling 
**7fa4137a73f64be1e6829f668ad162b25473c1db on 
Mogball:mogball/feature/query_apiendpoint** into 
**255ea699770a98b8406a516d44fc7eac47d45ab6 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3513: Feature: query string API endpoint

2017-09-22 Thread git 
coveralls commented on issue #3513: Feature: query string API endpoint
URL: 
https://github.com/apache/incubator-superset/pull/3513#issuecomment-331546765
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13395359/badge)](https://coveralls.io/builds/13395359)
   
   Coverage increased (+0.3%) to 69.879% when pulling 
**7fa4137a73f64be1e6829f668ad162b25473c1db on 
Mogball:mogball/feature/query_apiendpoint** into 
**255ea699770a98b8406a516d44fc7eac47d45ab6 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3513: Feature: query string API endpoint

2017-09-22 Thread git 
coveralls commented on issue #3513: Feature: query string API endpoint
URL: 
https://github.com/apache/incubator-superset/pull/3513#issuecomment-331546763
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13395359/badge)](https://coveralls.io/builds/13395359)
   
   Coverage increased (+0.3%) to 69.879% when pulling 
**7fa4137a73f64be1e6829f668ad162b25473c1db on 
Mogball:mogball/feature/query_apiendpoint** into 
**255ea699770a98b8406a516d44fc7eac47d45ab6 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3513: Feature: query string API endpoint

2017-09-22 Thread git 
coveralls commented on issue #3513: Feature: query string API endpoint
URL: 
https://github.com/apache/incubator-superset/pull/3513#issuecomment-331546766
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13395359/badge)](https://coveralls.io/builds/13395359)
   
   Coverage increased (+0.3%) to 69.879% when pulling 
**7fa4137a73f64be1e6829f668ad162b25473c1db on 
Mogball:mogball/feature/query_apiendpoint** into 
**255ea699770a98b8406a516d44fc7eac47d45ab6 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3509: Add Table performance improvements

2017-09-22 Thread git 
coveralls commented on issue #3509: Add Table performance improvements
URL: 
https://github.com/apache/incubator-superset/pull/3509#issuecomment-331544436
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13395254/badge)](https://coveralls.io/builds/13395254)
   
   Coverage increased (+0.02%) to 69.558% when pulling 
**5451ebe1799fea401b39472c07093c3a5ec680bb on 
Mogball:mogball/bugfix/add_table** into 
**9af34ba51cdb23a2970e968d0cbdee82778c6799 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3509: Add Table performance improvements

2017-09-22 Thread git 
coveralls commented on issue #3509: Add Table performance improvements
URL: 
https://github.com/apache/incubator-superset/pull/3509#issuecomment-331544433
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13395254/badge)](https://coveralls.io/builds/13395254)
   
   Coverage increased (+0.02%) to 69.558% when pulling 
**5451ebe1799fea401b39472c07093c3a5ec680bb on 
Mogball:mogball/bugfix/add_table** into 
**9af34ba51cdb23a2970e968d0cbdee82778c6799 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3467: allow user click-and-update slice name in dashboard view

2017-09-22 Thread git 
coveralls commented on issue #3467: allow user click-and-update slice name in 
dashboard view
URL: 
https://github.com/apache/incubator-superset/pull/3467#issuecomment-331543815
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13395212/badge)](https://coveralls.io/builds/13395212)
   
   Coverage decreased (-0.006%) to 69.534% when pulling 
**79d5aa36c243f45a2424ad197e06e0e84ff2baa7 on 
graceguo-supercat:gg-ChangeChartTitleInDashboard** into 
**255ea699770a98b8406a516d44fc7eac47d45ab6 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3467: allow user click-and-update slice name in dashboard view

2017-09-22 Thread git 
coveralls commented on issue #3467: allow user click-and-update slice name in 
dashboard view
URL: 
https://github.com/apache/incubator-superset/pull/3467#issuecomment-331543813
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13395212/badge)](https://coveralls.io/builds/13395212)
   
   Coverage decreased (-0.006%) to 69.534% when pulling 
**79d5aa36c243f45a2424ad197e06e0e84ff2baa7 on 
graceguo-supercat:gg-ChangeChartTitleInDashboard** into 
**255ea699770a98b8406a516d44fc7eac47d45ab6 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3467: allow user click-and-update slice name in dashboard view

2017-09-22 Thread git 
coveralls commented on issue #3467: allow user click-and-update slice name in 
dashboard view
URL: 
https://github.com/apache/incubator-superset/pull/3467#issuecomment-331543816
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13395212/badge)](https://coveralls.io/builds/13395212)
   
   Coverage decreased (-0.006%) to 69.534% when pulling 
**79d5aa36c243f45a2424ad197e06e0e84ff2baa7 on 
graceguo-supercat:gg-ChangeChartTitleInDashboard** into 
**255ea699770a98b8406a516d44fc7eac47d45ab6 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3467: allow user click-and-update slice name in dashboard view

2017-09-22 Thread git 
coveralls commented on issue #3467: allow user click-and-update slice name in 
dashboard view
URL: 
https://github.com/apache/incubator-superset/pull/3467#issuecomment-331543814
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13395212/badge)](https://coveralls.io/builds/13395212)
   
   Coverage decreased (-0.006%) to 69.534% when pulling 
**79d5aa36c243f45a2424ad197e06e0e84ff2baa7 on 
graceguo-supercat:gg-ChangeChartTitleInDashboard** into 
**255ea699770a98b8406a516d44fc7eac47d45ab6 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Mogball closed pull request #3513: Feature: query string API endpoint

2017-09-22 Thread git 
Mogball closed pull request #3513: Feature: query string API endpoint
URL: https://github.com/apache/incubator-superset/pull/3513
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Mogball opened a new pull request #3513: Feature: query string API endpoint

2017-09-22 Thread git 
Mogball opened a new pull request #3513: Feature: query string API endpoint
URL: https://github.com/apache/incubator-superset/pull/3513
 
 
   Exposes an endpoint `superset/slices//query` that returns the 
corresponding query string and language for that slice in the form `{ query: 
querystring, language: querylang }`, which would be seen when clicking on 
`Query` in the explore slice view.
   
   Also includes some unit tests.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] fabianmenges commented on issue #3512: Feature: Making data gaps visible in line charts by inserting zeros

2017-09-22 Thread git 
fabianmenges commented on issue #3512: Feature: Making data gaps visible in 
line charts by inserting zeros
URL: 
https://github.com/apache/incubator-superset/pull/3512#issuecomment-331530901
 
 
   K, I'll take care of this and bring it down to the server side, should be 
able to get something going by end of next week.
   
   We probably need to have a function to translate the time grains to pandas 
frequencies (like the one I wrote in JS to ms) because we also need to cover 
Druid and the granularities for Druid are handled completely independent. Even 
better would probably be to unify the concept of `druid granularity`/`pandas 
frequencies (offset-aliases)`/`sql time grain` because they are all used almost 
interchangeably within superset.
   
   Apart from that I don't think that my function would have problems with time 
zones since it just looks at raw milliseconds since epoch...
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Development environment question

2017-09-22 Thread COLLIER, THOMAS CERVANTES [AG/1005] 
I’m having trouble figuring out how to run superset in a manner that I can 
debug the python code on my local installation.  Any documentation out there?
The only instructions if came across is how to build and deploy superset but 
not how to setup a development environment.

Thomas Cervantes Collier
Scientific Visualization Web Developer
thomas.cervantes.coll...@monsanto.com
(636) 737-2623

This email and any attachments were sent from a Monsanto email account and may 
contain confidential and/or privileged information. If you are not the intended 
recipient, please contact the sender and delete this email and any attachments 
immediately. Any unauthorized use, including disclosing, printing, storing, 
copying or distributing this email, is prohibited. All emails and attachments 
sent to or from Monsanto email accounts may be subject to monitoring, reading, 
and archiving by Monsanto, including its affiliates and subsidiaries, as 
permitted by applicable law. Thank you.

[GitHub] Mogball commented on issue #3513: Feature: query string API endpoint

2017-09-22 Thread git 
Mogball commented on issue #3513: Feature: query string API endpoint
URL: 
https://github.com/apache/incubator-superset/pull/3513#issuecomment-331519325
 
 
   As for the use case: we want to be able to plug the generated query into 
other systems.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3509: Add Table performance improvements

2017-09-22 Thread git 
coveralls commented on issue #3509: Add Table performance improvements
URL: 
https://github.com/apache/incubator-superset/pull/3509#issuecomment-331518392
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13393367/badge)](https://coveralls.io/builds/13393367)
   
   Coverage increased (+0.02%) to 69.558% when pulling 
**6909de654e681cb03393c96065c8e25df63dfb85 on 
Mogball:mogball/bugfix/add_table** into 
**9af34ba51cdb23a2970e968d0cbdee82778c6799 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Mogball commented on issue #3513: Feature: query string API endpoint

2017-09-22 Thread git 
Mogball commented on issue #3513: Feature: query string API endpoint
URL: 
https://github.com/apache/incubator-superset/pull/3513#issuecomment-331518075
 
 
   @mistercrunch is it alright if I just move the logic into a separate 
function? Redirecting to `/explore_json//` from 
`/slice//query/` would mean calling `get_viz` a second time, which 
makes another database call.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Mogball commented on a change in pull request #3509: Add Table performance improvements

2017-09-22 Thread git 
Mogball commented on a change in pull request #3509: Add Table performance 
improvements
URL: 
https://github.com/apache/incubator-superset/pull/3509#discussion_r140553437
 
 

 ##
 File path: superset/models/core.py
 ##
 @@ -743,6 +744,16 @@ def get_perm(self):
 return (
 "[{obj.database_name}].(id:{obj.id})").format(obj=self)
 
+def has_table(self, table):
+engine = self.get_sqla_engine()
+return engine.dialect.has_table(
+engine, table.table_name, table.schema or None)
+
+def get_dialect(self):
+sqla_url = url.make_url(self.sqlalchemy_uri_decrypted)
+entrypoint = sqla_url._get_entrypoint()
 
 Review comment:
   Oh, turns out we can just call `sqla_url.get_dialect()`
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Mogball commented on a change in pull request #3509: Add Table performance improvements

2017-09-22 Thread git 
Mogball commented on a change in pull request #3509: Add Table performance 
improvements
URL: 
https://github.com/apache/incubator-superset/pull/3509#discussion_r140552810
 
 

 ##
 File path: superset/models/core.py
 ##
 @@ -743,6 +744,16 @@ def get_perm(self):
 return (
 "[{obj.database_name}].(id:{obj.id})").format(obj=self)
 
+def has_table(self, table):
+engine = self.get_sqla_engine()
+return engine.dialect.has_table(
+engine, table.table_name, table.schema or None)
+
+def get_dialect(self):
+sqla_url = url.make_url(self.sqlalchemy_uri_decrypted)
+entrypoint = sqla_url._get_entrypoint()
 
 Review comment:
   Sounds good. I was looking for a way to cache the `sqla_engine` because that 
function does get called frequently.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #3509: Add Table performance improvements

2017-09-22 Thread git 
mistercrunch commented on a change in pull request #3509: Add Table performance 
improvements
URL: 
https://github.com/apache/incubator-superset/pull/3509#discussion_r140542853
 
 

 ##
 File path: superset/models/core.py
 ##
 @@ -743,6 +744,16 @@ def get_perm(self):
 return (
 "[{obj.database_name}].(id:{obj.id})").format(obj=self)
 
+def has_table(self, table):
+engine = self.get_sqla_engine()
+return engine.dialect.has_table(
+engine, table.table_name, table.schema or None)
+
+def get_dialect(self):
+sqla_url = url.make_url(self.sqlalchemy_uri_decrypted)
+entrypoint = sqla_url._get_entrypoint()
 
 Review comment:
   also for the sake of moving forward I don't mind if you just call 
`get_sqla_engine` here and save the `sqla_engine` memoized property for another 
PR
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #3509: Add Table performance improvements

2017-09-22 Thread git 
mistercrunch commented on a change in pull request #3509: Add Table performance 
improvements
URL: 
https://github.com/apache/incubator-superset/pull/3509#discussion_r140542551
 
 

 ##
 File path: superset/models/core.py
 ##
 @@ -743,6 +744,16 @@ def get_perm(self):
 return (
 "[{obj.database_name}].(id:{obj.id})").format(obj=self)
 
+def has_table(self, table):
+engine = self.get_sqla_engine()
+return engine.dialect.has_table(
+engine, table.table_name, table.schema or None)
+
+def get_dialect(self):
+sqla_url = url.make_url(self.sqlalchemy_uri_decrypted)
+entrypoint = sqla_url._get_entrypoint()
 
 Review comment:
   check out the `@memoize` decorator in `superset.utils`
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #3509: Add Table performance improvements

2017-09-22 Thread git 
mistercrunch commented on a change in pull request #3509: Add Table performance 
improvements
URL: 
https://github.com/apache/incubator-superset/pull/3509#discussion_r140542113
 
 

 ##
 File path: superset/models/core.py
 ##
 @@ -743,6 +744,16 @@ def get_perm(self):
 return (
 "[{obj.database_name}].(id:{obj.id})").format(obj=self)
 
+def has_table(self, table):
+engine = self.get_sqla_engine()
+return engine.dialect.has_table(
+engine, table.table_name, table.schema or None)
+
+def get_dialect(self):
+sqla_url = url.make_url(self.sqlalchemy_uri_decrypted)
+entrypoint = sqla_url._get_entrypoint()
 
 Review comment:
   I hate calling private functions in external libs though... there's no 
guarantees as to whether the api may change in minor version changes.
   
   To mitigate the cost we could change the use of `get_sqla_engine` by using a 
cached `engine` `@property`. I think it's only a matter of adding a decorator.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #3512: Feature: Making data gaps visible in line charts by inserting zeros

2017-09-22 Thread git 
mistercrunch commented on issue #3512: Feature: Making data gaps visible in 
line charts by inserting zeros
URL: 
https://github.com/apache/incubator-superset/pull/3512#issuecomment-331498665
 
 
   An extra point for pandas vs having our own function for this is that pandas 
(from memory) deals nicely with timezones, such that when we want to start 
thinking about comprehensive time zone management pandas may do some of that 
magic too.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #3512: Feature: Making data gaps visible in line charts by inserting zeros

2017-09-22 Thread git 
mistercrunch commented on issue #3512: Feature: Making data gaps visible in 
line charts by inserting zeros
URL: 
https://github.com/apache/incubator-superset/pull/3512#issuecomment-331498665
 
 
   An extra point for pandas vs having our own JS function for this is that 
pandas (from memory) deals nicely with timezones, such that when we want to 
start thinking about comprehensive time zone management pandas may do some of 
that magic too.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #3512: Feature: Making data gaps visible in line charts by inserting zeros

2017-09-22 Thread git 
mistercrunch commented on issue #3512: Feature: Making data gaps visible in 
line charts by inserting zeros
URL: 
https://github.com/apache/incubator-superset/pull/3512#issuecomment-331497859
 
 
   I like the fact that "insert zeros" as a trigger is much more intuitive than 
"Resampling". I'm thinking server side on this one. Just because pandas is so 
simple for this.
   
   See how time grain is fairly loosely defined at the moment? 
https://github.com/apache/incubator-superset/blob/master/superset/db_engine_specs.py#L192
   
   One easy approach would be add a corresponding pandas `freq` to each time 
grain. Knowing this, it would be easy to resample whenever needed.
   
   "Resampling" came before the "Time-Grain"  concept and is now 
confusing/obsolete. I feel like we could trigger the pandas resampling based on 
time grain configuration with a simple checkbox.
   
   In that context, there may be some very few specific use cases where people 
may want the extra flexibility of resampling with specific fill patterns but I 
wouldn't be against deprecating the feature.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #3513: Feature: query string API endpoint

2017-09-22 Thread git 
mistercrunch commented on issue #3513: Feature: query string API endpoint
URL: 
https://github.com/apache/incubator-superset/pull/3513#issuecomment-331495310
 
 
   There's a bit of duplication of logic with what is going on here: 
https://github.com/apache/incubator-superset/blob/master/superset/views/core.py#L972
 . What is the use-case for this endpoint?
   
   Perhaps we can add corresponding routing for `slice_id` querystring instead 
of `form_data`. I think we do it with redirect logic in some places, may work 
for you, or we could avoid redirecting and just serve from that url.
   
   One behavior that we want to have/preserve is around being able to reference 
a slice and override some elements easily.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] bauchgefuhl opened a new issue #3514: Customizable and simplified interface for non-developers as a new dashboard

2017-09-22 Thread git 
bauchgefuhl opened a new issue #3514: Customizable and simplified interface for 
non-developers as a new dashboard
URL: https://github.com/apache/incubator-superset/issues/3514
 
 
   I found out that Superset lacks one feature - creating dashboards with 
simplified SQL Lab-like interface in them so a person with absolutely no coding 
skills (e.g. sales managers) could use it themselves. 
   
   For example, they might choose a predefined table (maybe joined in a 
specific way) with understandable name (a developer can create them) and type, 
for example, the range of dates, choose a company to list information about it 
in this time range. I mean, I want a tool for a developer to create specific 
interface with fields with customizable names. Kind of interface constructor 
with ability to connect specific field to specific column of specific table.
   
   We're very satisfied with Superset possibilities, though this feature is not 
presented though we really need it.
   Unfortunately, I only have an idea but not a suitable experience to insert 
this feature in the app architecture myself, 'cause my coding expertise differs 
from web development :)
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] abhijain1351 commented on issue #2920: How to configure multiple brokers for druid in superset

2017-09-22 Thread git 
abhijain1351 commented on issue #2920: How to configure multiple brokers for 
druid in superset
URL: 
https://github.com/apache/incubator-superset/issues/2920#issuecomment-331369061
 
 
   I'm trying to set up a druid router that sends queries to brokers that 
belong to different tiers based on query time interval. How does router figure 
out which tier that query should go to?
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3513: Feature: query string API endpoint

2017-09-22 Thread git 
coveralls commented on issue #3513: Feature: query string API endpoint
URL: 
https://github.com/apache/incubator-superset/pull/3513#issuecomment-331359370
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13384226/badge)](https://coveralls.io/builds/13384226)
   
   Coverage increased (+0.3%) to 69.814% when pulling 
**b264960dbc98255f5f5726770bab1d1af4babf10 on 
Mogball:mogball/feature/query_apiendpoint** into 
**9af34ba51cdb23a2970e968d0cbdee82778c6799 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services