[GitHub] vinay87 opened a new issue #3573: Heatmap Tooltip disappears under the slice's header.

[git]

vinay87 opened a new issue #3573: Heatmap Tooltip disappears under the slice's 
header.
URL: https://github.com/apache/incubator-superset/issues/3573
 
 
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [ x] I have checked the superset logs for python stacktraces and included 
it here as text if any
   - [ x] I have reproduced the issue with at least the latest released version 
of superset
   - [ x] I have checked the issue tracker for the same issue and I haven't 
found one similar
   
   
   ### Superset version
   0.20.0 Python 3.6
   
   ### Expected results
   I wanted to look at the heatmap values, so I assumed that the tooltip would 
appear over the header bar.
   
   ### Actual results
   
   It appears under it, I've attached a screenshot here.
   
   
   ### Steps to reproduce
   
![superset_heatmap_tooltip](https://user-images.githubusercontent.com/11478411/31109230-21355aba-a81c-11e7-8d0d-0b63dd146c57.png)
   
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed pull request #3572: After saving slice fixing redirect

[git]

mistercrunch closed pull request #3572: After saving slice fixing redirect
URL: https://github.com/apache/incubator-superset/pull/3572
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3572: After saving slice fixing redirect

[git]

coveralls commented on issue #3572: After saving slice fixing redirect
URL: 
https://github.com/apache/incubator-superset/pull/3572#issuecomment-333711120
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13536974/badge)](https://coveralls.io/builds/13536974)
   
   Coverage increased (+0.004%) to 70.145% when pulling 
**5723b14e20b60c3902361498ba4fdc24f4caac84 on 
michellethomas:mt_fix_save_slice** into 
**f8cc05b54edbd119bccc26837ac99f6c3d6078d1 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #3571: Feature: Copy-to-clipboard button in View Query

[git]

mistercrunch commented on issue #3571: Feature: Copy-to-clipboard button in 
View Query
URL: 
https://github.com/apache/incubator-superset/pull/3571#issuecomment-333709721
 
 
   We already have some component for this. I'd rather be consistent and always 
our component, or always use `react-copy-to-clipboard` . Not 2 different ways 
to do the same thing...
   
   
https://github.com/apache/incubator-superset/blob/master/superset/assets/javascripts/components/CopyToClipboard.jsx
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] michellethomas opened a new pull request #3572: After saving slice fixing redirect

[git]

michellethomas opened a new pull request #3572: After saving slice fixing 
redirect
URL: https://github.com/apache/incubator-superset/pull/3572
 
 
   When saving a slice and going to a dashboard, the redirect to the dashboard 
url is breaking. We were redirecting to `data.slice.slice_url` but data was a 
string when goto_dashboard is true.
   
   @graceguo-supercat was thinking it may be useful to always return the full 
slice object, but I can also just return `{'dashboard': dash.url}` instead of 
adding it to the response.
   
   Thanks for the help @graceguo-supercat 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kkalyan closed issue #3048: Feature Request: Display Label+Percentage in Pie Charts

[git]

kkalyan closed issue #3048: Feature Request: Display Label+Percentage in Pie 
Charts
URL: https://github.com/apache/incubator-superset/issues/3048
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3533: [WIP] Latest import csv

[git]

coveralls commented on issue #3533: [WIP] Latest import csv
URL: 
https://github.com/apache/incubator-superset/pull/3533#issuecomment-333701994
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13536426/badge)](https://coveralls.io/builds/13536426)
   
   Coverage decreased (-0.8%) to 69.384% when pulling 
**8f1e7d4d836771d7b1b931245710fda696e9fa9c on timifasubaa:latest_import_csv** 
into **f8cc05b54edbd119bccc26837ac99f6c3d6078d1 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kkalyan commented on issue #3555: Version 0.20.0 not tagged and missing features?

[git]

kkalyan commented on issue #3555: Version 0.20.0 not tagged and missing 
features?
URL: 
https://github.com/apache/incubator-superset/issues/3555#issuecomment-333702677
 
 
   not sure about the tags, but `pip install superset` does not install the 
latest code.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3533: [WIP] Latest import csv

[git]

coveralls commented on issue #3533: [WIP] Latest import csv
URL: 
https://github.com/apache/incubator-superset/pull/3533#issuecomment-333701993
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13536426/badge)](https://coveralls.io/builds/13536426)
   
   Coverage decreased (-1.03%) to 69.115% when pulling 
**8f1e7d4d836771d7b1b931245710fda696e9fa9c on timifasubaa:latest_import_csv** 
into **f8cc05b54edbd119bccc26837ac99f6c3d6078d1 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3533: [WIP] Latest import csv

[git]

coveralls commented on issue #3533: [WIP] Latest import csv
URL: 
https://github.com/apache/incubator-superset/pull/3533#issuecomment-333701994
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13536426/badge)](https://coveralls.io/builds/13536426)
   
   Coverage decreased (-1.03%) to 69.115% when pulling 
**8f1e7d4d836771d7b1b931245710fda696e9fa9c on timifasubaa:latest_import_csv** 
into **f8cc05b54edbd119bccc26837ac99f6c3d6078d1 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3571: Feature: Copy-to-clipboard button in View Query

[git]

coveralls commented on issue #3571: Feature: Copy-to-clipboard button in View 
Query
URL: 
https://github.com/apache/incubator-superset/pull/3571#issuecomment-333698683
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13536183/badge)](https://coveralls.io/builds/13536183)
   
   Coverage remained the same at 70.141% when pulling 
**43f179e1bdbc4f0a3b6bcd81362a4cc22da96836 on 
Mogball:mogball/feature/copy_query** into 
**f8cc05b54edbd119bccc26837ac99f6c3d6078d1 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3571: Feature: Copy-to-clipboard button in View Query

[git]

coveralls commented on issue #3571: Feature: Copy-to-clipboard button in View 
Query
URL: 
https://github.com/apache/incubator-superset/pull/3571#issuecomment-333698685
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13536183/badge)](https://coveralls.io/builds/13536183)
   
   Coverage remained the same at 70.141% when pulling 
**43f179e1bdbc4f0a3b6bcd81362a4cc22da96836 on 
Mogball:mogball/feature/copy_query** into 
**f8cc05b54edbd119bccc26837ac99f6c3d6078d1 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Mogball closed pull request #3562: Feature: paste comma-delimited lists into SelectControl

[git]

Mogball closed pull request #3562: Feature: paste comma-delimited lists into 
SelectControl
URL: https://github.com/apache/incubator-superset/pull/3562
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Mogball opened a new pull request #3562: Feature: paste comma-delimited lists into SelectControl

[git]

Mogball opened a new pull request #3562: Feature: paste comma-delimited lists 
into SelectControl
URL: https://github.com/apache/incubator-superset/pull/3562
 
 
   As per https://github.com/apache/incubator-superset/issues/2614
   
   Adds an event handler to `SelectControl` for paste events, and if `multi: 
true` transforms a comma-delimited string into a list of selected options:
   
   ![Pasting Comma 
Gif](https://media.giphy.com/media/3ohhwGs3RMVpjM2GJy/giphy.gif)
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Mogball opened a new pull request #3571: Feature: Copy-to-clipboard button in View Query

[git]

Mogball opened a new pull request #3571: Feature: Copy-to-clipboard button in 
View Query
URL: https://github.com/apache/incubator-superset/pull/3571
 
 
   Adds a button that copies the query string:
   
   https://user-images.githubusercontent.com/15016832/31104197-6c4fe4f2-a790-11e7-8dbd-192a80b6b072.png;>
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3533: [WIP] Latest import csv

[git]

coveralls commented on issue #3533: [WIP] Latest import csv
URL: 
https://github.com/apache/incubator-superset/pull/3533#issuecomment-333692794
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13535880/badge)](https://coveralls.io/builds/13535880)
   
   Coverage decreased (-0.8%) to 69.37% when pulling 
**f11a217b9e0a47c1078f7c55e1f88f4c6e776fdc on timifasubaa:latest_import_csv** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3533: [WIP] Latest import csv

[git]

coveralls commented on issue #3533: [WIP] Latest import csv
URL: 
https://github.com/apache/incubator-superset/pull/3533#issuecomment-333692792
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13535880/badge)](https://coveralls.io/builds/13535880)
   
   Coverage decreased (-0.8%) to 69.37% when pulling 
**f11a217b9e0a47c1078f7c55e1f88f4c6e776fdc on timifasubaa:latest_import_csv** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3533: [WIP] Latest import csv

[git]

coveralls commented on issue #3533: [WIP] Latest import csv
URL: 
https://github.com/apache/incubator-superset/pull/3533#issuecomment-333692795
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13535880/badge)](https://coveralls.io/builds/13535880)
   
   Coverage decreased (-0.8%) to 69.37% when pulling 
**f11a217b9e0a47c1078f7c55e1f88f4c6e776fdc on timifasubaa:latest_import_csv** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3533: [WIP] Latest import csv

[git]

coveralls commented on issue #3533: [WIP] Latest import csv
URL: 
https://github.com/apache/incubator-superset/pull/3533#issuecomment-333692791
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13535880/badge)](https://coveralls.io/builds/13535880)
   
   Coverage decreased (-0.8%) to 69.37% when pulling 
**f11a217b9e0a47c1078f7c55e1f88f4c6e776fdc on timifasubaa:latest_import_csv** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed pull request #3565: Feature: name+percent and name+value labels for piechart

[git]

mistercrunch closed pull request #3565: Feature: name+percent and name+value 
labels for piechart
URL: https://github.com/apache/incubator-superset/pull/3565
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] panjiyar123 opened a new issue #3570: Request for- Correlation Matrix Graph based Visualization

[git]

panjiyar123 opened a new issue #3570: Request for- Correlation Matrix Graph 
based Visualization
URL: https://github.com/apache/incubator-superset/issues/3570
 
 
   I am looking for Correlation Matrix type Visualization, but couldn't find 
one available currently in Superset. I can find one available in d3js- 
https://bl.ocks.org/arpitnarechania/caeba2e6579900ea12cb2a4eb157ce74
   
   but not sure steps to add same to superset. Can someone help/guide me to do 
same.
   
   
   ### Superset version
   
   
   ### Expected results
   
   
   ### Actual results
   
   
   ### Steps to reproduce
   
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed pull request #3567: Removing yarn warnings during install

[git]

mistercrunch closed pull request #3567: Removing yarn warnings during install
URL: https://github.com/apache/incubator-superset/pull/3567
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch opened a new pull request #3569: Bumping React to 15.6.2 (MIT license)

[git]

mistercrunch opened a new pull request #3569: Bumping React to 15.6.2 (MIT 
license)
URL: https://github.com/apache/incubator-superset/pull/3569
 
 
   I think that leaves only immutable.js with the ASF-incompatible PATENTS 
clause
   
   I asked for a 3.8.x MIT release of the immutable lib here:
   https://github.com/facebook/immutable-js/issues/1309
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] amancevice commented on issue #3400: Can this repo's releases be tagged again?

[git]

amancevice commented on issue #3400: Can this repo's releases be tagged again?
URL: 
https://github.com/apache/incubator-superset/issues/3400#issuecomment-333682380
 
 
   @mistercrunch fyi, the tags you created disappeared and `0.20.0` is missing 
as well.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3492: PandasConnector

[git]

coveralls commented on issue #3492: PandasConnector
URL: 
https://github.com/apache/incubator-superset/pull/3492#issuecomment-333677287
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13534750/badge)](https://coveralls.io/builds/13534750)
   
   Coverage increased (+0.4%) to 70.592% when pulling 
**fbfd6855d0b1187ac366b85770c6e8937906bc25 on kimetrica:3302-pandas-connctor** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3533: [WIP] Latest import csv

[git]

coveralls commented on issue #3533: [WIP] Latest import csv
URL: 
https://github.com/apache/incubator-superset/pull/3533#issuecomment-333675410
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13534613/badge)](https://coveralls.io/builds/13534613)
   
   Coverage decreased (-0.8%) to 69.365% when pulling 
**ecbe09cd1fcdfa6532d543f00757a671a989aea9 on timifasubaa:latest_import_csv** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on issue #3568: Getting General Error when trying to hook up Postgres database

[git]

xrmx commented on issue #3568: Getting General Error  when trying to hook up Postgres database
URL: 
https://github.com/apache/incubator-superset/issues/3568#issuecomment-333670542
 
 
   Looks like a cryptography issue, try to upgrade it to see if  newer version 
works.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3567: Removing yarn warnings during install

[git]

coveralls commented on issue #3567: Removing yarn warnings during install
URL: 
https://github.com/apache/incubator-superset/pull/3567#issuecomment-333652389
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13533120/badge)](https://coveralls.io/builds/13533120)
   
   Coverage remained the same at 70.141% when pulling 
**e07f10ff1b3f72a6bd56ac1a8d3e2f463df49332 on 
dennybiasiolli:removing-yarn-warnings** into 
**b39d165913affba3d146c4dbbe7c1c02dac135f2 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] delainewendling opened a new issue #3568: Getting General Error when trying to hook up Postgres database

[git]

delainewendling opened a new issue #3568: Getting General Error  when trying to hook up Postgres database
URL: https://github.com/apache/incubator-superset/issues/3568
 
 
   I am using Superset 0.20.0, Python 3.6.0, cryptography 1.7.2, and postgres 
9.6.3. When I attempted to connect a Postgres database to Superset, I first 
tested the connection with the following SQLAlchemy URI: 
`postgresql+psycopg2://dwendling:@localhost/path` and superset said the 
connection seemed OK. All of the database tables from the database showed up at 
the bottom of the screen, so it seemed like everything was going to work.
   
   However, when I pressed save I received the following errors. 
   
   `General Error `
   
   ```Traceback (most recent call last):
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/flask_appbuilder/models/sqla/interface.py",
 line 295, in add
   self.session.commit()
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/sqlalchemy/orm/scoping.py",
 line 157, in do
   return getattr(self.registry(), name)(*args, **kwargs)
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/sqlalchemy/orm/session.py",
 line 874, in commit
   self.transaction.commit()
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/sqlalchemy/orm/session.py",
 line 461, in commit
   self._prepare_impl()
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/sqlalchemy/orm/session.py",
 line 441, in _prepare_impl
   self.session.flush()
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/sqlalchemy/orm/session.py",
 line 2139, in flush
   self._flush(objects)
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/sqlalchemy/orm/session.py",
 line 2259, in _flush
   transaction.rollback(_capture_exception=True)
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/sqlalchemy/util/langhelpers.py",
 line 66, in __exit__
   compat.reraise(exc_type, exc_value, exc_tb)
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/sqlalchemy/util/compat.py",
 line 187, in reraise
   raise value
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/sqlalchemy/orm/session.py",
 line 2223, in _flush
   flush_context.execute()
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/sqlalchemy/orm/unitofwork.py",
 line 389, in execute
   rec.execute(self)
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/sqlalchemy/orm/unitofwork.py",
 line 548, in execute
   uow
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/sqlalchemy/orm/persistence.py",
 line 181, in save_obj
   mapper, table, insert)
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/sqlalchemy/orm/persistence.py",
 line 835, in _emit_insert_statements
   execute(statement, params)
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/sqlalchemy/engine/base.py",
 line 945, in execute
   return meth(self, multiparams, params)
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/sqlalchemy/sql/elements.py",
 line 263, in _execute_on_connection
   return connection._execute_clauseelement(self, multiparams, params)
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/sqlalchemy/engine/base.py",
 line 1053, in _execute_clauseelement
   compiled_sql, distilled_params
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/sqlalchemy/engine/base.py",
 line 1121, in _execute_context
   None, None)
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/sqlalchemy/engine/base.py",
 line 1402, in _handle_dbapi_exception
   exc_info
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/sqlalchemy/util/compat.py",
 line 203, in raise_from_cause
   reraise(type(exception), exception, tb=exc_tb, cause=cause)
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/sqlalchemy/util/compat.py",
 line 186, in reraise
   raise value.with_traceback(tb)
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/sqlalchemy/engine/base.py",
 line 1116, in _execute_context
   context = constructor(dialect, self, conn, *args)
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/sqlalchemy/engine/default.py",
 line 623, in _init_compiled
   param.append(processors[key](compiled_params[key]))
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/sqlalchemy/sql/type_api.py",
 line 1074, in process
   return impl_processor(process_param(value, dialect))
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/sqlalchemy_utils/types/encrypted.py",
 line 248, in process_bind_param
   self._update_key()
 File 
"/Users/dwendling/venvs/test/lib/python3.6/site-packages/sqlalchemy_utils/types/encrypted.py",
 line 243, in _update_key
   self.engine._update_key(key)

[GitHub] dennybiasiolli opened a new pull request #3567: Removing yarn warnings during install

[git]

dennybiasiolli opened a new pull request #3567: Removing yarn warnings during 
install
URL: https://github.com/apache/incubator-superset/pull/3567
 
 
   - removing deprecated babel-preset-es2015 in favor of babel-preset-env
   
   This removes this yarn warning during install:
   
   ```
   warning babel-preset-es2015@6.24.1:
   Thanks for using Babel: we recommend using babel-preset-env now:
   please read babeljs.io/env to update!
   ```
   
   - updating sinon to 4.0.0
   
   This removes wrench from its dependencies and this yarn warning during 
install:
   
   ```
   warning wrench@1.3.9: wrench.js is deprecated!
   You should check out fs-extra 
(https://github.com/jprichardson/node-fs-extra)
   for any operations you were using wrench for.
   Thanks for all the usage over the years.
   ```
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3533: [WIP] Latest import csv

[git]

coveralls commented on issue #3533: [WIP] Latest import csv
URL: 
https://github.com/apache/incubator-superset/pull/3533#issuecomment-333644198
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13532521/badge)](https://coveralls.io/builds/13532521)
   
   Coverage decreased (-0.8%) to 69.384% when pulling 
**072a43206bafce72204bda09adc4c195e25ec69c on timifasubaa:latest_import_csv** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] fabianmenges commented on issue #3518: Full Annotation Framework

[git]

fabianmenges commented on issue #3518: Full Annotation Framework
URL: 
https://github.com/apache/incubator-superset/pull/3518#issuecomment-333635359
 
 
   BTW, if you want to go forward with this, I will need to write a migration 
script or some other logic to handle the current `annotation_layer` formData 
variable.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dennybiasiolli commented on issue #2700: assets: unmantained dependency react-alert

[git]

dennybiasiolli commented on issue #2700: assets: unmantained dependency 
react-alert
URL: 
https://github.com/apache/incubator-superset/issues/2700#issuecomment-333630630
 
 
   Closed by #2923 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] fabianmenges commented on issue #3563: [nvd3] fix single metric showing up in legend

[git]

fabianmenges commented on issue #3563: [nvd3] fix single metric showing up in 
legend
URL: 
https://github.com/apache/incubator-superset/pull/3563#issuecomment-333630522
 
 
   Just saw this, now we have presentation logic in python again. Would have 
been cleaner to do it in JS. 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dennybiasiolli closed issue #2700: assets: unmantained dependency react-alert

[git]

dennybiasiolli closed issue #2700: assets: unmantained dependency react-alert
URL: https://github.com/apache/incubator-superset/issues/2700
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] fabianmenges commented on a change in pull request #3566: [Fix]: Label generation for `grouped by`, `single metric` time series charts

[git]

fabianmenges commented on a change in pull request #3566: [Fix]: Label 
generation for `grouped by`, `single metric` time series charts
URL: 
https://github.com/apache/incubator-superset/pull/3566#discussion_r142223252
 
 

 ##
 File path: superset/assets/visualizations/nvd3_vis.js
 ##
 @@ -97,9 +100,22 @@ function nvd3Vis(slice, payload) {
   const isExplore = $('#explore-container').length === 1;
 
   let data;
+  // Get the most significant part of the series name (key)
+  const mostSignificant = payload.data
+.filter(x => Array.isArray(x.key) && x.key.length > 1)
+.map(x => x.key[0]);
+  // # of distinct most significant keys
+  const distinctMostSignificant = mostSignificant
+.reduce((distinct, v) => distinct.add(v), new Set()).size;
+  // remove the msg key from the label if these conditions are true
+  const removeMostSignificant = mostSignificant.length === payload.data.length 
&&
+distinctMostSignificant === 1;
 
 Review comment:
   instead of this (complicated) logic in line 103 to 112 we could simplify  
how we set the `removeMostSignificant` flag to:
   ```
   const removeMostSignificant = slice.formData.metrics.length === 1;
   ```
   However that would make the label generation depend on the fromData and it 
would therefore be less generic. Let me know what you think...
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] fabianmenges commented on a change in pull request #3566: [Fix]: Label generation for `grouped by`, `single metric` time series charts

[git]

fabianmenges commented on a change in pull request #3566: [Fix]: Label 
generation for `grouped by`, `single metric` time series charts
URL: 
https://github.com/apache/incubator-superset/pull/3566#discussion_r142223252
 
 

 ##
 File path: superset/assets/visualizations/nvd3_vis.js
 ##
 @@ -97,9 +100,22 @@ function nvd3Vis(slice, payload) {
   const isExplore = $('#explore-container').length === 1;
 
   let data;
+  // Get the most significant part of the series name (key)
+  const mostSignificant = payload.data
+.filter(x => Array.isArray(x.key) && x.key.length > 1)
+.map(x => x.key[0]);
+  // # of distinct most significant keys
+  const distinctMostSignificant = mostSignificant
+.reduce((distinct, v) => distinct.add(v), new Set()).size;
+  // remove the msg key from the label if these conditions are true
+  const removeMostSignificant = mostSignificant.length === payload.data.length 
&&
+distinctMostSignificant === 1;
 
 Review comment:
   instead of this (complicated) logic in line 103 to 112 we could simplify  
how we set the `removeMostSignificant` flag to:
   ```
   const removeMostSignificant = slice.formData.metrics.length === 1;
   ```
   However that would make the label generation depend on the fromData and it 
would therefore be less generic.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] fabianmenges commented on a change in pull request #3566: [Fix]: Label generation for `grouped by`, `single metric` time series charts

[git]

fabianmenges commented on a change in pull request #3566: [Fix]: Label 
generation for `grouped by`, `single metric` time series charts
URL: 
https://github.com/apache/incubator-superset/pull/3566#discussion_r142223252
 
 

 ##
 File path: superset/assets/visualizations/nvd3_vis.js
 ##
 @@ -97,9 +100,22 @@ function nvd3Vis(slice, payload) {
   const isExplore = $('#explore-container').length === 1;
 
   let data;
+  // Get the most significant part of the series name (key)
+  const mostSignificant = payload.data
+.filter(x => Array.isArray(x.key) && x.key.length > 1)
+.map(x => x.key[0]);
+  // # of distinct most significant keys
+  const distinctMostSignificant = mostSignificant
+.reduce((distinct, v) => distinct.add(v), new Set()).size;
+  // remove the msg key from the label if these conditions are true
+  const removeMostSignificant = mostSignificant.length === payload.data.length 
&&
+distinctMostSignificant === 1;
 
 Review comment:
   instead of this (complicated) logic we could simplify  how we set the 
`removeMostSignificant` flag to:
   ```
   const removeMostSignificant = slice.formData.metrics.length === 1;
   ```
   However that would make the label generation depend on the fromData and it 
would therefore be less generic.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] fabianmenges opened a new pull request #3566: [Fix]: Label generation for `grouped by`, `single metric` time series charts

[git]

fabianmenges opened a new pull request #3566: [Fix]: Label generation for 
`grouped by`, `single metric` time series charts
URL: https://github.com/apache/incubator-superset/pull/3566
 
 
   @mistercrunch  reported a change in behavior/bug introduced in #3504 
   This addresses the issue.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kkalyan commented on issue #3565: Feature: name+percent and name+value labels for piechart

[git]

kkalyan commented on issue #3565: Feature: name+percent and name+value labels 
for piechart
URL: 
https://github.com/apache/incubator-superset/pull/3565#issuecomment-333625824
 
 
   awesome, thanks @Mogball! 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] joshwalters commented on issue #3555: Version 0.20.0 not tagged and missing features?

[git]

joshwalters commented on issue #3555: Version 0.20.0 not tagged and missing 
features?
URL: 
https://github.com/apache/incubator-superset/issues/3555#issuecomment-333623311
 
 
   @mistercrunch This is very odd. If I go to the url for `0.20.0` it is giving 
a 404 error, and it doesn't show in the tag browser. Maybe something _is_ 
deleting it??
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3533: [WIP] Latest import csv

[git]

coveralls commented on issue #3533: [WIP] Latest import csv
URL: 
https://github.com/apache/incubator-superset/pull/3533#issuecomment-333620639
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13530889/badge)](https://coveralls.io/builds/13530889)
   
   Coverage decreased (-0.8%) to 69.355% when pulling 
**507360d78ce4dc1860193192cde2ad5c74f499f7 on timifasubaa:latest_import_csv** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3533: [WIP] Latest import csv

[git]

coveralls commented on issue #3533: [WIP] Latest import csv
URL: 
https://github.com/apache/incubator-superset/pull/3533#issuecomment-333620640
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13530889/badge)](https://coveralls.io/builds/13530889)
   
   Coverage decreased (-0.8%) to 69.355% when pulling 
**507360d78ce4dc1860193192cde2ad5c74f499f7 on timifasubaa:latest_import_csv** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3533: [WIP] Latest import csv

[git]

coveralls commented on issue #3533: [WIP] Latest import csv
URL: 
https://github.com/apache/incubator-superset/pull/3533#issuecomment-333620637
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13530889/badge)](https://coveralls.io/builds/13530889)
   
   Coverage decreased (-0.8%) to 69.355% when pulling 
**507360d78ce4dc1860193192cde2ad5c74f499f7 on timifasubaa:latest_import_csv** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3533: [WIP] Latest import csv

[git]

coveralls commented on issue #3533: [WIP] Latest import csv
URL: 
https://github.com/apache/incubator-superset/pull/3533#issuecomment-333620638
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13530889/badge)](https://coveralls.io/builds/13530889)
   
   Coverage decreased (-0.8%) to 69.355% when pulling 
**507360d78ce4dc1860193192cde2ad5c74f499f7 on timifasubaa:latest_import_csv** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rjpereira commented on issue #3564: Request for Comments : Tableau-like data extracts feature

[git]

rjpereira commented on issue #3564: Request for Comments : Tableau-like data 
extracts feature
URL: 
https://github.com/apache/incubator-superset/issues/3564#issuecomment-333618815
 
 
   The deployment in same or separate and different DB would always be left as
   a configuration decision. My requirements are mostly to stage slow engines
   as Athena or materialize big joins in DBs that don't support materialised
   views as redshift.
   
   On Mon, 2 Oct 2017, 19:41 Maxime Beauchemin, 
   wrote:
   
   > Just curious, what would you use or allow as the "QDE" backend? Some
   > other, faster database? I don't think it's reasonable to use Superset's
   > metadata DB as we don't want mixed workloads (OLTP & OLAP) on that DB. We
   > want that metadata DB to serve the app predictably and reliably.
   >
   > ?
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] frankhsu commented on issue #3545: CHANGELOG for 0.20.0

[git]

frankhsu commented on issue #3545: CHANGELOG for 0.20.0
URL: 
https://github.com/apache/incubator-superset/pull/3545#issuecomment-333618190
 
 
   @mistercrunch is there a plan to continue to tagging releases?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] frankhsu commented on issue #3545: CHANGELOG for 0.20.0

[git]

frankhsu commented on issue #3545: CHANGELOG for 0.20.0
URL: 
https://github.com/apache/incubator-superset/pull/3545#issuecomment-333618190
 
 
   @mistercrunch will you be continuing to tag releases? or has that ended
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3565: Feature: name+percent and name+value labels for piechart

[git]

coveralls commented on issue #3565: Feature: name+percent and name+value labels 
for piechart
URL: 
https://github.com/apache/incubator-superset/pull/3565#issuecomment-333612587
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13530480/badge)](https://coveralls.io/builds/13530480)
   
   Coverage remained the same at 70.161% when pulling 
**b28cc655cbc403911d7fe34b4ea99060a9847479 on 
Mogball:mogball/feature/piechart_labels** into 
**bc3ad6461953427c5d74d5c83d1d536c720f8ace on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed pull request #3563: [nvd3] fix single metric showing up in legend

[git]

mistercrunch closed pull request #3563: [nvd3] fix single metric showing up in 
legend
URL: https://github.com/apache/incubator-superset/pull/3563
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #3564: Request for Comments : Tableau-like data extracts feature

[git]

mistercrunch commented on issue #3564: Request for Comments : Tableau-like data 
extracts feature
URL: 
https://github.com/apache/incubator-superset/issues/3564#issuecomment-333608601
 
 
   Just curious, what would you use or allow as the "QDE" backend? Some other, 
faster database? I don't think it's reasonable to use Superset's metadata DB as 
we don't want mixed workloads (OLTP & OLAP) on that DB. We want that metadata 
DB to serve the app predictably and reliably.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3563: [nvd3] fix single metric showing up in legend

[git]

coveralls commented on issue #3563: [nvd3] fix single metric showing up in 
legend
URL: 
https://github.com/apache/incubator-superset/pull/3563#issuecomment-333608575
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13530272/badge)](https://coveralls.io/builds/13530272)
   
   Coverage decreased (-0.02%) to 70.141% when pulling 
**05b2b42633941b6cc7a8018423e92ce7fe286720 on mistercrunch:fix_legend** into 
**bc3ad6461953427c5d74d5c83d1d536c720f8ace on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] timifasubaa commented on issue #3563: [nvd3] fix single metric showing up in legend

[git]

timifasubaa commented on issue #3563: [nvd3] fix single metric showing up in 
legend
URL: 
https://github.com/apache/incubator-superset/pull/3563#issuecomment-333608495
 
 
   LGTM
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Mogball opened a new pull request #3565: Feature: name+percent and name+value labels for piechart

[git]

Mogball opened a new pull request #3565: Feature: name+percent and name+value 
labels for piechart
URL: https://github.com/apache/incubator-superset/pull/3565
 
 
   As per https://github.com/apache/incubator-superset/issues/3048
   
   Adds to Chart Options for `Pie Chart` two label types: `Category and 
Percent` and `Category and Value` which displays the percentages and values 
next to the category names on the chart:
   
   ![Pie Chart labels 
GIF](https://media.giphy.com/media/3ohhwklNBeFr83dR0A/giphy.gif)
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3533: [WIP] Latest import csv

[git]

coveralls commented on issue #3533: [WIP] Latest import csv
URL: 
https://github.com/apache/incubator-superset/pull/3533#issuecomment-333606964
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13530207/badge)](https://coveralls.io/builds/13530207)
   
   Coverage decreased (-0.8%) to 69.374% when pulling 
**500534e08b5d0d3dadd8b7f52bc9aa916d81eb7d on timifasubaa:latest_import_csv** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3562: Feature: paste comma-delimited lists into SelectControl

[git]

coveralls commented on issue #3562: Feature: paste comma-delimited lists into 
SelectControl
URL: 
https://github.com/apache/incubator-superset/pull/3562#issuecomment-333606968
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13530195/badge)](https://coveralls.io/builds/13530195)
   
   Coverage remained the same at 70.161% when pulling 
**a9f00cadc4fff0a7f602e45567a33b925efc01c6 on 
Mogball:mogball/feature/paste_comma_filters** into 
**bc3ad6461953427c5d74d5c83d1d536c720f8ace on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch opened a new pull request #3563: [nvd3] fix single metric showing up in legend

[git]

mistercrunch opened a new pull request #3563: [nvd3] fix single metric showing 
up in legend
URL: https://github.com/apache/incubator-superset/pull/3563
 
 
   blame https://github.com/apache/incubator-superset/pull/3504
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3561: Feature: time range select on cumulative line and stack area charts

[git]

coveralls commented on issue #3561: Feature: time range select on cumulative 
line and stack area charts
URL: 
https://github.com/apache/incubator-superset/pull/3561#issuecomment-333604162
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13529997/badge)](https://coveralls.io/builds/13529997)
   
   Coverage remained the same at 70.161% when pulling 
**aab9d7ba38a7b91d3784e9be6f19f867059ed2e1 on 
Mogball:mogball/feature/time_range_select** into 
**bc3ad6461953427c5d74d5c83d1d536c720f8ace on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] fabianmenges commented on issue #3504: Feature: Display the verbose name for metrics within Timeseries charts and legend.

[git]

fabianmenges commented on issue #3504: Feature: Display the verbose name for 
metrics within Timeseries charts and legend.
URL: 
https://github.com/apache/incubator-superset/pull/3504#issuecomment-333602610
 
 
   Should be easy to fix, I'll try to push something later today...
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Mogball opened a new pull request #3562: Feature: paste comma-delimited lists into SelectControl

[git]

Mogball opened a new pull request #3562: Feature: paste comma-delimited lists 
into SelectControl
URL: https://github.com/apache/incubator-superset/pull/3562
 
 
   Adds an event handler to `SelectControl` for paste events, and if `multi: 
true` transforms a comma-delimited string into a list of selected options:
   
   ![Pasting Comma 
Gif](https://media.giphy.com/media/3ohhwGs3RMVpjM2GJy/giphy.gif)
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3533: [WIP] Latest import csv

[git]

coveralls commented on issue #3533: [WIP] Latest import csv
URL: 
https://github.com/apache/incubator-superset/pull/3533#issuecomment-333601240
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13529834/badge)](https://coveralls.io/builds/13529834)
   
   Coverage decreased (-0.8%) to 69.374% when pulling 
**633bfa424fc7102ed9fd020e7257f71973c3598a on timifasubaa:latest_import_csv** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3533: [WIP] Latest import csv

[git]

coveralls commented on issue #3533: [WIP] Latest import csv
URL: 
https://github.com/apache/incubator-superset/pull/3533#issuecomment-333601242
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13529834/badge)](https://coveralls.io/builds/13529834)
   
   Coverage decreased (-0.8%) to 69.374% when pulling 
**633bfa424fc7102ed9fd020e7257f71973c3598a on timifasubaa:latest_import_csv** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3533: [WIP] Latest import csv

[git]

coveralls commented on issue #3533: [WIP] Latest import csv
URL: 
https://github.com/apache/incubator-superset/pull/3533#issuecomment-333599900
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13529675/badge)](https://coveralls.io/builds/13529675)
   
   Coverage decreased (-0.8%) to 69.374% when pulling 
**633bfa424fc7102ed9fd020e7257f71973c3598a on timifasubaa:latest_import_csv** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rjpereira commented on issue #3557: "Results backend isn't configured" with Celery DynamoDB backend

[git]

rjpereira commented on issue #3557: "Results backend isn't configured" with 
Celery DynamoDB backend
URL: 
https://github.com/apache/incubator-superset/issues/3557#issuecomment-333599616
 
 
   Thanks I made it work in the end, although value is limited, agree.
   At the same time did an implementation of a DynamoDb Werkzeug Cache to 
support Slice and Schema caching (subject to Dynamo 400K limitation). First 
drop here  (https://github.com/logindex/dynamodb-werkzeugcache) if anyone is 
interested.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #3504: Feature: Display the verbose name for metrics within Timeseries charts and legend.

[git]

mistercrunch commented on a change in pull request #3504: Feature: Display the 
verbose name for metrics within Timeseries charts and legend.
URL: 
https://github.com/apache/incubator-superset/pull/3504#discussion_r142195354
 
 

 ##
 File path: superset/viz.py
 ##
 @@ -840,16 +840,11 @@ def to_series(self, df, classed='', title_suffix=''):
 ys = series[name]
 if df[name].dtype.kind not in "biufc":
 continue
-if isinstance(name, string_types):
-series_title = name
-else:
-name = ["{}".format(s) for s in name]
-if len(self.form_data.get('metrics')) > 1:
 
 Review comment:
   Users reported an issue related to removing this logic. In the case where 
there's a single metric and a one or many dimension, the metric name would not 
be reported prior to this change, which is the desired behavior. Where before 
using metric `count` with `gender` dimension would give ['female', 'male', 
'other'] in both the legend and tooltip, now it says  ['count, female', 'count, 
male', 'count, other'] 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sdia commented on issue #3559: Creating a table from Athena database connection

[git]

sdia commented on issue #3559: Creating a table from Athena database connection
URL: 
https://github.com/apache/incubator-superset/issues/3559#issuecomment-333575694
 
 
   Thank you for the swift reply, here is my connection string:
   
   
`awsathena+jdbc://aws_access_key_id:aws_secret_access_...@athena.us-west-2.amazonaws.com/schema?s3_staging_dir=staging_bucket`
   
   
   Regarding `information_schema.colums` it does not seem to exist in the 
system tables of Athena. It seems weird also that the query to that table (as 
it appears in logs) does not filter by table_name...
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3543: [WiP] adding a new "Time Series - Table" viz

[git]

coveralls commented on issue #3543: [WiP] adding a new "Time Series - Table" viz
URL: 
https://github.com/apache/incubator-superset/pull/3543#issuecomment-333594945
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13529447/badge)](https://coveralls.io/builds/13529447)
   
   Coverage decreased (-0.1%) to 70.019% when pulling 
**e98daaf6dcb9548f804add17c0b28cb389780600 on mistercrunch:time_table** into 
**bc3ad6461953427c5d74d5c83d1d536c720f8ace on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sdia commented on issue #3559: Creating a table from Athena database connection

[git]

sdia commented on issue #3559: Creating a table from Athena database connection
URL: 
https://github.com/apache/incubator-superset/issues/3559#issuecomment-333575694
 
 
   Thank you for the swift reply, here is my connection string:
   
   
`awsathena+jdbc://aws_access_key_id:aws_secret_access_...@athena.us-west-2.amazonaws.com/olx_bdt?s3_staging_dir=staging_bucket`
   
   
   Regarding `information_schema.colums` it does not seem to exist in the 
system tables of Athena. It seems weird also that the query to that table (as 
it appears in logs) does not filter by table_name...
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sdia commented on issue #3559: Creating a table from Athena database connection

[git]

sdia commented on issue #3559: Creating a table from Athena database connection
URL: 
https://github.com/apache/incubator-superset/issues/3559#issuecomment-333575694
 
 
   Thank you for the swift reply, here is my connection string:
   
   
`awsathena+jdbc://aws_access_key_id:aws_secret_access_...@athena.us-west-2.amazonaws.com/olx_bdt?s3_staging_dir=staging_bucket`
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #3557: "Results backend isn't configured" with Celery DynamoDB backend

[git]

mistercrunch commented on issue #3557: "Results backend isn't configured" with 
Celery DynamoDB backend
URL: 
https://github.com/apache/incubator-superset/issues/3557#issuecomment-333575495
 
 
   We may or may not use the celery results backend in the future though.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #3557: "Results backend isn't configured" with Celery DynamoDB backend

[git]

mistercrunch commented on issue #3557: "Results backend isn't configured" with 
Celery DynamoDB backend
URL: 
https://github.com/apache/incubator-superset/issues/3557#issuecomment-333575256
 
 
   It will if the @celery.task-decorated function does return something, which 
shouldn't be the case in our case.
   
   The way we use celery is we initiate the async task from a web request scope 
and essentially give up on it. The initiator (web server) doesn't expect 
getting result in the scope where its called.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #3558: Add Pronto Tools to user list

[git]

mistercrunch commented on issue #3558: Add Pronto Tools to user list
URL: 
https://github.com/apache/incubator-superset/pull/3558#issuecomment-333573824
 
 
   Awesome. Welcome on board!
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed pull request #3558: Add Pronto Tools to user list

[git]

mistercrunch closed pull request #3558: Add Pronto Tools to user list
URL: https://github.com/apache/incubator-superset/pull/3558
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #3555: Version 0.20.0 not tagged and missing features?

[git]

mistercrunch commented on issue #3555: Version 0.20.0 not tagged and missing 
features?
URL: 
https://github.com/apache/incubator-superset/issues/3555#issuecomment-333573374
 
 
   https://user-images.githubusercontent.com/487433/31085885-2fa127de-a74d-11e7-9f60-0d4f948927a2.png;>
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #3543: [WiP] adding a new "Time Series - Table" viz

[git]

mistercrunch commented on issue #3543: [WiP] adding a new "Time Series - Table" 
viz
URL: 
https://github.com/apache/incubator-superset/pull/3543#issuecomment-333572376
 
 
   @fabianmenges this also ships with a reusable "CollectionControl" that can 
be used to get an arbitrary array of controls and is smoothly sortable with 
dragndrop. We're having more and more use cases for collections in controls...
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #3559: Creating a table from Athena database connection

[git]

mistercrunch commented on issue #3559: Creating a table from Athena database 
connection
URL: 
https://github.com/apache/incubator-superset/issues/3559#issuecomment-333571788
 
 
   What does your connection string look like? What dialect are you using?
   
   It looks like it raises calling the dialiect's `get_table` method. And it 
looks like its using INFORMATION_SCHEMA.columns behind the scene, which I think 
works from Presto, it may just be something around a reserved word not being 
set in the dialect, and used in that query to get the columns information.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sdia opened a new issue #3559: Creating a table from Athena database connection

[git]

sdia opened a new issue #3559: Creating a table from Athena database connection
URL: https://github.com/apache/incubator-superset/issues/3559
 
 
   
   
   I can successfully create an Athena database; in the database console I can 
even see the tables in my database.
   
   However when I try to create a new table I have an error. The output of the 
console looks like this:
   
   ```
   2017-10-02 15:58:38,866:DEBUG:pyathenajdbc.connection:JVM path: 
/Library/Java/JavaVirtualMachines/jdk1.8.0_111.jdk/Contents/Home/jre/lib/jli/libjli.dylib
   2017-10-02 15:58:38,867:DEBUG:pyathenajdbc.connection:JVM args: [u'-server', 
u'-Djava.class.path=/tmp/venv/lib/python2.7/site-packages/pyathenajdbc/AthenaJDBC41-1.1.0.jar']
   log4j:WARN No appenders could be found for logger 
(com.amazonaws.athena.jdbc.AthenaDriver).
   log4j:WARN Please initialize the log4j system properly.
   log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for 
more info.
   2017-10-02 15:58:41,131:DEBUG:pyathenajdbc.converter:{'REAL': 7, 'CLOB': 
2005, 'TIME_WITH_TIMEZONE': 2013, 'LONGVARBINARY': -4, 'CHAR': 1, 'TINYINT': 
-6, 'BIGINT': -5, 'REF_CURSOR': 2012, 'DATE': 91, 'VARBINARY': -3, 'NULL': 0, 
'REF': 2006, 'LONGNVARCHAR': -16, 'SMALLINT': 5, 'VARCHAR': 12, 'DISTINCT': 
2001, 'NUMERIC': 2, 'NVARCHAR': -9, 'INTEGER': 4, 'ARRAY': 2003, 'JAVA_OBJECT': 
2000, 'DATALINK': 70, 'SQLXML': 2009, 'DECIMAL': 3, 'OTHER': , 
'TIMESTAMP_WITH_TIMEZONE': 2014, 'BIT': -7, 'NCHAR': -15, 'BINARY': -2, 
'STRUCT': 2002, 'DOUBLE': 8, 'LONGVARCHAR': -1, 'FLOAT': 6, 'BOOLEAN': 16, 
'BLOB': 2004, 'ROWID': -8, 'TIME': 92, 'NCLOB': 2011, 'TIMESTAMP': 93}
   2017-10-02 15:58:41,137:DEBUG:pyathenajdbc.cursor:SELECT
 table_schema,
 table_name,
 column_name,
 data_type,
 is_nullable,
 column_default,
 ordinal_position,
 comment
   FROM information_schema.columns
   2017-10-02 15:58:43,384:ERROR:pyathenajdbc.cursor:Failed to execute query.
   Traceback (most recent call last):
 File "/tmp/venv/lib/python2.7/site-packages/pyathenajdbc/cursor.py", line 
172, in execute
   result_set = self._statement.executeQuery(query)
   java.sql.SQLExceptionPyRaisable: java.sql.SQLException: Internal error
   2017-10-02 15:58:43,386:ERROR:root:(pyathenajdbc.error.DatabaseError) 
java.sql.SQLException: Internal error [SQL: u'\nSELECT\n
  table_schema,\n  table_name,\n  
column_name,\n  data_type,\n  is_nullable,\n
  column_default,\n  ordinal_position,\n
  comment\nFROM information_schema.columns\n
']
   Traceback (most recent call last):
 File 
"/tmp/venv/lib/python2.7/site-packages/superset/connectors/sqla/views.py", line 
243, in pre_add
   table.get_sqla_table_object()
 File 
"/tmp/venv/lib/python2.7/site-packages/superset/connectors/sqla/models.py", 
line 583, in get_sqla_table_object
   return self.database.get_table(self.table_name, schema=self.schema)
 File "/tmp/venv/lib/python2.7/site-packages/superset/models/core.py", line 
715, in get_table
   autoload_with=self.get_sqla_engine())
 File "/tmp/venv/lib/python2.7/site-packages/sqlalchemy/sql/schema.py", 
line 439, in __new__
   metadata._remove_table(name, schema)
 File 
"/tmp/venv/lib/python2.7/site-packages/sqlalchemy/util/langhelpers.py", line 
66, in __exit__
   compat.reraise(exc_type, exc_value, exc_tb)
 File "/tmp/venv/lib/python2.7/site-packages/sqlalchemy/sql/schema.py", 
line 434, in __new__
   table._init(name, metadata, *args, **kw)
 File "/tmp/venv/lib/python2.7/site-packages/sqlalchemy/sql/schema.py", 
line 514, in _init
   include_columns, _extend_on=_extend_on)
 File "/tmp/venv/lib/python2.7/site-packages/sqlalchemy/sql/schema.py", 
line 527, in _autoload
   _extend_on=_extend_on
 File "/tmp/venv/lib/python2.7/site-packages/sqlalchemy/engine/base.py", 
line 2045, in run_callable
   return conn.run_callable(callable_, *args, **kwargs)
 File "/tmp/venv/lib/python2.7/site-packages/sqlalchemy/engine/base.py", 
line 1534, in run_callable
   return callable_(self, *args, **kwargs)
 File "/tmp/venv/lib/python2.7/site-packages/sqlalchemy/engine/default.py", 
line 372, in reflecttable
   table, include_columns, exclude_columns, **opts)
 File 
"/tmp/venv/lib/python2.7/site-packages/sqlalchemy/engine/reflection.py", line 
598, in reflecttable
   table_name, schema, **table.dialect_kwargs):
 File 
"/tmp/venv/lib/python2.7/site-packages/sqlalchemy/engine/reflection.py", line 
369, in get_columns
   **kw)
 File "", line 2, in get_columns
 File 
"/tmp/venv/lib/python2.7/site-packages/sqlalchemy/engine/reflection.py", line 
54, in cache
  

[GitHub] rjpereira commented on issue #3555: Version 0.20.0 not tagged and missing features?

[git]

rjpereira commented on issue #3555: Version 0.20.0 not tagged and missing 
features?
URL: 
https://github.com/apache/incubator-superset/issues/3555#issuecomment-333490755
 
 
   Clarifying : the 0.20.0 tag was still not committed, right?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

What is git's repo/tag/branch of Pypi 0.20.0 ?

[Ricardo Pereira]

A bit lost on where the pypi is being taken from

https://pypi.python.org/pypi/superset

Thanks

[GitHub] xrmx commented on a change in pull request #3492: PandasConnector

[git]

xrmx commented on a change in pull request #3492: PandasConnector
URL: 
https://github.com/apache/incubator-superset/pull/3492#discussion_r142077712
 
 

 ##
 File path: dev-reqs.txt
 ##
 @@ -1,7 +1,10 @@
+beautifulsoup4==4.6.0
+lxml==3.8.0
 codeclimate-test-reporter
 coveralls
 flake8
 flask_cors
+lxml==3.8.0
 
 Review comment:
   Uhm, we probably don't want to tie the supported formats to the db so maybe 
it's better to just have a varchar in the db and limit the values from a select 
built from a config key so each user can support whatever formats they want.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Newbie question on customising superset

[Ricardo Pereira]

Hi.
I'm interested in customising superset, and more specifically expanding
SavedQuery ORM model to add a few columns, and later to to extend the
views/forms to expose some of those fields.

I'm not that familiar with Alchemy & Flask Migrate, so I'm not very sure
what would be the first steps to achieve this. This is an initial
deployment so, migration from a previous database would not be strictly
necessary if this makes a difference.

Thanks in advance,
Ricardo

[GitHub] rhunwicks commented on a change in pull request #3492: PandasConnector

[git]

rhunwicks commented on a change in pull request #3492: PandasConnector
URL: 
https://github.com/apache/incubator-superset/pull/3492#discussion_r142071323
 
 

 ##
 File path: dev-reqs.txt
 ##
 @@ -1,7 +1,10 @@
+beautifulsoup4==4.6.0
+lxml==3.8.0
 codeclimate-test-reporter
 coveralls
 flake8
 flask_cors
+lxml==3.8.0
 
 Review comment:
   I have added the necessary packages to `setup.py` so that `PandasDatasource` 
works for csv, html, json and Excel.
   
   @xrmx do you think it would be a good idea to allow 
`PandasDatasource.FORMATS` to be overridden from settings, much as we allow 
`ADDITIONAL_MODULE_DS_MAP` to add extra Connectors? Then a specific 
installation could, for example, install `pytables` and then set:
   
   ```python
   ADDITIONAL_PANDAS_FORMATS = [('hdf', 'HDF5')]
   ```
   
   Another approach would be to attempt to dynamically set the list of 
allowable formats based on whether we can import the required dependencies.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaimonPl commented on issue #3522: Date Filter is not working on dashboard.

[git]

DaimonPl commented on issue #3522: Date Filter is not working on dashboard.
URL: 
https://github.com/apache/incubator-superset/issues/3522#issuecomment-333448571
 
 
   @Mogball @xrmx great there's fix for that :) any chance to have it merged 
and released as 0.20.1 ? It's quite critical bug as all dashboards with date 
filters stopped working with 0.20.0
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services