[GitHub] sanoopmm opened a new issue #4583: Need multiple date filters in slice
sanoopmm opened a new issue #4583: Need multiple date filters in slice URL: https://github.com/apache/incubator-superset/issues/4583 Make sure these boxes are checked before submitting your issue - thank you! - [*] I have checked the superset logs for python stacktraces and included it here as text if any - [*] I have reproduced the issue with at least the latest released version of superset - [*] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version 0.20.4 ### Expected results When I try to create a slice and I have more than one Date columns, I need to specify multiple 'Time Column'. Also I need multiple date filters in the slice. According to the number of date columns, I need more number of date filters. ### Actual results Now only one 'Time Column' and only one date filter is possible even if more than one date columns are available in the table. ### Steps to reproduce 1. Create new slice 2. specify the 'Time Column' 3. Able to filter the data only by using the selected data column. 4. Only one 'since' and 'until' available. I need More than one according to the number of date columns. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing
codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=h1) Report > Merging [#4552](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b512da8002dc0dc7f6a1f5eb983606118f484d32?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4552 +/- ## === Coverage 71.17% 71.17% === Files 187 187 Lines 1480914809 Branches 1085 1085 === Hits1054010540 Misses 4266 4266 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree) | Coverage ? | | |---|---|---| | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.12% <0%> (?)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=footer). Last update [b512da8...5c69cce](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing
codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=h1) Report > Merging [#4552](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b512da8002dc0dc7f6a1f5eb983606118f484d32?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4552 +/- ## === Coverage 71.17% 71.17% === Files 187 187 Lines 1480914809 Branches 1085 1085 === Hits1054010540 Misses 4266 4266 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree) | Coverage ? | | |---|---|---| | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.12% <0%> (?)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=footer). Last update [b512da8...5c69cce](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4582: [code-climate] Deprecating Code Climate from JavaScript tests
codecov-io commented on issue #4582: [code-climate] Deprecating Code Climate from JavaScript tests URL: https://github.com/apache/incubator-superset/pull/4582#issuecomment-371729536 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=h1) Report > Merging [#4582](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b512da8002dc0dc7f6a1f5eb983606118f484d32?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4582 +/- ## === Coverage 71.17% 71.17% === Files 187 187 Lines 1480914809 Branches 1085 1085 === Hits1054010540 Misses 4266 4266 Partials33 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=footer). Last update [b512da8...3fbadd6](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4582: [code-climate] Deprecating Code Climate from JavaScript tests
codecov-io commented on issue #4582: [code-climate] Deprecating Code Climate from JavaScript tests URL: https://github.com/apache/incubator-superset/pull/4582#issuecomment-371729536 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=h1) Report > Merging [#4582](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b512da8002dc0dc7f6a1f5eb983606118f484d32?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4582 +/- ## === Coverage 71.17% 71.17% === Files 187 187 Lines 1480914809 Branches 1085 1085 === Hits1054010540 Misses 4266 4266 Partials33 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=footer). Last update [b512da8...3fbadd6](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4582: [code-climate] Deprecating Code Climate from JavaScript tests
codecov-io commented on issue #4582: [code-climate] Deprecating Code Climate from JavaScript tests URL: https://github.com/apache/incubator-superset/pull/4582#issuecomment-371729536 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=h1) Report > Merging [#4582](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b512da8002dc0dc7f6a1f5eb983606118f484d32?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4582 +/- ## === Coverage 71.17% 71.17% === Files 187 187 Lines 1480914809 Branches 1085 1085 === Hits1054010540 Misses 4266 4266 Partials33 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=footer). Last update [b512da8...3fbadd6](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4582: [code-climate] Deprecating Code Climate from JavaScript tests
codecov-io commented on issue #4582: [code-climate] Deprecating Code Climate from JavaScript tests URL: https://github.com/apache/incubator-superset/pull/4582#issuecomment-371729536 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=h1) Report > Merging [#4582](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b512da8002dc0dc7f6a1f5eb983606118f484d32?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4582 +/- ## === Coverage 71.17% 71.17% === Files 187 187 Lines 1480914809 Branches 1085 1085 === Hits1054010540 Misses 4266 4266 Partials33 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=footer). Last update [b512da8...3fbadd6](https://codecov.io/gh/apache/incubator-superset/pull/4582?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing
codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=h1) Report > Merging [#4552](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b512da8002dc0dc7f6a1f5eb983606118f484d32?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4552 +/- ## === Coverage 71.17% 71.17% === Files 187 187 Lines 1480914809 Branches 1085 1085 === Hits1054010540 Misses 4266 4266 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree) | Coverage ? | | |---|---|---| | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.12% <0%> (?)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=footer). Last update [b512da8...e4e1c55](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley opened a new pull request #4582: [code-climate] Deprecating Code Climate from JavaScript tests
john-bodley opened a new pull request #4582: [code-climate] Deprecating Code Climate from JavaScript tests URL: https://github.com/apache/incubator-superset/pull/4582 Given that we're now using `codecov` in Travis to process the various coverage reports, this PR deprecates outdated Code Climate logic. Note whilst processing `superset/assets/package.json` I also removed the unnecessary `node_modules/.bin/` path prefix for consistency. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster closed pull request #4570: Adding option to visualize negative values in Table view
williaster closed pull request #4570: Adding option to visualize negative
values in Table view
URL: https://github.com/apache/incubator-superset/pull/4570
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/assets/backendSync.json b/superset/assets/backendSync.json
index ba91b47cde..9e1ce4cd89 100644
--- a/superset/assets/backendSync.json
+++ b/superset/assets/backendSync.json
@@ -2214,6 +2214,20 @@
"default": false,
"description": "Whether to apply filter when table cell is clicked"
},
+"align_pn": {
+ "type": "CheckboxControl",
+ "label": "Align +/-",
+ "renderTrigger": true,
+ "default": false,
+ "description": "Whether to align the background chart for +/- values"
+},
+"color_pn": {
+ "type": "CheckboxControl",
+ "label": "Color +/-",
+ "renderTrigger": true,
+ "default": true,
+ "description": "Whether to color +/- values"
+},
"show_bubbles": {
"type": "CheckboxControl",
"label": "Show Bubbles",
@@ -2974,4 +2988,4 @@
"description": "Partitions whose height to parent height proportions are
below this value are pruned"
}
}
-}
\ No newline at end of file
+}
diff --git a/superset/assets/javascripts/explore/stores/controls.jsx
b/superset/assets/javascripts/explore/stores/controls.jsx
index 1a5b554297..ec4522be88 100644
--- a/superset/assets/javascripts/explore/stores/controls.jsx
+++ b/superset/assets/javascripts/explore/stores/controls.jsx
@@ -1325,6 +1325,22 @@ export const controls = {
description: t('Whether to apply filter when table cell is clicked'),
},
+ align_pn: {
+type: 'CheckboxControl',
+label: t('Align +/-'),
+renderTrigger: true,
+default: false,
+description: t('Whether to align the background chart for +/- values'),
+ },
+
+ color_pn: {
+type: 'CheckboxControl',
+label: t('Color +/-'),
+renderTrigger: true,
+default: true,
+description: t('Whether to color +/- values'),
+ },
+
show_bubbles: {
type: 'CheckboxControl',
label: t('Show Bubbles'),
diff --git a/superset/assets/javascripts/explore/stores/visTypes.js
b/superset/assets/javascripts/explore/stores/visTypes.js
index a4ffe4d22e..836da7b9cd 100644
--- a/superset/assets/javascripts/explore/stores/visTypes.js
+++ b/superset/assets/javascripts/explore/stores/visTypes.js
@@ -770,6 +770,7 @@ export const visTypes = {
['table_timestamp_format'],
['row_limit', 'page_length'],
['include_search', 'table_filter'],
+ ['align_pn', 'color_pn'],
],
},
],
diff --git a/superset/assets/visualizations/table.js
b/superset/assets/visualizations/table.js
index 6af73ca465..d00ba2af80 100644
--- a/superset/assets/visualizations/table.js
+++ b/superset/assets/visualizations/table.js
@@ -30,8 +30,14 @@ function tableVis(slice, payload) {
return arr;
}
const maxes = {};
+ const mins = {};
for (let i = 0; i < metrics.length; i += 1) {
-maxes[metrics[i]] = d3.max(col(metrics[i]));
+if (fd.align_pn) {
+ maxes[metrics[i]] = d3.max(col(metrics[i]).map(Math.abs));
+} else {
+ maxes[metrics[i]] = d3.max(col(metrics[i]));
+ mins[metrics[i]] = d3.min(col(metrics[i]));
+}
}
const tsFormatter = d3TimeFormatPreset(fd.table_timestamp_format);
@@ -100,12 +106,27 @@ function tableVis(slice, payload) {
.append('td')
.style('background-image', function (d) {
if (d.isMetric) {
-const perc = Math.round((d.val / maxes[d.col]) * 100);
+const r = (fd.color_pn && d.val < 0) ? 150 : 0;
+if (fd.align_pn) {
+ const perc = Math.abs(Math.round((d.val / maxes[d.col]) * 100));
+ // The 0.01 to 0.001 is a workaround for what appears to be a
+ // CSS rendering bug on flat, transparent colors
+ return (
+`linear-gradient(to right, rgba(${r},0,0,0.2), rgba(${r},0,0,0.2)
${perc}%, ` +
+`rgba(0,0,0,0.01) ${perc}%, rgba(0,0,0,0.001) 100%)`
+ );
+}
+const posExtent = Math.abs(Math.max(maxes[d.col], 0));
+const negExtent = Math.abs(Math.min(mins[d.col], 0));
+const tot = posExtent + negExtent;
+const perc1 = Math.round((Math.min(negExtent + d.val, negExtent) /
tot) * 100);
+const perc2 = Math.round((Math.abs(d.val) / tot) * 100);
// The 0.01 to 0.001 is a workaround for what appears to be a
// CSS rendering bug on flat, transparent colors
return (
- `linear-gradient(to left, rgba(0,0,0,0.2), rgba(0,0,0,0.2) ${perc}%,
` +
- `rgba(0,0,0,0.01) ${perc}%, rgba(0,0,0,0.001) 100%)`
+ `linear-gradient(to right, rgba(0,0,0,0.01), rgba(0,0,0,0.001)
[GitHub] michellethomas opened a new pull request #4581: Making timeseries_limit not required for phase 2
michellethomas opened a new pull request #4581: Making timeseries_limit not required for phase 2 URL: https://github.com/apache/incubator-superset/pull/4581 We have an issue on time series group by queries, if the chart doesn't have a limit, the data is incorrect. It gets run as a phase 1 query and shows only a single datapoint for each group by value instead of listing the full timeseries data. It looks like this was added [here](https://github.com/apache/incubator-superset/pull/4032/files#diff-a8dd5ec8d8decda2e3c5571d1ec0cdb6R1032), but I don't think queries without a limit should automatically be phase 1. I changed this but I'm not quite sure why it was added, is this needed for deckgl viz types? I tested this on time series phase 2 queries and phase 1 without a limit, and tested bar and pie chart visualizations. Fixes #4208 @mistercrunch @john-bodley This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4566: Adding column type label to dropdowns
codecov-io commented on issue #4566: Adding column type label to dropdowns URL: https://github.com/apache/incubator-superset/pull/4566#issuecomment-371269963 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=h1) Report > Merging [#4566](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/826d0631e04f96365bd35a913604932852371659?src=pr=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `58.69%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4566 +/- ## == - Coverage71.2% 71.17% -0.03% == Files 187 188 +1 Lines 1478514841 +56 Branches 1083 1096 +13 == + Hits1052710563 +36 - Misses 4255 4274 +19 - Partials34 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=tree) | Coverage ? | | |---|---|---| | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `66.66% <0%> (?)` | :arrow_up: | | [...set/assets/javascripts/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100% <100%> (?)` | :arrow_up: | | [...set/assets/javascripts/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `90.47% <75%> (-9.53%)` | :arrow_down: | | [.../assets/javascripts/components/ColumnTypeLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQ29sdW1uVHlwZUxhYmVsLmpzeA==) | `77.27% <77.27%> (?)` | | | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `37.59% <8.33%> (-0.58%)` | :arrow_down: | | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `73.33% <0%> (-4.93%)` | :arrow_down: | | [superset/assets/javascripts/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvaW5kZXguanN4) | `0% <0%> (?)` | :arrow_up: | | [...cripts/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `0% <0%> (?)` | :arrow_up: | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.12% <0%> (?)` | :arrow_up: | | ... and [3 more](https://codecov.io/gh/apache/incubator-superset/pull/4566/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=footer). Last update [826d063...4c3c5b8](https://codecov.io/gh/apache/incubator-superset/pull/4566?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on issue #4579: Removing [dashboard] and [slice] titles to show name
williaster commented on issue #4579: Removing [dashboard] and [slice] titles to
show name
URL:
https://github.com/apache/incubator-superset/pull/4579#issuecomment-371688774
what about just `Superset` in that case? Or `Superset - ${tableName}`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] williaster commented on issue #4579: Removing [dashboard] and [slice] titles to show name
williaster commented on issue #4579: Removing [dashboard] and [slice] titles to
show name
URL:
https://github.com/apache/incubator-superset/pull/4579#issuecomment-371688774
what about just "Superset" in that case? Or `Superset - ${tableName}`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] betodealmeida commented on a change in pull request #4572: Legend for deck.gl scatterplot
betodealmeida commented on a change in pull request #4572: Legend for deck.gl
scatterplot
URL:
https://github.com/apache/incubator-superset/pull/4572#discussion_r173347009
##
File path: superset/assets/visualizations/Legend.jsx
##
@@ -0,0 +1,42 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+
+import './Legend.css';
+
+const propTypes = {
+ categories: PropTypes.object,
+ toggleCategory: PropTypes.func,
+};
+
+const defaultProps = {
+ categories: {},
+ toggleCategory: () => {},
+};
+
+export default class Legend extends React.PureComponent {
Review comment:
My idea was to use this as a legend for all visualization types that don't
have a native one (like nvd3 has). Right now this component takes only a list
of categories and is not specific to maps.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] betodealmeida commented on issue #4572: Legend for deck.gl scatterplot
betodealmeida commented on issue #4572: Legend for deck.gl scatterplot URL: https://github.com/apache/incubator-superset/pull/4572#issuecomment-371687175  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] JaeGerW2016 opened a new issue #4580: Invalid identifier on visualize After a SQL query
JaeGerW2016 opened a new issue #4580: Invalid identifier on visualize After a SQL query URL: https://github.com/apache/incubator-superset/issues/4580 Invalid identifier on visualize After a SQL query then I View Query and copy it to SQL Editor The doubt is: the same sql can be queried in the SQL editor, in the visualize invalid identifier error This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] michellethomas commented on issue #4579: Removing [dashboard] and [slice] titles to show name
michellethomas commented on issue #4579: Removing [dashboard] and [slice] titles to show name URL: https://github.com/apache/incubator-superset/pull/4579#issuecomment-371666515 @williaster I added that originally but it just shows the table name if you are in explore which might just look a little confusing. I could also add [explore] at the end like `table_name [explore]` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4570: Adding option to visualize negative values in Table view
codecov-io commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371320334 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=h1) Report > Merging [#4570](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/826d0631e04f96365bd35a913604932852371659?src=pr=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4570 +/- ## == - Coverage71.2% 71.17% -0.03% == Files 187 187 Lines 1478514809 +24 Branches 1083 1085 +2 == + Hits1052710540 +13 - Misses 4255 4266 +11 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=tree) | Coverage ? | | |---|---|---| | [...rset/assets/javascripts/explore/stores/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/4570/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3Zpc1R5cGVzLmpz) | `70.58% (?)` | :arrow_up: | | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4570/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `38.16% (?)` | :arrow_up: | | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/4570/diff?src=pr=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `73.33% <0%> (-4.93%)` | :arrow_down: | | [superset/assets/javascripts/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4570/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvaW5kZXguanN4) | `0% <0%> (?)` | :arrow_up: | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4570/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.12% <0%> (?)` | :arrow_up: | | [...cripts/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4570/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `0% <0%> (?)` | :arrow_up: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4570/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.2% <0%> (+0.04%)` | :arrow_up: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4570/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `88.12% <0%> (+0.18%)` | :arrow_up: | | [...uperset/assets/javascripts/explore/stores/store.js](https://codecov.io/gh/apache/incubator-superset/pull/4570/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3N0b3JlLmpz) | `53.94% <0%> (+1.16%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=footer). Last update [826d063...452c697](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] elibrumbaugh commented on issue #4579: Removing [dashboard] and [slice] titles to show name
elibrumbaugh commented on issue #4579: Removing [dashboard] and [slice] titles to show name URL: https://github.com/apache/incubator-superset/pull/4579#issuecomment-371661615 Good call @williaster ! Thank you for making this happen @michellethomas !!! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tanvach commented on issue #4570: Adding option to visualize negative values in Table view
tanvach commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371659614 @williaster @john-bodley I've pushed the change to make coloring turned on as default. Thanks for reviewing the PR! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on issue #4570: Adding option to visualize negative values in Table view
williaster commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371654731 thanks @tanvach! @john-bodley and I think this looks good but think coloring should probably be on by default as it's possibly confusing for `+` and `-` to appear the same if you don't know it's a setting. will merge after that ? sorry for the back and forth, thanks again for adding this! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on a change in pull request #4579: Removing [dashboard] and [slice] titles to show name
williaster commented on a change in pull request #4579: Removing [dashboard] and [slice] titles to show name URL: https://github.com/apache/incubator-superset/pull/4579#discussion_r173318329 ## File path: superset/views/core.py ## @@ -1297,7 +1297,7 @@ def explore(self, datasource_type=None, datasource_id=None): if datasource_type == 'table' \ else datasource.datasource_name if slc: -title = '[slice] ' + slc.slice_name +title = slc.slice_name else: title = '[explore] ' + table_name Review comment: do you think we should change this as well? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa commented on issue #4579: Removing [dashboard] and [slice] titles to show name
timifasubaa commented on issue #4579: Removing [dashboard] and [slice] titles to show name URL: https://github.com/apache/incubator-superset/pull/4579#issuecomment-371651462 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4579: Removing [dashboard] and [slice] titles to show name
codecov-io commented on issue #4579: Removing [dashboard] and [slice] titles to show name URL: https://github.com/apache/incubator-superset/pull/4579#issuecomment-371642722 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4579?src=pr=h1) Report > Merging [#4579](https://codecov.io/gh/apache/incubator-superset/pull/4579?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9edbd64c5d2ac05c7a4a9eba8bb6de0d1ba4de03?src=pr=desc) will **not change** coverage. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4579?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4579 +/- ## === Coverage 71.17% 71.17% === Files 187 187 Lines 1480914809 Branches 1085 1085 === Hits1054010540 Misses 4266 4266 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4579?src=pr=tree) | Coverage ? | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4579/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.2% <0%> (?)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4579?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4579?src=pr=footer). Last update [9edbd64...402c7dd](https://codecov.io/gh/apache/incubator-superset/pull/4579?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] michellethomas opened a new pull request #4579: Removing [dashboard] and [slice] titles to show name
michellethomas opened a new pull request #4579: Removing [dashboard] and [slice] titles to show name URL: https://github.com/apache/incubator-superset/pull/4579 Showing [dashboard] and [slice] hide the name of the dashboard or slice in the tab. Anyone object to removing these labels? @john-bodley @graceguo-supercat @mistercrunch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] graceguo-supercat closed issue #4439: URL parameters not saved for a slice in explorer view
graceguo-supercat closed issue #4439: URL parameters not saved for a slice in explorer view URL: https://github.com/apache/incubator-superset/issues/4439 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] graceguo-supercat closed pull request #4578: [Explore] Save custom url parameters when user save slices
graceguo-supercat closed pull request #4578: [Explore] Save custom url
parameters when user save slices
URL: https://github.com/apache/incubator-superset/pull/4578
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/superset/assets/javascripts/explore/components/ExploreViewContainer.jsx
b/superset/assets/javascripts/explore/components/ExploreViewContainer.jsx
index e1b7acbee0..a254ded44b 100644
--- a/superset/assets/javascripts/explore/components/ExploreViewContainer.jsx
+++ b/superset/assets/javascripts/explore/components/ExploreViewContainer.jsx
@@ -293,6 +293,13 @@ ExploreViewContainer.propTypes = propTypes;
function mapStateToProps({ explore, charts, impressionId }) {
const form_data = getFormDataFromControls(explore.controls);
+ // fill in additional params stored in form_data but not used by control
+ Object.keys(explore.rawFormData)
+.forEach((key) => {
+ if (form_data[key] === undefined) {
+form_data[key] = explore.rawFormData[key];
+ }
+});
const chartKey = Object.keys(charts)[0];
const chart = charts[chartKey];
return {
diff --git a/superset/assets/javascripts/explore/index.jsx
b/superset/assets/javascripts/explore/index.jsx
index 35eb68db97..74f5a0bb68 100644
--- a/superset/assets/javascripts/explore/index.jsx
+++ b/superset/assets/javascripts/explore/index.jsx
@@ -25,6 +25,7 @@ initJQueryAjax();
const exploreViewContainer = document.getElementById('app');
const bootstrapData =
JSON.parse(exploreViewContainer.getAttribute('data-bootstrap'));
const controls = getControlsState(bootstrapData, bootstrapData.form_data);
+const rawFormData = { ...bootstrapData.form_data };
delete bootstrapData.form_data;
delete bootstrapData.common.locale;
delete bootstrapData.common.language_pack;
@@ -32,6 +33,7 @@ delete bootstrapData.common.language_pack;
// Initial state
const bootstrappedState = Object.assign(
bootstrapData, {
+rawFormData,
controls,
filterColumnOpts: [],
isDatasourceMetaLoading: false,
diff --git a/superset/assets/javascripts/explore/stores/store.js
b/superset/assets/javascripts/explore/stores/store.js
index 02bd121e65..4f1e7b5612 100644
--- a/superset/assets/javascripts/explore/stores/store.js
+++ b/superset/assets/javascripts/explore/stores/store.js
@@ -109,6 +109,13 @@ export function applyDefaultFormData(form_data) {
formData[k] = form_data[k];
}
});
+ // fill in additional params stored in form_data but not used by control
+ Object.keys(form_data)
+.forEach((key) => {
+ if (formData[key] === undefined) {
+formData[key] = form_data[key];
+ }
+});
return formData;
}
diff --git a/superset/jinja_context.py b/superset/jinja_context.py
index fe93594fce..ce8795acf2 100644
--- a/superset/jinja_context.py
+++ b/superset/jinja_context.py
@@ -7,6 +7,7 @@
from datetime import datetime, timedelta
import inspect
+import json
import random
import time
import uuid
@@ -30,15 +31,21 @@
def url_param(param, default=None):
-"""Get a url paramater
+"""Get a url or post data parameter
-:param param: the url parameter to lookup
+:param param: the parameter to lookup
:type param: str
:param default: the value to return in the absence of the parameter
:type default: str
"""
-print(request.args)
-return request.args.get(param, default)
+if request.args.get(param):
+return request.args.get(param, default)
+# Supporting POST as well as get
+if request.form.get('form_data'):
+form_data = json.loads(request.form.get('form_data'))
+url_params = form_data['url_params'] or {}
+return url_params.get(param, default)
+return default
def current_user_id():
diff --git a/superset/utils.py b/superset/utils.py
index c60f128d0e..ab3cef8a22 100644
--- a/superset/utils.py
+++ b/superset/utils.py
@@ -835,6 +835,15 @@ def get_filter_key(f):
del form_data['extra_filters']
+def merge_request_params(form_data, params):
+url_params = {}
+for key, value in params.items():
+if key in ('form_data', 'r'):
+continue
+url_params[key] = value
+form_data['url_params'] = url_params
+
+
def get_update_perms_flag():
val = os.environ.get('SUPERSET_UPDATE_PERMS')
return val.lower() not in ('0', 'false', 'no') if val else True
diff --git a/superset/views/core.py b/superset/views/core.py
index d5cd1689c5..4330e7d7ee 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -43,7 +43,9 @@
import superset.models.core as models
from superset.models.sql_lab import Query
from superset.sql_parse import SupersetQuery
-from superset.utils import has_access, merge_extra_filters, QueryStatus
+from superset.utils import
[GitHub] michellethomas commented on issue #4578: [Explore] Save custom url parameters when user save slices
michellethomas commented on issue #4578: [Explore] Save custom url parameters when user save slices URL: https://github.com/apache/incubator-superset/pull/4578#issuecomment-371623330 lgtm This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4578: [Explore] Save custom url parameters when user save slices
codecov-io commented on issue #4578: [Explore] Save custom url parameters when user save slices URL: https://github.com/apache/incubator-superset/pull/4578#issuecomment-371622470 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4578?src=pr=h1) Report > Merging [#4578](https://codecov.io/gh/apache/incubator-superset/pull/4578?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/42ebcaad40fff66b4cc833a04f988c5949280014?src=pr=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `51.85%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4578?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4578 +/- ## == - Coverage71.2% 71.17% -0.03% == Files 187 187 Lines 1478514809 +24 Branches 1083 1085 +2 == + Hits1052710540 +13 - Misses 4255 4266 +11 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4578?src=pr=tree) | Coverage ? | | |---|---|---| | [...cripts/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4578/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `0% <0%> (?)` | :arrow_up: | | [superset/assets/javascripts/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4578/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvaW5kZXguanN4) | `0% <0%> (?)` | :arrow_up: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4578/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `88.12% <100%> (+0.18%)` | :arrow_up: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4578/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.2% <100%> (+0.04%)` | :arrow_up: | | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/4578/diff?src=pr=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `73.33% <12.5%> (-4.93%)` | :arrow_down: | | [...uperset/assets/javascripts/explore/stores/store.js](https://codecov.io/gh/apache/incubator-superset/pull/4578/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3N0b3JlLmpz) | `53.94% <75%> (+1.16%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4578?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4578?src=pr=footer). Last update [42ebcaa...d34ca5a](https://codecov.io/gh/apache/incubator-superset/pull/4578?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4503: [Explore] Save custom url parameters when user save slices
codecov-io commented on issue #4503: [Explore] Save custom url parameters when user save slices URL: https://github.com/apache/incubator-superset/pull/4503#issuecomment-371619489 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4503?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@4135854`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `58%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4503?src=pr=tree) ```diff @@Coverage Diff@@ ## master#4503 +/- ## = Coverage ? 71.17% = Files ? 187 Lines ?14809 Branches ? 1085 = Hits ?10540 Misses? 4266 Partials ?3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4503?src=pr=tree) | Coverage ? | | |---|---|---| | [superset/assets/javascripts/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4503/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL3dlbGNvbWUvQXBwLmpzeA==) | `94.44% (?)` | | | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4503/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `52.25% <0%> (?)` | | | [superset/assets/javascripts/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4503/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvaW5kZXguanN4) | `0% <0%> (?)` | | | [...cripts/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4503/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `0% <0%> (?)` | | | [superset/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/4503/diff?src=pr=tree#diff-c3VwZXJzZXQvX19pbml0X18ucHk=) | `71.69% <100%> (?)` | | | [.../assets/javascripts/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4503/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `88.88% <100%> (?)` | | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4503/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `78.45% <100%> (?)` | | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4503/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.12% <100%> (?)` | | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4503/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `88.12% <100%> (?)` | | | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/4503/diff?src=pr=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `73.33% <12.5%> (?)` | | | ... and [3 more](https://codecov.io/gh/apache/incubator-superset/pull/4503/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4503?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4503?src=pr=footer). Last update [4135854...38a7627](https://codecov.io/gh/apache/incubator-superset/pull/4503?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4503: [Explore] Save custom url parameters when user save slices
codecov-io commented on issue #4503: [Explore] Save custom url parameters when user save slices URL: https://github.com/apache/incubator-superset/pull/4503#issuecomment-371619489 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4503?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@4135854`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `58%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4503?src=pr=tree) ```diff @@Coverage Diff@@ ## master#4503 +/- ## = Coverage ? 71.17% = Files ? 187 Lines ?14809 Branches ? 1085 = Hits ?10540 Misses? 4266 Partials ?3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4503?src=pr=tree) | Coverage ? | | |---|---|---| | [superset/assets/javascripts/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4503/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL3dlbGNvbWUvQXBwLmpzeA==) | `94.44% (?)` | | | [...cripts/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4503/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `0% <0%> (?)` | | | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4503/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `52.25% <0%> (?)` | | | [superset/assets/javascripts/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4503/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvaW5kZXguanN4) | `0% <0%> (?)` | | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4503/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.12% <100%> (?)` | | | [.../assets/javascripts/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4503/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `88.88% <100%> (?)` | | | [superset/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/4503/diff?src=pr=tree#diff-c3VwZXJzZXQvX19pbml0X18ucHk=) | `71.69% <100%> (?)` | | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4503/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `78.45% <100%> (?)` | | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4503/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `88.12% <100%> (?)` | | | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/4503/diff?src=pr=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `73.33% <12.5%> (?)` | | | ... and [3 more](https://codecov.io/gh/apache/incubator-superset/pull/4503/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4503?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4503?src=pr=footer). Last update [4135854...38a7627](https://codecov.io/gh/apache/incubator-superset/pull/4503?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] graceguo-supercat opened a new pull request #4578: [Explore] Save custom url parameters when user save slices
graceguo-supercat opened a new pull request #4578: [Explore] Save custom url parameters when user save slices URL: https://github.com/apache/incubator-superset/pull/4578 fix #4439 when user passed custom parameters in /explore/ request, i build these request parameters into form_data. So that request parameters become part of query state. when user save slice, i will save this form_data as slice parameter, so that query state is persistence. I also update jinja helper function url_param to read parameters from post form as well as request url. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4570: Adding option to visualize negative values in Table view
codecov-io commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371320334 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=h1) Report > Merging [#4570](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/826d0631e04f96365bd35a913604932852371659?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #4570 +/- ## == Coverage71.2% 71.2% == Files 187 187 Lines 14785 14785 Branches 10831083 == Hits10527 10527 Misses 42554255 Partials3 3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=tree) | Coverage ? | | |---|---|---| | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4570/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `38.16% (?)` | :arrow_up: | | [...rset/assets/javascripts/explore/stores/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/4570/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3Zpc1R5cGVzLmpz) | `70.58% (?)` | :arrow_up: | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4570/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.12% <0%> (?)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=footer). Last update [826d063...c4e3e8c](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley commented on issue #4570: Adding option to visualize negative values in Table view
john-bodley commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371602918 I agree with @williaster regarding not having to preserve backwards compatibility and that left aligned bars make the most sense. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tanvach commented on issue #4570: Adding option to visualize negative values in Table view
tanvach commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371598370 @williaster I've made red channel = 150 and it does look better. Here's aligning to the left. Actually I remember we used to have left aligned bars a few versions before. If we're doing this I'll just make these options default to off.  For the option labels, took out 'by' and looks better  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4570: Adding option to visualize negative values in Table view
codecov-io commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371320334 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=h1) Report > Merging [#4570](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/826d0631e04f96365bd35a913604932852371659?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #4570 +/- ## == Coverage71.2% 71.2% == Files 187 187 Lines 14785 14785 Branches 10831083 == Hits10527 10527 Misses 42554255 Partials3 3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=tree) | Coverage ? | | |---|---|---| | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4570/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `38.16% (?)` | :arrow_up: | | [...rset/assets/javascripts/explore/stores/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/4570/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3Zpc1R5cGVzLmpz) | `70.58% (?)` | :arrow_up: | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4570/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.12% <0%> (?)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=footer). Last update [826d063...b9bb2df](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4570: Adding option to visualize negative values in Table view
codecov-io commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371320334 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=h1) Report > Merging [#4570](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/826d0631e04f96365bd35a913604932852371659?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #4570 +/- ## == Coverage71.2% 71.2% == Files 187 187 Lines 14785 14785 Branches 10831083 == Hits10527 10527 Misses 42554255 Partials3 3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=tree) | Coverage ? | | |---|---|---| | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4570/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `38.16% (?)` | :arrow_up: | | [...rset/assets/javascripts/explore/stores/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/4570/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3Zpc1R5cGVzLmpz) | `70.58% (?)` | :arrow_up: | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4570/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.12% <0%> (?)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=footer). Last update [826d063...b9bb2df](https://codecov.io/gh/apache/incubator-superset/pull/4570?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on issue #4570: Adding option to visualize negative values in Table view
williaster commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371589859 @tanvach thanks for exploring these options! I agree that exposing the controls to the user is ideal given the tradeoffs. a couple more thoughts: - I think the label "Highlight negative" and "Right align" don't quite make it obvious what these do. What do you think about "Align by +/- "Color by +/-" (@john-bodley might have thoughts too) - I don't think that backwards compatibility is important here. actually I think it's strange that the bars were right-aligned to start, so I would suggest the behavior be either: align everything left, or align by +/- - would it be possible to make the red a little more obvious? it's not super differentiable from grey to me thoughts? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4570: Adding option to visualize negative values in Table view
mistercrunch commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371577255 +1 you'll need some css3 kung fu to make that happen :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #4550: Evelynturner/annotation timezone fix2
mistercrunch closed pull request #4550: Evelynturner/annotation timezone fix2
URL: https://github.com/apache/incubator-superset/pull/4550
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/assets/visualizations/nvd3_vis.js
b/superset/assets/visualizations/nvd3_vis.js
index 3739aa4102..8bd7229710 100644
--- a/superset/assets/visualizations/nvd3_vis.js
+++ b/superset/assets/visualizations/nvd3_vis.js
@@ -670,8 +670,8 @@ function nvd3Vis(slice, payload) {
const tip = tipFactory(e);
const records = (slice.annotationData[e.name].records ||
[]).map((r) => {
- const timeColumn = new Date(r[e.timeColumn]);
- const intervalEndColumn = new Date(r[e.intervalEndColumn]);
+ const timeColumn = new Date(moment.utc(r[e.timeColumn]));
+ const intervalEndColumn = new
Date(moment.utc(r[e.intervalEndColumn]));
return {
...r,
[e.timeColumn]: timeColumn,
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] hughhhh commented on a change in pull request #4572: Legend for deck.gl scatterplot
hug commented on a change in pull request #4572: Legend for deck.gl
scatterplot
URL:
https://github.com/apache/incubator-superset/pull/4572#discussion_r173236890
##
File path: superset/assets/visualizations/Legend.jsx
##
@@ -0,0 +1,42 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+
+import './Legend.css';
+
+const propTypes = {
+ categories: PropTypes.object,
+ toggleCategory: PropTypes.func,
+};
+
+const defaultProps = {
+ categories: {},
+ toggleCategory: () => {},
+};
+
+export default class Legend extends React.PureComponent {
Review comment:
Can we name this `MapLegend` or do you seeing this being extended to all
visualizations?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] darylerwin commented on issue #4577: Should version be showing 23.2 from the UI
darylerwin commented on issue #4577: Should version be showing 23.2 from the UI URL: https://github.com/apache/incubator-superset/issues/4577#issuecomment-371566577 reran and refresh and it shows correctly. I must have missed a step. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] darylerwin closed issue #4577: Should version be showing 23.2 from the UI
darylerwin closed issue #4577: Should version be showing 23.2 from the UI URL: https://github.com/apache/incubator-superset/issues/4577 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] darylerwin opened a new issue #4577: Should version be showing 23.2 from the UI
darylerwin opened a new issue #4577: Should version be showing 23.2 from the UI
URL: https://github.com/apache/incubator-superset/issues/4577
Make sure these boxes are checked before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included
it here as text if any
- [ ] I have reproduced the issue with at least the latest released version
of superset
- [ ] I have checked the issue tracker for the same issue and I haven't
found one similar
### Superset version
23.2
### Expected results
{"GIT_SHA": "", "version": "0.23.2"}
### Actual results
{"GIT_SHA": "", "version": "0.22.1"}
### Steps to reproduce
. ./venv/bin/activate
pip install superset --upgrade
superset db upgrade
superset init
Just clicked on the UI show version.
Did I miss a step in the upgrade process?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] tanvach commented on issue #4570: Adding option to visualize negative values in Table view
tanvach commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371549279 @john-bodley @williaster Since I think the best viz type depends on context, I've simply added options: `Right Align` and `Highlight Negative`. By default these are on, meaning it will right align the bar charts and coloring negative numbers (to be backwards compatible with current viz style). By turning `Right Align` off you will get bars going left for negative and right for positive. https://user-images.githubusercontent.com/729913/37164007-0b14540e-22ae-11e8-8961-0a79ae9c9fb5.png;> This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] EricDiepeveen commented on issue #4576: Upload a csv via gui points to non existing folder: '.../superset/app/static/uploads/data.csv'
EricDiepeveen commented on issue #4576: Upload a csv via gui points to non existing folder: '.../superset/app/static/uploads/data.csv' URL: https://github.com/apache/incubator-superset/issues/4576#issuecomment-371524655 Same happens here. Added the folder and set the permissions. That fixed the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] TMorville opened a new issue #4576: Upload a csv via gui points to non existing folder: '.../superset/app/static/uploads/data.csv'
TMorville opened a new issue #4576: Upload a csv via gui points to non existing folder: '.../superset/app/static/uploads/data.csv' URL: https://github.com/apache/incubator-superset/issues/4576 Make sure these boxes are checked before submitting your issue - thank you! - [x] I have checked the superset logs for python stacktraces and included it here as text if any - [x] I have reproduced the issue with at least the latest released version of superset - [x] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version: superset==0.23.2 ### Expected results: being able to upload a .csv file ### Actual results: Throws error `[Errno 2] No such file or directory: '/anaconda3/lib/python3.6/site-packages/superset/app/static/uploads/data.csv'` This is not the path where the data is stored. ### Steps to reproduce: Trying to upload a .csv file via the gui. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] IanWE opened a new issue #4575: Remove Permission from View Error
IanWE opened a new issue #4575: Remove Permission from View Error URL: https://github.com/apache/incubator-superset/issues/4575 I got this problem,Who can tell me how to solve it? database is sqlite3 superset version 2018-03-08 17:24:48,383:ERROR:flask_appbuilder.security.sqla.manager:Remove Permission from View Error: DELETE statement on table 'ab_permission_view_role' expected to delete 1 row(s); Only 2 were matched. 2018-03-08 17:24:48,435:ERROR:flask_appbuilder.security.sqla.manager:Remove Permission from View Error: DELETE statement on table 'ab_permission_view_role' expected to delete 1 row(s); Only 2 were matched. 2018-03-08 17:24:48,460:ERROR:flask_appbuilder.security.sqla.manager:Remove Permission from View Error: DELETE statement on table 'ab_permission_view_role' expected to delete 1 row(s); Only 2 were matched. ### Superset version This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] IanWE commented on issue #3061: when create a new role in superset python2.7
IanWE commented on issue #3061: when create a new role in superset python2.7 URL: https://github.com/apache/incubator-superset/issues/3061#issuecomment-371429629 I got the same problem,Can you tell me how to solve it@akfdgg This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tanvach commented on issue #4570: Adding option to visualize negative values in Table view
tanvach commented on issue #4570: Adding option to visualize negative values in Table view URL: https://github.com/apache/incubator-superset/pull/4570#issuecomment-371425925 Maybe I'm just used to [domain coloring ](https://en.wikipedia.org/wiki/Domain_coloring) since I think negative number is just a positive number with 180 deg phase angle :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #4569: Thrift-sasl install problem
xrmx commented on issue #4569: Thrift-sasl install problem URL: https://github.com/apache/incubator-superset/issues/4569#issuecomment-371414691 Then as the error suggests it may have been a network problem. If you retry it should work. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jerowe opened a new issue #4574: Feature Request - Additional Color Gradients
jerowe opened a new issue #4574: Feature Request - Additional Color Gradients URL: https://github.com/apache/incubator-superset/issues/4574 This is not a bug, but a feature request, or a point me towards code so I can do it request. ;-) I would like to have some additional color gradient options, specifically for the heatmap. I have several heatmaps with thresholds, which leads to empty cells. These cells are white, but white is also a color in the gradient. Please see attached. It is impossible to tell if values are empty, they did not make the cutoff, or if they are '1' (in this case).  Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
