[GitHub] jhettler commented on issue #4770: Cannot display Time Series Line Chart
jhettler commented on issue #4770: Cannot display Time Series Line Chart URL: https://github.com/apache/incubator-superset/issues/4770#issuecomment-379154535 Hi, I have found the similar issue yesterday on 0.24.0. And it is not a problem only in Time Series Line Chart, I was able to reproduce it with Pie Chart and Histogram as well, I didn't try more visualizations. In my case, we use Snowflake database and I expected it is related to DB engine and I am still not sure what's exactly wrong, everything works fine with Superset examples and as well if I add the tables from Snowflake straight from dialog Sources/Tables/Add table (plus icon in right upper corner). But if I try to create datasource/table from query it didn't work. Then I realize there are quotes around column names in query (view query menu in graph view - upper right corner). Same as in @syzuhdi case > SELECT "CITY", > "timestamp", > "count_QTY" I tried to lowercase all column names and whoila, everything works. Lowercased name of columns are not in doublequotes and it is correctly interpreted. I made following steps: 1. Run a query in SQL lab 2. Visualize it - it will ask for datasource name 3. Save the visualization 4. Go to Sources/Tables and edit the table/datasource you created in step 2 5. Rename all columns to lowercase 6. Try to visualize graph It's not nice, but it works for us as a temporary workaround. HTH. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jhettler commented on issue #4770: Cannot display Time Series Line Chart
jhettler commented on issue #4770: Cannot display Time Series Line Chart URL: https://github.com/apache/incubator-superset/issues/4770#issuecomment-379154535 Hi, I have found the similar issue yesterday on 0.24.0. And it is no a problem only in Time Series Line Chart, I was able to reproduce it with Pie Chart and Histogram as well, I didn't try more visualizations. In my case, we use Snowflake database and I expected it is related to DB engine and I am still not sure what's exactly wrong, everything works fine with Superset examples and as well if I add the tables from Snowflake straight from dialog Sources/Tables/Add table (plus icon in right upper corner). But if I try to create datasource/table from query it didn't work. Then I realize there are quotes around column names in query (view query menu in graph view - upper right corner). Same as in @syzuhdi case > SELECT "CITY", > "timestamp", > "count_QTY" I tried to lowercase all column names and whoila, everything works. Lowercased name of columns are not in doublequotes and it is correctly interpreted. I made following steps: 1. Run a query in SQL lab 2. Visualize it - it will ask for datasource name 3. Save the visualization 4. Go to Sources/Tables and edit the table/datasource you created in step 2 5. Rename all columns to lowercase 6. Try to visualize graph It's not nice, but it works for us as a temporary workaround. HTH. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jhettler commented on issue #4770: Cannot display Time Series Line Chart
jhettler commented on issue #4770: Cannot display Time Series Line Chart URL: https://github.com/apache/incubator-superset/issues/4770#issuecomment-379154535 Hi, I have found the similar issue yesterday on 0.24.0. In my case, we use Snowflake database and I expected it is related to DB engine and I am still not sure what's exactly wrong, everything works fine with Superset examples and as well if I add the tables from Snowflake straight from dialog Sources/Tables/Add table (plus icon in right upper corner). But if I try to create datasource/table from query it didn't work. Then I realize there are quotes around column names in query (view query menu in graph view - upper right corner). Same as in @syzuhdi case > SELECT "CITY", > "timestamp", > "count_QTY" I tried to lowercase all column names and whoila, everything works. Lowercased name of columns are not in doublequotes and it is correctly interpreted. I made following steps: 1. Run a query in SQL lab 2. Visualize it - it will ask for datasource name 3. Save the visualization 4. Go to Sources/Tables and edit the table/datasource you created in step 2 5. Rename all columns to lowercase 6. Try to visualize graph It's not nice, but it works for us as a temporary workaround. HTH. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart
codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart URL: https://github.com/apache/incubator-superset/pull/4772#issuecomment-379125594 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=h1) Report > Merging [#4772](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92230b853566de2ee55c55c49a2b1b41e10a6d10?src=pr=desc) will **increase** coverage by `0.08%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4772 +/- ## == + Coverage 72.59% 72.67% +0.08% == Files 205 205 Lines 1540115401 Branches 1183 1183 == + Hits1118011193 +13 + Misses 4218 4205 -13 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.45% <ø> (+0.97%)` | :arrow_up: | | [...ssets/javascripts/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `93.75% <100%> (ø)` | :arrow_up: | | [superset/assets/javascripts/dashboard/reducers.js](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9yZWR1Y2Vycy5qcw==) | `50% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=footer). Last update [92230b8...b8a396f](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart
codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart URL: https://github.com/apache/incubator-superset/pull/4772#issuecomment-379125594 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=h1) Report > Merging [#4772](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92230b853566de2ee55c55c49a2b1b41e10a6d10?src=pr=desc) will **increase** coverage by `0.08%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4772 +/- ## == + Coverage 72.59% 72.67% +0.08% == Files 205 205 Lines 1540115401 Branches 1183 1183 == + Hits1118011193 +13 + Misses 4218 4205 -13 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.45% <ø> (+0.97%)` | :arrow_up: | | [...ssets/javascripts/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `93.75% <100%> (ø)` | :arrow_up: | | [superset/assets/javascripts/dashboard/reducers.js](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9yZWR1Y2Vycy5qcw==) | `50% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=footer). Last update [92230b8...b8a396f](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart
codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart URL: https://github.com/apache/incubator-superset/pull/4772#issuecomment-379125594 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=h1) Report > Merging [#4772](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92230b853566de2ee55c55c49a2b1b41e10a6d10?src=pr=desc) will **increase** coverage by `0.08%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4772 +/- ## == + Coverage 72.59% 72.67% +0.08% == Files 205 205 Lines 1540115401 Branches 1183 1183 == + Hits1118011193 +13 + Misses 4218 4205 -13 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.45% <ø> (+0.97%)` | :arrow_up: | | [...ssets/javascripts/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `93.75% <100%> (ø)` | :arrow_up: | | [superset/assets/javascripts/dashboard/reducers.js](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9yZWR1Y2Vycy5qcw==) | `50% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=footer). Last update [92230b8...b8a396f](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4770: Cannot display Time Series Line Chart
mistercrunch commented on issue #4770: Cannot display Time Series Line Chart URL: https://github.com/apache/incubator-superset/issues/4770#issuecomment-379145499 Can you try on `0.24.0` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4770: Cannot display Time Series Line Chart
mistercrunch commented on issue #4770: Cannot display Time Series Line Chart URL: https://github.com/apache/incubator-superset/issues/4770#issuecomment-379145499 Can you try on `0.24.0`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on a change in pull request #4756: Improve xAxis ticks, thinner bottom margin
mistercrunch commented on a change in pull request #4756: Improve xAxis ticks,
thinner bottom margin
URL:
https://github.com/apache/incubator-superset/pull/4756#discussion_r179658357
##
File path: superset/assets/javascripts/utils/common.js
##
@@ -86,3 +86,12 @@ export function getShortUrl(longUrl, callback) {
},
});
}
+
+export function isTruthy(obj) {
Review comment:
It has to do with backward compatibility here. There's been a few instances
of `CheckboxControl` becoming a `SelectControl`. In this case the `show_brush`
used to be checkbox and now is `auto`, `Yes` or 'No'.
Since it's not the first time and won't be the last, we decided to go this
route.
The alternatives would be to either:
* write database migrations to alter all slices and replace `True` with
`'Yes'` but that's more work and db migration have maintenance overhead.
* systematically use `if (fd.show_brush === true || fd.show_brush ===
'yes')` everywhere
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mistercrunch commented on issue #4773: Fix brush with annotations
mistercrunch commented on issue #4773: Fix brush with annotations URL: https://github.com/apache/incubator-superset/pull/4773#issuecomment-379144362 LGTM. Leaving a bit more time if other committers want to take a look This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4773: Fix brush with annotations
codecov-io commented on issue #4773: Fix brush with annotations URL: https://github.com/apache/incubator-superset/pull/4773#issuecomment-379135096 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4773?src=pr=h1) Report > Merging [#4773](https://codecov.io/gh/apache/incubator-superset/pull/4773?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92230b853566de2ee55c55c49a2b1b41e10a6d10?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4773?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4773 +/- ## === Coverage 72.59% 72.59% === Files 205 205 Lines 1540115401 Branches 1183 1183 === Hits1118011180 Misses 4218 4218 Partials33 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4773?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4773?src=pr=footer). Last update [92230b8...0d9d86c](https://codecov.io/gh/apache/incubator-superset/pull/4773?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4773: Fix brush with annotations
codecov-io commented on issue #4773: Fix brush with annotations URL: https://github.com/apache/incubator-superset/pull/4773#issuecomment-379135096 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4773?src=pr=h1) Report > Merging [#4773](https://codecov.io/gh/apache/incubator-superset/pull/4773?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92230b853566de2ee55c55c49a2b1b41e10a6d10?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4773?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4773 +/- ## === Coverage 72.59% 72.59% === Files 205 205 Lines 1540115401 Branches 1183 1183 === Hits1118011180 Misses 4218 4218 Partials33 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4773?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4773?src=pr=footer). Last update [92230b8...0d9d86c](https://codecov.io/gh/apache/incubator-superset/pull/4773?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] betodealmeida opened a new pull request #4773: Fix brush with annotations
betodealmeida opened a new pull request #4773: Fix brush with annotations URL: https://github.com/apache/incubator-superset/pull/4773 The brush (time filter) currently does not work with annotations:  I added a new callback that is dispatched when the brush is updated, and now it works:  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart
codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart URL: https://github.com/apache/incubator-superset/pull/4772#issuecomment-379125594 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=h1) Report > Merging [#4772](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92230b853566de2ee55c55c49a2b1b41e10a6d10?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4772 +/- ## == + Coverage 72.59% 72.59% +<.01% == Files 205 205 Lines 1540115402 +1 Branches 1183 1183 == + Hits1118011181 +1 Misses 4218 4218 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=tree) | Coverage Δ | | |---|---|---| | [...cripts/dashboard/components/DashboardContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZENvbnRhaW5lci5qc3g=) | `0% <ø> (ø)` | :arrow_up: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.5% <100%> (+0.01%)` | :arrow_up: | | [...ssets/javascripts/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `93.75% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=footer). Last update [92230b8...b248744](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch opened a new pull request #4772: [dashboard] open in edit mode when adding a chart
mistercrunch opened a new pull request #4772: [dashboard] open in edit mode when adding a chart URL: https://github.com/apache/incubator-superset/pull/4772 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabeLoins commented on a change in pull request #4756: Improve xAxis ticks, thinner bottom margin
GabeLoins commented on a change in pull request #4756: Improve xAxis ticks,
thinner bottom margin
URL:
https://github.com/apache/incubator-superset/pull/4756#discussion_r179639918
##
File path: superset/assets/javascripts/utils/common.js
##
@@ -86,3 +86,12 @@ export function getShortUrl(longUrl, callback) {
},
});
}
+
+export function isTruthy(obj) {
Review comment:
acknowledging I have very little context here- this seems like a bad road to
go down. We use YAML for plenty of stuff over here and there have been many
issues caused by someone not expecting `True`/`t`/`yes` to be true...
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mistercrunch opened a new pull request #4771: [druid] fix 'Unorderable types' when col has nuls
mistercrunch opened a new pull request #4771: [druid] fix 'Unorderable types'
when col has nuls
URL: https://github.com/apache/incubator-superset/pull/4771
Error "unorderable types: str() < int()" occurs when grouping by a
numerical Druid colummn that contains null values.
* druid/pydruid returns strings in the datafram with NAs for nulls
* Superset has custom logic around get_fillna_for_col that fills in the
NULLs based on declared column type (FLOAT here), so now we have a mixed
bag of type in the series
* pandas chokes on pivot_table or groupby operations as it cannot sorts
mixed types
The approach here is to stringify and fillna('') to get a
consistent series.
Related: https://github.com/apache/incubator-superset/issues/3029
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] syzuhdi opened a new issue #4770: Cannot display Time Series Line Chart
syzuhdi opened a new issue #4770: Cannot display Time Series Line Chart
URL: https://github.com/apache/incubator-superset/issues/4770
Make sure these boxes are checked before submitting your issue - thank you!
- [X] I have checked the superset logs for python stacktraces and included
it here as text if any
- [X] I have reproduced the issue with at least the latest released version
of superset
- [X] I have checked the issue tracker for the same issue and I haven't
found one similar
### Superset version
0.22.1
### Expected results
Data shown in Time series Line Chart
### Actual results
When I click Run Query button in Slices, an error occur.
Error u'CITY'
Traceback (most recent call last):
File "/usr/local/venv/lib/python2.7/site-packages/superset/viz.py", line
278, in get_payload
data = self.get_data(df)
File "/usr/local/venv/lib/python2.7/site-packages/superset/viz.py", line
1045, in get_data
df = self.process_data(df)
File "/usr/local/venv/lib/python2.7/site-packages/superset/viz.py", line
981, in process_data
values=fd.get('metrics'))
File
"/usr/local/venv/lib/python2.7/site-packages/pandas/core/reshape/pivot.py",
line 135, in pivot_table
grouped = data.groupby(keys)
File "/usr/local/venv/lib/python2.7/site-packages/pandas/core/generic.py",
line 4416, in groupby
**kwargs)
File "/usr/local/venv/lib/python2.7/site-packages/pandas/core/groupby.py",
line 1699, in groupby
return klass(obj, by, **kwds)
File "/usr/local/venv/lib/python2.7/site-packages/pandas/core/groupby.py",
line 392, in __init__
mutated=self.mutated)
File "/usr/local/venv/lib/python2.7/site-packages/pandas/core/groupby.py",
line 2690, in _get_grouper
raise KeyError(gpr)
KeyError: u'CITY'
And this is the QUERY
SELECT "CITY",
"__timestamp",
"count_QTY"
FROM
(SELECT "CITY" AS "CITY",
"REGN_DATE" AS "__timestamp",
count(VIN_NO) AS "count_QTY"
FROM
(SELECT *
FROM mycrm_registration) expr_qry
JOIN
(SELECT "CITY__",
mme_inner__
FROM
(SELECT "CITY" AS "CITY__",
count(VIN_NO) AS mme_inner__
FROM
(SELECT *
FROM mycrm_registration) expr_qry
WHERE "REGN_DATE" >= TO_TIMESTAMP('2018-03-30T00:00:00',
'-MM-DD"T"HH24:MI:SS.ff6')
AND "REGN_DATE" <= TO_TIMESTAMP('2018-04-06T08:20:13',
'-MM-DD"T"HH24:MI:SS.ff6')
GROUP BY "CITY"
ORDER BY count(VIN_NO) DESC)
WHERE ROWNUM <= 100) anon_1 ON "CITY" = "CITY__"
WHERE "REGN_DATE" >= TO_TIMESTAMP('2018-03-30T00:00:00',
'-MM-DD"T"HH24:MI:SS.ff6')
AND "REGN_DATE" <= TO_TIMESTAMP('2018-04-06T08:20:13',
'-MM-DD"T"HH24:MI:SS.ff6')
GROUP BY "CITY",
"REGN_DATE"
ORDER BY count(VIN_NO) DESC)
WHERE ROWNUM <= 5
Any idea?
### Steps to reproduce
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] fabianmenges commented on issue #4740: Add extraction function support for Druid queries
fabianmenges commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-379117332 I don't think so, will verify. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] michellethomas opened a new issue #4769: Permissions - Gamma user can't edit
michellethomas opened a new issue #4769: Permissions - Gamma user can't edit URL: https://github.com/apache/incubator-superset/issues/4769 Gamma users can create datasources through the visualize flow in sqllab but then cannot edit those datasources. We should allow users to edit their own datasources. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4768: Resolving key conflicts in Timeseries Annotation Layer when key is a string
codecov-io commented on issue #4768: Resolving key conflicts in Timeseries Annotation Layer when key is a string URL: https://github.com/apache/incubator-superset/pull/4768#issuecomment-379098776 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4768?src=pr=h1) Report > Merging [#4768](https://codecov.io/gh/apache/incubator-superset/pull/4768?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92230b853566de2ee55c55c49a2b1b41e10a6d10?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4768?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4768 +/- ## === Coverage 72.59% 72.59% === Files 205 205 Lines 1540115401 Branches 1183 1183 === Hits1118011180 Misses 4218 4218 Partials33 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4768?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4768?src=pr=footer). Last update [92230b8...85b8f29](https://codecov.io/gh/apache/incubator-superset/pull/4768?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4768: Resolving key conflicts in Timeseries Annotation Layer when key is a string
mistercrunch commented on issue #4768: Resolving key conflicts in Timeseries Annotation Layer when key is a string URL: https://github.com/apache/incubator-superset/pull/4768#issuecomment-379096376 @fabianmenges This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] EvelynTurner opened a new pull request #4768: Resolving key conflicts in Timeseries Annotation Layer when key is a string
EvelynTurner opened a new pull request #4768: Resolving key conflicts in Timeseries Annotation Layer when key is a string URL: https://github.com/apache/incubator-superset/pull/4768 Before https://user-images.githubusercontent.com/36863942/38394889-40b64502-38fe-11e8-9877-14187772bd6d.png;> After: https://user-images.githubusercontent.com/36863942/38394892-43ceef78-38fe-11e8-8ad3-ab115ca26c66.png;> This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations
williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-379091611 fyi hitting some issues testing this with prod data, still working on it. should be able to get the chunk files to have names that match the name in the code This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on a change in pull request #4727: [webpack] setup lazy loading for all visualizations
williaster commented on a change in pull request #4727: [webpack] setup lazy
loading for all visualizations
URL:
https://github.com/apache/incubator-superset/pull/4727#discussion_r179614390
##
File path: superset/assets/visualizations/main.js
##
@@ -51,53 +51,56 @@ export const VIZ_TYPES = {
rose: 'rose',
};
+const loadVis = promise => promise.then(module => module.default || module);
+
const vizMap = {
- [VIZ_TYPES.area]: require('./nvd3_vis.js'),
- [VIZ_TYPES.bar]: require('./nvd3_vis.js'),
- [VIZ_TYPES.big_number]: require('./big_number.js'),
- [VIZ_TYPES.big_number_total]: require('./big_number.js'),
- [VIZ_TYPES.box_plot]: require('./nvd3_vis.js'),
- [VIZ_TYPES.bubble]: require('./nvd3_vis.js'),
- [VIZ_TYPES.bullet]: require('./nvd3_vis.js'),
- [VIZ_TYPES.cal_heatmap]: require('./cal_heatmap.js'),
- [VIZ_TYPES.compare]: require('./nvd3_vis.js'),
- [VIZ_TYPES.directed_force]: require('./directed_force.js'),
- [VIZ_TYPES.chord]: require('./chord.jsx'),
- [VIZ_TYPES.dist_bar]: require('./nvd3_vis.js'),
- [VIZ_TYPES.filter_box]: require('./filter_box.jsx'),
- [VIZ_TYPES.heatmap]: require('./heatmap.js'),
- [VIZ_TYPES.histogram]: require('./histogram.js'),
- [VIZ_TYPES.horizon]: require('./horizon.js'),
- [VIZ_TYPES.iframe]: require('./iframe.js'),
- [VIZ_TYPES.line]: require('./nvd3_vis.js'),
- [VIZ_TYPES.time_pivot]: require('./nvd3_vis.js'),
- [VIZ_TYPES.mapbox]: require('./mapbox.jsx'),
- [VIZ_TYPES.markup]: require('./markup.js'),
- [VIZ_TYPES.para]: require('./parallel_coordinates.js'),
- [VIZ_TYPES.pie]: require('./nvd3_vis.js'),
- [VIZ_TYPES.pivot_table]: require('./pivot_table.js'),
- [VIZ_TYPES.sankey]: require('./sankey.js'),
- [VIZ_TYPES.separator]: require('./markup.js'),
- [VIZ_TYPES.sunburst]: require('./sunburst.js'),
- [VIZ_TYPES.table]: require('./table.js'),
- [VIZ_TYPES.time_table]: require('./time_table.jsx'),
- [VIZ_TYPES.treemap]: require('./treemap.js'),
- [VIZ_TYPES.country_map]: require('./country_map.js'),
- [VIZ_TYPES.word_cloud]: require('./word_cloud.js'),
- [VIZ_TYPES.world_map]: require('./world_map.js'),
- [VIZ_TYPES.dual_line]: require('./nvd3_vis.js'),
- [VIZ_TYPES.event_flow]: require('./EventFlow.jsx'),
- [VIZ_TYPES.paired_ttest]: require('./paired_ttest.jsx'),
- [VIZ_TYPES.partition]: require('./partition.js'),
- [VIZ_TYPES.deck_scatter]: require('./deckgl/layers/scatter.jsx').default,
- [VIZ_TYPES.deck_screengrid]:
require('./deckgl/layers/screengrid.jsx').default,
- [VIZ_TYPES.deck_grid]: require('./deckgl/layers/grid.jsx').default,
- [VIZ_TYPES.deck_hex]: require('./deckgl/layers/hex.jsx').default,
- [VIZ_TYPES.deck_path]: require('./deckgl/layers/path.jsx').default,
- [VIZ_TYPES.deck_geojson]: require('./deckgl/layers/geojson.jsx').default,
- [VIZ_TYPES.deck_arc]: require('./deckgl/layers/arc.jsx').default,
- [VIZ_TYPES.deck_polygon]: require('./deckgl/layers/polygon.jsx').default,
- [VIZ_TYPES.deck_multi]: require('./deckgl/multi.jsx'),
- [VIZ_TYPES.rose]: require('./rose.js'),
+ [VIZ_TYPES.area]: () => loadVis(import(/* webpackChunkName: "nvd3_vis" */
'./nvd3_vis.js')),
+ [VIZ_TYPES.bar]: () => loadVis(import(/* webpackChunkName: "nvd3_vis" */
'./nvd3_vis.js')),
+ [VIZ_TYPES.big_number]: () => loadVis(import(/* webpackChunkName:
"big_number" */ './big_number.js')),
+ [VIZ_TYPES.big_number_total]: () => loadVis(import(/* webpackChunkName:
"big_number" */ './big_number.js')),
+ [VIZ_TYPES.box_plot]: () => loadVis(import(/* webpackChunkName: "nvd3_vis"
*/ './nvd3_vis.js')),
+ [VIZ_TYPES.bubble]: () => loadVis(import(/* webpackChunkName: "nvd3_vis" */
'./nvd3_vis.js')),
+ [VIZ_TYPES.bullet]: () => loadVis(import(/* webpackChunkName: "nvd3_vis" */
'./nvd3_vis.js')),
+ [VIZ_TYPES.cal_heatmap]: () => loadVis(import(/* webpackChunkName:
"cal_heatmap" */ './cal_heatmap.js')),
+ [VIZ_TYPES.compare]: () => loadVis(import(/* webpackChunkName: "nvd3_vis" */
'./nvd3_vis.js')),
+ [VIZ_TYPES.directed_force]: () => loadVis(import(/* webpackChunkName:
"directed_force" */ './directed_force.js')),
+ [VIZ_TYPES.chord]: () => loadVis(import(/* webpackChunkName: "chord" */
'./chord.jsx')),
+ [VIZ_TYPES.dist_bar]: () => loadVis(import(/* webpackChunkName: "nvd3_vis"
*/ './nvd3_vis.js')),
+ [VIZ_TYPES.filter_box]: () => loadVis(import(/* webpackChunkName:
"filter_box" */ './filter_box.jsx')),
+ [VIZ_TYPES.heatmap]: () => loadVis(import(/* webpackChunkName: "heatmap" */
'./heatmap.js')),
+ [VIZ_TYPES.histogram]: () => loadVis(import(/* webpackChunkName: "histogram"
*/ './histogram.js')),
+ [VIZ_TYPES.horizon]: () => loadVis(import(/* webpackChunkName: "horizon" */
'./horizon.js')),
+ [VIZ_TYPES.iframe]: () => loadVis(import(/* webpackChunkName: "iframe" */
'./iframe.js')),
+ [VIZ_TYPES.line]: () => loadVis(import(/* webpackChunkName: "nvd3_vis" */
'./nvd3_vis.js')),
+ [VIZ_TYPES.time_pivot]: () => loadVis(import(/* webpackChunkName: "nvd3_vis"
*/ './nvd3_vis.js')),
+
[GitHub] hughhhh closed pull request #4643: Added option to add fill to area line charts
hug closed pull request #4643: Added option to add fill to area line charts
URL: https://github.com/apache/incubator-superset/pull/4643
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/assets/javascripts/explore/stores/controls.jsx
b/superset/assets/javascripts/explore/stores/controls.jsx
index cc35d0e573..9ea407d5ae 100644
--- a/superset/assets/javascripts/explore/stores/controls.jsx
+++ b/superset/assets/javascripts/explore/stores/controls.jsx
@@ -376,6 +376,14 @@ export const controls = {
description: null,
},
+ line_fill_area: {
+type: 'CheckboxControl',
+label: t('Fill Area of Line Chart'),
+renderTrigger: true,
+default: false,
+description: null,
+ },
+
pivot_margins: {
type: 'CheckboxControl',
label: t('Show totals'),
diff --git a/superset/assets/javascripts/explore/stores/visTypes.js
b/superset/assets/javascripts/explore/stores/visTypes.js
index 75443469f3..6aad1b8905 100644
--- a/superset/assets/javascripts/explore/stores/visTypes.js
+++ b/superset/assets/javascripts/explore/stores/visTypes.js
@@ -187,6 +187,7 @@ export const visTypes = {
['y_axis_label', 'left_margin'],
['y_axis_showminmax', 'y_log_scale'],
['y_axis_format', 'y_axis_bounds'],
+ ['line_fill_area', null],
],
},
sections.NVD3TimeSeries[1],
diff --git a/superset/assets/visualizations/nvd3_vis.js
b/superset/assets/visualizations/nvd3_vis.js
index 7cfb1c3320..54597bb0da 100644
--- a/superset/assets/visualizations/nvd3_vis.js
+++ b/superset/assets/visualizations/nvd3_vis.js
@@ -75,6 +75,7 @@ function hideTooltips() {
$('.nvtooltip').css({ opacity: 0 });
}
+
function getMaxLabelSize(container, axisClass) {
// axis class = .nv-y2 // second y axis on dual line chart
// axis class = .nv-x // x axis on time series line chart
@@ -173,6 +174,17 @@ function nvd3Vis(slice, payload) {
} else {
chart = nv.models.lineChart();
}
+
+if (fd.line_fill_area) {
+ data = data.map(d => ({
+...d,
+area: true,
+fillOpacity: 0.1,
+ }));
+
+ chart.forceY([0]);
+}
+
// To alter the tooltip header
// chart.interactiveLayer.tooltip.headerFormatter(function(){return
'';});
chart.xScale(d3.time.scale.utc());
@@ -654,7 +666,6 @@ function nvd3Vis(slice, payload) {
const domain = [xMin, xMax];
xScale.domain(domain);
chart.xDomain(domain);
-
annotations.selectAll('line')
.data(records)
.enter()
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io commented on issue #4767: Improve controls layout for Table visualization
codecov-io commented on issue #4767: Improve controls layout for Table visualization URL: https://github.com/apache/incubator-superset/pull/4767#issuecomment-379035259 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4767?src=pr=h1) Report > Merging [#4767](https://codecov.io/gh/apache/incubator-superset/pull/4767?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92230b853566de2ee55c55c49a2b1b41e10a6d10?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4767?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4767 +/- ## == + Coverage 72.59% 72.61% +0.01% == Files 205 205 Lines 1540115401 Branches 1183 1183 == + Hits1118011183 +3 + Misses 4218 4215 -3 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4767?src=pr=tree) | Coverage Δ | | |---|---|---| | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4767/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `39.25% <ø> (ø)` | :arrow_up: | | [...rset/assets/javascripts/explore/stores/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/4767/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3Zpc1R5cGVzLmpz) | `70.58% <ø> (ø)` | :arrow_up: | | [...ipts/explore/components/ControlPanelsContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4767/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLmpzeA==) | `91.3% <0%> (+4.34%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4767?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4767?src=pr=footer). Last update [92230b8...3948d79](https://codecov.io/gh/apache/incubator-superset/pull/4767?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hughhhh commented on issue #4643: Added option to add fill to area line charts
hug commented on issue #4643: Added option to add fill to area line charts URL: https://github.com/apache/incubator-superset/pull/4643#issuecomment-379035275 deprioritizing due to work needing to be done on nvd3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4766: [explore] set control default for *showminmax = false
codecov-io commented on issue #4766: [explore] set control default for *showminmax = false URL: https://github.com/apache/incubator-superset/pull/4766#issuecomment-379033745 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4766?src=pr=h1) Report > Merging [#4766](https://codecov.io/gh/apache/incubator-superset/pull/4766?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92230b853566de2ee55c55c49a2b1b41e10a6d10?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4766?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4766 +/- ## === Coverage 72.59% 72.59% === Files 205 205 Lines 1540115401 Branches 1183 1183 === Hits1118011180 Misses 4218 4218 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4766?src=pr=tree) | Coverage Δ | | |---|---|---| | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4766/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `39.25% <ø> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4766?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4766?src=pr=footer). Last update [92230b8...e7c3ba8](https://codecov.io/gh/apache/incubator-superset/pull/4766?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom margin
mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom margin URL: https://github.com/apache/incubator-superset/pull/4756#issuecomment-379033116 I'll wait on @graceguo-supercat's review before merging this This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom margin
mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom margin URL: https://github.com/apache/incubator-superset/pull/4756#issuecomment-379032942 @williaster I agree with `flat` but didn't want to drive it myself as it may upset some users since we have to redefine/shorten `Adaptive formatting` as a prerequisite (I think the current definition was fine tuned by data scientists at Airbnb, forgot who but it's in the git history). It will also change the way thousands of line charts look like at Airbnb... You have my blessing to figure out better defaults that will please a majority of users. One key point is that day-of-week is very important to both Airbnb and Lyft given the strong weekly cycles, I wouldn't kick this out, better removing `` than removing 3-letters day-of-week. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on issue #4756: Improve xAxis ticks, thinner bottom margin
williaster commented on issue #4756: Improve xAxis ticks, thinner bottom margin URL: https://github.com/apache/incubator-superset/pull/4756#issuecomment-379029421 ah, that's nice about the `auto` setting. I'd like to get the `flat` in asap so users see staggered for the minimum amount of time, I'll begin work on the concise date logic! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch opened a new pull request #4767: Improve controls layout for Table visualization
mistercrunch opened a new pull request #4767: Improve controls layout for Table visualization URL: https://github.com/apache/incubator-superset/pull/4767 https://user-images.githubusercontent.com/487433/38383672-f02b9b00-38c1-11e8-9aac-28b2ccb582c1.png;> https://user-images.githubusercontent.com/487433/38383673-f0438b84-38c1-11e8-9d9c-2e0c33f053be.png;> This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch opened a new pull request #4766: [explore] set control default for *showminmax = false
mistercrunch opened a new pull request #4766: [explore] set control default for *showminmax = false URL: https://github.com/apache/incubator-superset/pull/4766 Let's make the defaults less crowded on the axes by not showing the min and max values on the axes (bounds) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa commented on issue #4576: Upload a csv via gui points to non existing folder: '.../superset/app/static/uploads/data.csv'
timifasubaa commented on issue #4576: Upload a csv via gui points to non existing folder: '.../superset/app/static/uploads/data.csv' URL: https://github.com/apache/incubator-superset/issues/4576#issuecomment-379007258 Seen. I'll send out a PR to fix this case. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4394: Implement the column config and row config in pivot table
mistercrunch commented on issue #4394: Implement the column config and row config in pivot table URL: https://github.com/apache/incubator-superset/pull/4394#issuecomment-379005432 @michellethomas do you think this conflicts with your goal of deprecating `datatables`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #4673: Add context to templates / respect slice timeout
mistercrunch closed pull request #4673: Add context to templates / respect
slice timeout
URL: https://github.com/apache/incubator-superset/pull/4673
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/connectors/sqla/models.py
b/superset/connectors/sqla/models.py
index ef8c68ebb3..8a93373a2e 100644
--- a/superset/connectors/sqla/models.py
+++ b/superset/connectors/sqla/models.py
@@ -462,6 +462,9 @@ def get_sqla_query( # sqla
'metrics': metrics,
'row_limit': row_limit,
'to_dttm': to_dttm,
+'filter': filter,
+'columns': {col.column_name: col for col in self.columns},
+
}
template_processor = self.get_template_processor(**template_kwargs)
db_engine_spec = self.database.db_engine_spec
diff --git a/superset/viz.py b/superset/viz.py
index 6f17ad71a7..697fb98ca8 100644
--- a/superset/viz.py
+++ b/superset/viz.py
@@ -251,6 +251,8 @@ def query_obj(self):
@property
def cache_timeout(self):
+if self.form_data.get('cache_timeout'):
+return int(self.form_data.get('cache_timeout'))
if self.datasource.cache_timeout:
return self.datasource.cache_timeout
if (
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mistercrunch commented on issue #4576: Upload a csv via gui points to non existing folder: '.../superset/app/static/uploads/data.csv'
mistercrunch commented on issue #4576: Upload a csv via gui points to non existing folder: '.../superset/app/static/uploads/data.csv' URL: https://github.com/apache/incubator-superset/issues/4576#issuecomment-379003741 @timifasubaa This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing
john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-378998654 @mistercrunch it would be good to understand how Lyft creates these different files (though your hypothesis seems valid). It seems you maybe able to achieve this in conjunction with pyenv. I can also explore pipenv, though it would need to play well with tox, Travis, etc. Also if we went down the virtualenv route one would need to activate it for the various services or wrap existing command via pipenv run. Finally the setup.py/requirements.txt relationship is well defined, in essence setup.py should never pin packages but merely provide the list of required dependencies, with version restrictions were appropriate. I realize that Superset is an application rather than a package, but this allows individual instances to configure their Python environment how they see appropriate, i.e., a custom plugin may require a different version of dependency. The requirements.txt simply provides a deterministic environment using package versions which we’ve certified/tested. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing
john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-378998654 @mistercrunch it would be good to understand how Lyft creates these different files and I can explore pipenv, though it would need to play well with tox, Travis, etc. Also if we went down the virtualenv route one would need to activate it for the various services or wrap existing command via pipenv run. Finally the setup.py/requirements.txt relationship is well defined, in essence setup.py should never pin packages but merely provide the list of required dependencies, with version restrictions were appropriate. I realize that Superset is an application rather than a package, but this allows individual instances to configure their Python environment how they see appropriate, i.e., a custom plugin may require a different version of dependency. The requirements.txt simply provides a deterministic environment using package versions which we’ve certified/tested. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4552: [travis/tox] Restructuring configuration and testing
mistercrunch commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-378973490 Also I'm not clear on how Pypi operates, but my guess is that it only looks at what's in `setup.py` and disregards the `requirements.txt` file, meaning a simple `pip install superset` would be less predictable following this PR since much version-range specs was removed from `setup.py` in this PR. At Lyft our build process for all Python apps generates both a `requirements.txt` and a `requirements3.txt` out of a `requirements.in` file, not sure how it's accomplished, maybe it has pip-compile while 2 different venv are used alternatively. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marslhx commented on issue #4151: Mapbox maps not rendering
marslhx commented on issue #4151: Mapbox maps not rendering URL: https://github.com/apache/incubator-superset/issues/4151#issuecomment-378845012 I meet this problem in another occasion. I added my registered API token of Mapbox in superset_config.py. And add path of it to .bash_profile, then _source ~ .bash_profile_, then _superset runserver_ However the map don't render yet. What's the matter? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Stevie337 commented on issue #4394: Implement the column config and row config in pivot table
Stevie337 commented on issue #4394: Implement the column config and row config in pivot table URL: https://github.com/apache/incubator-superset/pull/4394#issuecomment-378843824 Hi All, Has this PR already been pushed?? Ifso in what build would this be? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa commented on issue #4552: [travis/tox] Restructuring configuration and testing
timifasubaa commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-378840175 @mistercrunch @john-bodley Would (pipenv)[https://docs.pipenv.org/] solve our problems here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa commented on issue #4552: [travis/tox] Restructuring configuration and testing
timifasubaa commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-378840175 @mistercrunch @john-bodley Would pipenv[https://docs.pipenv.org/] solve our problems here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marslhx commented on issue #4576: Upload a csv via gui points to non existing folder: '.../superset/app/static/uploads/data.csv'
marslhx commented on issue #4576: Upload a csv via gui points to non existing folder: '.../superset/app/static/uploads/data.csv' URL: https://github.com/apache/incubator-superset/issues/4576#issuecomment-378839380 Add which folder to where? How to set the permission. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing
john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-378831814 @mistercrunch I definitely explored the `pip-compile` route as it would be great to have `requirements.txt` autogenerated from `setup.py` and `requirements-dev.txt` autogenerated from `requirements-dev.in` etc. The issue is there's not a plausible way to autogenerate a Python 2/3 compatible `requirements.txt` file, i.e., in Python 2.7 `pip-compile` generates: ``` # # This file is autogenerated by pip-compile # To update, run: # #pip-compile --output-file requirements.txt setup.py # alembic==0.9.9# via flask-migrate amqp==2.2.2 # via kombu asn1crypto==0.24.0# via cryptography babel==2.5.3 # via flask-babel, flower backports-abc==0.5# via tornado billiard==3.5.0.3 # via celery bleach==2.1.3 boto3==1.7.0 botocore==1.10.0 # via boto3, s3transfer celery==4.1.0 certifi==2018.1.18# via requests cffi==1.11.5 # via cryptography chardet==3.0.4# via requests click==6.7# via flask, flask-appbuilder colorama==0.3.9 cryptography==2.2.2 docutils==0.14# via botocore enum34==1.1.6 # via cryptography flask-appbuilder==1.10.0 flask-babel==0.11.1 # via flask-appbuilder flask-cache==0.13.1 flask-compress==1.4.0 flask-login==0.2.11 # via flask-appbuilder flask-migrate==2.1.1 flask-openid==1.2.5 # via flask-appbuilder flask-script==2.0.6 flask-sqlalchemy==2.1 flask-testing==0.7.1 flask-wtf==0.14.2 flask==0.12.2 flower==0.9.2 future==0.16.0 futures==3.2.0# via flower, s3transfer, tornado geopy==1.12.0 gunicorn==19.7.1 html5lib==1.0.1 # via bleach humanize==0.5.1 idna==2.6 ipaddress==1.0.19 # via cryptography itsdangerous==0.24# via flask jinja2==2.10 # via flask, flask-babel jmespath==0.9.3 # via boto3, botocore kombu==4.1.0 # via celery mako==1.0.7 # via alembic markdown==2.6.11 markupsafe==1.0 # via jinja2, mako numpy==1.14.2 # via pandas pandas==0.22.0 parsedatetime==2.4 pathlib2==2.3.0 polyline==1.3.2 pycparser==2.18 # via cffi pydruid==0.4.2 pyhive==0.5.1 python-dateutil==2.6.1 python-editor==1.0.3 # via alembic python-geohash==0.8.5 python-openid==2.2.5 # via flask-openid pytz==2018.3 # via babel, celery, flower, pandas pyyaml==3.12 requests==2.18.4 s3transfer==0.1.13# via boto3 sasl==0.2.1 # via thrift-sasl scandir==1.7 # via pathlib2 simplejson==3.13.2 singledispatch==3.4.0.3 # via tornado six==1.11.0 sqlalchemy-utils==0.33.2 sqlalchemy==1.2.6 sqlparse==0.2.4 thrift-sasl==0.3.0 thrift==0.11.0 tornado==5.0.1# via flower unicodecsv==0.14.1 unidecode==1.0.22 urllib3==1.22 # via requests vine==1.1.4 # via amqp webencodings==0.5.1 # via html5lib werkzeug==0.14.1 # via flask wtforms==2.1 # via flask-wtf ``` however if you try to install this in Python 3 via, `pip3 install -r requirements.txt` it fails with the following error: ``` Collecting futures==3.2.0 (from -r requirements.txt (line 33)) Could not find a version that satisfies the requirement futures==3.2.0 (from -r requirements.txt (line 33)) (from versions: 0.2.python3, 0.1, 0.2, 1.0, 2.0, 2.1, 2.1.1, 2.1.2, 2.1.3, 2.1.4, 2.1.5, 2.1.6, 2.2.0, 3.0.0, 3.0.1, 3.0.2, 3.0.3, 3.0.4, 3.0.5, 3.1.0, 3.1.1) No matching distribution found for futures==3.2.0 (from -r requirements.txt (line 33)) ``` I thought of two possible solutions: 1. Enabling `pip-compile` to support multiple Python versions, which is something that `requirements.txt supports, i.e., ``` futures==3.2.0; python_version == '2.7' ``` 2. Enabling `pip-compile` to exclude dependencies (which `futures` is) which would make the output Python 2/3 compatible. I raised this [issue](https://github.com/jazzband/pip-tools/issues/639) with `pip-tools` where the suggestion was to create a `requirements.txt` for each environment, however I'm not certain we want to have to build/maintain environment specific files. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing
codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=h1) Report > Merging [#4552](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/df4ff05441eaac7ca99f5725956f500344bc257d?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4552 +/- ## === Coverage 72.59% 72.59% === Files 205 205 Lines 1539915399 Branches 1183 1183 === Hits1117911179 Misses 4217 4217 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.3% <0%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=footer). Last update [df4ff05...af9241e](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4708: Does Superset have an API to expose a Chart's JSON data?
mistercrunch commented on issue #4708: Does Superset have an API to expose a Chart's JSON data? URL: https://github.com/apache/incubator-superset/issues/4708#issuecomment-378828914 Flask App Builder (FAB) offers a CRUD REST API out of the box for all models. Check out: ``` /slicemodelview/api /slicemodelview/api/read /dashboardmodelview/api /dashboardmodelview/api/read ``` http://flask-appbuilder.readthedocs.io/en/latest/quickhowto.html#rest-api This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
