[GitHub] villebro commented on issue #4889: Fix regression in timestamp expression

[GitBox]

villebro commented on issue #4889: Fix regression in timestamp expression
URL: 
https://github.com/apache/incubator-superset/pull/4889#issuecomment-384870624
 
 
   Bug fixed in #4890


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] villebro closed pull request #4889: Fix regression in timestamp expression

[GitBox]

villebro closed pull request #4889: Fix regression in timestamp expression
URL: https://github.com/apache/incubator-superset/pull/4889
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/connectors/sqla/models.py 
b/superset/connectors/sqla/models.py
index c65df0209a..83fe3971c6 100644
--- a/superset/connectors/sqla/models.py
+++ b/superset/connectors/sqla/models.py
@@ -131,7 +131,7 @@ def get_timestamp_expression(self, time_grain):
 expr = db_spec.epoch_ms_to_dttm().format(col=expr)
 grain = self.table.database.grains_dict().get(time_grain)
 literal = grain.function if grain else '{col}'
-literal = expr.format(col=expr)
+literal = literal.format(col=expr)
 return literal_column(literal, type_=DateTime).label(DTTM_ALIAS)
 
 @classmethod


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] leehwmj opened a new issue #4895: An error occurred while rendering the visualization: Error: An API access token is required to use Mapbox GL.

[GitBox]

leehwmj opened a new issue #4895: An error occurred while rendering the 
visualization: Error: An API access token is required to use Mapbox GL.
URL: https://github.com/apache/incubator-superset/issues/4895
 
 
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [x] I have checked the superset logs for python stacktraces and included 
it here as text if any
   - [x] I have reproduced the issue with at least the latest released version 
of superset
   - [x] I have checked the issue tracker for the same issue and I haven't 
found one similar
   
   
   ### Superset version
   0.25.0rc1
   
   ### Expected results
   
   
   ### Actual results
   ![2018-04-27 10 04 
04](https://user-images.githubusercontent.com/22087964/39341029-39e68448-4a0c-11e8-99e2-afbb8f11f07c.png)
   
   (An error occurred while rendering the visualization: Error: An API access 
token is required to use Mapbox GL. See 
https://www.mapbox.com/api-documentation/#access-tokens)
   
   ### Steps to reproduce
   Just git clone the forked repo, and checkout 0.25.0rc1. Then install & build 
like :
   
   git clone https://github.com/leehwmj-junta/incubator-superset.git 
apache-superset
   git checkout -b version0.25 0.25.0rc1
   
   cd apache-superset
   virtualenv env
   . env/bin/activate
   pip install -r requirements.txt
   pip install -e .
   fabmanager create-admin --app superset
   superset db upgrade
   superset init
   superset load_examples
   
   cd superset/assets
   yarn
   npm run sync-backend
   npm run prod
   
   npm run dev
   superset runserver -d -p 8081
   
   **login -> Dashboards -> deck.gl Demo**
   
   The result of the process described above is shown in the attached photo.
   I tried to resolve this error, but I could not find a way.
   If you know how, please help me.
   
   thank you


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed pull request #4890: [bugfix] temporal columns with expression fail

[GitBox]

mistercrunch closed pull request #4890: [bugfix] temporal columns with 
expression fail
URL: https://github.com/apache/incubator-superset/pull/4890
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/connectors/base/models.py 
b/superset/connectors/base/models.py
index 8e4a2a2245..9f9522daa4 100644
--- a/superset/connectors/base/models.py
+++ b/superset/connectors/base/models.py
@@ -241,6 +241,11 @@ def values_for_column(self, column_name, limit=1):
 def default_query(qry):
 return qry
 
+def get_column(self, column_name):
+for col in self.columns:
+if col.column_name == column_name:
+return col
+
 
 class BaseColumn(AuditMixinNullable, ImportMixin):
 """Interface for column"""
diff --git a/superset/connectors/sqla/models.py 
b/superset/connectors/sqla/models.py
index c65df0209a..56a1751243 100644
--- a/superset/connectors/sqla/models.py
+++ b/superset/connectors/sqla/models.py
@@ -117,22 +117,24 @@ def get_time_filter(self, start_dttm, end_dttm):
 
 def get_timestamp_expression(self, time_grain):
 """Getting the time component of the query"""
+pdf = self.python_date_format
+is_epoch = pdf in ('epoch_s', 'epoch_ms')
+if not self.expression and not time_grain and not is_epoch:
+return column(self.column_name, type_=DateTime).label(DTTM_ALIAS)
+
 expr = self.expression or self.column_name
-if not self.expression and not time_grain:
-return column(expr, type_=DateTime).label(DTTM_ALIAS)
+if is_epoch:
+# if epoch, translate to DATE using db specific conf
+db_spec = self.table.database.db_engine_spec
+if pdf == 'epoch_s':
+expr = db_spec.epoch_to_dttm().format(col=expr)
+elif pdf == 'epoch_ms':
+expr = db_spec.epoch_ms_to_dttm().format(col=expr)
 if time_grain:
-pdf = self.python_date_format
-if pdf in ('epoch_s', 'epoch_ms'):
-# if epoch, translate to DATE using db specific conf
-db_spec = self.table.database.db_engine_spec
-if pdf == 'epoch_s':
-expr = db_spec.epoch_to_dttm().format(col=expr)
-elif pdf == 'epoch_ms':
-expr = db_spec.epoch_ms_to_dttm().format(col=expr)
 grain = self.table.database.grains_dict().get(time_grain)
-literal = grain.function if grain else '{col}'
-literal = expr.format(col=expr)
-return literal_column(literal, type_=DateTime).label(DTTM_ALIAS)
+if grain:
+expr = grain.function.format(col=expr)
+return literal_column(expr, type_=DateTime).label(DTTM_ALIAS)
 
 @classmethod
 def import_obj(cls, i_column):
diff --git a/superset/data/__init__.py b/superset/data/__init__.py
index 160ed647f9..8ad6c11688 100644
--- a/superset/data/__init__.py
+++ b/superset/data/__init__.py
@@ -188,7 +188,7 @@ def load_world_bank_health_n_pop():
 "compare_lag": "10",
 "compare_suffix": "o10Y",
 "limit": "25",
-"granularity": "year",
+"granularity_sqla": "year",
 "groupby": [],
 "metric": 'sum__SP_POP_TOTL',
 "metrics": ["sum__SP_POP_TOTL"],
@@ -593,7 +593,7 @@ def load_birth_names():
 "compare_lag": "10",
 "compare_suffix": "o10Y",
 "limit": "25",
-"granularity": "ds",
+"granularity_sqla": "ds",
 "groupby": [],
 "metric": 'sum__num',
 "metrics": ["sum__num"],
@@ -642,7 +642,7 @@ def load_birth_names():
 datasource_id=tbl.id,
 params=get_slice_json(
 defaults,
-viz_type="big_number", granularity="ds",
+viz_type="big_number", granularity_sqla="ds",
 compare_lag="5", compare_suffix="over 5Y")),
 Slice(
 slice_name="Genders",
@@ -675,7 +675,7 @@ def load_birth_names():
 params=get_slice_json(
 defaults,
 viz_type="line", groupby=['name'],
-granularity='ds', rich_tooltip=True, show_legend=True)),
+granularity_sqla='ds', rich_tooltip=True, show_legend=True)),
 Slice(
 slice_name="Average and Sum Trends",
 viz_type='dual_line',
@@ -684,7 +684,7 @@ def load_birth_names():
 params=get_slice_json(
 defaults,
 viz_type="dual_line", metric='avg__num', metric_2='sum__num',
-granularity='ds')),
+granularity_sqla='ds')),
 Slice(
 slice_name="Title",
 viz_type='markup',
@@ -729,7 +729,7 @@ def 

[GitHub] Maxwell2022 commented on issue #4885: [0.24.0] Explore / Visualise - Cannot read property 'match' of null

[GitBox]

Maxwell2022 commented on issue #4885: [0.24.0] Explore / Visualise - Cannot 
read property 'match' of null
URL: 
https://github.com/apache/incubator-superset/issues/4885#issuecomment-384848350
 
 
   Just an update on this, issue. It looks like it's happening with JSONB 
column from my table.
   If I omit this columns from the request, the visualiser is working as 
excepted


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4890: [bugfix] temporal columns with expression fail

[GitBox]

codecov-io commented on issue #4890: [bugfix] temporal columns with expression 
fail
URL: 
https://github.com/apache/incubator-superset/pull/4890#issuecomment-384801471
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4890?src=pr=h1)
 Report
   > Merging 
[#4890](https://codecov.io/gh/apache/incubator-superset/pull/4890?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/fa3da8c888e25b62e72faaab8987631f07096b56?src=pr=desc)
 will **increase** coverage by `0.16%`.
   > The diff coverage is `88.23%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4890/graphs/tree.svg?src=pr=KsB0fHcx6l=650=150)](https://codecov.io/gh/apache/incubator-superset/pull/4890?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4890  +/-   ##
   ==
   + Coverage   76.97%   77.13%   +0.16% 
   ==
 Files  44   44  
 Lines8537 8542   +5 
   ==
   + Hits 6571 6589  +18 
   + Misses   1966 1953  -13
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4890?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/data/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/4890/diff?src=pr=tree#diff-c3VwZXJzZXQvZGF0YS9fX2luaXRfXy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4890/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==)
 | `90.74% <100%> (+0.23%)` | :arrow_up: |
   | 
[superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4890/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==)
 | `76.32% <84.61%> (+2.09%)` | :arrow_up: |
   | 
[superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4890/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5)
 | `52.69% <0%> (+0.53%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4890?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4890?src=pr=footer).
 Last update 
[fa3da8c...3ac0ba5](https://codecov.io/gh/apache/incubator-superset/pull/4890?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Maxwell2022 commented on issue #978: redirects change https requests to http locations

[GitBox]

Maxwell2022 commented on issue #978: redirects change https requests to http 
locations
URL: 
https://github.com/apache/incubator-superset/issues/978#issuecomment-384835516
 
 
   So I slept over this issue and investigate a bit more about Flask 
application and how these are working behind reverse proxies. It's expecting 
the `X-Forwarded-Proto` header from the reverse proxy. So I just added it to my 
nginx config and all good, not more redirect to http. I'll paste here my nginx 
config if it can help anyone else:
   
   ```
   upstream api {
 server superset-server:8088 max_fails=3;
   }
   
   map $http_upgrade $connection_upgrade {
 default   "upgrade";
 """";
   }
   
   # Force HTTPS
   server {
 listen 80;
 server_name superset.mydomain.com;
 return 301 https://$host$request_uri;
   }
   
   server {
 listen 443 ssl http2;
 server_namesuperset.mydomain.com;
   
 ssl_protocols TLSv1 TLSv1.1 TLSv1.2;
 ssl_certificate
/etc/nginx/letsencrypt/live/superset.mydomain.com/fullchain.pem;
 ssl_certificate_key 
/etc/nginx/letsencrypt/live/superset.mydomain.com/privkey.pem;
 ssl_trusted_certificate 
/etc/nginx/letsencrypt/live/superset.mydomain.com/chain.pem;
   
 access_log /var/log/nginx/superset.access.log main;
 error_log  /var/log/nginx/superset.error.log error;
   
 # Configuration for Lets Encrypt certificate renewal
 include /etc/nginx/snippet/acme-challenge.conf;
   
 location / {
   proxy_pass http://api;
   proxy_redirect off;
   
   proxy_set_header   Connection $connection_upgrade;
   proxy_set_header   Upgrade $http_upgrade;
   proxy_set_header   Host $host;
   proxy_set_header   X-Real-IP $remote_addr;
   proxy_set_header   X-Forwarded-For $proxy_add_x_forwarded_for;
   proxy_set_header   X-Forwarded-Proto $scheme;
 }
   }
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] darylerwin commented on issue #4894: Install fresh 025rc1 - gives me TypeError: make_declarative_base() takes at most 2 arguments (3 given)

[GitBox]

darylerwin commented on issue #4894: Install fresh 025rc1 - gives me TypeError: 
make_declarative_base() takes at most 2 arguments (3 given)
URL: 
https://github.com/apache/incubator-superset/issues/4894#issuecomment-384834541
 
 
   Stuck
   yarn run build
   yarn run v1.5.1
   warning You are using Node "4.2.6" which is not supported and may encounter 
bugs or unexpected behavior. Yarn supports the following semver range: "^4.8.0 
|| ^5.7.0 || ^6.2.2 || >=8.0.0"
   $ NODE_ENV=production webpack --colors --progress
   sh: 1: webpack: not found
   error An unexpected error occurred: "Command failed.
   Exit code: 127
   Command: sh
   Arguments: -c NODE_ENV=production webpack --colors --progress
   Directory: 
/home/derwin/venvbeta/lib/python2.7/site-packages/superset/static/assets
   Output:
   ".
   info If you think this is a bug, please open a bug report with the 
information provided in 
"/home/derwin/venvbeta/lib/python2.7/site-packages/superset/static/assets/yarn-error.log".
   info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this 
command.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] darylerwin commented on issue #4894: Install fresh 025rc1 - gives me TypeError: make_declarative_base() takes at most 2 arguments (3 given)

[GitBox]

darylerwin commented on issue #4894: Install fresh 025rc1 - gives me TypeError: 
make_declarative_base() takes at most 2 arguments (3 given)
URL: 
https://github.com/apache/incubator-superset/issues/4894#issuecomment-384834393
 
 
   I dont see a superset/assets ... I found
   ./lib/python2.7/site-packages/superset/static/assets


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #945: Google BigQuery Support

[GitBox]

mistercrunch commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384834148
 
 
   I'm not sure if that may be related, but Superset is not officially 
supported on Windows. We don't run tests or any sort of build against Windows. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] darylerwin commented on issue #4894: Install fresh 025rc1 - gives me TypeError: make_declarative_base() takes at most 2 arguments (3 given)

[GitBox]

darylerwin commented on issue #4894: Install fresh 025rc1 - gives me TypeError: 
make_declarative_base() takes at most 2 arguments (3 given)
URL: 
https://github.com/apache/incubator-superset/issues/4894#issuecomment-384834309
 
 
   Add New Slice doesnt show the css template..
   Looking into notes:
   # assuming $SUPERSET_HOME as the root of the repo
   cd $SUPERSET_HOME/superset/assets
   yarn
   yarn run build
   cd $SUPERSET_HOME
   python setup.py install


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #945: Google BigQuery Support

[GitBox]

mistercrunch commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384834148
 
 
   I'm not sure if that may be related, but Superset is not officially 
supported on Windows.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] darylerwin commented on issue #945: Google BigQuery Support

[GitBox]

darylerwin commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384774163
 
 
   I set this in my box that is running superset via .profile
   
   export 
GOOGLE_APPLICATION_CREDENTIALS="/home/derwin/my-production-bigdata-key.json"
   
   And that json file should similar in format to:
   ```json
   {
 "type": "service_account",
 "project_id": "xata",
 "private_key_id": "cb8c5d3d7b03203",
 "private_key": "-BEGIN PRIVATE KEY-\nMIIEvQ
   etcetc
   }
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] darylerwin commented on issue #4894: Install fresh 025rc1 - gives me TypeError: make_declarative_base() takes at most 2 arguments (3 given)

[GitBox]

darylerwin commented on issue #4894: Install fresh 025rc1 - gives me TypeError: 
make_declarative_base() takes at most 2 arguments (3 given)
URL: 
https://github.com/apache/incubator-superset/issues/4894#issuecomment-384832907
 
 
   I had to:
   edit 
/home/derwin/venvbeta/local/lib/python2.7/site-packages/superset/migrations/versions/289ce07647b_add_encrypted_password_field.py
   And use 
   #from sqlalchemy_utils.types.encrypted import EncryptedType
   from sqlalchemy_utils import EncryptedTyp


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed pull request #4892: Fix time grain

[GitBox]

mistercrunch closed pull request #4892: Fix time grain
URL: https://github.com/apache/incubator-superset/pull/4892
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/connectors/sqla/models.py 
b/superset/connectors/sqla/models.py
index c65df0209a..83fe3971c6 100644
--- a/superset/connectors/sqla/models.py
+++ b/superset/connectors/sqla/models.py
@@ -131,7 +131,7 @@ def get_timestamp_expression(self, time_grain):
 expr = db_spec.epoch_ms_to_dttm().format(col=expr)
 grain = self.table.database.grains_dict().get(time_grain)
 literal = grain.function if grain else '{col}'
-literal = expr.format(col=expr)
+literal = literal.format(col=expr)
 return literal_column(literal, type_=DateTime).label(DTTM_ALIAS)
 
 @classmethod


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4890: [bugfix] temporal columns with expression fail

[GitBox]

mistercrunch commented on issue #4890: [bugfix] temporal columns with 
expression fail
URL: 
https://github.com/apache/incubator-superset/pull/4890#issuecomment-384832659
 
 
   superseeds https://github.com/apache/incubator-superset/pull/4892


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] darylerwin commented on issue #4894: Install fresh 025rc1 - gives me TypeError: make_declarative_base() takes at most 2 arguments (3 given)

[GitBox]

darylerwin commented on issue #4894: Install fresh 025rc1 - gives me TypeError: 
make_declarative_base() takes at most 2 arguments (3 given)
URL: 
https://github.com/apache/incubator-superset/issues/4894#issuecomment-384830233
 
 
   Is this the correct answer?
   pip uninstall flask-sqlalchemy
   pip install flask-sqlalchemy==2.1
   superset db upgrade


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] darylerwin commented on issue #4894: Install fresh 025rc1 - gives me TypeError: make_declarative_base() takes at most 2 arguments (3 given)

[GitBox]

darylerwin commented on issue #4894: Install fresh 025rc1 - gives me TypeError: 
make_declarative_base() takes at most 2 arguments (3 given)
URL: 
https://github.com/apache/incubator-superset/issues/4894#issuecomment-384829460
 
 
   
   (venvbeta) :~/venvbeta/bin$ pip freeze
   alembic==0.9.9
   amqp==2.2.2
   asn1crypto==0.24.0
   Babel==2.5.3
   backports-abc==0.5
   billiard==3.5.0.3
   bleach==2.1.3
   boto3==1.7.10
   botocore==1.10.10
   cachetools==2.0.1
   celery==4.1.0
   certifi==2018.4.16
   cffi==1.11.5
   chardet==3.0.4
   click==6.7
   colorama==0.3.9
   cryptography==2.2.2
   docutils==0.14
   enum34==1.1.6
   Flask==1.0
   Flask-AppBuilder==1.10.0
   Flask-Babel==0.11.1
   Flask-Cache==0.13.1
   Flask-Compress==1.4.0
   Flask-Login==0.2.11
   Flask-Migrate==2.1.1
   Flask-OpenID==1.2.5
   Flask-Script==2.0.6
   Flask-SQLAlchemy==2.3.2
   Flask-Testing==0.7.1
   Flask-WTF==0.14.2
   flower==0.9.2
   future==0.16.0
   futures==3.2.0
   geographiclib==1.49
   geopy==1.13.0
   google-api-core==1.1.1
   google-auth==1.4.1
   google-cloud-bigquery==1.1.0
   google-cloud-core==0.28.1
   google-resumable-media==0.3.1
   googleapis-common-protos==1.5.3
   gunicorn==19.7.1
   html5lib==1.0.1
   humanize==0.5.1
   idna==2.6
   ipaddress==1.0.22
   itsdangerous==0.24
   Jinja2==2.10
   jmespath==0.9.3
   kombu==4.1.0
   Mako==1.0.7
   Markdown==2.6.11
   MarkupSafe==1.0
   mysqlclient==1.3.12
   numpy==1.14.2
   pandas==0.22.0
   parsedatetime==2.4
   pathlib2==2.3.2
   polyline==1.3.2
   protobuf==3.5.2.post1
   pyasn1==0.4.2
   pyasn1-modules==0.2.1
   pybigquery==0.2.8
   pycparser==2.18
   pydruid==0.4.2
   PyHive==0.5.1
   python-dateutil==2.7.2
   python-editor==1.0.3
   python-geohash==0.8.5
   python-openid==2.2.5
   pytz==2018.4
   PyYAML==3.12
   redis==2.10.6
   requests==2.18.4
   rsa==3.4.2
   s3transfer==0.1.13
   sasl==0.2.1
   scandir==1.7
   simplejson==3.14.0
   singledispatch==3.4.0.3
   six==1.11.0
   SQLAlchemy==1.2.7
   SQLAlchemy-Utils==0.33.2
   sqlparse==0.2.4
   superset==0.25.0rc1
   thrift==0.11.0
   thrift-sasl==0.3.0
   tornado==5.0.2
   unicodecsv==0.14.1
   Unidecode==1.0.22
   urllib3==1.22
   vine==1.1.4
   webencodings==0.5.1
   Werkzeug==0.14.1
   WTForms==2.1


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] darylerwin opened a new issue #4894: Install fresh 025rc1 - gives me TypeError: make_declarative_base() takes at most 2 arguments (3 given)

[GitBox]

darylerwin opened a new issue #4894: Install fresh 025rc1 - gives me TypeError: 
make_declarative_base() takes at most 2 arguments (3 given)
URL: https://github.com/apache/incubator-superset/issues/4894
 
 
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [ x] I have checked the superset logs for python stacktraces and included 
it here as text if any
   - [x ] I have reproduced the issue with at least the latest released version 
of superset
   - [ x] I have checked the issue tracker for the same issue and I haven't 
found one similar
   
   
   ### Superset version
   0.25rc1
   
   ### Expected results
   Should be a valid install?
   
   ### Actual results
   Traceback (most recent call last):
 File "/home/derwin/venvbeta/bin/superset", line 12, in 
   from superset.cli import manager
 File 
"/home/derwin/venvbeta/local/lib/python2.7/site-packages/superset/__init__.py", 
line 89, in 
   db = SQLA(app)
 File 
"/home/derwin/venvbeta/local/lib/python2.7/site-packages/flask_sqlalchemy/__init__.py",
 line 677, in __init__
   self.Model = self.make_declarative_base(model_class, metadata)
   TypeError: make_declarative_base() takes at most 2 arguments (3 given)
   
   ### Steps to reproduce
   virtualenv venvbeta
. ./venvbeta/bin/activate
   pip install --upgrade setuptools pip
   pip install mysqlclient
   pip install redis
   pip install pybigquery
   pip install --upgrade https://github.com/airbnb/superset/tarball/0.25.0rc1
   cd venvbeta
   cd bin
   cp /home/derwin/myvenv/bin/superset_config.py .
   superset db upgrade
   
/home/derwin/venvbeta/local/lib/python2.7/site-packages/sqlalchemy/ext/declarative/api.py:405:
 FSADeprecationWarning: "_BoundDeclarativeMeta" has been renamed to 
"DefaultMeta". The old name will be removed in 3.0.
 return declarative_base(**kw)
   Loaded your LOCAL configuration at 
[/home/derwin/venvbeta/bin/superset_config.pyc]
   
/home/derwin/venvbeta/local/lib/python2.7/site-packages/superset/security.py:11:
 FSADeprecationWarning: "_BoundDeclarativeMeta" has been renamed to 
"DefaultMeta". The old name will be removed in 3.0.
 from flask_appbuilder.security.sqla import models as ab_models
   
/home/derwin/venvbeta/local/lib/python2.7/site-packages/superset/security.py:11:
 FSADeprecationWarning: "_BoundDeclarativeMeta" has been renamed to 
"DefaultMeta". The old name will be removed in 3.0.
 from flask_appbuilder.security.sqla import models as ab_models
   
/home/derwin/venvbeta/local/lib/python2.7/site-packages/superset/security.py:11:
 FSADeprecationWarning: "_BoundDeclarativeMeta" has been renamed to 
"DefaultMeta". The old name will be removed in 3.0.
 from flask_appbuilder.security.sqla import models as ab_models
   
/home/derwin/venvbeta/local/lib/python2.7/site-packages/superset/security.py:11:
 FSADeprecationWarning: "_BoundDeclarativeMeta" has been renamed to 
"DefaultMeta". The old name will be removed in 3.0.
 from flask_appbuilder.security.sqla import models as ab_models
   
/home/derwin/venvbeta/local/lib/python2.7/site-packages/superset/security.py:11:
 FSADeprecationWarning: "_BoundDeclarativeMeta" has been renamed to 
"DefaultMeta". The old name will be removed in 3.0.
 from flask_appbuilder.security.sqla import models as ab_models
   
/home/derwin/venvbeta/local/lib/python2.7/site-packages/superset/security.py:11:
 FSADeprecationWarning: "_BoundDeclarativeMeta" has been renamed to 
"DefaultMeta". The old name will be removed in 3.0.
 from flask_appbuilder.security.sqla import models as ab_models
   Traceback (most recent call last):
 File "/home/derwin/venvbeta/bin/superset", line 12, in 
   from superset.cli import manager
 File 
"/home/derwin/venvbeta/local/lib/python2.7/site-packages/superset/__init__.py", 
line 89, in 
   db = SQLA(app)
 File 
"/home/derwin/venvbeta/local/lib/python2.7/site-packages/flask_sqlalchemy/__init__.py",
 line 677, in __init__
   self.Model = self.make_declarative_base(model_class, metadata)
   TypeError: make_declarative_base() takes at most 2 arguments (3 given)
   
   Can someone point me to what I messed up?
   ubuntu 14 I think with python 2.7.12
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] darylerwin commented on issue #945: Google BigQuery Support

[GitBox]

darylerwin commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384824298
 
 
   Where exactly is your .json file located ? Open it in file explorer to get 
the right path.
   
   The above error means you havent installed the package in the virtualenv.
   . ./venv1/bin/activate   (or however you activate in windows)
   # Try to install this again .. be sure you are in your virtual env
   pip install pybigquery
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] darylerwin commented on issue #945: Google BigQuery Support

[GitBox]

darylerwin commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384824298
 
 
   Where exactly is your .json file located ? Open it in file explorer to get 
the right path.
   
   The above error means you havent installed the package in the virtualenv.
   . ./venv1/bin/activate   (or however you activate in windows)
   '# Try to install this again .. be sure you are in your virtual env
   pip install pybigquery
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] graceguo-supercat opened a new pull request #4893: add sticky to sidepane

[GitBox]

graceguo-supercat opened a new pull request #4893: add sticky to sidepane
URL: https://github.com/apache/incubator-superset/pull/4893
 
 
   
![kbs2ejdu4y](https://user-images.githubusercontent.com/27990562/39336955-ffe08a66-496e-11e8-8d1a-b43c9b76e383.gif)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #4890: [bugfix] temporal columns with expression fail

[GitBox]

mistercrunch commented on a change in pull request #4890: [bugfix] temporal 
columns with expression fail
URL: 
https://github.com/apache/incubator-superset/pull/4890#discussion_r184558306
 
 

 ##
 File path: superset/connectors/sqla/models.py
 ##
 @@ -130,8 +131,9 @@ def get_timestamp_expression(self, time_grain):
 elif pdf == 'epoch_ms':
 expr = db_spec.epoch_ms_to_dttm().format(col=expr)
 grain = self.table.database.grains_dict().get(time_grain)
-literal = grain.function if grain else '{col}'
-literal = expr.format(col=expr)
+if grain:
+literal = grain.function
+literal = expr.format(col=expr)
 
 Review comment:
   Yeah I think we're both wrong on this one :( , I'm going to clean this up a 
bit more and write many tests covering the whole function.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] betodealmeida commented on a change in pull request #4890: [bugfix] temporal columns with expression fail

[GitBox]

betodealmeida commented on a change in pull request #4890: [bugfix] temporal 
columns with expression fail
URL: 
https://github.com/apache/incubator-superset/pull/4890#discussion_r184555680
 
 

 ##
 File path: superset/connectors/sqla/models.py
 ##
 @@ -130,8 +131,9 @@ def get_timestamp_expression(self, time_grain):
 elif pdf == 'epoch_ms':
 expr = db_spec.epoch_ms_to_dttm().format(col=expr)
 grain = self.table.database.grains_dict().get(time_grain)
-literal = grain.function if grain else '{col}'
-literal = expr.format(col=expr)
+if grain:
+literal = grain.function
+literal = expr.format(col=expr)
 
 Review comment:
   Yeah, I think this should be
   
   ```python
   literal = literal.format(col=expr)
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] betodealmeida commented on a change in pull request #4890: [bugfix] temporal columns with expression fail

[GitBox]

betodealmeida commented on a change in pull request #4890: [bugfix] temporal 
columns with expression fail
URL: 
https://github.com/apache/incubator-superset/pull/4890#discussion_r184555737
 
 

 ##
 File path: superset/connectors/sqla/models.py
 ##
 @@ -130,8 +131,9 @@ def get_timestamp_expression(self, time_grain):
 elif pdf == 'epoch_ms':
 expr = db_spec.epoch_ms_to_dttm().format(col=expr)
 grain = self.table.database.grains_dict().get(time_grain)
-literal = grain.function if grain else '{col}'
-literal = expr.format(col=expr)
+if grain:
+literal = grain.function
+literal = expr.format(col=expr)
 
 Review comment:
   See https://github.com/apache/incubator-superset/pull/4892


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4892: Fix time grain

[GitBox]

codecov-io commented on issue #4892: Fix time grain
URL: 
https://github.com/apache/incubator-superset/pull/4892#issuecomment-384809160
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4892?src=pr=h1)
 Report
   > Merging 
[#4892](https://codecov.io/gh/apache/incubator-superset/pull/4892?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/fa3da8c888e25b62e72faaab8987631f07096b56?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4892/graphs/tree.svg?token=KsB0fHcx6l=650=150=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4892?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4892   +/-   ##
   ===
 Coverage   76.97%   76.97%   
   ===
 Files  44   44   
 Lines8537 8537   
   ===
 Hits 6571 6571   
 Misses   1966 1966
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4892?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4892/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==)
 | `74.23% <0%> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4892?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4892?src=pr=footer).
 Last update 
[fa3da8c...840f498](https://codecov.io/gh/apache/incubator-superset/pull/4892?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] betodealmeida opened a new pull request #4892: Fix time grain

[GitBox]

betodealmeida opened a new pull request #4892: Fix time grain
URL: https://github.com/apache/incubator-superset/pull/4892
 
 
   Time grain was being ignored due to a small bug.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4891: Allow limiting rows on Pivot Table

[GitBox]

codecov-io commented on issue #4891: Allow limiting rows on Pivot Table
URL: 
https://github.com/apache/incubator-superset/pull/4891#issuecomment-384806142
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4891?src=pr=h1)
 Report
   > Merging 
[#4891](https://codecov.io/gh/apache/incubator-superset/pull/4891?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/fa3da8c888e25b62e72faaab8987631f07096b56?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4891/graphs/tree.svg?width=650=150=KsB0fHcx6l=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4891?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4891   +/-   ##
   ===
 Coverage   76.97%   76.97%   
   ===
 Files  44   44   
 Lines8537 8537   
   ===
 Hits 6571 6571   
 Misses   1966 1966
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4891?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4891?src=pr=footer).
 Last update 
[fa3da8c...12df68b](https://codecov.io/gh/apache/incubator-superset/pull/4891?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4890: [bugfix] temporal columns with expression fail

[GitBox]

codecov-io commented on issue #4890: [bugfix] temporal columns with expression 
fail
URL: 
https://github.com/apache/incubator-superset/pull/4890#issuecomment-384801471
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4890?src=pr=h1)
 Report
   > Merging 
[#4890](https://codecov.io/gh/apache/incubator-superset/pull/4890?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/fa3da8c888e25b62e72faaab8987631f07096b56?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4890/graphs/tree.svg?width=650=150=KsB0fHcx6l=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4890?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4890  +/-   ##
   ==
   - Coverage   76.97%   76.96%   -0.01% 
   ==
 Files  44   44  
 Lines8537 8543   +6 
   ==
   + Hits 6571 6575   +4 
   - Misses   1966 1968   +2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4890?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/data/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/4890/diff?src=pr=tree#diff-c3VwZXJzZXQvZGF0YS9fX2luaXRfXy5weQ==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4890/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==)
 | `73.93% <0%> (-0.31%)` | :arrow_down: |
   | 
[superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4890/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==)
 | `90.74% <100%> (+0.23%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4890?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4890?src=pr=footer).
 Last update 
[fa3da8c...6a7b25f](https://codecov.io/gh/apache/incubator-superset/pull/4890?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on a change in pull request #4890: [bugfix] temporal columns with expression fail

[GitBox]

xrmx commented on a change in pull request #4890: [bugfix] temporal columns 
with expression fail
URL: 
https://github.com/apache/incubator-superset/pull/4890#discussion_r184539575
 
 

 ##
 File path: tests/model_tests.py
 ##
 @@ -105,3 +105,9 @@ def test_grains_dict(self):
 self.assertEquals(d.get('day').function, 'DATE({col})')
 self.assertEquals(d.get('P1D').function, 'DATE({col})')
 self.assertEquals(d.get('Time Column').function, '{col}')
+
+def test_get_timestamp_expression(self):
+tbl = self.get_table_by_name('birth_names')
+ds_col = tbl.get_column('ds')
+sqla_literal = ds_col.get_timestamp_expression(None)
 
 Review comment:
   Or just add one test per database:
   
https://docs.python.org/2/library/unittest.html#skipping-tests-and-expected-failures


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on a change in pull request #4890: [bugfix] temporal columns with expression fail

[GitBox]

xrmx commented on a change in pull request #4890: [bugfix] temporal columns 
with expression fail
URL: 
https://github.com/apache/incubator-superset/pull/4890#discussion_r184537661
 
 

 ##
 File path: superset/connectors/sqla/models.py
 ##
 @@ -130,8 +131,9 @@ def get_timestamp_expression(self, time_grain):
 elif pdf == 'epoch_ms':
 expr = db_spec.epoch_ms_to_dttm().format(col=expr)
 grain = self.table.database.grains_dict().get(time_grain)
-literal = grain.function if grain else '{col}'
-literal = expr.format(col=expr)
+if grain:
+literal = grain.function
+literal = expr.format(col=expr)
 
 Review comment:
   Isn't this line always overriding the one before? the one before should be 
`expr = grain.function` or there should be an else branch somewhere


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] swamy16 commented on issue #945: Google BigQuery Support

[GitBox]

swamy16 commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384796852
 
 
   Also When I try connecting using UI I get the following error.
   
![superset_error_2](https://user-images.githubusercontent.com/19241632/3908-0ba0b976-49c8-11e8-9797-072541bc6eb8.PNG)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] emirot closed pull request #4780: [i18n] Add French translation

[GitBox]

emirot closed pull request #4780: [i18n] Add French translation
URL: https://github.com/apache/incubator-superset/pull/4780
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/translations/fr/LC_MESSAGES/messages.po 
b/superset/translations/fr/LC_MESSAGES/messages.po
index 33ce07e9a5..de684852e9 100644
--- a/superset/translations/fr/LC_MESSAGES/messages.po
+++ b/superset/translations/fr/LC_MESSAGES/messages.po
@@ -3690,3 +3690,22 @@ msgstr ""
 #: superset/views/sql_lab.py:79
 msgid "Saved Queries"
 msgstr "Requêtes sauvegardées"
+
+#: superset/templates/appbuilder/navbar_menu.html
+#: superset/templates/appbuilder/navbar.html:27
+msgid "List Users"
+msgstr "Lister les utilisateurs"
+
+#: superset/templates/appbuilder/navbar_menu.html
+#: superset/templates/appbuilder/navbar.html:27
+msgid "List Roles"
+msgstr "Lister les rôles"
+
+#: superset/templates/appbuilder/navbar_menu.html
+#: superset/templates/appbuilder/navbar.html:27
+msgid "User's Statistics"
+msgstr "Statistiques utilisateurs"
+
+#: superset/views/base.py:127
+msgid "Export to YAML"
+msgstr "Exporter en YAML"


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] emirot commented on issue #4780: [i18n] Add French translation

[GitBox]

emirot commented on issue #4780: [i18n] Add French translation
URL: 
https://github.com/apache/incubator-superset/pull/4780#issuecomment-384796601
 
 
   The PR dpgaspar/Flask-AppBuilder#735 got merged closing this one. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on a change in pull request #4890: [bugfix] temporal columns with expression fail

[GitBox]

xrmx commented on a change in pull request #4890: [bugfix] temporal columns 
with expression fail
URL: 
https://github.com/apache/incubator-superset/pull/4890#discussion_r184537661
 
 

 ##
 File path: superset/connectors/sqla/models.py
 ##
 @@ -130,8 +131,9 @@ def get_timestamp_expression(self, time_grain):
 elif pdf == 'epoch_ms':
 expr = db_spec.epoch_ms_to_dttm().format(col=expr)
 grain = self.table.database.grains_dict().get(time_grain)
-literal = grain.function if grain else '{col}'
-literal = expr.format(col=expr)
+if grain:
+literal = grain.function
+literal = expr.format(col=expr)
 
 Review comment:
   Isn't this line always overriding the one before? the one before should be 
`expr = grain.function` or something similar


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #4890: [bugfix] temporal columns with expression fail

[GitBox]

mistercrunch commented on a change in pull request #4890: [bugfix] temporal 
columns with expression fail
URL: 
https://github.com/apache/incubator-superset/pull/4890#discussion_r184538061
 
 

 ##
 File path: tests/model_tests.py
 ##
 @@ -105,3 +105,9 @@ def test_grains_dict(self):
 self.assertEquals(d.get('day').function, 'DATE({col})')
 self.assertEquals(d.get('P1D').function, 'DATE({col})')
 self.assertEquals(d.get('Time Column').function, '{col}')
+
+def test_get_timestamp_expression(self):
+tbl = self.get_table_by_name('birth_names')
+ds_col = tbl.get_column('ds')
+sqla_literal = ds_col.get_timestamp_expression(None)
 
 Review comment:
   The problem is the test will fail depending on the database it's working on. 
I guess I can figure out which engine it's on (postgres/mysql) and do the 
proper assertion depending on that


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on a change in pull request #4890: [bugfix] temporal columns with expression fail

[GitBox]

xrmx commented on a change in pull request #4890: [bugfix] temporal columns 
with expression fail
URL: 
https://github.com/apache/incubator-superset/pull/4890#discussion_r184537661
 
 

 ##
 File path: superset/connectors/sqla/models.py
 ##
 @@ -130,8 +131,9 @@ def get_timestamp_expression(self, time_grain):
 elif pdf == 'epoch_ms':
 expr = db_spec.epoch_ms_to_dttm().format(col=expr)
 grain = self.table.database.grains_dict().get(time_grain)
-literal = grain.function if grain else '{col}'
-literal = expr.format(col=expr)
+if grain:
+literal = grain.function
+literal = expr.format(col=expr)
 
 Review comment:
   Isn't this line always overriding the one before? Possible the one before 
should be `expr = grain.function` or something similar


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on a change in pull request #4890: [bugfix] temporal columns with expression fail

[GitBox]

xrmx commented on a change in pull request #4890: [bugfix] temporal columns 
with expression fail
URL: 
https://github.com/apache/incubator-superset/pull/4890#discussion_r184537661
 
 

 ##
 File path: superset/connectors/sqla/models.py
 ##
 @@ -130,8 +131,9 @@ def get_timestamp_expression(self, time_grain):
 elif pdf == 'epoch_ms':
 expr = db_spec.epoch_ms_to_dttm().format(col=expr)
 grain = self.table.database.grains_dict().get(time_grain)
-literal = grain.function if grain else '{col}'
-literal = expr.format(col=expr)
+if grain:
+literal = grain.function
+literal = expr.format(col=expr)
 
 Review comment:
   Isn't this line always overriding the one before?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hughhhh commented on issue #4891: Allow limiting rows on Pivot Table

[GitBox]

hug commented on issue #4891: Allow limiting rows on Pivot Table
URL: 
https://github.com/apache/incubator-superset/pull/4891#issuecomment-384796179
 
 
    


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hughhhh commented on a change in pull request #4890: [bugfix] temporal columns with expression fail

[GitBox]

hug commented on a change in pull request #4890: [bugfix] temporal columns 
with expression fail
URL: 
https://github.com/apache/incubator-superset/pull/4890#discussion_r184537516
 
 

 ##
 File path: tests/model_tests.py
 ##
 @@ -105,3 +105,9 @@ def test_grains_dict(self):
 self.assertEquals(d.get('day').function, 'DATE({col})')
 self.assertEquals(d.get('P1D').function, 'DATE({col})')
 self.assertEquals(d.get('Time Column').function, '{col}')
+
+def test_get_timestamp_expression(self):
+tbl = self.get_table_by_name('birth_names')
+ds_col = tbl.get_column('ds')
+sqla_literal = ds_col.get_timestamp_expression(None)
 
 Review comment:
   Can we add a test thats passing a value into `get_timestamp_expression()` to 
make sure we are returning the proper `literal_col`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch opened a new pull request #4891: Allow limiting rows on Pivot Table

[GitBox]

mistercrunch opened a new pull request #4891: Allow limiting rows on Pivot Table
URL: https://github.com/apache/incubator-superset/pull/4891
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch opened a new pull request #4890: [bugfix] temporal columns with expression fail

[GitBox]

mistercrunch opened a new pull request #4890: [bugfix] temporal columns with 
expression fail
URL: https://github.com/apache/incubator-superset/pull/4890
 
 
   error msg: "local variable 'literal' referenced before assignment"
   
   Error occurs [only] when using temporal column defined as a SQL
   expression.
   
   Also noticed that examples were using `granularity` instead of using
   `granularity_sqla` as they should. Fixed that here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] swamy16 commented on issue #945: Google BigQuery Support

[GitBox]

swamy16 commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384792564
 
 
   I double checked. The path is correct.
   
   and as for running the command 
   DIR C:\Users\sachitandandp\Downloads\
   I get the following error
   `The system cannot find the path specified.`
   
   I dont know why I am getting this error.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] darylerwin commented on issue #945: Google BigQuery Support

[GitBox]

darylerwin commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384789060
 
 
   yea.. Give the whole path..
   
   On Thu, Apr 26, 2018, 5:04 PM Tim Swast  wrote:
   
   > That's odd. That means Python cannot load the file at that path for some
   > reason. Are you sure the path is correct? Could you run DIR
   > C:\Users\sachitandandp\Downloads\ and check that the file is present?
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tswast commented on issue #945: Google BigQuery Support

[GitBox]

tswast commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384788427
 
 
   That's odd. That means Python cannot load the file at that path for some 
reason. Are you sure the path is correct? Could you run `DIR 
C:\Users\sachitandandp\Downloads\` and check that the file is present?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] swamy16 commented on issue #945: Google BigQuery Support

[GitBox]

swamy16 commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384787099
 
 
   @tswast 
   
   Initially I tried the same. It is still giving me the error.
   Attaching a snapshot of the same,
   
![superset_error_1](https://user-images.githubusercontent.com/19241632/39331646-c17a11c6-49c2-11e8-946a-ae8321efaa53.PNG)
   
   I think I am missing something.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] villebro commented on issue #4889: Fix regression in timestamp expression

[GitBox]

villebro commented on issue #4889: Fix regression in timestamp expression
URL: 
https://github.com/apache/incubator-superset/pull/4889#issuecomment-384786775
 
 
   No, unfortunately not, this effectively eliminated all grain rendering. Will 
try to look at those and related issues in the coming days (The Snowflake 
engine exhibits some funny behaviour that resembles the %-bug).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tswast commented on issue #945: Google BigQuery Support

[GitBox]

tswast commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384786370
 
 
   @swamy16 This error is a good sign. It means that you are definitely setting 
the variable so that the code can find it.
   
   You need to specify the full path when you are setting the variable. On 
Windows this includes the Disk Name: 
`C:\Users\[YOUR_USER_NAME]\Downloads\[FILE_NAME].json`. The path could be 
anywhere, not just the downloads folder. On Linux or macOS the full path starts 
with a slash: `/home/user/Downloads/service-account-file.json`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4889: Fix regression in timestamp expression

[GitBox]

codecov-io commented on issue #4889: Fix regression in timestamp expression
URL: 
https://github.com/apache/incubator-superset/pull/4889#issuecomment-384785357
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4889?src=pr=h1)
 Report
   > Merging 
[#4889](https://codecov.io/gh/apache/incubator-superset/pull/4889?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/fa3da8c888e25b62e72faaab8987631f07096b56?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4889/graphs/tree.svg?height=150=650=KsB0fHcx6l=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4889?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4889   +/-   ##
   ===
 Coverage   76.97%   76.97%   
   ===
 Files  44   44   
 Lines8537 8537   
   ===
 Hits 6571 6571   
 Misses   1966 1966
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4889?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4889/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==)
 | `74.23% <0%> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4889?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4889?src=pr=footer).
 Last update 
[fa3da8c...e269a1c](https://codecov.io/gh/apache/incubator-superset/pull/4889?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4889: Fix regression in timestamp expression

[GitBox]

codecov-io commented on issue #4889: Fix regression in timestamp expression
URL: 
https://github.com/apache/incubator-superset/pull/4889#issuecomment-384785357
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4889?src=pr=h1)
 Report
   > Merging 
[#4889](https://codecov.io/gh/apache/incubator-superset/pull/4889?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/fa3da8c888e25b62e72faaab8987631f07096b56?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4889/graphs/tree.svg?width=650=150=KsB0fHcx6l=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4889?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4889   +/-   ##
   ===
 Coverage   76.97%   76.97%   
   ===
 Files  44   44   
 Lines8537 8537   
   ===
 Hits 6571 6571   
 Misses   1966 1966
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4889?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4889/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==)
 | `74.23% <0%> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4889?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4889?src=pr=footer).
 Last update 
[fa3da8c...e269a1c](https://codecov.io/gh/apache/incubator-superset/pull/4889?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] swamy16 commented on issue #945: Google BigQuery Support

[GitBox]

swamy16 commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384785260
 
 
   @darylerwin  @tswast sorry for asking more dumb questions.
   
   when I use the following code 
   `set 
GOOGLE_APPLICATION_CREDENTIALS="Downloads\My_First_Project_79feb5164038.json"`
   I get the following error
   
   `google.auth.exceptions.DefaultCredentialsError: File 
"Downloads\My_First_Project_79feb5164038.json" was not found.`
   
   Somehow the app is throwing this exception.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] villebro opened a new pull request #4889: Fix regression in timestamp expression

[GitBox]

villebro opened a new pull request #4889: Fix regression in timestamp expression
URL: https://github.com/apache/incubator-superset/pull/4889
 
 
   Change to superset/connectors/sqla/models.py in #4821 introduced a 
regression, breaking time grain rendering.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tswast commented on issue #945: Google BigQuery Support

[GitBox]

tswast commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384775275
 
 
   @swamy16 : @darylerwin is correct. To use default credentials you must set 
the `GOOGLE_APPLICATION_CREDENTIALS` environment variable.
   
   As an alternative, I've filed 
https://github.com/mxmzdlv/pybigquery/issues/14 to allow specifying path to 
service account key file via the connection string.
   
   **Linux or macOS**
   
   Replace [PATH] with the file path of the JSON file that contains your 
service account key.
   
   ```
   export GOOGLE_APPLICATION_CREDENTIALS="[PATH]"
   ```
   
   For example:
   
   ```
   export 
GOOGLE_APPLICATION_CREDENTIALS="/home/user/Downloads/service-account-file.json"
   ```
   
   **Windows**
   
   Replace [PATH] with the file path of the JSON file that contains your 
service account key, and [FILE_NAME] with the filename.
   
   With PowerShell:
   
   ```
   $env:GOOGLE_APPLICATION_CREDENTIALS="[PATH]"
   ```
   
   For example:
   
   ```
   
$env:GOOGLE_APPLICATION_CREDENTIALS="C:\Users\username\Downloads\[FILE_NAME].json"
   ```
   
   With command prompt:
   
   ```
   set GOOGLE_APPLICATION_CREDENTIALS=[PATH]
   ```
   
   (From https://cloud.google.com/bigquery/docs/reference/libraries)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] darylerwin commented on issue #945: Google BigQuery Support

[GitBox]

darylerwin commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384774163
 
 
   I set this in my box that is running superset via .profile
   
   export 
GOOGLE_APPLICATION_CREDENTIALS="/home/derwin/my-production-bigdata-key.json"
   
   And that json file should similar in format to:
   {
 "type": "service_account",
 "project_id": "xata",
 "private_key_id": "cb8c5d3d7b03203",
 "private_key": "-BEGIN PRIVATE KEY-\nMIIEvQ
   etcetc
   }
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tcollier1975 closed issue #4022: Table View Filter does not work and throws exception

[GitBox]

tcollier1975 closed issue #4022: Table View Filter does not work and throws 
exception
URL: https://github.com/apache/incubator-superset/issues/4022
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on issue #4888: Unable to open superset

[GitBox]

xrmx commented on issue #4888: Unable to open superset
URL: 
https://github.com/apache/incubator-superset/issues/4888#issuecomment-384770259
 
 
   Since it looks like you are already using superset from git, use a newer git 
master that has all this sorted out. Just remember to install the 
requirements.txt.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] swamy16 commented on issue #945: Google BigQuery Support

[GitBox]

swamy16 commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384769951
 
 
   @darylerwin @mxmzdlv need your help here again.
   @darylerwin I did install superset in venv but still getting the error.
   So I created a different venv named venv1 and tried installing everything 
from scratch. (Now I think I installed everything right).
   
   Here while running the following code 
   `engine = create_engine('bigquery://my_project')`
   I got the following error
   `google.auth.exceptions.DefaultCredentialsError: Could not automatically 
determine credentials. Please set GOOGLE_APPLICATION_CREDENTIALS or
   explicitly create credential and re-run the application. For more
   information, please see
   https://developers.google.com/accounts/docs/application-default-credentials.`
   (Because of the errormessage I said I did something right although I don't 
know what)
   
   I have the created a service account key and have the json file in my 
laptop. I think I have to use the file but amd not sure of how to use it(I mean 
which folder should I keep the file or in which of the scripts within 
'venv1\Lib\site-packages\google\auth' folder ('_cloud_sdk', '_default', 
'_oauth2client', '_service_account_info', 'app_engine', 'credentials', 
'environment_vars') should I modify so that it reads my file and authenticates 
my google account.  
   
   Please do help me with this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] swamy16 commented on issue #945: Google BigQuery Support

[GitBox]

swamy16 commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384621475
 
 
   
   
![superset_error](https://user-images.githubusercontent.com/19241632/39325671-6d2542b0-49b0-11e8-8c88-469ffae2e1b2.PNG)
   
   
   I got this error while trying to connect to bigquery.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] qxlsz opened a new issue #4888: Unable to open superset

[GitBox]

qxlsz opened a new issue #4888: Unable to open superset
URL: https://github.com/apache/incubator-superset/issues/4888
 
 
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [ ] I have checked the superset logs for python stacktraces and included 
it here as text if any
   - [ ] I have reproduced the issue with at least the latest released version 
of superset
   - [ ] I have checked the issue tracker for the same issue and I haven't 
found one similar
   
   
   ### Superset version
   superset==0.23.0.dev0
   
   
   ### Expected results
   
   
   ### Actual results
   (superset) LUSC02WD09JHTDH:incubator-superset rjosyula$ superset
   Traceback (most recent call last):
 File "/Users/rjosyula/superset/bin/superset", line 4, in 
   __import__('pkg_resources').run_script('superset==0.23.0.dev0', 
u'superset')
 File 
"/Users/rjosyula/superset/lib/python2.7/site-packages/pkg_resources/__init__.py",
 line 3088, in 
   @_call_aside
 File 
"/Users/rjosyula/superset/lib/python2.7/site-packages/pkg_resources/__init__.py",
 line 3072, in _call_aside
   f(*args, **kwargs)
 File 
"/Users/rjosyula/superset/lib/python2.7/site-packages/pkg_resources/__init__.py",
 line 3101, in _initialize_master_working_set
   working_set = WorkingSet._build_master()
 File 
"/Users/rjosyula/superset/lib/python2.7/site-packages/pkg_resources/__init__.py",
 line 574, in _build_master
   ws.require(__requires__)
 File 
"/Users/rjosyula/superset/lib/python2.7/site-packages/pkg_resources/__init__.py",
 line 892, in require
   needed = self.resolve(parse_requirements(requirements))
 File 
"/Users/rjosyula/superset/lib/python2.7/site-packages/pkg_resources/__init__.py",
 line 778, in resolve
   raise DistributionNotFound(req, requirers)
   pkg_resources.DistributionNotFound: The 'unidecode>=0.04.21' distribution 
was not found and is required by superset
   
   ### Steps to reproduce
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] vylc commented on issue #4641: Kill Slice naming convention...

[GitBox]

vylc commented on issue #4641: Kill Slice naming convention...
URL: 
https://github.com/apache/incubator-superset/pull/4641#issuecomment-384722938
 
 
   Found a few more--new issue or add on here?
   (1) Copy Dashboard - go to any dashboard, under Actions, choose Save, dialog 
box asks to copy slices
   (2) Edit table - Details/Summary tab, Associated charts section instructions 
has slice references everywhere
   (3) Edit chart - In the Details/Summary tab, cache timeout references slice


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] vylc commented on issue #4641: Kill Slice naming convention...

[GitBox]

vylc commented on issue #4641: Kill Slice naming convention...
URL: 
https://github.com/apache/incubator-superset/pull/4641#issuecomment-384722938
 
 
   Found a few more--new issue or add on here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] john-bodley opened a new pull request #4887: [druid] Updating Druid refresh metadata tests

[GitBox]

john-bodley opened a new pull request #4887: [druid] Updating Druid refresh 
metadata tests
URL: https://github.com/apache/incubator-superset/pull/4887
 
 
   This PR updates the Druid tests for refreshing of the metadata in the 
following ways:
   - Removes the unnecessary enumerating of datasources as there's only one.
   - Adds a check that the column type also is updated during the refresh. 
Previously we only checked the updated metrics. 
   
   to: @GabeLoins


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4886: remove hard code http scheme of short url #4656

[GitBox]

codecov-io commented on issue #4886: remove hard code http scheme of short url 
#4656
URL: 
https://github.com/apache/incubator-superset/pull/4886#issuecomment-384570274
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4886?src=pr=h1)
 Report
   > Merging 
[#4886](https://codecov.io/gh/apache/incubator-superset/pull/4886?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/fa3da8c888e25b62e72faaab8987631f07096b56?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4886/graphs/tree.svg?height=150=650=KsB0fHcx6l=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4886?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4886   +/-   ##
   ===
 Coverage   76.97%   76.97%   
   ===
 Files  44   44   
 Lines8537 8537   
   ===
 Hits 6571 6571   
 Misses   1966 1966
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4886?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4886/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==)
 | `74.68% <ø> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4886?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4886?src=pr=footer).
 Last update 
[fa3da8c...b28090d](https://codecov.io/gh/apache/incubator-superset/pull/4886?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ripoul commented on issue #4886: remove hard code http scheme of short url #4656

[GitBox]

ripoul commented on issue #4886: remove hard code http scheme of short url #4656
URL: 
https://github.com/apache/incubator-superset/pull/4886#issuecomment-384705396
 
 
   for your first question : it's a probleme when your server accept only https 
request. In this case we would like to respond with the same scheme than the 
request to be sure the server can handle it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] john-bodley commented on a change in pull request #4886: remove hard code http scheme of short url #4656

[GitBox]

john-bodley commented on a change in pull request #4886: remove hard code http 
scheme of short url #4656
URL: 
https://github.com/apache/incubator-superset/pull/4886#discussion_r184451027
 
 

 ##
 File path: superset/views/core.py
 ##
 @@ -748,9 +748,10 @@ def shortner(self):
 obj = models.Url(url=url)
 db.session.add(obj)
 db.session.commit()
+scheme = request.scheme
 
 Review comment:
   Why do we need this temporary variable? I sense it adds for more obfuscation 
and thus would include this on line 754.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] darylerwin commented on issue #945: Google BigQuery Support

[GitBox]

darylerwin commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384635550
 
 
   Did you do your pip install within your virtual env?
   Only other little things I see different then mine is:
   URI has trailing slash .. 
   bigquery://my-production-bigdata/
   and for extras I added some debugging..
   
   {
   "metadata_params": {},
   "engine_params": {"echo":True}
   }
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] darylerwin commented on issue #945: Google BigQuery Support

[GitBox]

darylerwin commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384635550
 
 
   Did you do your pip install within your virtual env?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] swamy16 commented on issue #945: Google BigQuery Support

[GitBox]

swamy16 commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384620285
 
 
   @mxmzdlv Thanks for your quick response. I tried the method you suggested
   `pip install pybigquery --upgrade. It didnt work`.
   
   Then I uninstalled pyodbc using 
   `pip uninstall pyodbc` 
   
   and again ran the same commands
   engine = create_engine('bigquery://My_database')
   
   I got an error showing 
   `Traceback (most recent call last):
 File "", line 1, in 
 File 
"C:\Users\sachitanandp\venv\lib\site-packages\sqlalchemy\engine\__init__.py", 
line 419, in create_engine
   return strategy.create(*args, **kwargs)
 File 
"C:\Users\sachitanandp\venv\lib\site-packages\sqlalchemy\engine\strategies.py", 
line 80, in create
   dbapi = dialect_cls.dbapi(**dbapi_args)
 File 
"C:\Users\sachitanandp\venv\lib\site-packages\sqlalchemy\connectors\pyodbc.py", 
line 38, in dbapi
   return __import__('pyodbc')
   ModuleNotFoundError: No module named 'pyodbc'`
   
   I dont know if I am doing the right thing.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] swamy16 commented on issue #945: Google BigQuery Support

[GitBox]

swamy16 commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384621475
 
 
   
![superset_error](https://user-images.githubusercontent.com/19241632/39305415-a4e25d18-497a-11e8-9783-d54fa72d4dad.PNG)
   
   I got this error while trying to connect to bigquery.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] swamy16 commented on issue #945: Google BigQuery Support

[GitBox]

swamy16 commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384620285
 
 
   @mxmzdlv Thanks for your quick response. I tried the method you suggested
   `pip install pybigquery --upgrade. It didnt work`.
   
   Then I uninstalled pyodbc using 
   `pip uninstall pyodbc` 
   
   and again ran the same commands
   engine = create_engine('bigquery://compact-arc-200812')
   
   I got an error showing 
   `Traceback (most recent call last):
 File "", line 1, in 
 File 
"C:\Users\sachitanandp\venv\lib\site-packages\sqlalchemy\engine\__init__.py", 
line 419, in create_engine
   return strategy.create(*args, **kwargs)
 File 
"C:\Users\sachitanandp\venv\lib\site-packages\sqlalchemy\engine\strategies.py", 
line 80, in create
   dbapi = dialect_cls.dbapi(**dbapi_args)
 File 
"C:\Users\sachitanandp\venv\lib\site-packages\sqlalchemy\connectors\pyodbc.py", 
line 38, in dbapi
   return __import__('pyodbc')
   ModuleNotFoundError: No module named 'pyodbc'`
   
   I dont know if I am doing the right thing.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] swamy16 commented on issue #945: Google BigQuery Support

[GitBox]

swamy16 commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384613448
 
 
   Also I am running these commands from my command promt. I am still unsure of 
how my superset will be connected to Bigquery. I have not provided any 
credentials anywhere nor has it been mentioned anywhere. It would be great If 
anyone can give any clarity on that as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mxmzdlv commented on issue #945: Google BigQuery Support

[GitBox]

mxmzdlv commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384616319
 
 
   @swamy16 Not sure what's happening, but it seems like it doesn't recognize 
BigQuery and is trying to use pyodbc db-api instead. I would recommend asking 
SQLAlchemy community about this.
   
   To run BigQuery in Superset just install pybigquery in the environment with 
your Superset:
   ```pip install pybigquery --upgrade```
   
   Afterwards, create a new Database in Superset (menu Source > Databases) and 
use the connection string `bigquery://your_project_id`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mxmzdlv commented on issue #945: Google BigQuery Support

[GitBox]

mxmzdlv commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384616319
 
 
   @swamy16 Not sure what's happening, but it seems like it doesn't recognize 
BigQuery and is trying to use pyodbc db-api instead. I would recommend asking 
SQLAlchemy community about this.
   
   To run BigQuery in Superset just install pybigquery in the environment with 
your superset:
   ```pip install pybigquery --upgrade```
   
   Afterwards, create a new Database in Superset (menu Source > Databases) and 
use the connection string `bigquery://your_project_id`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] swamy16 commented on issue #945: Google BigQuery Support

[GitBox]

swamy16 commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384613448
 
 
   Also I am running these commands from my command promt. I am still unsure of 
how my superset will be connected to Bigquery. It would be great If anyone can 
give any clarity on that as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] swamy16 commented on issue #945: Google BigQuery Support

[GitBox]

swamy16 commented on issue #945: Google BigQuery Support
URL: 
https://github.com/apache/incubator-superset/issues/945#issuecomment-384611534
 
 
   Hi all,
   I am trying to connect bigquery to superset using the method specified by 
@mxmzdlv on Jun 7, 2017. I am receiving an error while connecting. I ran the 
following code
   
   from sqlalchemy import *
   from sqlalchemy.engine import create_engine
   from sqlalchemy.schema import *
   engine = create_engine('bigquery://my_project_id')
   table = Table('Weekly_trial.hour_timeband_mapping', MetaData(bind=engine), 
autoload=True)
   
   Error I got is as below
   sqlalchemy.exc.InterfaceError: (pyodbc.InterfaceError) ('IM002', '[IM002] 
[Microsoft][ODBC Driver Manager] Data source name not found and no default 
driver specified (0) (SQLDriverConnect)') (Background on this error at: 
http://sqlalche.me/e/rvf5)
   
   I ran the above code in command promt in windows 10 in python module.
   
   Please let me know If I am doing anything wrong. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ripoul commented on issue #4886: remove hard code http scheme of short url #4656

[GitBox]

ripoul commented on issue #4886: remove hard code http scheme of short url #4656
URL: 
https://github.com/apache/incubator-superset/pull/4886#issuecomment-384570892
 
 
   @xrmx done ! ty for your help ! :smiley: 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4886: remove hard code http scheme of short url #4656

[GitBox]

codecov-io commented on issue #4886: remove hard code http scheme of short url 
#4656
URL: 
https://github.com/apache/incubator-superset/pull/4886#issuecomment-384570274
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4886?src=pr=h1)
 Report
   > Merging 
[#4886](https://codecov.io/gh/apache/incubator-superset/pull/4886?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/fa3da8c888e25b62e72faaab8987631f07096b56?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4886/graphs/tree.svg?token=KsB0fHcx6l=650=150=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4886?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4886  +/-   ##
   ==
   + Coverage   76.97%   76.97%   +<.01% 
   ==
 Files  44   44  
 Lines8537 8538   +1 
   ==
   + Hits 6571 6572   +1 
 Misses   1966 1966
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4886?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4886/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==)
 | `74.7% <100%> (+0.01%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4886?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4886?src=pr=footer).
 Last update 
[fa3da8c...2ceeaf0](https://codecov.io/gh/apache/incubator-superset/pull/4886?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4886: remove hard code http scheme of short url #4656

[GitBox]

codecov-io commented on issue #4886: remove hard code http scheme of short url 
#4656
URL: 
https://github.com/apache/incubator-superset/pull/4886#issuecomment-384570274
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4886?src=pr=h1)
 Report
   > Merging 
[#4886](https://codecov.io/gh/apache/incubator-superset/pull/4886?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/fa3da8c888e25b62e72faaab8987631f07096b56?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4886/graphs/tree.svg?src=pr=KsB0fHcx6l=650=150)](https://codecov.io/gh/apache/incubator-superset/pull/4886?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4886  +/-   ##
   ==
   + Coverage   76.97%   76.97%   +<.01% 
   ==
 Files  44   44  
 Lines8537 8538   +1 
   ==
   + Hits 6571 6572   +1 
 Misses   1966 1966
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4886?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4886/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==)
 | `74.7% <100%> (+0.01%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4886?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4886?src=pr=footer).
 Last update 
[fa3da8c...2ceeaf0](https://codecov.io/gh/apache/incubator-superset/pull/4886?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asjolaviral commented on issue #3070: date and datetime

[GitBox]

asjolaviral commented on issue #3070: date and datetime 
URL: 
https://github.com/apache/incubator-superset/issues/3070#issuecomment-384569434
 
 
   It also works for me DATE_FORMAT(date,'%Y-%m-%d'), how can we get Year only.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on issue #4886: remove hard code http scheme of short url #4656

[GitBox]

xrmx commented on issue #4886: remove hard code http scheme of short url #4656
URL: 
https://github.com/apache/incubator-superset/pull/4886#issuecomment-384564829
 
 
   @ripoul you fix what hey report:
   ./superset/views/core.py:754:13: E122 continuation line missing indentation 
or outdented
   
   that means that you have to readd the 4 spaces indentation you removed :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on issue #4886: remove hard code http scheme of short url #4656

[GitBox]

xrmx commented on issue #4886: remove hard code http scheme of short url #4656
URL: 
https://github.com/apache/incubator-superset/pull/4886#issuecomment-384564829
 
 
   @ripoul you fix what hey report:
   ./superset/views/core.py:754:13: E122 continuation line missing indentation 
or outdented
   
   that means that you have to readd the 4 spaces indentation you removed )


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ripoul commented on issue #4886: remove hard code http scheme of short url #4656

[GitBox]

ripoul commented on issue #4886: remove hard code http scheme of short url #4656
URL: 
https://github.com/apache/incubator-superset/pull/4886#issuecomment-384556708
 
 
   how can I make the test succeed ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on issue #4886: remove hard code http scheme of short url #4656

[GitBox]

xrmx commented on issue #4886: remove hard code http scheme of short url #4656
URL: 
https://github.com/apache/incubator-superset/pull/4886#issuecomment-384552150
 
 
   @ripoul i think it would be more complicated than that to have the full url 
with scheme and host. Don't mind that, we can cleanup that later.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ripoul commented on issue #4886: remove hard code http scheme of short url #4656

[GitBox]

ripoul commented on issue #4886: remove hard code http scheme of short url #4656
URL: 
https://github.com/apache/incubator-superset/pull/4886#issuecomment-384551571
 
 
   something like this ? (I never use url_for)
   
   ```
   url_for(directory,  r=obj.id)
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on a change in pull request #4886: remove hard code http scheme of short url #4656

[GitBox]

xrmx commented on a change in pull request #4886: remove hard code http scheme 
of short url #4656
URL: 
https://github.com/apache/incubator-superset/pull/4886#discussion_r184299506
 
 

 ##
 File path: superset/views/core.py
 ##
 @@ -748,9 +748,10 @@ def shortner(self):
 obj = models.Url(url=url)
 db.session.add(obj)
 db.session.commit()
+scheme = request.scheme
 return Response(
-'http://{request.headers[Host]}/{directory}?r={obj.id}'.format(
-request=request, directory=directory, obj=obj),
+
'{scheme}://{request.headers[Host]}/{directory}?r={obj.id}'.format(  
+scheme = scheme, request=request, directory=directory, obj=obj),  
 
 Review comment:
   no spaces around =, and don't  add whitespace before new line please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ripoul opened a new pull request #4886: remove hard code http scheme of short url #4656

[GitBox]

ripoul opened a new pull request #4886: remove hard code http scheme of short 
url #4656
URL: https://github.com/apache/incubator-superset/pull/4886
 
 
   remove the hard code http. get the scheme of the request and use it to 
create the new url


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Maxwell2022 opened a new issue #4885: [0.24.0] Explore / Visualise - Cannot read property 'match' of null

[GitBox]

Maxwell2022 opened a new issue #4885: [0.24.0] Explore / Visualise - Cannot 
read property 'match' of null
URL: https://github.com/apache/incubator-superset/issues/4885
 
 
   I'm getting an error when creating a table from a SQL editor (visualise). 
   
   When clicking on visualise, it's redirecting me to `/superset/explore/` and 
loading forever with the following javascript error:
   
   
![image](https://user-images.githubusercontent.com/670701/39290958-a9b89330-4974-11e8-8cbb-dc233294697b.png)
   
   It's doing this with a specific table, I just have a `SELECT * FROM 
"table_name" LIMIT 10` and it's crashing the visualiser. If I try with another 
table, then it's working. I thing it depends of the columns / data that is 
returned.
   
   ### Superset version
   0.24.0
   
   ### Expected results
   Display the visualisation
   
   ### Actual results
   Javascript error
   
   ### Steps to reproduce
   1. Add a PostgreSQL source
   2. Go to the SQL Editor
   3. Perform a simple SQL query (not sure which one, some of them are working)
   4. Click on visualise (leave the default checkbox)
   5. Click on visualise again
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services