[jira] [Commented] (SUPERSET-11) Remove unnecessary parens in druid/models.py

[Beto Dealmeida (Jira)]

[ 
https://issues.apache.org/jira/browse/SUPERSET-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951183#comment-16951183
 ] 

Beto Dealmeida commented on SUPERSET-11:


It's interesting, I though black ([https://pypi.org/project/black/]) would take 
care of this.

> Remove unnecessary parens in druid/models.py
> 
>
> Key: SUPERSET-11
> URL: https://issues.apache.org/jira/browse/SUPERSET-11
> Project: Superset
>  Issue Type: Improvement
>Reporter: Jakob Homan
>Priority: Trivial
>  Labels: newbie
>
> Line: 425
> {code:python:title=druids.model/py}
> @property
> def perm(self) -> Optional[str]:
> return (
> ("{parent_name}.[{obj.metric_name}](id:{obj.id})").format(
> obj=self, parent_name=self.datasource.full_name
> )
> if self.datasource
> else None
> )
> {code}
> The parens around the string are not necessary and add visual confusion to 
> the other parens in the statement.  They should be removed and format 
> directly called on the string.
> *Note:* This is a newbie ticket designed as a starter task for a new 
> contributor.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Convenience releases

[Beto Dealmeida]

I'll try to reach out to him.


On 8/28/19 9:24 AM, Maxime Beauchemin wrote:

I couldn't find that person's contact info, so I'm not sure how to go about
it.

Max

On Wed, Aug 28, 2019 at 9:21 AM Stephanie Rivera 
wrote:


Good point!

Cheers,

Stephanie


*Stephanie Rivera* |* Vice President, Data Intelligence*

8181 Arista Place | Broomfield, CO 80021

<
http://www.google.com/url?q=http%3A%2F%2Fwww.spotxchange.com%2F&sa=D&sntz=1&usg=AFrqEzdlZjMtAvYRCQByfN6D_6PjZhSbSw

*Everyone

you will ever meet knows something you don't.*

<
https://www.google.com/url?q=https%3A%2F%2Fdl.dropbox.com%2Fs%2F5se5ucpqodjsq1h%2Flinkedin.png&sa=D&sntz=1&usg=AFrqEzdTHQrlDWywpW7VZVpwGJJdOBY-Wg



On Wed, Aug 28, 2019 at 10:16 AM Bolke de Bruin  wrote:


You could argue that for a convenience release you could use "superset
based on the source release of Apache superset" which might get

rid/reduce

the licensing challenge. It's not an official release channel so why

treat

it as such?

Did you try contacting the author on pypi's superset? It's a bit a
trademark issue I guess. You could ask Apache legal to help eventually as
trademark protection is important. Besides malware could be spread this

way

as well.

B.

Sent from my iPhone


On 28 Aug 2019, at 18:04, Maxime Beauchemin <

maximebeauche...@gmail.com>

wrote:

Hi all,

Now that 0.34.0 is out, I'd like to ship convenience releases in the

for

of

a PyPI.org release and a Docker image, ideally served on dockerhub.

Now we have a few blockers/concerns:

* as mentioned before, it looks like someone claimed "apache-superset"

on

pypi.org, probably by mistake.

https://pypi.org/user/cidiomar.dias.restoque/,

there's no process to re-claim it just yet, but folks seem to be

working

on

it here https://github.com/pypa/warehouse/issues/1506. Anyone has the
ability to pull strings at pypi.org ? :)
* can we just use `superset` in pypi (which we own) or does it have to

be

`apache-superset`?
* for a release to be convenient, we should ship our minified JS

bundles,

but I'm afraid that forces us to craft a 600+ entries LICENSE file
dynamically. Workaround might be to add a `superset build` command that
would well build this stuff. Requires having npm/node and such, working

on

some user-space dir as we should treat `site-packages` as be immutable.

I'm

not sure if that's reasonable/doable
* about docker, I'm assuming similar licensing issues for images that
contain minified bundles (is that the case?), but it's probably ok to

share

just a Dockerfile itself
* Maybe we should just automate the process that compiles the LICENSE

file

with the 600 npm libs? I did a bit of work in that area before
https://github.com/apache/incubator-superset/pull/5801

Thoughts?

Max

Re: Convenience releases

[Beto Dealmeida]

On 8/28/19 9:04 AM, Maxime Beauchemin wrote:


* as mentioned before, it looks like someone claimed "apache-superset" on
pypi.org, probably by mistake.https://pypi.org/user/cidiomar.dias.restoque/,
there's no process to re-claim it just yet, but folks seem to be working on
it herehttps://github.com/pypa/warehouse/issues/1506. Anyone has the
ability to pull strings at pypi.org ?


There's a process for claiming a package name from PyPI, I recently was 
able to get ownership of the "rison" project. This is the PR I made to 
claim it:


https://github.com/pypa/warehouse/issues/4140

It took more than a year (!), but maybe we can be more vocal about it. :)


--Beto

Re: [RESULT][VOTE] Release Superset 0.34.0 based on Superset 0.34.0rc1

[Beto Dealmeida]

I can take a look at the release today and vote.

On 8/15/19 3:51 PM, Alan Gates wrote:

We should have a 3rd PPMC vote.  If we can get Thejas or Jakob to vote as
mentors that will give us another PPMC vote and one more IPMC vote.

Alan.

On Thu, Aug 15, 2019 at 2:26 PM Maxime Beauchemin <
maximebeauche...@gmail.com> wrote:


Vote passes!

+2 binding votes (Alan & Max)
+3 non-binding vote (Ville, Charles, Bolke)

No neutral or negative votes.

Now (assuming 2 binding votes are enough) I have to figure out what my
steps are. I think it consist of starting a vote thread similar to this one
on gene...@incubator.apache.org where I [think I] need 3 or more IPMC
binding votes.

Max

On Mon, Aug 12, 2019 at 2:48 PM Maxime Beauchemin <
maximebeauche...@gmail.com> wrote:


+cc Justin  I'd appreciate if you could do a pass on this as you

uncovered

the most issues last time

Thanks,

Max

On Mon, Aug 12, 2019 at 1:38 PM Maxime Beauchemin <
maximebeauche...@gmail.com> wrote:


We should probably develop and evolve guidelines on what constitutes a
release blocker. For this first Apache release I think we're more

focussed

on license-related topics and ASF-type requirements along with "P0"-type
blockers that would make significant portions of Superset unusable.

Bellow are some of the issues raised in a previous release attempt (from
an email that Justin McLean sent). I believe everything in there has

been

tackled, but we should probably double check.

```
I checked:
- incubating is missing from name
- signatures and hashes good
- DISCLAIMER exists
- LICENSE is missing a few licenses (see below)
- NOTICE should not include LICENSE information e.g The line about CC
4.0. This may need to be removed. Also this content may be Category X

and

this can’t included in a source release. [11]
- Some 3rd party code have headers with "[LICENSE TBD]” [4][5][6][7][9]
which seems odd
- The ASF headers on a number of files are not correct e.g the file [13]
and other under that directory (search for COPYRIGHT 2016 and and

COPYRIGHT

2017 and COPYRIGHT 2018) Or are these files not actually licensed to the
ASF?
- Source release may contained compiled code e.g [20] my understanding

is

that a .mo file is compiled from the .po file. I not sure if it could be
classified as code however, but even if that is so it may be best to

remove

them from the source release.

There is a few bits of missing licensing  information:
- How is the map date here licensed? [3] Is it from
http://www.diva-gis.org/Data? I can see there is a credit in the code
that has a link to https://bl.ocks.org/john-guerra. How is that code
licensed?
- This file [7] is missing from LICENSE I assume it’s public domain? [8]
- This file [9] is licensed how? It seems to come from here [10] which
says to contact the author for a license.
- How is this image [14] licensed? (One reference I found said it could
only be used for personal use [21])
- LICENSE is missing license information for these fonts
[15][16][17][18][19] The license for Glyphicons Halflings is complex

and in

this context (outside of bootstrap) a commercial license may be needed

[22]

and so it can’t be included.

Some other improvements that could be made:
- The LICENSE fieldworker is a little odd with headings like BSD

2-Clause

licenses with noting under them, people (or tools) may incorrectly

assume

that it does contain BSD 2-Clause licensed code.
- Make vote link link in future emails to lists.apache,org
- Sign release with an apache.org email address
- This [12] has copyright 2018 when it shovel be 2019

Thanks,
Justin

1. https://incubator.apache.org/policy/incubation.html#releases
2.


https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist

3. apache-superset
-0.32.0rc2/superset/assets/src/visualizations/CountryMap/*
4.

apache-superset-0.32.0rc2/superset/assets/vendor/cal-heatmap/cal-heatmap.js

/ .css
5

apache-superset-0.32.0rc2/superset/assets/vendor/parallel_coordinates/d3.parcoords.js

/ .css
6. apache-superset
-0.32.0rc2/superset/assets/vendor/parallel_coordinates/divgrid.js
7 apache-superset-0.32.0rc2/superset/assets/vendor/pygments.css
8. https://github.com/richleland/pygments-css/blob/master/UNLICENSE.txt
9. ./apache-superset
-0.32.0rc2/superset/assets/vendor/parallel_coordinates/divgrid.js
10. http://bl.ocks.org/syntagmatic/3687826
11. http://www.tavfrna.incubator.apache.org/legal/resolved.html#cc-sa
12. ./apache-superset-0.32.0rc2/docs/conf.py
13. ./apache-superset-0.32.0rc2/superset/translations/messages.pot
14. ./apache-superset-0.32.0rc2/superset/assets/images/babytux.jpg
15. apache-superset
-0.32.0rc2/superset/assets/stylesheets/fonts/Roboto-Regular.woff
16. apache-superset
-0.32.0rc2/superset/assets/stylesheets/fonts/Roboto-Regular.woff2
17. apache-superset


-0.32.0rc2/superset/assets/stylesheets/fonts/glyphicons-halflings-regular.ttf

18. apache-superset


-0.32.0rc2/superset/assets/stylesheets/fonts/glyphicons-halflings-regular.woff

19. apache-s

Re: [Superset] Design interest group

[Beto Dealmeida]

Same here, I'd love to participate.

On 8/7/19 6:03 PM, Vyl Chiang wrote:

I'm definitely interested in joining. I can represent Lyft's user needs as
well as soliciting and consolidating feedback from Lyft Design as well.

Thanks!
Vyl

Vyl Chiang
Product
650.279.1185



On Tue, Aug 6, 2019 at 11:13 AM Sylvia Tomiyama
 wrote:


Hi Max! Thanks for kicking this off. I think it's a really exciting and
great thing for Superset.

I'd be happy to join in on the efforts. I can represent the user needs we
see at Airbnb, and in particular some of the challenges and needs we see
for a very mature and large deployment of Superset, as well as how Superset
interplays with other data tools in an overall data ecosystem.

--Sylvia

On Tue, Aug 6, 2019 at 10:53 AM Eli Brumbaugh
 wrote:


Hi Max,

Thank you for sharing this exciting update. I am interested in
participating on behalf of Airbnb Design.

I look forward to working with you all.

Best,
Eli

On Mon, Aug 5, 2019 at 4:54 PM Maxime Beauchemin <
maximebeauche...@gmail.com>
wrote:


Hi all,

As mentioned at the bi-weekly community meeting, the team at Preset is
planning to sponsor an engagement with design agency Cartel
 to assist the community in defining what

the

future of Superset may evolve looking like. The folks at Cartel (cced)

are

specialized in designing data-heavy, highly-interactive applications

like

Superset.

The effort will take place over September - October - November, and for
that engagement we'd like to assemble a small interest group (6-8

people)

that can help shape the direction of this effort, from across the
community. We'd like for the major contributors to be represented, and

for

representation to be roughly be based on merit accumulated so far. The
folks at Cartel told us they've had much better success working with
smaller group so we're trying to respect that.

People who want to get involved should:
* be able to commit 2H+ a week over those 3 months
* have a history of involvement in the project, merit and/or merit
representation
* a deep understanding of the product
* design sense + good UI / UX intuition
* understanding Superset use cases and users

We'd also like to be able to communicate progress throughout the

process

and offer a way for the people from the wider community to provide
feedback. One or two people in the interest group will be in charge of
communicating in and out as we move forward.

The interest group will define what areas to focus on and the

deliverables

as we engage with the agency. My personal intuition going into this is

that

we'll prefer to go wide and shallow as opposed to dig super deep into a
small set of specific area. Though we'll likely focus on core-ux

workflows

like content creation, and tying up the different pieces of Superset
together. We may explore new areas like spreasheet-type interactions,
notebooky-type interfaces and things of that nature as well. In any

case,

expect to see lots of wireframes!

We do not intend for the designs produced during this engagement to be

an

absolute for the future of Superset, but instead as an inspiration and
guiding material to build upon as we work on individual PRs.

Anyhow! Please reach out if you're interested or have feedback on the
process. We're intending to report progress on the mailing list as we

go.

Thanks,

Max



--
Eli Sebastian Brumbaugh
Pronouns: He, Him
Design Manager  |  Data Platform, Data UX & Data Design System
Indigenous@ Airfinity Group Lead

[VOTE] SIP-16 Proposal for loading additional polygon encodings

[Beto Dealmeida]

Hi, friends!

I'd like to call a vote on SIP-16 Proposal for loading additional 
polygon encodings (https://github.com/apache/incubator-superset/issues/6814)


This is a small change allowing custom polygon encodings to be defined 
by the user in the configuration, behind a feature flag. The PR 
implementing it is https://github.com/apache/incubator-superset/pull/6863.


Thanks and best regards,

--Beto

[DISCUSS] SIP-18 Scheduling queries from SQL Lab

[Beto Dealmeida]

Please discuss & subscribe here: 
https://github.com/apache/incubator-superset/issues/7425


Thanks,

Beto

[SIP-0] Vote

[Beto Dealmeida]

Hi, all.

I would like to call a vote on SIP-0, "Superset Improvement Proposals":

https://github.com/apache/incubator-superset/issues/5602

Beto