[GitHub] codecov-io commented on issue #4584: [sqllab] Added share button to bottom menu
codecov-io commented on issue #4584: [sqllab] Added share button to bottom menu URL: https://github.com/apache/incubator-superset/pull/4584#issuecomment-371746821 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=h1) Report > Merging [#4584](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b512da8002dc0dc7f6a1f5eb983606118f484d32?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4584 +/- ## == + Coverage 71.17% 71.19% +0.01% == Files 187 188 +1 Lines 1480914822 +13 Branches 1085 1085 == + Hits1054010552 +12 - Misses 4266 4267 +1 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=tree) | Coverage ? | | |---|---|---| | [...ssets/javascripts/SqlLab/components/ShareQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4584/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NoYXJlUXVlcnkuanN4) | `100% <100%> (?)` | | | [...assets/javascripts/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4584/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `74.73% <100%> (+0.26%)` | :arrow_up: | | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/4584/diff?src=pr=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `74.21% <0%> (-0.13%)` | :arrow_down: | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4584/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.18% <0%> (+0.06%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=footer). Last update [b512da8...fc0c346](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4584: [sqllab] Added share button to bottom menu
codecov-io commented on issue #4584: [sqllab] Added share button to bottom menu URL: https://github.com/apache/incubator-superset/pull/4584#issuecomment-371746821 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=h1) Report > Merging [#4584](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b512da8002dc0dc7f6a1f5eb983606118f484d32?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4584 +/- ## == + Coverage 71.17% 71.19% +0.01% == Files 187 188 +1 Lines 1480914822 +13 Branches 1085 1085 == + Hits1054010552 +12 - Misses 4266 4267 +1 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=tree) | Coverage ? | | |---|---|---| | [...ssets/javascripts/SqlLab/components/ShareQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4584/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NoYXJlUXVlcnkuanN4) | `100% <100%> (?)` | | | [...assets/javascripts/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4584/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `74.73% <100%> (+0.26%)` | :arrow_up: | | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/4584/diff?src=pr=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `74.21% <0%> (-0.13%)` | :arrow_down: | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4584/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.18% <0%> (+0.06%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=footer). Last update [b512da8...fc0c346](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4584: [sqllab] Added share button to bottom menu
codecov-io commented on issue #4584: [sqllab] Added share button to bottom menu URL: https://github.com/apache/incubator-superset/pull/4584#issuecomment-371746821 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=h1) Report > Merging [#4584](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b512da8002dc0dc7f6a1f5eb983606118f484d32?src=pr=desc) will **increase** coverage by `0.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4584 +/- ## == + Coverage 71.17% 71.19% +0.01% == Files 187 188 +1 Lines 1480914818 +9 Branches 1085 1085 == + Hits1054010549 +9 Misses 4266 4266 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=tree) | Coverage ? | | |---|---|---| | [...ssets/javascripts/SqlLab/components/ShareQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4584/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NoYXJlUXVlcnkuanN4) | `100% <100%> (?)` | | | [...assets/javascripts/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4584/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `74.73% <100%> (+0.26%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=footer). Last update [b512da8...d4f35d2](https://codecov.io/gh/apache/incubator-superset/pull/4584?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
