[GitHub] fabianmenges commented on issue #3512: Feature: Making data gaps visible in line charts by inserting zeros

2017-09-22 Thread git
fabianmenges commented on issue #3512: Feature: Making data gaps visible in 
line charts by inserting zeros
URL: 
https://github.com/apache/incubator-superset/pull/3512#issuecomment-331530901
 
 
   K, I'll take care of this and bring it down to the server side, should be 
able to get something going by end of next week.
   
   We probably need to have a function to translate the time grains to pandas 
frequencies (like the one I wrote in JS to ms) because we also need to cover 
Druid and the granularities for Druid are handled completely independent. Even 
better would probably be to unify the concept of `druid granularity`/`pandas 
frequencies (offset-aliases)`/`sql time grain` because they are all used almost 
interchangeably within superset.
   
   Apart from that I don't think that my function would have problems with time 
zones since it just looks at raw milliseconds since epoch...
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] fabianmenges commented on issue #3512: Feature: Making data gaps visible in line charts by inserting zeros

2017-09-21 Thread git
fabianmenges commented on issue #3512: Feature: Making data gaps visible in 
line charts by inserting zeros
URL: 
https://github.com/apache/incubator-superset/pull/3512#issuecomment-331288385
 
 
   If you think it makes more sense to enhance resampling on the server side 
(e.g. support the various period types, derive it from the time grain) I'm  
happy to improve that experience instead.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services