graceguo-supercat commented on issue #4833: [sqllab] Help sqllab forget query history URL: https://github.com/apache/incubator-superset/pull/4833#issuecomment-385783066 current auto query refresh component work like this: - in client-side, from all queries in local storage, it find out - status in `'running', 'started', 'pending', 'fetching'`, and - started in < 6 hours - if has any queries, polling with latest updated timestamp - if there is no such queries, stop polling. - in server-side, for every poll request, we get all queries - by user_id, and - changed after updated timestamp - if some query went wrong, and query status kept as `running` but never got to updated after 6 hours, when client-side polling with a newer timestamp (< 6 hours), this query will not have a chance to be set as `timeout` state. But it won't cause client-side keep polling because now client-side added timeout threshold. this PR LGTM. but will not merge until @mistercrunch feel comfortable. Thank you!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
