[GitHub] jeffreythewang commented on issue #4740: Add extraction function support for Druid queries
jeffreythewang commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-386061964 My bad, I thought you were attaching `extractionFn`s to `DimensionSpec`s as well like in [this](http://druid.io/docs/latest/querying/dimensionspecs.html#extraction-functions) way, but I realized you are building the `Filter`s from `DimensionSpec`s that already have `extractionFn`s defined. I assume you have users (or someone else) define their own `extractionFn`s in the datasource configuration? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jeffreythewang commented on issue #4740: Add extraction function support for Druid queries
jeffreythewang commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-386061964 My bad, I thought you were attaching `extractionFn`s to `DimensionSpec`s as well like in [this](http://druid.io/docs/latest/querying/dimensionspecs.html#extraction-functions) way, but it seems like you are building the `Filter`s from `DimensionSpec`s that already have `extractionFn`s defined. I assume you have users (or someone else) define their own `extractionFn`s in the datasource configuration? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jeffreythewang commented on issue #4740: Add extraction function support for Druid queries
jeffreythewang commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-385596164 We currently don't use extraction functions either. This may have already been answered, but I'm curious why you didn't use the pydruid [`DimensionSpec`](https://github.com/druid-io/pydruid/blob/master/pydruid/utils/dimensions.py#L8) builder? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
