[GitHub] michellethomas commented on issue #4649: Use one library for table components

2018-03-27 Thread GitBox
michellethomas commented on issue #4649: Use one library for table components
URL: 
https://github.com/apache/incubator-superset/issues/4649#issuecomment-376692253
 
 
   We have users adding tables with large amounts of data to dashboards (that 
then freeze or slow down the dashboard), I'm hoping we see some performance 
improvements moving to `react-virtualized`, but if I can't get it to work I'll 
use reactable.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] michellethomas commented on issue #4649: Use one library for table components

2018-03-26 Thread GitBox
michellethomas commented on issue #4649: Use one library for table components
URL: 
https://github.com/apache/incubator-superset/issues/4649#issuecomment-376344407
 
 
   After talking with Chris a bit more about this, for now I think we are just 
going to use `react-virtualized` until there's a clear need to use something 
within `data-ui/data-table`.
   
   I'm going to start by moving the Table viz over to react-virtualized.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] michellethomas commented on issue #4649: Use one library for table components

2018-03-20 Thread GitBox
michellethomas commented on issue #4649: Use one library for table components
URL: 
https://github.com/apache/incubator-superset/issues/4649#issuecomment-374683340
 
 
   Thanks for the information Max. This is super useful.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services