mistercrunch closed pull request #4908: Replace NaN/Infinity with null
URL: https://github.com/apache/incubator-superset/pull/4908
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/views/core.py b/superset/views/core.py
index 2e01e99b3a..a79ff2b4da 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -6,7 +6,6 @@
from __future__ import unicode_literals
from datetime import datetime, timedelta
-import json
import logging
import os
import re
@@ -24,6 +23,7 @@
from flask_babel import gettext as __
from flask_babel import lazy_gettext as _
import pandas as pd
+import simplejson as json
from six import text_type
import sqlalchemy as sqla
from sqlalchemy import create_engine
@@ -2327,7 +2327,8 @@ def results(self, key):
payload_json = json.loads(payload)
payload_json['data'] = payload_json['data'][:display_limit]
return json_success(
- json.dumps(payload_json, default=utils.json_iso_dttm_ser))
+ json.dumps(
+ payload_json, default=utils.json_iso_dttm_ser,
ignore_nan=True))
@has_access_api
@expose('/stop_query/', methods=['POST'])
@@ -2435,7 +2436,7 @@ def sql_json(self):
resp = json_success(json.dumps(
{'query': query.to_dict()}, default=utils.json_int_dttm_ser,
- allow_nan=False), status=202)
+ ignore_nan=True), status=202)
session.commit()
return resp
@@ -2453,7 +2454,7 @@ def sql_json(self):
rendered_query,
return_results=True)
payload = json.dumps(
- data, default=utils.pessimistic_json_iso_dttm_ser)
+ data, default=utils.pessimistic_json_iso_dttm_ser,
ignore_nan=True)
except Exception as e:
logging.exception(e)
return json_error_response('{}'.format(e))
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
