[GitHub] mistercrunch commented on issue #4819: Visualization for multiple line charts
mistercrunch commented on issue #4819: Visualization for multiple line charts URL: https://github.com/apache/incubator-superset/pull/4819#issuecomment-385708415 Cool, please fix merge conflicts, as this looks like it's ready to be merged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4819: Visualization for multiple line charts
mistercrunch commented on issue #4819: Visualization for multiple line charts URL: https://github.com/apache/incubator-superset/pull/4819#issuecomment-383677102 Let's talk about what to do around filters, it may be easy to pass them as `extra_filters` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4819: Visualization for multiple line charts
mistercrunch commented on issue #4819: Visualization for multiple line charts URL: https://github.com/apache/incubator-superset/pull/4819#issuecomment-382830493 Build is failing :( Oh also it could be nice to add an example in `data/__init__.py` this will automatically add test coverage in `viz.py` as all examples get unit tested. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4819: Visualization for multiple line charts
mistercrunch commented on issue #4819: Visualization for multiple line charts URL: https://github.com/apache/incubator-superset/pull/4819#issuecomment-381023994 Neat. I wonder if there is an easy way to align the ticks on both Y axes so they line up. Not a big deal but all those grey lines look a bit chaotic. If you Google image search “dual axis chart” you can see most tools out there align the ticks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4819: Visualization for multiple line charts
mistercrunch commented on issue #4819: Visualization for multiple line charts URL: https://github.com/apache/incubator-superset/pull/4819#issuecomment-381023994 Neat. I wonder if there is an easy way to align the ticks on both Y axes so they line up. Not a big deal but all those grey lines look a bit chaotic. If you Google image search “dual axis chart” you’ll most tools out there align the ticks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
