[GitHub] williaster commented on issue #4910: Use React.PureComponent everywhere
williaster commented on issue #4910: Use React.PureComponent everywhere URL: https://github.com/apache/incubator-superset/pull/4910#issuecomment-385608926 I would not pursue this, [from Dan Abranov ]( https://twitter.com/dan_abramov/status/75938353012011008) (on React team, creator of redux): > Don‘t use PureComponent everywhere. Measure. On that Twitter thread he notes that equality checks for every `prop` for every component (which is what happens when you use `PureComponent`) is not necessarily cheap, and it can actually slow down your app in some cases. This is what I've been told as well, you should only start doing this when you measure something (with dev tools) and know something expensive is happening. Or do some explicit measuring in this PR and only update significant improvements you see. https://user-images.githubusercontent.com/4496521/39463701-2db7b4f2-4cce-11e8-80e6-f6b784dddac0.png; width="400" /> This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on issue #4910: Use React.PureComponent everywhere
williaster commented on issue #4910: Use React.PureComponent everywhere URL: https://github.com/apache/incubator-superset/pull/4910#issuecomment-385608926 I would not pursue this, [from Dan Abranov ]( https://twitter.com/dan_abramov/status/75938353012011008) (on React team, creator of redux): > Don‘t use PureComponent everywhere. Measure. On that Twitter thread he notes that equality checks for every `prop` for every component (which is what happens when you use `PureComponent`) is not necessarily cheap, and it can actually slow down your app in some cases. This is what I've been told as well, you should only start doing this when you measure something (with dev tools) and know something expensive is happening. Or do some explicit measuring in this PR and only update significant improvements you see. https://user-images.githubusercontent.com/4496521/39463701-2db7b4f2-4cce-11e8-80e6-f6b784dddac0.png This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on issue #4910: Use React.PureComponent everywhere
williaster commented on issue #4910: Use React.PureComponent everywhere URL: https://github.com/apache/incubator-superset/pull/4910#issuecomment-385608926 I would not pursue this, [from Dan Abranov ]( https://twitter.com/dan_abramov/status/75938353012011008) (on React team, creator of redux): > Don‘t use PureComponent everywhere. Measure. On that Twitter thread he notes that equality checks for every `prop` for every component (which is what happens when you use `PureComponent`) is not necessarily cheap, and it can actually slow down your app in some cases. This is what I've been told as well, you should only start doing this when you measure something (with dev tools) and know something expensive is happening. Or do some explicit measuring in this PR and see what's improving significantly. https://user-images.githubusercontent.com/4496521/39463701-2db7b4f2-4cce-11e8-80e6-f6b784dddac0.png This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on issue #4910: Use React.PureComponent everywhere
williaster commented on issue #4910: Use React.PureComponent everywhere URL: https://github.com/apache/incubator-superset/pull/4910#issuecomment-385608926 I would not pursue this, [from Dan Abranov ]( https://twitter.com/dan_abramov/status/75938353012011008) (on React team, creator of redux): > Don‘t use PureComponent everywhere. Measure. https://user-images.githubusercontent.com/4496521/39463701-2db7b4f2-4cce-11e8-80e6-f6b784dddac0.png; width="350" /> On that Twitter thread he notes that equality checks for every `prop` for every component (which is what happens when you use `PureComponent`) is not necessarily cheap, and it can actually slow down your app in some cases. This is what I've been told as well, you should only start doing this when you measure something (with dev tools) and know something expensive is happening. Or do some explicit measuring in this PR and see what's improving significantly. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
