[GitHub] SanjayJosh commented on issue #1870: Unable to construct SQLAlchemy URI for Teradata which can read and load Cover views
SanjayJosh commented on issue #1870: Unable to construct SQLAlchemy URI for
Teradata which can read and load Cover views
URL:
https://github.com/apache/incubator-superset/issues/1870#issuecomment-381500446
I did do pip install sqlalchemy-teradata , and then restart superset.
However, on giving this URI:
`teradata://UID:PWD@Servername:22/View_Schema_name?authentication=LDAP` in
superset , I get
`ERROR: {"error": "Connection failed!\n\nThe error message returned
was:\nCan't load plugin: sqlalchemy.dialects:teradata"}`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] SanjayJosh commented on issue #1870: Unable to construct SQLAlchemy URI for Teradata which can read and load Cover views
SanjayJosh commented on issue #1870: Unable to construct SQLAlchemy URI for
Teradata which can read and load Cover views
URL:
https://github.com/apache/incubator-superset/issues/1870#issuecomment-381500446
I did do pip install sqlalchemy-teradata , and then restart superset.
However, on giving this
URI:
`teradata://UID:PWD@Servername:22/View_Schema_name?authentication=LDAP` in
superset , I get
`ERROR: {"error": "Connection failed!\n\nThe error message returned
was:\nCan't load plugin: sqlalchemy.dialects:teradata"}`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] SanjayJosh commented on issue #1870: Unable to construct SQLAlchemy URI for Teradata which can read and load Cover views
SanjayJosh commented on issue #1870: Unable to construct SQLAlchemy URI for
Teradata which can read and load Cover views
URL:
https://github.com/apache/incubator-superset/issues/1870#issuecomment-381500446
I did do pip install sqlalchemy-teradata , and then restart superset.
However, on giving this
URI:
`teradata://UID:PWD@Servername:22/View_Schema_name?authentication=LDAP` in
superset , I get
`ERROR: {"error": "Connection failed!\n\nThe error message returned
was:\nCan't load plugin: sqlalchemy.dialects:teradata"}`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rhunwicks closed pull request #3492: PandasConnector
rhunwicks closed pull request #3492: PandasConnector
URL: https://github.com/apache/incubator-superset/pull/3492
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/contrib/__init__.py b/contrib/__init__.py
new file mode 100644
index 00..e69de29bb2
diff --git a/contrib/cache/__init__.py b/contrib/cache/__init__.py
new file mode 100644
index 00..e69de29bb2
diff --git a/contrib/cache/dataframe.py b/contrib/cache/dataframe.py
new file mode 100644
index 00..4d4014b824
--- /dev/null
+++ b/contrib/cache/dataframe.py
@@ -0,0 +1,195 @@
+from __future__ import absolute_import
+from __future__ import division
+from __future__ import print_function
+from __future__ import unicode_literals
+
+from io import open
+import json
+import os
+import tempfile
+from time import time
+try:
+import cPickle as pickle
+except ImportError: # pragma: no cover
+import pickle
+
+import pandas as pd
+from six import u
+from werkzeug.contrib.cache import FileSystemCache
+
+
+class DataFrameCache(FileSystemCache):
+"""
+A cache that stores Pandas DataFrames on the file system.
+
+DataFrames are stored in Feather Format - a fast on-disk representation
+of the Apache Arrow in-memory format to eliminate serialization
+overhead.
+
+This cache depends on being the only user of the `cache_dir`. Make
+absolutely sure that nobody but this cache stores files there or
+otherwise the cache will randomly delete files therein.
+
+:param cache_dir: the directory where cache files are stored.
+:param threshold: the maximum number of items the cache stores before
+ it starts deleting some.
+:param default_timeout: the default timeout that is used if no timeout is
+specified on :meth:`~BaseCache.set`. A timeout of
+0 indicates that the cache never expires.
+:param mode: the file mode wanted for the cache files, default 0600
+"""
+
+_fs_cache_suffix = '.cached'
+_fs_metadata_suffix = '.metadata'
+
+def _list_dir(self):
+"""return a list of (fully qualified) cache filenames
+"""
+return [os.path.join(self._path, fn) for fn in os.listdir(self._path)
+if fn.endswith(self._fs_cache_suffix)]
+
+def _prune(self):
+entries = self._list_dir()
+if len(entries) > self._threshold:
+now = time()
+for idx, cname in enumerate(entries):
+mname = os.path.splitext(cname)[0] + self._fs_metadata_suffix
+try:
+with open(mname, 'r', encoding='utf-8') as f:
+metadata = json.load(f)
+except (IOError, OSError):
+metadata = {'expires': -1}
+try:
+remove = ((metadata['expires'] != 0 and
metadata['expires'] <= now)
+ or idx % 3 == 0)
+if remove:
+os.remove(cname)
+os.remove(mname)
+except (IOError, OSError):
+pass
+
+def clear(self):
+for cname in self._list_dir():
+try:
+mname = os.path.splitext(cname)[0] + self._fs_metadata_suffix
+os.remove(cname)
+os.remove(mname)
+except (IOError, OSError):
+return False
+return True
+
+def get(self, key):
+filename = self._get_filename(key)
+cname = filename + self._fs_cache_suffix
+mname = filename + self._fs_metadata_suffix
+try:
+with open(mname, 'r', encoding='utf-8') as f:
+metadata = json.load(f)
+except (IOError, OSError):
+metadata = {'expires': -1}
+try:
+with open(cname, 'rb') as f:
+if metadata['expires'] == 0 or metadata['expires'] > time():
+read_method = getattr(pd,
'read_{}'.format(metadata['format']))
+read_args = metadata.get('read_args', {})
+if metadata['format'] == 'hdf':
+return read_method(f.name, **read_args)
+else:
+return read_method(f, **read_args)
+else:
+os.remove(cname)
+os.remove(mname)
+return None
+except (IOError, OSError):
+return None
+
+def add(self, key, value, timeout=None):
+filename = self._get_filename(key) + self._fs_cache_suffix
+if not os.path.exists(filename):
+return self.set(key, value, timeout)
+return False
+
+def set(self, key, value, timeout
[GitHub] rhunwicks commented on issue #3492: PandasConnector
rhunwicks commented on issue #3492: PandasConnector URL: https://github.com/apache/incubator-superset/pull/3492#issuecomment-381541387 Having the migrations and requirements mixed in with the main Superset ones without ever merging this MR causes frequent merge conflicts. Therefore, I am going to close this MR. We will continue to maintain the connector in order to allow us to use Superset with APIs and remote files, but we will do so in our fork rather than a MR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhunwicks commented on issue #3302: Create a PandasDatasource
rhunwicks commented on issue #3302: Create a PandasDatasource URL: https://github.com/apache/incubator-superset/issues/3302#issuecomment-381543161 Having the migrations and requirements mixed in with the main Superset ones without ever merging this MR causes frequent merge conflicts. Therefore, I have closed MR #3492. We will continue to maintain the connector in order to allow us to use Superset with APIs and remote files, but we will do so in [our fork](https://github.com/kimetrica/superset/tree/kimetrica) rather than a MR. If Superset publishes a specification for developing third party connectors in future then we will repackage our connector according to the specification. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] claycrosby commented on issue #4366: Add filters to dashboard in single slice without filter box view - interactive filters
claycrosby commented on issue #4366: Add filters to dashboard in single slice without filter box view - interactive filters URL: https://github.com/apache/incubator-superset/issues/4366#issuecomment-381558954 +1 would like to embed filters within individual slices This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] daniel5001 commented on issue #4725: [WIP] Add "Published" feature to dashboards
daniel5001 commented on issue #4725: [WIP] Add "Published" feature to dashboards URL: https://github.com/apache/incubator-superset/pull/4725#issuecomment-381639525 Hey guys, Any update on this merge? Would love to be able to roll this feature out. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] betodealmeida commented on issue #4821: Fix time granularity-related issues
betodealmeida commented on issue #4821: Fix time granularity-related issues URL: https://github.com/apache/incubator-superset/pull/4821#issuecomment-381677303 Taking a look — thanks for fixing this! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa commented on issue #4829: [import csv] ensure directory exists before saving csv file
timifasubaa commented on issue #4829: [import csv] ensure directory exists before saving csv file URL: https://github.com/apache/incubator-superset/pull/4829#issuecomment-381704752 @john-bodley Done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SpyderRivera commented on issue #4725: [WIP] Add "Published" feature to dashboards
SpyderRivera commented on issue #4725: [WIP] Add "Published" feature to dashboards URL: https://github.com/apache/incubator-superset/pull/4725#issuecomment-381709077 I completely agree "Releasing the feature: Perhaps it'd be fine to just have a script that sets all dashboards to published since this wouldn't affect the system at all and then people would just be able to modify it from then on? " This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] betodealmeida commented on issue #4819: Visualization for multiple line charts
betodealmeida commented on issue #4819: Visualization for multiple line charts URL: https://github.com/apache/incubator-superset/pull/4819#issuecomment-381724475 https://user-images.githubusercontent.com/1534870/38831144-595c318e-4173-11e8-8f45-dc63ad6852b1.png";> This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa opened a new pull request #4833: [sqllab] Help sqllab forget query history
timifasubaa opened a new pull request #4833: [sqllab] Help sqllab forget query history URL: https://github.com/apache/incubator-superset/pull/4833 In the sqllab asynchronous polling logic, it looks through the query history and continues to poll if there is a query in the history that is not successful. This PR makes it look only at the last 6 hours of queries when checking for their states. The rationale is that a query that was started 6 hours ago is probably dead or problematic and should be rerun. Also, if for some reason a query in the history is in a bad state and remains non successful, superset will continue to poll. @graceguo-supercat @mistercrunch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
SLA in DAGs
Hi Devs, Is there any way to define DAG SLAs based on runtime rather than execution_time? I've multiple scenarios where I have to backfill my data and we get tons of SLA alerts. Ideally, I would like to monitor actual DAG run from start of runtime to end of DAG. Thanks, -Y
[GitHub] timifasubaa opened a new pull request #4834: [WIP] Load async sql lab early for Presto
timifasubaa opened a new pull request #4834: [WIP] Load async sql lab early for Presto URL: https://github.com/apache/incubator-superset/pull/4834 This PR enables sqllab to load queries early after the first 1K rows are available from Presto. When the query is loaded early, the user can immediately visualize if that was the intention. But the user must wait till the end if they want to upload CSV or see the rest of the results. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley opened a new pull request #4835: [setup] Dropping 3.4 and adding 3.6
john-bodley opened a new pull request #4835: [setup] Dropping 3.4 and adding 3.6 URL: https://github.com/apache/incubator-superset/pull/4835 Since `0.21.0` Pandas has dropped support for Python 3.4 which is now causing problems with Travis CI. I speculate the issue is only now surfacing with the release of `pip` version `10.0` per [this](https://github.com/pandas-dev/pandas/issues/20697) thread. It seems other applications are dropping support for Python 3.4 and I was wondering whether we should do the same (and adding Python 3.6 as a replacement). to: @fabianmenges @mistercrunch cc: @timifasubaa This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hughhhh opened a new pull request #4836: Refactoring on exploreReducer
hug opened a new pull request #4836: Refactoring on exploreReducer URL: https://github.com/apache/incubator-superset/pull/4836 Changed return statement to have es6 syntax insteas of `Object.assign()` function call @betodealmeida @mistercrunch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4835: [setup] Dropping 3.4 and adding 3.6
codecov-io commented on issue #4835: [setup] Dropping 3.4 and adding 3.6 URL: https://github.com/apache/incubator-superset/pull/4835#issuecomment-381867249 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4835?src=pr&el=h1) Report > Merging [#4835](https://codecov.io/gh/apache/incubator-superset/pull/4835?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2900ca345da969e0a146591c8108d92451b37e24?src=pr&el=desc) will **decrease** coverage by `5.47%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4835?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#4835 +/- ## == - Coverage 72.36% 66.89% -5.48% == Files 208 164 -44 Lines 15662 7164-8498 Branches 1227 1227 == - Hits11334 4792-6542 + Misses 4325 2369-1956 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4835?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/4835/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | | | | [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4835/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | | | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4835/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | | | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4835/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | | | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4835/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | | | | [superset/security.py](https://codecov.io/gh/apache/incubator-superset/pull/4835/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkucHk=) | | | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4835/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | | | | [superset/stats\_logger.py](https://codecov.io/gh/apache/incubator-superset/pull/4835/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3RhdHNfbG9nZ2VyLnB5) | | | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4835/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | | | | [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/4835/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | | | | ... and [33 more](https://codecov.io/gh/apache/incubator-superset/pull/4835/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4835?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4835?src=pr&el=footer). Last update [2900ca3...42434a2](https://codecov.io/gh/apache/incubator-superset/pull/4835?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4835: [setup] Dropping 3.4 and adding 3.6
codecov-io commented on issue #4835: [setup] Dropping 3.4 and adding 3.6 URL: https://github.com/apache/incubator-superset/pull/4835#issuecomment-381867249 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4835?src=pr&el=h1) Report > Merging [#4835](https://codecov.io/gh/apache/incubator-superset/pull/4835?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2900ca345da969e0a146591c8108d92451b37e24?src=pr&el=desc) will **not change** coverage. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4835?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#4835 +/- ## === Coverage 72.36% 72.36% === Files 208 208 Lines 1566215662 Branches 1227 1227 === Hits1133411334 Misses 4325 4325 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4835?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/4835/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `44.06% <0%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4835?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4835?src=pr&el=footer). Last update [2900ca3...42434a2](https://codecov.io/gh/apache/incubator-superset/pull/4835?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4835: [setup] Dropping 3.4 and adding 3.6
codecov-io commented on issue #4835: [setup] Dropping 3.4 and adding 3.6 URL: https://github.com/apache/incubator-superset/pull/4835#issuecomment-381867249 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4835?src=pr&el=h1) Report > Merging [#4835](https://codecov.io/gh/apache/incubator-superset/pull/4835?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2900ca345da969e0a146591c8108d92451b37e24?src=pr&el=desc) will **not change** coverage. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4835?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#4835 +/- ## === Coverage 72.36% 72.36% === Files 208 208 Lines 1566215662 Branches 1227 1227 === Hits1133411334 Misses 4325 4325 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4835?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/4835/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `44.06% <0%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4835?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4835?src=pr&el=footer). Last update [2900ca3...42434a2](https://codecov.io/gh/apache/incubator-superset/pull/4835?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
