Re: Improving how Target Endpoint is Associated with Message Forwarding Processor

[Isuru Udana]

Thanks Shafreen. I reviewed it and suggested a few minor modifications.

On Sun, Nov 1, 2020 at 11:42 AM Shafreen  wrote:

> Hi All,
>
> Please find the below PR for this improvement.
>
> https://github.com/apache/synapse/pull/50
>
> I will send another PR updating the doc once this is merged.
>
> On Sat, Oct 17, 2020 at 9:27 AM Vanjikumaran Sivajothy <
> vanjikuma...@gmail.com> wrote:
>
>> I agree with your suggestion; it is much better clean design approach.
>>
>>
>> On Fri, Oct 16, 2020 at 8:34 PM Shafreen 
>> wrote:
>>
>>> Hi All,
>>>
>>> Any opinion on this?
>>>
>>> On Sun, Oct 11, 2020 at 11:45 AM Shafreen 
>>> wrote:
>>>
 Hi All,

 Each Message Forwarding Processor must have a target endpoint. At the
 moment we configure this target endpoint by adding a property in the
 in-sequence of proxy service as follows.

 

 IMO, this way of associating target-endpoint with Message Forwarding
 Processor is not only error prone but also less readable. Therefore, I
 think we can improve configuring target endpoint by making it at an
 attribute of the Message Forwarding Processor as follows,

 >>> "org.apache.synapse.message.processors.forward.ScheduledMessageForwardingProcessor"
 name="ScheduledProcessor" messageStore="MyStore"
 *targetEndpoint="StockQuoteServiceEp"*> 
 1 3
 true 

 WDYT ?

>>> --
>> Sent from Gmail Mobile
>>
>

-- 
*Isuru Udana*
Associate Director/Architect



*; WSO2 Inc.; http://wso2.com email: isud...@gmail.com
 *

Re: Improving how Target Endpoint is Associated with Message Forwarding Processor

[Shafreen]

Hi All,

Please find the below PR for this improvement.

https://github.com/apache/synapse/pull/50

I will send another PR updating the doc once this is merged.

On Sat, Oct 17, 2020 at 9:27 AM Vanjikumaran Sivajothy <
vanjikuma...@gmail.com> wrote:

> I agree with your suggestion; it is much better clean design approach.
>
>
> On Fri, Oct 16, 2020 at 8:34 PM Shafreen  wrote:
>
>> Hi All,
>>
>> Any opinion on this?
>>
>> On Sun, Oct 11, 2020 at 11:45 AM Shafreen 
>> wrote:
>>
>>> Hi All,
>>>
>>> Each Message Forwarding Processor must have a target endpoint. At the
>>> moment we configure this target endpoint by adding a property in the
>>> in-sequence of proxy service as follows.
>>>
>>> 
>>>
>>> IMO, this way of associating target-endpoint with Message Forwarding
>>> Processor is not only error prone but also less readable. Therefore, I
>>> think we can improve configuring target endpoint by making it at an
>>> attribute of the Message Forwarding Processor as follows,
>>>
>>> >> "org.apache.synapse.message.processors.forward.ScheduledMessageForwardingProcessor"
>>> name="ScheduledProcessor" messageStore="MyStore"
>>> *targetEndpoint="StockQuoteServiceEp"*> 1
>>>  3 <
>>> parameter name="max.deliver.drop">true 
>>>
>>> WDYT ?
>>>
>> --
> Sent from Gmail Mobile
>