[GitHub] [synapse] isudana merged pull request #50: Improving how Target Endpoint is Associated with Message Forwarding Processor

[GitBox]

isudana merged pull request #50:
URL: https://github.com/apache/synapse/pull/50


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org
For additional commands, e-mail: dev-h...@synapse.apache.org

Re: Improving how Target Endpoint is Associated with Message Forwarding Processor

[Shafreen]

Hi Isuru,

I have updated PR as per the comments.

On Mon, Nov 2, 2020 at 9:07 PM Shafreen  wrote:

> Thanks. Will update the PR accordingly.
>
> On Mon, Nov 2, 2020 at 7:53 AM Isuru Udana  wrote:
>
>> Thanks Shafreen. I reviewed it and suggested a few minor modifications.
>>
>> On Sun, Nov 1, 2020 at 11:42 AM Shafreen 
>> wrote:
>>
>>> Hi All,
>>>
>>> Please find the below PR for this improvement.
>>>
>>> https://github.com/apache/synapse/pull/50
>>>
>>> I will send another PR updating the doc once this is merged.
>>>
>>> On Sat, Oct 17, 2020 at 9:27 AM Vanjikumaran Sivajothy <
>>> vanjikuma...@gmail.com> wrote:
>>>
 I agree with your suggestion; it is much better clean design approach.


 On Fri, Oct 16, 2020 at 8:34 PM Shafreen 
 wrote:

> Hi All,
>
> Any opinion on this?
>
> On Sun, Oct 11, 2020 at 11:45 AM Shafreen 
> wrote:
>
>> Hi All,
>>
>> Each Message Forwarding Processor must have a target endpoint. At the
>> moment we configure this target endpoint by adding a property in the
>> in-sequence of proxy service as follows.
>>
>> 
>>
>> IMO, this way of associating target-endpoint with Message Forwarding
>> Processor is not only error prone but also less readable. Therefore, I
>> think we can improve configuring target endpoint by making it at an
>> attribute of the Message Forwarding Processor as follows,
>>
>> > "org.apache.synapse.message.processors.forward.ScheduledMessageForwardingProcessor"
>> name="ScheduledProcessor" messageStore="MyStore"
>> *targetEndpoint="StockQuoteServiceEp"*> 
>> 1 3> > true > messageProcessor>
>>
>> WDYT ?
>>
> --
 Sent from Gmail Mobile

>>>
>>
>> --
>> *Isuru Udana*
>> Associate Director/Architect
>>
>>
>>
>> *; WSO2 Inc.; http://wso2.com email: isud...@gmail.com
>>  *
>>
>>
>>

Re: Improving how Target Endpoint is Associated with Message Forwarding Processor

[Shafreen]

Thanks. Will update the PR accordingly.

On Mon, Nov 2, 2020 at 7:53 AM Isuru Udana  wrote:

> Thanks Shafreen. I reviewed it and suggested a few minor modifications.
>
> On Sun, Nov 1, 2020 at 11:42 AM Shafreen  wrote:
>
>> Hi All,
>>
>> Please find the below PR for this improvement.
>>
>> https://github.com/apache/synapse/pull/50
>>
>> I will send another PR updating the doc once this is merged.
>>
>> On Sat, Oct 17, 2020 at 9:27 AM Vanjikumaran Sivajothy <
>> vanjikuma...@gmail.com> wrote:
>>
>>> I agree with your suggestion; it is much better clean design approach.
>>>
>>>
>>> On Fri, Oct 16, 2020 at 8:34 PM Shafreen 
>>> wrote:
>>>
 Hi All,

 Any opinion on this?

 On Sun, Oct 11, 2020 at 11:45 AM Shafreen 
 wrote:

> Hi All,
>
> Each Message Forwarding Processor must have a target endpoint. At the
> moment we configure this target endpoint by adding a property in the
> in-sequence of proxy service as follows.
>
> 
>
> IMO, this way of associating target-endpoint with Message Forwarding
> Processor is not only error prone but also less readable. Therefore, I
> think we can improve configuring target endpoint by making it at an
> attribute of the Message Forwarding Processor as follows,
>
>  "org.apache.synapse.message.processors.forward.ScheduledMessageForwardingProcessor"
> name="ScheduledProcessor" messageStore="MyStore"
> *targetEndpoint="StockQuoteServiceEp"*> 
> 1 3
> true  >
>
> WDYT ?
>
 --
>>> Sent from Gmail Mobile
>>>
>>
>
> --
> *Isuru Udana*
> Associate Director/Architect
>
>
>
> *; WSO2 Inc.; http://wso2.com email: isud...@gmail.com
>  *
>
>
>

Re: Improving how Target Endpoint is Associated with Message Forwarding Processor

[Isuru Udana]

Thanks Shafreen. I reviewed it and suggested a few minor modifications.

On Sun, Nov 1, 2020 at 11:42 AM Shafreen  wrote:

> Hi All,
>
> Please find the below PR for this improvement.
>
> https://github.com/apache/synapse/pull/50
>
> I will send another PR updating the doc once this is merged.
>
> On Sat, Oct 17, 2020 at 9:27 AM Vanjikumaran Sivajothy <
> vanjikuma...@gmail.com> wrote:
>
>> I agree with your suggestion; it is much better clean design approach.
>>
>>
>> On Fri, Oct 16, 2020 at 8:34 PM Shafreen 
>> wrote:
>>
>>> Hi All,
>>>
>>> Any opinion on this?
>>>
>>> On Sun, Oct 11, 2020 at 11:45 AM Shafreen 
>>> wrote:
>>>
 Hi All,

 Each Message Forwarding Processor must have a target endpoint. At the
 moment we configure this target endpoint by adding a property in the
 in-sequence of proxy service as follows.

 

 IMO, this way of associating target-endpoint with Message Forwarding
 Processor is not only error prone but also less readable. Therefore, I
 think we can improve configuring target endpoint by making it at an
 attribute of the Message Forwarding Processor as follows,

 >>> "org.apache.synapse.message.processors.forward.ScheduledMessageForwardingProcessor"
 name="ScheduledProcessor" messageStore="MyStore"
 *targetEndpoint="StockQuoteServiceEp"*> 
 1 3
 true 

 WDYT ?

>>> --
>> Sent from Gmail Mobile
>>
>

-- 
*Isuru Udana*
Associate Director/Architect



*; WSO2 Inc.; http://wso2.com email: isud...@gmail.com
 *

Re: Improving how Target Endpoint is Associated with Message Forwarding Processor

[Shafreen]

Hi All,

Please find the below PR for this improvement.

https://github.com/apache/synapse/pull/50

I will send another PR updating the doc once this is merged.

On Sat, Oct 17, 2020 at 9:27 AM Vanjikumaran Sivajothy <
vanjikuma...@gmail.com> wrote:

> I agree with your suggestion; it is much better clean design approach.
>
>
> On Fri, Oct 16, 2020 at 8:34 PM Shafreen  wrote:
>
>> Hi All,
>>
>> Any opinion on this?
>>
>> On Sun, Oct 11, 2020 at 11:45 AM Shafreen 
>> wrote:
>>
>>> Hi All,
>>>
>>> Each Message Forwarding Processor must have a target endpoint. At the
>>> moment we configure this target endpoint by adding a property in the
>>> in-sequence of proxy service as follows.
>>>
>>> 
>>>
>>> IMO, this way of associating target-endpoint with Message Forwarding
>>> Processor is not only error prone but also less readable. Therefore, I
>>> think we can improve configuring target endpoint by making it at an
>>> attribute of the Message Forwarding Processor as follows,
>>>
>>> >> "org.apache.synapse.message.processors.forward.ScheduledMessageForwardingProcessor"
>>> name="ScheduledProcessor" messageStore="MyStore"
>>> *targetEndpoint="StockQuoteServiceEp"*> 1
>>>  3 <
>>> parameter name="max.deliver.drop">true 
>>>
>>> WDYT ?
>>>
>> --
> Sent from Gmail Mobile
>

Re: Improving how Target Endpoint is Associated with Message Forwarding Processor

[Vanjikumaran Sivajothy]

I agree with your suggestion; it is much better clean design approach.


On Fri, Oct 16, 2020 at 8:34 PM Shafreen  wrote:

> Hi All,
>
> Any opinion on this?
>
> On Sun, Oct 11, 2020 at 11:45 AM Shafreen 
> wrote:
>
>> Hi All,
>>
>> Each Message Forwarding Processor must have a target endpoint. At the
>> moment we configure this target endpoint by adding a property in the
>> in-sequence of proxy service as follows.
>>
>> 
>>
>> IMO, this way of associating target-endpoint with Message Forwarding
>> Processor is not only error prone but also less readable. Therefore, I
>> think we can improve configuring target endpoint by making it at an
>> attribute of the Message Forwarding Processor as follows,
>>
>> > "org.apache.synapse.message.processors.forward.ScheduledMessageForwardingProcessor"
>> name="ScheduledProcessor" messageStore="MyStore"
>> *targetEndpoint="StockQuoteServiceEp"*> 1
>>  3 <
>> parameter name="max.deliver.drop">true 
>>
>> WDYT ?
>>
> --
Sent from Gmail Mobile

Re: Improving how Target Endpoint is Associated with Message Forwarding Processor

[Shafreen]

Hi All,

Any opinion on this?

On Sun, Oct 11, 2020 at 11:45 AM Shafreen  wrote:

> Hi All,
>
> Each Message Forwarding Processor must have a target endpoint. At the
> moment we configure this target endpoint by adding a property in the
> in-sequence of proxy service as follows.
>
> 
>
> IMO, this way of associating target-endpoint with Message Forwarding
> Processor is not only error prone but also less readable. Therefore, I
> think we can improve configuring target endpoint by making it at an
> attribute of the Message Forwarding Processor as follows,
>
>  "org.apache.synapse.message.processors.forward.ScheduledMessageForwardingProcessor"
> name="ScheduledProcessor" messageStore="MyStore"
> *targetEndpoint="StockQuoteServiceEp"*> 1 parameter> 3  name="max.deliver.drop">true 
>
> WDYT ?
>

Improving how Target Endpoint is Associated with Message Forwarding Processor

[Shafreen]

Hi All,

Each Message Forwarding Processor must have a target endpoint. At the
moment we configure this target endpoint by adding a property in the
in-sequence of proxy service as follows.



IMO, this way of associating target-endpoint with Message Forwarding
Processor is not only error prone but also less readable. Therefore, I
think we can improve configuring target endpoint by making it at an
attribute of the Message Forwarding Processor as follows,

 1 3 true 

WDYT ?