[GitHub] [synapse] isudana merged pull request #14: SYNAPSE-1109: copy wsa:From value when creating request context
isudana merged pull request #14: SYNAPSE-1109: copy wsa:From value when creating request context URL: https://github.com/apache/synapse/pull/14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana commented on issue #14: SYNAPSE-1109: copy wsa:From value when creating request context
isudana commented on issue #14: SYNAPSE-1109: copy wsa:From value when creating request context URL: https://github.com/apache/synapse/pull/14#issuecomment-523099981 Thanks for your contribution. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] auke- opened a new pull request #15: SYNAPSE-1109: fix for unit test
auke- opened a new pull request #15: SYNAPSE-1109: fix for unit test URL: https://github.com/apache/synapse/pull/15 The unit test in the patch for SYNAPSE-1109 contained an error, which is fixed in this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana merged pull request #15: SYNAPSE-1109: fix for unit test
isudana merged pull request #15: SYNAPSE-1109: fix for unit test URL: https://github.com/apache/synapse/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] auke- opened a new pull request #16: Notify observers when engaging proxy modules
auke- opened a new pull request #16: Notify observers when engaging proxy modules URL: https://github.com/apache/synapse/pull/16 When the addressing or security module is engaged on the proxy service the Axis2 Observers aren't notified. This is due to the fact that the wrong engageModule method is invoked on the AxisService. By invoking the correct engageModule method on the AxisService the Axis2 Observers are notified when a module is engaged on a proxy service. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] auke- opened a new pull request #17: Notify observers when starting proxy services
auke- opened a new pull request #17: Notify observers when starting proxy services URL: https://github.com/apache/synapse/pull/17 When a proxy service is started the Axis2 Observers aren't notified. This is due to the fact that the proxy services are only loaded by the Axis2 Synapse controller and not started. Inline in, out and fault sequences are not initialized, since that happens when a service is started. By starting the proxy services explicitly in the Axis2 Synapse controller the sequences are properly initialized and the Axis2 Observers are notified. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] auke- opened a new pull request #18: Add .gitignore which ignores common IDE and OS files
auke- opened a new pull request #18: Add .gitignore which ignores common IDE and OS files URL: https://github.com/apache/synapse/pull/18 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana merged pull request #18: Add .gitignore which ignores common IDE and OS files
isudana merged pull request #18: Add .gitignore which ignores common IDE and OS files URL: https://github.com/apache/synapse/pull/18 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana commented on issue #18: Add .gitignore which ignores common IDE and OS files
isudana commented on issue #18: Add .gitignore which ignores common IDE and OS files URL: https://github.com/apache/synapse/pull/18#issuecomment-525744239 Thank you for your contribution. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana commented on issue #17: Notify observers when starting proxy services
isudana commented on issue #17: Notify observers when starting proxy services URL: https://github.com/apache/synapse/pull/17#issuecomment-529187073 Thank you for your contribution. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana merged pull request #17: Notify observers when starting proxy services
isudana merged pull request #17: Notify observers when starting proxy services URL: https://github.com/apache/synapse/pull/17 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] madhawa-gunasekara opened a new pull request #19: Fix SYNAPSE-1104
madhawa-gunasekara opened a new pull request #19: Fix SYNAPSE-1104 URL: https://github.com/apache/synapse/pull/19 Fix Transport issue when the pipe is not consumed correctly. [INFO] [INFO] Reactor Summary for Apache Synapse 3.0.2-SNAPSHOT: [INFO] [INFO] Apache Synapse . SUCCESS [ 11.770 s] [INFO] Apache Synapse - Secure Vault .. SUCCESS [ 8.991 s] [INFO] Apache Synapse - Commons ... SUCCESS [ 5.478 s] [INFO] Apache Synapse - Transports SUCCESS [ 0.547 s] [INFO] Apache Synapse - Non-blocking HTTP/s Transport . SUCCESS [ 14.900 s] [INFO] Apache Synapse - PIPE Transport SUCCESS [ 1.066 s] [INFO] Apache Synapse - VFS Transport . SUCCESS [ 12.917 s] [INFO] Apache Synapse - FIX Transport . SUCCESS [ 1.989 s] [INFO] Apache Synapse - AMQP Transport SUCCESS [ 4.327 s] [INFO] Apache Synapse - Tasks . SUCCESS [ 1.417 s] [INFO] Apache Synapse - Core .. SUCCESS [02:47 min] [INFO] Apache Synapse - Extensions SUCCESS [ 12.562 s] [INFO] Apache Synapse - Samples ... SUCCESS [ 5.738 s] [INFO] Apache Synapse - Patches ... SUCCESS [ 1.182 s] [INFO] Apache Synapse - Experimental code . SUCCESS [ 1.176 s] [INFO] Apache Synapse . SUCCESS [ 10.392 s] [INFO] Apache Synapse - Web Application ... SUCCESS [ 19.692 s] [INFO] Apache Synapse - Handler Module SUCCESS [ 1.317 s] [INFO] Apache Synapse - XAR Maven Plugin .. SUCCESS [ 6.829 s] [INFO] Apache Synapse - Configuration Migrator SUCCESS [ 0.751 s] [INFO] Apache Synapse - Distribution .. SUCCESS [ 14.454 s] [INFO] Apache Synapse - Package skeleton ZIP .. SUCCESS [ 0.438 s] [INFO] Apache Synapse - Package archetype . SUCCESS [ 0.625 s] [INFO] Apache Synapse - Integration ... SUCCESS [02:58 min] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 08:12 min [INFO] Finished at: 2019-09-09T17:50:34+05:30 [INFO] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] sajithaliyanage opened a new pull request #20: Add synapse unit testing framework
sajithaliyanage opened a new pull request #20: Add synapse unit testing framework URL: https://github.com/apache/synapse/pull/20 Provide a built-in way to execute a unit test against a given synapse configuration artifact such as sequence, proxy, api, local entry, endpoint. Following tasks will be added from this PR, - Test Proxy services with test cases, input payloads and transport properties - Test APIs with test cases, input payloads and transport properties - Test Sequences with test cases, input payloads and synapse, axis2, transport properties - Undeploye all the deployed configurations - Customize the starting port of unit testing framework This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] dependabot[bot] opened a new pull request #21: Bump spring.version from 1.2.8 to 5.2.0.RELEASE
dependabot[bot] opened a new pull request #21: Bump spring.version from 1.2.8 to 5.2.0.RELEASE URL: https://github.com/apache/synapse/pull/21 Bumps `spring.version` from 1.2.8 to 5.2.0.RELEASE. Updates `spring-core` from 1.2.8 to 5.2.0.RELEASE Release notes *Sourced from [spring-core's releases](https://github.com/spring-projects/spring-framework/releases).* > ## v5.2.0.RELEASE > ## :star: New Features > > - Add support for MockRestServiceServer to verify that a header does not exist [#23721](https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/23721) > - Set name for shutdown hook Thread [#23670](https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/23670) > - Use Reactor's new Schedulers.boundedElastic() [#23661](https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/23661) > - Avoid ArrayIndexOutOfBoundsException in SpEL's Indexer [#23658](https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/23658) > - Fix RSocketRequester API for requests without payload [#23649](https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/23649) > - Allow registration of RSocket metadata extractors [#23645](https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/23645) > - Allow `@Import` and `@ComponentScan` classes to use constructor injection [#23637](https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/23637) > - Add SVG mapping to mime.types file for JavaMail support [#23629](https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/23629) > - Provide support for disabling cron-based scheduled jobs registered via SchedulingConfigurer [#23568](https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/23568) > - Log HTTP method in logging filters and revise log message format [#23567](https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/23567) > - Omit cancellation of transactional Monos in TransactionOperator [#23562](https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/23562) > - PathMatchingResourcePatternResolver cannot load resources with a '#' in their file name within JARs [#23532](https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/23532) > - Improve parity between Java and Kotlin router DSL [#23524](https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/23524) > - Provide an memory efficient alternative to ClientHttpRequestInterceptor [#22002](https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/22002) > > ## :beetle: Bug Fixes > > - Newly added TransactionOperations.execute(Runnable) breaks existing Kotlin code [#23724](https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/23724) > - ServerRequestExtensionsTests#`remoteAddressOrNull with value()` fails on Java 13 [#23677](https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/23677) > - PathPatternParserTests#regexPathElementPatterns() fails on Java 13 [#23669](https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/23669) > - BOM has explicit `compile` scope for each dependency [#23660](https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/23660) > - AbstractResource causes early log4j initialization [#23655](https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/23655) > - Improper UTF-8 handling in MockMvc for JSON response [#23622](https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/23622) > - Memory leak when using `@Async` after upgrading from 5.1 to 5.2 [#23571](https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/23571) > - FactoryBean registered with explicit target type cannot be autowired by type [#23561](https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/23561) > > ## :notebook_with_decorative_cover: Documentation > > - Fix typo in DispatcherServlet Javadoc [#23726](https://github-redirect.dependabot.com/spring-projects/spring-framework/pull/23726) > - Clarify units handling in DataSize javadoc [#23697](https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/23697) > - Upgrade "Spring Framework Versions" page to mention JDK 13 support [#23674](https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/23674) > - Document WebMvc.fn [#23657](https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/23657) > - Mention Ordered and `@Order` support for components in Javadoc [#23636](https://github-redirect.dependabot.com/spring-projects/spring-framework/issues/23636) > - Fix typo [#
[GitHub] [synapse] dependabot[bot] commented on issue #21: Bump spring.version from 1.2.8 to 5.2.0.RELEASE
dependabot[bot] commented on issue #21: Bump spring.version from 1.2.8 to 5.2.0.RELEASE URL: https://github.com/apache/synapse/pull/21#issuecomment-552690347 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana closed pull request #21: Bump spring.version from 1.2.8 to 5.2.0.RELEASE
isudana closed pull request #21: Bump spring.version from 1.2.8 to 5.2.0.RELEASE URL: https://github.com/apache/synapse/pull/21 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana commented on issue #21: Bump spring.version from 1.2.8 to 5.2.0.RELEASE
isudana commented on issue #21: Bump spring.version from 1.2.8 to 5.2.0.RELEASE URL: https://github.com/apache/synapse/pull/21#issuecomment-552690337 Spring version upgrade cannot be done without a refactoring in the code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana merged pull request #19: Fix SYNAPSE-1104
isudana merged pull request #19: Fix SYNAPSE-1104 URL: https://github.com/apache/synapse/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana commented on issue #16: Notify observers when engaging proxy modules
isudana commented on issue #16: Notify observers when engaging proxy modules URL: https://github.com/apache/synapse/pull/16#issuecomment-552695340 Yes, it looks like AxisConfiguration is parsed as the source AxisDescription while it should be the ProxyService itself. So currently the observers that are observing the axis configuration changes get notified for a module engage in proxy service, which is wrong. I will review and merge the PR. Thanks for your contribution. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana merged pull request #16: Notify observers when engaging proxy modules
isudana merged pull request #16: Notify observers when engaging proxy modules URL: https://github.com/apache/synapse/pull/16 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana commented on issue #11: Performance save - Replace instances of Math.Random with Random.nextD…
isudana commented on issue #11: Performance save - Replace instances of Math.Random with Random.nextD… URL: https://github.com/apache/synapse/pull/11#issuecomment-555270122 There is no conclusive fact to claim that using Random.nextDouble() gives a significant performance gain over Math.Random(). I found the following resources, but those are not good enough to make a drastic change in the codebase. https://stackoverflow.com/questions/738629/math-random-versus-random-nextintint https://community.oracle.com/message/6596485?#6594485 Do you have any other resources or proof to prove that we could gain a performance improvement by doing this change? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana closed pull request #11: Performance save - Replace instances of Math.Random with Random.nextD…
isudana closed pull request #11: Performance save - Replace instances of Math.Random with Random.nextD… URL: https://github.com/apache/synapse/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] madhawa-gunasekara opened a new pull request #22: Fix SYNAPSE-1105
madhawa-gunasekara opened a new pull request #22: Fix SYNAPSE-1105 URL: https://github.com/apache/synapse/pull/22 TargetConnections getConnection method doesn't retrun null when the connection is not available. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] madhawa-gunasekara opened a new pull request #23: Fix SYNAPSE-1106
madhawa-gunasekara opened a new pull request #23: Fix SYNAPSE-1106 URL: https://github.com/apache/synapse/pull/23 MessageContext class store messageContext object in a ThreadLocalVariable where it doesn't clear created ThreadLocal variables properly. Therefore synapse passthrough threads contain created the Theadlocal variable which refers to the created soap envelope during the mediation level. Because of the retained ThreadLocal variables, Passthrough threads consumes a huge amount of memory which leads to OOM. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana commented on a change in pull request #23: Fix SYNAPSE-1106
isudana commented on a change in pull request #23: Fix SYNAPSE-1106
URL: https://github.com/apache/synapse/pull/23#discussion_r384256406
##
File path:
modules/transports/core/nhttp/src/main/java/org/apache/synapse/transport/passthru/ServerWorker.java
##
@@ -107,110 +107,114 @@ public ServerWorker(final SourceRequest request,
}
public void run() {
-if (log.isDebugEnabled()) {
-log.debug("Starting a new Server Worker instance");
-}
-ConfigurationContext cfgCtx =
sourceConfiguration.getConfigurationContext();
-msgContext.setProperty(Constants.Configuration.HTTP_METHOD,
request.getMethod());
-
-String method = request.getRequest() != null ?
-
request.getRequest().getRequestLine().getMethod().toUpperCase() : "";
-
-String uri = request.getUri();
-String oriUri = uri;
-
-if (uri.contains(cfgCtx.getServicePath())) {
-// discard up to servicePath
-uri = uri.substring(uri.indexOf(cfgCtx.getServicePath()) +
-cfgCtx.getServicePath().length());
-// discard [proxy] service name if any
-int pos = uri.indexOf("/", 1);
-if (pos > 0) {
-uri = uri.substring(pos);
-} else {
-pos = uri.indexOf("?");
-if (pos != -1) {
+try {
Review comment:
Please do not do code formatting in the entire class while sending fixes, it
makes really hard to see the actual change you have done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org
For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana merged pull request #23: Fix SYNAPSE-1106
isudana merged pull request #23: Fix SYNAPSE-1106 URL: https://github.com/apache/synapse/pull/23 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] madhawa-gunasekara commented on a change in pull request #23: Fix SYNAPSE-1106
madhawa-gunasekara commented on a change in pull request #23: Fix SYNAPSE-1106
URL: https://github.com/apache/synapse/pull/23#discussion_r385136910
##
File path:
modules/transports/core/nhttp/src/main/java/org/apache/synapse/transport/passthru/ServerWorker.java
##
@@ -107,110 +107,114 @@ public ServerWorker(final SourceRequest request,
}
public void run() {
-if (log.isDebugEnabled()) {
-log.debug("Starting a new Server Worker instance");
-}
-ConfigurationContext cfgCtx =
sourceConfiguration.getConfigurationContext();
-msgContext.setProperty(Constants.Configuration.HTTP_METHOD,
request.getMethod());
-
-String method = request.getRequest() != null ?
-
request.getRequest().getRequestLine().getMethod().toUpperCase() : "";
-
-String uri = request.getUri();
-String oriUri = uri;
-
-if (uri.contains(cfgCtx.getServicePath())) {
-// discard up to servicePath
-uri = uri.substring(uri.indexOf(cfgCtx.getServicePath()) +
-cfgCtx.getServicePath().length());
-// discard [proxy] service name if any
-int pos = uri.indexOf("/", 1);
-if (pos > 0) {
-uri = uri.substring(pos);
-} else {
-pos = uri.indexOf("?");
-if (pos != -1) {
+try {
Review comment:
Noted 👍
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org
For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana commented on issue #22: Fix SYNAPSE-1105
isudana commented on issue #22: Fix SYNAPSE-1105 URL: https://github.com/apache/synapse/pull/22#issuecomment-592910084 Can you please explain the fix, I can't understand the difference in the logic made by this PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar opened a new pull request #24: Add an improvement to log-mediator
shafreenAnfar opened a new pull request #24: Add an improvement to log-mediator URL: https://github.com/apache/synapse/pull/24 Consider the below Proxy service in which I have configured the log-mediator to print logs only when the category is set to DEBUG. However, there is no way to start the server with log-mediator debug logs enabled. Only way to print the property values inside the log mediator is by configuring debug mode for the log -mediator class in the log4j.properties. But this is wrong because aforementioned configuration is there for the implementer of log-mediator but not for the synapse user. ```xml http://ws.apache.org/ns/synapse"; name="test" transports="http,https" statistics="disable" trace="disable" startOnLoad="true"> ``` Above issue is fixed with this PR. With this fix synapse users can start the server as follows which will enable debug mood for log-mediator. ``` sh synapse.sh -synapseDebug ``` Following is a sample output of the log mediator. ``` 2020-03-04 21:01:02,663 [-] [PassThroughMessageProcessor-1] INFO LogMediator To: /services/test, MessageID: urn:uuid:13cc5420-1282-456b-a0c0-fcfa6457c28e, Direction: request, someproperty = somevalue ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] madhawa-gunasekara closed pull request #22: Fix SYNAPSE-1105
madhawa-gunasekara closed pull request #22: Fix SYNAPSE-1105 URL: https://github.com/apache/synapse/pull/22 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] madhawa-gunasekara commented on issue #22: Fix SYNAPSE-1105
madhawa-gunasekara commented on issue #22: Fix SYNAPSE-1105 URL: https://github.com/apache/synapse/pull/22#issuecomment-594828088 @isudana yes this is a mistake. I will close the pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana commented on a change in pull request #24: Add an improvement to log-mediator
isudana commented on a change in pull request #24: Add an improvement to log-mediator URL: https://github.com/apache/synapse/pull/24#discussion_r388012618 ## File path: modules/distribution/src/main/bin/synapse.sh ## @@ -146,12 +146,17 @@ if [ "$1" = "-xdebug" ]; then SERVER_NAME=$2 shift 2 # -serverName and actual name + elif [ "$1" = "-synapseDebug" ]; then +SYNAPSE_DEBUG="synapseDebug" +shift + elif [ "$1" = "-h" ]; then echo "Usage: synapse.sh ( commands ... )" echo "commands:" echo " -xdebugStart Synapse under JPDA debugger" echo " -sample (number) Start with sample Synapse configuration of given number" echo " -serverName Name of the Synapse server instance" +echo " -synapseName Start Synapse under debug mode" Review comment: this should be changed to -synapseDebug isn't it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar commented on a change in pull request #24: Add an improvement to log-mediator
shafreenAnfar commented on a change in pull request #24: Add an improvement to log-mediator URL: https://github.com/apache/synapse/pull/24#discussion_r388671630 ## File path: modules/distribution/src/main/bin/synapse.sh ## @@ -146,12 +146,17 @@ if [ "$1" = "-xdebug" ]; then SERVER_NAME=$2 shift 2 # -serverName and actual name + elif [ "$1" = "-synapseDebug" ]; then +SYNAPSE_DEBUG="synapseDebug" +shift + elif [ "$1" = "-h" ]; then echo "Usage: synapse.sh ( commands ... )" echo "commands:" echo " -xdebugStart Synapse under JPDA debugger" echo " -sample (number) Start with sample Synapse configuration of given number" echo " -serverName Name of the Synapse server instance" +echo " -synapseName Start Synapse under debug mode" Review comment: Fixed it. Thanks for pointing out and sorry for the mistake. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar opened a new pull request #25: Enable Continuous Integration (CI) for new PRs
shafreenAnfar opened a new pull request #25: Enable Continuous Integration (CI) for new PRs URL: https://github.com/apache/synapse/pull/25 At the moment, when there is a new PR, we always have to build locally to make sure the new PR doesn't introduce any regression issues. However, with Github Actions we can automate this effort with zero cost. I have written a Github workflow to automatically build new PRs to check its validity. Current Github workflow only runs on latest-ubuntu with Java 8. However, we can further improve it as we move forward. Once merged it will look like in the below image.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana opened a new pull request #26: Update certificates to fix the expired cert issue
isudana opened a new pull request #26: Update certificates to fix the expired cert issue URL: https://github.com/apache/synapse/pull/26 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] vanjikumaran merged pull request #26: Update certificates to fix the expired cert issue
vanjikumaran merged pull request #26: Update certificates to fix the expired cert issue URL: https://github.com/apache/synapse/pull/26 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana merged pull request #25: Enable Continuous Integration (CI) for new PRs
isudana merged pull request #25: Enable Continuous Integration (CI) for new PRs URL: https://github.com/apache/synapse/pull/25 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana merged pull request #24: Add an improvement to log-mediator
isudana merged pull request #24: Add an improvement to log-mediator URL: https://github.com/apache/synapse/pull/24 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] vanjikumaran opened a new pull request #27: Adding CI Badge in the ReadMe file
vanjikumaran opened a new pull request #27: Adding CI Badge in the ReadMe file URL: https://github.com/apache/synapse/pull/27 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana merged pull request #27: Adding CI Badge in the ReadMe file
isudana merged pull request #27: Adding CI Badge in the ReadMe file URL: https://github.com/apache/synapse/pull/27 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar opened a new pull request #28: Add synapse daily build github workflow with a badge
shafreenAnfar opened a new pull request #28: Add synapse daily build github workflow with a badge URL: https://github.com/apache/synapse/pull/28 Hi All, At the moment, there is no direct way to know if the master is broken. For instance, recently, Synapse master was broken due to an expired certificate but nobody new till someone built it locally. This problem is solved with this PR. This PR adds a github workflow which triggers a build on master every midnight. This allows to immediately get to know if the master is broken. So that we can quickly attend to it and get if fixed. Along with the github workflow, this PR also adds a badge to Readme.md which indicates status of the synapse daily build. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar opened a new pull request #29: Add documentation for the log mediator improvement
shafreenAnfar opened a new pull request #29: Add documentation for the log mediator improvement URL: https://github.com/apache/synapse/pull/29 This PR adds documentation for the feature which was merged with PR #24. When merged it will look as below,  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana commented on a change in pull request #28: Add synapse daily build github workflow with a badge
isudana commented on a change in pull request #28: Add synapse daily build github workflow with a badge URL: https://github.com/apache/synapse/pull/28#discussion_r392680178 ## File path: README.md ## @@ -1,7 +1,7 @@ + Review comment: This points to your forked github repo build. can you please change it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar commented on a change in pull request #28: Add synapse daily build github workflow with a badge
shafreenAnfar commented on a change in pull request #28: Add synapse daily build github workflow with a badge URL: https://github.com/apache/synapse/pull/28#discussion_r392746807 ## File path: README.md ## @@ -1,7 +1,7 @@ + Review comment: Done! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] vanjikumaran commented on a change in pull request #28: Add synapse daily build github workflow with a badge
vanjikumaran commented on a change in pull request #28: Add synapse daily build github workflow with a badge URL: https://github.com/apache/synapse/pull/28#discussion_r392752732 ## File path: README.md ## @@ -1,7 +1,7 @@ + Review comment: @shafreenAnfar, Why there are no tag nodes Example:- "![CI]" Can you please take a screenshot of the preview changes? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana merged pull request #28: Add synapse daily build github workflow with a badge
isudana merged pull request #28: Add synapse daily build github workflow with a badge URL: https://github.com/apache/synapse/pull/28 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar closed pull request #29: Add documentation for the log mediator improvement
shafreenAnfar closed pull request #29: Add documentation for the log mediator improvement URL: https://github.com/apache/synapse/pull/29 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar commented on issue #29: Add documentation for the log mediator improvement
shafreenAnfar commented on issue #29: Add documentation for the log mediator improvement URL: https://github.com/apache/synapse/pull/29#issuecomment-600444926 Closing this PR and I will send a new one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar opened a new pull request #30: Add documentation for the log mediator improvement
shafreenAnfar opened a new pull request #30: Add documentation for the log mediator improvement URL: https://github.com/apache/synapse/pull/30 This PR adds documentation for the feature which was merged with PR #24. When merged it will look as below,  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana merged pull request #30: Add documentation for the log mediator improvement
isudana merged pull request #30: Add documentation for the log mediator improvement URL: https://github.com/apache/synapse/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana opened a new pull request #31: Remove CI badge from readme
isudana opened a new pull request #31: Remove CI badge from readme URL: https://github.com/apache/synapse/pull/31 CI build runs for a particular pull request. Failure or the success of the CI build does not reflect the build state of the entire source repository. So we need to remove that from the main readme file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] vanjikumaran merged pull request #31: Remove CI badge from readme
vanjikumaran merged pull request #31: Remove CI badge from readme URL: https://github.com/apache/synapse/pull/31 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar opened a new pull request #32: Improve Message Forwarding Processor (MFP) to support HTTP status codes
shafreenAnfar opened a new pull request #32: Improve Message Forwarding Processor (MFP) to support HTTP status codes URL: https://github.com/apache/synapse/pull/32 At the moment, current MFP implementation does not support retrying based on HTTP status codes. It only supports retrying for transport level failures but not for application level failures. As you know, in HTTP protocol, application level failures are distinguished using different status codes. In the case of MFP, it is important to be able to retry for 5xx server errors. But there also could be rare occasions in which retrying for 4xx and 3xx are useful. Especially when dealing with servers that do not follow HTTP protocol exactly as it is. Therefore, I have improved MFP implementation to support retrying based on the returned HTTP status code as well. Say, a user wants to retry for HTTP status codes 500 and 504 but not for any other HTTP status code. In that case user can configure the MFP as below. Please note the parameter in bold font which I have introduced along with this feature. ```xml http://ws.apache.org/ns/synapse"; class="org.apache.synapse.message.processors.forward.ScheduledMessageForwardingProcessor" name="Processor2" messageStore="JMSMS"> 4 replySequence 1000 500, 504 ``` Please not that the above parameter does not come to effect in case of out-only. Once this is merged, I am planning to send another PR for the required documentation changes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar opened a new pull request #33: Add windows runner to workflow
shafreenAnfar opened a new pull request #33: Add windows runner to workflow URL: https://github.com/apache/synapse/pull/33 This will run the daily build on latest windows apart from running it on latest linux os. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar opened a new pull request #34: Add windows runner to workflow
shafreenAnfar opened a new pull request #34: Add windows runner to workflow URL: https://github.com/apache/synapse/pull/34 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar commented on issue #33: Add windows runner to workflow
shafreenAnfar commented on issue #33: Add windows runner to workflow URL: https://github.com/apache/synapse/pull/33#issuecomment-605590064 Closing this PR. I have sent the same PR from a different branch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar closed pull request #33: Add windows runner to workflow
shafreenAnfar closed pull request #33: Add windows runner to workflow URL: https://github.com/apache/synapse/pull/33 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar commented on a change in pull request #32: Improve Message Forwarding Processor (MFP) to support HTTP status codes
shafreenAnfar commented on a change in pull request #32: Improve Message Forwarding Processor (MFP) to support HTTP status codes URL: https://github.com/apache/synapse/pull/32#discussion_r399756268 ## File path: modules/core/src/main/java/org/apache/synapse/SynapseConstants.java ## @@ -412,6 +412,9 @@ public static final String HTTP_SENDER_STATUSCODE = "transport.http.statusCode"; +public static final String HTTP_INTERNAL_SERVER_ERROR = "500"; +public static final String HTTP_BAD_REQUEST_ERROR = "400"; + Review comment: If needed I can move this to MessageProcessorConsents class as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana merged pull request #34: Add windows runner to workflow
isudana merged pull request #34: Add windows runner to workflow URL: https://github.com/apache/synapse/pull/34 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana commented on a change in pull request #32: Improve Message Forwarding Processor (MFP) to support HTTP status codes
isudana commented on a change in pull request #32: Improve Message Forwarding Processor (MFP) to support HTTP status codes URL: https://github.com/apache/synapse/pull/32#discussion_r400340740 ## File path: modules/core/src/main/java/org/apache/synapse/SynapseConstants.java ## @@ -412,6 +412,9 @@ public static final String HTTP_SENDER_STATUSCODE = "transport.http.statusCode"; +public static final String HTTP_INTERNAL_SERVER_ERROR = "500"; +public static final String HTTP_BAD_REQUEST_ERROR = "400"; + Review comment: +1, let's move this to MessageProcessorConsents This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar commented on issue #32: Improve Message Forwarding Processor (MFP) to support HTTP status codes
shafreenAnfar commented on issue #32: Improve Message Forwarding Processor (MFP) to support HTTP status codes URL: https://github.com/apache/synapse/pull/32#issuecomment-606358193 Btw, do let me know if there is way to write a solid test-case for this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana merged pull request #32: Improve Message Forwarding Processor (MFP) to support HTTP status codes
isudana merged pull request #32: Improve Message Forwarding Processor (MFP) to support HTTP status codes URL: https://github.com/apache/synapse/pull/32 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar opened a new pull request #35: Fix the typo in the class name
shafreenAnfar opened a new pull request #35: Fix the typo in the class name URL: https://github.com/apache/synapse/pull/35 Hi All, I have fixed the typo in the class as follows, `MessageProcessorConsents` -> `MessageProcessorConstants` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar opened a new pull request #36: Update documentation for the HTTP status code retry
shafreenAnfar opened a new pull request #36: Update documentation for the HTTP status code retry URL: https://github.com/apache/synapse/pull/36 This PR contains the documentation for the feature in PR #32. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] vanjikumaran merged pull request #36: Update documentation for the HTTP status code retry
vanjikumaran merged pull request #36: Update documentation for the HTTP status code retry URL: https://github.com/apache/synapse/pull/36 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] vanjikumaran merged pull request #35: Fix the typo in the class name
vanjikumaran merged pull request #35: Fix the typo in the class name URL: https://github.com/apache/synapse/pull/35 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] vanjikumaran commented on issue #20: Add synapse unit testing framework
vanjikumaran commented on issue #20: Add synapse unit testing framework URL: https://github.com/apache/synapse/pull/20#issuecomment-607959370 @isudana we should look into this feature This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar opened a new pull request #37: Format the synapse code in the sample 705
shafreenAnfar opened a new pull request #37: Format the synapse code in the sample 705 URL: https://github.com/apache/synapse/pull/37 $subject. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana merged pull request #37: Format the synapse code in the sample 705
isudana merged pull request #37: Format the synapse code in the sample 705 URL: https://github.com/apache/synapse/pull/37 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar opened a new pull request #38: Refactor ForwardingJob class and fix few issues
shafreenAnfar opened a new pull request #38: Refactor ForwardingJob class and fix few issues URL: https://github.com/apache/synapse/pull/38 Hi All, This PR does the $subject and in the process I have fixed two issues as well. Programmers spend more time to reading code and less time on writing code. Therefore, it is needless to say that having readable code is essential in any project. `ForwardingJob` class was actually the opposite of this (forgive me for saying this) and it is very hard to read the code do new modification. Making the code vulnerable for regression issues. Therefore, I have refactored the code starting the basic principle of functions doing one and only one thing. In the processes I have moved some variables into class variables as actually control the state of the `ForwadingJob`. Also, code abstraction done in a way that, reader starts with the highest abstraction of the concept and then drill down to more granular abstractions. This is similar to news-paper metaphor. Also, all the functions follow vertical affinity and therefore closely related functions are placed next to other. Please note that after the refactor I have re-tested all the scenarios such as, **Out Only Scenario** - Success scenario - Retry scenario - Max delivery scenario - Max delivery drop scenario - Invoking Deactivate scenario **Response Scenario** - Success scenario - Retry scenario - Retry on application level failure scenario - Invoking reply sequence scenario - Invoking fault sequence scenario - Invoking deactivate sequence scenario - Max delivery attempt scenario - Max delivery drop scenario Along with this I have fixed below two bugs, https://issues.apache.org/jira/browse/SYNAPSE-1120 https://issues.apache.org/jira/browse/SYNAPSE-1121 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar opened a new pull request #39: Add mac-os runner for the daily build
shafreenAnfar opened a new pull request #39: Add mac-os runner for the daily build URL: https://github.com/apache/synapse/pull/39 At the moment daily build only runs on ubuntu and windows. This PR adds mac-os the the list. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana merged pull request #39: Add mac-os runner for the daily build
isudana merged pull request #39: Add mac-os runner for the daily build URL: https://github.com/apache/synapse/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana commented on issue #38: Refactor ForwardingJob class and fix few issues
isudana commented on issue #38: Refactor ForwardingJob class and fix few issues URL: https://github.com/apache/synapse/pull/38#issuecomment-609533832 Thanks Shafreen, I will take time and review the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana merged pull request #38: Refactor ForwardingJob class and fix few issues
isudana merged pull request #38: Refactor ForwardingJob class and fix few issues URL: https://github.com/apache/synapse/pull/38 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar opened a new pull request #40: Add retry interval feature
shafreenAnfar opened a new pull request #40: Add retry interval feature URL: https://github.com/apache/synapse/pull/40 At the moment Message Processor only support one interval for both fetching messages from the store and retrying when there is a failure. But, IMO, these are two different concepts and deserve two different configurations. Therefore, this PR introduces the new retry interval as follows, ```1``` This will allow the user to control the speed of retry when there is a failure. Please note that after the change I have re-tested all the scenarios such as, **Out Only Scenario** - Success scenario - Retry scenario - Max delivery scenario - Max delivery drop scenario - Invoking Deactivate scenario **Response Scenario** - Success scenario - Retry scenario - Retry on application level failure scenario - Invoking reply sequence scenario - Invoking fault sequence scenario - Invoking deactivate sequence scenario - Max delivery attempt scenario - Max delivery drop scenario This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar commented on issue #40: Add retry interval feature
shafreenAnfar commented on issue #40: Add retry interval feature URL: https://github.com/apache/synapse/pull/40#issuecomment-612645251 Had to close this PR due to unwanted commits. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar closed pull request #40: Add retry interval feature
shafreenAnfar closed pull request #40: Add retry interval feature URL: https://github.com/apache/synapse/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar commented on issue #40: Add retry interval feature
shafreenAnfar commented on issue #40: Add retry interval feature URL: https://github.com/apache/synapse/pull/40#issuecomment-612647624 Please find the new PR. https://github.com/apache/synapse/pull/41 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar opened a new pull request #41: Add retry interval feature
shafreenAnfar opened a new pull request #41: Add retry interval feature URL: https://github.com/apache/synapse/pull/41 At the moment Message Processor only support one interval for both fetching messages from the store and retrying when there is a failure. But, IMO, these are two different concepts and deserve two different configurations. Therefore, this PR introduces the new retry interval as follows, ```1``` This will allow the user to control the speed of retry when there is a failure. Please note that after the change I have re-tested all the scenarios such as, **Out Only Scenario** - Success scenario - Retry scenario - Max delivery scenario - Max delivery drop scenario - Invoking Deactivate scenario **Response Scenario** - Success scenario - Retry scenario - Retry on application level failure scenario - Invoking reply sequence scenario - Invoking fault sequence scenario - Invoking deactivate sequence scenario - Max delivery attempt scenario - Max delivery drop scenario This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar opened a new pull request #42: Add Java 7 to build matrix
shafreenAnfar opened a new pull request #42: Add Java 7 to build matrix URL: https://github.com/apache/synapse/pull/42 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] vanjikumaran merged pull request #42: Add Java 7 to build matrix
vanjikumaran merged pull request #42: Add Java 7 to build matrix URL: https://github.com/apache/synapse/pull/42 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana commented on a change in pull request #41: Add retry interval feature
isudana commented on a change in pull request #41:
URL: https://github.com/apache/synapse/pull/41#discussion_r411376184
##
File path:
modules/core/src/main/java/org/apache/synapse/message/processors/forward/ForwardingJob.java
##
@@ -80,20 +85,31 @@ private void configureForwardingJob(JobDataMap jdm) {
ScheduledMessageForwardingProcessor.BLOCKING_SENDER);
processor = (ScheduledMessageForwardingProcessor) jdm.get(
ScheduledMessageForwardingProcessor.PROCESSOR_INSTANCE);
+retryInterval = 1000;
+
+setParameters(jdm);
+}
+
+private void setParameters(JobDataMap jdm) {
Map parameters = (Map)
jdm.get(MessageProcessorConstants.PARAMETERS);
-maxDeliverAttempts = extractMaxDeliveryAttempts(parameters, processor);
-isMaxDeliverAttemptDropEnabled =
isMaxDeliverAttemptDropEnabled(parameters);
-retryHttpStatusCodes(parameters);
-setSequences(parameters);
+if (parameters != null) {
+maxDeliverAttempts = extractMaxDeliveryAttempts(parameters,
processor);
+isMaxDeliverAttemptDropEnabled =
isMaxDeliverAttemptDropEnabled(parameters);
+if (parameters.get(ForwardingProcessorConstants.RETRY_INTERVAL) !=
null) {
+retryInterval = Integer.parseInt((String)
parameters.get(ForwardingProcessorConstants.RETRY_INTERVAL));
Review comment:
Shouldn't we handle NumberformatException here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org
For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar commented on a change in pull request #41: Add retry interval feature
shafreenAnfar commented on a change in pull request #41:
URL: https://github.com/apache/synapse/pull/41#discussion_r411504565
##
File path:
modules/core/src/main/java/org/apache/synapse/message/processors/forward/ForwardingJob.java
##
@@ -80,20 +85,31 @@ private void configureForwardingJob(JobDataMap jdm) {
ScheduledMessageForwardingProcessor.BLOCKING_SENDER);
processor = (ScheduledMessageForwardingProcessor) jdm.get(
ScheduledMessageForwardingProcessor.PROCESSOR_INSTANCE);
+retryInterval = 1000;
+
+setParameters(jdm);
+}
+
+private void setParameters(JobDataMap jdm) {
Map parameters = (Map)
jdm.get(MessageProcessorConstants.PARAMETERS);
-maxDeliverAttempts = extractMaxDeliveryAttempts(parameters, processor);
-isMaxDeliverAttemptDropEnabled =
isMaxDeliverAttemptDropEnabled(parameters);
-retryHttpStatusCodes(parameters);
-setSequences(parameters);
+if (parameters != null) {
+maxDeliverAttempts = extractMaxDeliveryAttempts(parameters,
processor);
+isMaxDeliverAttemptDropEnabled =
isMaxDeliverAttemptDropEnabled(parameters);
+if (parameters.get(ForwardingProcessorConstants.RETRY_INTERVAL) !=
null) {
+retryInterval = Integer.parseInt((String)
parameters.get(ForwardingProcessorConstants.RETRY_INTERVAL));
Review comment:
Thanks for pointing out. I missed it. I have handle the exception by
falling back to default value and also logged the error message.
`2020-04-20 21:35:48,458 [-] [DefaultQuartzScheduler_Worker-1] ERROR
ForwardingJob Invalid value for retry.interval switching back to default value
`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org
For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar commented on a change in pull request #41: Add retry interval feature
shafreenAnfar commented on a change in pull request #41:
URL: https://github.com/apache/synapse/pull/41#discussion_r411504565
##
File path:
modules/core/src/main/java/org/apache/synapse/message/processors/forward/ForwardingJob.java
##
@@ -80,20 +85,31 @@ private void configureForwardingJob(JobDataMap jdm) {
ScheduledMessageForwardingProcessor.BLOCKING_SENDER);
processor = (ScheduledMessageForwardingProcessor) jdm.get(
ScheduledMessageForwardingProcessor.PROCESSOR_INSTANCE);
+retryInterval = 1000;
+
+setParameters(jdm);
+}
+
+private void setParameters(JobDataMap jdm) {
Map parameters = (Map)
jdm.get(MessageProcessorConstants.PARAMETERS);
-maxDeliverAttempts = extractMaxDeliveryAttempts(parameters, processor);
-isMaxDeliverAttemptDropEnabled =
isMaxDeliverAttemptDropEnabled(parameters);
-retryHttpStatusCodes(parameters);
-setSequences(parameters);
+if (parameters != null) {
+maxDeliverAttempts = extractMaxDeliveryAttempts(parameters,
processor);
+isMaxDeliverAttemptDropEnabled =
isMaxDeliverAttemptDropEnabled(parameters);
+if (parameters.get(ForwardingProcessorConstants.RETRY_INTERVAL) !=
null) {
+retryInterval = Integer.parseInt((String)
parameters.get(ForwardingProcessorConstants.RETRY_INTERVAL));
Review comment:
Thanks for pointing out. I missed it. I have handled the exception by
falling back to default value and also logged the error message.
`2020-04-20 21:35:48,458 [-] [DefaultQuartzScheduler_Worker-1] ERROR
ForwardingJob Invalid value for retry.interval switching back to default value
`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org
For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar opened a new pull request #43: Add documentation for retry.interval feature
shafreenAnfar opened a new pull request #43: URL: https://github.com/apache/synapse/pull/43 This PR adds documentation for feature in #41. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar opened a new pull request #44: Add different OSs and JDKs
shafreenAnfar opened a new pull request #44: URL: https://github.com/apache/synapse/pull/44 At the moment the build that runs for each PR only runs on ubuntu and Java 8. With this PR I have added windows and mac to the build along with Java 7. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar opened a new pull request #45: Fix the issue of not invoking fault-sequence
shafreenAnfar opened a new pull request #45: URL: https://github.com/apache/synapse/pull/45 At the moment, when there is a failure in Message Processor (i.e. Connection refused) fault sequence is not invoked in `OUT_ONLY` scenario. This issue is fixed with this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] vanjikumaran commented on a change in pull request #43: Add documentation for retry.interval feature
vanjikumaran commented on a change in pull request #43: URL: https://github.com/apache/synapse/pull/43#discussion_r422676323 ## File path: modules/documentation/src/site/xdoc/userguide/samples/sample705.xml ## @@ -58,6 +58,7 @@3 true 500, 504 +5000 Review comment: It would be good if you can adopt the default value that is in the code [1] [1]https://github.com/apache/synapse/pull/41/files#diff-af12a51dc14c81dc0feaf0cfa7e8667aR88 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana merged pull request #45: Fix the issue of not invoking fault-sequence
isudana merged pull request #45: URL: https://github.com/apache/synapse/pull/45 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar opened a new pull request #46: Add consume one message at a time feature
shafreenAnfar opened a new pull request #46: URL: https://github.com/apache/synapse/pull/46 Current behavior of the Message Forwarding Processor is to consume all the messages at once. For instance, say, the Message Forwarding Processor is configured to run every 10 seconds and the Message store is filled with 5 messages within the 10 second gap. In such a situation, Message Forwarding Processor consumes all 5 messages and try to send it to back-end as fast as possible. I think this behavior is not optimal. The purpose of Message Forwarding Processor it to send messages to the back-end in a controlled rate. So that the back-end server can handle the load. IMO, ideal behavior should be to consume one message at a time and try to send it to the back-end as per the configured interval. I have implemented this feature by introducing the below configuration to Message Processor. ```xml false ``` Default behavior is to consume all the messages at once. When the value of `consume.all`, is set to `false`. Message processor would only consume one message per each trigger. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar opened a new pull request #47: Add documentation for consume.all property of Message Forwarding Processor
shafreenAnfar opened a new pull request #47: URL: https://github.com/apache/synapse/pull/47 This PR includes the documentation for `consume.all` property. For more details please refer to #46. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana merged pull request #47: Add documentation for consume.all property of Message Forwarding Processor
isudana merged pull request #47: URL: https://github.com/apache/synapse/pull/47 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana merged pull request #46: Add consume one message at a time feature
isudana merged pull request #46: URL: https://github.com/apache/synapse/pull/46 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar opened a new pull request #48: Fix the daily build
shafreenAnfar opened a new pull request #48: URL: https://github.com/apache/synapse/pull/48 I have removed the matrix from the daily build. It seems there are intermittent test failures which causes the daily build to fail. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] vanjikumaran merged pull request #48: Fix the daily build
vanjikumaran merged pull request #48: URL: https://github.com/apache/synapse/pull/48 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar opened a new pull request #49: Fix the build
shafreenAnfar opened a new pull request #49: URL: https://github.com/apache/synapse/pull/49 At the moment both daily build and the PR builds are failing due to SSL issue. This issue is only seen when the build is run with Java 8 which is provided by setup-java github action. I am further looking into this issue. In the mean time I have removed Java 8 build. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana merged pull request #49: Fix the build
isudana merged pull request #49: URL: https://github.com/apache/synapse/pull/49 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] shafreenAnfar opened a new pull request #51: Remove the Jenkins build badge from ReadMe
shafreenAnfar opened a new pull request #51: URL: https://github.com/apache/synapse/pull/51 $subject. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] veithen merged pull request #51: Remove the Jenkins build badge from ReadMe
veithen merged pull request #51: URL: https://github.com/apache/synapse/pull/51 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
[GitHub] [synapse] isudana merged pull request #50: Improving how Target Endpoint is Associated with Message Forwarding Processor
isudana merged pull request #50: URL: https://github.com/apache/synapse/pull/50 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
