[jira] [Resolved] (SYNCOPE-1633) Give the possibility to add a custom message to the confirm dialog
[ https://issues.apache.org/jira/browse/SYNCOPE-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Chicchiriccò resolved SYNCOPE-1633. - Resolution: Fixed > Give the possibility to add a custom message to the confirm dialog > -- > > Key: SYNCOPE-1633 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1633 > Project: Syncope > Issue Type: Improvement > Components: console >Affects Versions: 2.1.9 >Reporter: Marco Di Sabatino Di Diodoro >Assignee: Marco Di Sabatino Di Diodoro >Priority: Minor > Fix For: 2.1.10, 3.0.0 > > > In some cases it is not possible to specify the message to appear in the > confirm dialog. In order to display a custom message the entire component > must be overridden. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SYNCOPE-1634) Group Owner update/delete action doesn't trigger propagation action
[
https://issues.apache.org/jira/browse/SYNCOPE-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347020#comment-17347020
]
ASF subversion and git services commented on SYNCOPE-1634:
--
Commit 1a7229230e6e058cbc2152530491e8c98fc5f433 in syncope's branch
refs/heads/master from DmitriyBrashevets
[ https://gitbox.apache.org/repos/asf?p=syncope.git;h=1a72292 ]
[SYNCOPE-1634] Provision group during user/group owner update (#263)
> Group Owner update/delete action doesn't trigger propagation action
> ---
>
> Key: SYNCOPE-1634
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1634
> Project: Syncope
> Issue Type: Bug
> Components: core
>Affects Versions: 2.1.6, 2.1.9
>Reporter: Dmitriy Brashevets
>Assignee: Francesco Chicchiriccò
>Priority: Major
> Fix For: 2.1.10, 3.0.0
>
>
> Removing or adding of user as a userOwner or group as a groupOwner to group
> doesn't trigger propagation action for this group. The group is assigned to a
> particular resource.
> An example of HTTP call is (userOwner assignement):
> *POST* *http://${syncopeHost}/syncope/rest/groups/${groupKey}*
> {code:javascript}
> {
> "@class": "org.apache.syncope.common.lib.to.GroupTO",
> "key": "6d1d2db6-35ff-4d99-9d2d-b635ff4d99c7",
> "type": "GROUP",
> "realm": "/myOU",
> "name": "mypti_imp_user",
> "creator": "admin",
> "creationDate": "2021-04-27T10:11:28.463+",
> "lastModifier": "admin",
> "lastChangeDate": "2021-05-17T15:38:02.213+",
> "status": null,
> "userOwner": "95e1e259-0a15-41ed-a1e2-590a1521ed74",
> "groupOwner": null,
> "udynMembershipCond": null,
> "staticUserMembershipCount": 3,
> "dynamicUserMembershipCount": 0,
> "staticAnyObjectMembershipCount": 0,
> "dynamicAnyObjectMembershipCount": 0,
> "adynMembershipConds": {
>
> },
> "dynRealms": [
>
> ],
> "auxClasses": [
>
> ],
> "plainAttrs": [
>
> ],
> "derAttrs": [
>
> ],
> "virAttrs": [
>
> ],
> "resources": [
> "f5d7756e-4d9d-4590-a4a9-dcd1c4a8a60d"
> ],
> "typeExtensions": [
>
> ]
> }
> {code}
> Example of assigning of group as a group owner:
> *POST http://${syncopeHost}/syncope/rest/groups/${groupKey}*
> {code:javascript}
> {
> "@class": "org.apache.syncope.common.lib.to.GroupTO",
> "key": "6d1d2db6-35ff-4d99-9d2d-b635ff4d99c7",
> "type": "GROUP",
> "realm": "/myOU",
> "name": "mypti_imp_user",
> "creator": "admin",
> "creationDate": "2021-04-27T10:11:28.463+",
> "lastModifier": "admin",
> "lastChangeDate": "2021-05-18T13:01:38.428+",
> "status": null,
> "userOwner": "",
> "groupOwner": "30849a12-bbca-40f7-849a-12bbca30f777",
> "udynMembershipCond": null,
> "staticUserMembershipCount": 3,
> "dynamicUserMembershipCount": 0,
> "staticAnyObjectMembershipCount": 0,
> "dynamicAnyObjectMembershipCount": 0,
> "adynMembershipConds": {
>
> },
> "dynRealms": [
>
> ],
> "auxClasses": [
>
> ],
> "plainAttrs": [
>
> ],
> "derAttrs": [
>
> ],
> "virAttrs": [
>
> ],
> "resources": [
> "f5d7756e-4d9d-4590-a4a9-dcd1c4a8a60d"
> ],
> "typeExtensions": [
>
> ]
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SYNCOPE-1634) Group Owner update/delete action doesn't trigger propagation action
[
https://issues.apache.org/jira/browse/SYNCOPE-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francesco Chicchiriccò resolved SYNCOPE-1634.
-
Resolution: Fixed
> Group Owner update/delete action doesn't trigger propagation action
> ---
>
> Key: SYNCOPE-1634
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1634
> Project: Syncope
> Issue Type: Bug
> Components: core
>Affects Versions: 2.1.6, 2.1.9
>Reporter: Dmitriy Brashevets
>Assignee: Francesco Chicchiriccò
>Priority: Major
> Fix For: 2.1.10, 3.0.0
>
>
> Removing or adding of user as a userOwner or group as a groupOwner to group
> doesn't trigger propagation action for this group. The group is assigned to a
> particular resource.
> An example of HTTP call is (userOwner assignement):
> *POST* *http://${syncopeHost}/syncope/rest/groups/${groupKey}*
> {code:javascript}
> {
> "@class": "org.apache.syncope.common.lib.to.GroupTO",
> "key": "6d1d2db6-35ff-4d99-9d2d-b635ff4d99c7",
> "type": "GROUP",
> "realm": "/myOU",
> "name": "mypti_imp_user",
> "creator": "admin",
> "creationDate": "2021-04-27T10:11:28.463+",
> "lastModifier": "admin",
> "lastChangeDate": "2021-05-17T15:38:02.213+",
> "status": null,
> "userOwner": "95e1e259-0a15-41ed-a1e2-590a1521ed74",
> "groupOwner": null,
> "udynMembershipCond": null,
> "staticUserMembershipCount": 3,
> "dynamicUserMembershipCount": 0,
> "staticAnyObjectMembershipCount": 0,
> "dynamicAnyObjectMembershipCount": 0,
> "adynMembershipConds": {
>
> },
> "dynRealms": [
>
> ],
> "auxClasses": [
>
> ],
> "plainAttrs": [
>
> ],
> "derAttrs": [
>
> ],
> "virAttrs": [
>
> ],
> "resources": [
> "f5d7756e-4d9d-4590-a4a9-dcd1c4a8a60d"
> ],
> "typeExtensions": [
>
> ]
> }
> {code}
> Example of assigning of group as a group owner:
> *POST http://${syncopeHost}/syncope/rest/groups/${groupKey}*
> {code:javascript}
> {
> "@class": "org.apache.syncope.common.lib.to.GroupTO",
> "key": "6d1d2db6-35ff-4d99-9d2d-b635ff4d99c7",
> "type": "GROUP",
> "realm": "/myOU",
> "name": "mypti_imp_user",
> "creator": "admin",
> "creationDate": "2021-04-27T10:11:28.463+",
> "lastModifier": "admin",
> "lastChangeDate": "2021-05-18T13:01:38.428+",
> "status": null,
> "userOwner": "",
> "groupOwner": "30849a12-bbca-40f7-849a-12bbca30f777",
> "udynMembershipCond": null,
> "staticUserMembershipCount": 3,
> "dynamicUserMembershipCount": 0,
> "staticAnyObjectMembershipCount": 0,
> "dynamicAnyObjectMembershipCount": 0,
> "adynMembershipConds": {
>
> },
> "dynRealms": [
>
> ],
> "auxClasses": [
>
> ],
> "plainAttrs": [
>
> ],
> "derAttrs": [
>
> ],
> "virAttrs": [
>
> ],
> "resources": [
> "f5d7756e-4d9d-4590-a4a9-dcd1c4a8a60d"
> ],
> "typeExtensions": [
>
> ]
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SYNCOPE-1634) Group Owner update/delete action doesn't trigger propagation action
[
https://issues.apache.org/jira/browse/SYNCOPE-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347014#comment-17347014
]
ASF subversion and git services commented on SYNCOPE-1634:
--
Commit 3e1bfa6c4a337d6eb1789fbb9d0459b7f78a5255 in syncope's branch
refs/heads/2_1_X from DmitriyBrashevets
[ https://gitbox.apache.org/repos/asf?p=syncope.git;h=3e1bfa6 ]
[SYNCOPE-1634] Provision group during user/group owner update (#263)
> Group Owner update/delete action doesn't trigger propagation action
> ---
>
> Key: SYNCOPE-1634
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1634
> Project: Syncope
> Issue Type: Bug
> Components: core
>Affects Versions: 2.1.6, 2.1.9
>Reporter: Dmitriy Brashevets
>Assignee: Francesco Chicchiriccò
>Priority: Major
> Fix For: 2.1.10, 3.0.0
>
>
> Removing or adding of user as a userOwner or group as a groupOwner to group
> doesn't trigger propagation action for this group. The group is assigned to a
> particular resource.
> An example of HTTP call is (userOwner assignement):
> *POST* *http://${syncopeHost}/syncope/rest/groups/${groupKey}*
> {code:javascript}
> {
> "@class": "org.apache.syncope.common.lib.to.GroupTO",
> "key": "6d1d2db6-35ff-4d99-9d2d-b635ff4d99c7",
> "type": "GROUP",
> "realm": "/myOU",
> "name": "mypti_imp_user",
> "creator": "admin",
> "creationDate": "2021-04-27T10:11:28.463+",
> "lastModifier": "admin",
> "lastChangeDate": "2021-05-17T15:38:02.213+",
> "status": null,
> "userOwner": "95e1e259-0a15-41ed-a1e2-590a1521ed74",
> "groupOwner": null,
> "udynMembershipCond": null,
> "staticUserMembershipCount": 3,
> "dynamicUserMembershipCount": 0,
> "staticAnyObjectMembershipCount": 0,
> "dynamicAnyObjectMembershipCount": 0,
> "adynMembershipConds": {
>
> },
> "dynRealms": [
>
> ],
> "auxClasses": [
>
> ],
> "plainAttrs": [
>
> ],
> "derAttrs": [
>
> ],
> "virAttrs": [
>
> ],
> "resources": [
> "f5d7756e-4d9d-4590-a4a9-dcd1c4a8a60d"
> ],
> "typeExtensions": [
>
> ]
> }
> {code}
> Example of assigning of group as a group owner:
> *POST http://${syncopeHost}/syncope/rest/groups/${groupKey}*
> {code:javascript}
> {
> "@class": "org.apache.syncope.common.lib.to.GroupTO",
> "key": "6d1d2db6-35ff-4d99-9d2d-b635ff4d99c7",
> "type": "GROUP",
> "realm": "/myOU",
> "name": "mypti_imp_user",
> "creator": "admin",
> "creationDate": "2021-04-27T10:11:28.463+",
> "lastModifier": "admin",
> "lastChangeDate": "2021-05-18T13:01:38.428+",
> "status": null,
> "userOwner": "",
> "groupOwner": "30849a12-bbca-40f7-849a-12bbca30f777",
> "udynMembershipCond": null,
> "staticUserMembershipCount": 3,
> "dynamicUserMembershipCount": 0,
> "staticAnyObjectMembershipCount": 0,
> "dynamicAnyObjectMembershipCount": 0,
> "adynMembershipConds": {
>
> },
> "dynRealms": [
>
> ],
> "auxClasses": [
>
> ],
> "plainAttrs": [
>
> ],
> "derAttrs": [
>
> ],
> "virAttrs": [
>
> ],
> "resources": [
> "f5d7756e-4d9d-4590-a4a9-dcd1c4a8a60d"
> ],
> "typeExtensions": [
>
> ]
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [syncope] ilgrosso commented on pull request #263: [SYNCOPE-1634] Provision group during user/group owner update
ilgrosso commented on pull request #263: URL: https://github.com/apache/syncope/pull/263#issuecomment-843287982 thanks @DmitriyBrashevets ! I am going to cherry-pick on `master` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [syncope] ilgrosso merged pull request #263: [SYNCOPE-1634] Provision group during user/group owner update
ilgrosso merged pull request #263: URL: https://github.com/apache/syncope/pull/263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SYNCOPE-1634) Group Owner update/delete action doesn't trigger propagation action
[
https://issues.apache.org/jira/browse/SYNCOPE-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francesco Chicchiriccò updated SYNCOPE-1634:
Fix Version/s: 3.0.0
2.1.10
> Group Owner update/delete action doesn't trigger propagation action
> ---
>
> Key: SYNCOPE-1634
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1634
> Project: Syncope
> Issue Type: Bug
> Components: core
>Affects Versions: 2.1.6, 2.1.9
>Reporter: Dmitriy Brashevets
>Priority: Major
> Fix For: 2.1.10, 3.0.0
>
>
> Removing or adding of user as a userOwner or group as a groupOwner to group
> doesn't trigger propagation action for this group. The group is assigned to a
> particular resource.
> An example of HTTP call is (userOwner assignement):
> *POST* *http://${syncopeHost}/syncope/rest/groups/${groupKey}*
> {code:javascript}
> {
> "@class": "org.apache.syncope.common.lib.to.GroupTO",
> "key": "6d1d2db6-35ff-4d99-9d2d-b635ff4d99c7",
> "type": "GROUP",
> "realm": "/myOU",
> "name": "mypti_imp_user",
> "creator": "admin",
> "creationDate": "2021-04-27T10:11:28.463+",
> "lastModifier": "admin",
> "lastChangeDate": "2021-05-17T15:38:02.213+",
> "status": null,
> "userOwner": "95e1e259-0a15-41ed-a1e2-590a1521ed74",
> "groupOwner": null,
> "udynMembershipCond": null,
> "staticUserMembershipCount": 3,
> "dynamicUserMembershipCount": 0,
> "staticAnyObjectMembershipCount": 0,
> "dynamicAnyObjectMembershipCount": 0,
> "adynMembershipConds": {
>
> },
> "dynRealms": [
>
> ],
> "auxClasses": [
>
> ],
> "plainAttrs": [
>
> ],
> "derAttrs": [
>
> ],
> "virAttrs": [
>
> ],
> "resources": [
> "f5d7756e-4d9d-4590-a4a9-dcd1c4a8a60d"
> ],
> "typeExtensions": [
>
> ]
> }
> {code}
> Example of assigning of group as a group owner:
> *POST http://${syncopeHost}/syncope/rest/groups/${groupKey}*
> {code:javascript}
> {
> "@class": "org.apache.syncope.common.lib.to.GroupTO",
> "key": "6d1d2db6-35ff-4d99-9d2d-b635ff4d99c7",
> "type": "GROUP",
> "realm": "/myOU",
> "name": "mypti_imp_user",
> "creator": "admin",
> "creationDate": "2021-04-27T10:11:28.463+",
> "lastModifier": "admin",
> "lastChangeDate": "2021-05-18T13:01:38.428+",
> "status": null,
> "userOwner": "",
> "groupOwner": "30849a12-bbca-40f7-849a-12bbca30f777",
> "udynMembershipCond": null,
> "staticUserMembershipCount": 3,
> "dynamicUserMembershipCount": 0,
> "staticAnyObjectMembershipCount": 0,
> "dynamicAnyObjectMembershipCount": 0,
> "adynMembershipConds": {
>
> },
> "dynRealms": [
>
> ],
> "auxClasses": [
>
> ],
> "plainAttrs": [
>
> ],
> "derAttrs": [
>
> ],
> "virAttrs": [
>
> ],
> "resources": [
> "f5d7756e-4d9d-4590-a4a9-dcd1c4a8a60d"
> ],
> "typeExtensions": [
>
> ]
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (SYNCOPE-1634) Group Owner update/delete action doesn't trigger propagation action
[
https://issues.apache.org/jira/browse/SYNCOPE-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francesco Chicchiriccò reassigned SYNCOPE-1634:
---
Assignee: Francesco Chicchiriccò
> Group Owner update/delete action doesn't trigger propagation action
> ---
>
> Key: SYNCOPE-1634
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1634
> Project: Syncope
> Issue Type: Bug
> Components: core
>Affects Versions: 2.1.6, 2.1.9
>Reporter: Dmitriy Brashevets
>Assignee: Francesco Chicchiriccò
>Priority: Major
> Fix For: 2.1.10, 3.0.0
>
>
> Removing or adding of user as a userOwner or group as a groupOwner to group
> doesn't trigger propagation action for this group. The group is assigned to a
> particular resource.
> An example of HTTP call is (userOwner assignement):
> *POST* *http://${syncopeHost}/syncope/rest/groups/${groupKey}*
> {code:javascript}
> {
> "@class": "org.apache.syncope.common.lib.to.GroupTO",
> "key": "6d1d2db6-35ff-4d99-9d2d-b635ff4d99c7",
> "type": "GROUP",
> "realm": "/myOU",
> "name": "mypti_imp_user",
> "creator": "admin",
> "creationDate": "2021-04-27T10:11:28.463+",
> "lastModifier": "admin",
> "lastChangeDate": "2021-05-17T15:38:02.213+",
> "status": null,
> "userOwner": "95e1e259-0a15-41ed-a1e2-590a1521ed74",
> "groupOwner": null,
> "udynMembershipCond": null,
> "staticUserMembershipCount": 3,
> "dynamicUserMembershipCount": 0,
> "staticAnyObjectMembershipCount": 0,
> "dynamicAnyObjectMembershipCount": 0,
> "adynMembershipConds": {
>
> },
> "dynRealms": [
>
> ],
> "auxClasses": [
>
> ],
> "plainAttrs": [
>
> ],
> "derAttrs": [
>
> ],
> "virAttrs": [
>
> ],
> "resources": [
> "f5d7756e-4d9d-4590-a4a9-dcd1c4a8a60d"
> ],
> "typeExtensions": [
>
> ]
> }
> {code}
> Example of assigning of group as a group owner:
> *POST http://${syncopeHost}/syncope/rest/groups/${groupKey}*
> {code:javascript}
> {
> "@class": "org.apache.syncope.common.lib.to.GroupTO",
> "key": "6d1d2db6-35ff-4d99-9d2d-b635ff4d99c7",
> "type": "GROUP",
> "realm": "/myOU",
> "name": "mypti_imp_user",
> "creator": "admin",
> "creationDate": "2021-04-27T10:11:28.463+",
> "lastModifier": "admin",
> "lastChangeDate": "2021-05-18T13:01:38.428+",
> "status": null,
> "userOwner": "",
> "groupOwner": "30849a12-bbca-40f7-849a-12bbca30f777",
> "udynMembershipCond": null,
> "staticUserMembershipCount": 3,
> "dynamicUserMembershipCount": 0,
> "staticAnyObjectMembershipCount": 0,
> "dynamicAnyObjectMembershipCount": 0,
> "adynMembershipConds": {
>
> },
> "dynRealms": [
>
> ],
> "auxClasses": [
>
> ],
> "plainAttrs": [
>
> ],
> "derAttrs": [
>
> ],
> "virAttrs": [
>
> ],
> "resources": [
> "f5d7756e-4d9d-4590-a4a9-dcd1c4a8a60d"
> ],
> "typeExtensions": [
>
> ]
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [syncope] DmitriyBrashevets commented on a change in pull request #263: [SYNCOPE-1634] Provision group during user/group owner update
DmitriyBrashevets commented on a change in pull request #263:
URL: https://github.com/apache/syncope/pull/263#discussion_r634485482
##
File path:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/GroupDataBinderImpl.java
##
@@ -207,16 +207,43 @@ public void create(final Group group, final GroupTO
groupTO) {
group.setName(groupPatch.getName().getValue());
}
+PropagationByResource propByRes = new
PropagationByResource<>();
// owner
if (groupPatch.getUserOwner() != null) {
-group.setUserOwner(groupPatch.getUserOwner().getValue() == null
-? null
-: userDAO.find(groupPatch.getUserOwner().getValue()));
+if (StringUtils.isBlank(groupPatch.getUserOwner().getValue())) {
+if (group.getUserOwner() != null) {
+group.setUserOwner(null);
+propByRes.addAll(ResourceOperation.UPDATE,
groupDAO.findAllResourceKeys(group.getKey()));
+}
+} else {
+User userOwner =
userDAO.find(groupPatch.getUserOwner().getValue());
+if (userOwner != null) {
+group.setUserOwner(userOwner);
+propByRes.addAll(ResourceOperation.UPDATE,
groupDAO.findAllResourceKeys(group.getKey()));
+} else {
+LOG.debug("Unable to find user owner for group {} by key
{}",
+group.getKey(),
groupPatch.getUserOwner().getValue() );
Review comment:
thanks, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [syncope] DmitriyBrashevets commented on a change in pull request #263: [SYNCOPE-1634] Provision group during user/group owner update
DmitriyBrashevets commented on a change in pull request #263:
URL: https://github.com/apache/syncope/pull/263#discussion_r634484113
##
File path:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/GroupDataBinderImpl.java
##
@@ -207,16 +207,43 @@ public void create(final Group group, final GroupTO
groupTO) {
group.setName(groupPatch.getName().getValue());
}
+PropagationByResource propByRes = new
PropagationByResource<>();
// owner
if (groupPatch.getUserOwner() != null) {
-group.setUserOwner(groupPatch.getUserOwner().getValue() == null
-? null
-: userDAO.find(groupPatch.getUserOwner().getValue()));
+if (StringUtils.isBlank(groupPatch.getUserOwner().getValue())) {
+if (group.getUserOwner() != null) {
+group.setUserOwner(null);
+propByRes.addAll(ResourceOperation.UPDATE,
groupDAO.findAllResourceKeys(group.getKey()));
+}
+} else {
+User userOwner =
userDAO.find(groupPatch.getUserOwner().getValue());
+if (userOwner != null) {
Review comment:
inverted condition
##
File path:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/GroupDataBinderImpl.java
##
@@ -207,16 +207,43 @@ public void create(final Group group, final GroupTO
groupTO) {
group.setName(groupPatch.getName().getValue());
}
+PropagationByResource propByRes = new
PropagationByResource<>();
// owner
if (groupPatch.getUserOwner() != null) {
-group.setUserOwner(groupPatch.getUserOwner().getValue() == null
-? null
-: userDAO.find(groupPatch.getUserOwner().getValue()));
+if (StringUtils.isBlank(groupPatch.getUserOwner().getValue())) {
+if (group.getUserOwner() != null) {
+group.setUserOwner(null);
+propByRes.addAll(ResourceOperation.UPDATE,
groupDAO.findAllResourceKeys(group.getKey()));
+}
+} else {
+User userOwner =
userDAO.find(groupPatch.getUserOwner().getValue());
+if (userOwner != null) {
+group.setUserOwner(userOwner);
+propByRes.addAll(ResourceOperation.UPDATE,
groupDAO.findAllResourceKeys(group.getKey()));
+} else {
+LOG.debug("Unable to find user owner for group {} by key
{}",
+group.getKey(),
groupPatch.getUserOwner().getValue() );
+group.setUserOwner(null);
+}
+}
}
if (groupPatch.getGroupOwner() != null) {
-group.setGroupOwner(groupPatch.getGroupOwner().getValue() == null
-? null
-: groupDAO.find(groupPatch.getGroupOwner().getValue()));
+if (StringUtils.isBlank(groupPatch.getGroupOwner().getValue())) {
Review comment:
agree, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [syncope] DmitriyBrashevets commented on a change in pull request #263: [SYNCOPE-1634] Provision group during user/group owner update
DmitriyBrashevets commented on a change in pull request #263:
URL: https://github.com/apache/syncope/pull/263#discussion_r634483108
##
File path:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/GroupDataBinderImpl.java
##
@@ -207,16 +207,43 @@ public void create(final Group group, final GroupTO
groupTO) {
group.setName(groupPatch.getName().getValue());
}
+PropagationByResource propByRes = new
PropagationByResource<>();
// owner
if (groupPatch.getUserOwner() != null) {
-group.setUserOwner(groupPatch.getUserOwner().getValue() == null
-? null
-: userDAO.find(groupPatch.getUserOwner().getValue()));
+if (StringUtils.isBlank(groupPatch.getUserOwner().getValue())) {
Review comment:
agree, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [syncope] DmitriyBrashevets commented on a change in pull request #263: [SYNCOPE-1634] Provision group during user/group owner update
DmitriyBrashevets commented on a change in pull request #263:
URL: https://github.com/apache/syncope/pull/263#discussion_r634482576
##
File path:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/GroupDataBinderImpl.java
##
@@ -207,16 +207,43 @@ public void create(final Group group, final GroupTO
groupTO) {
group.setName(groupPatch.getName().getValue());
}
+PropagationByResource propByRes = new
PropagationByResource<>();
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [syncope] ilgrosso commented on a change in pull request #263: [SYNCOPE-1634] Provision group during user/group owner update
ilgrosso commented on a change in pull request #263:
URL: https://github.com/apache/syncope/pull/263#discussion_r634443411
##
File path:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/GroupDataBinderImpl.java
##
@@ -207,16 +207,43 @@ public void create(final Group group, final GroupTO
groupTO) {
group.setName(groupPatch.getName().getValue());
}
+PropagationByResource propByRes = new
PropagationByResource<>();
// owner
if (groupPatch.getUserOwner() != null) {
-group.setUserOwner(groupPatch.getUserOwner().getValue() == null
-? null
-: userDAO.find(groupPatch.getUserOwner().getValue()));
+if (StringUtils.isBlank(groupPatch.getUserOwner().getValue())) {
Review comment:
Checking for `null` equality should be enough here (rather than
`StringUtils#isBlank` since the expected value is an user key, e.g. UUID
##
File path:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/GroupDataBinderImpl.java
##
@@ -207,16 +207,43 @@ public void create(final Group group, final GroupTO
groupTO) {
group.setName(groupPatch.getName().getValue());
}
+PropagationByResource propByRes = new
PropagationByResource<>();
// owner
if (groupPatch.getUserOwner() != null) {
-group.setUserOwner(groupPatch.getUserOwner().getValue() == null
-? null
-: userDAO.find(groupPatch.getUserOwner().getValue()));
+if (StringUtils.isBlank(groupPatch.getUserOwner().getValue())) {
+if (group.getUserOwner() != null) {
+group.setUserOwner(null);
+propByRes.addAll(ResourceOperation.UPDATE,
groupDAO.findAllResourceKeys(group.getKey()));
+}
+} else {
+User userOwner =
userDAO.find(groupPatch.getUserOwner().getValue());
+if (userOwner != null) {
Review comment:
Please invert this if / else check to avoid Yoda issues with checkstyle,
e.g.
```
if (userOwner == null) {
} else {
}
```
##
File path:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/GroupDataBinderImpl.java
##
@@ -207,16 +207,43 @@ public void create(final Group group, final GroupTO
groupTO) {
group.setName(groupPatch.getName().getValue());
}
+PropagationByResource propByRes = new
PropagationByResource<>();
// owner
if (groupPatch.getUserOwner() != null) {
-group.setUserOwner(groupPatch.getUserOwner().getValue() == null
-? null
-: userDAO.find(groupPatch.getUserOwner().getValue()));
+if (StringUtils.isBlank(groupPatch.getUserOwner().getValue())) {
+if (group.getUserOwner() != null) {
+group.setUserOwner(null);
+propByRes.addAll(ResourceOperation.UPDATE,
groupDAO.findAllResourceKeys(group.getKey()));
+}
+} else {
+User userOwner =
userDAO.find(groupPatch.getUserOwner().getValue());
+if (userOwner != null) {
+group.setUserOwner(userOwner);
+propByRes.addAll(ResourceOperation.UPDATE,
groupDAO.findAllResourceKeys(group.getKey()));
+} else {
+LOG.debug("Unable to find user owner for group {} by key
{}",
+group.getKey(),
groupPatch.getUserOwner().getValue() );
+group.setUserOwner(null);
+}
+}
}
if (groupPatch.getGroupOwner() != null) {
-group.setGroupOwner(groupPatch.getGroupOwner().getValue() == null
-? null
-: groupDAO.find(groupPatch.getGroupOwner().getValue()));
+if (StringUtils.isBlank(groupPatch.getGroupOwner().getValue())) {
Review comment:
Same observations here as in the former block
##
File path:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/GroupDataBinderImpl.java
##
@@ -207,16 +207,43 @@ public void create(final Group group, final GroupTO
groupTO) {
group.setName(groupPatch.getName().getValue());
}
+PropagationByResource propByRes = new
PropagationByResource<>();
Review comment:
Please rename this as something like `ownerPropByRes`
##
File path:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/GroupDataBinderImpl.java
##
@@ -207,16 +207,43 @@ public void create(final Group group, final GroupTO
groupTO) {
group.setName(groupPatch.getName().getValue());
}
+PropagationByResource propByRes = new
[GitHub] [syncope] DmitriyBrashevets opened a new pull request #263: [SYNCOPE-1634] Provision group during user/group owner update
DmitriyBrashevets opened a new pull request #263: URL: https://github.com/apache/syncope/pull/263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SYNCOPE-1634) Group Owner update/delete action doesn't trigger propagation action
[
https://issues.apache.org/jira/browse/SYNCOPE-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitriy Brashevets updated SYNCOPE-1634:
Affects Version/s: 2.1.9
> Group Owner update/delete action doesn't trigger propagation action
> ---
>
> Key: SYNCOPE-1634
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1634
> Project: Syncope
> Issue Type: Bug
> Components: core
>Affects Versions: 2.1.6, 2.1.9
>Reporter: Dmitriy Brashevets
>Priority: Major
>
> Removing or adding of user as a userOwner or group as a groupOwner to group
> doesn't trigger propagation action for this group. The group is assigned to a
> particular resource.
> An example of HTTP call is (userOwner assignement):
> *POST* *http://${syncopeHost}/syncope/rest/groups/${groupKey}*
> {code:javascript}
> {
> "@class": "org.apache.syncope.common.lib.to.GroupTO",
> "key": "6d1d2db6-35ff-4d99-9d2d-b635ff4d99c7",
> "type": "GROUP",
> "realm": "/myOU",
> "name": "mypti_imp_user",
> "creator": "admin",
> "creationDate": "2021-04-27T10:11:28.463+",
> "lastModifier": "admin",
> "lastChangeDate": "2021-05-17T15:38:02.213+",
> "status": null,
> "userOwner": "95e1e259-0a15-41ed-a1e2-590a1521ed74",
> "groupOwner": null,
> "udynMembershipCond": null,
> "staticUserMembershipCount": 3,
> "dynamicUserMembershipCount": 0,
> "staticAnyObjectMembershipCount": 0,
> "dynamicAnyObjectMembershipCount": 0,
> "adynMembershipConds": {
>
> },
> "dynRealms": [
>
> ],
> "auxClasses": [
>
> ],
> "plainAttrs": [
>
> ],
> "derAttrs": [
>
> ],
> "virAttrs": [
>
> ],
> "resources": [
> "f5d7756e-4d9d-4590-a4a9-dcd1c4a8a60d"
> ],
> "typeExtensions": [
>
> ]
> }
> {code}
> Example of assigning of group as a group owner:
> *POST http://${syncopeHost}/syncope/rest/groups/${groupKey}*
> {code:javascript}
> {
> "@class": "org.apache.syncope.common.lib.to.GroupTO",
> "key": "6d1d2db6-35ff-4d99-9d2d-b635ff4d99c7",
> "type": "GROUP",
> "realm": "/myOU",
> "name": "mypti_imp_user",
> "creator": "admin",
> "creationDate": "2021-04-27T10:11:28.463+",
> "lastModifier": "admin",
> "lastChangeDate": "2021-05-18T13:01:38.428+",
> "status": null,
> "userOwner": "",
> "groupOwner": "30849a12-bbca-40f7-849a-12bbca30f777",
> "udynMembershipCond": null,
> "staticUserMembershipCount": 3,
> "dynamicUserMembershipCount": 0,
> "staticAnyObjectMembershipCount": 0,
> "dynamicAnyObjectMembershipCount": 0,
> "adynMembershipConds": {
>
> },
> "dynRealms": [
>
> ],
> "auxClasses": [
>
> ],
> "plainAttrs": [
>
> ],
> "derAttrs": [
>
> ],
> "virAttrs": [
>
> ],
> "resources": [
> "f5d7756e-4d9d-4590-a4a9-dcd1c4a8a60d"
> ],
> "typeExtensions": [
>
> ]
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SYNCOPE-1634) Group Owner update/delete action doesn't trigger propagation action
[
https://issues.apache.org/jira/browse/SYNCOPE-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitriy Brashevets updated SYNCOPE-1634:
Affects Version/s: (was: 2.1.9)
2.1.6
> Group Owner update/delete action doesn't trigger propagation action
> ---
>
> Key: SYNCOPE-1634
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1634
> Project: Syncope
> Issue Type: Bug
> Components: core
>Affects Versions: 2.1.6
>Reporter: Dmitriy Brashevets
>Priority: Major
>
> Removing or adding of user as a userOwner or group as a groupOwner to group
> doesn't trigger propagation action for this group. The group is assigned to a
> particular resource.
> An example of HTTP call is (userOwner assignement):
> *POST* *http://${syncopeHost}/syncope/rest/groups/${groupKey}*
> {code:javascript}
> {
> "@class": "org.apache.syncope.common.lib.to.GroupTO",
> "key": "6d1d2db6-35ff-4d99-9d2d-b635ff4d99c7",
> "type": "GROUP",
> "realm": "/myOU",
> "name": "mypti_imp_user",
> "creator": "admin",
> "creationDate": "2021-04-27T10:11:28.463+",
> "lastModifier": "admin",
> "lastChangeDate": "2021-05-17T15:38:02.213+",
> "status": null,
> "userOwner": "95e1e259-0a15-41ed-a1e2-590a1521ed74",
> "groupOwner": null,
> "udynMembershipCond": null,
> "staticUserMembershipCount": 3,
> "dynamicUserMembershipCount": 0,
> "staticAnyObjectMembershipCount": 0,
> "dynamicAnyObjectMembershipCount": 0,
> "adynMembershipConds": {
>
> },
> "dynRealms": [
>
> ],
> "auxClasses": [
>
> ],
> "plainAttrs": [
>
> ],
> "derAttrs": [
>
> ],
> "virAttrs": [
>
> ],
> "resources": [
> "f5d7756e-4d9d-4590-a4a9-dcd1c4a8a60d"
> ],
> "typeExtensions": [
>
> ]
> }
> {code}
> Example of assigning of group as a group owner:
> *POST http://${syncopeHost}/syncope/rest/groups/${groupKey}*
> {code:javascript}
> {
> "@class": "org.apache.syncope.common.lib.to.GroupTO",
> "key": "6d1d2db6-35ff-4d99-9d2d-b635ff4d99c7",
> "type": "GROUP",
> "realm": "/myOU",
> "name": "mypti_imp_user",
> "creator": "admin",
> "creationDate": "2021-04-27T10:11:28.463+",
> "lastModifier": "admin",
> "lastChangeDate": "2021-05-18T13:01:38.428+",
> "status": null,
> "userOwner": "",
> "groupOwner": "30849a12-bbca-40f7-849a-12bbca30f777",
> "udynMembershipCond": null,
> "staticUserMembershipCount": 3,
> "dynamicUserMembershipCount": 0,
> "staticAnyObjectMembershipCount": 0,
> "dynamicAnyObjectMembershipCount": 0,
> "adynMembershipConds": {
>
> },
> "dynRealms": [
>
> ],
> "auxClasses": [
>
> ],
> "plainAttrs": [
>
> ],
> "derAttrs": [
>
> ],
> "virAttrs": [
>
> ],
> "resources": [
> "f5d7756e-4d9d-4590-a4a9-dcd1c4a8a60d"
> ],
> "typeExtensions": [
>
> ]
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SYNCOPE-1634) Group Owner update/delete action doesn't trigger propagation action
Dmitriy Brashevets created SYNCOPE-1634:
---
Summary: Group Owner update/delete action doesn't trigger
propagation action
Key: SYNCOPE-1634
URL: https://issues.apache.org/jira/browse/SYNCOPE-1634
Project: Syncope
Issue Type: Bug
Components: core
Affects Versions: 2.1.9
Reporter: Dmitriy Brashevets
Removing or adding of user as a userOwner or group as a groupOwner to group
doesn't trigger propagation action for this group. The group is assigned to a
particular resource.
An example of HTTP call is (userOwner assignement):
*POST* *http://${syncopeHost}/syncope/rest/groups/${groupKey}*
{code:javascript}
{
"@class": "org.apache.syncope.common.lib.to.GroupTO",
"key": "6d1d2db6-35ff-4d99-9d2d-b635ff4d99c7",
"type": "GROUP",
"realm": "/myOU",
"name": "mypti_imp_user",
"creator": "admin",
"creationDate": "2021-04-27T10:11:28.463+",
"lastModifier": "admin",
"lastChangeDate": "2021-05-17T15:38:02.213+",
"status": null,
"userOwner": "95e1e259-0a15-41ed-a1e2-590a1521ed74",
"groupOwner": null,
"udynMembershipCond": null,
"staticUserMembershipCount": 3,
"dynamicUserMembershipCount": 0,
"staticAnyObjectMembershipCount": 0,
"dynamicAnyObjectMembershipCount": 0,
"adynMembershipConds": {
},
"dynRealms": [
],
"auxClasses": [
],
"plainAttrs": [
],
"derAttrs": [
],
"virAttrs": [
],
"resources": [
"f5d7756e-4d9d-4590-a4a9-dcd1c4a8a60d"
],
"typeExtensions": [
]
}
{code}
Example of assigning of group as a group owner:
*POST http://${syncopeHost}/syncope/rest/groups/${groupKey}*
{code:javascript}
{
"@class": "org.apache.syncope.common.lib.to.GroupTO",
"key": "6d1d2db6-35ff-4d99-9d2d-b635ff4d99c7",
"type": "GROUP",
"realm": "/myOU",
"name": "mypti_imp_user",
"creator": "admin",
"creationDate": "2021-04-27T10:11:28.463+",
"lastModifier": "admin",
"lastChangeDate": "2021-05-18T13:01:38.428+",
"status": null,
"userOwner": "",
"groupOwner": "30849a12-bbca-40f7-849a-12bbca30f777",
"udynMembershipCond": null,
"staticUserMembershipCount": 3,
"dynamicUserMembershipCount": 0,
"staticAnyObjectMembershipCount": 0,
"dynamicAnyObjectMembershipCount": 0,
"adynMembershipConds": {
},
"dynRealms": [
],
"auxClasses": [
],
"plainAttrs": [
],
"derAttrs": [
],
"virAttrs": [
],
"resources": [
"f5d7756e-4d9d-4590-a4a9-dcd1c4a8a60d"
],
"typeExtensions": [
]
}
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Broken: apache/syncope#7394 (master - 48ece56)
Build Update for apache/syncope - Build: #7394 Status: Broken Duration: 59 mins and 56 secs Commit: 48ece56 (master) Author: Marco Di Sabatino Di Diodoro Message: [SYNCOPE-1633] Confirm dialog custom message View the changeset: https://github.com/apache/syncope/compare/075767100cf8...48ece56217b5 View the full build log and details: https://travis-ci.com/github/apache/syncope/builds/226186120?utm_medium=notification_source=email -- You can unsubscribe from build emails from the apache/syncope repository going to https://travis-ci.com/account/preferences/unsubscribe?repository=16807214_medium=notification_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.com/account/preferences/unsubscribe?utm_medium=notification_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.
[jira] [Commented] (SYNCOPE-1633) Give the possibility to add a custom message to the confirm dialog
[ https://issues.apache.org/jira/browse/SYNCOPE-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346760#comment-17346760 ] ASF subversion and git services commented on SYNCOPE-1633: -- Commit 48ece56217b561ac6892a4ea76cf7e045ead1326 in syncope's branch refs/heads/master from Marco Di Sabatino Di Diodoro [ https://gitbox.apache.org/repos/asf?p=syncope.git;h=48ece56 ] [SYNCOPE-1633] Confirm dialog custom message > Give the possibility to add a custom message to the confirm dialog > -- > > Key: SYNCOPE-1633 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1633 > Project: Syncope > Issue Type: Improvement > Components: console >Affects Versions: 2.1.9 >Reporter: Marco Di Sabatino Di Diodoro >Assignee: Marco Di Sabatino Di Diodoro >Priority: Minor > Fix For: 2.1.10, 3.0.0 > > > In some cases it is not possible to specify the message to appear in the > confirm dialog. In order to display a custom message the entire component > must be overridden. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SYNCOPE-1633) Give the possibility to add a custom message to the confirm dialog
[ https://issues.apache.org/jira/browse/SYNCOPE-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346745#comment-17346745 ] ASF subversion and git services commented on SYNCOPE-1633: -- Commit 5d451759a2224b8d6fb608d62814e59b1a41ec5f in syncope's branch refs/heads/2_1_X from Marco Di Sabatino Di Diodoro [ https://gitbox.apache.org/repos/asf?p=syncope.git;h=5d45175 ] [SYNCOPE-1633] Confirm dialog custom message > Give the possibility to add a custom message to the confirm dialog > -- > > Key: SYNCOPE-1633 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1633 > Project: Syncope > Issue Type: Improvement > Components: console >Affects Versions: 2.1.9 >Reporter: Marco Di Sabatino Di Diodoro >Assignee: Marco Di Sabatino Di Diodoro >Priority: Minor > Fix For: 2.1.10, 3.0.0 > > > In some cases it is not possible to specify the message to appear in the > confirm dialog. In order to display a custom message the entire component > must be overridden. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SYNCOPE-1633) Give the possibility to add a custom message to the confirm dialog
Marco Di Sabatino Di Diodoro created SYNCOPE-1633: - Summary: Give the possibility to add a custom message to the confirm dialog Key: SYNCOPE-1633 URL: https://issues.apache.org/jira/browse/SYNCOPE-1633 Project: Syncope Issue Type: Improvement Components: console Affects Versions: 2.1.9 Reporter: Marco Di Sabatino Di Diodoro Assignee: Marco Di Sabatino Di Diodoro Fix For: 2.1.10, 3.0.0 In some cases it is not possible to specify the message to appear in the confirm dialog. In order to display a custom message the entire component must be overridden. -- This message was sent by Atlassian Jira (v8.3.4#803005)
