Re: [DISCUSS] Adjusting GitHub tags
I've got a few positive reactions on the PR, merged then got an error that "A repository cannot have more than 20 topics", so I had to remove some. Nevertheless, the new tags are on display now. Regards. On 13/09/21 07:38, Francesco Chicchiriccò wrote: Hi there, in preparation to our (hopefully upcoming) very first milestone release from master branch, I am proposing to adjust our GitHub tags as in the following PR: https://github.com/apache/syncope/pull/288 Please have a look. Regards. -- Francesco Chicchiriccò Tirasa - Open Source Excellence http://www.tirasa.net/ Member at The Apache Software Foundation Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail http://home.apache.org/~ilgrosso/
[GitHub] [syncope] ilgrosso merged pull request #288: Adjusting GitHub tags
ilgrosso merged pull request #288: URL: https://github.com/apache/syncope/pull/288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SYNCOPE-1632) Graphical issue on must change password view
[ https://issues.apache.org/jira/browse/SYNCOPE-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17416719#comment-17416719 ] ASF subversion and git services commented on SYNCOPE-1632: -- Commit d997a52e9715437c9a4c0edce269a388c77071cc in syncope's branch refs/heads/master from Andrea Patricelli [ https://gitbox.apache.org/repos/asf?p=syncope.git;h=d997a52 ] [SYNCOPE-1632] graphical adjustments to must-change-password page > Graphical issue on must change password view > > > Key: SYNCOPE-1632 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1632 > Project: Syncope > Issue Type: Bug > Components: console >Affects Versions: 3.0.0 >Reporter: Lorenzo Di Cola >Assignee: Andrea Patricelli >Priority: Minor > Fix For: 3.0.0 > > Attachments: mustChangePasswordView.png > > > * From admin user trigger must change password on user X. > * Login into Syncope Console with the user X > In this page the HTML elements need some CSS fix. Maybe CSS is not enough, > the issue can come from AdminLTE and bootstrap upgrade, so it needs some HTML > structure changes. > !mustChangePasswordView.png|width=1200! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [syncope] andrea-patricelli merged pull request #291: [SYNCOPE-1632] graphical adjustments to must-change-password page
andrea-patricelli merged pull request #291: URL: https://github.com/apache/syncope/pull/291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SYNCOPE-1632) Graphical issue on must change password view
[ https://issues.apache.org/jira/browse/SYNCOPE-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Patricelli resolved SYNCOPE-1632. Resolution: Resolved > Graphical issue on must change password view > > > Key: SYNCOPE-1632 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1632 > Project: Syncope > Issue Type: Bug > Components: console >Affects Versions: 3.0.0 >Reporter: Lorenzo Di Cola >Assignee: Andrea Patricelli >Priority: Minor > Fix For: 3.0.0 > > Attachments: mustChangePasswordView.png > > > * From admin user trigger must change password on user X. > * Login into Syncope Console with the user X > In this page the HTML elements need some CSS fix. Maybe CSS is not enough, > the issue can come from AdminLTE and bootstrap upgrade, so it needs some HTML > structure changes. > !mustChangePasswordView.png|width=1200! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SYNCOPE-1643) Update of Realm doesn't trigger provisioning for users
[ https://issues.apache.org/jira/browse/SYNCOPE-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Chicchiriccò resolved SYNCOPE-1643. - Resolution: Fixed > Update of Realm doesn't trigger provisioning for users > -- > > Key: SYNCOPE-1643 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1643 > Project: Syncope > Issue Type: Bug > Components: core >Affects Versions: 2.1.9 >Reporter: Dmitriy Brashevets >Assignee: Francesco Chicchiriccò >Priority: Major > Fix For: 2.1.10, 3.0.0 > > > When update user realm the provisioning is not triggered -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SYNCOPE-1643) Update of Realm doesn't trigger provisioning for users
[ https://issues.apache.org/jira/browse/SYNCOPE-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17416646#comment-17416646 ] ASF subversion and git services commented on SYNCOPE-1643: -- Commit 569fc1a3190f61105c81dcf773dcea4d07bbb544 in syncope's branch refs/heads/master from DmitriyBrashevets [ https://gitbox.apache.org/repos/asf?p=syncope.git;h=569fc1a ] [SYNCOPE-1643] users: set realm after having projection (#289) Signed-off-by: Dmitriy Brashevets > Update of Realm doesn't trigger provisioning for users > -- > > Key: SYNCOPE-1643 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1643 > Project: Syncope > Issue Type: Bug > Components: core >Affects Versions: 2.1.9 >Reporter: Dmitriy Brashevets >Assignee: Francesco Chicchiriccò >Priority: Major > Fix For: 2.1.10, 3.0.0 > > > When update user realm the provisioning is not triggered -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [syncope] ilgrosso commented on pull request #290: NOJIRA - Turn off bean proxying for WA; fixes typo
ilgrosso commented on pull request #290: URL: https://github.com/apache/syncope/pull/290#issuecomment-921739924 Thanks for providing these very useful background information: without knowing exactly the context, I am already taking this approach in #287 , maybe not everywhere yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SYNCOPE-1643) Update of Realm doesn't trigger provisioning for users
[ https://issues.apache.org/jira/browse/SYNCOPE-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17416636#comment-17416636 ] ASF subversion and git services commented on SYNCOPE-1643: -- Commit 7ceb056973ee9f3350eae608236ecc9f53f40721 in syncope's branch refs/heads/2_1_X from DmitriyBrashevets [ https://gitbox.apache.org/repos/asf?p=syncope.git;h=7ceb056 ] [SYNCOPE-1643] users: set realm after having projection (#289) Signed-off-by: Dmitriy Brashevets > Update of Realm doesn't trigger provisioning for users > -- > > Key: SYNCOPE-1643 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1643 > Project: Syncope > Issue Type: Bug > Components: core >Affects Versions: 2.1.9 >Reporter: Dmitriy Brashevets >Assignee: Francesco Chicchiriccò >Priority: Major > Fix For: 2.1.10, 3.0.0 > > > When update user realm the provisioning is not triggered -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [syncope] ilgrosso merged pull request #289: [SYNCOPE-1643] Chaning of user realm doesn't trigger provisioning
ilgrosso merged pull request #289: URL: https://github.com/apache/syncope/pull/289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SYNCOPE-1643) Update of Realm doesn't trigger provisioning for users
[ https://issues.apache.org/jira/browse/SYNCOPE-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Chicchiriccò updated SYNCOPE-1643: Summary: Update of Realm doesn't trigger provisioning for users (was: Update of Realm doesn't trigger provsioning for user, group or any objects) > Update of Realm doesn't trigger provisioning for users > -- > > Key: SYNCOPE-1643 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1643 > Project: Syncope > Issue Type: Bug > Components: core >Affects Versions: 2.1.9 >Reporter: Dmitriy Brashevets >Assignee: Francesco Chicchiriccò >Priority: Major > Fix For: 2.1.10, 3.0.0 > > > When update user realm the provisioning is not triggered -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SYNCOPE-1643) Update of Realm doesn't trigger provsioning for user, group or any objects
[ https://issues.apache.org/jira/browse/SYNCOPE-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Chicchiriccò reassigned SYNCOPE-1643: --- Assignee: Francesco Chicchiriccò > Update of Realm doesn't trigger provsioning for user, group or any objects > -- > > Key: SYNCOPE-1643 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1643 > Project: Syncope > Issue Type: Bug > Components: core >Affects Versions: 2.1.9 >Reporter: Dmitriy Brashevets >Assignee: Francesco Chicchiriccò >Priority: Major > Fix For: 2.1.10, 3.0.0 > > > When update user realm the provisioning is not triggered -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [syncope] DmitriyBrashevets commented on pull request #289: [SYNCOPE-1643] Chaning of user realm doesn't trigger provisioning
DmitriyBrashevets commented on pull request #289: URL: https://github.com/apache/syncope/pull/289#issuecomment-921733929 > @DmitriyBrashevets I understand that: > > 1. only moving the `setRealm()` invocation, with no further changes, fixes `UserDataBinderImpl`'s behavior > 2. no issues with `GroupDataBInderImpl` > > If these are correct, then please just apply the same change as (1) into `AnyObjectDataBinderImpl` and we should be all set, thanks. The `AnyObjectDataBinderImpl` doesn't require any changes the `setRealm()` is executed after the creation of the projection -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [syncope] DmitriyBrashevets commented on a change in pull request #289: [SYNCOPE-1643] Chaning of user realm doesn't trigger provisioning
DmitriyBrashevets commented on a change in pull request #289:
URL: https://github.com/apache/syncope/pull/289#discussion_r710981612
##
File path:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/UserDataBinderImpl.java
##
@@ -384,9 +384,6 @@ private boolean isPasswordMapped(final ExternalResource
resource) {
AnyUtils anyUtils = anyUtilsFactory.getInstance(AnyTypeKind.USER);
-// realm
Review comment:
I described in
https://github.com/apache/syncope/pull/289#issuecomment-921725709
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [syncope] ilgrosso commented on pull request #289: [SYNCOPE-1643] Chaning of user realm doesn't trigger provisioning
ilgrosso commented on pull request #289: URL: https://github.com/apache/syncope/pull/289#issuecomment-921728348 @DmitriyBrashevets I understand that: 1. only moving the `setRealm()` invocation, with no further changes, fixes `UserDataBinderImpl`'s behavior 2. no issues with `GroupDataBInderImpl` If these are correct, then please just apply the same change as (1) into `AnyObjectDataBinderImpl` and we should be all set, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [syncope] DmitriyBrashevets edited a comment on pull request #289: [SYNCOPE-1643] Chaning of user realm doesn't trigger provisioning
DmitriyBrashevets edited a comment on pull request #289: URL: https://github.com/apache/syncope/pull/289#issuecomment-921725709 > @DmitriyBrashevets please apply similar changes to `GroupDataBinderImpl` and `AnyObjectDataBinderImpl` For groups the provisioning works well when the realm is changed. If the org.apache.syncope.core.provisioning.java.data.AbstractAnyDataBinder#setRealm is executed after the before-projection is created then `org.apache.syncope.core.provisioning.java.data.AbstractAnyDataBinder#propByRes` calculates resources correctly as there may be changes in the `org.apache.syncope.common.lib.to.AttrTO` with schema "__NAME__" because of connObjectLink. This leads to a consistent behavior for UserDataBinder and GroupDataBinder. So, I'd say that moving of the execution of `org.apache.syncope.core.provisioning.java.data.AbstractAnyDataBinder#setRealm` below the creation of projections solves the issue. Please, look at: https://github.com/apache/syncope/blob/ad2523680b68e843cba35261c350521875f81945/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/GroupDataBinderImpl.java#L203 Please, tell: 1. if `org.apache.syncope.core.provisioning.java.data.AbstractAnyDataBinder.setRealm(Any, AnyPatch)` still needs to be modfied and the explicit check for the realms should be added 2. if you're fine with moving of `org.apache.syncope.core.provisioning.java.data.AbstractAnyDataBinder#setRealm` below -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [syncope] DmitriyBrashevets commented on pull request #289: [SYNCOPE-1643] Chaning of user realm doesn't trigger provisioning
DmitriyBrashevets commented on pull request #289: URL: https://github.com/apache/syncope/pull/289#issuecomment-921725709 > @DmitriyBrashevets please apply similar changes to `GroupDataBinderImpl` and `AnyObjectDataBinderImpl` For groups the provisioning works well when the realm is changed. If the org.apache.syncope.core.provisioning.java.data.AbstractAnyDataBinder#setRealm is executed after the before-projection is created then `org.apache.syncope.core.provisioning.java.data.AbstractAnyDataBinder#propByRes` calculates resources correctly as there may be changes in the `org.apache.syncope.common.lib.to.AttrTO` with schema "__NAME__" because of connObjectLink. This leads to a consistent behavior for UserDataBinder and GroupDataBinder. So, I'd say that moving of the execution of `org.apache.syncope.core.provisioning.java.data.AbstractAnyDataBinder#setRealm` below the creation of projections solves the issue. Please, look at: https://github.com/apache/syncope/blob/ad2523680b68e843cba35261c350521875f81945/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/GroupDataBinderImpl.java#L203 Please, tell: 1. if `org.apache.syncope.core.provisioning.java.data.AbstractAnyDataBinder.setRealm(Any, AnyPatch)` still needs to be modfied 2. if you're fine with moving of `org.apache.syncope.core.provisioning.java.data.AbstractAnyDataBinder#setRealm` below -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [syncope] ilgrosso commented on a change in pull request #289: [SYNCOPE-1643] Chaning of user realm doesn't trigger provisioning
ilgrosso commented on a change in pull request #289:
URL: https://github.com/apache/syncope/pull/289#discussion_r710975945
##
File path:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/UserDataBinderImpl.java
##
@@ -384,9 +384,6 @@ private boolean isPasswordMapped(final ExternalResource
resource) {
AnyUtils anyUtils = anyUtilsFactory.getInstance(AnyTypeKind.USER);
-// realm
Review comment:
why moving the `setRealm()` method invocation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [syncope] mmoayyed opened a new pull request #290: NOJIRA - Turn off bean proxying for WA; fixes typo
mmoayyed opened a new pull request #290: URL: https://github.com/apache/syncope/pull/290 This pull request turns off and disables CGLIB bean proxying for the WA module. This is the recommended practice from Spring which would help WA in the future to compile better and easier against GraalVM. Without bean proxying, bean methods can no longer call each other directly during construction, as there is no proxy to intercept. Instead, references either need to be passed as auto-wired parameters (the approach used here), or they need to be injected into configuration classes using injections. (The latter approach is generally more preferable, if the number of injected parameters grows unwieldy) Also fixes a bean name typo (missing `e`). This approach might also be used for #287 as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [syncope] ilgrosso edited a comment on pull request #289: [SYNCOPE-1643] Chaning of user realm doesn't trigger provisioning
ilgrosso edited a comment on pull request #289: URL: https://github.com/apache/syncope/pull/289#issuecomment-921680869 @DmitriyBrashevets please make the change in `org.apache.syncope.core.provisioning.java.data.AbstractAnyDataBinder.setRealm(Any, AnyPatch)` so that it applies to Users, Groups and Any Objects. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [syncope] ilgrosso edited a comment on pull request #289: [SYNCOPE-1643] Chaning of user realm doesn't trigger provisioning
ilgrosso edited a comment on pull request #289: URL: https://github.com/apache/syncope/pull/289#issuecomment-921680869 @DmitriyBrashevets please make the change in `org.apache.syncope.core.provisioning.java.data.AbstractAnyDataBinder.setRealm(Any, AnyPatch)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [syncope] ilgrosso commented on pull request #289: [SYNCOPE-1643] Chaning of user realm doesn't trigger provisioning
ilgrosso commented on pull request #289: URL: https://github.com/apache/syncope/pull/289#issuecomment-921680869 @DmitriyBrashevets please apply similar changes to `GroupDataBinderImpl` and `AnyObjectDataBinderImpl` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [syncope] ilgrosso commented on a change in pull request #289: [SYNCOPE-1643] Chaning of user realm doesn't trigger provisioning
ilgrosso commented on a change in pull request #289:
URL: https://github.com/apache/syncope/pull/289#discussion_r710932730
##
File path:
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/UserDataBinderImpl.java
##
@@ -675,6 +675,14 @@ private boolean isPasswordMapped(final ExternalResource
resource) {
collect(Collectors.toSet()));
}
+if (userPatch.getRealm() != null) {
Review comment:
please check that the patch is effectively changing the current Realm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (SYNCOPE-1643) Update of Realm doesn't trigger provsioning for user, group or any objects
[ https://issues.apache.org/jira/browse/SYNCOPE-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Chicchiriccò updated SYNCOPE-1643: Summary: Update of Realm doesn't trigger provsioning for user, group or any objects (was: Update of Realm doesn't trigger provsioning for user) > Update of Realm doesn't trigger provsioning for user, group or any objects > -- > > Key: SYNCOPE-1643 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1643 > Project: Syncope > Issue Type: Bug > Components: core >Affects Versions: 2.1.9 >Reporter: Dmitriy Brashevets >Priority: Major > > When update user realm the provisioning is not triggered -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SYNCOPE-1643) Update of Realm doesn't trigger provsioning for user, group or any objects
[ https://issues.apache.org/jira/browse/SYNCOPE-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Chicchiriccò updated SYNCOPE-1643: Fix Version/s: 3.0.0 2.1.10 > Update of Realm doesn't trigger provsioning for user, group or any objects > -- > > Key: SYNCOPE-1643 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1643 > Project: Syncope > Issue Type: Bug > Components: core >Affects Versions: 2.1.9 >Reporter: Dmitriy Brashevets >Priority: Major > Fix For: 2.1.10, 3.0.0 > > > When update user realm the provisioning is not triggered -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [syncope] DmitriyBrashevets opened a new pull request #289: [SYNCOPE-1643] Chaning of user realm doesn't trigger provisioning
DmitriyBrashevets opened a new pull request #289: URL: https://github.com/apache/syncope/pull/289 Signed-off-by: Dmitriy Brashevets -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SYNCOPE-1643) Update of Realm doesn't trigger provsioning for user
Dmitriy Brashevets created SYNCOPE-1643: --- Summary: Update of Realm doesn't trigger provsioning for user Key: SYNCOPE-1643 URL: https://issues.apache.org/jira/browse/SYNCOPE-1643 Project: Syncope Issue Type: Bug Components: core Affects Versions: 2.1.9 Reporter: Dmitriy Brashevets When update user realm the provisioning is not triggered -- This message was sent by Atlassian Jira (v8.3.4#803005)
