Re: svn access
On 10/12/2012 07:54, Jean-Baptiste Onofré wrote: Hi guys, I wanted some OSGi stuff on 1_0_X branch, but I don't have the permission for that: svn: access to '/repos/asf/!svn/ver/1418240/syncope/branches/1_0_X' forbidden It's probably due to the graduation. Is someone can take a look ? Done, now it should be working. You user was enlisted for PMC but not for committers. ...it seems infra would benefit from an IdM, isn't it? :-) Regards. -- Francesco Chicchiriccò ASF Member, Apache Syncope PMC chair, Apache Cocoon PMC Member http://people.apache.org/~ilgrosso/
[jira] [Commented] (SYNCOPE-245) Improve UserTestITCase and RoleTestITCase
[ https://issues.apache.org/jira/browse/SYNCOPE-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13527761#comment-13527761 ] Francesco Chicchiriccò commented on SYNCOPE-245: Applying your patch causes different hunks: could you please check? ilgrosso@mogano ~/work/syncope/1_0_X $ patch -p0 ~/Downloads/syncope_tests.patch patching file core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java patching file core/src/test/java/org/apache/syncope/core/rest/UserTestITCase.java Hunk #1 succeeded at 78 (offset -1 lines). Hunk #2 succeeded at 130 (offset -1 lines). Hunk #3 succeeded at 182 (offset -1 lines). Hunk #4 succeeded at 201 (offset -1 lines). Hunk #5 FAILED at 307. Hunk #6 succeeded at 318 (offset -32 lines). Hunk #7 succeeded at 379 (offset -32 lines). Hunk #8 succeeded at 420 (offset -32 lines). Hunk #9 succeeded at 525 (offset -32 lines). Hunk #10 succeeded at 1003 (offset -31 lines). Hunk #11 FAILED at 1042. Hunk #12 succeeded at 1077 (offset -31 lines). Hunk #13 succeeded at 1160 (offset -31 lines). Hunk #14 succeeded at 1479 (offset -31 lines). Hunk #15 succeeded at 1490 (offset -31 lines). Hunk #16 succeeded at 1566 (offset -31 lines). Hunk #17 succeeded at 1584 (offset -31 lines). Hunk #18 succeeded at 1614 (offset -31 lines). Hunk #19 succeeded at 1628 (offset -31 lines). Hunk #20 succeeded at 1665 (offset -31 lines). Hunk #21 succeeded at 1685 (offset -31 lines). Hunk #22 succeeded at 1785 (offset -31 lines). Hunk #23 succeeded at 1810 (offset -31 lines). Hunk #24 succeeded at 1873 (offset -31 lines). 2 out of 24 hunks FAILED -- saving rejects to file core/src/test/java/org/apache/syncope/core/rest/UserTestITCase.java.rej patching file core/src/test/java/org/apache/syncope/core/rest/TaskTestITCase.java Hunk #1 FAILED at 18. Hunk #2 succeeded at 207 (offset -2 lines). Hunk #3 succeeded at 230 (offset -2 lines). Hunk #4 succeeded at 326 (offset -2 lines). Hunk #5 succeeded at 529 (offset -2 lines). 1 out of 5 hunks FAILED -- saving rejects to file core/src/test/java/org/apache/syncope/core/rest/TaskTestITCase.java.rej patching file core/src/test/java/org/apache/syncope/core/rest/SchemaTestITCase.java patching file core/src/test/java/org/apache/syncope/core/rest/RoleTestITCase.java Hunk #1 FAILED at 18. Hunk #7 succeeded at 311 (offset -34 lines). 1 out of 7 hunks FAILED -- saving rejects to file core/src/test/java/org/apache/syncope/core/rest/RoleTestITCase.java.rej ilgrosso@mogano ~/work/syncope/1_0_X $ svn status ? core/src/test/java/org/apache/syncope/core/rest/UserTestITCase.java.orig M core/src/test/java/org/apache/syncope/core/rest/SchemaTestITCase.java ? core/src/test/java/org/apache/syncope/core/rest/TaskTestITCase.java.orig M core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java M core/src/test/java/org/apache/syncope/core/rest/UserTestITCase.java ? core/src/test/java/org/apache/syncope/core/rest/RoleTestITCase.java.orig M core/src/test/java/org/apache/syncope/core/rest/RoleTestITCase.java M core/src/test/java/org/apache/syncope/core/rest/TaskTestITCase.java Improve UserTestITCase and RoleTestITCase - Key: SYNCOPE-245 URL: https://issues.apache.org/jira/browse/SYNCOPE-245 Project: Syncope Issue Type: Improvement Affects Versions: 1.0.3-incubating, 1.1.0 Reporter: Christian Schneider Assignee: Christian Schneider Fix For: 1.1.0 Attachments: syncope_tests.patch, syncope_usertest.patch The test org.apache.syncope.core.rest.UserTestITCase has some highly repetitive code where AttributeTOs and AttributeMods are created. I created two small helper methods and was able to make the test about 150 lines smaller. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [DISCUSS] Re: Extract syncope system/integration tests into separate project
I am kind of +0 about the move of the integration tests into a separate project. Many projects like CXF and Karaf have the integration tests in a separate project. There the benefit is that the individual modules have their unit tests which run very fast and the integration tests only have to run after all modules are built. So this allows to have a little bit faster development cycle. In syncope the itests are in the core module which does not have real unit tests anyway. So I think the advantage of moving the itests out is not so big. This may change if we start creating unit tests for the the core classes. I am not so sure though how well unit tests would work there. Additionally the whole syncope build is very fast (about 3 mins) compared to more than one hour in e.g. camel. Christian On 10.12.2012 09:56, Francesco Chicchiriccò wrote: Hi all, let's try to make some order :-) The current situation is: 1. I am about to merge the DEV_ROLE_PROVISIONING branch into the trunk 2. Jan (with help from Christian) will then merge the cxf branch into the trunk and also apply some refactoring (see SYNCOPE-241 and SYNCOPE-242) by splitting the core module After (2) will have completed, we can think to discuss about additional refactoring, IMO. Now, I am not completely sure about the proposed refactoring, especially after what I expect from (2): could you please give more details about the benefits? For example, I am not sure that moving test classes and resources in separate modules (hence making such classes part of the release) is necessarily a good thing. Regards. On 10/12/2012 09:41, Andrei Shakirin wrote: Hi JB, I mean just maven module, sure :) What do you prefer as a name? a) itests b) systests Cheers, Andrei. -Original Message- From: Jean-Baptiste Onofré [mailto:j...@nanthrax.net] Sent: Sonntag, 9. Dezember 2012 20:47 To: dev@syncope.apache.org Subject: Re: Extract syncope system/integration tests into separate project Hi Andrei, by separate project, you mean a real project (with its own release cycle, artifacts, svn repo, etc), or just a Maven module ? I don't think it's a good idea to have it in a separate real project as it's coupled to the others artifacts/modules/codebase. But a itest Maven module it's a good think (it's what we have most of projects, like Karaf, ServiceMix, etc). Regards JB On 12/09/2012 07:37 PM, Andrei Shakirin wrote: Hi, I would suggest to extract integration and system tests into separate project. From my perspective it makes management of tests and build process more transparent and easy. Of course, JUnit tests will stay in corresponded projects. Does it make sense? Cheers, Andrei.
[jira] [Updated] (SYNCOPE-246) Remove collection setters in transfer objects for JAXB marshalling
[ https://issues.apache.org/jira/browse/SYNCOPE-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Chicchiriccò updated SYNCOPE-246: --- Fix Version/s: 1.1.0 Remove collection setters in transfer objects for JAXB marshalling -- Key: SYNCOPE-246 URL: https://issues.apache.org/jira/browse/SYNCOPE-246 Project: Syncope Issue Type: Bug Components: core Affects Versions: 1.1.0 Environment: CXF branch Reporter: Andrei Shakirin Assignee: Jan Bernhardt Fix For: 1.1.0 XML payload will be marshaled/unmarshaled using JAXB by migration to CXF Rest frontend. JAXB works with collections in a little bit different way as Spring Rest marshaling. JAXB uses only getter for the list (assumes that list is initialized due object creation) and adds elements into the list obtained by getter by unmarshaling. It doesn't need setter at all. The problem is that actual implementation of transfer objects doesn't work with JAXB. If TO provide setter for collection, JAXB gets the list, adds the elements and additionally calls setter for this list. As far as setter logic cleans the TO collection, the result collection is always empty. Solution is remove setters for collections in TOs by migration on CXF Rest. I find it also better from security and encapsulation aspects. Regards, Andrei. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SYNCOPE-247) Use complete UUID as role name to avoid problems by test rerun
Andrei Shakirin created SYNCOPE-247: --- Summary: Use complete UUID as role name to avoid problems by test rerun Key: SYNCOPE-247 URL: https://issues.apache.org/jira/browse/SYNCOPE-247 Project: Syncope Issue Type: Improvement Environment: CXF branch Reporter: Andrei Shakirin Assignee: Jan Bernhardt Attachments: AbstractRoleTestITCase.java.patch Actually some of Role integration tests (issue 228, crud) cannot be rerun. Reason: only 8 first characters from UUID is used as role name, that causes name collisions. Patch for the CXF branch is attached. Regards, Andrei. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SYNCOPE-247) Use complete UUID as role name to avoid problems by test rerun
[ https://issues.apache.org/jira/browse/SYNCOPE-247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Chicchiriccò updated SYNCOPE-247: --- Issue Type: Sub-task (was: Improvement) Parent: SYNCOPE-231 Use complete UUID as role name to avoid problems by test rerun -- Key: SYNCOPE-247 URL: https://issues.apache.org/jira/browse/SYNCOPE-247 Project: Syncope Issue Type: Sub-task Environment: CXF branch Reporter: Andrei Shakirin Assignee: Jan Bernhardt Attachments: AbstractRoleTestITCase.java.patch Actually some of Role integration tests (issue 228, crud) cannot be rerun. Reason: only 8 first characters from UUID is used as role name, that causes name collisions. Patch for the CXF branch is attached. Regards, Andrei. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SYNCOPE-172) Role propagation / synchronization
[ https://issues.apache.org/jira/browse/SYNCOPE-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528055#comment-13528055 ] Hudson commented on SYNCOPE-172: Integrated in Syncope-ROLE_PROVISIONING #29 (See [https://builds.apache.org/job/Syncope-ROLE_PROVISIONING/29/]) [SYNCOPE-172] Add dedicated test for role synchronization (full reconciliation) (Revision 1419558) Result = UNSTABLE ilgrosso : Files : * /syncope/branches/DEV_ROLE_PROVISIONING/core/src/main/java/org/apache/syncope/core/util/ConnObjectUtil.java * /syncope/branches/DEV_ROLE_PROVISIONING/core/src/test/java/org/apache/syncope/core/persistence/dao/TaskTest.java * /syncope/branches/DEV_ROLE_PROVISIONING/core/src/test/java/org/apache/syncope/core/rest/TaskTestITCase.java * /syncope/branches/DEV_ROLE_PROVISIONING/core/src/test/resources/content.xml Role propagation / synchronization -- Key: SYNCOPE-172 URL: https://issues.apache.org/jira/browse/SYNCOPE-172 Project: Syncope Issue Type: Sub-task Reporter: Francesco Chicchiriccò Assignee: Francesco Chicchiriccò Fix For: 1.1.0 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Syncope-CXF - Build # 11 - Still Unstable
The Apache Jenkins build system has built Syncope-CXF (build #11) Status: Still Unstable Check console output at https://builds.apache.org/job/Syncope-CXF/11/ to view the results.
Status CXF libraries in Syncope
Hi all,
I wanted to report about my progress of trying the CXF libraries (2.7.0)
in syncope. The idea is to test if we can have the cxf libs and spring
webservices at the same time. If this works we can do the migration to
cxf in several steps. If it does not work we have to do all in one go.
I added the cxf libraries below to syncope-core. At first I had a lot of
test failures until Jan hinted that the cxf libraries probably collide
with the libs of the soap connector.
So I removed the cxf libs from the lib directory of the soap connector.
After this change I had all tests except for
org.apache.syncope.core.rest.TaskTestITCase.sync() working. Does anyone
know what this test does exactly. I already understood that it uses a
csv table and a user template to kind of postprocess users. As it fails
after adding the cxf deps I assume it also does a webservice call. Can
someone give me a hint where to dig?
So assumed I get this last test working the problem with the soap
connector still remains. The way I simply removed the libs is of course
just a test to see if it works. We still have to find a proper solution
for this.
One possibility is to update the soap connector to the current cxf
version. This will probably work until we upgrade the cxf version again.
Another possibility would be to remove the libs from the connector and
rely on people adding the libs in another way. As far as I understood
the idea of the connectors is that they simply work without additional
libs so I am not sure if this is an option. I also do not yet understand
how the classloading in the connectors works. Can someone explain this?
Best regards
Christian
dependency
groupIdjavax.ws.rs/groupId
artifactIdjavax.ws.rs-api/artifactId
/dependency
dependency
groupIdorg.apache.cxf/groupId
artifactIdcxf-api/artifactId
version${cxf.version}/version
/dependency
dependency
groupIdorg.apache.cxf/groupId
artifactIdcxf-rt-frontend-jaxrs/artifactId
/dependency
dependency
groupIdorg.apache.cxf/groupId
artifactIdcxf-rt-rs-extension-providers/artifactId
/dependency
dependency
groupIdorg.apache.cxf/groupId
artifactIdcxf-rt-rs-extension-search/artifactId
/dependency
dependency
groupIdorg.apache.cxf/groupId
artifactIdcxf-rt-frontend-jaxws/artifactId
/dependency
dependency
groupIdorg.codehaus.jettison/groupId
artifactIdjettison/artifactId
version1.3.2/version
/dependency
