[jira] [Commented] (SYNCOPE-1806) Overlapping dynamic realms don't get updated
[ https://issues.apache.org/jira/browse/SYNCOPE-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823993#comment-17823993 ] ASF subversion and git services commented on SYNCOPE-1806: -- Commit 1926165c4c034daacfe11494c071d683eb6af443 in syncope's branch refs/heads/3_0_X from Francesco Chicchiriccò [ https://gitbox.apache.org/repos/asf?p=syncope.git;h=1926165c4c ] [SYNCOPE-1806] Fixing tests > Overlapping dynamic realms don't get updated > > > Key: SYNCOPE-1806 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1806 > Project: Syncope > Issue Type: Bug > Components: core >Affects Versions: 2.1.13, 3.0.6 >Reporter: federico brignola >Assignee: Francesco Chicchiriccò >Priority: Minor > Fix For: 3.0.7, 4.0.0 > > Attachments: docker-compose.yml > > > When two or more dynamic realms have overlapping conditions, Users, Groups > and AnyObjects are not added to all the matching realms but only to the first > one. > > Steps to reproduce: > # run the following docker-compose environment > # create a user "user1" with email "us...@example.com" > # create a dynamic realm "dynr1" with condition "USER Dynamic Condition > [ATTRIBUTE email NOT NULL]" > # create another dynamic realm "dynr2" with the same condition of "dynr1" > # // Check that both dynamic realms contain the user "user1" > # create a new user "user2" with email "us...@example.com" > # // Check that only the realm "dynr1" contains the user "user2" while the > other doesn't -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SYNCOPE-1806) Overlapping dynamic realms don't get updated
[ https://issues.apache.org/jira/browse/SYNCOPE-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Chicchiriccò resolved SYNCOPE-1806. - Resolution: Fixed > Overlapping dynamic realms don't get updated > > > Key: SYNCOPE-1806 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1806 > Project: Syncope > Issue Type: Bug > Components: core >Affects Versions: 2.1.13, 3.0.6 >Reporter: federico brignola >Assignee: Francesco Chicchiriccò >Priority: Minor > Fix For: 3.0.7, 4.0.0 > > Attachments: docker-compose.yml > > > When two or more dynamic realms have overlapping conditions, Users, Groups > and AnyObjects are not added to all the matching realms but only to the first > one. > > Steps to reproduce: > # run the following docker-compose environment > # create a user "user1" with email "us...@example.com" > # create a dynamic realm "dynr1" with condition "USER Dynamic Condition > [ATTRIBUTE email NOT NULL]" > # create another dynamic realm "dynr2" with the same condition of "dynr1" > # // Check that both dynamic realms contain the user "user1" > # create a new user "user2" with email "us...@example.com" > # // Check that only the realm "dynr1" contains the user "user2" while the > other doesn't -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SYNCOPE-1806) Overlapping dynamic realms don't get updated
[ https://issues.apache.org/jira/browse/SYNCOPE-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823996#comment-17823996 ] ASF subversion and git services commented on SYNCOPE-1806: -- Commit cfc59b624af78cb07d10cfec67747bec90f9907c in syncope's branch refs/heads/master from Francesco Chicchiriccò [ https://gitbox.apache.org/repos/asf?p=syncope.git;h=cfc59b624a ] [SYNCOPE-1806] Fixing tests > Overlapping dynamic realms don't get updated > > > Key: SYNCOPE-1806 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1806 > Project: Syncope > Issue Type: Bug > Components: core >Affects Versions: 2.1.13, 3.0.6 >Reporter: federico brignola >Assignee: Francesco Chicchiriccò >Priority: Minor > Fix For: 3.0.7, 4.0.0 > > Attachments: docker-compose.yml > > > When two or more dynamic realms have overlapping conditions, Users, Groups > and AnyObjects are not added to all the matching realms but only to the first > one. > > Steps to reproduce: > # run the following docker-compose environment > # create a user "user1" with email "us...@example.com" > # create a dynamic realm "dynr1" with condition "USER Dynamic Condition > [ATTRIBUTE email NOT NULL]" > # create another dynamic realm "dynr2" with the same condition of "dynr1" > # // Check that both dynamic realms contain the user "user1" > # create a new user "user2" with email "us...@example.com" > # // Check that only the realm "dynr1" contains the user "user2" while the > other doesn't -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SYNCOPE-1806) Overlapping dynamic realms don't get updated
[ https://issues.apache.org/jira/browse/SYNCOPE-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823965#comment-17823965 ] ASF subversion and git services commented on SYNCOPE-1806: -- Commit b67cfff546ffdf3233460789e3343410161d77b3 in syncope's branch refs/heads/3_0_X from Francesco Chicchiriccò [ https://gitbox.apache.org/repos/asf?p=syncope.git;h=b67cfff546 ] [SYNCOPE-1806] Fixing all dynamic memberships refresh: Realms, Groups and Roles > Overlapping dynamic realms don't get updated > > > Key: SYNCOPE-1806 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1806 > Project: Syncope > Issue Type: Bug > Components: core >Affects Versions: 2.1.13, 3.0.6 >Reporter: federico brignola >Assignee: Francesco Chicchiriccò >Priority: Minor > Fix For: 3.0.7, 4.0.0 > > Attachments: docker-compose.yml > > > When two or more dynamic realms have overlapping conditions, Users, Groups > and AnyObjects are not added to all the matching realms but only to the first > one. > > Steps to reproduce: > # run the following docker-compose environment > # create a user "user1" with email "us...@example.com" > # create a dynamic realm "dynr1" with condition "USER Dynamic Condition > [ATTRIBUTE email NOT NULL]" > # create another dynamic realm "dynr2" with the same condition of "dynr1" > # // Check that both dynamic realms contain the user "user1" > # create a new user "user2" with email "us...@example.com" > # // Check that only the realm "dynr1" contains the user "user2" while the > other doesn't -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [SYNCOPE-1809] Remove uidOnCreate attribute on delete propagation [syncope]
ilgrosso commented on code in PR #640:
URL: https://github.com/apache/syncope/pull/640#discussion_r1514685072
##
fit/core-reference/src/test/java/org/apache/syncope/fit/core/UserIssuesITCase.java:
##
@@ -1634,4 +1640,72 @@ public void issueSYNCOPE1793() {
resource(RESOURCE_NAME_NOPROPAGATION).action(ResourceAssociationAction.ASSIGN).build());
assertEquals(Response.Status.OK.getStatusCode(), response.getStatus());
}
+
+@Test
+public void issue1809() throws IOException {
Review Comment:
this should be named `issueSYNCOPE1809` (see others)
##
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/propagation/AbstractPropagationTaskExecutor.java:
##
@@ -383,6 +383,20 @@ protected Uid delete(
connector.delete(objectClass, uid, null, propagationAttempted);
result = uid;
+// SYNCOPE-1809 remove uidOnCreate attribute, if any
Review Comment:
are such comments really needed? We've got `git blame`
##
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/propagation/AbstractPropagationTaskExecutor.java:
##
@@ -383,6 +383,20 @@ protected Uid delete(
connector.delete(objectClass, uid, null, propagationAttempted);
result = uid;
+// SYNCOPE-1809 remove uidOnCreate attribute, if any
+taskInfo.getResource()
+.getProvisionByAnyType(taskInfo.getAnyType())
+.filter(provision -> provision.getUidOnCreate() != null)
+.ifPresent(provision -> {
+LOG.debug("Removing uidOnCreate [{}] attribute from
[{}] on delete",
Review Comment:
either remove this logging statement or add it for the other case when
`getUidOnCreate()` is used in this class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] [SYNCOPE-1809] Remove uidOnCreate attribute on delete propagation [syncope]
andrea-patricelli opened a new pull request, #640: URL: https://github.com/apache/syncope/pull/640 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SYNCOPE-1809] Remove uidOnCreate attribute on delete propagation [syncope]
andrea-patricelli commented on code in PR #640:
URL: https://github.com/apache/syncope/pull/640#discussion_r1514744013
##
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/propagation/AbstractPropagationTaskExecutor.java:
##
@@ -383,6 +383,20 @@ protected Uid delete(
connector.delete(objectClass, uid, null, propagationAttempted);
result = uid;
+// SYNCOPE-1809 remove uidOnCreate attribute, if any
+taskInfo.getResource()
+.getProvisionByAnyType(taskInfo.getAnyType())
+.filter(provision -> provision.getUidOnCreate() != null)
+.ifPresent(provision -> {
+LOG.debug("Removing uidOnCreate [{}] attribute from
[{}] on delete",
Review Comment:
Added logging also in the other section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [SYNCOPE-1809] Remove uidOnCreate attribute on delete propagation [syncope]
andrea-patricelli merged PR #640: URL: https://github.com/apache/syncope/pull/640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SYNCOPE-1809) Cleanup of uid-on-create attribute on resource unassignment
[ https://issues.apache.org/jira/browse/SYNCOPE-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824101#comment-17824101 ] ASF subversion and git services commented on SYNCOPE-1809: -- Commit 55e7ed9224177051030ca45147d2435367699953 in syncope's branch refs/heads/3_0_X from Andrea Patricelli [ https://gitbox.apache.org/repos/asf?p=syncope.git;h=55e7ed9224 ] [SYNCOPE-1809] Remove uidOnCreate attribute on delete propagation (#640) * [SYNCOPE-1809] Remove uidOnCreate attribute on delete propagation > Cleanup of uid-on-create attribute on resource unassignment > --- > > Key: SYNCOPE-1809 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1809 > Project: Syncope > Issue Type: Improvement > Components: core >Affects Versions: 3.0.6 >Reporter: Andrea Patricelli >Assignee: Andrea Patricelli >Priority: Major > Fix For: 3.0.7, 4.0.0 > > > Suppose to have an external resource that generates ids on its side and you > should set for a specific mapping the "Schema to hold values for identifiers > generated upon Create by the external Identity Store" with a specific plain > attribute name, i.e. "uid on create". > When that resource is unassigned from the user, group or any object, that > attribute value should be cleared to guarantee consistency in future > assignments of the same resource and to cleanup all info related to the > removed resource. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [SYNCOPE-1809] Remove uidOnCreate attribute on delete propagation [syncope]
andrea-patricelli commented on code in PR #640: URL: https://github.com/apache/syncope/pull/640#discussion_r1514722405 ## core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/propagation/AbstractPropagationTaskExecutor.java: ## @@ -383,6 +383,20 @@ protected Uid delete( connector.delete(objectClass, uid, null, propagationAttempted); result = uid; +// SYNCOPE-1809 remove uidOnCreate attribute, if any Review Comment: No, going to remove. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (SYNCOPE-1806) Overlapping dynamic realms don't get updated
[ https://issues.apache.org/jira/browse/SYNCOPE-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Chicchiriccò reassigned SYNCOPE-1806: --- Assignee: Francesco Chicchiriccò > Overlapping dynamic realms don't get updated > > > Key: SYNCOPE-1806 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1806 > Project: Syncope > Issue Type: Bug > Components: core >Affects Versions: 2.1.13, 3.0.6 >Reporter: federico brignola >Assignee: Francesco Chicchiriccò >Priority: Minor > Fix For: 3.0.7, 4.0.0 > > Attachments: docker-compose.yml > > > When two or more dynamic realms have overlapping conditions, Users, Groups > and AnyObjects are not added to all the matching realms but only to the first > one. > > Steps to reproduce: > # run the following docker-compose environment > # create a user "user1" with email "us...@example.com" > # create a dynamic realm "dynr1" with condition "USER Dynamic Condition > [ATTRIBUTE email NOT NULL]" > # create another dynamic realm "dynr2" with the same condition of "dynr1" > # // Check that both dynamic realms contain the user "user1" > # create a new user "user2" with email "us...@example.com" > # // Check that only the realm "dynr1" contains the user "user2" while the > other doesn't -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SYNCOPE-1809) Cleanup of uid-on-create attribute on resource unassignment
Andrea Patricelli created SYNCOPE-1809: -- Summary: Cleanup of uid-on-create attribute on resource unassignment Key: SYNCOPE-1809 URL: https://issues.apache.org/jira/browse/SYNCOPE-1809 Project: Syncope Issue Type: Improvement Components: core Affects Versions: 3.0.6 Reporter: Andrea Patricelli Assignee: Andrea Patricelli Fix For: 3.0.7, 4.0.0 Suppose to have an external resource that generates ids on its side and you should set for a specific mapping the "Schema to hold values for identifiers generated upon Create by the external Identity Store" with a specific plain attribute name, i.e. "uid on create". When that resource is unassigned from the user, group or any object, that attribute value should be cleared to guarantee consistency in future assignments of the same resource and to cleanup all info related to the removed resource. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SYNCOPE-1806) Overlapping dynamic realms don't get updated
[ https://issues.apache.org/jira/browse/SYNCOPE-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823940#comment-17823940 ] ASF subversion and git services commented on SYNCOPE-1806: -- Commit 5145c09af48a2f6422c031b0b91e3dcd5fe4cac3 in syncope's branch refs/heads/master from Francesco Chicchiriccò [ https://gitbox.apache.org/repos/asf?p=syncope.git;h=5145c09af4 ] [SYNCOPE-1806] Fixing all dynamic memberships refresh: Realms, Groups and Roles > Overlapping dynamic realms don't get updated > > > Key: SYNCOPE-1806 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1806 > Project: Syncope > Issue Type: Bug > Components: core >Affects Versions: 2.1.13, 3.0.6 >Reporter: federico brignola >Assignee: Francesco Chicchiriccò >Priority: Minor > Fix For: 3.0.7, 4.0.0 > > Attachments: docker-compose.yml > > > When two or more dynamic realms have overlapping conditions, Users, Groups > and AnyObjects are not added to all the matching realms but only to the first > one. > > Steps to reproduce: > # run the following docker-compose environment > # create a user "user1" with email "us...@example.com" > # create a dynamic realm "dynr1" with condition "USER Dynamic Condition > [ATTRIBUTE email NOT NULL]" > # create another dynamic realm "dynr2" with the same condition of "dynr1" > # // Check that both dynamic realms contain the user "user1" > # create a new user "user2" with email "us...@example.com" > # // Check that only the realm "dynr1" contains the user "user2" while the > other doesn't -- This message was sent by Atlassian Jira (v8.20.10#820010)
