[jira] [Commented] (SYNCOPE-654) Some generic and uninformative error messages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14494166#comment-14494166
 ] 

ASF GitHub Bot commented on SYNCOPE-654:


GitHub user giacomolm opened a pull request:

https://github.com/apache/syncope/pull/3

[SYNCOPE-654] JPA error messages and Syncope client exceptions are corre...

...ctly displayed

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/giacomolm/syncope 1_2_X

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/syncope/pull/3.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3


commit c040d9e4e475ed6741aa6575bca0b94acfc5ae88
Author: giacomolm giacom...@hotmail.it
Date:   2015-04-14T14:33:45Z

[SYNCOPE-654] JPA error messages and Syncope client exceptions are 
correctly displayed




 Some generic and uninformative error messages
 -

 Key: SYNCOPE-654
 URL: https://issues.apache.org/jira/browse/SYNCOPE-654
 Project: Syncope
  Issue Type: Bug
  Components: core
Affects Versions: 1.2.3
Reporter: Francesco Chicchiriccò
Assignee: Giacomo Lamonaco
 Fix For: 1.2.4, 2.0.0


 Under some circumstances, the error message reported is not very informative; 
 try, for example, to
  # define a user or role schema with unique flag
  # create first user (or group) with certain value for such a schema
  # attempt to create another user (or group) with same value
  # error is raised (correctly) but message says DataIntegrityViolation [The 
 transaction has been rolled back. See the nested exceptions for details on 
 the errors that occurred.]
 Besides this specific case, more tests should be added to check at least 
 every case managed by {{RestServiceExceptionMapper}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-660) Extend control over asynchronous job execution

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564404#comment-14564404
 ] 

ASF GitHub Bot commented on SYNCOPE-660:


Github user ilgrosso commented on the pull request:

https://github.com/apache/syncope/pull/6#issuecomment-106742950
  
LGTM: please go ahead and merge


 Extend control over asynchronous job execution
 --

 Key: SYNCOPE-660
 URL: https://issues.apache.org/jira/browse/SYNCOPE-660
 Project: Syncope
  Issue Type: Improvement
Reporter: Francesco Chicchiriccò
Assignee: Giacomo Lamonaco
 Fix For: 1.2.5, 2.0.0


 Asynchronous job execution, generally delegated to Quartz, can currently be 
 checked only at completion, and only by indirectly checking the status on 
 related JPA entities (TaskExec, ReportExec, ...).
 A REST endpoint should be provided for reporting on jobs execution and 
 providing the ability to control (e.g. stop / pause / resume / ...) .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-660) Extend control over asynchronous job execution

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564491#comment-14564491
 ] 

ASF GitHub Bot commented on SYNCOPE-660:


Github user asfgit closed the pull request at:

https://github.com/apache/syncope/pull/6


 Extend control over asynchronous job execution
 --

 Key: SYNCOPE-660
 URL: https://issues.apache.org/jira/browse/SYNCOPE-660
 Project: Syncope
  Issue Type: Improvement
Reporter: Francesco Chicchiriccò
Assignee: Giacomo Lamonaco
 Fix For: 1.2.5, 2.0.0


 Asynchronous job execution, generally delegated to Quartz, can currently be 
 checked only at completion, and only by indirectly checking the status on 
 related JPA entities (TaskExec, ReportExec, ...).
 A REST endpoint should be provided for reporting on jobs execution and 
 providing the ability to control (e.g. stop / pause / resume / ...) .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-660) Extend control over asynchronous job execution

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563093#comment-14563093
 ] 

ASF GitHub Bot commented on SYNCOPE-660:


GitHub user giacomolm opened a pull request:

https://github.com/apache/syncope/pull/6

[SYNCOPE-660] Added console utilities for runtime task management



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/giacomolm/syncope 1_2_X

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/syncope/pull/6.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6


commit cdac2a5e277d3b61b1d2a739494869ca72f52695
Author: giacomolm giacom...@hotmail.it
Date:   2015-05-28T15:27:12Z

[SYNCOPE-660] Added console utilities for runtime task management

commit 6408db5bdc853f31d91d81e0593353e99e3d1f0c
Author: giacomolm giacom...@hotmail.it
Date:   2015-05-28T15:27:44Z

Merge branch '1_2_X' of https://github.com/apache/syncope into 1_2_X




 Extend control over asynchronous job execution
 --

 Key: SYNCOPE-660
 URL: https://issues.apache.org/jira/browse/SYNCOPE-660
 Project: Syncope
  Issue Type: Improvement
Reporter: Francesco Chicchiriccò
Assignee: Giacomo Lamonaco
 Fix For: 1.2.5, 2.0.0


 Asynchronous job execution, generally delegated to Quartz, can currently be 
 checked only at completion, and only by indirectly checking the status on 
 related JPA entities (TaskExec, ReportExec, ...).
 A REST endpoint should be provided for reporting on jobs execution and 
 providing the ability to control (e.g. stop / pause / resume / ...) .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-660) Extend control over asynchronous job execution

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563101#comment-14563101
 ] 

ASF GitHub Bot commented on SYNCOPE-660:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/6#discussion_r31246416
  
--- Diff: 
console/src/main/java/org/apache/syncope/console/pages/panels/RuntimePanel.java 
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.syncope.console.pages.panels;
+
+import org.apache.syncope.console.rest.JobRestClient;
+import 
org.apache.syncope.console.wicket.ajax.markup.html.ClearIndicatingAjaxLink;
+import org.apache.wicket.PageReference;
+import org.apache.wicket.ajax.AbstractAjaxTimerBehavior;
+import org.apache.wicket.ajax.AjaxRequestTarget;
+import org.apache.wicket.markup.html.panel.Fragment;
+import org.apache.wicket.model.IModel;
+import org.apache.wicket.markup.html.panel.Panel;
+
+public class RuntimePanel extends Panel {
+
+private static final long serialVersionUID = 1L;
--- End diff --

Please generate this.


 Extend control over asynchronous job execution
 --

 Key: SYNCOPE-660
 URL: https://issues.apache.org/jira/browse/SYNCOPE-660
 Project: Syncope
  Issue Type: Improvement
Reporter: Francesco Chicchiriccò
Assignee: Giacomo Lamonaco
 Fix For: 1.2.5, 2.0.0


 Asynchronous job execution, generally delegated to Quartz, can currently be 
 checked only at completion, and only by indirectly checking the status on 
 related JPA entities (TaskExec, ReportExec, ...).
 A REST endpoint should be provided for reporting on jobs execution and 
 providing the ability to control (e.g. stop / pause / resume / ...) .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-660) Extend control over asynchronous job execution

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563104#comment-14563104
 ] 

ASF GitHub Bot commented on SYNCOPE-660:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/6#discussion_r31246542
  
--- Diff: 
console/src/main/java/org/apache/syncope/console/pages/panels/RuntimePanel.java 
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.syncope.console.pages.panels;
+
+import org.apache.syncope.console.rest.JobRestClient;
+import 
org.apache.syncope.console.wicket.ajax.markup.html.ClearIndicatingAjaxLink;
+import org.apache.wicket.PageReference;
+import org.apache.wicket.ajax.AbstractAjaxTimerBehavior;
+import org.apache.wicket.ajax.AjaxRequestTarget;
+import org.apache.wicket.markup.html.panel.Fragment;
+import org.apache.wicket.model.IModel;
+import org.apache.wicket.markup.html.panel.Panel;
+
+public class RuntimePanel extends Panel {
+
+private static final long serialVersionUID = 1L;
+
+private boolean latestStatus;
+
+protected Fragment fragmentStop, fragmentSpinner;
+
+public AbstractAjaxTimerBehavior timer;
+
+final PageReference pageRef;
+
+private final long jobId;
+
+private final JobRestClient jobRestClient;
+
+public RuntimePanel(final String componentId, final IModel? model, 
final PageReference pageRef, final long jobId,
+final JobRestClient jobRestClient) {
+super(componentId, model);
+this.pageRef = pageRef;
+this.jobId = jobId;
+this.jobRestClient = jobRestClient;
+latestStatus = false;
+this.refresh();
--- End diff --

Non-final method called in constructor?


 Extend control over asynchronous job execution
 --

 Key: SYNCOPE-660
 URL: https://issues.apache.org/jira/browse/SYNCOPE-660
 Project: Syncope
  Issue Type: Improvement
Reporter: Francesco Chicchiriccò
Assignee: Giacomo Lamonaco
 Fix For: 1.2.5, 2.0.0


 Asynchronous job execution, generally delegated to Quartz, can currently be 
 checked only at completion, and only by indirectly checking the status on 
 related JPA entities (TaskExec, ReportExec, ...).
 A REST endpoint should be provided for reporting on jobs execution and 
 providing the ability to control (e.g. stop / pause / resume / ...) .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-660) Extend control over asynchronous job execution

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563114#comment-14563114
 ] 

ASF GitHub Bot commented on SYNCOPE-660:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/6#discussion_r31246817
  
--- Diff: 
console/src/main/java/org/apache/syncope/console/rest/JobRestClient.java ---
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.syncope.console.rest;
+
+import org.springframework.stereotype.Component;
+
+@Component
+public abstract class JobRestClient extends BaseRestClient{
+
+public abstract boolean isJobRunning(final long reportId);
--- End diff --

`reportId` or `taskId`? Just put `id`


 Extend control over asynchronous job execution
 --

 Key: SYNCOPE-660
 URL: https://issues.apache.org/jira/browse/SYNCOPE-660
 Project: Syncope
  Issue Type: Improvement
Reporter: Francesco Chicchiriccò
Assignee: Giacomo Lamonaco
 Fix For: 1.2.5, 2.0.0


 Asynchronous job execution, generally delegated to Quartz, can currently be 
 checked only at completion, and only by indirectly checking the status on 
 related JPA entities (TaskExec, ReportExec, ...).
 A REST endpoint should be provided for reporting on jobs execution and 
 providing the ability to control (e.g. stop / pause / resume / ...) .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-660) Extend control over asynchronous job execution

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563116#comment-14563116
 ] 

ASF GitHub Bot commented on SYNCOPE-660:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/6#discussion_r31246879
  
--- Diff: 
console/src/main/java/org/apache/syncope/console/rest/ReportRestClient.java ---
@@ -105,4 +108,24 @@ public void deleteExecution(final long reportExecId) {
 public Response exportExecutionResult(final Long executionId, final 
ReportExecExportFormat fmt) {
 return 
getService(ReportService.class).exportExecutionResult(executionId, fmt);
 }
+
+@Override
+public boolean isJobRunning(final long reportId) {
+for (ReportExecTO reportExecTO : 
getService(ReportService.class).listJobs(JobStatusType.RUNNING)) {
+if (reportExecTO.getReport() == reportId) {
+return true;
+}
+}
+return false;
+}
+
+@Override
+public void startJob(final long taskId) {
+getService(ReportService.class).actionJob(taskId, JobAction.START);
+}
+
+@Override
+public void stopJob(final long taskId) {
--- End diff --

reportId


 Extend control over asynchronous job execution
 --

 Key: SYNCOPE-660
 URL: https://issues.apache.org/jira/browse/SYNCOPE-660
 Project: Syncope
  Issue Type: Improvement
Reporter: Francesco Chicchiriccò
Assignee: Giacomo Lamonaco
 Fix For: 1.2.5, 2.0.0


 Asynchronous job execution, generally delegated to Quartz, can currently be 
 checked only at completion, and only by indirectly checking the status on 
 related JPA entities (TaskExec, ReportExec, ...).
 A REST endpoint should be provided for reporting on jobs execution and 
 providing the ability to control (e.g. stop / pause / resume / ...) .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-660) Extend control over asynchronous job execution

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563121#comment-14563121
 ] 

ASF GitHub Bot commented on SYNCOPE-660:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/6#discussion_r31247288
  
--- Diff: 
core/src/main/java/org/apache/syncope/core/rest/controller/AbstractJobController.java
 ---
@@ -158,7 +158,19 @@ protected void actionJob(final String jobName, final 
JobAction action) {
 if (scheduler.getScheduler().checkExists(jobKey)) {
 switch (action) {
 case START:
-scheduler.getScheduler().triggerJob(jobKey);
+Long currentId = getIdFromJobName(jobKey);
+boolean found = false;
+//Two or more equals jobs cannot be executed 
concurrently
+for (JobExecutionContext jec : 
scheduler.getScheduler().getCurrentlyExecutingJobs()) {
--- End diff --

Please use plain `for` with `found` as guard, thus avoiding `break`.


 Extend control over asynchronous job execution
 --

 Key: SYNCOPE-660
 URL: https://issues.apache.org/jira/browse/SYNCOPE-660
 Project: Syncope
  Issue Type: Improvement
Reporter: Francesco Chicchiriccò
Assignee: Giacomo Lamonaco
 Fix For: 1.2.5, 2.0.0


 Asynchronous job execution, generally delegated to Quartz, can currently be 
 checked only at completion, and only by indirectly checking the status on 
 related JPA entities (TaskExec, ReportExec, ...).
 A REST endpoint should be provided for reporting on jobs execution and 
 providing the ability to control (e.g. stop / pause / resume / ...) .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-660) Extend control over asynchronous job execution

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563105#comment-14563105
 ] 

ASF GitHub Bot commented on SYNCOPE-660:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/6#discussion_r31246599
  
--- Diff: 
console/src/main/java/org/apache/syncope/console/pages/panels/RuntimePanel.java 
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.syncope.console.pages.panels;
+
+import org.apache.syncope.console.rest.JobRestClient;
+import 
org.apache.syncope.console.wicket.ajax.markup.html.ClearIndicatingAjaxLink;
+import org.apache.wicket.PageReference;
+import org.apache.wicket.ajax.AbstractAjaxTimerBehavior;
+import org.apache.wicket.ajax.AjaxRequestTarget;
+import org.apache.wicket.markup.html.panel.Fragment;
+import org.apache.wicket.model.IModel;
+import org.apache.wicket.markup.html.panel.Panel;
+
+public class RuntimePanel extends Panel {
+
+private static final long serialVersionUID = 1L;
+
+private boolean latestStatus;
+
+protected Fragment fragmentStop, fragmentSpinner;
+
+public AbstractAjaxTimerBehavior timer;
+
+final PageReference pageRef;
+
+private final long jobId;
+
+private final JobRestClient jobRestClient;
+
+public RuntimePanel(final String componentId, final IModel? model, 
final PageReference pageRef, final long jobId,
+final JobRestClient jobRestClient) {
+super(componentId, model);
+this.pageRef = pageRef;
+this.jobId = jobId;
+this.jobRestClient = jobRestClient;
+latestStatus = false;
+this.refresh();
+
+}
+
+public void refresh() {
+boolean currentStatus = jobRestClient.isJobRunning(jobId);
+if (currentStatus == true  latestStatus == false) {
+setRunning();
+} else if (currentStatus == false) {
+setNotRunning();
+}
+
+latestStatus = currentStatus;
+
--- End diff --

Empty line


 Extend control over asynchronous job execution
 --

 Key: SYNCOPE-660
 URL: https://issues.apache.org/jira/browse/SYNCOPE-660
 Project: Syncope
  Issue Type: Improvement
Reporter: Francesco Chicchiriccò
Assignee: Giacomo Lamonaco
 Fix For: 1.2.5, 2.0.0


 Asynchronous job execution, generally delegated to Quartz, can currently be 
 checked only at completion, and only by indirectly checking the status on 
 related JPA entities (TaskExec, ReportExec, ...).
 A REST endpoint should be provided for reporting on jobs execution and 
 providing the ability to control (e.g. stop / pause / resume / ...) .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-660) Extend control over asynchronous job execution

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563109#comment-14563109
 ] 

ASF GitHub Bot commented on SYNCOPE-660:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/6#discussion_r31246708
  
--- Diff: 
console/src/main/java/org/apache/syncope/console/pages/panels/RuntimePanel.java 
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.syncope.console.pages.panels;
+
+import org.apache.syncope.console.rest.JobRestClient;
+import 
org.apache.syncope.console.wicket.ajax.markup.html.ClearIndicatingAjaxLink;
+import org.apache.wicket.PageReference;
+import org.apache.wicket.ajax.AbstractAjaxTimerBehavior;
+import org.apache.wicket.ajax.AjaxRequestTarget;
+import org.apache.wicket.markup.html.panel.Fragment;
+import org.apache.wicket.model.IModel;
+import org.apache.wicket.markup.html.panel.Panel;
+
+public class RuntimePanel extends Panel {
+
+private static final long serialVersionUID = 1L;
+
+private boolean latestStatus;
+
+protected Fragment fragmentStop, fragmentSpinner;
+
+public AbstractAjaxTimerBehavior timer;
+
+final PageReference pageRef;
+
+private final long jobId;
+
+private final JobRestClient jobRestClient;
+
+public RuntimePanel(final String componentId, final IModel? model, 
final PageReference pageRef, final long jobId,
+final JobRestClient jobRestClient) {
+super(componentId, model);
+this.pageRef = pageRef;
+this.jobId = jobId;
+this.jobRestClient = jobRestClient;
+latestStatus = false;
+this.refresh();
+
+}
+
+public void refresh() {
+boolean currentStatus = jobRestClient.isJobRunning(jobId);
+if (currentStatus == true  latestStatus == false) {
--- End diff --

Please rewrite this as `if (currentStatus  !latestStatus)`...


 Extend control over asynchronous job execution
 --

 Key: SYNCOPE-660
 URL: https://issues.apache.org/jira/browse/SYNCOPE-660
 Project: Syncope
  Issue Type: Improvement
Reporter: Francesco Chicchiriccò
Assignee: Giacomo Lamonaco
 Fix For: 1.2.5, 2.0.0


 Asynchronous job execution, generally delegated to Quartz, can currently be 
 checked only at completion, and only by indirectly checking the status on 
 related JPA entities (TaskExec, ReportExec, ...).
 A REST endpoint should be provided for reporting on jobs execution and 
 providing the ability to control (e.g. stop / pause / resume / ...) .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-660) Extend control over asynchronous job execution

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563102#comment-14563102
 ] 

ASF GitHub Bot commented on SYNCOPE-660:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/6#discussion_r31246454
  
--- Diff: 
console/src/main/java/org/apache/syncope/console/pages/panels/RuntimePanel.java 
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.syncope.console.pages.panels;
+
+import org.apache.syncope.console.rest.JobRestClient;
+import 
org.apache.syncope.console.wicket.ajax.markup.html.ClearIndicatingAjaxLink;
+import org.apache.wicket.PageReference;
+import org.apache.wicket.ajax.AbstractAjaxTimerBehavior;
+import org.apache.wicket.ajax.AjaxRequestTarget;
+import org.apache.wicket.markup.html.panel.Fragment;
+import org.apache.wicket.model.IModel;
+import org.apache.wicket.markup.html.panel.Panel;
+
+public class RuntimePanel extends Panel {
+
+private static final long serialVersionUID = 1L;
+
+private boolean latestStatus;
+
+protected Fragment fragmentStop, fragmentSpinner;
+
+public AbstractAjaxTimerBehavior timer;
+
+final PageReference pageRef;
--- End diff --

please set scope (private?)


 Extend control over asynchronous job execution
 --

 Key: SYNCOPE-660
 URL: https://issues.apache.org/jira/browse/SYNCOPE-660
 Project: Syncope
  Issue Type: Improvement
Reporter: Francesco Chicchiriccò
Assignee: Giacomo Lamonaco
 Fix For: 1.2.5, 2.0.0


 Asynchronous job execution, generally delegated to Quartz, can currently be 
 checked only at completion, and only by indirectly checking the status on 
 related JPA entities (TaskExec, ReportExec, ...).
 A REST endpoint should be provided for reporting on jobs execution and 
 providing the ability to control (e.g. stop / pause / resume / ...) .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-660) Extend control over asynchronous job execution

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563106#comment-14563106
 ] 

ASF GitHub Bot commented on SYNCOPE-660:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/6#discussion_r31246625
  
--- Diff: 
console/src/main/java/org/apache/syncope/console/pages/panels/RuntimePanel.java 
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.syncope.console.pages.panels;
+
+import org.apache.syncope.console.rest.JobRestClient;
+import 
org.apache.syncope.console.wicket.ajax.markup.html.ClearIndicatingAjaxLink;
+import org.apache.wicket.PageReference;
+import org.apache.wicket.ajax.AbstractAjaxTimerBehavior;
+import org.apache.wicket.ajax.AjaxRequestTarget;
+import org.apache.wicket.markup.html.panel.Fragment;
+import org.apache.wicket.model.IModel;
+import org.apache.wicket.markup.html.panel.Panel;
+
+public class RuntimePanel extends Panel {
+
+private static final long serialVersionUID = 1L;
+
+private boolean latestStatus;
+
+protected Fragment fragmentStop, fragmentSpinner;
+
+public AbstractAjaxTimerBehavior timer;
+
+final PageReference pageRef;
+
+private final long jobId;
+
+private final JobRestClient jobRestClient;
+
+public RuntimePanel(final String componentId, final IModel? model, 
final PageReference pageRef, final long jobId,
+final JobRestClient jobRestClient) {
+super(componentId, model);
+this.pageRef = pageRef;
+this.jobId = jobId;
+this.jobRestClient = jobRestClient;
+latestStatus = false;
+this.refresh();
+
+}
+
+public void refresh() {
+boolean currentStatus = jobRestClient.isJobRunning(jobId);
+if (currentStatus == true  latestStatus == false) {
+setRunning();
+} else if (currentStatus == false) {
+setNotRunning();
+}
+
+latestStatus = currentStatus;
+
+}
+
+public void setRunning() {
+fragmentStop = new Fragment(panelStop, fragmentStop, this);
+fragmentStop.addOrReplace(new 
ClearIndicatingAjaxLinkVoid(stopLink, pageRef) {
+
+private static final long serialVersionUID = 
-7978723352517770644L;
+
+@Override
+protected void onClickInternal(final AjaxRequestTarget target) 
{
+
--- End diff --

Empty line


 Extend control over asynchronous job execution
 --

 Key: SYNCOPE-660
 URL: https://issues.apache.org/jira/browse/SYNCOPE-660
 Project: Syncope
  Issue Type: Improvement
Reporter: Francesco Chicchiriccò
Assignee: Giacomo Lamonaco
 Fix For: 1.2.5, 2.0.0


 Asynchronous job execution, generally delegated to Quartz, can currently be 
 checked only at completion, and only by indirectly checking the status on 
 related JPA entities (TaskExec, ReportExec, ...).
 A REST endpoint should be provided for reporting on jobs execution and 
 providing the ability to control (e.g. stop / pause / resume / ...) .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-660) Extend control over asynchronous job execution

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563115#comment-14563115
 ] 

ASF GitHub Bot commented on SYNCOPE-660:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/6#discussion_r31246859
  
--- Diff: 
console/src/main/java/org/apache/syncope/console/rest/ReportRestClient.java ---
@@ -105,4 +108,24 @@ public void deleteExecution(final long reportExecId) {
 public Response exportExecutionResult(final Long executionId, final 
ReportExecExportFormat fmt) {
 return 
getService(ReportService.class).exportExecutionResult(executionId, fmt);
 }
+
+@Override
+public boolean isJobRunning(final long reportId) {
+for (ReportExecTO reportExecTO : 
getService(ReportService.class).listJobs(JobStatusType.RUNNING)) {
+if (reportExecTO.getReport() == reportId) {
+return true;
+}
+}
+return false;
+}
+
+@Override
+public void startJob(final long taskId) {
--- End diff --

reportId


 Extend control over asynchronous job execution
 --

 Key: SYNCOPE-660
 URL: https://issues.apache.org/jira/browse/SYNCOPE-660
 Project: Syncope
  Issue Type: Improvement
Reporter: Francesco Chicchiriccò
Assignee: Giacomo Lamonaco
 Fix For: 1.2.5, 2.0.0


 Asynchronous job execution, generally delegated to Quartz, can currently be 
 checked only at completion, and only by indirectly checking the status on 
 related JPA entities (TaskExec, ReportExec, ...).
 A REST endpoint should be provided for reporting on jobs execution and 
 providing the ability to control (e.g. stop / pause / resume / ...) .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-701) New end-user UI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982232#comment-14982232
 ] 

ASF GitHub Bot commented on SYNCOPE-701:


Github user asfgit closed the pull request at:

https://github.com/apache/syncope/pull/11


> New end-user UI
> ---
>
> Key: SYNCOPE-701
> URL: https://issues.apache.org/jira/browse/SYNCOPE-701
> Project: Syncope
>  Issue Type: New Feature
>Reporter: Francesco Chicchiriccò
>Assignee: Andrea Patricelli
> Fix For: 2.0.0
>
>
> Before SYNCOPE-156, the admin console used to offer self-service features 
> like as self-registration, profile maintenance and password reset.
> The idea is to built a separate web application providing such features; some 
> requirements:
>  # extremely customizable on deployment basis: not only look & feel, but also 
> application logic (this sets one of glamour JS frameworks -as AngularJS - as 
> candidate)
>  # keep admin UI attitude of being gateway for accessing REST services 
> exposed by core: this might require to build a sort of 'proxy' application to 
> be contacted by client-side JS code



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-701) New end-user UI

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982220#comment-14982220
 ] 

ASF GitHub Bot commented on SYNCOPE-701:


GitHub user andrea-patricelli opened a pull request:

https://github.com/apache/syncope/pull/11

SYNCOPE-701 first working implementation



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andrea-patricelli/syncope SYNCOPE-701

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/syncope/pull/11.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #11


commit 223a64e26deff69a4ed8275d0f1348ca4e130a01
Author: Andrea Patricelli 
Date:   2015-10-05T13:12:55Z

SYNCOPE-701 first working implementation




> New end-user UI
> ---
>
> Key: SYNCOPE-701
> URL: https://issues.apache.org/jira/browse/SYNCOPE-701
> Project: Syncope
>  Issue Type: New Feature
>Reporter: Francesco Chicchiriccò
>Assignee: Andrea Patricelli
> Fix For: 2.0.0
>
>
> Before SYNCOPE-156, the admin console used to offer self-service features 
> like as self-registration, profile maintenance and password reset.
> The idea is to built a separate web application providing such features; some 
> requirements:
>  # extremely customizable on deployment basis: not only look & feel, but also 
> application logic (this sets one of glamour JS frameworks -as AngularJS - as 
> candidate)
>  # keep admin UI attitude of being gateway for accessing REST services 
> exposed by core: this might require to build a sort of 'proxy' application to 
> be contacted by client-side JS code



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-702) Documentation issue on Architecture section

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944712#comment-14944712
 ] 

ASF GitHub Bot commented on SYNCOPE-702:


Github user ilgrosso commented on the pull request:

https://github.com/apache/syncope/pull/9#issuecomment-145786501
  
Please limit your changes to the link only, I see several formatting and 
spacing changes.


> Documentation issue on Architecture section
> ---
>
> Key: SYNCOPE-702
> URL: https://issues.apache.org/jira/browse/SYNCOPE-702
> Project: Syncope
>  Issue Type: Bug
>  Components: documentation
>Reporter: Facundo Farias
>Priority: Minor
> Fix For: 1.2.6, 2.0.0
>
>
> On the Architecture section of the documentation, on the JPA persistence 
> layer part, the available options link it is not working, retrieving a HTTP 
> 404 
> (http://openjpa.apache.org/builds/latest/docs/docbook/manual/ref_guide_dbsetup_dbsupport.html).
>  Not sure, which should be the correct link, but perhaps this one: 
> http://openjpa.apache.org/builds/2.2.1/apache-openjpa/docs/ref_guide_dbsetup_dbsupport.html
> If you give me some advice I can fix it :)
> Thanks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-702) Documentation issue on Architecture section

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944728#comment-14944728
 ] 

ASF GitHub Bot commented on SYNCOPE-702:


Github user ilgrosso commented on the pull request:

https://github.com/apache/syncope/pull/9#issuecomment-145788400
  
Please also send you fix against the 1_2_X branch, not master.


> Documentation issue on Architecture section
> ---
>
> Key: SYNCOPE-702
> URL: https://issues.apache.org/jira/browse/SYNCOPE-702
> Project: Syncope
>  Issue Type: Bug
>  Components: documentation
>Reporter: Facundo Farias
>Priority: Minor
> Fix For: 1.2.6, 2.0.0
>
>
> On the Architecture section of the documentation, on the JPA persistence 
> layer part, the available options link it is not working, retrieving a HTTP 
> 404 
> (http://openjpa.apache.org/builds/latest/docs/docbook/manual/ref_guide_dbsetup_dbsupport.html).
>  Not sure, which should be the correct link, but perhaps this one: 
> http://openjpa.apache.org/builds/2.2.1/apache-openjpa/docs/ref_guide_dbsetup_dbsupport.html
> If you give me some advice I can fix it :)
> Thanks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-702) Documentation issue on Architecture section

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944756#comment-14944756
 ] 

ASF GitHub Bot commented on SYNCOPE-702:


Github user asfgit closed the pull request at:

https://github.com/apache/syncope/pull/10


> Documentation issue on Architecture section
> ---
>
> Key: SYNCOPE-702
> URL: https://issues.apache.org/jira/browse/SYNCOPE-702
> Project: Syncope
>  Issue Type: Bug
>  Components: documentation
>Reporter: Facundo Farias
>Assignee: Francesco Chicchiriccò
>Priority: Minor
> Fix For: 1.2.6, 2.0.0
>
>
> On the Architecture section of the documentation, on the JPA persistence 
> layer part, the available options link it is not working, retrieving a HTTP 
> 404 
> (http://openjpa.apache.org/builds/latest/docs/docbook/manual/ref_guide_dbsetup_dbsupport.html).
>  Not sure, which should be the correct link, but perhaps this one: 
> http://openjpa.apache.org/builds/2.2.1/apache-openjpa/docs/ref_guide_dbsetup_dbsupport.html
> If you give me some advice I can fix it :)
> Thanks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-702) Documentation issue on Architecture section

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944707#comment-14944707
 ] 

ASF GitHub Bot commented on SYNCOPE-702:


GitHub user facundofarias opened a pull request:

https://github.com/apache/syncope/pull/9

SYNCOPE-702: Fixing documentation issue on architecture section

(broken link)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/facundofarias/syncope master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/syncope/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #9


commit ca950a2b949345173feef7c38dcb9dfcc1261cea
Author: Facundo Farias 
Date:   2015-10-06T08:42:43Z

SYNCOPE-702: Fixing documentation issue on architecture section (broken 
link).




> Documentation issue on Architecture section
> ---
>
> Key: SYNCOPE-702
> URL: https://issues.apache.org/jira/browse/SYNCOPE-702
> Project: Syncope
>  Issue Type: Bug
>  Components: documentation
>Reporter: Facundo Farias
>Priority: Minor
> Fix For: 1.2.6, 2.0.0
>
>
> On the Architecture section of the documentation, on the JPA persistence 
> layer part, the available options link it is not working, retrieving a HTTP 
> 404 
> (http://openjpa.apache.org/builds/latest/docs/docbook/manual/ref_guide_dbsetup_dbsupport.html).
>  Not sure, which should be the correct link, but perhaps this one: 
> http://openjpa.apache.org/builds/2.2.1/apache-openjpa/docs/ref_guide_dbsetup_dbsupport.html
> If you give me some advice I can fix it :)
> Thanks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-702) Documentation issue on Architecture section

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944740#comment-14944740
 ] 

ASF GitHub Bot commented on SYNCOPE-702:


Github user facundofarias closed the pull request at:

https://github.com/apache/syncope/pull/9


> Documentation issue on Architecture section
> ---
>
> Key: SYNCOPE-702
> URL: https://issues.apache.org/jira/browse/SYNCOPE-702
> Project: Syncope
>  Issue Type: Bug
>  Components: documentation
>Reporter: Facundo Farias
>Priority: Minor
> Fix For: 1.2.6, 2.0.0
>
>
> On the Architecture section of the documentation, on the JPA persistence 
> layer part, the available options link it is not working, retrieving a HTTP 
> 404 
> (http://openjpa.apache.org/builds/latest/docs/docbook/manual/ref_guide_dbsetup_dbsupport.html).
>  Not sure, which should be the correct link, but perhaps this one: 
> http://openjpa.apache.org/builds/2.2.1/apache-openjpa/docs/ref_guide_dbsetup_dbsupport.html
> If you give me some advice I can fix it :)
> Thanks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-702) Documentation issue on Architecture section

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944748#comment-14944748
 ] 

ASF GitHub Bot commented on SYNCOPE-702:


GitHub user facundofarias opened a pull request:

https://github.com/apache/syncope/pull/10

SYNCOPE-702: Fixing documentation issue on architecture section



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/facundofarias/syncope 1_2_X

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/syncope/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10


commit a1e4daefa809f56023c4e61d3a50ab4681d1a5f0
Author: Facundo Farias 
Date:   2015-10-06T09:01:03Z

SYNCOPE-702: Fixing documentation issue on architecture section




> Documentation issue on Architecture section
> ---
>
> Key: SYNCOPE-702
> URL: https://issues.apache.org/jira/browse/SYNCOPE-702
> Project: Syncope
>  Issue Type: Bug
>  Components: documentation
>Reporter: Facundo Farias
>Priority: Minor
> Fix For: 1.2.6, 2.0.0
>
>
> On the Architecture section of the documentation, on the JPA persistence 
> layer part, the available options link it is not working, retrieving a HTTP 
> 404 
> (http://openjpa.apache.org/builds/latest/docs/docbook/manual/ref_guide_dbsetup_dbsupport.html).
>  Not sure, which should be the correct link, but perhaps this one: 
> http://openjpa.apache.org/builds/2.2.1/apache-openjpa/docs/ref_guide_dbsetup_dbsupport.html
> If you give me some advice I can fix it :)
> Thanks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-675) Role tree construction takes some time if there are a lot roles

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14620720#comment-14620720
 ] 

ASF GitHub Bot commented on SYNCOPE-675:


Github user giacomolm closed the pull request at:

https://github.com/apache/syncope/pull/8


 Role tree construction takes some time if there are a lot roles
 ---

 Key: SYNCOPE-675
 URL: https://issues.apache.org/jira/browse/SYNCOPE-675
 Project: Syncope
  Issue Type: Improvement
  Components: console
Affects Versions: 1.2.4
Reporter: Giacomo Lamonaco
Assignee: Giacomo Lamonaco
Priority: Minor

 MembershipPanel and TreeRolePanel visualize roles through a wicket tree. Try 
 to create a lot of roles in Syncope. Then try to open the role page or try to 
 edit an user opening the edit modal page. You will experience some delay (it 
 depends also on your system performance).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-675) Role tree construction takes some time if there are a lot roles

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14620719#comment-14620719
 ] 

ASF GitHub Bot commented on SYNCOPE-675:


Github user giacomolm commented on the pull request:

https://github.com/apache/syncope/pull/8#issuecomment-120042212
  
[SYNCOPE-676] made this issue outdated


 Role tree construction takes some time if there are a lot roles
 ---

 Key: SYNCOPE-675
 URL: https://issues.apache.org/jira/browse/SYNCOPE-675
 Project: Syncope
  Issue Type: Improvement
  Components: console
Affects Versions: 1.2.4
Reporter: Giacomo Lamonaco
Assignee: Giacomo Lamonaco
Priority: Minor

 MembershipPanel and TreeRolePanel visualize roles through a wicket tree. Try 
 to create a lot of roles in Syncope. Then try to open the role page or try to 
 edit an user opening the edit modal page. You will experience some delay (it 
 depends also on your system performance).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-866) Check for existence of key before adding template

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314001#comment-15314001
 ] 

ASF GitHub Bot commented on SYNCOPE-866:


Github user tmess567 commented on the issue:

https://github.com/apache/syncope/pull/18
  
So, in the crud method, I will be calling the issueSYNCOPE866() method? Or 
should I just add a Test Case directly into the crud method?


> Check for existence of key before adding template
> -
>
> Key: SYNCOPE-866
> URL: https://issues.apache.org/jira/browse/SYNCOPE-866
> Project: Syncope
>  Issue Type: Improvement
>  Components: core
>Reporter: Tushar Mishra
> Fix For: 2.0.0
>
>
> The create(String key) method in the MailTemplateLogic and 
> ReportTemplateLogic classes of the org.apache.syncope.core.logic package 
> should check if the key being added to the MailTemplateDAO instance is 
> already present. If such a key already exists, it should throw an appropriate 
> exception for the same.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-866) Check for existence of key before adding template

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314014#comment-15314014
 ] 

ASF GitHub Bot commented on SYNCOPE-866:


Github user ilgrosso commented on the issue:

https://github.com/apache/syncope/pull/18
  
Ok, the changes are just fine.

Now, you need to add a couple of methods like as follows

```java
@Test
public void issueSYNCOPE866() {

}
```

to the two classes mentioned above.

In the body of such methods you will, by taking reference with other 
methods in the same class, essentially:

1. create a report template with an existing key
1. assert that such creation operation fails with

The following is a working sample - that you can just grab and put there - 
for report template:

```java
@Test
public void issueSYNCOPE866() {
ReportTemplateTO reportTemplateTO = new ReportTemplateTO();
reportTemplateTO.setKey("empty");
try {
reportTemplateService.create(reportTemplateTO);
fail();
} catch (SyncopeClientException e) {
assertEquals(ClientExceptionType.EntityExists, e.getType());
}
}
```


> Check for existence of key before adding template
> -
>
> Key: SYNCOPE-866
> URL: https://issues.apache.org/jira/browse/SYNCOPE-866
> Project: Syncope
>  Issue Type: Improvement
>  Components: core
>Reporter: Tushar Mishra
> Fix For: 2.0.0
>
>
> The create(String key) method in the MailTemplateLogic and 
> ReportTemplateLogic classes of the org.apache.syncope.core.logic package 
> should check if the key being added to the MailTemplateDAO instance is 
> already present. If such a key already exists, it should throw an appropriate 
> exception for the same.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-866) Check for existence of key before adding template

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15313877#comment-15313877
 ] 

ASF GitHub Bot commented on SYNCOPE-866:


Github user ilgrosso commented on the issue:

https://github.com/apache/syncope/pull/18
  
Please also add a test case on 
[ReportTemplateITCase](https://github.com/apache/syncope/blob/master/fit/core-reference/src/test/java/org/apache/syncope/fit/core/ReportTemplateITCase.java)
 and on 
[MailTemplateITCase](https://github.com/apache/syncope/blob/master/fit/core-reference/src/test/java/org/apache/syncope/fit/core/MailTemplateITCase.java)
 named `issueSYNCOPE866()`.


> Check for existence of key before adding template
> -
>
> Key: SYNCOPE-866
> URL: https://issues.apache.org/jira/browse/SYNCOPE-866
> Project: Syncope
>  Issue Type: Improvement
>  Components: core
>Reporter: Tushar Mishra
> Fix For: 2.0.0
>
>
> The create(String key) method in the MailTemplateLogic and 
> ReportTemplateLogic classes of the org.apache.syncope.core.logic package 
> should check if the key being added to the MailTemplateDAO instance is 
> already present. If such a key already exists, it should throw an appropriate 
> exception for the same.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-700) Documentation artifacts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326997#comment-15326997
 ] 

ASF GitHub Bot commented on SYNCOPE-700:


Github user ilgrosso commented on the issue:

https://github.com/apache/syncope/pull/19
  
Hi @tmess567 thanks for this initiative!
I will review this PR soon, please keep adding commits to it.

Please also refer to SYNCOPE-700 in the commit log message, thanks.


> Documentation artifacts
> ---
>
> Key: SYNCOPE-700
> URL: https://issues.apache.org/jira/browse/SYNCOPE-700
> Project: Syncope
>  Issue Type: Improvement
>  Components: documentation
>Reporter: Francesco Chicchiriccò
>Assignee: Francesco Chicchiriccò
> Fix For: 2.0.0
>
>
> As [discussed|http://markmail.org/message/dpleneuzrfcsmq2r] in mailing list, 
> setup the {{asciidoctor-maven-plugin}} in order to generate, alongside with 
> the build, the project documentation in HTML and PDF.
> The generated documentation will then be part of release artifacts and always 
> up-to-date with current release.
> Preliminary results available at 
> http://syncope.apache.org/2.0.0-SNAPSHOT/docs/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-871) Link NumberWidgets on the dashboard to their respective pages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331961#comment-15331961
 ] 

ASF GitHub Bot commented on SYNCOPE-871:


GitHub user tmess567 opened a pull request:

https://github.com/apache/syncope/pull/20

SYNCOPE-871 Linked NumberWidgets to pages

Added events to NumberWidget that listen to mousedown events and open up 
the respective pages as discussed in the 
[SYNCOPE-871](https://issues.apache.org/jira/browse/SYNCOPE-871) issue.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tmess567/syncope SYNCOPE-871

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/syncope/pull/20.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20


commit 73e735cd8ddd4f9272d0177d4b1fe1943a568d8c
Author: Tushar 
Date:   2016-06-12T18:01:16Z

Corrected misspells and also added content to the Using the Admin Console 
section for the reference guide

commit ec53d9183faaff5d9d9d1adf364776d996fa3a22
Author: Tushar 
Date:   2016-06-13T05:59:43Z

Corrected misspells and added some links

commit 3ea78cd9260e9634427c1de93ad5632829a81676
Author: Tushar 
Date:   2016-06-15T15:53:50Z

SYNCOPE-871 NumberWidgets on Dashboard now link to their respective pages




> Link NumberWidgets on the dashboard to their respective pages
> -
>
> Key: SYNCOPE-871
> URL: https://issues.apache.org/jira/browse/SYNCOPE-871
> Project: Syncope
>  Issue Type: Improvement
>  Components: console
>Reporter: Tushar Mishra
>Priority: Minor
>  Labels: user-experience
> Fix For: 2.0.0
>
>
> To implement intuitive user experience, the NumberWidgets shown on the 
> console's dashboard should link to the following pages:
> Users -> Realms/User
> Groups -> Realms/Group
> Printers -> Realms/Printer
> Resources -> Topology



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-721) Enduser i18n

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333575#comment-15333575
 ] 

ASF GitHub Bot commented on SYNCOPE-721:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/22#discussion_r6732
  
--- Diff: pom.xml ---
@@ -404,6 +404,9 @@ under the License.
 1.3.3
 0.17.1
 
1.1.0
+2.11.0
+
2.8.1
--- End diff --

Please remove this (see next comment).


> Enduser i18n
> 
>
> Key: SYNCOPE-721
> URL: https://issues.apache.org/jira/browse/SYNCOPE-721
> Project: Syncope
>  Issue Type: New Feature
>  Components: enduser
>Reporter: Andrea Patricelli
> Fix For: 2.0.0
>
>
> Add i18n to angular application. It may be useful to export and load once a 
> JSON file with translated labels and get translations from it at runtime.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-721) Enduser i18n

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333581#comment-15333581
 ] 

ASF GitHub Bot commented on SYNCOPE-721:


Github user ilgrosso commented on the issue:

https://github.com/apache/syncope/pull/22
  
Thanks @mteo your PR looks generally good: I haven't tested it yet tough: 
I'll do and let you know.

I have also added some comments suggesting few changes.

Finally, since you have added a couple of new dependencies for `enduser`, 
you will also need to update some `LICENSE` / `NOTICE` files.

 I have developed a [simple tool](https://github.com/ilgrosso/LNGenerator) 
to automate this task, maybe I can land a hand once you're done with other 
changes.


> Enduser i18n
> 
>
> Key: SYNCOPE-721
> URL: https://issues.apache.org/jira/browse/SYNCOPE-721
> Project: Syncope
>  Issue Type: New Feature
>  Components: enduser
>Reporter: Andrea Patricelli
> Fix For: 2.0.0
>
>
> Add i18n to angular application. It may be useful to export and load once a 
> JSON file with translated labels and get translations from it at runtime.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-871) Link NumberWidgets on the dashboard to their respective pages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333764#comment-15333764
 ] 

ASF GitHub Bot commented on SYNCOPE-871:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/21#discussion_r67343220
  
--- Diff: 
client/console/src/main/java/org/apache/syncope/client/console/pages/Realms.java
 ---
@@ -170,76 +175,101 @@ private WebMarkupContainer updateRealmContent(final 
RealmTO realmTO) {
 if (realmTO == null) {
 return content;
 }
-content.addOrReplace(new Realm("body", realmTO, 
getPageReference()) {
+content.addOrReplace(new RealmConcrete("body", realmTO, 
getPageReference()));
+return content;
+}
 
-private static final long serialVersionUID = 
8221398624379357183L;
+private WebMarkupContainer updateRealmContent(final RealmTO realmTO, 
final int selectedIndex) {
+if (realmTO == null) {
+return content;
+}
+content.addOrReplace(new RealmConcrete("body", realmTO, 
getPageReference(), selectedIndex));
+return content;
+}
 
-@Override
-protected void onClickTemplate(final AjaxRequestTarget target) 
{
-templates.setTargetObject(realmTO);
-templates.toggle(target, true);
-}
+class RealmConcrete extends Realm {
--- End diff --

I don't understand why you have created `RealmConcrete` instead of putting 
your additions directly into `Realm`


> Link NumberWidgets on the dashboard to their respective pages
> -
>
> Key: SYNCOPE-871
> URL: https://issues.apache.org/jira/browse/SYNCOPE-871
> Project: Syncope
>  Issue Type: Improvement
>  Components: console
>Reporter: Tushar Mishra
>Priority: Minor
>  Labels: user-experience
> Fix For: 2.0.0
>
>
> To implement intuitive user experience, the NumberWidgets shown on the 
> console's dashboard should link to the following pages:
> Users -> Realms/User
> Groups -> Realms/Group
> Printers -> Realms/Printer
> Resources -> Topology



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-869) Missing notification in case of success after create and update

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346288#comment-15346288
 ] 

ASF GitHub Bot commented on SYNCOPE-869:


GitHub user mteo opened a pull request:

https://github.com/apache/syncope/pull/25

[SYNCOPE-869] adds a final state to edit/create user and password res…

…et in case of success

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mteo/syncope SYNCOPE-869

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/syncope/pull/25.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #25


commit 3a9d2013c3f4c3c3bc8d40514b3794515ffc7034
Author: Matteo Di Carlo 
Date:   2016-06-23T10:51:08Z

[SYNCOPE-869] adds a final state to edit/create user and password reset in 
case of success




> Missing notification in case of success after create and update
> ---
>
> Key: SYNCOPE-869
> URL: https://issues.apache.org/jira/browse/SYNCOPE-869
> Project: Syncope
>  Issue Type: Bug
>  Components: enduser
>Affects Versions: 2.0.0-M3
>Reporter: Francesco Chicchiriccò
> Fix For: 2.0.0-M4
>
>
> After completing the self-registration and update process, no notification is 
> shown in case of success.
> It could be wise to provide a full-blown landing page, with link for 
> returning to login page.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-721) Enduser i18n

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334057#comment-15334057
 ] 

ASF GitHub Bot commented on SYNCOPE-721:


Github user mteo closed the pull request at:

https://github.com/apache/syncope/pull/22


> Enduser i18n
> 
>
> Key: SYNCOPE-721
> URL: https://issues.apache.org/jira/browse/SYNCOPE-721
> Project: Syncope
>  Issue Type: New Feature
>  Components: enduser
>Reporter: Andrea Patricelli
>Assignee: Francesco Chicchiriccò
> Fix For: 2.0.0
>
>
> Add i18n to angular application. It may be useful to export and load once a 
> JSON file with translated labels and get translations from it at runtime.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-871) Link NumberWidgets on the dashboard to their respective pages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335672#comment-15335672
 ] 

ASF GitHub Bot commented on SYNCOPE-871:


Github user ilgrosso commented on the issue:

https://github.com/apache/syncope/pull/21
  
Please rebase on master: b1626cf0d5b438c466ca2501b23153dc4fed6d4b has moved 
`AnyTypeComparator` into a separate class file.


> Link NumberWidgets on the dashboard to their respective pages
> -
>
> Key: SYNCOPE-871
> URL: https://issues.apache.org/jira/browse/SYNCOPE-871
> Project: Syncope
>  Issue Type: Improvement
>  Components: console
>Reporter: Tushar Mishra
>Priority: Minor
>  Labels: user-experience
> Fix For: 2.0.0
>
>
> To implement intuitive user experience, the NumberWidgets shown on the 
> console's dashboard should link to the following pages:
> Users -> Realms/User
> Groups -> Realms/Group
> Printers -> Realms/Printer
> Resources -> Topology



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-828) Russian translation for admin console

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15240683#comment-15240683
 ] 

ASF GitHub Bot commented on SYNCOPE-828:


Github user asfgit closed the pull request at:

https://github.com/apache/syncope/pull/12


> Russian translation for admin console
> -
>
> Key: SYNCOPE-828
> URL: https://issues.apache.org/jira/browse/SYNCOPE-828
> Project: Syncope
>  Issue Type: New Feature
>  Components: console
>Reporter: Francesco Chicchiriccò
>Assignee: Dmitry Berezkin
> Fix For: 2.0.0
>
>
> Add Russian to the list of available translations for admin console UI.
> Relevant mail thread: http://markmail.org/message/wrftlbrpswyeeivu



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257853#comment-15257853
 ] 

ASF GitHub Bot commented on SYNCOPE-798:


GitHub user mteo opened a pull request:

https://github.com/apache/syncope/pull/13

SYNCOPE-798 now cancel does logout



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mteo/syncope SYNCOPE-798

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/syncope/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13


commit c6c88bd56038c2a21e3b0d22aeac4a6104e8f280
Author: Matteo Di Carlo 
Date:   2016-04-26T10:17:55Z

SYNCOPE-798 now cancel does logout




> Once authenticated to enduser, "Cancel" brings nowhere 
> ---
>
> Key: SYNCOPE-798
> URL: https://issues.apache.org/jira/browse/SYNCOPE-798
> Project: Syncope
>  Issue Type: Bug
>  Components: enduser
>Affects Versions: 2.0.0-M2
>Reporter: Francesco Chicchiriccò
> Fix For: 2.0.0
>
> Attachments: pointless page.png
>
>
> How to reproduce:
>  # log into enduser
>  # hit the red button Cancel on the bottom
>  # you are redirected to an empty page (see screenshot attached)
> Cancel should be equivalent to Logout (so it is really needed? The logout 
> button is already there).
> Incidentally, the same pointless page is returned when accessing 
> /syncope-enduser if authenticated - which looks wrong, the excepted landing 
> page should be first one, e.g. "crendentials".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-838) review of logging state of the syncope enduser

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268825#comment-15268825
 ] 

ASF GitHub Bot commented on SYNCOPE-838:


Github user mteo commented on the pull request:

https://github.com/apache/syncope/pull/14#issuecomment-216554285
  
ok. I fixed the java logs.
Thanks for the review.


> review of logging state of the syncope enduser 
> ---
>
> Key: SYNCOPE-838
> URL: https://issues.apache.org/jira/browse/SYNCOPE-838
> Project: Syncope
>  Issue Type: Improvement
>  Components: enduser
> Environment: syncope enduser
>Reporter: Matteo Di Carlo
>Assignee: Matteo Di Carlo
> Fix For: 2.0.0
>
>
> Review of logging messages of syncope enduser, javascript and java.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-838) review of logging state of the syncope enduser

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268831#comment-15268831
 ] 

ASF GitHub Bot commented on SYNCOPE-838:


Github user asfgit closed the pull request at:

https://github.com/apache/syncope/pull/14


> review of logging state of the syncope enduser 
> ---
>
> Key: SYNCOPE-838
> URL: https://issues.apache.org/jira/browse/SYNCOPE-838
> Project: Syncope
>  Issue Type: Improvement
>  Components: enduser
> Environment: syncope enduser
>Reporter: Matteo Di Carlo
>Assignee: Matteo Di Carlo
> Fix For: 2.0.0
>
>
> Review of logging messages of syncope enduser, javascript and java.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266583#comment-15266583
 ] 

ASF GitHub Bot commented on SYNCOPE-798:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/13#discussion_r61736403
  
--- Diff: 
client/enduser/src/main/resources/META-INF/resources/app/js/app.js ---
@@ -27,394 +29,409 @@ angular.module('info', []);
 
 // Declare app level module which depends on views, and components
 var app = angular.module('SyncopeEnduserApp', [
-  'ui.router',
-  'ui.bootstrap',
-  'ui.select',
-  'ngSanitize',
-  'ngAnimate',
-  'ngResource',
-  'ngCookies',
-  'treasure-overlay-spinner',
-  'ngPasswordStrength',
-  'kendo.directives',
-  'home',
-  'login',
-  'language',
-  'self',
-  'info'
+'ui.router',
+'ui.bootstrap',
+'ui.select',
+'ngSanitize',
+'ngAnimate',
+'ngResource',
+'ngCookies',
+'treasure-overlay-spinner',
+'ngPasswordStrength',
+'kendo.directives',
+'home',
+'login',
+'language',
+'self',
+'info'
 ]);
 
 app.config(['$stateProvider', '$urlRouterProvider', '$httpProvider',
-  function ($stateProvider, $urlRouterProvider, $httpProvider) {
-// route configuration
-$stateProvider
-.state('home', {
-  url: '/',
-  templateUrl: 'views/self.html'
-})
-.state('self', {
-  url: '/self',
-  templateUrl: 'views/self.html'
-})
-.state('user-self-update', {
-  url: '/user-self-update',
-  templateUrl: 'views/home.html',
-  controller: 'HomeController',
-  resolve: {
-'authenticated': function (AuthenticationHelper) {
-  return AuthenticationHelper.authenticated();
-}
-  }
-})
-.state('create', {
-  url: '/self/create',
-  templateUrl: 'views/editUser.html'
-})
-// nested states 
-// each of these sections will have their own view
-// url will be nested (/self/create)
-.state('create.credentials', {
-  url: '/credentials',
-  templateUrl: 'views/user-credentials.html'
-})
-.state('create.groups', {
-  url: '/groups',
-  templateUrl: 'views/user-groups.html'
-})
-.state('create.plainSchemas', {
-  url: '/plainSchemas',
-  templateUrl: 'views/user-plain-schemas.html'
-})
-.state('create.derivedSchemas', {
-  url: '/derivedSchemas',
-  templateUrl: 'views/user-derived-schemas.html'
-})
-.state('create.virtualSchemas', {
-  url: '/virtualSchemas',
-  templateUrl: 'views/user-virtual-schemas.html'
-})
-.state('create.resources', {
-  url: '/resources',
-  templateUrl: 'views/user-resources.html'
-})
-.state('create.finish', {
-  url: '/finish',
-  templateUrl: 'views/user-form-finish.html'
-})
-.state('update', {
-  url: '/self/update',
-  templateUrl: 'views/editUser.html',
-  resolve: {
-'authenticated': function (AuthenticationHelper) {
-  return AuthenticationHelper.authenticated();
-}
-  }
-})
-// nested states 
-// each of these sections will have their own view
-// url will be nested (/self/update)
-.state('update.credentials', {
-  url: '/credentials',
-  templateUrl: 'views/user-credentials.html',
-  resolve: {
-'authenticated': function (AuthenticationHelper) {
-  return AuthenticationHelper.authenticated();
-}
-  }
-})
-.state('update.plainSchemas', {
-  url: '/plainSchemas',
-  templateUrl: 'views/user-plain-schemas.html',
-  resolve: {
-'authenticated': function (AuthenticationHelper) {
-  return AuthenticationHelper.authenticated();
-}
-  }
-

[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266800#comment-15266800
 ] 

ASF GitHub Bot commented on SYNCOPE-798:


Github user ilgrosso commented on the pull request:

https://github.com/apache/syncope/pull/13#issuecomment-216268832
  
LGTM @mteo I'll go ahead and merge, thanks!


> Once authenticated to enduser, "Cancel" brings nowhere 
> ---
>
> Key: SYNCOPE-798
> URL: https://issues.apache.org/jira/browse/SYNCOPE-798
> Project: Syncope
>  Issue Type: Bug
>  Components: enduser
>Affects Versions: 2.0.0-M2
>Reporter: Francesco Chicchiriccò
>Assignee: Matteo Di Carlo
> Fix For: 2.0.0
>
> Attachments: pointless page.png
>
>
> How to reproduce:
>  # log into enduser
>  # hit the red button Cancel on the bottom
>  # you are redirected to an empty page (see screenshot attached)
> Cancel should be equivalent to Logout (so it is really needed? The logout 
> button is already there).
> Incidentally, the same pointless page is returned when accessing 
> /syncope-enduser if authenticated - which looks wrong, the excepted landing 
> page should be first one, e.g. "crendentials".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266580#comment-15266580
 ] 

ASF GitHub Bot commented on SYNCOPE-798:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/13#discussion_r61736317
  
--- Diff: 
client/enduser/src/main/resources/META-INF/resources/app/js/app.js ---
@@ -27,394 +29,409 @@ angular.module('info', []);
 
 // Declare app level module which depends on views, and components
 var app = angular.module('SyncopeEnduserApp', [
-  'ui.router',
-  'ui.bootstrap',
-  'ui.select',
-  'ngSanitize',
-  'ngAnimate',
-  'ngResource',
-  'ngCookies',
-  'treasure-overlay-spinner',
-  'ngPasswordStrength',
-  'kendo.directives',
-  'home',
-  'login',
-  'language',
-  'self',
-  'info'
+'ui.router',
+'ui.bootstrap',
+'ui.select',
+'ngSanitize',
+'ngAnimate',
+'ngResource',
+'ngCookies',
+'treasure-overlay-spinner',
+'ngPasswordStrength',
+'kendo.directives',
+'home',
+'login',
+'language',
+'self',
+'info'
 ]);
 
 app.config(['$stateProvider', '$urlRouterProvider', '$httpProvider',
-  function ($stateProvider, $urlRouterProvider, $httpProvider) {
-// route configuration
-$stateProvider
-.state('home', {
-  url: '/',
-  templateUrl: 'views/self.html'
-})
-.state('self', {
-  url: '/self',
-  templateUrl: 'views/self.html'
-})
-.state('user-self-update', {
-  url: '/user-self-update',
-  templateUrl: 'views/home.html',
-  controller: 'HomeController',
-  resolve: {
-'authenticated': function (AuthenticationHelper) {
-  return AuthenticationHelper.authenticated();
-}
-  }
-})
-.state('create', {
-  url: '/self/create',
-  templateUrl: 'views/editUser.html'
-})
-// nested states 
-// each of these sections will have their own view
-// url will be nested (/self/create)
-.state('create.credentials', {
-  url: '/credentials',
-  templateUrl: 'views/user-credentials.html'
-})
-.state('create.groups', {
-  url: '/groups',
-  templateUrl: 'views/user-groups.html'
-})
-.state('create.plainSchemas', {
-  url: '/plainSchemas',
-  templateUrl: 'views/user-plain-schemas.html'
-})
-.state('create.derivedSchemas', {
-  url: '/derivedSchemas',
-  templateUrl: 'views/user-derived-schemas.html'
-})
-.state('create.virtualSchemas', {
-  url: '/virtualSchemas',
-  templateUrl: 'views/user-virtual-schemas.html'
-})
-.state('create.resources', {
-  url: '/resources',
-  templateUrl: 'views/user-resources.html'
-})
-.state('create.finish', {
-  url: '/finish',
-  templateUrl: 'views/user-form-finish.html'
-})
-.state('update', {
-  url: '/self/update',
-  templateUrl: 'views/editUser.html',
-  resolve: {
-'authenticated': function (AuthenticationHelper) {
-  return AuthenticationHelper.authenticated();
-}
-  }
-})
-// nested states 
-// each of these sections will have their own view
-// url will be nested (/self/update)
-.state('update.credentials', {
-  url: '/credentials',
-  templateUrl: 'views/user-credentials.html',
-  resolve: {
-'authenticated': function (AuthenticationHelper) {
-  return AuthenticationHelper.authenticated();
-}
-  }
-})
-.state('update.plainSchemas', {
-  url: '/plainSchemas',
-  templateUrl: 'views/user-plain-schemas.html',
-  resolve: {
-'authenticated': function (AuthenticationHelper) {
-  return AuthenticationHelper.authenticated();
-}
-  }
-

[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266589#comment-15266589
 ] 

ASF GitHub Bot commented on SYNCOPE-798:


Github user ilgrosso commented on the pull request:

https://github.com/apache/syncope/pull/13#issuecomment-216232120
  
Hi @mteo thanks for your PR!
There are few minor comments of mine: once fixed, I'll be happy to merge it.


> Once authenticated to enduser, "Cancel" brings nowhere 
> ---
>
> Key: SYNCOPE-798
> URL: https://issues.apache.org/jira/browse/SYNCOPE-798
> Project: Syncope
>  Issue Type: Bug
>  Components: enduser
>Affects Versions: 2.0.0-M2
>Reporter: Francesco Chicchiriccò
>Assignee: Matteo Di Carlo
> Fix For: 2.0.0
>
> Attachments: pointless page.png
>
>
> How to reproduce:
>  # log into enduser
>  # hit the red button Cancel on the bottom
>  # you are redirected to an empty page (see screenshot attached)
> Cancel should be equivalent to Logout (so it is really needed? The logout 
> button is already there).
> Incidentally, the same pointless page is returned when accessing 
> /syncope-enduser if authenticated - which looks wrong, the excepted landing 
> page should be first one, e.g. "crendentials".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266578#comment-15266578
 ] 

ASF GitHub Bot commented on SYNCOPE-798:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/13#discussion_r61736304
  
--- Diff: 
client/enduser/src/main/resources/META-INF/resources/app/js/app.js ---
@@ -27,394 +29,409 @@ angular.module('info', []);
 
 // Declare app level module which depends on views, and components
 var app = angular.module('SyncopeEnduserApp', [
-  'ui.router',
-  'ui.bootstrap',
-  'ui.select',
-  'ngSanitize',
-  'ngAnimate',
-  'ngResource',
-  'ngCookies',
-  'treasure-overlay-spinner',
-  'ngPasswordStrength',
-  'kendo.directives',
-  'home',
-  'login',
-  'language',
-  'self',
-  'info'
+'ui.router',
+'ui.bootstrap',
+'ui.select',
+'ngSanitize',
+'ngAnimate',
+'ngResource',
+'ngCookies',
+'treasure-overlay-spinner',
+'ngPasswordStrength',
+'kendo.directives',
+'home',
+'login',
+'language',
+'self',
+'info'
 ]);
 
 app.config(['$stateProvider', '$urlRouterProvider', '$httpProvider',
-  function ($stateProvider, $urlRouterProvider, $httpProvider) {
-// route configuration
-$stateProvider
-.state('home', {
-  url: '/',
-  templateUrl: 'views/self.html'
-})
-.state('self', {
-  url: '/self',
-  templateUrl: 'views/self.html'
-})
-.state('user-self-update', {
-  url: '/user-self-update',
-  templateUrl: 'views/home.html',
-  controller: 'HomeController',
-  resolve: {
-'authenticated': function (AuthenticationHelper) {
-  return AuthenticationHelper.authenticated();
-}
-  }
-})
-.state('create', {
-  url: '/self/create',
-  templateUrl: 'views/editUser.html'
-})
-// nested states 
-// each of these sections will have their own view
-// url will be nested (/self/create)
-.state('create.credentials', {
-  url: '/credentials',
-  templateUrl: 'views/user-credentials.html'
-})
-.state('create.groups', {
-  url: '/groups',
-  templateUrl: 'views/user-groups.html'
-})
-.state('create.plainSchemas', {
-  url: '/plainSchemas',
-  templateUrl: 'views/user-plain-schemas.html'
-})
-.state('create.derivedSchemas', {
-  url: '/derivedSchemas',
-  templateUrl: 'views/user-derived-schemas.html'
-})
-.state('create.virtualSchemas', {
-  url: '/virtualSchemas',
-  templateUrl: 'views/user-virtual-schemas.html'
-})
-.state('create.resources', {
-  url: '/resources',
-  templateUrl: 'views/user-resources.html'
-})
-.state('create.finish', {
-  url: '/finish',
-  templateUrl: 'views/user-form-finish.html'
-})
-.state('update', {
-  url: '/self/update',
-  templateUrl: 'views/editUser.html',
-  resolve: {
-'authenticated': function (AuthenticationHelper) {
-  return AuthenticationHelper.authenticated();
-}
-  }
-})
-// nested states 
-// each of these sections will have their own view
-// url will be nested (/self/update)
-.state('update.credentials', {
-  url: '/credentials',
-  templateUrl: 'views/user-credentials.html',
-  resolve: {
-'authenticated': function (AuthenticationHelper) {
-  return AuthenticationHelper.authenticated();
-}
-  }
-})
-.state('update.plainSchemas', {
-  url: '/plainSchemas',
-  templateUrl: 'views/user-plain-schemas.html',
-  resolve: {
-'authenticated': function (AuthenticationHelper) {
-  return AuthenticationHelper.authenticated();
-}
-  }
-

[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266762#comment-15266762
 ] 

ASF GitHub Bot commented on SYNCOPE-798:


Github user mteo commented on the pull request:

https://github.com/apache/syncope/pull/13#issuecomment-216263417
  
Hi @ilgrosso, 
I made the changes. Thanks for the review.


> Once authenticated to enduser, "Cancel" brings nowhere 
> ---
>
> Key: SYNCOPE-798
> URL: https://issues.apache.org/jira/browse/SYNCOPE-798
> Project: Syncope
>  Issue Type: Bug
>  Components: enduser
>Affects Versions: 2.0.0-M2
>Reporter: Francesco Chicchiriccò
>Assignee: Matteo Di Carlo
> Fix For: 2.0.0
>
> Attachments: pointless page.png
>
>
> How to reproduce:
>  # log into enduser
>  # hit the red button Cancel on the bottom
>  # you are redirected to an empty page (see screenshot attached)
> Cancel should be equivalent to Logout (so it is really needed? The logout 
> button is already there).
> Incidentally, the same pointless page is returned when accessing 
> /syncope-enduser if authenticated - which looks wrong, the excepted landing 
> page should be first one, e.g. "crendentials".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266575#comment-15266575
 ] 

ASF GitHub Bot commented on SYNCOPE-798:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/13#discussion_r61736265
  
--- Diff: 
client/enduser/src/main/resources/META-INF/resources/app/js/app.js ---
@@ -27,394 +29,409 @@ angular.module('info', []);
 
 // Declare app level module which depends on views, and components
 var app = angular.module('SyncopeEnduserApp', [
-  'ui.router',
-  'ui.bootstrap',
-  'ui.select',
-  'ngSanitize',
-  'ngAnimate',
-  'ngResource',
-  'ngCookies',
-  'treasure-overlay-spinner',
-  'ngPasswordStrength',
-  'kendo.directives',
-  'home',
-  'login',
-  'language',
-  'self',
-  'info'
+'ui.router',
+'ui.bootstrap',
+'ui.select',
+'ngSanitize',
+'ngAnimate',
+'ngResource',
+'ngCookies',
+'treasure-overlay-spinner',
+'ngPasswordStrength',
+'kendo.directives',
+'home',
+'login',
+'language',
+'self',
+'info'
 ]);
 
 app.config(['$stateProvider', '$urlRouterProvider', '$httpProvider',
-  function ($stateProvider, $urlRouterProvider, $httpProvider) {
-// route configuration
-$stateProvider
-.state('home', {
-  url: '/',
-  templateUrl: 'views/self.html'
-})
-.state('self', {
-  url: '/self',
-  templateUrl: 'views/self.html'
-})
-.state('user-self-update', {
-  url: '/user-self-update',
-  templateUrl: 'views/home.html',
-  controller: 'HomeController',
-  resolve: {
-'authenticated': function (AuthenticationHelper) {
-  return AuthenticationHelper.authenticated();
-}
-  }
-})
-.state('create', {
-  url: '/self/create',
-  templateUrl: 'views/editUser.html'
-})
-// nested states 
-// each of these sections will have their own view
-// url will be nested (/self/create)
-.state('create.credentials', {
-  url: '/credentials',
-  templateUrl: 'views/user-credentials.html'
-})
-.state('create.groups', {
-  url: '/groups',
-  templateUrl: 'views/user-groups.html'
-})
-.state('create.plainSchemas', {
-  url: '/plainSchemas',
-  templateUrl: 'views/user-plain-schemas.html'
-})
-.state('create.derivedSchemas', {
-  url: '/derivedSchemas',
-  templateUrl: 'views/user-derived-schemas.html'
-})
-.state('create.virtualSchemas', {
-  url: '/virtualSchemas',
-  templateUrl: 'views/user-virtual-schemas.html'
-})
-.state('create.resources', {
-  url: '/resources',
-  templateUrl: 'views/user-resources.html'
-})
-.state('create.finish', {
-  url: '/finish',
-  templateUrl: 'views/user-form-finish.html'
-})
-.state('update', {
-  url: '/self/update',
-  templateUrl: 'views/editUser.html',
-  resolve: {
-'authenticated': function (AuthenticationHelper) {
-  return AuthenticationHelper.authenticated();
-}
-  }
-})
-// nested states 
-// each of these sections will have their own view
-// url will be nested (/self/update)
-.state('update.credentials', {
-  url: '/credentials',
-  templateUrl: 'views/user-credentials.html',
-  resolve: {
-'authenticated': function (AuthenticationHelper) {
-  return AuthenticationHelper.authenticated();
-}
-  }
-})
-.state('update.plainSchemas', {
-  url: '/plainSchemas',
-  templateUrl: 'views/user-plain-schemas.html',
-  resolve: {
-'authenticated': function (AuthenticationHelper) {
-  return AuthenticationHelper.authenticated();
-}
-  }
-

[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266569#comment-15266569
 ] 

ASF GitHub Bot commented on SYNCOPE-798:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/13#discussion_r61735968
  
--- Diff: 
client/enduser/src/main/resources/META-INF/resources/app/js/app.js ---
@@ -1,3 +1,5 @@
+/* global $http, AuthService */
--- End diff --

Is this required? If not, please remove; otherwise move it past the license 
header.


> Once authenticated to enduser, "Cancel" brings nowhere 
> ---
>
> Key: SYNCOPE-798
> URL: https://issues.apache.org/jira/browse/SYNCOPE-798
> Project: Syncope
>  Issue Type: Bug
>  Components: enduser
>Affects Versions: 2.0.0-M2
>Reporter: Francesco Chicchiriccò
>Assignee: Matteo Di Carlo
> Fix For: 2.0.0
>
> Attachments: pointless page.png
>
>
> How to reproduce:
>  # log into enduser
>  # hit the red button Cancel on the bottom
>  # you are redirected to an empty page (see screenshot attached)
> Cancel should be equivalent to Logout (so it is really needed? The logout 
> button is already there).
> Incidentally, the same pointless page is returned when accessing 
> /syncope-enduser if authenticated - which looks wrong, the excepted landing 
> page should be first one, e.g. "crendentials".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-799) Do not allow admin user log in to enduser

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270628#comment-15270628
 ] 

ASF GitHub Bot commented on SYNCOPE-799:


Github user asfgit closed the pull request at:

https://github.com/apache/syncope/pull/15


> Do not allow admin user log in to enduser
> -
>
> Key: SYNCOPE-799
> URL: https://issues.apache.org/jira/browse/SYNCOPE-799
> Project: Syncope
>  Issue Type: Bug
>  Components: enduser
>Affects Versions: 2.0.0-M2
>Reporter: Francesco Chicchiriccò
>Assignee: Matteo Di Carlo
> Fix For: 2.0.0
>
>
> The admin user is not a real user, so it cannot be allowed to log in to 
> enduser.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-799) Do not allow admin user log in to enduser

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270626#comment-15270626
 ] 

ASF GitHub Bot commented on SYNCOPE-799:


Github user ilgrosso commented on the pull request:

https://github.com/apache/syncope/pull/15#issuecomment-216865870
  
LGTM! I'll go ahead an merge.


> Do not allow admin user log in to enduser
> -
>
> Key: SYNCOPE-799
> URL: https://issues.apache.org/jira/browse/SYNCOPE-799
> Project: Syncope
>  Issue Type: Bug
>  Components: enduser
>Affects Versions: 2.0.0-M2
>Reporter: Francesco Chicchiriccò
>Assignee: Matteo Di Carlo
> Fix For: 2.0.0
>
>
> The admin user is not a real user, so it cannot be allowed to log in to 
> enduser.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-799) Do not allow admin user log in to enduser

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270621#comment-15270621
 ] 

ASF GitHub Bot commented on SYNCOPE-799:


GitHub user mteo opened a pull request:

https://github.com/apache/syncope/pull/15

[SYNCOPE-799] user Admin cannot log in to enduser anymore



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mteo/syncope SYNCOPE-799

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/syncope/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15


commit 214a5795eb42c45fda1cfea7fe850eac80fd02fb
Author: Matteo Di Carlo 
Date:   2016-05-04T13:20:15Z

[SYNCOPE-799] user Admin cannot log in to enduser anymore




> Do not allow admin user log in to enduser
> -
>
> Key: SYNCOPE-799
> URL: https://issues.apache.org/jira/browse/SYNCOPE-799
> Project: Syncope
>  Issue Type: Bug
>  Components: enduser
>Affects Versions: 2.0.0-M2
>Reporter: Francesco Chicchiriccò
>Assignee: Matteo Di Carlo
> Fix For: 2.0.0
>
>
> The admin user is not a real user, so it cannot be allowed to log in to 
> enduser.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-836) On Firefox, once logged in can't log out and viceversa if cache is not have been cleared

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272475#comment-15272475
 ] 

ASF GitHub Bot commented on SYNCOPE-836:


GitHub user mteo opened a pull request:

https://github.com/apache/syncope/pull/16

[SYNCOPE-836] user can log in and out without cleaning cache

because the cache, user couldn't switch authentication status. First 
solution was to disable cache globally in httpprovider for any browser. It 
didn't work for firefox, so stronger solution is to disable cache in every get 
request and make every get request different by adding a time parameter 
throught a interceptor.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mteo/syncope SYNCOPE-836

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/syncope/pull/16.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #16


commit 45642228c0963844a34d4bcccd86d4eef4489fa5
Author: Matteo Di Carlo 
Date:   2016-05-05T14:36:46Z

[SYNCOPE-836] user can log in and out without cleaning cache




> On Firefox, once logged in can't log out and viceversa if cache is not have 
> been cleared
> 
>
> Key: SYNCOPE-836
> URL: https://issues.apache.org/jira/browse/SYNCOPE-836
> Project: Syncope
>  Issue Type: Bug
>  Components: enduser
>Affects Versions: 2.0.0
> Environment: Firefox
>Reporter: Matteo Di Carlo
>Assignee: Matteo Di Carlo
> Fix For: 2.0.0
>
>
> on Firefox:
> -Log in with existing user
> -Log out 
> -delete cookies
> -can't log back in and no error message shown



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-836) On Firefox, once logged in can't log out and viceversa if cache is not have been cleared

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272481#comment-15272481
 ] 

ASF GitHub Bot commented on SYNCOPE-836:


Github user asfgit closed the pull request at:

https://github.com/apache/syncope/pull/16


> On Firefox, once logged in can't log out and viceversa if cache is not have 
> been cleared
> 
>
> Key: SYNCOPE-836
> URL: https://issues.apache.org/jira/browse/SYNCOPE-836
> Project: Syncope
>  Issue Type: Bug
>  Components: enduser
>Affects Versions: 2.0.0
> Environment: Firefox
>Reporter: Matteo Di Carlo
>Assignee: Matteo Di Carlo
> Fix For: 2.0.0
>
>
> on Firefox:
> -Log in with existing user
> -Log out 
> -delete cookies
> -can't log back in and no error message shown



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-838) review of logging state of the syncope enduser

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268784#comment-15268784
 ] 

ASF GitHub Bot commented on SYNCOPE-838:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/14#discussion_r61889125
  
--- Diff: 
client/enduser/src/main/resources/META-INF/resources/app/js/controllers/LoginController.js
 ---
@@ -76,19 +76,19 @@ angular.module("login").controller("LoginController", 
['$scope', '$rootScope', '
 
 $scope.errorAPI = function () {
   $http.get("/syncope-enduser/api/error").success(function (data) {
-console.log("errorAPI response: ", data);
+console.debug("errorAPI response: ", data);
   });
 };
 
 $scope.sampleAPI = function () {
   $http.get("/syncope-enduser/api/user-self").success(function (data) {
-console.log("sampleAPI response: ", data);
+console.debug("sampleAPI response: ", data);
   });
 };
 
 $scope.schemaAPI = function () {
   $http.get("/syncope-enduser/api/schema").success(function (data) {
-console.log("schemaAPI response: ", data);
+console.debuXg("schemaAPI response: ", data);
--- End diff --

typo


> review of logging state of the syncope enduser 
> ---
>
> Key: SYNCOPE-838
> URL: https://issues.apache.org/jira/browse/SYNCOPE-838
> Project: Syncope
>  Issue Type: Improvement
>  Components: enduser
> Environment: syncope enduser
>Reporter: Matteo Di Carlo
>Assignee: Matteo Di Carlo
> Fix For: 2.0.0
>
>
> Review of logging messages of syncope enduser, javascript and java.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-838) review of logging state of the syncope enduser

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268780#comment-15268780
 ] 

ASF GitHub Bot commented on SYNCOPE-838:


GitHub user mteo opened a pull request:

https://github.com/apache/syncope/pull/14

[SYNCOPE-838] review of syncope-enduser's logs

logging messages cleaning, syntax and logging level review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mteo/syncope SYNCOPE-838

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/syncope/pull/14.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #14


commit 17b12412ffec3a205a753556c444820121a5cfe7
Author: Matteo Di Carlo 
Date:   2016-05-03T14:04:56Z

[SYNCOPE-838] review of syncope-enduser's logs




> review of logging state of the syncope enduser 
> ---
>
> Key: SYNCOPE-838
> URL: https://issues.apache.org/jira/browse/SYNCOPE-838
> Project: Syncope
>  Issue Type: Improvement
>  Components: enduser
> Environment: syncope enduser
>Reporter: Matteo Di Carlo
>Assignee: Matteo Di Carlo
> Fix For: 2.0.0
>
>
> Review of logging messages of syncope enduser, javascript and java.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-838) review of logging state of the syncope enduser

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268794#comment-15268794
 ] 

ASF GitHub Bot commented on SYNCOPE-838:


Github user ilgrosso commented on the pull request:

https://github.com/apache/syncope/pull/14#issuecomment-216546800
  
Nice job @mteo - could you please also review the Java code in a similar 
fashion?


> review of logging state of the syncope enduser 
> ---
>
> Key: SYNCOPE-838
> URL: https://issues.apache.org/jira/browse/SYNCOPE-838
> Project: Syncope
>  Issue Type: Improvement
>  Components: enduser
> Environment: syncope enduser
>Reporter: Matteo Di Carlo
>Assignee: Matteo Di Carlo
> Fix For: 2.0.0
>
>
> Review of logging messages of syncope enduser, javascript and java.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266572#comment-15266572
 ] 

ASF GitHub Bot commented on SYNCOPE-798:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/13#discussion_r61736063
  
--- Diff: 
client/enduser/src/main/resources/META-INF/resources/app/js/app.js ---
@@ -27,394 +29,409 @@ angular.module('info', []);
 
 // Declare app level module which depends on views, and components
 var app = angular.module('SyncopeEnduserApp', [
-  'ui.router',
-  'ui.bootstrap',
-  'ui.select',
-  'ngSanitize',
-  'ngAnimate',
-  'ngResource',
-  'ngCookies',
-  'treasure-overlay-spinner',
-  'ngPasswordStrength',
-  'kendo.directives',
-  'home',
-  'login',
-  'language',
-  'self',
-  'info'
+'ui.router',
--- End diff --

Please avoid this formatting-only modifications, they make harder to 
recognize actual changes.


> Once authenticated to enduser, "Cancel" brings nowhere 
> ---
>
> Key: SYNCOPE-798
> URL: https://issues.apache.org/jira/browse/SYNCOPE-798
> Project: Syncope
>  Issue Type: Bug
>  Components: enduser
>Affects Versions: 2.0.0-M2
>Reporter: Francesco Chicchiriccò
>Assignee: Matteo Di Carlo
> Fix For: 2.0.0
>
> Attachments: pointless page.png
>
>
> How to reproduce:
>  # log into enduser
>  # hit the red button Cancel on the bottom
>  # you are redirected to an empty page (see screenshot attached)
> Cancel should be equivalent to Logout (so it is really needed? The logout 
> button is already there).
> Incidentally, the same pointless page is returned when accessing 
> /syncope-enduser if authenticated - which looks wrong, the excepted landing 
> page should be first one, e.g. "crendentials".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266577#comment-15266577
 ] 

ASF GitHub Bot commented on SYNCOPE-798:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/13#discussion_r61736292
  
--- Diff: 
client/enduser/src/main/resources/META-INF/resources/app/js/app.js ---
@@ -27,394 +29,409 @@ angular.module('info', []);
 
 // Declare app level module which depends on views, and components
 var app = angular.module('SyncopeEnduserApp', [
-  'ui.router',
-  'ui.bootstrap',
-  'ui.select',
-  'ngSanitize',
-  'ngAnimate',
-  'ngResource',
-  'ngCookies',
-  'treasure-overlay-spinner',
-  'ngPasswordStrength',
-  'kendo.directives',
-  'home',
-  'login',
-  'language',
-  'self',
-  'info'
+'ui.router',
+'ui.bootstrap',
+'ui.select',
+'ngSanitize',
+'ngAnimate',
+'ngResource',
+'ngCookies',
+'treasure-overlay-spinner',
+'ngPasswordStrength',
+'kendo.directives',
+'home',
+'login',
+'language',
+'self',
+'info'
 ]);
 
 app.config(['$stateProvider', '$urlRouterProvider', '$httpProvider',
-  function ($stateProvider, $urlRouterProvider, $httpProvider) {
-// route configuration
-$stateProvider
-.state('home', {
-  url: '/',
-  templateUrl: 'views/self.html'
-})
-.state('self', {
-  url: '/self',
-  templateUrl: 'views/self.html'
-})
-.state('user-self-update', {
-  url: '/user-self-update',
-  templateUrl: 'views/home.html',
-  controller: 'HomeController',
-  resolve: {
-'authenticated': function (AuthenticationHelper) {
-  return AuthenticationHelper.authenticated();
-}
-  }
-})
-.state('create', {
-  url: '/self/create',
-  templateUrl: 'views/editUser.html'
-})
-// nested states 
-// each of these sections will have their own view
-// url will be nested (/self/create)
-.state('create.credentials', {
-  url: '/credentials',
-  templateUrl: 'views/user-credentials.html'
-})
-.state('create.groups', {
-  url: '/groups',
-  templateUrl: 'views/user-groups.html'
-})
-.state('create.plainSchemas', {
-  url: '/plainSchemas',
-  templateUrl: 'views/user-plain-schemas.html'
-})
-.state('create.derivedSchemas', {
-  url: '/derivedSchemas',
-  templateUrl: 'views/user-derived-schemas.html'
-})
-.state('create.virtualSchemas', {
-  url: '/virtualSchemas',
-  templateUrl: 'views/user-virtual-schemas.html'
-})
-.state('create.resources', {
-  url: '/resources',
-  templateUrl: 'views/user-resources.html'
-})
-.state('create.finish', {
-  url: '/finish',
-  templateUrl: 'views/user-form-finish.html'
-})
-.state('update', {
-  url: '/self/update',
-  templateUrl: 'views/editUser.html',
-  resolve: {
-'authenticated': function (AuthenticationHelper) {
-  return AuthenticationHelper.authenticated();
-}
-  }
-})
-// nested states 
-// each of these sections will have their own view
-// url will be nested (/self/update)
-.state('update.credentials', {
-  url: '/credentials',
-  templateUrl: 'views/user-credentials.html',
-  resolve: {
-'authenticated': function (AuthenticationHelper) {
-  return AuthenticationHelper.authenticated();
-}
-  }
-})
-.state('update.plainSchemas', {
-  url: '/plainSchemas',
-  templateUrl: 'views/user-plain-schemas.html',
-  resolve: {
-'authenticated': function (AuthenticationHelper) {
-  return AuthenticationHelper.authenticated();
-}
-  }
-

[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266576#comment-15266576
 ] 

ASF GitHub Bot commented on SYNCOPE-798:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/13#discussion_r61736276
  
--- Diff: 
client/enduser/src/main/resources/META-INF/resources/app/js/app.js ---
@@ -27,394 +29,409 @@ angular.module('info', []);
 
 // Declare app level module which depends on views, and components
 var app = angular.module('SyncopeEnduserApp', [
-  'ui.router',
-  'ui.bootstrap',
-  'ui.select',
-  'ngSanitize',
-  'ngAnimate',
-  'ngResource',
-  'ngCookies',
-  'treasure-overlay-spinner',
-  'ngPasswordStrength',
-  'kendo.directives',
-  'home',
-  'login',
-  'language',
-  'self',
-  'info'
+'ui.router',
+'ui.bootstrap',
+'ui.select',
+'ngSanitize',
+'ngAnimate',
+'ngResource',
+'ngCookies',
+'treasure-overlay-spinner',
+'ngPasswordStrength',
+'kendo.directives',
+'home',
+'login',
+'language',
+'self',
+'info'
 ]);
 
 app.config(['$stateProvider', '$urlRouterProvider', '$httpProvider',
-  function ($stateProvider, $urlRouterProvider, $httpProvider) {
-// route configuration
-$stateProvider
-.state('home', {
-  url: '/',
-  templateUrl: 'views/self.html'
-})
-.state('self', {
-  url: '/self',
-  templateUrl: 'views/self.html'
-})
-.state('user-self-update', {
-  url: '/user-self-update',
-  templateUrl: 'views/home.html',
-  controller: 'HomeController',
-  resolve: {
-'authenticated': function (AuthenticationHelper) {
-  return AuthenticationHelper.authenticated();
-}
-  }
-})
-.state('create', {
-  url: '/self/create',
-  templateUrl: 'views/editUser.html'
-})
-// nested states 
-// each of these sections will have their own view
-// url will be nested (/self/create)
-.state('create.credentials', {
-  url: '/credentials',
-  templateUrl: 'views/user-credentials.html'
-})
-.state('create.groups', {
-  url: '/groups',
-  templateUrl: 'views/user-groups.html'
-})
-.state('create.plainSchemas', {
-  url: '/plainSchemas',
-  templateUrl: 'views/user-plain-schemas.html'
-})
-.state('create.derivedSchemas', {
-  url: '/derivedSchemas',
-  templateUrl: 'views/user-derived-schemas.html'
-})
-.state('create.virtualSchemas', {
-  url: '/virtualSchemas',
-  templateUrl: 'views/user-virtual-schemas.html'
-})
-.state('create.resources', {
-  url: '/resources',
-  templateUrl: 'views/user-resources.html'
-})
-.state('create.finish', {
-  url: '/finish',
-  templateUrl: 'views/user-form-finish.html'
-})
-.state('update', {
-  url: '/self/update',
-  templateUrl: 'views/editUser.html',
-  resolve: {
-'authenticated': function (AuthenticationHelper) {
-  return AuthenticationHelper.authenticated();
-}
-  }
-})
-// nested states 
-// each of these sections will have their own view
-// url will be nested (/self/update)
-.state('update.credentials', {
-  url: '/credentials',
-  templateUrl: 'views/user-credentials.html',
-  resolve: {
-'authenticated': function (AuthenticationHelper) {
-  return AuthenticationHelper.authenticated();
-}
-  }
-})
-.state('update.plainSchemas', {
-  url: '/plainSchemas',
-  templateUrl: 'views/user-plain-schemas.html',
-  resolve: {
-'authenticated': function (AuthenticationHelper) {
-  return AuthenticationHelper.authenticated();
-}
-  }
-

[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266813#comment-15266813
 ] 

ASF GitHub Bot commented on SYNCOPE-798:


Github user mteo closed the pull request at:

https://github.com/apache/syncope/pull/13


> Once authenticated to enduser, "Cancel" brings nowhere 
> ---
>
> Key: SYNCOPE-798
> URL: https://issues.apache.org/jira/browse/SYNCOPE-798
> Project: Syncope
>  Issue Type: Bug
>  Components: enduser
>Affects Versions: 2.0.0-M2
>Reporter: Francesco Chicchiriccò
>Assignee: Matteo Di Carlo
> Fix For: 2.0.0
>
> Attachments: pointless page.png
>
>
> How to reproduce:
>  # log into enduser
>  # hit the red button Cancel on the bottom
>  # you are redirected to an empty page (see screenshot attached)
> Cancel should be equivalent to Logout (so it is really needed? The logout 
> button is already there).
> Incidentally, the same pointless page is returned when accessing 
> /syncope-enduser if authenticated - which looks wrong, the excepted landing 
> page should be first one, e.g. "crendentials".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266552#comment-15266552
 ] 

ASF GitHub Bot commented on SYNCOPE-798:


Github user mteo commented on the pull request:

https://github.com/apache/syncope/pull/13#issuecomment-216227329
  
Pr is completed, now you can take a look.


> Once authenticated to enduser, "Cancel" brings nowhere 
> ---
>
> Key: SYNCOPE-798
> URL: https://issues.apache.org/jira/browse/SYNCOPE-798
> Project: Syncope
>  Issue Type: Bug
>  Components: enduser
>Affects Versions: 2.0.0-M2
>Reporter: Francesco Chicchiriccò
>Assignee: Matteo Di Carlo
> Fix For: 2.0.0
>
> Attachments: pointless page.png
>
>
> How to reproduce:
>  # log into enduser
>  # hit the red button Cancel on the bottom
>  # you are redirected to an empty page (see screenshot attached)
> Cancel should be equivalent to Logout (so it is really needed? The logout 
> button is already there).
> Incidentally, the same pointless page is returned when accessing 
> /syncope-enduser if authenticated - which looks wrong, the excepted landing 
> page should be first one, e.g. "crendentials".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-798) Once authenticated to enduser, "Cancel" brings nowhere

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266566#comment-15266566
 ] 

ASF GitHub Bot commented on SYNCOPE-798:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/13#discussion_r61735681
  
--- Diff: 
client/enduser/src/main/java/org/apache/syncope/client/enduser/SyncopeEnduserApplication.java
 ---
@@ -154,6 +155,16 @@ public IResource getResource() {
 return new LogoutResource();
 }
 });
+
+mountResource("/api/self/islogged", new 
ResourceReference("userAuthentication") {
+
+private static final long serialVersionUID = 
-128426276529456602L;
+
+@Override
+public IResource getResource() {
+return new UserAuthentication();
--- End diff --

Please rename `UserAuthentication` according to its mount point.


> Once authenticated to enduser, "Cancel" brings nowhere 
> ---
>
> Key: SYNCOPE-798
> URL: https://issues.apache.org/jira/browse/SYNCOPE-798
> Project: Syncope
>  Issue Type: Bug
>  Components: enduser
>Affects Versions: 2.0.0-M2
>Reporter: Francesco Chicchiriccò
>Assignee: Matteo Di Carlo
> Fix For: 2.0.0
>
> Attachments: pointless page.png
>
>
> How to reproduce:
>  # log into enduser
>  # hit the red button Cancel on the bottom
>  # you are redirected to an empty page (see screenshot attached)
> Cancel should be equivalent to Logout (so it is really needed? The logout 
> button is already there).
> Incidentally, the same pointless page is returned when accessing 
> /syncope-enduser if authenticated - which looks wrong, the excepted landing 
> page should be first one, e.g. "crendentials".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-828) Russian translation for admin console

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15239899#comment-15239899
 ] 

ASF GitHub Bot commented on SYNCOPE-828:


GitHub user securny opened a pull request:

https://github.com/apache/syncope/pull/12

[SYNCOPE-828] Russian translation for admin console

[SYNCOPE-828] Added russian translation for admin console

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/securny/syncope ru

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/syncope/pull/12.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #12


commit 251b8cbd9ff481319e868a7e3a754329b15dbca0
Author: berezkin 
Date:   2016-04-03T11:57:11Z

Russian locale added

test commit with adding russian locale

commit 9c953038ce639966e83fd90c328305cb9a76944f
Author: berezkin 
Date:   2016-04-03T12:00:52Z

Revert "Russian locale added"

This reverts commit 251b8cbd9ff481319e868a7e3a754329b15dbca0.

commit 0605f608ce02ec3f3e08c37b8f618c1f61081b14
Author: berezkin 
Date:   2016-04-03T12:28:03Z

Added *_ru.properties

Added *_ru.properties files

commit 885ad8ea9f906726277be9f1a3bc2be33594bbc0
Author: securny 
Date:   2016-04-04T18:33:05Z

Added another *_ru.properties

Added another *_ru.properties files

commit 7f98ceece325892a6c8e47312d431144308298c1
Author: securny 
Date:   2016-04-06T19:01:38Z

One more update with *_ru.properties

One more update with *_ru.properties

commit 14f208c1dda61c7c7397f07099dd4dd39639a099
Author: securny 
Date:   2016-04-08T05:13:40Z

Almost finished with *_ru.properties

Almost finished with *_ru.properties. Just 2 files left.

commit 19f5e4a3ad771d2c35bd363381d890d1ea9278b7
Author: securny 
Date:   2016-04-11T08:16:34Z

Done with *_ru.properties

Done with *_ru.properties

commit 247888eaabf079f3a9a2b9daafe05bf61c03e5b2
Author: securny 
Date:   2016-04-11T08:42:32Z

Merge remote-tracking branch 'upstream/master' into ru

commit 6a978331201c42ca58d73f89e35211472a010d0a
Author: securny 
Date:   2016-04-11T17:03:49Z

Added new *_ru.properties

Added new *_ru.properties

commit dc108de2242dd25039e194e828e49593c2c04e40
Author: securny 
Date:   2016-04-11T18:49:21Z

Source code style fixes

Source code style fixes

commit af4a6e47540d64564722b63a6db32ab4852921d7
Author: securny 
Date:   2016-04-11T18:49:38Z

Merge remote-tracking branch 'upstream/master' into ru

commit 795cd6a0287fbcbc571c23e3540771b54976f3b6
Author: securny 
Date:   2016-04-12T07:03:52Z

Added new *_ru.properties files

Added new *_ru.properties files

commit ac1d901ed4b32097b7acec7c47c2425ee52bde62
Author: securny 
Date:   2016-04-12T08:04:58Z

Removing old keys from *_ru.properties

Removing old keys from *_ru.properties

commit e63f1421dc3cbe4982b322d51425d60b0113bd10
Author: securny 
Date:   2016-04-12T13:28:53Z

Merge remote-tracking branch 'upstream/master' into ru

commit a7c62c527f49b98a71008d8274958a85593e963f
Author: securny 
Date:   2016-04-13T12:50:28Z

Merge remote-tracking branch 'upstream/master' into ru

commit f2f9c01658369501ec1df71f2a98936fed63bb03
Author: securny 
Date:   2016-04-13T17:05:11Z

Done with current *_ru.properties

Done with current *_ru.properties files




> Russian translation for admin console
> -
>
> Key: SYNCOPE-828
> URL: https://issues.apache.org/jira/browse/SYNCOPE-828
> Project: Syncope
>  Issue Type: New Feature
>  Components: console
>Reporter: Francesco Chicchiriccò
>Assignee: Dmitry Berezkin
> Fix For: 2.0.0
>
>
> Add Russian to the list of available translations for admin console UI.
> Relevant mail thread: http://markmail.org/message/wrftlbrpswyeeivu



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-880) Identity Recertification

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391583#comment-15391583
 ] 

ASF GitHub Bot commented on SYNCOPE-880:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/26#discussion_r72031798
  
--- Diff: core/persistence-jpa/src/test/resources/domains/MasterContent.xml 
---
@@ -461,7 +470,15 @@ under the License.
   
   
-
+
+  
--- End diff --

Sure, please go ahead.


> Identity Recertification
> 
>
> Key: SYNCOPE-880
> URL: https://issues.apache.org/jira/browse/SYNCOPE-880
> Project: Syncope
>  Issue Type: New Feature
>  Components: core
>Reporter: Nicola Scendoni
>Assignee: Nicola Scendoni
>Priority: Minor
> Fix For: 2.0.0
>
>
> Identify Re-certification is required for many national and international 
> standards like SOX, GxP, etc.
> The idea is to implement one scheduled task that filter users basing on some 
> attributes (example: last recertification date, role,...) and move then on 
> one state "to be certified" and assign one task to some group that has the 
> responsibility to recertified the user, or delete it from the system.
> Some report should report evidence about when the users have been recertified 
> and who was the certifier.
>  
> This feature would be also the starting point to create account, role and 
> groups re-certifications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-880) Identity Recertification

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389024#comment-15389024
 ] 

ASF GitHub Bot commented on SYNCOPE-880:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/26#discussion_r71833155
  
--- Diff: core/workflow-activiti/src/main/resources/userWorkflow.bpmn20.xml 
---
@@ -82,12 +82,47 @@ under the License.
 
 
 
+
+
+  
+ 
+
+
--- End diff --

`approve` and `reason for rejecting` can be fine for test workflow, please 
make them more verbose and appropriate for recertification


> Identity Recertification
> 
>
> Key: SYNCOPE-880
> URL: https://issues.apache.org/jira/browse/SYNCOPE-880
> Project: Syncope
>  Issue Type: New Feature
>  Components: console, core
>Reporter: Nicola Scendoni
>Priority: Minor
>
> Identify Re-certification is required for many national and international 
> standards like SOX, GxP, etc.
> The idea is to implement one scheduled task that filter users basing on some 
> attributes (example: last recertification date, role,...) and move then on 
> one state "to be certified" and assign one task to some group that has the 
> responsibility to recertified the user, or delete it from the system.
> Some report should report evidence about when the users have been recertified 
> and who was the certifier.
>  
> This feature would be also the starting point to create account, role and 
> groups re-certifications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-880) Identity Recertification

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389033#comment-15389033
 ] 

ASF GitHub Bot commented on SYNCOPE-880:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/26#discussion_r71833317
  
--- Diff: 
fit/core-reference/src/main/java/org/apache/syncope/fit/core/reference/TestIdentityRecertification.java
 ---
@@ -0,0 +1,100 @@
+/*
+ * Copyright 2016 The Apache Software Foundation.
--- End diff --

Bad license header


> Identity Recertification
> 
>
> Key: SYNCOPE-880
> URL: https://issues.apache.org/jira/browse/SYNCOPE-880
> Project: Syncope
>  Issue Type: New Feature
>  Components: console, core
>Reporter: Nicola Scendoni
>Priority: Minor
>
> Identify Re-certification is required for many national and international 
> standards like SOX, GxP, etc.
> The idea is to implement one scheduled task that filter users basing on some 
> attributes (example: last recertification date, role,...) and move then on 
> one state "to be certified" and assign one task to some group that has the 
> responsibility to recertified the user, or delete it from the system.
> Some report should report evidence about when the users have been recertified 
> and who was the certifier.
>  
> This feature would be also the starting point to create account, role and 
> groups re-certifications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-880) Identity Recertification

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389032#comment-15389032
 ] 

ASF GitHub Bot commented on SYNCOPE-880:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/26#discussion_r71833309
  
--- Diff: 
core/workflow-java/src/main/java/org/apache/syncope/core/workflow/java/DefaultUserWorkflowAdapter.java
 ---
@@ -207,4 +207,10 @@ public WorkflowFormTO claimForm(final String taskId) {
 throw new WorkflowException(new UnsupportedOperationException("Not 
supported."));
 }
 
+@Override
+public WorkflowResult doRequestCertify(final User user) {
+//Implement here Identity Recertification Process 
--- End diff --

Form processing is not supported by the default adapter, so remove comment 
and change message to "Not supported"


> Identity Recertification
> 
>
> Key: SYNCOPE-880
> URL: https://issues.apache.org/jira/browse/SYNCOPE-880
> Project: Syncope
>  Issue Type: New Feature
>  Components: console, core
>Reporter: Nicola Scendoni
>Priority: Minor
>
> Identify Re-certification is required for many national and international 
> standards like SOX, GxP, etc.
> The idea is to implement one scheduled task that filter users basing on some 
> attributes (example: last recertification date, role,...) and move then on 
> one state "to be certified" and assign one task to some group that has the 
> responsibility to recertified the user, or delete it from the system.
> Some report should report evidence about when the users have been recertified 
> and who was the certifier.
>  
> This feature would be also the starting point to create account, role and 
> groups re-certifications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-880) Identity Recertification

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389030#comment-15389030
 ] 

ASF GitHub Bot commented on SYNCOPE-880:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/26#discussion_r71833259
  
--- Diff: 
core/workflow-api/src/main/java/org/apache/syncope/core/workflow/api/UserWorkflowAdapter.java
 ---
@@ -60,6 +61,10 @@
 WorkflowResult> create(
 UserTO userTO, boolean disablePwdPolicyCheck, final Boolean 
enabled, boolean storePassword);
 
+
+WorkflowResult doRequestCertify(final User user);
--- End diff --

`do*` methods are defined by abstract implementations for inner execution: 
please rename this method as `requestCertify`


> Identity Recertification
> 
>
> Key: SYNCOPE-880
> URL: https://issues.apache.org/jira/browse/SYNCOPE-880
> Project: Syncope
>  Issue Type: New Feature
>  Components: console, core
>Reporter: Nicola Scendoni
>Priority: Minor
>
> Identify Re-certification is required for many national and international 
> standards like SOX, GxP, etc.
> The idea is to implement one scheduled task that filter users basing on some 
> attributes (example: last recertification date, role,...) and move then on 
> one state "to be certified" and assign one task to some group that has the 
> responsibility to recertified the user, or delete it from the system.
> Some report should report evidence about when the users have been recertified 
> and who was the certifier.
>  
> This feature would be also the starting point to create account, role and 
> groups re-certifications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-880) Identity Recertification

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389044#comment-15389044
 ] 

ASF GitHub Bot commented on SYNCOPE-880:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/26#discussion_r71833798
  
--- Diff: 
fit/core-reference/src/test/java/org/apache/syncope/fit/core/RecertificationITCase.java
 ---
@@ -0,0 +1,90 @@
+/*
+ * Copyright 2016 The Apache Software Foundation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.syncope.fit.core;
+
+import java.util.Arrays;
+import java.util.Date;
+import java.util.List;
+import javax.ws.rs.core.Response;
+import org.apache.commons.lang3.time.DateUtils;
+import org.apache.syncope.common.lib.to.SchedTaskTO;
+import org.apache.syncope.common.lib.to.WorkflowFormPropertyTO;
+import org.apache.syncope.common.lib.to.WorkflowFormTO;
+import org.apache.syncope.common.rest.api.beans.ExecuteQuery;
+import org.apache.syncope.common.rest.api.service.TaskService;
+import org.apache.syncope.fit.core.reference.TestIdentityRecertification;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
+import org.junit.FixMethodOrder;
+import org.junit.Test;
+import org.junit.runners.MethodSorters;
+
+@FixMethodOrder(MethodSorters.JVM)
+public class RecertificationITCase extends AbstractTaskITCase{
+
+private void runRecertTask() {
+SchedTaskTO task = new SchedTaskTO();
+task.setActive(true);
+task.setName("IdentityRecert");
+
task.setJobDelegateClassName(TestIdentityRecertification.class.getName());
+
+Response response = taskService.create(task);
+task = getObject(response.getLocation(), TaskService.class, 
SchedTaskTO.class);
+assertNotNull(task);
+
+Date initial = new Date();
+Date later = DateUtils.addSeconds(initial, 2);
+
+taskService.execute(new 
ExecuteQuery.Builder().key(task.getKey()).startAt(later).build());
--- End diff --

Any particular reason for not executing the task via 
`AbstractTaskITCase#execTask`?


> Identity Recertification
> 
>
> Key: SYNCOPE-880
> URL: https://issues.apache.org/jira/browse/SYNCOPE-880
> Project: Syncope
>  Issue Type: New Feature
>  Components: console, core
>Reporter: Nicola Scendoni
>Priority: Minor
> Fix For: 2.0.0
>
>
> Identify Re-certification is required for many national and international 
> standards like SOX, GxP, etc.
> The idea is to implement one scheduled task that filter users basing on some 
> attributes (example: last recertification date, role,...) and move then on 
> one state "to be certified" and assign one task to some group that has the 
> responsibility to recertified the user, or delete it from the system.
> Some report should report evidence about when the users have been recertified 
> and who was the certifier.
>  
> This feature would be also the starting point to create account, role and 
> groups re-certifications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-880) Identity Recertification

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389018#comment-15389018
 ] 

ASF GitHub Bot commented on SYNCOPE-880:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/26#discussion_r71833002
  
--- Diff: 
core/workflow-activiti/src/main/java/org/apache/syncope/core/workflow/activiti/task/Recertify.java
 ---
@@ -0,0 +1,102 @@
+/*
+ * Copyright 2016 The Apache Software Foundation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.syncope.core.workflow.activiti.task;
+
+import java.text.DateFormat;
+import java.text.SimpleDateFormat;
+import java.util.Date;
+import org.apache.syncope.common.lib.types.AnyTypeKind;
+import org.apache.syncope.core.persistence.api.dao.PlainSchemaDAO;
+import org.apache.syncope.core.persistence.api.dao.UserDAO;
+import org.apache.syncope.core.persistence.api.entity.AnyUtilsFactory;
+import org.apache.syncope.core.persistence.api.entity.EntityFactory;
+import org.apache.syncope.core.persistence.api.entity.PlainSchema;
+import org.apache.syncope.core.persistence.api.entity.user.UPlainAttr;
+import org.apache.syncope.core.persistence.api.entity.user.User;
+import 
org.apache.syncope.core.workflow.activiti.ActivitiUserWorkflowAdapter;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.stereotype.Component;
+
+@Component
+public class Recertify extends AbstractActivitiServiceTask {
+
+public static final String LAST_RECERTIFICATOR_ATTR = 
"lastRecertificator";
+
+public static final String LAST_RECERTIFICATION_ATTR = 
"lastRecertification";
+
+public static final String RECERTIFICATION_TIME = 
"identity.recertification.day.interval";
+
+@Autowired
+protected UserDAO userDAO;
+
+@Autowired
+protected EntityFactory entityFactory;
+
+@Autowired
+private PlainSchemaDAO plainSchemaDAO;
+
+@Autowired
+protected AnyUtilsFactory anyUtilsFactory;
+
+private PlainSchema lastRecertificationSchema;
+
+private PlainSchema lastRecertificatorSchema;
+
+@Override
+protected void doExecute(final String executionId) {
+
+LOG.debug("Processing Recertification {}", executionId);
+User user = engine.getRuntimeService().
+getVariable(executionId, ActivitiUserWorkflowAdapter.USER, 
User.class);
+String submitter = engine.getRuntimeService().
+getVariable(executionId, 
ActivitiUserWorkflowAdapter.FORM_SUBMITTER, String.class);
+
+LOG.debug("Saving Recertification information for user {}", 
user.getUsername());
+
+lastRecertificatorSchema = 
plainSchemaDAO.find(LAST_RECERTIFICATOR_ATTR);
+lastRecertificationSchema = 
plainSchemaDAO.find(LAST_RECERTIFICATION_ATTR);
+setSchemaReadonly(false);
+
+
+UPlainAttr recertifierAttr = 
entityFactory.newEntity(UPlainAttr.class);
+recertifierAttr.setOwner(user);
+recertifierAttr.setSchema(lastRecertificatorSchema);
+
+recertifierAttr.add(submitter, 
anyUtilsFactory.getInstance(AnyTypeKind.USER));
+
+DateFormat format = new 
SimpleDateFormat(lastRecertificationSchema.getConversionPattern());
+String recertificationDate = format.format(new Date());
+UPlainAttr recertAttr = entityFactory.newEntity(UPlainAttr.class);
+recertAttr.setOwner(user);
+recertAttr.setSchema(lastRecertificationSchema);
+
+recertAttr.add(recertificationDate, 
anyUtilsFactory.getInstance(AnyTypeKind.USER));
+
+user.add(recertAttr);
+user.add(recertifierAttr);
+
+setSchemaReadonly(true);
+
+userDAO.save(user);
+}
+
+private void setSchemaReadonly(final boolean readonly) {
--- End diff --

This method can be removed for the same reasons stated above for static 
fields; however, it wasn't needed anyway as read-only attributes are meant for 
being managed via DAO rather than via 

[jira] [Commented] (SYNCOPE-880) Identity Recertification

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389026#comment-15389026
 ] 

ASF GitHub Bot commented on SYNCOPE-880:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/26#discussion_r71833186
  
--- Diff: core/workflow-activiti/src/main/resources/userWorkflow.bpmn20.xml 
---
@@ -229,4 +284,4 @@ under the License.
   
 
   
-
--- End diff --

Please avoid such modifications (blank lines at the end of files) if 
possible


> Identity Recertification
> 
>
> Key: SYNCOPE-880
> URL: https://issues.apache.org/jira/browse/SYNCOPE-880
> Project: Syncope
>  Issue Type: New Feature
>  Components: console, core
>Reporter: Nicola Scendoni
>Priority: Minor
>
> Identify Re-certification is required for many national and international 
> standards like SOX, GxP, etc.
> The idea is to implement one scheduled task that filter users basing on some 
> attributes (example: last recertification date, role,...) and move then on 
> one state "to be certified" and assign one task to some group that has the 
> responsibility to recertified the user, or delete it from the system.
> Some report should report evidence about when the users have been recertified 
> and who was the certifier.
>  
> This feature would be also the starting point to create account, role and 
> groups re-certifications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-880) Identity Recertification

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389038#comment-15389038
 ] 

ASF GitHub Bot commented on SYNCOPE-880:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/26#discussion_r71833563
  
--- Diff: 
fit/core-reference/src/main/java/org/apache/syncope/fit/core/reference/TestIdentityRecertification.java
 ---
@@ -0,0 +1,100 @@
+/*
+ * Copyright 2016 The Apache Software Foundation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.syncope.fit.core.reference;
+
+import java.util.Date;
+import org.apache.syncope.core.persistence.api.dao.ConfDAO;
+import org.apache.syncope.core.persistence.api.dao.UserDAO;
+import org.apache.syncope.core.persistence.api.entity.conf.CPlainAttr;
+import org.apache.syncope.core.persistence.api.entity.user.UPlainAttr;
+import 
org.apache.syncope.core.persistence.api.entity.user.UPlainAttrUniqueValue;
+import org.apache.syncope.core.persistence.api.entity.user.User;
+import 
org.apache.syncope.core.provisioning.java.job.AbstractSchedTaskJobDelegate;
+import org.apache.syncope.core.workflow.activiti.task.Recertify;
+import org.apache.syncope.core.workflow.api.UserWorkflowAdapter;
+import org.quartz.JobExecutionException;
+import org.springframework.beans.factory.annotation.Autowired;
+
+public class TestIdentityRecertification extends 
AbstractSchedTaskJobDelegate {
--- End diff --

Please explain why this class (e.g. the actual recertification task) is 
placed here (hence in the code only used for tests) rather than in the 
`core/workflow-java` Maven module


> Identity Recertification
> 
>
> Key: SYNCOPE-880
> URL: https://issues.apache.org/jira/browse/SYNCOPE-880
> Project: Syncope
>  Issue Type: New Feature
>  Components: console, core
>Reporter: Nicola Scendoni
>Priority: Minor
>
> Identify Re-certification is required for many national and international 
> standards like SOX, GxP, etc.
> The idea is to implement one scheduled task that filter users basing on some 
> attributes (example: last recertification date, role,...) and move then on 
> one state "to be certified" and assign one task to some group that has the 
> responsibility to recertified the user, or delete it from the system.
> Some report should report evidence about when the users have been recertified 
> and who was the certifier.
>  
> This feature would be also the starting point to create account, role and 
> groups re-certifications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-880) Identity Recertification

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389040#comment-15389040
 ] 

ASF GitHub Bot commented on SYNCOPE-880:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/26#discussion_r71833609
  
--- Diff: 
fit/core-reference/src/test/java/org/apache/syncope/fit/core/RecertificationITCase.java
 ---
@@ -0,0 +1,90 @@
+/*
--- End diff --

Bad license header


> Identity Recertification
> 
>
> Key: SYNCOPE-880
> URL: https://issues.apache.org/jira/browse/SYNCOPE-880
> Project: Syncope
>  Issue Type: New Feature
>  Components: console, core
>Reporter: Nicola Scendoni
>Priority: Minor
>
> Identify Re-certification is required for many national and international 
> standards like SOX, GxP, etc.
> The idea is to implement one scheduled task that filter users basing on some 
> attributes (example: last recertification date, role,...) and move then on 
> one state "to be certified" and assign one task to some group that has the 
> responsibility to recertified the user, or delete it from the system.
> Some report should report evidence about when the users have been recertified 
> and who was the certifier.
>  
> This feature would be also the starting point to create account, role and 
> groups re-certifications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-880) Identity Recertification

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389048#comment-15389048
 ] 

ASF GitHub Bot commented on SYNCOPE-880:


Github user ilgrosso commented on the issue:

https://github.com/apache/syncope/pull/26
  
@nscendoni thanks for your work: I have added some minor comments.

Once addressed, please also rebase and squash and I'd say we'll be ready to 
merge this PR.

As you might have seen, I have assigned SYNCOPE-880 to you and also set the 
fix version to 2.0.0 (meaning that this work is expected to be part of next 
stable release).

Nice job!


> Identity Recertification
> 
>
> Key: SYNCOPE-880
> URL: https://issues.apache.org/jira/browse/SYNCOPE-880
> Project: Syncope
>  Issue Type: New Feature
>  Components: console, core
>Reporter: Nicola Scendoni
>Assignee: Nicola Scendoni
>Priority: Minor
> Fix For: 2.0.0
>
>
> Identify Re-certification is required for many national and international 
> standards like SOX, GxP, etc.
> The idea is to implement one scheduled task that filter users basing on some 
> attributes (example: last recertification date, role,...) and move then on 
> one state "to be certified" and assign one task to some group that has the 
> responsibility to recertified the user, or delete it from the system.
> Some report should report evidence about when the users have been recertified 
> and who was the certifier.
>  
> This feature would be also the starting point to create account, role and 
> groups re-certifications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-809) Eclipse plugin

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389119#comment-15389119
 ] 

ASF GitHub Bot commented on SYNCOPE-809:


Github user ilgrosso commented on the issue:

https://github.com/apache/syncope/pull/28
  
I have made some adjustments to Maven and now things seem to work fine: 
please review and apply the attached 
[SYNCOPE-809-Maven-diff.txt](https://github.com/apache/syncope/files/377683/SYNCOPE-809-Maven-diff.txt)
 (it's the output of `git diff`, you can apply it with `patch -p1`) to your 
fork, then commit.

Once done that, I'd say we still have to  address an issue before merging: 
I have noticed that the P2 site contains under `repository/plugins/` several 
JAR files which should IMO downloaded from elsewhere (e.g. the main Eclipse 
update site): do you think it could be possible to leave just 
`org.apache.syncope.ide.eclipse.plugin_XXX.jar` there?

Other tasks that can be handled **after** merging this PR:

1. Multiple LICENSE / NOTICE files are available in the generated P2 site: 
they should all removed and new ones should be provided on the root directory 
of the P2 site, reflecting the actual content of 
`org.apache.syncope.ide.eclipse.plugin_XXX.jar` (I can take care of this)

1. The [release process](http://syncope.apache.org/release-process.html) 
needs to be adjusted for manually signing the artifacts in the P2 site (I can 
take care of this)

1. Various functional and non-functional improvements to plugin features




> Eclipse plugin
> --
>
> Key: SYNCOPE-809
> URL: https://issues.apache.org/jira/browse/SYNCOPE-809
> Project: Syncope
>  Issue Type: Sub-task
> Environment: Eclipse
>Reporter: Francesco Chicchiriccò
>Assignee: Tushar Mishra
>  Labels: eclipse, gsoc2016
>
> Develop a plug-in, according to what reported in SYNCOPE-770, working with 
> latest Eclipse version.
> See Google Summer of Code project proposal at 
> https://summerofcode.withgoogle.com/projects/#4822214733987840



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-880) Identity Recertification

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389006#comment-15389006
 ] 

ASF GitHub Bot commented on SYNCOPE-880:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/26#discussion_r71832626
  
--- Diff: 
core/workflow-activiti/src/main/java/org/apache/syncope/core/workflow/activiti/ActivitiUserWorkflowAdapter.java
 ---
@@ -349,11 +349,33 @@ protected void saveForFormSubmit(final User user, 
final String password, final P
 }
 
 @Override
+public WorkflowResult doRequestCertify(final User user) {
+String authUser = AuthContextUtils.getUsername();
+engine.getRuntimeService().setVariable(user.getWorkflowId(), 
FORM_SUBMITTER, authUser);
+
+LOG.debug("Executing request-certify");
+Set performedTasks = doExecuteTask(user, 
"request-certify", null);
+for (String s: performedTasks) {
--- End diff --

Please remove this debug loop (other methods of this class do not have it)


> Identity Recertification
> 
>
> Key: SYNCOPE-880
> URL: https://issues.apache.org/jira/browse/SYNCOPE-880
> Project: Syncope
>  Issue Type: New Feature
>  Components: console, core
>Reporter: Nicola Scendoni
>Priority: Minor
>
> Identify Re-certification is required for many national and international 
> standards like SOX, GxP, etc.
> The idea is to implement one scheduled task that filter users basing on some 
> attributes (example: last recertification date, role,...) and move then on 
> one state "to be certified" and assign one task to some group that has the 
> responsibility to recertified the user, or delete it from the system.
> Some report should report evidence about when the users have been recertified 
> and who was the certifier.
>  
> This feature would be also the starting point to create account, role and 
> groups re-certifications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-880) Identity Recertification

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389008#comment-15389008
 ] 

ASF GitHub Bot commented on SYNCOPE-880:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/26#discussion_r71832647
  
--- Diff: 
core/workflow-activiti/src/main/java/org/apache/syncope/core/workflow/activiti/ActivitiUserWorkflowAdapter.java
 ---
@@ -349,11 +349,33 @@ protected void saveForFormSubmit(final User user, 
final String password, final P
 }
 
 @Override
+public WorkflowResult doRequestCertify(final User user) {
+String authUser = AuthContextUtils.getUsername();
+engine.getRuntimeService().setVariable(user.getWorkflowId(), 
FORM_SUBMITTER, authUser);
+
+LOG.debug("Executing request-certify");
+Set performedTasks = doExecuteTask(user, 
"request-certify", null);
+for (String s: performedTasks) {
+LOG.debug("request-certity: {}", s);
+}
+LOG.debug("request-certify performed");
+
+PropagationByResource propByRes = 
engine.getRuntimeService().getVariable(
+user.getWorkflowId(), PROP_BY_RESOURCE, 
PropagationByResource.class);
+
+saveForFormSubmit(
+user, null, propByRes);
+
+return new WorkflowResult<>(user.getKey(), null, performedTasks);
+}
+
+@Override
 protected WorkflowResult doSuspend(final User user) {
 Set performedTasks = doExecuteTask(user, "suspend", null);
 updateStatus(user);
 User updated = userDAO.save(user);
 
+
--- End diff --

Please remove this blank line.


> Identity Recertification
> 
>
> Key: SYNCOPE-880
> URL: https://issues.apache.org/jira/browse/SYNCOPE-880
> Project: Syncope
>  Issue Type: New Feature
>  Components: console, core
>Reporter: Nicola Scendoni
>Priority: Minor
>
> Identify Re-certification is required for many national and international 
> standards like SOX, GxP, etc.
> The idea is to implement one scheduled task that filter users basing on some 
> attributes (example: last recertification date, role,...) and move then on 
> one state "to be certified" and assign one task to some group that has the 
> responsibility to recertified the user, or delete it from the system.
> Some report should report evidence about when the users have been recertified 
> and who was the certifier.
>  
> This feature would be also the starting point to create account, role and 
> groups re-certifications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-880) Identity Recertification

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389010#comment-15389010
 ] 

ASF GitHub Bot commented on SYNCOPE-880:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/26#discussion_r71832672
  
--- Diff: 
core/workflow-activiti/src/main/java/org/apache/syncope/core/workflow/activiti/task/Recertify.java
 ---
@@ -0,0 +1,102 @@
+/*
--- End diff --

Bad license header


> Identity Recertification
> 
>
> Key: SYNCOPE-880
> URL: https://issues.apache.org/jira/browse/SYNCOPE-880
> Project: Syncope
>  Issue Type: New Feature
>  Components: console, core
>Reporter: Nicola Scendoni
>Priority: Minor
>
> Identify Re-certification is required for many national and international 
> standards like SOX, GxP, etc.
> The idea is to implement one scheduled task that filter users basing on some 
> attributes (example: last recertification date, role,...) and move then on 
> one state "to be certified" and assign one task to some group that has the 
> responsibility to recertified the user, or delete it from the system.
> Some report should report evidence about when the users have been recertified 
> and who was the certifier.
>  
> This feature would be also the starting point to create account, role and 
> groups re-certifications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-880) Identity Recertification

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389015#comment-15389015
 ] 

ASF GitHub Bot commented on SYNCOPE-880:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/26#discussion_r71832883
  
--- Diff: 
core/workflow-activiti/src/main/java/org/apache/syncope/core/workflow/activiti/task/Recertify.java
 ---
@@ -0,0 +1,102 @@
+/*
+ * Copyright 2016 The Apache Software Foundation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.syncope.core.workflow.activiti.task;
+
+import java.text.DateFormat;
+import java.text.SimpleDateFormat;
+import java.util.Date;
+import org.apache.syncope.common.lib.types.AnyTypeKind;
+import org.apache.syncope.core.persistence.api.dao.PlainSchemaDAO;
+import org.apache.syncope.core.persistence.api.dao.UserDAO;
+import org.apache.syncope.core.persistence.api.entity.AnyUtilsFactory;
+import org.apache.syncope.core.persistence.api.entity.EntityFactory;
+import org.apache.syncope.core.persistence.api.entity.PlainSchema;
+import org.apache.syncope.core.persistence.api.entity.user.UPlainAttr;
+import org.apache.syncope.core.persistence.api.entity.user.User;
+import 
org.apache.syncope.core.workflow.activiti.ActivitiUserWorkflowAdapter;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.stereotype.Component;
+
+@Component
+public class Recertify extends AbstractActivitiServiceTask {
+
+public static final String LAST_RECERTIFICATOR_ATTR = 
"lastRecertificator";
--- End diff --

Such static fields can be removed once settling `lastRecertificator` / 
`lastRecertification` as class fields.


> Identity Recertification
> 
>
> Key: SYNCOPE-880
> URL: https://issues.apache.org/jira/browse/SYNCOPE-880
> Project: Syncope
>  Issue Type: New Feature
>  Components: console, core
>Reporter: Nicola Scendoni
>Priority: Minor
>
> Identify Re-certification is required for many national and international 
> standards like SOX, GxP, etc.
> The idea is to implement one scheduled task that filter users basing on some 
> attributes (example: last recertification date, role,...) and move then on 
> one state "to be certified" and assign one task to some group that has the 
> responsibility to recertified the user, or delete it from the system.
> Some report should report evidence about when the users have been recertified 
> and who was the certifier.
>  
> This feature would be also the starting point to create account, role and 
> groups re-certifications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-880) Identity Recertification

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389013#comment-15389013
 ] 

ASF GitHub Bot commented on SYNCOPE-880:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/26#discussion_r71832801
  
--- Diff: core/persistence-jpa/src/test/resources/domains/MasterContent.xml 
---
@@ -461,7 +470,15 @@ under the License.
   
   
-
+
+  
--- End diff --

We should probably better handle `lastRecertification` and 
`lastRecertificator` rather as `User` / `JPAUser` fields rather than schemas.


> Identity Recertification
> 
>
> Key: SYNCOPE-880
> URL: https://issues.apache.org/jira/browse/SYNCOPE-880
> Project: Syncope
>  Issue Type: New Feature
>  Components: console, core
>Reporter: Nicola Scendoni
>Priority: Minor
>
> Identify Re-certification is required for many national and international 
> standards like SOX, GxP, etc.
> The idea is to implement one scheduled task that filter users basing on some 
> attributes (example: last recertification date, role,...) and move then on 
> one state "to be certified" and assign one task to some group that has the 
> responsibility to recertified the user, or delete it from the system.
> Some report should report evidence about when the users have been recertified 
> and who was the certifier.
>  
> This feature would be also the starting point to create account, role and 
> groups re-certifications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-872) Type extensions not considered for user form

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404255#comment-15404255
 ] 

ASF GitHub Bot commented on SYNCOPE-872:


Github user ilgrosso commented on the issue:

https://github.com/apache/syncope/pull/30
  
I have made some comments: please address them. then rebase (there are 
unresolved conflicts ATM) and finally sqash into a single commit.

Please also change the subject to something mentioning SYNCOPE-872 (to get 
automatically linked on JIRA),


> Type extensions not considered for user form
> 
>
> Key: SYNCOPE-872
> URL: https://issues.apache.org/jira/browse/SYNCOPE-872
> Project: Syncope
>  Issue Type: Bug
>  Components: enduser
>Reporter: Francesco Chicchiriccò
>Assignee: Matteo Di Carlo
> Fix For: 2.0.0
>
>
> How to reproduce:
> # Define type extension for group G, adding AnyTypeClass C to users
> # Create a new user, assign group G
> You should see (also) attributes defined in C, but you don't.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-809) Eclipse plugin

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405414#comment-15405414
 ] 

ASF GitHub Bot commented on SYNCOPE-809:


Github user ilgrosso commented on the issue:

https://github.com/apache/syncope/pull/31
  
I've added some comments, please address.

I am also adding explicit reference to SYNCOPE-809 so that this PR gets 
linked to JIRA (as the "Syncope 809" subject won't work for this purpose).


> Eclipse plugin
> --
>
> Key: SYNCOPE-809
> URL: https://issues.apache.org/jira/browse/SYNCOPE-809
> Project: Syncope
>  Issue Type: Sub-task
>  Components: ide
> Environment: Eclipse
>Reporter: Francesco Chicchiriccò
>Assignee: Tushar Mishra
>  Labels: eclipse, gsoc2016
> Fix For: 2.0.0
>
>
> Develop a plug-in, according to what reported in SYNCOPE-770, working with 
> latest Eclipse version.
> See Google Summer of Code project proposal at 
> https://summerofcode.withgoogle.com/projects/#4822214733987840



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-872) Type extensions not considered for user form

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406151#comment-15406151
 ] 

ASF GitHub Bot commented on SYNCOPE-872:


Github user mteo closed the pull request at:

https://github.com/apache/syncope/pull/30


> Type extensions not considered for user form
> 
>
> Key: SYNCOPE-872
> URL: https://issues.apache.org/jira/browse/SYNCOPE-872
> Project: Syncope
>  Issue Type: Bug
>  Components: enduser
>Reporter: Francesco Chicchiriccò
>Assignee: Matteo Di Carlo
> Fix For: 2.0.0
>
>
> How to reproduce:
> # Define type extension for group G, adding AnyTypeClass C to users
> # Create a new user, assign group G
> You should see (also) attributes defined in C, but you don't.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-872) Type extensions not considered for user form

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406150#comment-15406150
 ] 

ASF GitHub Bot commented on SYNCOPE-872:


Github user mteo commented on the issue:

https://github.com/apache/syncope/pull/30
  
manually committed with 343b3d400fd2457e2458c52eacd03af17c51dbac


> Type extensions not considered for user form
> 
>
> Key: SYNCOPE-872
> URL: https://issues.apache.org/jira/browse/SYNCOPE-872
> Project: Syncope
>  Issue Type: Bug
>  Components: enduser
>Reporter: Francesco Chicchiriccò
>Assignee: Matteo Di Carlo
> Fix For: 2.0.0
>
>
> How to reproduce:
> # Define type extension for group G, adding AnyTypeClass C to users
> # Create a new user, assign group G
> You should see (also) attributes defined in C, but you don't.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-880) Identity Recertification

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420326#comment-15420326
 ] 

ASF GitHub Bot commented on SYNCOPE-880:


Github user nscendoni commented on a diff in the pull request:

https://github.com/apache/syncope/pull/26#discussion_r74701618
  
--- Diff: 
fit/core-reference/src/main/java/org/apache/syncope/fit/core/reference/TestIdentityRecertification.java
 ---
@@ -0,0 +1,100 @@
+/*
+ * Copyright 2016 The Apache Software Foundation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.syncope.fit.core.reference;
+
+import java.util.Date;
+import org.apache.syncope.core.persistence.api.dao.ConfDAO;
+import org.apache.syncope.core.persistence.api.dao.UserDAO;
+import org.apache.syncope.core.persistence.api.entity.conf.CPlainAttr;
+import org.apache.syncope.core.persistence.api.entity.user.UPlainAttr;
+import 
org.apache.syncope.core.persistence.api.entity.user.UPlainAttrUniqueValue;
+import org.apache.syncope.core.persistence.api.entity.user.User;
+import 
org.apache.syncope.core.provisioning.java.job.AbstractSchedTaskJobDelegate;
+import org.apache.syncope.core.workflow.activiti.task.Recertify;
+import org.apache.syncope.core.workflow.api.UserWorkflowAdapter;
+import org.quartz.JobExecutionException;
+import org.springframework.beans.factory.annotation.Autowired;
+
+public class TestIdentityRecertification extends 
AbstractSchedTaskJobDelegate {
--- End diff --

Another advice regarding this topic. I did not added the task in the 
production MasterContent.xml. I guess that this should be added by 
administrator according to their needs. Please let me know if you agree with 
this approach


> Identity Recertification
> 
>
> Key: SYNCOPE-880
> URL: https://issues.apache.org/jira/browse/SYNCOPE-880
> Project: Syncope
>  Issue Type: New Feature
>  Components: core
>Reporter: Nicola Scendoni
>Assignee: Nicola Scendoni
>Priority: Minor
> Fix For: 2.0.0
>
>
> Identify Re-certification is required for many national and international 
> standards like SOX, GxP, etc.
> The idea is to implement one scheduled task that filter users basing on some 
> attributes (example: last recertification date, role,...) and move then on 
> one state "to be certified" and assign one task to some group that has the 
> responsibility to recertified the user, or delete it from the system.
> Some report should report evidence about when the users have been recertified 
> and who was the certifier.
>  
> This feature would be also the starting point to create account, role and 
> groups re-certifications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-880) Identity Recertification

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420324#comment-15420324
 ] 

ASF GitHub Bot commented on SYNCOPE-880:


Github user nscendoni commented on a diff in the pull request:

https://github.com/apache/syncope/pull/26#discussion_r74701544
  
--- Diff: 
fit/core-reference/src/main/java/org/apache/syncope/fit/core/reference/TestIdentityRecertification.java
 ---
@@ -0,0 +1,100 @@
+/*
+ * Copyright 2016 The Apache Software Foundation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.syncope.fit.core.reference;
+
+import java.util.Date;
+import org.apache.syncope.core.persistence.api.dao.ConfDAO;
+import org.apache.syncope.core.persistence.api.dao.UserDAO;
+import org.apache.syncope.core.persistence.api.entity.conf.CPlainAttr;
+import org.apache.syncope.core.persistence.api.entity.user.UPlainAttr;
+import 
org.apache.syncope.core.persistence.api.entity.user.UPlainAttrUniqueValue;
+import org.apache.syncope.core.persistence.api.entity.user.User;
+import 
org.apache.syncope.core.provisioning.java.job.AbstractSchedTaskJobDelegate;
+import org.apache.syncope.core.workflow.activiti.task.Recertify;
+import org.apache.syncope.core.workflow.api.UserWorkflowAdapter;
+import org.quartz.JobExecutionException;
+import org.springframework.beans.factory.annotation.Autowired;
+
+public class TestIdentityRecertification extends 
AbstractSchedTaskJobDelegate {
--- End diff --

The only reason was to extend AbstractSchedTaskJobDelegate without 
modifying dependencies.
I'm refactoring this code to implement SchedTaskJobDelegate interface. 
Please advice if you have a better advice


> Identity Recertification
> 
>
> Key: SYNCOPE-880
> URL: https://issues.apache.org/jira/browse/SYNCOPE-880
> Project: Syncope
>  Issue Type: New Feature
>  Components: core
>Reporter: Nicola Scendoni
>Assignee: Nicola Scendoni
>Priority: Minor
> Fix For: 2.0.0
>
>
> Identify Re-certification is required for many national and international 
> standards like SOX, GxP, etc.
> The idea is to implement one scheduled task that filter users basing on some 
> attributes (example: last recertification date, role,...) and move then on 
> one state "to be certified" and assign one task to some group that has the 
> responsibility to recertified the user, or delete it from the system.
> Some report should report evidence about when the users have been recertified 
> and who was the certifier.
>  
> This feature would be also the starting point to create account, role and 
> groups re-certifications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-880) Identity Recertification

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420328#comment-15420328
 ] 

ASF GitHub Bot commented on SYNCOPE-880:


Github user nscendoni commented on a diff in the pull request:

https://github.com/apache/syncope/pull/26#discussion_r74701636
  
--- Diff: core/workflow-activiti/src/main/resources/userWorkflow.bpmn20.xml 
---
@@ -82,12 +82,47 @@ under the License.
 
 
 
+
+
--- End diff --

I removed it. I guess we need to have more flexibility on recertifier 
assignment. I'll open a new ISSUE in jira with some proposal.


> Identity Recertification
> 
>
> Key: SYNCOPE-880
> URL: https://issues.apache.org/jira/browse/SYNCOPE-880
> Project: Syncope
>  Issue Type: New Feature
>  Components: core
>Reporter: Nicola Scendoni
>Assignee: Nicola Scendoni
>Priority: Minor
> Fix For: 2.0.0
>
>
> Identify Re-certification is required for many national and international 
> standards like SOX, GxP, etc.
> The idea is to implement one scheduled task that filter users basing on some 
> attributes (example: last recertification date, role,...) and move then on 
> one state "to be certified" and assign one task to some group that has the 
> responsibility to recertified the user, or delete it from the system.
> Some report should report evidence about when the users have been recertified 
> and who was the certifier.
>  
> This feature would be also the starting point to create account, role and 
> groups re-certifications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-828) Russian translation for admin console

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414902#comment-15414902
 ] 

ASF GitHub Bot commented on SYNCOPE-828:


Github user asfgit closed the pull request at:

https://github.com/apache/syncope/pull/33


> Russian translation for admin console
> -
>
> Key: SYNCOPE-828
> URL: https://issues.apache.org/jira/browse/SYNCOPE-828
> Project: Syncope
>  Issue Type: New Feature
>  Components: console
>Reporter: Francesco Chicchiriccò
>Assignee: Dmitry Berezkin
> Fix For: 2.0.0-M3
>
>
> Add Russian to the list of available translations for admin console UI.
> Relevant mail thread: http://markmail.org/message/wrftlbrpswyeeivu



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-880) Identity Recertification

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416719#comment-15416719
 ] 

ASF GitHub Bot commented on SYNCOPE-880:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/26#discussion_r74380625
  
--- Diff: 
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/user/JPAUser.java
 ---
@@ -184,6 +185,14 @@
 @Column(nullable = true)
 private String securityAnswer;
 
+@Column(nullable = true)
+private String lastRecertificator;
+
+@Column(nullable = true)
+@Temporal(TemporalType.TIMESTAMP)
+private Date lastRecertificion;
--- End diff --

Fix spell `lastRecertification`


> Identity Recertification
> 
>
> Key: SYNCOPE-880
> URL: https://issues.apache.org/jira/browse/SYNCOPE-880
> Project: Syncope
>  Issue Type: New Feature
>  Components: core
>Reporter: Nicola Scendoni
>Assignee: Nicola Scendoni
>Priority: Minor
> Fix For: 2.0.0
>
>
> Identify Re-certification is required for many national and international 
> standards like SOX, GxP, etc.
> The idea is to implement one scheduled task that filter users basing on some 
> attributes (example: last recertification date, role,...) and move then on 
> one state "to be certified" and assign one task to some group that has the 
> responsibility to recertified the user, or delete it from the system.
> Some report should report evidence about when the users have been recertified 
> and who was the certifier.
>  
> This feature would be also the starting point to create account, role and 
> groups re-certifications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-880) Identity Recertification

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416716#comment-15416716
 ] 

ASF GitHub Bot commented on SYNCOPE-880:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/26#discussion_r74380553
  
--- Diff: 
core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/user/User.java
 ---
@@ -96,4 +96,12 @@
 
 List getRoles();
 
+String getLastRecertificator();
+
+void setLastRecertificator(String lastRecertificator);
+
+Date getLastRecertificion();
--- End diff --

Fix spell: `getLastRecertification()`


> Identity Recertification
> 
>
> Key: SYNCOPE-880
> URL: https://issues.apache.org/jira/browse/SYNCOPE-880
> Project: Syncope
>  Issue Type: New Feature
>  Components: core
>Reporter: Nicola Scendoni
>Assignee: Nicola Scendoni
>Priority: Minor
> Fix For: 2.0.0
>
>
> Identify Re-certification is required for many national and international 
> standards like SOX, GxP, etc.
> The idea is to implement one scheduled task that filter users basing on some 
> attributes (example: last recertification date, role,...) and move then on 
> one state "to be certified" and assign one task to some group that has the 
> responsibility to recertified the user, or delete it from the system.
> Some report should report evidence about when the users have been recertified 
> and who was the certifier.
>  
> This feature would be also the starting point to create account, role and 
> groups re-certifications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-880) Identity Recertification

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416718#comment-15416718
 ] 

ASF GitHub Bot commented on SYNCOPE-880:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/26#discussion_r74380581
  
--- Diff: 
core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/user/User.java
 ---
@@ -96,4 +96,12 @@
 
 List getRoles();
 
+String getLastRecertificator();
+
+void setLastRecertificator(String lastRecertificator);
+
+Date getLastRecertificion();
+
+void setLastRecertificion(Date lastRecertificion);
--- End diff --

Fix spell: setLastRecertification(Date lastRecertification)`


> Identity Recertification
> 
>
> Key: SYNCOPE-880
> URL: https://issues.apache.org/jira/browse/SYNCOPE-880
> Project: Syncope
>  Issue Type: New Feature
>  Components: core
>Reporter: Nicola Scendoni
>Assignee: Nicola Scendoni
>Priority: Minor
> Fix For: 2.0.0
>
>
> Identify Re-certification is required for many national and international 
> standards like SOX, GxP, etc.
> The idea is to implement one scheduled task that filter users basing on some 
> attributes (example: last recertification date, role,...) and move then on 
> one state "to be certified" and assign one task to some group that has the 
> responsibility to recertified the user, or delete it from the system.
> Some report should report evidence about when the users have been recertified 
> and who was the certifier.
>  
> This feature would be also the starting point to create account, role and 
> groups re-certifications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-809) Eclipse plugin

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387239#comment-15387239
 ] 

ASF GitHub Bot commented on SYNCOPE-809:


Github user tmess567 commented on a diff in the pull request:

https://github.com/apache/syncope/pull/28#discussion_r71652297
  
--- Diff: 
ide/eclipse/bundles/org.apache.syncope.ide.eclipse.plugin/META-INF/MANIFEST.MF 
---
@@ -0,0 +1,48 @@
+Manifest-Version: 1.0
+Bundle-ManifestVersion: 2
+Bundle-Name: Plugin
+Bundle-SymbolicName: org.apache.syncope.ide.eclipse.plugin;singleton:=true
+Bundle-Version: 2.0.0.qualifier
--- End diff --

The qualifier maps to STANDALONE
Which is why the jar, the archive and the p2 site built is named 
"org.apache.syncope.ide.eclipse.plugin-2.0.0-SNAPSHOT"

The version number can be changed using a plugin.properties file, but this 
will again lead to the same problems as faced in [this 
issue](https://github.com/tmess567/SYNCOPE-809/issues/9). 

Also, this version number must be the same as in the pom or else it will 
throw the following error.
```
[ERROR] Failed to execute goal 
org.eclipse.tycho:tycho-packaging-plugin:0.25.0:validate-version 
(default-validate-version) on project org.apache.syncope.ide.eclipse.plugin: 
Unqualified OSGi version 1.0.0.qualifier must match unqualified Maven version 
2.0.0-SNAPSHOT for SNAPSHOT builds
```
It would be better if this remains static and is changed whenever required.




> Eclipse plugin
> --
>
> Key: SYNCOPE-809
> URL: https://issues.apache.org/jira/browse/SYNCOPE-809
> Project: Syncope
>  Issue Type: Sub-task
> Environment: Eclipse
>Reporter: Francesco Chicchiriccò
>Assignee: Tushar Mishra
>  Labels: eclipse, gsoc2016
>
> Develop a plug-in, according to what reported in SYNCOPE-770, working with 
> latest Eclipse version.
> See Google Summer of Code project proposal at 
> https://summerofcode.withgoogle.com/projects/#4822214733987840



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-828) Russian translation for admin console

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411059#comment-15411059
 ] 

ASF GitHub Bot commented on SYNCOPE-828:


GitHub user securny opened a pull request:

https://github.com/apache/syncope/pull/32

[SYNCOPE-828] Russian translation for admin console

RU localization changes and updates

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/securny/syncope ru

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/syncope/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #32


commit 251b8cbd9ff481319e868a7e3a754329b15dbca0
Author: berezkin 
Date:   2016-04-03T11:57:11Z

Russian locale added

test commit with adding russian locale

commit 9c953038ce639966e83fd90c328305cb9a76944f
Author: berezkin 
Date:   2016-04-03T12:00:52Z

Revert "Russian locale added"

This reverts commit 251b8cbd9ff481319e868a7e3a754329b15dbca0.

commit 0605f608ce02ec3f3e08c37b8f618c1f61081b14
Author: berezkin 
Date:   2016-04-03T12:28:03Z

Added *_ru.properties

Added *_ru.properties files

commit 885ad8ea9f906726277be9f1a3bc2be33594bbc0
Author: securny 
Date:   2016-04-04T18:33:05Z

Added another *_ru.properties

Added another *_ru.properties files

commit 7f98ceece325892a6c8e47312d431144308298c1
Author: securny 
Date:   2016-04-06T19:01:38Z

One more update with *_ru.properties

One more update with *_ru.properties

commit 14f208c1dda61c7c7397f07099dd4dd39639a099
Author: securny 
Date:   2016-04-08T05:13:40Z

Almost finished with *_ru.properties

Almost finished with *_ru.properties. Just 2 files left.

commit 19f5e4a3ad771d2c35bd363381d890d1ea9278b7
Author: securny 
Date:   2016-04-11T08:16:34Z

Done with *_ru.properties

Done with *_ru.properties

commit 247888eaabf079f3a9a2b9daafe05bf61c03e5b2
Author: securny 
Date:   2016-04-11T08:42:32Z

Merge remote-tracking branch 'upstream/master' into ru

commit 6a978331201c42ca58d73f89e35211472a010d0a
Author: securny 
Date:   2016-04-11T17:03:49Z

Added new *_ru.properties

Added new *_ru.properties

commit dc108de2242dd25039e194e828e49593c2c04e40
Author: securny 
Date:   2016-04-11T18:49:21Z

Source code style fixes

Source code style fixes

commit af4a6e47540d64564722b63a6db32ab4852921d7
Author: securny 
Date:   2016-04-11T18:49:38Z

Merge remote-tracking branch 'upstream/master' into ru

commit 795cd6a0287fbcbc571c23e3540771b54976f3b6
Author: securny 
Date:   2016-04-12T07:03:52Z

Added new *_ru.properties files

Added new *_ru.properties files

commit ac1d901ed4b32097b7acec7c47c2425ee52bde62
Author: securny 
Date:   2016-04-12T08:04:58Z

Removing old keys from *_ru.properties

Removing old keys from *_ru.properties

commit e63f1421dc3cbe4982b322d51425d60b0113bd10
Author: securny 
Date:   2016-04-12T13:28:53Z

Merge remote-tracking branch 'upstream/master' into ru

commit a7c62c527f49b98a71008d8274958a85593e963f
Author: securny 
Date:   2016-04-13T12:50:28Z

Merge remote-tracking branch 'upstream/master' into ru

commit f2f9c01658369501ec1df71f2a98936fed63bb03
Author: securny 
Date:   2016-04-13T17:05:11Z

Done with current *_ru.properties

Done with current *_ru.properties files

commit c3d8aa5a343b7e764af1e7b82eeff54b217968c3
Author: securny 
Date:   2016-04-14T06:58:38Z

Merge remote-tracking branch 'upstream/master' into ru

commit 29747c85234fd53af30c256da88fcf19b491af2e
Author: securny 
Date:   2016-04-20T11:46:35Z

Merge remote-tracking branch 'upstream/master' into ru

commit a42df3df406d5ebf65a567db43d46c2ff354bff3
Author: securny 
Date:   2016-04-21T12:40:07Z

Merge remote-tracking branch 'upstream/master' into ru

commit b81067d92d948811e992ea1944e80dd690208c1e
Author: securny 
Date:   2016-04-23T12:31:07Z

Merge remote-tracking branch 'upstream/master' into ru

commit 665db8ce11537e00e3dccdc57fe37b761cba8595
Author: securny 
Date:   2016-04-26T18:35:23Z

Merge remote-tracking branch 'upstream/master' into ru

commit e70133a0fd8bcc84641ff1846aaeaccf9e93a80c
Author: securny 
Date:   2016-05-09T18:32:01Z

Merge remote-tracking branch 'upstream/master' into ru

commit f03d56c8834c008aedb166f129e591f006ff0c78
Author: securny 

[jira] [Commented] (SYNCOPE-828) Russian translation for admin console

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411456#comment-15411456
 ] 

ASF GitHub Bot commented on SYNCOPE-828:


Github user ilgrosso commented on the issue:

https://github.com/apache/syncope/pull/32
  
Hi @securny, thanks for your work!

There are unfortunately some issues in merging this PR, due to some nasty 
conflicts.

I would suggest to:

1. close this PR
2. align your own fork's master branch with latest changes from syncope 
master branch
3. create new branch from your now-aligned master branch
4. unzip 
[patch-32.zip](https://github.com/apache/syncope/files/406325/patch-32.zip) and 
apply the contained diff via `patch -p1 < 32.diff`
5. open new PR from this newly created branch

I can naturally apply the elaborated diff by myself (and thus you could 
skip all such procedure), but this way I will lost your commit authorship (I 
could name you in the commit log, but anyway...)






> Russian translation for admin console
> -
>
> Key: SYNCOPE-828
> URL: https://issues.apache.org/jira/browse/SYNCOPE-828
> Project: Syncope
>  Issue Type: New Feature
>  Components: console
>Reporter: Francesco Chicchiriccò
>Assignee: Dmitry Berezkin
> Fix For: 2.0.0-M3
>
>
> Add Russian to the list of available translations for admin console UI.
> Relevant mail thread: http://markmail.org/message/wrftlbrpswyeeivu



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-809) Eclipse plugin

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389272#comment-15389272
 ] 

ASF GitHub Bot commented on SYNCOPE-809:


Github user asfgit closed the pull request at:

https://github.com/apache/syncope/pull/28


> Eclipse plugin
> --
>
> Key: SYNCOPE-809
> URL: https://issues.apache.org/jira/browse/SYNCOPE-809
> Project: Syncope
>  Issue Type: Sub-task
>  Components: ide
> Environment: Eclipse
>Reporter: Francesco Chicchiriccò
>Assignee: Tushar Mishra
>  Labels: eclipse, gsoc2016
> Fix For: 2.0.0
>
>
> Develop a plug-in, according to what reported in SYNCOPE-770, working with 
> latest Eclipse version.
> See Google Summer of Code project proposal at 
> https://summerofcode.withgoogle.com/projects/#4822214733987840



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-828) Russian translation for admin console

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414169#comment-15414169
 ] 

ASF GitHub Bot commented on SYNCOPE-828:


GitHub user securny opened a pull request:

https://github.com/apache/syncope/pull/33

[SYNCOPE-828] Russian translation for admin console

Second try to merge changes

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/securny/syncope ru_addon

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/syncope/pull/33.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #33


commit 251b8cbd9ff481319e868a7e3a754329b15dbca0
Author: berezkin 
Date:   2016-04-03T11:57:11Z

Russian locale added

test commit with adding russian locale

commit 9c953038ce639966e83fd90c328305cb9a76944f
Author: berezkin 
Date:   2016-04-03T12:00:52Z

Revert "Russian locale added"

This reverts commit 251b8cbd9ff481319e868a7e3a754329b15dbca0.

commit 9d5f0be4652ca29c55226f8d7f6dda448594716b
Author: securny 
Date:   2016-08-09T19:52:56Z

Merge pull request #1 from apache/master

Syncing from original

commit 85992c59a1f5151b2f80b0e287316da12b7cdcdb
Author: securny 
Date:   2016-08-09T19:57:22Z

Merge remote-tracking branch 'upstream/master'

commit 10b62594204a9e40c3a83634bcacebbdd49fc223
Author: securny 
Date:   2016-08-09T19:59:23Z

Merge remote-tracking branch 'origin/master'

commit af3a0f37090ef42def48369898df48132f5557db
Author: securny 
Date:   2016-08-09T20:15:06Z

One more translation for RU locale




> Russian translation for admin console
> -
>
> Key: SYNCOPE-828
> URL: https://issues.apache.org/jira/browse/SYNCOPE-828
> Project: Syncope
>  Issue Type: New Feature
>  Components: console
>Reporter: Francesco Chicchiriccò
>Assignee: Dmitry Berezkin
> Fix For: 2.0.0-M3
>
>
> Add Russian to the list of available translations for admin console UI.
> Relevant mail thread: http://markmail.org/message/wrftlbrpswyeeivu



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-828) Russian translation for admin console

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414096#comment-15414096
 ] 

ASF GitHub Bot commented on SYNCOPE-828:


Github user securny closed the pull request at:

https://github.com/apache/syncope/pull/32


> Russian translation for admin console
> -
>
> Key: SYNCOPE-828
> URL: https://issues.apache.org/jira/browse/SYNCOPE-828
> Project: Syncope
>  Issue Type: New Feature
>  Components: console
>Reporter: Francesco Chicchiriccò
>Assignee: Dmitry Berezkin
> Fix For: 2.0.0-M3
>
>
> Add Russian to the list of available translations for admin console UI.
> Relevant mail thread: http://markmail.org/message/wrftlbrpswyeeivu



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-700) Documentation artifacts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358723#comment-15358723
 ] 

ASF GitHub Bot commented on SYNCOPE-700:


Github user ilgrosso commented on the issue:

https://github.com/apache/syncope/pull/19
  
@tmess567 if you don't mind, I'll merge this PR as it is right now and 
continue working from here, since I am about to start again on SYNCOPE-700.
Fine with you?


> Documentation artifacts
> ---
>
> Key: SYNCOPE-700
> URL: https://issues.apache.org/jira/browse/SYNCOPE-700
> Project: Syncope
>  Issue Type: Improvement
>  Components: documentation
>Reporter: Francesco Chicchiriccò
>Assignee: Francesco Chicchiriccò
> Fix For: 2.0.0
>
>
> As [discussed|http://markmail.org/message/dpleneuzrfcsmq2r] in mailing list, 
> setup the {{asciidoctor-maven-plugin}} in order to generate, alongside with 
> the build, the project documentation in HTML and PDF.
> The generated documentation will then be part of release artifacts and always 
> up-to-date with current release.
> Preliminary results available at 
> http://syncope.apache.org/2.0.0-SNAPSHOT/docs/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-880) Identity Recertification

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422343#comment-15422343
 ] 

ASF GitHub Bot commented on SYNCOPE-880:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/26#discussion_r74886819
  
--- Diff: core/workflow-activiti/src/main/resources/userWorkflow.bpmn20.xml 
---
@@ -82,12 +82,47 @@ under the License.
 
 
 
+
+
--- End diff --

Removing some production workflow looks fine, thanks.

You might consider writing some sections about identity recertification in 
the [reference 
guide](https://ci.apache.org/projects/syncope/reference-guide.html), also 
including some operational notes as how to set assignment.


> Identity Recertification
> 
>
> Key: SYNCOPE-880
> URL: https://issues.apache.org/jira/browse/SYNCOPE-880
> Project: Syncope
>  Issue Type: New Feature
>  Components: core
>Reporter: Nicola Scendoni
>Assignee: Nicola Scendoni
>Priority: Minor
> Fix For: 2.0.0
>
>
> Identify Re-certification is required for many national and international 
> standards like SOX, GxP, etc.
> The idea is to implement one scheduled task that filter users basing on some 
> attributes (example: last recertification date, role,...) and move then on 
> one state "to be certified" and assign one task to some group that has the 
> responsibility to recertified the user, or delete it from the system.
> Some report should report evidence about when the users have been recertified 
> and who was the certifier.
>  
> This feature would be also the starting point to create account, role and 
> groups re-certifications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-880) Identity Recertification

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422340#comment-15422340
 ] 

ASF GitHub Bot commented on SYNCOPE-880:


Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/26#discussion_r74886344
  
--- Diff: 
fit/core-reference/src/main/java/org/apache/syncope/fit/core/reference/TestIdentityRecertification.java
 ---
@@ -0,0 +1,100 @@
+/*
+ * Copyright 2016 The Apache Software Foundation.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.syncope.fit.core.reference;
+
+import java.util.Date;
+import org.apache.syncope.core.persistence.api.dao.ConfDAO;
+import org.apache.syncope.core.persistence.api.dao.UserDAO;
+import org.apache.syncope.core.persistence.api.entity.conf.CPlainAttr;
+import org.apache.syncope.core.persistence.api.entity.user.UPlainAttr;
+import 
org.apache.syncope.core.persistence.api.entity.user.UPlainAttrUniqueValue;
+import org.apache.syncope.core.persistence.api.entity.user.User;
+import 
org.apache.syncope.core.provisioning.java.job.AbstractSchedTaskJobDelegate;
+import org.apache.syncope.core.workflow.activiti.task.Recertify;
+import org.apache.syncope.core.workflow.api.UserWorkflowAdapter;
+import org.quartz.JobExecutionException;
+import org.springframework.beans.factory.annotation.Autowired;
+
+public class TestIdentityRecertification extends 
AbstractSchedTaskJobDelegate {
--- End diff --

You could always add it to both `MasterContent.xml`, but without schedule, 
so that it is not run automatically.
WDYT?

Finally, extending `AbstractSchedTaskJobDelegate` and putting all logic 
into `doExecute` is considered best-practice, as other things are performed as 
well (conditionally saving execution, notification and audit, ..).


> Identity Recertification
> 
>
> Key: SYNCOPE-880
> URL: https://issues.apache.org/jira/browse/SYNCOPE-880
> Project: Syncope
>  Issue Type: New Feature
>  Components: core
>Reporter: Nicola Scendoni
>Assignee: Nicola Scendoni
>Priority: Minor
> Fix For: 2.0.0
>
>
> Identify Re-certification is required for many national and international 
> standards like SOX, GxP, etc.
> The idea is to implement one scheduled task that filter users basing on some 
> attributes (example: last recertification date, role,...) and move then on 
> one state "to be certified" and assign one task to some group that has the 
> responsibility to recertified the user, or delete it from the system.
> Some report should report evidence about when the users have been recertified 
> and who was the certifier.
>  
> This feature would be also the starting point to create account, role and 
> groups re-certifications.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SYNCOPE-808) Netbeans plugin

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15849813#comment-15849813
 ] 

ASF GitHub Bot commented on SYNCOPE-808:


Github user ilgrosso commented on the issue:

https://github.com/apache/syncope/pull/43
  
I have added a temporary [SYNCOPE-808 
branch](https://github.com/apache/syncope/tree/SYNCOPE-808), based on `2_0_X` 
with the content of this PR + my attached commit above.


> Netbeans plugin
> ---
>
> Key: SYNCOPE-808
> URL: https://issues.apache.org/jira/browse/SYNCOPE-808
> Project: Syncope
>  Issue Type: Sub-task
>  Components: ide
> Environment: Netbeans IDE
>Reporter: Francesco Chicchiriccò
>Assignee: Tushar Mishra
>  Labels: gsoc2016, netbeans
> Fix For: 2.0.3, 2.1.0
>
>
> Develop a plug-in, according to what reported in SYNCOPE-770, working with 
> latest Netbeans version.
> See Google Summer of Code project proposal at 
> https://summerofcode.withgoogle.com/projects/#5722525799546880



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)