sebwrede opened a new pull request #1054:
URL: https://github.com/apache/systemds/pull/1054
Exceptions added to the FederatedResponse risk exposing data from the
federated worker. Exceptions need to be caught and then a new exception could
be created and added to the FederatedResponse without all details from the
original exception.
An example of how to add an exception to the FederatedResponse without
exposing data can be seen in "executeCommand" in FederatedWorkerHandler.java:
`catch (DMLPrivacyException | FederatedWorkerHandlerException ex) {return
new FederatedResponse(ResponseType.ERROR, ex);}`
This code catches DMLPrivacyExceptions and FederatedWorkerHandlerExceptions
and any other type of exception is handled by a different catch-block where the
name of the exception class is put into the message of a
FederatedWorkerHandlerException. In this way, we can throw DMLPrivacyExceptions
and FederatedWorkerHandlerExceptions without including any private data in the
exception message and all other exceptions will not be returned in the
FederatedResponse.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
