[GitHub] incubator-taverna-mobile pull request #68: Improved ImageZoom screen

[saketkumar95]

GitHub user saketkumar95 opened a pull request:

https://github.com/apache/incubator-taverna-mobile/pull/68

Improved ImageZoom screen

This PR improves the ImageZoom Screen. 

- [x] Apply the `AndroidStyle.xml` style template to your code in Android 
Studio.

- [x] Run the checks with `./gradlew check` to make sure you didn't break 
anything

- [x] If you have multiple commits please combine them into one commit by 
squashing them.

Here is the screenshot after changes : 

![screenshot_1520060327](https://user-images.githubusercontent.com/21558765/36931563-7bf9d28a-1ede-11e8-9529-32d6a778af22.png)

@sagar15795 Please review! :)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/saketkumar95/incubator-taverna-mobile 
imageZoom

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-taverna-mobile/pull/68.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #68


commit d8a6a1d0aa5ba5cbe8430f0b8e373529186a6504
Author: saketkumar95 
Date:   2018-03-03T06:56:36Z

Improved ImageZoom screen




---

Running Workflows using Taverna Server

[Nitish Kundala]

Hi,
I have been reading up to work on the Issue - 1033
 and have understood
the following. (Any advice or corrections would be appreciated)

I have been through the documentation

of the Taverna Mobile app and understood the following:
1)The Taverna Player JSON API

is used to run the workflows.
2)Taverna Player is currently capable of running only type two workflows.
3)On clicking the run button we receive a WorkflowRunTask, the user can
enter the required parameters specific for the run.
4)Then the app creates a RunTask which then waits for the result and the
user can download the results.

So as I understand it, the changes that are to be made are:
1) The login that currently goes via the the Taverna Player Portal needs to
go via the Taverna Server.
2) The uploading of the workflow content has to be done to the Taverna
Server to run.
3) Getting of the workflow details of the ones that were run also has to be
rerouted.

So basically the TavernaPlayerService.java

Interface has to be replaced. And there have to be made certain changes in
the API call structure.
I have been going through the Taverna Server

Documentations and trying to map the required calls.


Thanks and Regards,

*Nitish Kundala* .

[GitHub] incubator-taverna-mobile pull request #67: Fix: Replace fav workflow icon im...

[Hiteshgautam01]

GitHub user Hiteshgautam01 opened a pull request:

https://github.com/apache/incubator-taverna-mobile/pull/67

Fix: Replace fav workflow icon image view with floating action button to 
enhance the UI

 Please make sure these boxes are checked before submitting your pull 
request - thanks!

- [ ] Apply the `AndroidStyle.xml` style template to your code in Android 
Studio.

- [ ] Run the checks with `./gradlew check` to make sure you didn't break 
anything

- [ ] If you have multiple commits please combine them into one commit by 
squashing them.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Hiteshgautam01/incubator-taverna-mobile 
Fav_work_toggle

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-taverna-mobile/pull/67.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #67


commit f0a4e6843031f9acc9bf08fdb371322c9d85471a
Author: Hitesh Gautam 
Date:   2018-03-02T08:02:22Z

Fix: Replace fav workflow icon image view with floating action button to 
enhance the UI




---