[GitHub] incubator-tephra issue #45: [TEPHRA-236] Changes to replace deprecated class...
Github user poornachandra commented on the issue: https://github.com/apache/incubator-tephra/pull/45 Thanks for the contribution @bijugs! ---
[GitHub] incubator-tephra issue #45: [TEPHRA-236] Changes to replace deprecated class...
Github user bijugs commented on the issue: https://github.com/apache/incubator-tephra/pull/45 @poornachandra , Updated the PR with changes for the latest comments and squashed the commits to one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-tephra issue #45: [TEPHRA-236] Changes to replace deprecated class...
Github user bijugs commented on the issue: https://github.com/apache/incubator-tephra/pull/45 @poornachandra did over look the logic and thank you for catching that. Updated the PR with an additional commit to make the review process easier. Can squash the commits once the review of the latest change is complete. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-tephra issue #45: [TEPHRA-236] Changes to replace deprecated class...
Github user poornachandra commented on the issue: https://github.com/apache/incubator-tephra/pull/45 @bijugs Just one more comment to address - https://github.com/apache/incubator-tephra/pull/45#discussion_r128894170 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-tephra issue #45: [TEPHRA-236] Changes to replace deprecated class...
Github user bijugs commented on the issue: https://github.com/apache/incubator-tephra/pull/45 @poornachandra patch after squashing the commits seems to apply fine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-tephra issue #45: [TEPHRA-236] Changes to replace deprecated class...
Github user poornachandra commented on the issue: https://github.com/apache/incubator-tephra/pull/45 Thanks @bijugs, I'll continue the review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-tephra issue #45: [TEPHRA-236] Changes to replace deprecated class...
Github user bijugs commented on the issue: https://github.com/apache/incubator-tephra/pull/45 @poornachandra Did update the PR by removing the updated code. Since this is ``WIP`` will squash the commits once the reviews are complete. At this time ``Table`` class doesn't support ``flushCommits`` method and have raised a [ticket](https://issues.apache.org/jira/browse/HBASE-18360) to ``Hbase`` project. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
