[GitHub] incubator-tephra issue #67: TEPHRA-272 Add HBase 2.0 compatibility module
Github user poornachandra commented on the issue: https://github.com/apache/incubator-tephra/pull/67 @ankitsinghal I spent some time on the tephra-hbase-compat-1.4 compat module tests failure. It looks like the 1.4 compat module tests were never run earlier. When you changed the travis.xml to build hbase-compat-1.4 module, the issue was exposed. I have filed JIRA https://issues.apache.org/jira/browse/TEPHRA-285 for this issue. Since the failure was already present, I will go ahead and merge this PR. Thanks for the contribution! ---
[GitHub] incubator-tephra issue #67: TEPHRA-272 Add HBase 2.0 compatibility module
Github user ankitsinghal commented on the issue: https://github.com/apache/incubator-tephra/pull/67 @poornachandra , have squashed all commit in a single one. can you please commit this. ---
[GitHub] incubator-tephra issue #67: TEPHRA-272 Add HBase 2.0 compatibility module
Github user ankitsinghal commented on the issue: https://github.com/apache/incubator-tephra/pull/67 @poornachandra , I have already made the change to compile HBase-2.0 with Java 8. should I rebase and squash the commits for merge now? It seems HBase 1.x releases are still with Java 7 so We can also support Java 7 for the older releases of HBase so that user can still use latest releases of Tephra without changing their environment. Though not sure why 1-2 tests of HBase 1.4 are failing on Java 7, we can fix this in separate JIRA. ---
[GitHub] incubator-tephra issue #67: TEPHRA-272 Add HBase 2.0 compatibility module
Github user poornachandra commented on the issue: https://github.com/apache/incubator-tephra/pull/67 @joshelser There is nothing stopping us from moving Tephra to Java 8. Just that we'll have to build consensus on the Tephra dev list, and it will add to the delay of this PR. If making the POM changes to work with both Java 7 and Java 8 is complicated, then @ankitsinghal can you send out an email to the dev list for the Java 8 consensus? ---
[GitHub] incubator-tephra issue #67: TEPHRA-272 Add HBase 2.0 compatibility module
Github user poornachandra commented on the issue: https://github.com/apache/incubator-tephra/pull/67 @ankitsinghal Since HBase-2.0 needs Java 8, let's try changing the compiler for only HBase-2.0 compat module to use Java 8. We can still keep the other modules as Java 7. I haven't tried it out myself. But I think it should work. Right now, we run Travis tests using both Java 7 and Java 8 for all modules. We can restrict HBase-2.0 compat module tests to run only for Java 8. ---
[GitHub] incubator-tephra issue #67: TEPHRA-272 Add HBase 2.0 compatibility module
Github user ankitsinghal commented on the issue: https://github.com/apache/incubator-tephra/pull/67 bq. Can you update the pom for the 2.0 compat module to use Java 8? Do we want to make Java8 specific to HBase-2.0 compat module and keep other still running on Java7. Will it not affect the release process, as currently the release is built with single version JDK 1.7? ---
[GitHub] incubator-tephra issue #67: TEPHRA-272 Add HBase 2.0 compatibility module
Github user poornachandra commented on the issue: https://github.com/apache/incubator-tephra/pull/67 @ankitsinghal Just one more question (https://github.com/apache/incubator-tephra/pull/67#discussion_r169503415). Also the Java 7 build is failing for HBase 2.0 compat module. Looks like HBase 2.0 needs Java 8. Can you update the pom for the 2.0 compat module to use Java 8? Note that the master branch has some changes on how the Travis tests are run (TEPHRA-282). You'll have to rebase, and then add an entry to travis.yml for the 2.0 compat module. ---
[GitHub] incubator-tephra issue #67: TEPHRA-272 Add HBase 2.0 compatibility module
Github user ankitsinghal commented on the issue: https://github.com/apache/incubator-tephra/pull/67 Thanks a lot @poornachandra for the review, I have taken care of all the current review comments in the last commit. Let me know if any changes required with your further review. ---
[GitHub] incubator-tephra issue #67: TEPHRA-272 Add HBase 2.0 compatibility module
Github user poornachandra commented on the issue: https://github.com/apache/incubator-tephra/pull/67 @ankitsinghal I'm taking a look at the PR. Meanwhile, the Travis build has failed. Looks like there is some issue finding HBase 2.0 dependencies. Can you take a look at it? Also, I'm on vacation this month. So there may be a delay in my replies. ---
