[jira] [Created] (THRIFT-2567) Csharp slow ?
Martin Vogt created THRIFT-2567:
---
Summary: Csharp slow ?
Key: THRIFT-2567
URL: https://issues.apache.org/jira/browse/THRIFT-2567
Project: Thrift
Issue Type: Question
Components: C# - Library
Affects Versions: 1.0
Reporter: Martin Vogt
Priority: Minor
Hello,
I have a simple csharp server/client for performance tests,
something like this
{quote}
service {
binary getData();
}
{quote}
which returns a 1MB buffer.(git snapshot from a few days ago).
A thrift call client-server takes 8ms
according to stopWatch.Elapsed. The same client-server
implemented from here(modified of course):
{quote}
http://www.java2s.com/Code/CSharp/Network/SimpleTcpClient.htm
http://www.java2s.com/Code/CSharp/Network/SimpleTcpServer.htm
{quote}
takes ~1ms. (Factor 8 faster, than the thrift client/server, all localhost
connections on windows)
I tried to narrow it down where the actual problem is, but without
luck so far.
- Its not the binary stream creation during unmarshall:
{quote}
// pseudocode
byte[] getData() {
len=iprot.readi32()
byte[] x=new byte[len]
iprot.readAll(x,len);
return x;
}
{quote}
It _looks_ that its in the thrift c# library classes (TSocket,etc..),
but up to now I haven't found an explanation for the
differences.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[GitHub] thrift pull request: Introduce file to specify third party library...
GitHub user pascal-bach opened a pull request: https://github.com/apache/thrift/pull/132 Introduce file to specify third party library locations on Windows This change makes it simpler to specify the location of third party libraries on Windows You can merge this pull request into a Git repository by running: $ git pull https://github.com/siemens/thrift winbuild Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/132.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #132 commit f55437d55549ced475092518f432936c4e760639 Author: Pascal Bach pascal.b...@siemens.com Date: 2014-04-09T09:19:18Z TPipeServer requires OverlappedSubmissionThread.cpp|h so include it in the corresponding VS files commit 63a3309a83e6fb09b589a61fe56c5abe1157acb5 Author: Pascal Bach pascal.b...@siemens.com Date: 2014-03-26T15:44:07Z Replace Env variables for 3rdparty --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (THRIFT-2568) Implement own certificate handler
Michael Blättler created THRIFT-2568: Summary: Implement own certificate handler Key: THRIFT-2568 URL: https://issues.apache.org/jira/browse/THRIFT-2568 Project: Thrift Issue Type: Improvement Components: C# - Library Affects Versions: 0.9.1 Reporter: Michael Blättler Priority: Trivial Enhance the C# TLS-Transport with a paramater to give it a specific certificate handler function. This enables to easely accept untrusted certificates or accept a specific certificate, which can be useful while debuging. -- This message was sent by Atlassian JIRA (v6.2#6252)
[GitHub] thrift pull request: Introduce file to specify third party library...
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/132#issuecomment-45207908 Hi Pascal thanks for the patch! please create a related Jira Issue, see http://thrift.apache.org/docs/HowToContribute and I will take care on it. -roger --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: THRIFT-2568: Implemented possibility to use o...
GitHub user mblaettler opened a pull request: https://github.com/apache/thrift/pull/133 THRIFT-2568: Implemented possibility to use own certificate handler Added the possibility to set a user specific certificate validation routine. This allows to accept unsigned or wrong certificates for debug reasons. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mblaettler/thrift THRIFT-2568-own-cert-validator Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/133.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #133 commit 57494794e787356ee98229cac35ea7aaa60ad562 Author: mblaettler michi.blaett...@bluewin.ch Date: 2014-06-05T11:41:05Z THRIFT-2568: Implemented possibility to use own certificate handler --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2568) Implement own certificate handler
[ https://issues.apache.org/jira/browse/THRIFT-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14018703#comment-14018703 ] ASF GitHub Bot commented on THRIFT-2568: GitHub user mblaettler opened a pull request: https://github.com/apache/thrift/pull/133 THRIFT-2568: Implemented possibility to use own certificate handler Added the possibility to set a user specific certificate validation routine. This allows to accept unsigned or wrong certificates for debug reasons. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mblaettler/thrift THRIFT-2568-own-cert-validator Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/133.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #133 commit 57494794e787356ee98229cac35ea7aaa60ad562 Author: mblaettler michi.blaett...@bluewin.ch Date: 2014-06-05T11:41:05Z THRIFT-2568: Implemented possibility to use own certificate handler Implement own certificate handler - Key: THRIFT-2568 URL: https://issues.apache.org/jira/browse/THRIFT-2568 Project: Thrift Issue Type: Improvement Components: C# - Library Affects Versions: 0.9.1 Reporter: Michael Blättler Priority: Trivial Enhance the C# TLS-Transport with a paramater to give it a specific certificate handler function. This enables to easely accept untrusted certificates or accept a specific certificate, which can be useful while debuging. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (THRIFT-2539) Tsocket.cpp addrinfo ai_flags = AI_ADDRCONFIG
[ https://issues.apache.org/jira/browse/THRIFT-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michał Gazda updated THRIFT-2539: - Attachment: THRIFT-2539-fix-for-windows-cpp.patch Hello, please try this patch, should be not invasive and it solves problem for me. I don't know if there is similar problem on other systems but I used WSA error name here so it is in ifdef. Tsocket.cpp addrinfo ai_flags = AI_ADDRCONFIG - Key: THRIFT-2539 URL: https://issues.apache.org/jira/browse/THRIFT-2539 Project: Thrift Issue Type: Question Affects Versions: 0.9.1 Reporter: Michał Gazda Assignee: Randy Abernethy Attachments: THRIFT-2539-fix-for-windows-cpp.patch, THRIFT-2539-my-new-feature.patch, TSocket.cpp While creating and using thrift based app we have found some problem on windows 7 which was not present on winxp. When we try to open socket with local_open() for the host name localhost getaddrinfo fails with 11004. What is important we do not have any physical network address as all network cards are disabled in the system. As I assume it is connected wit he flag AI_ADDRCONFIG. Why it is set by default? I wonder if I do remove it can it cause some problems? I would like our app to be able to communicate locally even if there is no external network available. Hope to get quick reply, thank you. -- This message was sent by Atlassian JIRA (v6.2#6252)
Ruby Server rer=turns Thrift::TransportException
Hello all, I have replaced simple_server.rb and simple_client.rb at test/rb/integration using attached client and server. What I have done here is added testVoid and testMultiException to server and client which are defined in ThriftTest.thrift. When I run the client against server, I got following error. test_multi_exception(SimpleClientTest) [rb/integration/simple_client.rb:174]: [Thrift::Test::Xception2] exception expected, not Class: Thrift::TransportException Message: end of file reached ---Backtrace--- /home/chamila/gsoc/1/thrift/lib/rb/lib/thrift/transport/socket.rb:122:in `rescue in read' /home/chamila/gsoc/1/thrift/lib/rb/lib/thrift/transport/socket.rb:97:in `read' /home/chamila/gsoc/1/thrift/lib/rb/lib/thrift/transport/base_transport.rb:84:in `read_all' /home/chamila/gsoc/1/thrift/lib/rb/lib/thrift/transport/base_transport.rb:73:in `read_into_buffer' /home/chamila/gsoc/1/thrift/lib/rb/lib/thrift/protocol/binary_protocol.rb:194:in `read_i32' /home/chamila/gsoc/1/thrift/lib/rb/lib/thrift/protocol/binary_protocol.rb:120:in `read_message_begin' /home/chamila/gsoc/1/thrift/lib/rb/lib/thrift/client.rb:45:in `receive_message' /home/chamila/gsoc/1/thrift/test/rb/gen-rb/thrift_test.rb:295:in `recv_testMultiException' /home/chamila/gsoc/1/thrift/test/rb/gen-rb/thrift_test.rb:287:in `testMultiException' rb/integration/simple_client.rb:175:in `block in test_multi_exception' I observed that server works fine when I sent Xception as arg0, fails in other cases. Also client works properly with java and node servers. Any idea on what is wrong here? Thank You! -- *Chamila Dilshan Wijayarathna,* SMIEEE, SMIESL, Undergraduate, Department of Computer Science and Engineering, University of Moratuwa. simple_client.rb Description: application/ruby simple_server.rb Description: application/ruby
AW: [jira] [Updated] (THRIFT-2539) Tsocket.cpp addrinfo ai_flags = AI_ADDRCONFIG
Does it work with both OS flavours now? XP and newer? Von: Michał Gazda (JIRA) Gesendet: 05.06.2014 14:46 An: dev@thrift.apache.org Betreff: [jira] [Updated] (THRIFT-2539) Tsocket.cpp addrinfo ai_flags = AI_ADDRCONFIG [ https://issues.apache.org/jira/browse/THRIFT-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michał Gazda updated THRIFT-2539: - Attachment: THRIFT-2539-fix-for-windows-cpp.patch Hello, please try this patch, should be not invasive and it solves problem for me. I don't know if there is similar problem on other systems but I used WSA error name here so it is in ifdef. Tsocket.cpp addrinfo ai_flags = AI_ADDRCONFIG - Key: THRIFT-2539 URL: https://issues.apache.org/jira/browse/THRIFT-2539 Project: Thrift Issue Type: Question Affects Versions: 0.9.1 Reporter: Michał Gazda Assignee: Randy Abernethy Attachments: THRIFT-2539-fix-for-windows-cpp.patch, THRIFT-2539-my-new-feature.patch, TSocket.cpp While creating and using thrift based app we have found some problem on windows 7 which was not present on winxp. When we try to open socket with local_open() for the host name localhost getaddrinfo fails with 11004. What is important we do not have any physical network address as all network cards are disabled in the system. As I assume it is connected wit he flag AI_ADDRCONFIG. Why it is set by default? I wonder if I do remove it can it cause some problems? I would like our app to be able to communicate locally even if there is no external network available. Hope to get quick reply, thank you. -- This message was sent by Atlassian JIRA (v6.2#6252)
[GitHub] thrift pull request: THRIFT-2568: Implemented possibility to use o...
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/133 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Closed] (THRIFT-2568) Implement own certificate handler
[ https://issues.apache.org/jira/browse/THRIFT-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-2568. -- Resolution: Fixed Fix Version/s: 0.9.2 Assignee: (was: Jens Geyer) LGTM, committed. Implement own certificate handler - Key: THRIFT-2568 URL: https://issues.apache.org/jira/browse/THRIFT-2568 Project: Thrift Issue Type: Improvement Components: C# - Library Affects Versions: 0.9.1 Reporter: Michael Blättler Priority: Trivial Fix For: 0.9.2 Enhance the C# TLS-Transport with a paramater to give it a specific certificate handler function. This enables to easely accept untrusted certificates or accept a specific certificate, which can be useful while debuging. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (THRIFT-2568) Implement own certificate handler
[ https://issues.apache.org/jira/browse/THRIFT-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14019164#comment-14019164 ] ASF GitHub Bot commented on THRIFT-2568: Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/133 Implement own certificate handler - Key: THRIFT-2568 URL: https://issues.apache.org/jira/browse/THRIFT-2568 Project: Thrift Issue Type: Improvement Components: C# - Library Affects Versions: 0.9.1 Reporter: Michael Blättler Priority: Trivial Fix For: 0.9.2 Enhance the C# TLS-Transport with a paramater to give it a specific certificate handler function. This enables to easely accept untrusted certificates or accept a specific certificate, which can be useful while debuging. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (THRIFT-2568) Implement own certificate handler
[ https://issues.apache.org/jira/browse/THRIFT-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-2568: -- Assignee: Jens Geyer Implement own certificate handler - Key: THRIFT-2568 URL: https://issues.apache.org/jira/browse/THRIFT-2568 Project: Thrift Issue Type: Improvement Components: C# - Library Affects Versions: 0.9.1 Reporter: Michael Blättler Assignee: Jens Geyer Priority: Trivial Fix For: 0.9.2 Enhance the C# TLS-Transport with a paramater to give it a specific certificate handler function. This enables to easely accept untrusted certificates or accept a specific certificate, which can be useful while debuging. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (THRIFT-2568) Implement own certificate handler
[ https://issues.apache.org/jira/browse/THRIFT-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14019203#comment-14019203 ] Hudson commented on THRIFT-2568: SUCCESS: Integrated in Thrift #1173 (See [https://builds.apache.org/job/Thrift/1173/]) THRIFT-2568 Implement own certificate handler (jensg: rev 7b11fec0c53b3231a472e008dfbb285d1aac44df) * lib/csharp/src/Transport/TTLSSocket.cs Implement own certificate handler - Key: THRIFT-2568 URL: https://issues.apache.org/jira/browse/THRIFT-2568 Project: Thrift Issue Type: Improvement Components: C# - Library Affects Versions: 0.9.1 Reporter: Michael Blättler Priority: Trivial Fix For: 0.9.2 Enhance the C# TLS-Transport with a paramater to give it a specific certificate handler function. This enables to easely accept untrusted certificates or accept a specific certificate, which can be useful while debuging. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (THRIFT-2189) Go does not support union type
[ https://issues.apache.org/jira/browse/THRIFT-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2189: --- Fix Version/s: (was: 0.9.2) 1.0 Go does not support union type Key: THRIFT-2189 URL: https://issues.apache.org/jira/browse/THRIFT-2189 Project: Thrift Issue Type: Bug Components: Go - Compiler Reporter: Jack L Assignee: Jens Geyer Fix For: 1.0 Go thrift compiler does not support union types -- This message was sent by Atlassian JIRA (v6.2#6252)
[GitHub] thrift pull request: Update simple_json_protocol.go
GitHub user hpgood opened a pull request: https://github.com/apache/thrift/pull/134 Update simple_json_protocol.go fix bug:when read the end of message ,don't need ParsePostValue(). You can merge this pull request into a Git repository by running: $ git pull https://github.com/hpgood/thrift patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/134.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #134 commit 37cc1b1e0ef47d40db970eac2cfcbf79053e48da Author: hpgood 35557...@qq.com Date: 2014-06-06T03:40:20Z Update simple_json_protocol.go fix bug:when read the end of message ,don't need ParsePostValue(). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: Update json_protocol.go
GitHub user hpgood opened a pull request: https://github.com/apache/thrift/pull/135 Update json_protocol.go at ReadMessageEnd,don't need ParsePostValue. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hpgood/thrift patch-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/135.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #135 commit 3aa5679e35888e786c40c65339e3f1ebc3010158 Author: hpgood 35557...@qq.com Date: 2014-06-06T03:42:47Z Update json_protocol.go at ReadMessageEnd,don't need ParsePostValue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: Update json_protocol.go
Github user hpgood closed the pull request at: https://github.com/apache/thrift/pull/135 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
