[jira] [Created] (THRIFT-2840) Cabal file points to LICENSE file outside the path of the Haskell project.
Sean Parsons created THRIFT-2840:
Summary: Cabal file points to LICENSE file outside the path of the
Haskell project.
Key: THRIFT-2840
URL: https://issues.apache.org/jira/browse/THRIFT-2840
Project: Thrift
Issue Type: Bug
Components: Haskell - Library
Affects Versions: 0.9.2
Reporter: Sean Parsons
Priority: Blocker
Currently the Cabal file for the 0.9.2 package that is currently on Hackage
will break when an attempt is made to install it:
{code}
Downloading thrift-0.9.2...
Configuring thrift-0.9.2...
Warning: The 'license-file' field refers to the file '../../LICENSE' which
does not exist.
Building thrift-0.9.2...
Preprocessing library thrift-0.9.2...
[ 1 of 14] Compiling Thrift.Transport.IOBuffer (
src/Thrift/Transport/IOBuffer.hs,
dist/dist-sandbox-791868f2/build/Thrift/Transport/IOBuffer.o )
[ 2 of 14] Compiling Thrift.Arbitraries ( src/Thrift/Arbitraries.hs,
dist/dist-sandbox-791868f2/build/Thrift/Arbitraries.o )
[ 3 of 14] Compiling Thrift.Types ( src/Thrift/Types.hs,
dist/dist-sandbox-791868f2/build/Thrift/Types.o )
[ 4 of 14] Compiling Thrift.Transport ( src/Thrift/Transport.hs,
dist/dist-sandbox-791868f2/build/Thrift/Transport.o )
[ 5 of 14] Compiling Thrift.Protocol ( src/Thrift/Protocol.hs,
dist/dist-sandbox-791868f2/build/Thrift/Protocol.o )
[ 6 of 14] Compiling Thrift.Protocol.Binary ( src/Thrift/Protocol/Binary.hs,
dist/dist-sandbox-791868f2/build/Thrift/Protocol/Binary.o )
[ 7 of 14] Compiling Thrift.Protocol.Compact ( src/Thrift/Protocol/Compact.hs,
dist/dist-sandbox-791868f2/build/Thrift/Protocol/Compact.o )
[ 8 of 14] Compiling Thrift.Protocol.JSON ( src/Thrift/Protocol/JSON.hs,
dist/dist-sandbox-791868f2/build/Thrift/Protocol/JSON.o )
[ 9 of 14] Compiling Thrift.Transport.Handle ( src/Thrift/Transport/Handle.hs,
dist/dist-sandbox-791868f2/build/Thrift/Transport/Handle.o )
[10 of 14] Compiling Thrift.Transport.Empty ( src/Thrift/Transport/Empty.hs,
dist/dist-sandbox-791868f2/build/Thrift/Transport/Empty.o )
[11 of 14] Compiling Thrift.Transport.Framed ( src/Thrift/Transport/Framed.hs,
dist/dist-sandbox-791868f2/build/Thrift/Transport/Framed.o )
[12 of 14] Compiling Thrift.Transport.HttpClient (
src/Thrift/Transport/HttpClient.hs,
dist/dist-sandbox-791868f2/build/Thrift/Transport/HttpClient.o )
[13 of 14] Compiling Thrift ( src/Thrift.hs,
dist/dist-sandbox-791868f2/build/Thrift.o )
[14 of 14] Compiling Thrift.Server( src/Thrift/Server.hs,
dist/dist-sandbox-791868f2/build/Thrift/Server.o )
In-place registering thrift-0.9.2...
Creating package registration file: /tmp/pkgConf-thrift-0.925204.2
cabal: ../../LICENSE: does not exist
Failed to install thrift-0.9.2
cabal: Error: some packages failed to install:
thrift-0.9.2 failed during the final install step. The exception was:
ExitFailure 1
{code}
I've already created a pull request for this issue on Github which points the
path to the file already inside the Haskell lib folder:
https://github.com/apache/thrift/pull/272
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] thrift pull request: Fixed the path to the LICENSE file for Haskel...
Github user seanparsons commented on the pull request: https://github.com/apache/thrift/pull/272#issuecomment-63438188 The JIRA for this pull request is thus: https://issues.apache.org/jira/browse/THRIFT-2840 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2840) Cabal file points to LICENSE file outside the path of the Haskell project.
[
https://issues.apache.org/jira/browse/THRIFT-2840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14215914#comment-14215914
]
ASF GitHub Bot commented on THRIFT-2840:
Github user seanparsons commented on the pull request:
https://github.com/apache/thrift/pull/272#issuecomment-63438188
The JIRA for this pull request is thus:
https://issues.apache.org/jira/browse/THRIFT-2840
Cabal file points to LICENSE file outside the path of the Haskell project.
--
Key: THRIFT-2840
URL: https://issues.apache.org/jira/browse/THRIFT-2840
Project: Thrift
Issue Type: Bug
Components: Haskell - Library
Affects Versions: 0.9.2
Reporter: Sean Parsons
Priority: Blocker
Currently the Cabal file for the 0.9.2 package that is currently on Hackage
will break when an attempt is made to install it:
{code}
Downloading thrift-0.9.2...
Configuring thrift-0.9.2...
Warning: The 'license-file' field refers to the file '../../LICENSE' which
does not exist.
Building thrift-0.9.2...
Preprocessing library thrift-0.9.2...
[ 1 of 14] Compiling Thrift.Transport.IOBuffer (
src/Thrift/Transport/IOBuffer.hs,
dist/dist-sandbox-791868f2/build/Thrift/Transport/IOBuffer.o )
[ 2 of 14] Compiling Thrift.Arbitraries ( src/Thrift/Arbitraries.hs,
dist/dist-sandbox-791868f2/build/Thrift/Arbitraries.o )
[ 3 of 14] Compiling Thrift.Types ( src/Thrift/Types.hs,
dist/dist-sandbox-791868f2/build/Thrift/Types.o )
[ 4 of 14] Compiling Thrift.Transport ( src/Thrift/Transport.hs,
dist/dist-sandbox-791868f2/build/Thrift/Transport.o )
[ 5 of 14] Compiling Thrift.Protocol ( src/Thrift/Protocol.hs,
dist/dist-sandbox-791868f2/build/Thrift/Protocol.o )
[ 6 of 14] Compiling Thrift.Protocol.Binary ( src/Thrift/Protocol/Binary.hs,
dist/dist-sandbox-791868f2/build/Thrift/Protocol/Binary.o )
[ 7 of 14] Compiling Thrift.Protocol.Compact (
src/Thrift/Protocol/Compact.hs,
dist/dist-sandbox-791868f2/build/Thrift/Protocol/Compact.o )
[ 8 of 14] Compiling Thrift.Protocol.JSON ( src/Thrift/Protocol/JSON.hs,
dist/dist-sandbox-791868f2/build/Thrift/Protocol/JSON.o )
[ 9 of 14] Compiling Thrift.Transport.Handle (
src/Thrift/Transport/Handle.hs,
dist/dist-sandbox-791868f2/build/Thrift/Transport/Handle.o )
[10 of 14] Compiling Thrift.Transport.Empty ( src/Thrift/Transport/Empty.hs,
dist/dist-sandbox-791868f2/build/Thrift/Transport/Empty.o )
[11 of 14] Compiling Thrift.Transport.Framed (
src/Thrift/Transport/Framed.hs,
dist/dist-sandbox-791868f2/build/Thrift/Transport/Framed.o )
[12 of 14] Compiling Thrift.Transport.HttpClient (
src/Thrift/Transport/HttpClient.hs,
dist/dist-sandbox-791868f2/build/Thrift/Transport/HttpClient.o )
[13 of 14] Compiling Thrift ( src/Thrift.hs,
dist/dist-sandbox-791868f2/build/Thrift.o )
[14 of 14] Compiling Thrift.Server( src/Thrift/Server.hs,
dist/dist-sandbox-791868f2/build/Thrift/Server.o )
In-place registering thrift-0.9.2...
Creating package registration file: /tmp/pkgConf-thrift-0.925204.2
cabal: ../../LICENSE: does not exist
Failed to install thrift-0.9.2
cabal: Error: some packages failed to install:
thrift-0.9.2 failed during the final install step. The exception was:
ExitFailure 1
{code}
I've already created a pull request for this issue on Github which points the
path to the file already inside the Haskell lib folder:
https://github.com/apache/thrift/pull/272
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2729) C++ coding standards
[ https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14215952#comment-14215952 ] Konrad Grochowski commented on THRIFT-2729: --- commited, I'll add doc to coding_standards.md in branch later. make style added :) (requires clang-format 3.5) C++ coding standards Key: THRIFT-2729 URL: https://issues.apache.org/jira/browse/THRIFT-2729 Project: Thrift Issue Type: Sub-task Components: C++ - Library Reporter: Konrad Grochowski Attachments: .clang-format, CPPLINT.cfg -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2729) C++ coding standards
[ https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216041#comment-14216041 ] Hudson commented on THRIFT-2729: FAILURE: Integrated in Thrift #1357 (See [https://builds.apache.org/job/Thrift/1357/]) THRIFT-2729: C++ - .clang-format created and applied (hcorg: rev 74260aa9099c3bb209bc8e524b0e8ba603f62c41) * lib/cpp/test/ThriftTest_extras.cpp * lib/cpp/src/thrift/concurrency/Exception.h * lib/cpp/src/thrift/Thrift.cpp * lib/cpp/src/thrift/server/TNonblockingServer.cpp * lib/cpp/src/thrift/transport/TServerSocket.cpp * compiler/cpp/src/parse/t_typedef.h * compiler/cpp/src/generate/t_st_generator.cc * lib/cpp/src/thrift/server/TSimpleServer.h * lib/cpp/test/RecursiveTest.cpp * lib/cpp/src/thrift/protocol/TProtocolTap.h * lib/cpp/src/thrift/concurrency/BoostMonitor.cpp * lib/cpp/test/concurrency/ThreadManagerTests.h * lib/cpp/src/thrift/protocol/TDebugProtocol.cpp * lib/cpp/src/thrift/protocol/TProtocolException.h * test/cpp/src/StressTestNonBlocking.cpp * lib/cpp/src/thrift/transport/TSocket.h * lib/cpp/src/thrift/TLogging.h * lib/cpp/test/processor/EventLog.h * lib/cpp/src/thrift/concurrency/Monitor.h * compiler/cpp/src/parse/t_const_value.h * compiler/cpp/src/main.h * configure.ac * lib/cpp/src/thrift/transport/TServerTransport.h * lib/cpp/src/thrift/concurrency/StdThreadFactory.cpp * lib/cpp/src/thrift/server/TSimpleServer.cpp * lib/cpp/src/thrift/Thrift.h * lib/cpp/src/thrift/transport/TSSLServerSocket.h * lib/cpp/src/thrift/transport/TSocket.cpp * lib/cpp/src/thrift/TReflectionLocal.h * lib/cpp/src/thrift/transport/THttpTransport.h * lib/cpp/test/RWMutexStarveTest.cpp * lib/cpp/src/thrift/transport/TFileTransport.h * lib/cpp/src/thrift/transport/TSSLSocket.h * lib/cpp/src/thrift/transport/TFDTransport.h * compiler/cpp/src/parse/t_enum.h * lib/cpp/src/thrift/TToString.h * lib/cpp/test/processor/Handlers.h * compiler/cpp/src/parse/t_type.h * lib/cpp/src/thrift/TApplicationException.cpp * lib/cpp/src/thrift/protocol/TMultiplexedProtocol.cpp * lib/cpp/src/thrift/transport/THttpClient.cpp * lib/cpp/src/thrift/concurrency/Util.cpp * compiler/cpp/src/parse/t_struct.h * compiler/cpp/src/parse/t_container.h * tutorial/cpp/CppServer.cpp * lib/cpp/src/thrift/transport/TTransportUtils.cpp * lib/cpp/src/thrift/transport/THttpTransport.cpp * compiler/cpp/src/generate/t_as3_generator.cc * lib/cpp/src/thrift/concurrency/BoostThreadFactory.h * compiler/cpp/src/parse/t_map.h * lib/cpp/test/concurrency/TimerManagerTests.h * compiler/cpp/src/generate/t_hs_generator.cc * lib/cpp/test/processor/ServerThread.cpp * lib/cpp/src/thrift/protocol/TProtocol.h * test/cpp/src/TestServer.cpp * lib/cpp/src/thrift/protocol/TJSONProtocol.cpp * lib/cpp/src/thrift/async/TAsyncProcessor.h * compiler/cpp/src/parse/t_const.h * lib/cpp/src/thrift/transport/TSocketPool.h * lib/cpp/src/thrift/protocol/TCompactProtocol.h * lib/cpp/src/thrift/transport/TSimpleFileTransport.cpp * lib/cpp/test/processor/ProcessorTest.cpp * lib/cpp/src/thrift/concurrency/FunctionRunner.h * lib/cpp/src/thrift/concurrency/Thread.h * lib/cpp/src/thrift/server/TThreadedServer.cpp * lib/cpp/src/thrift/processor/PeekProcessor.cpp * lib/cpp/src/thrift/concurrency/PlatformThreadFactory.h * lib/cpp/src/thrift/transport/TPipe.cpp * lib/cpp/src/thrift/concurrency/TimerManager.h * compiler/cpp/src/main.cc * lib/cpp/src/thrift/transport/TBufferTransports.cpp * lib/cpp/src/thrift/async/TEvhttpClientChannel.cpp * compiler/cpp/src/generate/t_perl_generator.cc * compiler/cpp/src/parse/t_scope.h * lib/cpp/test/DebugProtoTest.cpp * lib/cpp/src/thrift/transport/TSSLSocket.cpp * compiler/cpp/src/generate/t_js_generator.cc * compiler/cpp/src/logging.h * lib/cpp/test/DenseProtoTest.cpp * lib/cpp/src/thrift/server/TServer.h * lib/cpp/src/thrift/server/TThreadPoolServer.h * compiler/cpp/Makefile.am * compiler/cpp/src/generate/t_cocoa_generator.cc * lib/cpp/test/Benchmark.cpp * lib/cpp/src/thrift/concurrency/TimerManager.cpp * lib/cpp/src/thrift/server/TThreadPoolServer.cpp * lib/cpp/src/thrift/windows/GetTimeOfDay.h * compiler/cpp/src/generate/t_rb_generator.cc * lib/cpp/test/TFileTransportTest.cpp * lib/cpp/src/thrift/async/TEvhttpServer.cpp * compiler/cpp/src/parse/t_function.h * lib/cpp/src/thrift/protocol/TVirtualProtocol.h * lib/cpp/src/thrift/thrift-config.h * lib/cpp/src/thrift/server/TNonblockingServer.h * lib/cpp/src/thrift/transport/TTransportException.h * test/cpp/Makefile.am * lib/cpp/test/concurrency/Tests.cpp * lib/cpp/src/thrift/async/TAsyncChannel.h * .clang-format * compiler/cpp/src/generate/t_generator.cc * lib/cpp/src/thrift/transport/TTransportException.cpp * lib/cpp/src/thrift/concurrency/PosixThreadFactory.cpp * lib/cpp/src/thrift/transport/TPipe.h * lib/cpp/src/thrift/async/TAsyncChannel.cpp * lib/cpp/src/thrift/concurrency/BoostThreadFactory.cpp * lib/cpp/src/thrift/transport/TZlibTransport.cpp * tutorial/cpp/Makefile.am *
Build failed in Jenkins: Thrift #1357
See https://builds.apache.org/job/Thrift/1357/changes Changes: [hcorg] THRIFT-2729: C++ - .clang-format created and applied -- [...truncated 582 lines...] checking whether the shell understands +=... yes checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop checking for /usr/bin/ld option to reload object files... -r checking for objdump... objdump checking how to recognize dependent libraries... pass_all checking for dlltool... no checking how to associate runtime and link libraries... printf %s\n checking for ar... ar checking for archiver @FILE support... @ checking for strip... strip checking for ranlib... ranlib checking for gawk... (cached) nawk checking command to parse /usr/bin/nm -B output from cc object... ok checking for sysroot... no checking for mt... mt checking if mt is a manifest tool... no checking for ANSI C header files... yes checking for sys/types.h... yes checking for sys/stat.h... yes checking for stdlib.h... yes checking for string.h... yes checking for memory.h... yes checking for strings.h... yes checking for inttypes.h... yes checking for stdint.h... yes checking for unistd.h... yes checking for dlfcn.h... yes checking for objdir... .libs checking if cc supports -fno-rtti -fno-exceptions... no checking for cc option to produce PIC... -fPIC -DPIC checking if cc PIC flag -fPIC -DPIC works... yes checking if cc static flag -static works... yes checking if cc supports -c -o file.o... yes checking if cc supports -c -o file.o... (cached) yes checking whether the cc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes checking whether -lc should be explicitly linked in... no checking dynamic linker characteristics... GNU/Linux ld.so checking how to hardcode library paths into programs... immediate checking whether stripping libraries is possible... yes checking if libtool supports shared libraries... yes checking whether to build shared libraries... yes checking whether to build static libraries... no checking how to run the C++ preprocessor... g++ -E checking for ld used by g++... /usr/bin/ld -m elf_x86_64 checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes checking for g++ option to produce PIC... -fPIC -DPIC checking if g++ PIC flag -fPIC -DPIC works... yes checking if g++ static flag -static works... yes checking if g++ supports -c -o file.o... yes checking if g++ supports -c -o file.o... (cached) yes checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes checking dynamic linker characteristics... (cached) GNU/Linux ld.so checking how to hardcode library paths into programs... immediate configure: creating ./config.status config.status: creating config.h config.status: executing libtool commands thrift 1.0.0-dev Building C++ Library . : yes Building C (GLib) Library : no Building Java Library : yes Building C# Library .. : yes Building Python Library .. : yes Building Ruby Library : no Building Haxe Library : no Building Haskell Library . : no Building Perl Library : yes Building PHP Library . : yes Building Erlang Library .. : no Building Go Library .. : yes Building D Library ... : no Building NodeJS Library .. : no Building Lua Library . : yes C++ Library: Build TZlibTransport .. : yes Build TNonblockingServer .. : yes Build TQTcpServer (Qt) : yes Java Library: Using javac ... : javac Using java : java Using ant . : /usr/bin/ant C# Library: Using .NET 3.5 : yes Python Library: Using Python .. : /usr/bin/python PHP Library: Using php-config .. : /usr/bin/php-config Perl Library: Using Perl : /usr/bin/perl Go Library: Using Go... : /usr/bin/go Using Go version... : go version go1.2.1 linux/amd64 Lua Library: Using Lua .. : /usr/bin/lua If something is missing that you think should be present, please skim the output of configure to find the missing component. Details are present in config.log. + make make all-recursive make[1]: Entering directory `https://builds.apache.org/job/Thrift/ws/' Making all in compiler/cpp make[2]: Entering directory `https://builds.apache.org/job/Thrift/ws/compiler/cpp' \ \ /bin/bash ../../ylwrap `test -f 'src/thrifty.yy' || echo './'`src/thrifty.yy y.tab.c thrifty.cc y.tab.h `echo thrifty.cc | sed -e s/cc$/hh/ -e s/cpp$/hpp/ -e s/cxx$/hxx/ -e s/c++$/h++/ -e s/c$/h/` y.output thrifty.output -- bison -y -d updating thrifty.hh make all-am make[3]: Entering directory
[jira] [Assigned] (THRIFT-2831) Removes dead code in web_server.js introduced in THRIFT-2819
[ https://issues.apache.org/jira/browse/THRIFT-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy Abernethy reassigned THRIFT-2831: --- Assignee: Randy Abernethy Removes dead code in web_server.js introduced in THRIFT-2819 Key: THRIFT-2831 URL: https://issues.apache.org/jira/browse/THRIFT-2831 Project: Thrift Issue Type: Bug Components: Node.js - Library Reporter: Chi Vinh Le Assignee: Randy Abernethy The commit https://issues.apache.org/jira/browse/THRIFT-2819 introduced dead code in web_server.js. Sorry it was introduced by me. The web_server.js was working totally fine even in binary cases. My code actually does nothing. This pull request will remove it: https://github.com/apache/thrift/pull/270 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Jenkins build is back to normal : Thrift #1358
See https://builds.apache.org/job/Thrift/1358/changes
[jira] [Commented] (THRIFT-2729) C++ coding standards
[ https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216057#comment-14216057 ] Hudson commented on THRIFT-2729: SUCCESS: Integrated in Thrift #1358 (See [https://builds.apache.org/job/Thrift/1358/]) Revert THRIFT-2729: C++ - .clang-format created and applied (hcorg: rev 240120c8434b49d1f76d207aff4e3530d3ada14b) * lib/cpp/src/thrift/protocol/TVirtualProtocol.h * lib/cpp/src/thrift/transport/TTransportUtils.cpp * compiler/cpp/src/parse/t_field.h * lib/cpp/src/thrift/async/TEvhttpClientChannel.h * compiler/cpp/src/parse/parse.cc * lib/cpp/src/thrift/transport/TSSLSocket.h * lib/cpp/src/thrift/thrift-config.h * lib/cpp/src/thrift/transport/TSSLServerSocket.h * lib/cpp/src/thrift/protocol/TMultiplexedProtocol.h * lib/cpp/src/thrift/server/TNonblockingServer.cpp * lib/cpp/test/ToStringTest.cpp * lib/cpp/test/JSONProtoTest.cpp * lib/cpp/src/thrift/concurrency/StdMutex.cpp * lib/cpp/src/thrift/async/TAsyncChannel.h * compiler/cpp/src/main.h * lib/cpp/src/thrift/server/TSimpleServer.h * lib/cpp/src/thrift/concurrency/Mutex.h * lib/cpp/src/thrift/concurrency/Thread.h * lib/cpp/test/concurrency/ThreadManagerTests.h * lib/cpp/test/RWMutexStarveTest.cpp * compiler/cpp/src/parse/t_set.h * lib/cpp/src/thrift/transport/TSimpleFileTransport.cpp * compiler/cpp/src/generate/t_generator.cc * lib/cpp/test/processor/EventLog.cpp * lib/cpp/test/DenseProtoTest.cpp * compiler/cpp/Makefile.am * lib/cpp/src/thrift/transport/TServerSocket.h * lib/cpp/src/thrift/protocol/TJSONProtocol.cpp * compiler/cpp/src/generate/t_hs_generator.cc * lib/cpp/src/thrift/protocol/TProtocol.h * lib/cpp/test/processor/ServerThread.h * lib/cpp/src/thrift/transport/TTransportException.cpp * test/cpp/src/ThriftTest_extras.cpp * lib/cpp/test/GenericHelpers.h * compiler/cpp/src/parse/t_map.h * compiler/cpp/src/generate/t_d_generator.cc * lib/cpp/src/thrift/server/TSimpleServer.cpp * lib/cpp/src/thrift/transport/PlatformSocket.h * lib/cpp/src/thrift/protocol/TBinaryProtocol.h * test/cpp/src/TestClient.cpp * lib/cpp/src/thrift/protocol/TProtocolException.h * lib/cpp/src/thrift/concurrency/PosixThreadFactory.cpp * compiler/cpp/src/generate/t_as3_generator.cc * lib/cpp/src/thrift/processor/TMultiplexedProcessor.h * tutorial/cpp/CppServer.cpp * lib/cpp/test/OpenSSLManualInitTest.cpp * lib/cpp/src/thrift/concurrency/Util.h * lib/cpp/src/thrift/concurrency/ThreadManager.h * test/cpp/Makefile.am * compiler/cpp/src/generate/t_xsd_generator.cc * lib/cpp/src/thrift/concurrency/BoostMonitor.cpp * compiler/cpp/src/parse/t_function.h * lib/cpp/src/thrift/transport/TSocket.h * compiler/cpp/src/parse/t_type.h * lib/cpp/test/TPipedTransportTest.cpp * compiler/cpp/src/generate/t_oop_generator.h * compiler/cpp/src/logging.h * lib/cpp/src/thrift/transport/TSSLServerSocket.cpp * lib/cpp/src/thrift/transport/TServerTransport.h * lib/cpp/src/thrift/transport/TSSLSocket.cpp * compiler/cpp/src/parse/t_scope.h * lib/cpp/src/thrift/transport/TServerSocket.cpp * lib/cpp/src/thrift/processor/PeekProcessor.h * lib/cpp/src/thrift/transport/TTransportException.h * compiler/cpp/src/generate/t_ocaml_generator.cc * lib/cpp/src/thrift/concurrency/ThreadManager.cpp * lib/cpp/src/thrift/windows/GetTimeOfDay.cpp * lib/cpp/test/OptionalRequiredTest.cpp * lib/cpp/src/thrift/async/TEvhttpServer.h * lib/cpp/src/thrift/transport/TShortReadTransport.h * compiler/cpp/src/parse/t_const_value.h * lib/cpp/test/ThriftTest_extras.cpp * lib/cpp/src/thrift/concurrency/Util.cpp * compiler/cpp/src/generate/t_html_generator.h * compiler/cpp/src/generate/t_cpp_generator.cc * lib/cpp/test/TFDTransportTest.cpp * lib/cpp/src/thrift/protocol/TDenseProtocol.h * lib/cpp/src/thrift/protocol/TJSONProtocol.h * lib/cpp/src/thrift/windows/SocketPair.cpp * lib/cpp/test/TFileTransportTest.cpp * lib/cpp/src/thrift/async/TAsyncProtocolProcessor.cpp * compiler/cpp/src/parse/t_doc.h * lib/cpp/src/thrift/concurrency/BoostThreadFactory.h * configure.ac * lib/cpp/src/thrift/protocol/TProtocolDecorator.h * lib/cpp/src/thrift/windows/TWinsockSingleton.h * compiler/cpp/src/generate/t_js_generator.cc * lib/cpp/src/thrift/concurrency/Mutex.cpp * lib/cpp/src/thrift/concurrency/Exception.h * lib/cpp/test/concurrency/ThreadFactoryTests.h * lib/cpp/src/thrift/transport/TFDTransport.h * lib/cpp/src/thrift/TReflectionLocal.h * lib/cpp/test/AllProtocolTests.cpp * lib/cpp/src/thrift/transport/TPipe.cpp * test/cpp/src/StressTestNonBlocking.cpp * lib/cpp/src/thrift/windows/Operators.h * lib/cpp/src/thrift/transport/TZlibTransport.cpp * lib/cpp/src/thrift/protocol/TBinaryProtocol.tcc * compiler/cpp/src/main.cc * lib/cpp/src/thrift/async/TAsyncBufferProcessor.h * compiler/cpp/src/parse/t_base_type.h * compiler/cpp/src/generate/t_html_generator.cc * compiler/cpp/src/generate/t_st_generator.cc * lib/cpp/test/processor/EventLog.h * lib/cpp/src/thrift/concurrency/StdMonitor.cpp *
[jira] [Commented] (THRIFT-2729) C++ coding standards
[ https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216070#comment-14216070 ] Hudson commented on THRIFT-2729: SUCCESS: Integrated in Thrift #1359 (See [https://builds.apache.org/job/Thrift/1359/]) THRIFT-2729: C++ - .clang-format created and applied (hcorg: rev 16a23a6618754a5a87aeb8df99a72516b0272fb3) * lib/cpp/src/thrift/transport/TTransportException.h * test/cpp/src/StressTestNonBlocking.cpp * lib/cpp/src/thrift/protocol/TProtocolDecorator.h * tutorial/cpp/CppServer.cpp * lib/cpp/src/thrift/async/TAsyncDispatchProcessor.h * lib/cpp/src/thrift/processor/TMultiplexedProcessor.h * lib/cpp/test/TFDTransportTest.cpp * lib/cpp/src/thrift/TReflectionLocal.h * lib/cpp/test/processor/EventLog.cpp * lib/cpp/src/thrift/windows/WinFcntl.cpp * lib/cpp/src/thrift/protocol/TProtocolTap.h * lib/cpp/test/DenseProtoTest.cpp * lib/cpp/src/thrift/cxxfunctional.h * lib/cpp/test/Base64Test.cpp * lib/cpp/src/thrift/transport/THttpClient.cpp * lib/cpp/test/concurrency/ThreadManagerTests.h * lib/cpp/src/thrift/processor/StatsProcessor.h * lib/cpp/src/thrift/transport/TSocket.cpp * lib/cpp/src/thrift/windows/GetTimeOfDay.h * compiler/cpp/src/parse/t_list.h * lib/cpp/src/thrift/protocol/TProtocolException.h * lib/cpp/test/processor/Handlers.h * lib/cpp/src/thrift/async/TAsyncProtocolProcessor.cpp * compiler/cpp/src/generate/t_ocaml_generator.cc * lib/cpp/src/thrift/VirtualProfiling.cpp * lib/cpp/src/thrift/protocol/TBinaryProtocol.tcc * compiler/cpp/src/parse/t_enum.h * compiler/cpp/src/generate/t_cpp_generator.cc * lib/cpp/src/thrift/windows/TWinsockSingleton.cpp * lib/cpp/src/thrift/protocol/TMultiplexedProtocol.cpp * lib/cpp/src/thrift/concurrency/Mutex.cpp * lib/cpp/src/thrift/server/TNonblockingServer.h * lib/cpp/src/thrift/transport/TSSLServerSocket.cpp * lib/cpp/src/thrift/qt/TQIODeviceTransport.h * test/cpp/src/TestClient.cpp * lib/cpp/test/ZlibTest.cpp * lib/cpp/src/thrift/thrift-config.h * lib/cpp/src/thrift/transport/TSocket.h * lib/cpp/test/processor/EventLog.h * lib/cpp/src/thrift/concurrency/Util.cpp * lib/cpp/src/thrift/concurrency/Monitor.cpp * lib/cpp/src/thrift/TLogging.h * compiler/cpp/src/generate/t_html_generator.h * lib/cpp/src/thrift/transport/TBufferTransports.h * lib/cpp/src/thrift/concurrency/PlatformThreadFactory.h * compiler/cpp/src/generate/t_rb_generator.cc * compiler/cpp/src/generate/t_gv_generator.cc * lib/cpp/test/AllProtocolTests.cpp * compiler/cpp/src/md5.h * lib/cpp/test/TPipedTransportTest.cpp * lib/cpp/test/OptionalRequiredTest.cpp * lib/cpp/src/thrift/windows/WinFcntl.h * lib/cpp/src/thrift/qt/TQTcpServer.h * lib/cpp/src/thrift/windows/Operators.h * compiler/cpp/src/generate/t_generator_registry.h * lib/cpp/src/thrift/server/TThreadPoolServer.cpp * lib/cpp/src/thrift/transport/TPipeServer.cpp * lib/cpp/src/thrift/concurrency/StdMutex.cpp * lib/cpp/src/thrift/concurrency/BoostThreadFactory.cpp * lib/cpp/src/thrift/Thrift.h * lib/cpp/src/thrift/transport/TPipe.h * lib/cpp/src/thrift/protocol/TCompactProtocol.h * lib/cpp/Makefile.am * compiler/cpp/src/generate/t_javame_generator.cc * lib/cpp/src/thrift/transport/TServerSocket.h * compiler/cpp/src/generate/t_generator.h * compiler/cpp/src/main.h * lib/cpp/src/thrift/transport/TTransportUtils.h * lib/cpp/src/thrift/transport/TFDTransport.cpp * tutorial/cpp/CppClient.cpp * lib/cpp/test/concurrency/Tests.cpp * lib/cpp/src/thrift/protocol/TMultiplexedProtocol.h * lib/cpp/src/thrift/protocol/TDenseProtocol.h * compiler/cpp/src/parse/t_field.h * lib/cpp/src/thrift/transport/TFileTransport.cpp * lib/cpp/src/thrift/concurrency/PosixThreadFactory.cpp * lib/cpp/src/thrift/TProcessor.h * lib/cpp/test/AllProtocolTests.tcc * lib/cpp/src/thrift/async/TAsyncChannel.cpp * compiler/cpp/src/generate/t_js_generator.cc * lib/cpp/src/thrift/concurrency/StdThreadFactory.cpp * compiler/cpp/src/generate/t_erl_generator.cc * lib/cpp/src/thrift/transport/TSSLServerSocket.h * lib/cpp/src/thrift/qt/TQTcpServer.cpp * lib/cpp/src/thrift/transport/PlatformSocket.h * lib/cpp/src/thrift/server/TThreadedServer.h * lib/cpp/src/thrift/windows/Sync.h * compiler/cpp/src/main.cc * lib/cpp/src/thrift/processor/PeekProcessor.h * lib/cpp/src/thrift/TApplicationException.h * lib/cpp/src/thrift/concurrency/BoostThreadFactory.h * compiler/cpp/src/parse/t_const_value.h * lib/cpp/src/thrift/transport/TSimpleFileTransport.h * lib/cpp/src/thrift/async/TEvhttpClientChannel.h * compiler/cpp/src/parse/t_type.h * lib/cpp/src/thrift/qt/TQIODeviceTransport.cpp * compiler/cpp/src/parse/t_enum_value.h * compiler/cpp/src/generate/t_generator.cc * lib/cpp/src/thrift/transport/TTransport.h * tutorial/cpp/Makefile.am * compiler/cpp/src/generate/t_d_generator.cc * compiler/cpp/src/generate/t_as3_generator.cc * lib/cpp/src/thrift/transport/TShortReadTransport.h * lib/cpp/src/thrift/transport/THttpTransport.cpp * lib/cpp/src/thrift/transport/TSocketPool.cpp *
[jira] [Closed] (THRIFT-2840) Cabal file points to LICENSE file outside the path of the Haskell project.
[
https://issues.apache.org/jira/browse/THRIFT-2840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-2840.
Resolution: Fixed
Fix Version/s: 0.9.3
Assignee: Sean Parsons
Committed, thanks for the patch
Cabal file points to LICENSE file outside the path of the Haskell project.
--
Key: THRIFT-2840
URL: https://issues.apache.org/jira/browse/THRIFT-2840
Project: Thrift
Issue Type: Bug
Components: Haskell - Library
Affects Versions: 0.9.2
Reporter: Sean Parsons
Assignee: Sean Parsons
Priority: Blocker
Fix For: 0.9.3
Currently the Cabal file for the 0.9.2 package that is currently on Hackage
will break when an attempt is made to install it:
{code}
Downloading thrift-0.9.2...
Configuring thrift-0.9.2...
Warning: The 'license-file' field refers to the file '../../LICENSE' which
does not exist.
Building thrift-0.9.2...
Preprocessing library thrift-0.9.2...
[ 1 of 14] Compiling Thrift.Transport.IOBuffer (
src/Thrift/Transport/IOBuffer.hs,
dist/dist-sandbox-791868f2/build/Thrift/Transport/IOBuffer.o )
[ 2 of 14] Compiling Thrift.Arbitraries ( src/Thrift/Arbitraries.hs,
dist/dist-sandbox-791868f2/build/Thrift/Arbitraries.o )
[ 3 of 14] Compiling Thrift.Types ( src/Thrift/Types.hs,
dist/dist-sandbox-791868f2/build/Thrift/Types.o )
[ 4 of 14] Compiling Thrift.Transport ( src/Thrift/Transport.hs,
dist/dist-sandbox-791868f2/build/Thrift/Transport.o )
[ 5 of 14] Compiling Thrift.Protocol ( src/Thrift/Protocol.hs,
dist/dist-sandbox-791868f2/build/Thrift/Protocol.o )
[ 6 of 14] Compiling Thrift.Protocol.Binary ( src/Thrift/Protocol/Binary.hs,
dist/dist-sandbox-791868f2/build/Thrift/Protocol/Binary.o )
[ 7 of 14] Compiling Thrift.Protocol.Compact (
src/Thrift/Protocol/Compact.hs,
dist/dist-sandbox-791868f2/build/Thrift/Protocol/Compact.o )
[ 8 of 14] Compiling Thrift.Protocol.JSON ( src/Thrift/Protocol/JSON.hs,
dist/dist-sandbox-791868f2/build/Thrift/Protocol/JSON.o )
[ 9 of 14] Compiling Thrift.Transport.Handle (
src/Thrift/Transport/Handle.hs,
dist/dist-sandbox-791868f2/build/Thrift/Transport/Handle.o )
[10 of 14] Compiling Thrift.Transport.Empty ( src/Thrift/Transport/Empty.hs,
dist/dist-sandbox-791868f2/build/Thrift/Transport/Empty.o )
[11 of 14] Compiling Thrift.Transport.Framed (
src/Thrift/Transport/Framed.hs,
dist/dist-sandbox-791868f2/build/Thrift/Transport/Framed.o )
[12 of 14] Compiling Thrift.Transport.HttpClient (
src/Thrift/Transport/HttpClient.hs,
dist/dist-sandbox-791868f2/build/Thrift/Transport/HttpClient.o )
[13 of 14] Compiling Thrift ( src/Thrift.hs,
dist/dist-sandbox-791868f2/build/Thrift.o )
[14 of 14] Compiling Thrift.Server( src/Thrift/Server.hs,
dist/dist-sandbox-791868f2/build/Thrift/Server.o )
In-place registering thrift-0.9.2...
Creating package registration file: /tmp/pkgConf-thrift-0.925204.2
cabal: ../../LICENSE: does not exist
Failed to install thrift-0.9.2
cabal: Error: some packages failed to install:
thrift-0.9.2 failed during the final install step. The exception was:
ExitFailure 1
{code}
I've already created a pull request for this issue on Github which points the
path to the file already inside the Haskell lib folder:
https://github.com/apache/thrift/pull/272
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2840) Cabal file points to LICENSE file outside the path of the Haskell project.
[
https://issues.apache.org/jira/browse/THRIFT-2840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216210#comment-14216210
]
Hudson commented on THRIFT-2840:
SUCCESS: Integrated in Thrift #1360 (See
[https://builds.apache.org/job/Thrift/1360/])
THRIFT-2840: Cabal file points to LICENSE file outside the path of the Haskell
project. (jfarrell: rev 0a93dcde9fff3b04cd37386bb2461e62dec3ed01)
* lib/hs/Thrift.cabal
Cabal file points to LICENSE file outside the path of the Haskell project.
--
Key: THRIFT-2840
URL: https://issues.apache.org/jira/browse/THRIFT-2840
Project: Thrift
Issue Type: Bug
Components: Haskell - Library
Affects Versions: 0.9.2
Reporter: Sean Parsons
Assignee: Sean Parsons
Priority: Blocker
Fix For: 0.9.3
Currently the Cabal file for the 0.9.2 package that is currently on Hackage
will break when an attempt is made to install it:
{code}
Downloading thrift-0.9.2...
Configuring thrift-0.9.2...
Warning: The 'license-file' field refers to the file '../../LICENSE' which
does not exist.
Building thrift-0.9.2...
Preprocessing library thrift-0.9.2...
[ 1 of 14] Compiling Thrift.Transport.IOBuffer (
src/Thrift/Transport/IOBuffer.hs,
dist/dist-sandbox-791868f2/build/Thrift/Transport/IOBuffer.o )
[ 2 of 14] Compiling Thrift.Arbitraries ( src/Thrift/Arbitraries.hs,
dist/dist-sandbox-791868f2/build/Thrift/Arbitraries.o )
[ 3 of 14] Compiling Thrift.Types ( src/Thrift/Types.hs,
dist/dist-sandbox-791868f2/build/Thrift/Types.o )
[ 4 of 14] Compiling Thrift.Transport ( src/Thrift/Transport.hs,
dist/dist-sandbox-791868f2/build/Thrift/Transport.o )
[ 5 of 14] Compiling Thrift.Protocol ( src/Thrift/Protocol.hs,
dist/dist-sandbox-791868f2/build/Thrift/Protocol.o )
[ 6 of 14] Compiling Thrift.Protocol.Binary ( src/Thrift/Protocol/Binary.hs,
dist/dist-sandbox-791868f2/build/Thrift/Protocol/Binary.o )
[ 7 of 14] Compiling Thrift.Protocol.Compact (
src/Thrift/Protocol/Compact.hs,
dist/dist-sandbox-791868f2/build/Thrift/Protocol/Compact.o )
[ 8 of 14] Compiling Thrift.Protocol.JSON ( src/Thrift/Protocol/JSON.hs,
dist/dist-sandbox-791868f2/build/Thrift/Protocol/JSON.o )
[ 9 of 14] Compiling Thrift.Transport.Handle (
src/Thrift/Transport/Handle.hs,
dist/dist-sandbox-791868f2/build/Thrift/Transport/Handle.o )
[10 of 14] Compiling Thrift.Transport.Empty ( src/Thrift/Transport/Empty.hs,
dist/dist-sandbox-791868f2/build/Thrift/Transport/Empty.o )
[11 of 14] Compiling Thrift.Transport.Framed (
src/Thrift/Transport/Framed.hs,
dist/dist-sandbox-791868f2/build/Thrift/Transport/Framed.o )
[12 of 14] Compiling Thrift.Transport.HttpClient (
src/Thrift/Transport/HttpClient.hs,
dist/dist-sandbox-791868f2/build/Thrift/Transport/HttpClient.o )
[13 of 14] Compiling Thrift ( src/Thrift.hs,
dist/dist-sandbox-791868f2/build/Thrift.o )
[14 of 14] Compiling Thrift.Server( src/Thrift/Server.hs,
dist/dist-sandbox-791868f2/build/Thrift/Server.o )
In-place registering thrift-0.9.2...
Creating package registration file: /tmp/pkgConf-thrift-0.925204.2
cabal: ../../LICENSE: does not exist
Failed to install thrift-0.9.2
cabal: Error: some packages failed to install:
thrift-0.9.2 failed during the final install step. The exception was:
ExitFailure 1
{code}
I've already created a pull request for this issue on Github which points the
path to the file already inside the Haskell lib folder:
https://github.com/apache/thrift/pull/272
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2832) Generate thrift c_glib code for client only
[ https://issues.apache.org/jira/browse/THRIFT-2832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216258#comment-14216258 ] Simon South commented on THRIFT-2832: - There's no switch that does this presently, so that would be a new feature that would need be added. Frankly I think a better use of time would be to improve the compiler so the code it produces no longer generates warnings. If you post another ticket with details of the problem you're seeing, I'll investigate. Generate thrift c_glib code for client only --- Key: THRIFT-2832 URL: https://issues.apache.org/jira/browse/THRIFT-2832 Project: Thrift Issue Type: Question Components: C glib - Compiler Affects Versions: 0.9.2 Reporter: wuhzj Priority: Minor I noticed that in latest thrift v0.9.2, the C (GLib) compiler and library to add support for implementing servers. But in my case, I got some compiling warnings in when compiling the generated server side code after upgrade to 0.9.2. Actually, I just use thrift c glib in client side, Is it possible to generate the client side code only? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request: Fixed the path to the LICENSE file for Haskel...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/272 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Comment Edited] (THRIFT-2832) Generate thrift c_glib code for client only
[ https://issues.apache.org/jira/browse/THRIFT-2832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216374#comment-14216374 ] wuhzj edited comment on THRIFT-2832 at 11/18/14 4:28 PM: - The warnings are similar, all are related to release of liststring variable, I just paste one of them here. /home/jinzhao/nosql/hg_proxy_build/proxy/c/thrift_c_glib/o_n_d_b.c: In function 'o_n_d_b_processor_process_multi_delete': /home/jinzhao/nosql/hg_proxy_build/proxy/c/thrift_c_glib/o_n_d_b.c:11309:7: warning: passing argument 1 of 'g_array_unref' from incompatible pointer type [enabled by default] /usr/local/include/glib-2.0/glib/garray.h:84:9: note: expected 'struct GArray *' but argument is of type 'struct GPtrArray *' The signature of the function multiDelete like below, there is a parameter liststring includedTable, in the generated c code, includedTable is a variable with the type of GPtrArray * , but in the code to do cleanup work, it is released using g_array_unref(includedTable) but not g_ptr_array_unref(includedTable), so this cause the below warnings. TInt multiDelete(1:string tableName, 2:TRow key, 3:TFieldRange fieldRange, 4:liststring includedTable, 5:TWriteOptions writeOptions) throws (1:TDurabilityException de, 2:TRequestTimeoutException re, 3:TFaultException fe, 4:TProxyException pe, 5:TIllegalArgumentException iae); In c code, the includedTable is released using g_array_unref() like bellow. if (includedTable != NULL) g_array_unref (includedTable); Not sure if above information is enough, please let me know If you need more information. Thanks in advance. was (Author: wuhzj): The warnings are similar, I just paste one of them here. The signature of the function multiDelete like bellow, there is a parameter liststring includedTable, in the generated c code, includedTable is a variable with GPtrArray * type, but in the code to do cleanup work, it is released using g_array_unref(includedTable) but not g_ptr_array_unref(includedTable), so this cause the below warnings. TInt multiDelete(1:string tableName, 2:TRow key, 3:TFieldRange fieldRange, 4:liststring includedTable, 5:TWriteOptions writeOptions) throws (1:TDurabilityException de, 2:TRequestTimeoutException re, 3:TFaultException fe, 4:TProxyException pe, 5:TIllegalArgumentException iae); if (includedTable != NULL) g_array_unref (includedTable); Generate thrift c_glib code for client only --- Key: THRIFT-2832 URL: https://issues.apache.org/jira/browse/THRIFT-2832 Project: Thrift Issue Type: Question Components: C glib - Compiler Affects Versions: 0.9.2 Reporter: wuhzj Priority: Minor I noticed that in latest thrift v0.9.2, the C (GLib) compiler and library to add support for implementing servers. But in my case, I got some compiling warnings in when compiling the generated server side code after upgrade to 0.9.2. Actually, I just use thrift c glib in client side, Is it possible to generate the client side code only? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (THRIFT-2832) Generate thrift c_glib code for client only
[ https://issues.apache.org/jira/browse/THRIFT-2832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216374#comment-14216374 ] wuhzj edited comment on THRIFT-2832 at 11/18/14 4:28 PM: - The warnings are similar, all are related to release of liststring variable, I just paste one of them here. /home/jinzhao/nosql/hg_proxy_build/proxy/c/thrift_c_glib/o_n_d_b.c: In function 'o_n_d_b_processor_process_multi_delete': /home/jinzhao/nosql/hg_proxy_build/proxy/c/thrift_c_glib/o_n_d_b.c:11309:7: warning: passing argument 1 of 'g_array_unref' from incompatible pointer type [enabled by default] /usr/local/include/glib-2.0/glib/garray.h:84:9: note: expected 'struct GArray *' but argument is of type 'struct GPtrArray *' The signature of the function multiDelete like below, there is a parameter liststring includedTable, in the generated c code, includedTable is a variable with the type of GPtrArray * , but in the code to do cleanup work, it is released using g_array_unref(includedTable) but not g_ptr_array_unref(includedTable), so this cause the below warnings. TInt multiDelete(1:string tableName, 2:TRow key, 3:TFieldRange fieldRange, 4:liststring includedTable, 5:TWriteOptions writeOptions) throws (1:TDurabilityException de, 2:TRequestTimeoutException re, 3:TFaultException fe, 4:TProxyException pe, 5:TIllegalArgumentException iae); In c code, the includedTable is released using g_array_unref() like below: if (includedTable != NULL) g_array_unref (includedTable); Not sure if above information is enough, please let me know If you need more information. Thanks in advance. was (Author: wuhzj): The warnings are similar, all are related to release of liststring variable, I just paste one of them here. /home/jinzhao/nosql/hg_proxy_build/proxy/c/thrift_c_glib/o_n_d_b.c: In function 'o_n_d_b_processor_process_multi_delete': /home/jinzhao/nosql/hg_proxy_build/proxy/c/thrift_c_glib/o_n_d_b.c:11309:7: warning: passing argument 1 of 'g_array_unref' from incompatible pointer type [enabled by default] /usr/local/include/glib-2.0/glib/garray.h:84:9: note: expected 'struct GArray *' but argument is of type 'struct GPtrArray *' The signature of the function multiDelete like below, there is a parameter liststring includedTable, in the generated c code, includedTable is a variable with the type of GPtrArray * , but in the code to do cleanup work, it is released using g_array_unref(includedTable) but not g_ptr_array_unref(includedTable), so this cause the below warnings. TInt multiDelete(1:string tableName, 2:TRow key, 3:TFieldRange fieldRange, 4:liststring includedTable, 5:TWriteOptions writeOptions) throws (1:TDurabilityException de, 2:TRequestTimeoutException re, 3:TFaultException fe, 4:TProxyException pe, 5:TIllegalArgumentException iae); In c code, the includedTable is released using g_array_unref() like bellow. if (includedTable != NULL) g_array_unref (includedTable); Not sure if above information is enough, please let me know If you need more information. Thanks in advance. Generate thrift c_glib code for client only --- Key: THRIFT-2832 URL: https://issues.apache.org/jira/browse/THRIFT-2832 Project: Thrift Issue Type: Question Components: C glib - Compiler Affects Versions: 0.9.2 Reporter: wuhzj Priority: Minor I noticed that in latest thrift v0.9.2, the C (GLib) compiler and library to add support for implementing servers. But in my case, I got some compiling warnings in when compiling the generated server side code after upgrade to 0.9.2. Actually, I just use thrift c glib in client side, Is it possible to generate the client side code only? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (THRIFT-2832) Generate thrift c_glib code for client only
[ https://issues.apache.org/jira/browse/THRIFT-2832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simon South reassigned THRIFT-2832: --- Assignee: Simon South Generate thrift c_glib code for client only --- Key: THRIFT-2832 URL: https://issues.apache.org/jira/browse/THRIFT-2832 Project: Thrift Issue Type: Question Components: C glib - Compiler Affects Versions: 0.9.2 Reporter: wuhzj Assignee: Simon South Priority: Minor I noticed that in latest thrift v0.9.2, the C (GLib) compiler and library to add support for implementing servers. But in my case, I got some compiling warnings in when compiling the generated server side code after upgrade to 0.9.2. Actually, I just use thrift c glib in client side, Is it possible to generate the client side code only? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (THRIFT-2833) Version 0.9.2 not available on Maven Central
[ https://issues.apache.org/jira/browse/THRIFT-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-2833. Resolution: Fixed Fix Version/s: 0.7 published http://repo.maven.apache.org/maven2/org/apache/thrift/libthrift/0.9.2/ Version 0.9.2 not available on Maven Central Key: THRIFT-2833 URL: https://issues.apache.org/jira/browse/THRIFT-2833 Project: Thrift Issue Type: Task Components: Java - Library Reporter: Zlika Assignee: Jake Farrell Fix For: 0.7 It is written in the download page (https://thrift.apache.org/download) that Thrift 0.9.2 is available on Maven Central. Sadly, this is not the case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2833) Version 0.9.2 not available on Maven Central
[ https://issues.apache.org/jira/browse/THRIFT-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216646#comment-14216646 ] Zlika commented on THRIFT-2833: --- Thanks! Version 0.9.2 not available on Maven Central Key: THRIFT-2833 URL: https://issues.apache.org/jira/browse/THRIFT-2833 Project: Thrift Issue Type: Task Components: Java - Library Reporter: Zlika Assignee: Jake Farrell Fix For: 0.7 It is written in the download page (https://thrift.apache.org/download) that Thrift 0.9.2 is available on Maven Central. Sadly, this is not the case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2831) Removes dead code in web_server.js introduced in THRIFT-2819
[ https://issues.apache.org/jira/browse/THRIFT-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy Abernethy resolved THRIFT-2831. - Resolution: Fixed Fix Version/s: 0.9.3 Committed. Removes dead code in web_server.js introduced in THRIFT-2819 Key: THRIFT-2831 URL: https://issues.apache.org/jira/browse/THRIFT-2831 Project: Thrift Issue Type: Bug Components: Node.js - Library Reporter: Chi Vinh Le Assignee: Randy Abernethy Fix For: 0.9.3 The commit https://issues.apache.org/jira/browse/THRIFT-2819 introduced dead code in web_server.js. Sorry it was introduced by me. The web_server.js was working totally fine even in binary cases. My code actually does nothing. This pull request will remove it: https://github.com/apache/thrift/pull/270 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2834) Remove semi-colons from python code generator
[ https://issues.apache.org/jira/browse/THRIFT-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216748#comment-14216748 ] Randy Abernethy commented on THRIFT-2834: - Hello Cash, I'd like to commit this but it doesn't apply to the current master. Can you update the patch? Best, Randy Remove semi-colons from python code generator - Key: THRIFT-2834 URL: https://issues.apache.org/jira/browse/THRIFT-2834 Project: Thrift Issue Type: Task Components: Python - Compiler Reporter: Cash Costello Priority: Trivial The python compiler is adding unnecessary semi-colons to a few of the line endings. A PR to fix this is on github at https://github.com/apache/thrift/pull/250 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (THRIFT-2834) Remove semi-colons from python code generator
[ https://issues.apache.org/jira/browse/THRIFT-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy Abernethy reassigned THRIFT-2834: --- Assignee: Randy Abernethy Remove semi-colons from python code generator - Key: THRIFT-2834 URL: https://issues.apache.org/jira/browse/THRIFT-2834 Project: Thrift Issue Type: Task Components: Python - Compiler Reporter: Cash Costello Assignee: Randy Abernethy Priority: Trivial The python compiler is adding unnecessary semi-colons to a few of the line endings. A PR to fix this is on github at https://github.com/apache/thrift/pull/250 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (THRIFT-2821) Enable the use of custom HTTP-Header in the Transport
[ https://issues.apache.org/jira/browse/THRIFT-2821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy Abernethy reassigned THRIFT-2821: --- Assignee: Randy Abernethy Enable the use of custom HTTP-Header in the Transport - Key: THRIFT-2821 URL: https://issues.apache.org/jira/browse/THRIFT-2821 Project: Thrift Issue Type: Improvement Components: JavaScript - Library Affects Versions: 0.9.2 Environment: Browser Reporter: David Sautter Assignee: Randy Abernethy Priority: Trivial Labels: features Attachments: 0001-THRIFT-2821-Enable-the-use-of-custom-HTTP-Header-in-.patch Original Estimate: 1h Remaining Estimate: 1h Several Thrift server implementations (for example csharp) enable to read custom HTTP Headers, but the JavaScript Client is not yet able to provide them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (THRIFT-2817) TSimpleJSONProtocol reads beyond end of message
[ https://issues.apache.org/jira/browse/THRIFT-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-2817: -- Assignee: Jens Geyer TSimpleJSONProtocol reads beyond end of message --- Key: THRIFT-2817 URL: https://issues.apache.org/jira/browse/THRIFT-2817 Project: Thrift Issue Type: Bug Components: Go - Library Reporter: Chi Vinh Le Assignee: Jens Geyer The TSimpleJSONProtocol reads beyond end of message, which prevent processing the message until more data arrives. https://github.com/apache/thrift/pull/264 EDIT: New pull request here: https://github.com/apache/thrift/pull/273 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (THRIFT-2841) Add comprehensive integration tests for the whole Go stack
Jens Geyer created THRIFT-2841: -- Summary: Add comprehensive integration tests for the whole Go stack Key: THRIFT-2841 URL: https://issues.apache.org/jira/browse/THRIFT-2841 Project: Thrift Issue Type: Sub-task Components: Go - Library Reporter: Jens Geyer Assignee: Jens Geyer Fix For: 0.9.3 Issue extracted from THRIFT-2817: To test THRIFT-2817 fix I ported the integration tests from the nodejs thrift library to go. Those are comprehensive integration tests that tests the whole thrift stack. The tests revealed another problem in TFramedTransport (see THRIFT-2839) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2831) Removes dead code in web_server.js introduced in THRIFT-2819
[ https://issues.apache.org/jira/browse/THRIFT-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216767#comment-14216767 ] Hudson commented on THRIFT-2831: SUCCESS: Integrated in Thrift #1361 (See [https://builds.apache.org/job/Thrift/1361/]) THRIFT-2831:Eliminates dead code in node web server (ra: rev 9c0316bbf382860019e434e10955d3ac4186b830) * lib/nodejs/lib/thrift/web_server.js Removes dead code in web_server.js introduced in THRIFT-2819 Key: THRIFT-2831 URL: https://issues.apache.org/jira/browse/THRIFT-2831 Project: Thrift Issue Type: Bug Components: Node.js - Library Reporter: Chi Vinh Le Assignee: Randy Abernethy Fix For: 0.9.3 The commit https://issues.apache.org/jira/browse/THRIFT-2819 introduced dead code in web_server.js. Sorry it was introduced by me. The web_server.js was working totally fine even in binary cases. My code actually does nothing. This pull request will remove it: https://github.com/apache/thrift/pull/270 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-615) TThreadPoolServer doesn't call task_done after pulling tasks from it's clients queue
[ https://issues.apache.org/jira/browse/THRIFT-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy Abernethy resolved THRIFT-615. Resolution: Invalid Assignee: Randy Abernethy (was: David Reiss) This patch no longer applies. If the concern persists in the current master please create a new issue. TThreadPoolServer doesn't call task_done after pulling tasks from it's clients queue Key: THRIFT-615 URL: https://issues.apache.org/jira/browse/THRIFT-615 Project: Thrift Issue Type: Bug Components: Python - Library Reporter: Matt Jones Assignee: Randy Abernethy Priority: Minor Attachments: thrift-task-done-2.diff, thrift-task-done.diff Original Estimate: 0h Remaining Estimate: 0h Exactly as the title says. The effect of the bug is that you can't join the clients queue, since no client has ever signalled itself as done. The fix is trivial (patch attached). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (THRIFT-388) Use a separate wire format for async calls
[ https://issues.apache.org/jira/browse/THRIFT-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy Abernethy reassigned THRIFT-388: -- Assignee: Randy Abernethy (was: David Reiss) Use a separate wire format for async calls -- Key: THRIFT-388 URL: https://issues.apache.org/jira/browse/THRIFT-388 Project: Thrift Issue Type: Improvement Reporter: David Reiss Assignee: Randy Abernethy Priority: Minor Fix For: 1.0 Attachments: ASF.LICENSE.NOT.GRANTED--0001-THRIFT-388.-Create-a-ONEWAY-message-type-that-is-a.patch If async calls look different from normal calls on the wire, then a proxy with no access to the particular IDL will be able to distinguish them. That will be good. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-388) Use a separate wire format for async calls
[ https://issues.apache.org/jira/browse/THRIFT-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy Abernethy resolved THRIFT-388. Resolution: Duplicate This patch no longer applies, oneway has been widely implemented. Use a separate wire format for async calls -- Key: THRIFT-388 URL: https://issues.apache.org/jira/browse/THRIFT-388 Project: Thrift Issue Type: Improvement Reporter: David Reiss Assignee: Randy Abernethy Priority: Minor Fix For: 1.0 Attachments: ASF.LICENSE.NOT.GRANTED--0001-THRIFT-388.-Create-a-ONEWAY-message-type-that-is-a.patch If async calls look different from normal calls on the wire, then a proxy with no access to the particular IDL will be able to distinguish them. That will be good. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2548) Nodejs servers and clients does not work properly with -ssl
[
https://issues.apache.org/jira/browse/THRIFT-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randy Abernethy resolved THRIFT-2548.
-
Resolution: Fixed
Assignee: Randy Abernethy
Repaired elsewhere.
Nodejs servers and clients does not work properly with -ssl
Key: THRIFT-2548
URL: https://issues.apache.org/jira/browse/THRIFT-2548
Project: Thrift
Issue Type: Bug
Components: Node.js - Library, Test Suite
Reporter: Chamila Dilshan Wijayarathna
Assignee: Randy Abernethy
Labels: gsoc2014
When trying to run lib/nodejs/test/client.js with 'ssl', it gives following
error.
chamila@chamila-Aspire-5742:~/gsoc/1/thrift/test$ node
${NODE_TEST_DIR}/client.js -p binary -t buffered --ssl
/home/chamila/gsoc/1/thrift/lib/nodejs/test/client.js:62
connection = thrift.createSSLConnection('localhost', 9090, options);
^
TypeError: Object #Object has no method 'createSSLConnection'
at Object.anonymous
(/home/chamila/gsoc/1/thrift/lib/nodejs/test/client.js:62:23)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Function.Module.runMain (module.js:497:10)
at startup (node.js:119:16)
at node.js:902:3
When trying to connect to node server with ssl using another client, server
does not receive requests from client.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (THRIFT-2841) Add comprehensive integration tests for the whole Go stack
[ https://issues.apache.org/jira/browse/THRIFT-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2841. Resolution: Fixed Committed, thanks! Add comprehensive integration tests for the whole Go stack -- Key: THRIFT-2841 URL: https://issues.apache.org/jira/browse/THRIFT-2841 Project: Thrift Issue Type: Sub-task Components: Go - Library Reporter: Jens Geyer Assignee: Jens Geyer Fix For: 0.9.3 Issue extracted from THRIFT-2817: To test THRIFT-2817 fix I ported the integration tests from the nodejs thrift library to go. Those are comprehensive integration tests that tests the whole thrift stack. The tests revealed another problem in TFramedTransport (see THRIFT-2839) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2839) TFramedTransport read bug
[ https://issues.apache.org/jira/browse/THRIFT-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2839. Resolution: Fixed Fix Version/s: 0.9.3 Committed, thanks! TFramedTransport read bug - Key: THRIFT-2839 URL: https://issues.apache.org/jira/browse/THRIFT-2839 Project: Thrift Issue Type: Bug Components: Go - Library Affects Versions: 0.9.2 Reporter: Chi Vinh Le Assignee: Jens Geyer Fix For: 0.9.3 When calling TFramedTransport.Read, it should return remaining bytes. Currently throws an error without reading, when passing a []byte that is bigger than frame_size. PR available at: https://github.com/apache/thrift/pull/273 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2817) TSimpleJSONProtocol reads beyond end of message
[ https://issues.apache.org/jira/browse/THRIFT-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2817. Resolution: Fixed Fix Version/s: 0.9.3 Committed, thanks! TSimpleJSONProtocol reads beyond end of message --- Key: THRIFT-2817 URL: https://issues.apache.org/jira/browse/THRIFT-2817 Project: Thrift Issue Type: Bug Components: Go - Library Reporter: Chi Vinh Le Assignee: Jens Geyer Fix For: 0.9.3 The TSimpleJSONProtocol reads beyond end of message, which prevent processing the message until more data arrives. https://github.com/apache/thrift/pull/264 EDIT: New pull request here: https://github.com/apache/thrift/pull/273 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2790) thrift -gen all = an option to generate all languages and features
[
https://issues.apache.org/jira/browse/THRIFT-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216816#comment-14216816
]
Jens Geyer commented on THRIFT-2790:
Nice (except for the tabs :-)), but this still does not cover {{js:node}} and
the like. To be honest, I have no idea how these special switches could be
distinguished from the normal ones. Maybe we need to pass some special flag
or option when registering the generators to have these information somewhere,
somehow present.
thrift -gen all = an option to generate all languages and features
---
Key: THRIFT-2790
URL: https://issues.apache.org/jira/browse/THRIFT-2790
Project: Thrift
Issue Type: Improvement
Components: Compiler (General), Documentation, Test Suite
Reporter: Roger Meier
Attachments:
0001-THRIFT-2790-gen-all-option-to-easily-test-compatibil.patch,
generate-all-languages.bat
I would like to have a *thrift -gen all* option to generate everything we
have in one step. This would allow proper testing of all compiler changes by
using test/ThriftTest.thrift. An optional make check target could compare
different versions based on their git hash or to previous gen-all.backup
folder.
Suggested-by: Roger Meier ro...@apache.org
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2547) nodejs servers and clients fails to connect with cpp using compact protocol
[
https://issues.apache.org/jira/browse/THRIFT-2547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216832#comment-14216832
]
Randy Abernethy commented on THRIFT-2547:
-
test/test.sh reports nodejs client - cpp server ok but other way around is
still a problem.
nodejs servers and clients fails to connect with cpp using compact protocol
---
Key: THRIFT-2547
URL: https://issues.apache.org/jira/browse/THRIFT-2547
Project: Thrift
Issue Type: Bug
Components: Node.js - Library, Test Suite
Reporter: Chamila Dilshan Wijayarathna
Labels: gsoc2014
Nodejs servers give following error.
BAD: -2111766528
events.js:74
throw TypeError('Uncaught, unspecified error event.');
^
TypeError: Uncaught, unspecified error event.
at TypeError (anonymous)
at Server.EventEmitter.emit (events.js:74:15)
at
/home/chamila/gsoc/1/thrift/node_modules/thrift/lib/thrift/server.js:54:16
at Socket.anonymous
(/home/chamila/gsoc/1/thrift/node_modules/thrift/lib/thrift/transport.js:185:5)
at Socket.EventEmitter.emit (events.js:95:17)
at Socket.anonymous (_stream_readable.js:746:14)
at Socket.EventEmitter.emit (events.js:92:17)
at emitReadable_ (_stream_readable.js:408:10)
at emitReadable (_stream_readable.js:404:5)
at readableAddChunk (_stream_readable.js:165:9)
Nodejs Client gives following errors.
write set 8 3
assert.js:92
throw new assert.AssertionError({
^
AssertionError: Error: write EPIPE
at testDriver (/home/chamila/gsoc/1/thrift/lib/nodejs/test/client.js:70:3)
at EventEmitter.emit (events.js:95:17)
at Socket.anonymous
(/home/chamila/gsoc/1/thrift/node_modules/thrift/lib/thrift/connection.js:59:12)
at Socket.EventEmitter.emit (events.js:95:17)
at onwriteError (_stream_writable.js:235:10)
at onwrite (_stream_writable.js:253:5)
at WritableState.onwrite (_stream_writable.js:97:5)
at fireErrorCallbacks (net.js:438:13)
at Socket._destroy (net.js:472:3)
at Object.afterWrite (net.js:718:10)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (THRIFT-2547) nodejs servers and clients fails to connect with cpp using compact protocol
[
https://issues.apache.org/jira/browse/THRIFT-2547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randy Abernethy reassigned THRIFT-2547:
---
Assignee: Randy Abernethy
nodejs servers and clients fails to connect with cpp using compact protocol
---
Key: THRIFT-2547
URL: https://issues.apache.org/jira/browse/THRIFT-2547
Project: Thrift
Issue Type: Bug
Components: Node.js - Library, Test Suite
Reporter: Chamila Dilshan Wijayarathna
Assignee: Randy Abernethy
Labels: gsoc2014
Nodejs servers give following error.
BAD: -2111766528
events.js:74
throw TypeError('Uncaught, unspecified error event.');
^
TypeError: Uncaught, unspecified error event.
at TypeError (anonymous)
at Server.EventEmitter.emit (events.js:74:15)
at
/home/chamila/gsoc/1/thrift/node_modules/thrift/lib/thrift/server.js:54:16
at Socket.anonymous
(/home/chamila/gsoc/1/thrift/node_modules/thrift/lib/thrift/transport.js:185:5)
at Socket.EventEmitter.emit (events.js:95:17)
at Socket.anonymous (_stream_readable.js:746:14)
at Socket.EventEmitter.emit (events.js:92:17)
at emitReadable_ (_stream_readable.js:408:10)
at emitReadable (_stream_readable.js:404:5)
at readableAddChunk (_stream_readable.js:165:9)
Nodejs Client gives following errors.
write set 8 3
assert.js:92
throw new assert.AssertionError({
^
AssertionError: Error: write EPIPE
at testDriver (/home/chamila/gsoc/1/thrift/lib/nodejs/test/client.js:70:3)
at EventEmitter.emit (events.js:95:17)
at Socket.anonymous
(/home/chamila/gsoc/1/thrift/node_modules/thrift/lib/thrift/connection.js:59:12)
at Socket.EventEmitter.emit (events.js:95:17)
at onwriteError (_stream_writable.js:235:10)
at onwrite (_stream_writable.js:253:5)
at WritableState.onwrite (_stream_writable.js:97:5)
at fireErrorCallbacks (net.js:438:13)
at Socket._destroy (net.js:472:3)
at Object.afterWrite (net.js:718:10)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2738) JS coding standards
[ https://issues.apache.org/jira/browse/THRIFT-2738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216842#comment-14216842 ] Randy Abernethy commented on THRIFT-2738: - Code should report 0 warnings and errors when linted with JSHint. Also, particularly important for un-compiled languages, everything needs a test (100% code coverage). I think that is all we need. JS coding standards --- Key: THRIFT-2738 URL: https://issues.apache.org/jira/browse/THRIFT-2738 Project: Thrift Issue Type: Sub-task Components: JavaScript - Library, Node.js - Library Reporter: Konrad Grochowski -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (THRIFT-1754) RangeError in buffer handling
[
https://issues.apache.org/jira/browse/THRIFT-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randy Abernethy reassigned THRIFT-1754:
---
Assignee: Randy Abernethy
RangeError in buffer handling
-
Key: THRIFT-1754
URL: https://issues.apache.org/jira/browse/THRIFT-1754
Project: Thrift
Issue Type: Bug
Components: Node.js - Library
Affects Versions: 0.9
Environment: Ubuntu 12.04, Node.js v0.8.8
Reporter: Vesa Poikajärvi
Assignee: Randy Abernethy
Priority: Minor
I have a Node.js service that connects to multiple Thrift servers (using
TFramedTransport with C++ servers and TBufferedTransport with Python
servers). Every now and then for reasons rather hard to track the following
happens:
{noformat}
buffer.js:242
this.parent = new SlowBuffer(this.length);
^
RangeError: length kMaxLength
at new Buffer (buffer.js:242:21)
at Socket.TFramedTransport.receiver
(/home/me/my_service/node_modules/thrift/lib/thrift/transport.js:59:17)
at Socket.EventEmitter.emit (events.js:88:17)
at TCP.onread (net.js:395:14)
{noformat}
Node module is extracted from Thrift 0.9 tarball due to THRIFT-1637. And as
mentioned, I cannot really tell what triggers the behavior. When running in
development mode I use [Forever|https://github.com/nodejitsu/forever] to
relaunch a crashed process, and when it first crashes because of this it will
keep relaunching a few times, maybe ten or so (I connect to the services upon
startup), and then it starts working again.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2841) Add comprehensive integration tests for the whole Go stack
[ https://issues.apache.org/jira/browse/THRIFT-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216850#comment-14216850 ] Hudson commented on THRIFT-2841: SUCCESS: Integrated in Thrift #1362 (See [https://builds.apache.org/job/Thrift/1362/]) THRIFT-2841 Add comprehensive integration tests for the whole Go stack (jensg: rev 5f9bdffd2aefb3e1d1b0cc717f0e7dc5a2a16ad7) * lib/go/test/tests/thrifttest_handler.go * lib/go/test/tests/protocols_test.go * lib/go/test/tests/thrifttest_driver.go Add comprehensive integration tests for the whole Go stack -- Key: THRIFT-2841 URL: https://issues.apache.org/jira/browse/THRIFT-2841 Project: Thrift Issue Type: Sub-task Components: Go - Library Reporter: Jens Geyer Assignee: Jens Geyer Fix For: 0.9.3 Issue extracted from THRIFT-2817: To test THRIFT-2817 fix I ported the integration tests from the nodejs thrift library to go. Those are comprehensive integration tests that tests the whole thrift stack. The tests revealed another problem in TFramedTransport (see THRIFT-2839) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2817) TSimpleJSONProtocol reads beyond end of message
[ https://issues.apache.org/jira/browse/THRIFT-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216851#comment-14216851 ] Hudson commented on THRIFT-2817: SUCCESS: Integrated in Thrift #1362 (See [https://builds.apache.org/job/Thrift/1362/]) THRIFT-2817 Smarter buffer peeking for json protocols (jensg: rev 2f971e8f742fcaa0c84cfcc4f02eb844123e5819) * lib/go/thrift/json_protocol.go * lib/go/thrift/simple_json_protocol_test.go * lib/go/thrift/simple_json_protocol.go TSimpleJSONProtocol reads beyond end of message --- Key: THRIFT-2817 URL: https://issues.apache.org/jira/browse/THRIFT-2817 Project: Thrift Issue Type: Bug Components: Go - Library Reporter: Chi Vinh Le Assignee: Jens Geyer Fix For: 0.9.3 The TSimpleJSONProtocol reads beyond end of message, which prevent processing the message until more data arrives. https://github.com/apache/thrift/pull/264 EDIT: New pull request here: https://github.com/apache/thrift/pull/273 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-1754) RangeError in buffer handling
[
https://issues.apache.org/jira/browse/THRIFT-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randy Abernethy resolved THRIFT-1754.
-
Resolution: Fixed
Fix Version/s: 0.9.2
Hi Vesa et. al.,
Node.js had many issues in v0.9. As Wade mentions 0.9.2 contains a very large
patch list for node. Please try 0.9.2 and reopen this issue if you still have
problems. As of the last week or so, npm install thrift will install 0.9.2.
Best,
Randy
RangeError in buffer handling
-
Key: THRIFT-1754
URL: https://issues.apache.org/jira/browse/THRIFT-1754
Project: Thrift
Issue Type: Bug
Components: Node.js - Library
Affects Versions: 0.9
Environment: Ubuntu 12.04, Node.js v0.8.8
Reporter: Vesa Poikajärvi
Assignee: Randy Abernethy
Priority: Minor
Fix For: 0.9.2
I have a Node.js service that connects to multiple Thrift servers (using
TFramedTransport with C++ servers and TBufferedTransport with Python
servers). Every now and then for reasons rather hard to track the following
happens:
{noformat}
buffer.js:242
this.parent = new SlowBuffer(this.length);
^
RangeError: length kMaxLength
at new Buffer (buffer.js:242:21)
at Socket.TFramedTransport.receiver
(/home/me/my_service/node_modules/thrift/lib/thrift/transport.js:59:17)
at Socket.EventEmitter.emit (events.js:88:17)
at TCP.onread (net.js:395:14)
{noformat}
Node module is extracted from Thrift 0.9 tarball due to THRIFT-1637. And as
mentioned, I cannot really tell what triggers the behavior. When running in
development mode I use [Forever|https://github.com/nodejitsu/forever] to
relaunch a crashed process, and when it first crashes because of this it will
keep relaunching a few times, maybe ten or so (I connect to the services upon
startup), and then it starts working again.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2729) C++ coding standards
[ https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216858#comment-14216858 ] Roger Meier commented on THRIFT-2729: - great work Konrad! I really like our new *make style*. ;-r C++ coding standards Key: THRIFT-2729 URL: https://issues.apache.org/jira/browse/THRIFT-2729 Project: Thrift Issue Type: Sub-task Components: C++ - Library Reporter: Konrad Grochowski Attachments: .clang-format, CPPLINT.cfg -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (THRIFT-2546) cross language tests fails at 'TestMultiException' when using nodejs server
[ https://issues.apache.org/jira/browse/THRIFT-2546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy Abernethy resolved THRIFT-2546. - Resolution: Duplicate This is 2547 from another angle. Will address there. cross language tests fails at 'TestMultiException' when using nodejs server --- Key: THRIFT-2546 URL: https://issues.apache.org/jira/browse/THRIFT-2546 Project: Thrift Issue Type: Bug Components: Node.js - Library, Test Suite Reporter: Chamila Dilshan Wijayarathna Labels: gsoc2014 Nodejs server gives following message when failing. testMultiException(Xception, test 1) testMultiException(Xception2, test 2) testMultiException(success, test 3) events.js:72 throw er; // Unhandled 'error' event ^ Error: read ECONNRESET at errnoException (net.js:901:11) at TCP.onread (net.js:556:19) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-1754) RangeError in buffer handling
[
https://issues.apache.org/jira/browse/THRIFT-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216867#comment-14216867
]
Branden Visser commented on THRIFT-1754:
There is a unit test over in a github fork of this that reproduces the issue:
https://github.com/simplereach/node-thrift/commit/602b7b275641016b30ebd715ee40288e3418080a
If that unit test can be ported, then it would be possible to ensure it is
resolved.
RangeError in buffer handling
-
Key: THRIFT-1754
URL: https://issues.apache.org/jira/browse/THRIFT-1754
Project: Thrift
Issue Type: Bug
Components: Node.js - Library
Affects Versions: 0.9
Environment: Ubuntu 12.04, Node.js v0.8.8
Reporter: Vesa Poikajärvi
Assignee: Randy Abernethy
Priority: Minor
Fix For: 0.9.2
I have a Node.js service that connects to multiple Thrift servers (using
TFramedTransport with C++ servers and TBufferedTransport with Python
servers). Every now and then for reasons rather hard to track the following
happens:
{noformat}
buffer.js:242
this.parent = new SlowBuffer(this.length);
^
RangeError: length kMaxLength
at new Buffer (buffer.js:242:21)
at Socket.TFramedTransport.receiver
(/home/me/my_service/node_modules/thrift/lib/thrift/transport.js:59:17)
at Socket.EventEmitter.emit (events.js:88:17)
at TCP.onread (net.js:395:14)
{noformat}
Node module is extracted from Thrift 0.9 tarball due to THRIFT-1637. And as
mentioned, I cannot really tell what triggers the behavior. When running in
development mode I use [Forever|https://github.com/nodejitsu/forever] to
relaunch a crashed process, and when it first crashes because of this it will
keep relaunching a few times, maybe ten or so (I connect to the services upon
startup), and then it starts working again.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2729) C++ coding standards
[ https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216885#comment-14216885 ] Konrad Grochowski commented on THRIFT-2729: --- thanks, I hope I'll be able to find more such tools for other libs (clang-format can be used also for java and javascript, but I have to check how it behaves) C++ coding standards Key: THRIFT-2729 URL: https://issues.apache.org/jira/browse/THRIFT-2729 Project: Thrift Issue Type: Sub-task Components: C++ - Library Reporter: Konrad Grochowski Attachments: .clang-format, CPPLINT.cfg -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request: Fixes THRIFT-2817 and THRIFT-2839
Github user cvlchinet commented on the pull request: https://github.com/apache/thrift/pull/273#issuecomment-63554886 Commited. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: THRIFT-2831 - Removes dead code in web_server...
Github user cvlchinet commented on the pull request: https://github.com/apache/thrift/pull/270#issuecomment-63554942 Commited. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2817) TSimpleJSONProtocol reads beyond end of message
[ https://issues.apache.org/jira/browse/THRIFT-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216903#comment-14216903 ] ASF GitHub Bot commented on THRIFT-2817: Github user cvlchinet closed the pull request at: https://github.com/apache/thrift/pull/273 TSimpleJSONProtocol reads beyond end of message --- Key: THRIFT-2817 URL: https://issues.apache.org/jira/browse/THRIFT-2817 Project: Thrift Issue Type: Bug Components: Go - Library Reporter: Chi Vinh Le Assignee: Jens Geyer Fix For: 0.9.3 The TSimpleJSONProtocol reads beyond end of message, which prevent processing the message until more data arrives. https://github.com/apache/thrift/pull/264 EDIT: New pull request here: https://github.com/apache/thrift/pull/273 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request: Fixes THRIFT-2817 and THRIFT-2839
Github user cvlchinet closed the pull request at: https://github.com/apache/thrift/pull/273 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2817) TSimpleJSONProtocol reads beyond end of message
[ https://issues.apache.org/jira/browse/THRIFT-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216901#comment-14216901 ] ASF GitHub Bot commented on THRIFT-2817: Github user cvlchinet commented on the pull request: https://github.com/apache/thrift/pull/273#issuecomment-63554886 Commited. TSimpleJSONProtocol reads beyond end of message --- Key: THRIFT-2817 URL: https://issues.apache.org/jira/browse/THRIFT-2817 Project: Thrift Issue Type: Bug Components: Go - Library Reporter: Chi Vinh Le Assignee: Jens Geyer Fix For: 0.9.3 The TSimpleJSONProtocol reads beyond end of message, which prevent processing the message until more data arrives. https://github.com/apache/thrift/pull/264 EDIT: New pull request here: https://github.com/apache/thrift/pull/273 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request: THRIFT-2831 - Removes dead code in web_server...
Github user cvlchinet closed the pull request at: https://github.com/apache/thrift/pull/270 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2831) Removes dead code in web_server.js introduced in THRIFT-2819
[ https://issues.apache.org/jira/browse/THRIFT-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216904#comment-14216904 ] ASF GitHub Bot commented on THRIFT-2831: Github user cvlchinet commented on the pull request: https://github.com/apache/thrift/pull/270#issuecomment-63554942 Commited. Removes dead code in web_server.js introduced in THRIFT-2819 Key: THRIFT-2831 URL: https://issues.apache.org/jira/browse/THRIFT-2831 Project: Thrift Issue Type: Bug Components: Node.js - Library Reporter: Chi Vinh Le Assignee: Randy Abernethy Fix For: 0.9.3 The commit https://issues.apache.org/jira/browse/THRIFT-2819 introduced dead code in web_server.js. Sorry it was introduced by me. The web_server.js was working totally fine even in binary cases. My code actually does nothing. This pull request will remove it: https://github.com/apache/thrift/pull/270 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2831) Removes dead code in web_server.js introduced in THRIFT-2819
[ https://issues.apache.org/jira/browse/THRIFT-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216905#comment-14216905 ] ASF GitHub Bot commented on THRIFT-2831: Github user cvlchinet closed the pull request at: https://github.com/apache/thrift/pull/270 Removes dead code in web_server.js introduced in THRIFT-2819 Key: THRIFT-2831 URL: https://issues.apache.org/jira/browse/THRIFT-2831 Project: Thrift Issue Type: Bug Components: Node.js - Library Reporter: Chi Vinh Le Assignee: Randy Abernethy Fix For: 0.9.3 The commit https://issues.apache.org/jira/browse/THRIFT-2819 introduced dead code in web_server.js. Sorry it was introduced by me. The web_server.js was working totally fine even in binary cases. My code actually does nothing. This pull request will remove it: https://github.com/apache/thrift/pull/270 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2790) thrift -gen all = an option to generate all languages and features
[ https://issues.apache.org/jira/browse/THRIFT-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216908#comment-14216908 ] Roger Meier commented on THRIFT-2790: - Oh yes, the compiler needs some refactoring. The options are compiler internally only available as strings... no map, vector; such data structure might contain valid option combinations as well. This is required to achieve the -gen all-full option. and the tabs... I'm happy to have make style up and running with the first language to automate this;-r thrift -gen all = an option to generate all languages and features --- Key: THRIFT-2790 URL: https://issues.apache.org/jira/browse/THRIFT-2790 Project: Thrift Issue Type: Improvement Components: Compiler (General), Documentation, Test Suite Reporter: Roger Meier Attachments: 0001-THRIFT-2790-gen-all-option-to-easily-test-compatibil.patch, generate-all-languages.bat I would like to have a *thrift -gen all* option to generate everything we have in one step. This would allow proper testing of all compiler changes by using test/ThriftTest.thrift. An optional make check target could compare different versions based on their git hash or to previous gen-all.backup folder. Suggested-by: Roger Meier ro...@apache.org -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request: add support for running under Browserify
Github user cvlchinet commented on the pull request: https://github.com/apache/thrift/pull/251#issuecomment-63556192 Did you double check that data really comes as an Uint8Array and not a plain ArrayBuffer? And to get more attention and to follow their contribution rules, you should file an issue in JIRA: https://issues.apache.org/jira/browse/THRIFT/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: Update simple_json_protocol.go
Github user cvlchinet commented on the pull request: https://github.com/apache/thrift/pull/134#issuecomment-63557119 This was fixed in https://github.com/apache/thrift/pull/273. Can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-1754) RangeError in buffer handling
[
https://issues.apache.org/jira/browse/THRIFT-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216935#comment-14216935
]
Randy Abernethy commented on THRIFT-1754:
-
Hey Branden,
I just looked through transport.js and I'm pretty sure this has been squared
away (nice fix though). It was certainly one of many problems with 0.9.1 and
prior. Would be super to get a patch for your test that will apply to master
though. Maybe a self contained assert based unit test in
lib/nodejs/test/transport.js ?
-Randy
RangeError in buffer handling
-
Key: THRIFT-1754
URL: https://issues.apache.org/jira/browse/THRIFT-1754
Project: Thrift
Issue Type: Bug
Components: Node.js - Library
Affects Versions: 0.9
Environment: Ubuntu 12.04, Node.js v0.8.8
Reporter: Vesa Poikajärvi
Assignee: Randy Abernethy
Priority: Minor
Fix For: 0.9.2
I have a Node.js service that connects to multiple Thrift servers (using
TFramedTransport with C++ servers and TBufferedTransport with Python
servers). Every now and then for reasons rather hard to track the following
happens:
{noformat}
buffer.js:242
this.parent = new SlowBuffer(this.length);
^
RangeError: length kMaxLength
at new Buffer (buffer.js:242:21)
at Socket.TFramedTransport.receiver
(/home/me/my_service/node_modules/thrift/lib/thrift/transport.js:59:17)
at Socket.EventEmitter.emit (events.js:88:17)
at TCP.onread (net.js:395:14)
{noformat}
Node module is extracted from Thrift 0.9 tarball due to THRIFT-1637. And as
mentioned, I cannot really tell what triggers the behavior. When running in
development mode I use [Forever|https://github.com/nodejitsu/forever] to
relaunch a crashed process, and when it first crashes because of this it will
keep relaunching a few times, maybe ten or so (I connect to the services upon
startup), and then it starts working again.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (THRIFT-1976) Javascript client unable to serialize/deserialize maps with struct keys
[
https://issues.apache.org/jira/browse/THRIFT-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randy Abernethy reassigned THRIFT-1976:
---
Assignee: Randy Abernethy
Javascript client unable to serialize/deserialize maps with struct keys
---
Key: THRIFT-1976
URL: https://issues.apache.org/jira/browse/THRIFT-1976
Project: Thrift
Issue Type: Bug
Components: JavaScript - Compiler, JavaScript - Library
Affects Versions: 0.9
Environment: All
Reporter: Andrew Stanton
Assignee: Randy Abernethy
The Javascript compiler is unable to serialize maps where a struct is a key
due to particularities with how Javascript treats {} objects.
Using the following thrift definition:
struct Foo {
1: required string name;
}
struct Bar {
1: required string description;
}
struct Mapper {
1: required mapFoo,Bar fooToBar;
}
/* End */
It produces the following javascript code:
/* Start -Snipped */
Mapper.prototype.write = function(output) {
output.writeStructBegin('Mapper');
if (this.fooToBar !== null this.fooToBar !== undefined) {
output.writeFieldBegin('fooToBar', Thrift.Type.MAP, 1);
output.writeMapBegin(Thrift.Type.STRUCT, Thrift.Type.STRUCT,
Thrift.objectLength(this.fooToBar));
// XXX
// This will always fail as kiter8 will always be a String
// XXX
for (var kiter8 in this.fooToBar)
{
if (this.fooToBar.hasOwnProperty(kiter8))
{
var viter9 = this.fooToBar[kiter8];
// kiter8 is a string, not an object.
kiter8.write(output);
viter9.write(output);
}
}
output.writeMapEnd();
output.writeFieldEnd();
}
output.writeFieldStop();
output.writeStructEnd();
return;
};
/* END */
This code always fails since enumeration of an object's keys will always
yield String values. I've annotated the relevant parts in the above code.
There isn't really a simple fix for this either: Using for-in, there is no
way to get a reference to the original key object. Practically, a Map type
would have to be added to the thrift library with basic put()/get()/delete()
operations to allow for struct maps.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2324) Transport and Protocol JavaScript Implementations for Google Chrome Packaged Applications (js:chrome)
[ https://issues.apache.org/jira/browse/THRIFT-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216978#comment-14216978 ] Randy Abernethy commented on THRIFT-2324: - Hey Nicholas, any progress on this? Transport and Protocol JavaScript Implementations for Google Chrome Packaged Applications (js:chrome) - Key: THRIFT-2324 URL: https://issues.apache.org/jira/browse/THRIFT-2324 Project: Thrift Issue Type: New Feature Components: JavaScript - Library Reporter: Nicholas Whitehead Assignee: Randy Abernethy Priority: Minor Labels: Chrome, ChromeApps, JavaScript, Thrift Original Estimate: 672h Remaining Estimate: 672h This is an umbrella issue for the implementation of a Thrift JavaScript Library for the Google Chrome Packaged Applications API. The base language is JavaScript, and is browser (Chrome) resident, but the Chrome Apps API supports a full TCP Socket API so the intent is to implement Transport and Protocol libraries, similar in function to the nodejs Thrift libraries but using the native facilities of the Chrome Apps API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (THRIFT-2324) Transport and Protocol JavaScript Implementations for Google Chrome Packaged Applications (js:chrome)
[ https://issues.apache.org/jira/browse/THRIFT-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy Abernethy reassigned THRIFT-2324: --- Assignee: Randy Abernethy Transport and Protocol JavaScript Implementations for Google Chrome Packaged Applications (js:chrome) - Key: THRIFT-2324 URL: https://issues.apache.org/jira/browse/THRIFT-2324 Project: Thrift Issue Type: New Feature Components: JavaScript - Library Reporter: Nicholas Whitehead Assignee: Randy Abernethy Priority: Minor Labels: Chrome, ChromeApps, JavaScript, Thrift Original Estimate: 672h Remaining Estimate: 672h This is an umbrella issue for the implementation of a Thrift JavaScript Library for the Google Chrome Packaged Applications API. The base language is JavaScript, and is browser (Chrome) resident, but the Chrome Apps API supports a full TCP Socket API so the intent is to implement Transport and Protocol libraries, similar in function to the nodejs Thrift libraries but using the native facilities of the Chrome Apps API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request: Fixed the path to the LICENSE file for Haskel...
Github user igillis commented on the pull request: https://github.com/apache/thrift/pull/272#issuecomment-63561945 I ran into this last night -- thanks for fixing @seanparsons! I'm new to the Haskell/Thrift ecosystem -- will this fix be picked up by hackage or do I need to download the corresponding tarball from jenkins? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2756) register Media Type @ IANA
[
https://issues.apache.org/jira/browse/THRIFT-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14217001#comment-14217001
]
Randy Abernethy commented on THRIFT-2756:
-
Looks like they took compact as well:
http://www.iana.org/assignments/media-types/application/vnd.apache.thrift.compact
Any feedback on the JSON format?
register Media Type @ IANA
--
Key: THRIFT-2756
URL: https://issues.apache.org/jira/browse/THRIFT-2756
Project: Thrift
Issue Type: Improvement
Reporter: Roger Meier
Assignee: Roger Meier
Discussion started here THRIFT-2674
Goal is to get proper Content-Types for Apache Thrift:
{noformat}
Content-Type: application/vnd.apache.thrift.binary; # binary
Content-Type: application/vnd.apache.thrift.json; charset=utf-8 # 8-bit text
Content-Type: application/vnd.apache.thrift.compact;# binary
{noformat}
Binary was already accepted:
http://www.iana.org/assignments/media-types/application/vnd.apache.thrift.binary
json and compact are in Expert Review status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2756) register Media Type @ IANA
[
https://issues.apache.org/jira/browse/THRIFT-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14217144#comment-14217144
]
Henrique Mendonça commented on THRIFT-2756:
---
awesome work guys!
Cheers
register Media Type @ IANA
--
Key: THRIFT-2756
URL: https://issues.apache.org/jira/browse/THRIFT-2756
Project: Thrift
Issue Type: Improvement
Reporter: Roger Meier
Assignee: Roger Meier
Discussion started here THRIFT-2674
Goal is to get proper Content-Types for Apache Thrift:
{noformat}
Content-Type: application/vnd.apache.thrift.binary; # binary
Content-Type: application/vnd.apache.thrift.json; charset=utf-8 # 8-bit text
Content-Type: application/vnd.apache.thrift.compact;# binary
{noformat}
Binary was already accepted:
http://www.iana.org/assignments/media-types/application/vnd.apache.thrift.binary
json and compact are in Expert Review status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] thrift pull request: Fixes thrift-2834 : removed unnecessary semi-...
GitHub user cash opened a pull request: https://github.com/apache/thrift/pull/276 Fixes thrift-2834 : removed unnecessary semi-colons This replaces #250 as there had been a code standard update on master making for a difficult merge. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cash/thrift thrift-2834 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/276.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #276 commit 085001e54193bdce2f082d303bf6f5ea1ebf3ea3 Author: Cash Costello cash.coste...@gmail.com Date: 2014-11-19T01:42:02Z removed unnecessary semi-colons --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2834) Remove semi-colons from python code generator
[ https://issues.apache.org/jira/browse/THRIFT-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14217269#comment-14217269 ] Cash Costello commented on THRIFT-2834: --- https://github.com/apache/thrift/pull/276 Remove semi-colons from python code generator - Key: THRIFT-2834 URL: https://issues.apache.org/jira/browse/THRIFT-2834 Project: Thrift Issue Type: Task Components: Python - Compiler Reporter: Cash Costello Assignee: Randy Abernethy Priority: Trivial The python compiler is adding unnecessary semi-colons to a few of the line endings. A PR to fix this is on github at https://github.com/apache/thrift/pull/250 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] thrift pull request: Fixed the path to the LICENSE file for Haskel...
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/272#issuecomment-63583220 This will be picked up in the 0.9.3 release slated for early next month --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Updated] (THRIFT-2835) Add possibility to distribute generators separately from thrift core, and load them dynamically
[ https://issues.apache.org/jira/browse/THRIFT-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-2835: - Labels: fbthrift (was: fbthrift,) Add possibility to distribute generators separately from thrift core, and load them dynamically --- Key: THRIFT-2835 URL: https://issues.apache.org/jira/browse/THRIFT-2835 Project: Thrift Issue Type: New Feature Components: Compiler (General) Reporter: Anatol Pomozov Labels: fbthrift It is a follow-up for discussion with Facebook's fbthrift https://github.com/facebook/fbthrift/issues/48 fbthrift adds its own generator that creates C++ classes based on their libraries. I do not know how upstreamable this generator but I think other companies would want to do the same - create their own custom generators. Currently there is no way to distribute generators separately from the thrift core. Thus the company have to fork whole project and add their own generator. It is what Facebook did. The idea is that thrift should be able to load language generators dynamically. i.e. a company foo creates its own generator and puts it to system /usr/lib/thrift/generators/cpp_foo.so When thrift compiler starts - it checks /usr/lib/thrift/generators/ and uses dlopen() to load the shared libraries. The shared library contains information about the generator (name, options, ...) thus it allows thrift core to use this custom third-party generator. This allows companies to create and distribute generator will less pain and no need to fork the project. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2835) Add possibility to distribute generators separately from thrift core, and load them dynamically
[ https://issues.apache.org/jira/browse/THRIFT-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-2835: - Component/s: Compiler (General) Add possibility to distribute generators separately from thrift core, and load them dynamically --- Key: THRIFT-2835 URL: https://issues.apache.org/jira/browse/THRIFT-2835 Project: Thrift Issue Type: New Feature Components: Compiler (General) Reporter: Anatol Pomozov Labels: fbthrift It is a follow-up for discussion with Facebook's fbthrift https://github.com/facebook/fbthrift/issues/48 fbthrift adds its own generator that creates C++ classes based on their libraries. I do not know how upstreamable this generator but I think other companies would want to do the same - create their own custom generators. Currently there is no way to distribute generators separately from the thrift core. Thus the company have to fork whole project and add their own generator. It is what Facebook did. The idea is that thrift should be able to load language generators dynamically. i.e. a company foo creates its own generator and puts it to system /usr/lib/thrift/generators/cpp_foo.so When thrift compiler starts - it checks /usr/lib/thrift/generators/ and uses dlopen() to load the shared libraries. The shared library contains information about the generator (name, options, ...) thus it allows thrift core to use this custom third-party generator. This allows companies to create and distribute generator will less pain and no need to fork the project. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (THRIFT-2795) thrift_binary_protocol.c: 'dereferencing type-punned pointer will break strict-aliasing rules'
[
https://issues.apache.org/jira/browse/THRIFT-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell updated THRIFT-2795:
-
Component/s: Build Process
thrift_binary_protocol.c: 'dereferencing type-punned pointer will break
strict-aliasing rules'
--
Key: THRIFT-2795
URL: https://issues.apache.org/jira/browse/THRIFT-2795
Project: Thrift
Issue Type: Bug
Components: Build Process
Affects Versions: 0.9.1
Reporter: Anatol Pomozov
Priority: Minor
I am trying to compile the project on Linux Arch (gcc 4.9.1) and I see
following error:
{quote}
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../lib/cpp/src/thrift
-D_FORTIFY_SOURCE=2 -O2 -g -Wall -W -Werror -Isrc -I src/thrift/c_glib
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -MT
libthrift_c_glib_la-thrift_binary_protocol.lo -MD -MP -MF
.deps/libthrift_c_glib_la-thrift_binary_protocol.Tpo -c
src/thrift/c_glib/protocol/thrift_binary_protocol.c -fPIC -DPIC -o
.libs/libthrift_c_glib_la-thrift_binary_protocol.o
src/thrift/c_glib/protocol/thrift_binary_protocol.c: In function
'thrift_binary_protocol_read_i16':
src/thrift/c_glib/protocol/thrift_binary_protocol.c:672:3: error:
dereferencing type-punned pointer will break strict-aliasing rules
[-Werror=strict-aliasing]
*value = *(gint16 *) b;
^
src/thrift/c_glib/protocol/thrift_binary_protocol.c: In function
'thrift_binary_protocol_read_i32':
src/thrift/c_glib/protocol/thrift_binary_protocol.c:691:3: error:
dereferencing type-punned pointer will break strict-aliasing rules
[-Werror=strict-aliasing]
*value = *(gint32 *) b;
^
src/thrift/c_glib/protocol/thrift_binary_protocol.c: In function
'thrift_binary_protocol_read_i64':
src/thrift/c_glib/protocol/thrift_binary_protocol.c:710:3: error:
dereferencing type-punned pointer will break strict-aliasing rules
[-Werror=strict-aliasing]
*value = *(gint64 *) b;
^
src/thrift/c_glib/protocol/thrift_binary_protocol.c: In function
'thrift_binary_protocol_read_double':
src/thrift/c_glib/protocol/thrift_binary_protocol.c:729:3: error:
dereferencing type-punned pointer will break strict-aliasing rules
[-Werror=strict-aliasing]
guint64 bits = *(guint64 *) b;
^
cc1: all warnings being treated as errors
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] thrift pull request: Fixed the path to the LICENSE file for Haskel...
Github user igillis commented on the pull request: https://github.com/apache/thrift/pull/272#issuecomment-63592969 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Resolved] (THRIFT-2834) Remove semi-colons from python code generator
[ https://issues.apache.org/jira/browse/THRIFT-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy Abernethy resolved THRIFT-2834. - Resolution: Fixed Fix Version/s: 0.9.3 Thanks for the fast turn around Cash! Committed. Remove semi-colons from python code generator - Key: THRIFT-2834 URL: https://issues.apache.org/jira/browse/THRIFT-2834 Project: Thrift Issue Type: Task Components: Python - Compiler Reporter: Cash Costello Assignee: Randy Abernethy Priority: Trivial Fix For: 0.9.3 The python compiler is adding unnecessary semi-colons to a few of the line endings. A PR to fix this is on github at https://github.com/apache/thrift/pull/250 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2213) thrift org.apache.thrift.EncodingUtils.setBit(BIZ)B
[ https://issues.apache.org/jira/browse/THRIFT-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14217450#comment-14217450 ] Yanbo Liang commented on THRIFT-2213: - Multiple thrift version in your classpath. Maybe due to version mismatch between hive and hadoop. thrift org.apache.thrift.EncodingUtils.setBit(BIZ)B --- Key: THRIFT-2213 URL: https://issues.apache.org/jira/browse/THRIFT-2213 Project: Thrift Issue Type: Bug Components: Java - Library Reporter: lianwenbo Exception in thread main java.lang.NoSuchMethodError: org.apache.thrift.EncodingUtils.setBit(BIZ)B at org.apache.hadoop.hive.ql.plan.api.Query.setStartedIsSet(Query.java:487) at org.apache.hadoop.hive.ql.plan.api.Query.setStarted(Query.java:474) at org.apache.hadoop.hive.ql.QueryPlan.updateCountersInQueryPlan(QueryPlan.java:304) at org.apache.hadoop.hive.ql.QueryPlan.getQueryPlan(QueryPlan.java:437) at org.apache.hadoop.hive.ql.QueryPlan.toString(QueryPlan.java:609) at org.apache.hadoop.hive.ql.history.HiveHistory.logPlanProgress(HiveHistory.java:499) at org.apache.hadoop.hive.ql.Driver.execute(Driver.java:1059) at org.apache.hadoop.hive.ql.Driver.run(Driver.java:935) at org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:259) at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:216) at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:412) at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:755) at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:613) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.apache.hadoop.util.RunJar.main(RunJar.java:156) When running the show tables in hive cli, I find the above errors. I try to reinstall the thriftlib,but make no use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (THRIFT-2213) thrift org.apache.thrift.EncodingUtils.setBit(BIZ)B
[ https://issues.apache.org/jira/browse/THRIFT-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14217450#comment-14217450 ] Yanbo Liang edited comment on THRIFT-2213 at 11/19/14 5:38 AM: --- Multiple thrift version in your classpath. Maybe due to hive version is not compatible with hadoop. was (Author: yanboliang): Multiple thrift version in your classpath. Maybe due to version mismatch between hive and hadoop. thrift org.apache.thrift.EncodingUtils.setBit(BIZ)B --- Key: THRIFT-2213 URL: https://issues.apache.org/jira/browse/THRIFT-2213 Project: Thrift Issue Type: Bug Components: Java - Library Reporter: lianwenbo Exception in thread main java.lang.NoSuchMethodError: org.apache.thrift.EncodingUtils.setBit(BIZ)B at org.apache.hadoop.hive.ql.plan.api.Query.setStartedIsSet(Query.java:487) at org.apache.hadoop.hive.ql.plan.api.Query.setStarted(Query.java:474) at org.apache.hadoop.hive.ql.QueryPlan.updateCountersInQueryPlan(QueryPlan.java:304) at org.apache.hadoop.hive.ql.QueryPlan.getQueryPlan(QueryPlan.java:437) at org.apache.hadoop.hive.ql.QueryPlan.toString(QueryPlan.java:609) at org.apache.hadoop.hive.ql.history.HiveHistory.logPlanProgress(HiveHistory.java:499) at org.apache.hadoop.hive.ql.Driver.execute(Driver.java:1059) at org.apache.hadoop.hive.ql.Driver.run(Driver.java:935) at org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:259) at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:216) at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:412) at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:755) at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:613) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.apache.hadoop.util.RunJar.main(RunJar.java:156) When running the show tables in hive cli, I find the above errors. I try to reinstall the thriftlib,but make no use. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2834) Remove semi-colons from python code generator
[ https://issues.apache.org/jira/browse/THRIFT-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14217457#comment-14217457 ] Hudson commented on THRIFT-2834: SUCCESS: Integrated in Thrift #1363 (See [https://builds.apache.org/job/Thrift/1363/]) THRIFT-2834:Remove spurious semicolons in generated code (ra: rev 6a4589aa4fc2634bd0dcb37ab5782c9d39d28b41) * compiler/cpp/src/generate/t_py_generator.cc Remove semi-colons from python code generator - Key: THRIFT-2834 URL: https://issues.apache.org/jira/browse/THRIFT-2834 Project: Thrift Issue Type: Task Components: Python - Compiler Reporter: Cash Costello Assignee: Randy Abernethy Priority: Trivial Fix For: 0.9.3 The python compiler is adding unnecessary semi-colons to a few of the line endings. A PR to fix this is on github at https://github.com/apache/thrift/pull/250 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
