[jira] [Commented] (THRIFT-3859) Unix Domain Socket Support in Objective-C

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852623#comment-15852623
 ] 

ASF GitHub Bot commented on THRIFT-3859:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1031
  
Would it be possible to rebase this on master so we can get a clean CI 
build?  Also enabling unix socket transport in the "make cross" test would be 
really nice to validate this code.


> Unix Domain Socket Support in Objective-C
> -
>
> Key: THRIFT-3859
> URL: https://issues.apache.org/jira/browse/THRIFT-3859
> Project: Thrift
>  Issue Type: Improvement
>  Components: Cocoa - Library
>Affects Versions: 0.10.0
>Reporter: Chris Vasselli
>Priority: Minor
>
> I would like to be able to use Unix Domain Sockets as the transport to 
> communicate between different processes on a single machine. There seems to 
> be support in the C++ and Python libraries (the two other languages used in 
> my project), but no support in Objective-C.
> Proposed server interface:
> {{TSocketServer *server = [[TSocketServer alloc] 
> initWithPath:@"/path/to/pipe" protocolFactory:protocolFactory 
> processorFactory:processorFactory];}}
> Proposed client interface:
> {{TSocketTransport *socket = [[TSocketTransport alloc] 
> initWithPath:@"/path/to/pipe"];}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift issue #1031: THRIFT-3859: Unix Domain Socket Support in Objective-C

[jeking3]

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1031
  
Would it be possible to rebase this on master so we can get a clean CI 
build?  Also enabling unix socket transport in the "make cross" test would be 
really nice to validate this code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1177: edit comment

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1177


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1177: edit comment

[pigbrain]

GitHub user pigbrain opened a pull request:

https://github.com/apache/thrift/pull/1177

edit comment

I think the comment is wrong. so i fix it.

`setSoTimeout(0)` is for block on accept.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pigbrain/thrift master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1177.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1177


commit b2a6fb77dac8e114a075e5d185890d2d6bb3fac7
Author: pigbrain 
Date:   2017-02-03T14:41:43Z

I think the comment is wrong. So i fix comment.

setSoTimeout(0) is for block on accept.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---