[jira] [Closed] (THRIFT-4175) ts and with_ns options added to js generator with no help text

2017-04-17 Thread Randy Abernethy (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Randy Abernethy closed THRIFT-4175.
---
Resolution: Invalid

user error

> ts and with_ns options added to js generator with no help text
> --
>
> Key: THRIFT-4175
> URL: https://issues.apache.org/jira/browse/THRIFT-4175
> Project: Thrift
>  Issue Type: Improvement
>  Components: JavaScript - Compiler
>Affects Versions: 0.10.0
>Reporter: Randy Abernethy
>Priority: Minor
>
> thrift -help says nothing about js:ts or js:with_ns



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (THRIFT-4018) Ruby server can corrupt connections by putting ApplicationException in the middle of a response

2017-04-17 Thread Dan Bravender (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972167#comment-15972167
 ] 

Dan Bravender commented on THRIFT-4018:
---

bq. Based on the title of this ticket, wouldn't it be better to prevent the 
ruby server from being able to corrupt the stream on the sending side?

I believe the line of code I added in write_result is happening on the server 
(but I could be wrong): 
https://github.com/apache/thrift/pull/1179/files#diff-3f78a103bfde10cf9dd3d6e77afa2516R53

> Ruby server can corrupt connections by putting ApplicationException in the 
> middle of a response
> ---
>
> Key: THRIFT-4018
> URL: https://issues.apache.org/jira/browse/THRIFT-4018
> Project: Thrift
>  Issue Type: Bug
>  Components: Ruby - Library
>Affects Versions: 0.9.3
>Reporter: Dan Bravender
>
> # Have a client make a call to a thrift server method that returns an invalid 
> value for an enum
> # Have the client make another call to the same method that returns an 
> invalid value for an enum
> *Expected*: Thrift server responds with an ApplicationException for both calls
> *Actual*: The thrift server responds with ApplicationException for the first 
> call but then further calls can't be parsed by the client because there is 
> unexpected data that the client cannot parse 
> I discovered this while writing a test case for THRIFT-3781 though it is the 
> opposite problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (THRIFT-4175) ts and with_ns options added to js generator with no help text

2017-04-17 Thread Randy Abernethy (JIRA)
Randy Abernethy created THRIFT-4175:
---

 Summary: ts and with_ns options added to js generator with no help 
text
 Key: THRIFT-4175
 URL: https://issues.apache.org/jira/browse/THRIFT-4175
 Project: Thrift
  Issue Type: Improvement
  Components: JavaScript - Compiler
Affects Versions: 0.10.0
Reporter: Randy Abernethy
Priority: Minor


thrift -help says nothing about js:ts or js:with_ns



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] thrift pull request #1247: MSYS-appveyor-install.bat: use mingw-w64-xxx vari...

2017-04-17 Thread emmenlau
Github user emmenlau commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1247#discussion_r111824596
  
--- Diff: build/appveyor/MSYS-appveyor-install.bat ---
@@ -28,11 +28,11 @@ CALL cl_showenv.bat|| EXIT /B
 SET PACKAGES=^
   --needed -S bison flex ^
   make ^
-  openssl openssl-devel ^
+  mingw-w64-openssl ^
   mingw-w64-x86_64-boost ^
   mingw-w64-x86_64-cmake ^
   mingw-w64-x86_64-toolchain ^
-  zlib zlib-devel
+  mingw-w64-zlib
--- End diff --

Thanks for noticing the missing architecture! Fixed in latest PR.
The `mingw-w64` variants of packages do not use dev / devel package.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] thrift pull request #1247: MSYS-appveyor-install.bat: use mingw-w64-xxx vari...

2017-04-17 Thread emmenlau
Github user emmenlau commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1247#discussion_r111824603
  
--- Diff: build/appveyor/MSYS-appveyor-install.bat ---
@@ -28,11 +28,11 @@ CALL cl_showenv.bat|| EXIT /B
 SET PACKAGES=^
   --needed -S bison flex ^
   make ^
-  openssl openssl-devel ^
+  mingw-w64-openssl ^
--- End diff --

Thanks for noticing the missing architecture! Fixed in latest PR.
The `mingw-w64` variants of packages do not use dev / devel package.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (THRIFT-3357) Generate EnumSet/EnumMap where elements/keys are enums

2017-04-17 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971642#comment-15971642
 ] 

ASF GitHub Bot commented on THRIFT-3357:


Github user afds commented on the issue:

https://github.com/apache/thrift/pull/627
  
Created a new pull request here: https://github.com/apache/thrift/pull/1253


> Generate EnumSet/EnumMap where elements/keys are enums
> --
>
> Key: THRIFT-3357
> URL: https://issues.apache.org/jira/browse/THRIFT-3357
> Project: Thrift
>  Issue Type: Improvement
>  Components: Java - Compiler
>Reporter: Deniss Afonin
>
> Generate EnumSet/EnumMap instead of HashSet/HashMap where elements/keys are 
> enums.
> This makes these maps/sets memory efficient and faster.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (THRIFT-3357) Generate EnumSet/EnumMap where elements/keys are enums

2017-04-17 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971641#comment-15971641
 ] 

ASF GitHub Bot commented on THRIFT-3357:


GitHub user afds opened a pull request:

https://github.com/apache/thrift/pull/1253

THRIFT-3357: Generate EnumSet/EnumMap where elements/keys are enums



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/afds/thrift THRIFT-3357

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1253.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1253


commit 55c5b73be8a340c9793ba07595fef17adc9874e1
Author: Deniss Afonin 
Date:   2017-04-17T20:53:16Z

THRIFT-3357: Generate EnumSet/EnumMap where elements/keys are enums




> Generate EnumSet/EnumMap where elements/keys are enums
> --
>
> Key: THRIFT-3357
> URL: https://issues.apache.org/jira/browse/THRIFT-3357
> Project: Thrift
>  Issue Type: Improvement
>  Components: Java - Compiler
>Reporter: Deniss Afonin
>
> Generate EnumSet/EnumMap instead of HashSet/HashMap where elements/keys are 
> enums.
> This makes these maps/sets memory efficient and faster.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] thrift pull request #1253: THRIFT-3357: Generate EnumSet/EnumMap where eleme...

2017-04-17 Thread afds
GitHub user afds opened a pull request:

https://github.com/apache/thrift/pull/1253

THRIFT-3357: Generate EnumSet/EnumMap where elements/keys are enums



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/afds/thrift THRIFT-3357

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1253.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1253


commit 55c5b73be8a340c9793ba07595fef17adc9874e1
Author: Deniss Afonin 
Date:   2017-04-17T20:53:16Z

THRIFT-3357: Generate EnumSet/EnumMap where elements/keys are enums




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (THRIFT-3357) Generate EnumSet/EnumMap where elements/keys are enums

2017-04-17 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/THRIFT-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971611#comment-15971611
 ] 

ASF GitHub Bot commented on THRIFT-3357:


Github user afds closed the pull request at:

https://github.com/apache/thrift/pull/627


> Generate EnumSet/EnumMap where elements/keys are enums
> --
>
> Key: THRIFT-3357
> URL: https://issues.apache.org/jira/browse/THRIFT-3357
> Project: Thrift
>  Issue Type: Improvement
>  Components: Java - Compiler
>Reporter: Deniss Afonin
>
> Generate EnumSet/EnumMap instead of HashSet/HashMap where elements/keys are 
> enums.
> This makes these maps/sets memory efficient and faster.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] thrift pull request #627: THRIFT-3357: enum_containers option to generate En...

2017-04-17 Thread afds
Github user afds closed the pull request at:

https://github.com/apache/thrift/pull/627


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Updated] (THRIFT-3357) Generate EnumSet/EnumMap where elements/keys are enums

2017-04-17 Thread Deniss Afonin (JIRA)

 [ 
https://issues.apache.org/jira/browse/THRIFT-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deniss Afonin updated THRIFT-3357:
--
Description: 
Generate EnumSet/EnumMap instead of HashSet/HashMap where elements/keys are 
enums.

This makes these maps/sets memory efficient and faster.

  was:
Additional java compiler option to generate EnumSet/EnumMap instead of 
HashSet/HashMap where elements/keys are enums.

This makes these maps/sets memory efficient and faster.

Summary: Generate EnumSet/EnumMap where elements/keys are enums  (was: 
Additional java compiler option to generate EnumSet/EnumMap where elements/keys 
are enums)

> Generate EnumSet/EnumMap where elements/keys are enums
> --
>
> Key: THRIFT-3357
> URL: https://issues.apache.org/jira/browse/THRIFT-3357
> Project: Thrift
>  Issue Type: Improvement
>  Components: Java - Compiler
>Reporter: Deniss Afonin
>
> Generate EnumSet/EnumMap instead of HashSet/HashMap where elements/keys are 
> enums.
> This makes these maps/sets memory efficient and faster.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[REPORT] Apache Thrift - April 2017

2017-04-17 Thread Jake Farrell
 Apache Thrift is a framework for providing cross-platform RPC and
serialization.

Project Status
-
The Apache Thrift community is happy to announce that we have expanded our
client library offering to 25 languages now with the new addition of Rust.
We
are addressing some performance regressions that occurred in some of our
client
libraries in the Apache Thrift 0.10.0 release and are planning on a 0.11-rc0 to
be
packaged and ready for vote before the end of April.

Community
---
Latest Additions:

* PMC addition:Nobuaki Sukegawa, 1.25.2016
* Committer addition:   James King, 10.18.2016

Issue backlog status since last report:

* Created:143
* Resolved:  142

Mailing list activity since last report:

* @dev2467 messages
* @user   28 messages

Releases
---
Last release: 0.10.0, Release Date: 1.3.2017


[GitHub] thrift pull request #1187: Review for pull up of RUST extended namespace sup...

2017-04-17 Thread jfarrell
Github user jfarrell closed the pull request at:

https://github.com/apache/thrift/pull/1187


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---