[jira] [Commented] (THRIFT-4212) c_glib flush tries to close SSL even if socket is invalid

2017-05-25 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024950#comment-16024950
 ] 

ASF GitHub Bot commented on THRIFT-4212:


GitHub user gadLinux opened a pull request:

https://github.com/apache/thrift/pull/1279

THRIFT-4212: Fix flush on ssl socket thrift

Fixes the bug in flush on ssl thrift communications transport

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gadLinux/thrift THRIFT-4212

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1279.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1279


commit 94968a7db10d4b95bec62d33bed66868eebfbc38
Author: Gonzalo Aguilar Delgado 
Date:   2017-05-23T15:22:44Z

THRIFT-4205: Make sure gobject+glib are correctly linked

commit fb518bebec7666953fc69a540db9a56973b9bab5
Author: Gonzalo Aguilar Delgado 
Date:   2017-05-23T15:24:54Z

Fix lib for glib

commit a813c237fad8997ef96806259b999c5431759caa
Author: Gonzalo Aguilar Delgado 
Date:   2017-05-25T15:11:38Z

Fix logging in thrift library in #THRIFT-4211

commit 9250da1fe208927a09539d335ecf01d07e63d082
Author: Gonzalo Aguilar Delgado 
Date:   2017-05-25T15:17:37Z

Merge branch 'THRIFT-4211' into RELEASE-1.0.0

commit 84d328d93cab5e51587d892c3ecf641130531c3b
Author: Gonzalo Aguilar Delgado 
Date:   2017-05-25T16:15:30Z

Fix flush on invalid socket




> c_glib flush tries to close SSL even if socket is invalid
> -
>
> Key: THRIFT-4212
> URL: https://issues.apache.org/jira/browse/THRIFT-4212
> Project: Thrift
>  Issue Type: Bug
>  Components: C glib - Library
>Affects Versions: 1.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
> Fix For: 1.0
>
>
> It seems that SSL is trying to get info from socket even when socket is 
> already invalid, making the app to crash.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift pull request #1279: THRIFT-4212: Fix flush on ssl socket thrift

2017-05-25 Thread gadLinux 
GitHub user gadLinux opened a pull request:

https://github.com/apache/thrift/pull/1279

THRIFT-4212: Fix flush on ssl socket thrift

Fixes the bug in flush on ssl thrift communications transport

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gadLinux/thrift THRIFT-4212

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1279.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1279


commit 94968a7db10d4b95bec62d33bed66868eebfbc38
Author: Gonzalo Aguilar Delgado 
Date:   2017-05-23T15:22:44Z

THRIFT-4205: Make sure gobject+glib are correctly linked

commit fb518bebec7666953fc69a540db9a56973b9bab5
Author: Gonzalo Aguilar Delgado 
Date:   2017-05-23T15:24:54Z

Fix lib for glib

commit a813c237fad8997ef96806259b999c5431759caa
Author: Gonzalo Aguilar Delgado 
Date:   2017-05-25T15:11:38Z

Fix logging in thrift library in #THRIFT-4211

commit 9250da1fe208927a09539d335ecf01d07e63d082
Author: Gonzalo Aguilar Delgado 
Date:   2017-05-25T15:17:37Z

Merge branch 'THRIFT-4211' into RELEASE-1.0.0

commit 84d328d93cab5e51587d892c3ecf641130531c3b
Author: Gonzalo Aguilar Delgado 
Date:   2017-05-25T16:15:30Z

Fix flush on invalid socket




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (THRIFT-4212) c_glib flush tries to close SSL even if socket is invalid

2017-05-25 Thread Gonzalo Aguilar (JIRA) 
Gonzalo Aguilar created THRIFT-4212:
---

 Summary: c_glib flush tries to close SSL even if socket is invalid
 Key: THRIFT-4212
 URL: https://issues.apache.org/jira/browse/THRIFT-4212
 Project: Thrift
  Issue Type: Bug
  Components: C glib - Library
Affects Versions: 1.0
Reporter: Gonzalo Aguilar
Assignee: Gonzalo Aguilar
 Fix For: 1.0


It seems that SSL is trying to get info from socket even when socket is already 
invalid, making the app to crash.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-4211) Fix GError glib management under Thrift

2017-05-25 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024848#comment-16024848
 ] 

ASF GitHub Bot commented on THRIFT-4211:


GitHub user gadLinux opened a pull request:

https://github.com/apache/thrift/pull/1278

THRIFT-4211: Fix logging in thrift library

It seems we were aborting on error. 

We are now doing properly management. Error is ok and working perfectly.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gadLinux/thrift THRIFT-4211

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1278.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1278


commit a813c237fad8997ef96806259b999c5431759caa
Author: Gonzalo Aguilar Delgado 
Date:   2017-05-25T15:11:38Z

Fix logging in thrift library in #THRIFT-4211




> Fix GError glib management under Thrift
> ---
>
> Key: THRIFT-4211
> URL: https://issues.apache.org/jira/browse/THRIFT-4211
> Project: Thrift
>  Issue Type: Bug
>  Components: C glib - Library
>Affects Versions: 1.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
> Fix For: 1.0
>
>
> It seems that current Gerror management done in thrift is not quite ok and 
> causes the library to fail. 
> This issue tracks and fixes all problems found during testing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift pull request #1278: THRIFT-4211: Fix logging in thrift library

2017-05-25 Thread gadLinux 
GitHub user gadLinux opened a pull request:

https://github.com/apache/thrift/pull/1278

THRIFT-4211: Fix logging in thrift library

It seems we were aborting on error. 

We are now doing properly management. Error is ok and working perfectly.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gadLinux/thrift THRIFT-4211

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1278.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1278


commit a813c237fad8997ef96806259b999c5431759caa
Author: Gonzalo Aguilar Delgado 
Date:   2017-05-25T15:11:38Z

Fix logging in thrift library in #THRIFT-4211




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-4211) Fix GError glib management under Thrift

2017-05-25 Thread Gonzalo Aguilar (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024847#comment-16024847
 ] 

Gonzalo Aguilar commented on THRIFT-4211:
-

It seems we were aborting due to wrong understanding of how g_error works. 

There's room for improvement but for now it seems correct

> Fix GError glib management under Thrift
> ---
>
> Key: THRIFT-4211
> URL: https://issues.apache.org/jira/browse/THRIFT-4211
> Project: Thrift
>  Issue Type: Bug
>  Components: C glib - Library
>Affects Versions: 1.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
> Fix For: 1.0
>
>
> It seems that current Gerror management done in thrift is not quite ok and 
> causes the library to fail. 
> This issue tracks and fixes all problems found during testing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (THRIFT-4211) Fix GError glib management under Thrift

2017-05-25 Thread Gonzalo Aguilar (JIRA) 
Gonzalo Aguilar created THRIFT-4211:
---

 Summary: Fix GError glib management under Thrift
 Key: THRIFT-4211
 URL: https://issues.apache.org/jira/browse/THRIFT-4211
 Project: Thrift
  Issue Type: Bug
  Components: C glib - Library
Affects Versions: 1.0
Reporter: Gonzalo Aguilar
Assignee: Gonzalo Aguilar
 Fix For: 1.0


It seems that current Gerror management done in thrift is not quite ok and 
causes the library to fail. 

This issue tracks and fixes all problems found during testing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (THRIFT-4205) c_glib is not linking against glib + gobject

2017-05-25 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024714#comment-16024714
 ] 

ASF GitHub Bot commented on THRIFT-4205:


Github user gadLinux commented on the issue:

https://github.com/apache/thrift/pull/1272
  
Good. Wait for a fix. And I will open a new issue, since we detected that 
thrift crashes when certificate verification not ok.


> c_glib is not linking against glib + gobject
> 
>
> Key: THRIFT-4205
> URL: https://issues.apache.org/jira/browse/THRIFT-4205
> Project: Thrift
>  Issue Type: Improvement
>  Components: C glib - Library
>Affects Versions: 1.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
>Priority: Critical
>  Labels: build
> Fix For: 1.0
>
>
> The library is not linking against glib and gobject depedencies. It means 
> that it will work if the library is linked against a program that uses that 
> libraries but it will fail in environments like Android. 
> Since the reference to gobject (for example) will not be there and in 
> System.Loadlibrary('libthrift_c_glib') it will fail to load because missing 
> symbols.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] thrift issue #1272: THRIFT-4205: Set flags for glib+gobject on compilation

2017-05-25 Thread gadLinux 
Github user gadLinux commented on the issue:

https://github.com/apache/thrift/pull/1272
  
Good. Wait for a fix. And I will open a new issue, since we detected that 
thrift crashes when certificate verification not ok.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (THRIFT-4205) c_glib is not linking against glib + gobject

2017-05-25 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/THRIFT-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024670#comment-16024670
 ] 

ASF GitHub Bot commented on THRIFT-4205:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1272
  
@gadLinux looks like https://issues.apache.org/jira/browse/THRIFT-4202


> c_glib is not linking against glib + gobject
> 
>
> Key: THRIFT-4205
> URL: https://issues.apache.org/jira/browse/THRIFT-4205
> Project: Thrift
>  Issue Type: Improvement
>  Components: C glib - Library
>Affects Versions: 1.0
>Reporter: Gonzalo Aguilar
>Assignee: Gonzalo Aguilar
>Priority: Critical
>  Labels: build
> Fix For: 1.0
>
>
> The library is not linking against glib and gobject depedencies. It means 
> that it will work if the library is linked against a program that uses that 
> libraries but it will fail in environments like Android. 
> Since the reference to gobject (for example) will not be there and in 
> System.Loadlibrary('libthrift_c_glib') it will fail to load because missing 
> symbols.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Travis failing (again)

2017-05-25 Thread Jens Geyer 
Hi,

I tried to wrap my head around it but to no avail.

Step 24 : RUN curl -sSL https://www.npmjs.com/install.sh | sh
---> Running in 0edf1ca023e7
tar=/bin/tar
version:
tar (GNU tar) 1.27.1
Copyright (C) 2013 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later 
.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by John Gilmore and Jay Fenlason.
install npm@latest
fetching: https://registry.npmjs.org/npm/-/npm-4.6.1.tgz
npm ERR! Object function (err) {
npm ERR! if (err) return cb(err)
npm ERR! fs.fsync(fd, function (err) {
npm ERR!   if (err) return cb(err)
npm ERR!   fs.close(fd, cb)
npm ERR! })
npm ERR!   } has no method 'toLowerCase'
It failed
The command '/bin/sh -c curl -sSL https://www.npmjs.com/install.sh | sh' 
returned a non-zero code: 1
/home/travis/.travis/job_stages: line 155:  1053 Terminated 
travis_jigger $! $timeout $cmd


To me it looks like an issue with the npmjs install script, possibly related 
to the following commit, but I'm not sure enough to file an issue:

https://github.com/npm/npm/commit/afa7c0364ee5c819f4095f478580e6c2f55348ab#diff-36018a6a9e1de1798516799b84841318

Thoughs anyone?

Have fun,
JensG

[GitHub] thrift issue #1272: THRIFT-4205: Set flags for glib+gobject on compilation

2017-05-25 Thread jeking3 
Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1272
  
@gadLinux looks like https://issues.apache.org/jira/browse/THRIFT-4202


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---