[jira] [Commented] (THRIFT-3055) Apache Thrift Logo
[ https://issues.apache.org/jira/browse/THRIFT-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745602#comment-16745602 ] Randy Abernethy commented on THRIFT-3055: - Bummer. Still like the second one from the bottom of the previous list. > Apache Thrift Logo > -- > > Key: THRIFT-3055 > URL: https://issues.apache.org/jira/browse/THRIFT-3055 > Project: Thrift > Issue Type: Brainstorming > Components: Wish List >Reporter: Jake Farrell >Assignee: James E. King III >Priority: Major > Attachments: ApacheThriftLogoIdea.PNG, ApacheThriftLogoProposal.pptx, > ApacheThriftLogoWip3.pptx, ThriftLogo-UMLConnection.JPG, > ThriftLogoUmlIdeas.JPG, screenshot-1.png, screenshot-2.png > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-3055) Apache Thrift Logo
[ https://issues.apache.org/jira/browse/THRIFT-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745573#comment-16745573 ] James E. King III commented on THRIFT-3055: --- Sadly, due to the origination from logomaker, the puzzle logo is a dead end according to Apache Legal. Have to start over... > Apache Thrift Logo > -- > > Key: THRIFT-3055 > URL: https://issues.apache.org/jira/browse/THRIFT-3055 > Project: Thrift > Issue Type: Brainstorming > Components: Wish List >Reporter: Jake Farrell >Assignee: James E. King III >Priority: Major > Attachments: ApacheThriftLogoIdea.PNG, ApacheThriftLogoProposal.pptx, > ApacheThriftLogoWip3.pptx, ThriftLogo-UMLConnection.JPG, > ThriftLogoUmlIdeas.JPG, screenshot-1.png, screenshot-2.png > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-2790) thrift -gen all => an option to generate all languages and features
[ https://issues.apache.org/jira/browse/THRIFT-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745461#comment-16745461 ] James E. King III commented on THRIFT-2790: --- I would still like to see this option - although it would only allow for the "standard" language-specific options, but I see the use cases it would solve: 1. Will my thrift file work with future languages my project(s) start using? 2. Am I using any keywords that are invalid across any language? It sounds like given the difference between "js" and "nodejs" is a compiler flag, this won't actually generate all... so what do we want to do with it? > thrift -gen all => an option to generate all languages and features > --- > > Key: THRIFT-2790 > URL: https://issues.apache.org/jira/browse/THRIFT-2790 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General), Documentation, Test Suite >Reporter: Roger Meier >Priority: Major > Attachments: > 0001-THRIFT-2790-gen-all-option-to-easily-test-compatibil.patch, > generate-all-languages.bat > > > I would like to have a *thrift -gen all* option to generate everything we > have in one step. This would allow proper testing of all compiler changes by > using test/ThriftTest.thrift. An optional make check target could compare > different versions based on their git hash or to previous gen-all.backup > folder. > Suggested-by: Roger Meier -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (THRIFT-4401) document compiler plugin feature on the web site
[ https://issues.apache.org/jira/browse/THRIFT-4401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III closed THRIFT-4401. - Resolution: Won't Do Assignee: James E. King III > document compiler plugin feature on the web site > > > Key: THRIFT-4401 > URL: https://issues.apache.org/jira/browse/THRIFT-4401 > Project: Thrift > Issue Type: Documentation > Components: Compiler (General) >Reporter: Jens Geyer >Assignee: James E. King III >Priority: Major > Labels: documentation > > Could be worth to document this [**"How it > works"**|https://issues.apache.org/jira/browse/THRIFT-2835?focusedCommentId=15172058=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15172058] > stuff from THRIFT-2835 better on the web site, including any restrictions > etc that might apply.The only real doc we have for that feature is that > ticket. Nobody will find that, unless you know exactly what you are searching > for. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (THRIFT-4743) Remove the compiler plug-in mode
[ https://issues.apache.org/jira/browse/THRIFT-4743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III reassigned THRIFT-4743: - Assignee: James E. King III > Remove the compiler plug-in mode > > > Key: THRIFT-4743 > URL: https://issues.apache.org/jira/browse/THRIFT-4743 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General) >Affects Versions: 1.0 >Reporter: James E. King III >Assignee: James E. King III >Priority: Major > > Vote passed on the development mailing list to remove the dynamic compiler > plug-in mechanism. It has been disabled in the majority of all CI builds, > and the mode is already disabled by default in the build systems. This will > simplify the project and remove some compile-time and packaging-time branches. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (THRIFT-3991) compiler plugin relies on boost
[
https://issues.apache.org/jira/browse/THRIFT-3991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King III closed THRIFT-3991.
-
Resolution: Won't Do
Assignee: James E. King III (was: Aki Sukegawa)
> compiler plugin relies on boost
> ---
>
> Key: THRIFT-3991
> URL: https://issues.apache.org/jira/browse/THRIFT-3991
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
>Affects Versions: 0.10.0
>Reporter: Xiaoshuang LU
>Assignee: James E. King III
>Priority: Major
> Attachments: THRIFT-3991.patch
>
>
> {code}
> [root@localhost thrift]# make
> make all-recursive
> make[1]: Entering directory `/data/thrift'
> Making all in lib/cpp
> make[2]: Entering directory `/data/thrift/lib/cpp'
> Making all in .
> make[3]: Entering directory `/data/thrift/lib/cpp'
> make[3]: Nothing to be done for `all-am'.
> make[3]: Leaving directory `/data/thrift/lib/cpp'
> make[2]: Leaving directory `/data/thrift/lib/cpp'
> Making all in compiler/cpp
> make[2]: Entering directory `/data/thrift/compiler/cpp'
> Making all in src
> make[3]: Entering directory `/data/thrift/compiler/cpp/src'
> make all-am
> make[4]: Entering directory `/data/thrift/compiler/cpp/src'
> make[4]: Nothing to be done for `all-am'.
> make[4]: Leaving directory `/data/thrift/compiler/cpp/src'
> make[3]: Leaving directory `/data/thrift/compiler/cpp/src'
> Making all in src/thrift/plugin
> make[3]: Entering directory `/data/thrift/compiler/cpp/src/thrift/plugin'
> make all-am
> make[4]: Entering directory `/data/thrift/compiler/cpp/src/thrift/plugin'
> make[4]: Nothing to be done for `all-am'.
> make[4]: Leaving directory `/data/thrift/compiler/cpp/src/thrift/plugin'
> make[3]: Leaving directory `/data/thrift/compiler/cpp/src/thrift/plugin'
> Making all in .
> make[3]: Entering directory `/data/thrift/compiler/cpp'
> /bin/sh ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I.
> -I../.. -I../../lib/cpp/src/thrift -I../../lib/c_glib/src/thrift -I./src
> -Isrc -I../../lib/cpp/src -DTHRIFT_ENABLE_PLUGIN=1 -Wall -Wextra -pedantic
> -g -O2 -MT src/thrift/plugin/libthriftc_la-plugin.lo -MD -MP -MF
> src/thrift/plugin/.deps/libthriftc_la-plugin.Tpo -c -o
> src/thrift/plugin/libthriftc_la-plugin.lo `test -f
> 'src/thrift/plugin/plugin.cc' || echo './'`src/thrift/plugin/plugin.cc
> libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../.. -I../../lib/cpp/src/thrift
> -I../../lib/c_glib/src/thrift -I./src -Isrc -I../../lib/cpp/src
> -DTHRIFT_ENABLE_PLUGIN=1 -Wall -Wextra -pedantic -g -O2 -MT
> src/thrift/plugin/libthriftc_la-plugin.lo -MD -MP -MF
> src/thrift/plugin/.deps/libthriftc_la-plugin.Tpo -c
> src/thrift/plugin/plugin.cc -o src/thrift/plugin/libthriftc_la-plugin.o
> In file included from ./src/thrift/plugin/plugin.h:23:0,
> from src/thrift/plugin/plugin.cc:20:
> ../../lib/cpp/src/thrift/Thrift.h:45:39: fatal error:
> boost/utility/enable_if.hpp: No such file or directory
> #include
>^
> compilation terminated.
> make[3]: *** [src/thrift/plugin/libthriftc_la-plugin.lo] Error 1
> make[3]: Leaving directory `/data/thrift/compiler/cpp'
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory `/data/thrift/compiler/cpp'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/data/thrift'
> make: *** [all] Error 2
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (THRIFT-2295) Make "oneway" more generic
[
https://issues.apache.org/jira/browse/THRIFT-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King III closed THRIFT-2295.
-
Resolution: Auto Closed
Assignee: James E. King III
My assumption is that signal would be used for push notifications. Instead it
would be better to implement true endpoints on either side of the connection
that can function both as a server and as a client. If you'd like to continue
this work then reopen and submit as a pull request.
> Make "oneway" more generic
> --
>
> Key: THRIFT-2295
> URL: https://issues.apache.org/jira/browse/THRIFT-2295
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
>Affects Versions: 0.9.1
>Reporter: Martin Vogt
>Assignee: James E. King III
>Priority: Trivial
> Attachments: 040_functionModifiers140619v1.patch
>
>
> I'm experimenting with different function modifiers
> ("oneway","signal","slot", etc...)
> The current code does not make such tests easy, because the "oneway"
> modifier is hardcoded as bool.
> The following patch improves the optional function modifier to be more
> generic.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (THRIFT-1819) Thrift has many unused #includes
[ https://issues.apache.org/jira/browse/THRIFT-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III closed THRIFT-1819. - Resolution: Invalid Assignee: James E. King III (was: Ben Craig) Closing, as patch broke things and was never addressed. > Thrift has many unused #includes > > > Key: THRIFT-1819 > URL: https://issues.apache.org/jira/browse/THRIFT-1819 > Project: Thrift > Issue Type: Bug > Components: Compiler (General) >Reporter: Andrew Gaul >Assignee: James E. King III >Priority: Major > Attachments: thrift-1819-unused-includes.patch > > > Patch forthcoming. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4570) New TypeScript generator optimized for size
[ https://issues.apache.org/jira/browse/THRIFT-4570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745455#comment-16745455 ] James E. King III commented on THRIFT-4570: --- With a pull request if you can add cross test support, that'll go a long way to ensuring compatibility. > New TypeScript generator optimized for size > --- > > Key: THRIFT-4570 > URL: https://issues.apache.org/jira/browse/THRIFT-4570 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General), TypeScript - Library >Reporter: Antony Ducommun >Priority: Major > Attachments: SmallService.ts, SmallTest.thrift, SmallTest_types.ts, > thrift.ts > > > I propose to add a new compiler generating native typescript code with the > following goals: > * Using promise only (no direct callback) > * Reducing the generated code to the minimum > * Fully typed code to avoid misuse of generated code > * Initially geared toward web-browser usage and not nodejs > My understanding is that the usual generator flow is not ideal for javascript > because: > * The advantage of using a streaming parser is lost (cf. initial JSON.parse) > * It's not clear if we gain much by doing a streaming write vs. a > JSON.stringify > * The usual transports available (xhr, websocket) don't mix well with > streaming > * The 'speed first' focus is not the first concern I encountered using > thrift in a browser environment. I am usually more concerned by final code > bundle size than the speed at which the messages are serialized. > So I wrote a prototype which produces a quite different kind of code compared > to the js generator and the results are interesting. On a set of existing > thrift interfaces, here is the difference in size (fully compressed/minified > and including respective libraries): > * Using standard js generator: 484 Kb > * Using my prototype ts generator: 184 Kb > It's around a 1:2.5 ratio. Some files have up to a 1:5 ratio. > But there is no magic. There is of course a potential performance penalty > when moving more serialization/deserialization code in a shared library, > which should be fully evaluated. Also the code needs to be tested and further > improved. It's still rough at this stage. > Here attached is the output generated for the SmallTest example found in the > thrift tests folder. > I'll open a pull request if there is interest in this direction. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4570) New TypeScript generator optimized for size
[ https://issues.apache.org/jira/browse/THRIFT-4570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745453#comment-16745453 ] James E. King III commented on THRIFT-4570: --- I don't use JavaScript much, so I'm probably not qualified to weigh in on this. Observation is we have js, nodejs, ts, nodets. Things seem to be diverging, not converging, in this space. You may want to raise attention on the mailing list and see if anyone else has comments they could add here. > New TypeScript generator optimized for size > --- > > Key: THRIFT-4570 > URL: https://issues.apache.org/jira/browse/THRIFT-4570 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General), TypeScript - Library >Reporter: Antony Ducommun >Priority: Major > Attachments: SmallService.ts, SmallTest.thrift, SmallTest_types.ts, > thrift.ts > > > I propose to add a new compiler generating native typescript code with the > following goals: > * Using promise only (no direct callback) > * Reducing the generated code to the minimum > * Fully typed code to avoid misuse of generated code > * Initially geared toward web-browser usage and not nodejs > My understanding is that the usual generator flow is not ideal for javascript > because: > * The advantage of using a streaming parser is lost (cf. initial JSON.parse) > * It's not clear if we gain much by doing a streaming write vs. a > JSON.stringify > * The usual transports available (xhr, websocket) don't mix well with > streaming > * The 'speed first' focus is not the first concern I encountered using > thrift in a browser environment. I am usually more concerned by final code > bundle size than the speed at which the messages are serialized. > So I wrote a prototype which produces a quite different kind of code compared > to the js generator and the results are interesting. On a set of existing > thrift interfaces, here is the difference in size (fully compressed/minified > and including respective libraries): > * Using standard js generator: 484 Kb > * Using my prototype ts generator: 184 Kb > It's around a 1:2.5 ratio. Some files have up to a 1:5 ratio. > But there is no magic. There is of course a potential performance penalty > when moving more serialization/deserialization code in a shared library, > which should be fully evaluated. Also the code needs to be tested and further > improved. It's still rough at this stage. > Here attached is the output generated for the SmallTest example found in the > thrift tests folder. > I'll open a pull request if there is interest in this direction. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (THRIFT-3945) thrift-maven-plugin needs docs
[ https://issues.apache.org/jira/browse/THRIFT-3945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III updated THRIFT-3945: -- Component/s: (was: Compiler (General)) Contributed > thrift-maven-plugin needs docs > -- > > Key: THRIFT-3945 > URL: https://issues.apache.org/jira/browse/THRIFT-3945 > Project: Thrift > Issue Type: Documentation > Components: Contributed >Reporter: Christopher Tubbs >Priority: Major > > The thrift-maven-plugin contrib module needs documentation. The project > should generate and publish maven-site-plugin style plugin documentation, so > users can learn how to properly use the plugin's goals and configuration > options. > (Also, a JIRA component should be created for the thrift-maven-plugin, so > that issues related to the plugin can be quickly found by component in JIRA. > I also recommend moving it to its own git repository, to make it easier to > improve the plugin between THRIFT releases.) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (THRIFT-4341) No WARNING or ERROR when included .thrift file is not found while running thrift-maven-plugin
[
https://issues.apache.org/jira/browse/THRIFT-4341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King III updated THRIFT-4341:
--
Component/s: Contributed
> No WARNING or ERROR when included .thrift file is not found while running
> thrift-maven-plugin
> -
>
> Key: THRIFT-4341
> URL: https://issues.apache.org/jira/browse/THRIFT-4341
> Project: Thrift
> Issue Type: Bug
> Components: Contributed
> Environment: Ubuntu 16.04.2 LTS
>Reporter: Merter Sualp
>Priority: Minor
> Labels: contrib
> Attachments: no_thrift_js_reported.jpg
>
>
> While using thrift-maven-plugin, we define our Javascript execution as below:
> {code:xml}
>
> thrift-js-sources
> generate-sources
>
> compile
>
>
> js:node
>
> included_file.thrift
>
> ${a.directory}
>
>
> {code}
> However, if the compiler cannot find the included_file.thrift, it gives only
> an INFO and moves on without a warning or an error. The partial output is:
> !no_thrift_js_reported.jpg!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (THRIFT-803) Twisted servers close the connection with no error response when an unhandled error occurs
[ https://issues.apache.org/jira/browse/THRIFT-803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III closed THRIFT-803. Resolution: Auto Closed Assignee: James E. King III Issue is quite old and may no longer be valid. Reopen it if you find it is broken in 0.12.0. > Twisted servers close the connection with no error response when an unhandled > error occurs > -- > > Key: THRIFT-803 > URL: https://issues.apache.org/jira/browse/THRIFT-803 > Project: Thrift > Issue Type: Bug > Components: Python - Library >Affects Versions: 0.2 > Environment: Debian, Ubuntu >Reporter: Christopher Armstrong >Assignee: James E. King III >Priority: Major > > When an unhandled error occurs in a service handler, the connection is closed > but no message is sent to the client to indicate that an error occurred. > Mattias de Zalenski first mentioned this issue in a comment: > https://issues.apache.org/jira/browse/THRIFT-585?focusedCommentId=12757052=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12757052 > And he attached a fix for it, though in an undesirable format (changing the > compiler instead of the library, and as an entire .cc file instead of a > patch): > https://issues.apache.org/jira/secure/attachment/12419992/t_py_generator.cc > IMO, in addition to sending back an error message to the client, unhandled > errors should also be logged with log.err(). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (THRIFT-3419) thrift-maven-plugin property error
[
https://issues.apache.org/jira/browse/THRIFT-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King III closed THRIFT-3419.
-
Resolution: Fixed
> thrift-maven-plugin property error
> --
>
> Key: THRIFT-3419
> URL: https://issues.apache.org/jira/browse/THRIFT-3419
> Project: Thrift
> Issue Type: Bug
> Components: Contributed
>Affects Versions: 0.9.3, 0.10.0, 1.0
>Reporter: chillon.m
>Assignee: chillon.m
>Priority: Major
> Labels: patch
> Fix For: 0.10.0
>
> Attachments: temporaryThriftFileDirectory.patch, thrift-error.png
>
>
> execute 'mvn compile' occure an error:
> The parameters '${project.build.directory}/thrift-dependencies' for goal
> org.apache.thrift:thrift-maven-plugin:0.9.3:compile are missing or invalid
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Reopened] (THRIFT-3419) thrift-maven-plugin property error
[
https://issues.apache.org/jira/browse/THRIFT-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King III reopened THRIFT-3419:
---
> thrift-maven-plugin property error
> --
>
> Key: THRIFT-3419
> URL: https://issues.apache.org/jira/browse/THRIFT-3419
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
>Affects Versions: 0.9.3, 0.10.0, 1.0
>Reporter: chillon.m
>Assignee: chillon.m
>Priority: Major
> Labels: patch
> Attachments: temporaryThriftFileDirectory.patch, thrift-error.png
>
>
> execute 'mvn compile' occure an error:
> The parameters '${project.build.directory}/thrift-dependencies' for goal
> org.apache.thrift:thrift-maven-plugin:0.9.3:compile are missing or invalid
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (THRIFT-3419) thrift-maven-plugin property error
[
https://issues.apache.org/jira/browse/THRIFT-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King III updated THRIFT-3419:
--
Component/s: (was: Java - Library)
Contributed
> thrift-maven-plugin property error
> --
>
> Key: THRIFT-3419
> URL: https://issues.apache.org/jira/browse/THRIFT-3419
> Project: Thrift
> Issue Type: Bug
> Components: Contributed
>Affects Versions: 0.9.3, 0.10.0, 1.0
>Reporter: chillon.m
>Assignee: chillon.m
>Priority: Major
> Labels: patch
> Fix For: 0.10.0
>
> Attachments: temporaryThriftFileDirectory.patch, thrift-error.png
>
>
> execute 'mvn compile' occure an error:
> The parameters '${project.build.directory}/thrift-dependencies' for goal
> org.apache.thrift:thrift-maven-plugin:0.9.3:compile are missing or invalid
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (THRIFT-3419) thrift-maven-plugin property error
[
https://issues.apache.org/jira/browse/THRIFT-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King III updated THRIFT-3419:
--
Fix Version/s: 0.10.0
> thrift-maven-plugin property error
> --
>
> Key: THRIFT-3419
> URL: https://issues.apache.org/jira/browse/THRIFT-3419
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
>Affects Versions: 0.9.3, 0.10.0, 1.0
>Reporter: chillon.m
>Assignee: chillon.m
>Priority: Major
> Labels: patch
> Fix For: 0.10.0
>
> Attachments: temporaryThriftFileDirectory.patch, thrift-error.png
>
>
> execute 'mvn compile' occure an error:
> The parameters '${project.build.directory}/thrift-dependencies' for goal
> org.apache.thrift:thrift-maven-plugin:0.9.3:compile are missing or invalid
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (THRIFT-4229) Make thrift-maven-plugin threadSafe
[
https://issues.apache.org/jira/browse/THRIFT-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King III updated THRIFT-4229:
--
Component/s: (was: Build Process)
Contributed
> Make thrift-maven-plugin threadSafe
> ---
>
> Key: THRIFT-4229
> URL: https://issues.apache.org/jira/browse/THRIFT-4229
> Project: Thrift
> Issue Type: Bug
> Components: Contributed
>Affects Versions: 0.9.3, 0.10.0
> Environment: Maven 3.5
> org.apache.thrift:thrift-maven-plugin:0.9.3
> org.apache.thrift
> thrift-maven-plugin
> 0.9.3
>Reporter: Ahmet Bolac
>Priority: Major
> Labels: contrib
> Attachments: screenshot-1.png
>
>
> We are seeing a warning in our build using Maven 3.5 as following:
> {noformat}
> [WARNING] *
> [WARNING] * Your build is requesting parallel execution, but project *
> [WARNING] * contains the following plugin(s) that have goals not marked *
> [WARNING] * as @threadSafe to support parallel building. *
> [WARNING] * While this /may/ work fine, please look for plugin updates*
> [WARNING] * and/or request plugins be made thread-safe. *
> [WARNING] * If reporting an issue, report it against the plugin in*
> [WARNING] * question, not against maven-core *
> [WARNING] *
> [WARNING] The following plugins are not marked @threadSafe in drive-thrift:
> [WARNING] org.apache.thrift.tools:maven-thrift-plugin:0.1.11
> [WARNING] Enable debug to see more precisely which goals are not marked
> @threadSafe.
> [WARNING] *
> {noformat}
> which indicates the plugin is not thread-safe.
> Is it possible to address this in the next version so it is thread-safe (and
> marked as such) and does not trigger this warning anymore?
> Thanks
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (THRIFT-3945) thrift-maven-plugin needs docs
[ https://issues.apache.org/jira/browse/THRIFT-3945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III updated THRIFT-3945: -- Labels: contrib (was: ) > thrift-maven-plugin needs docs > -- > > Key: THRIFT-3945 > URL: https://issues.apache.org/jira/browse/THRIFT-3945 > Project: Thrift > Issue Type: Documentation > Components: Contributed >Reporter: Christopher Tubbs >Priority: Major > Labels: contrib > > The thrift-maven-plugin contrib module needs documentation. The project > should generate and publish maven-site-plugin style plugin documentation, so > users can learn how to properly use the plugin's goals and configuration > options. > (Also, a JIRA component should be created for the thrift-maven-plugin, so > that issues related to the plugin can be quickly found by component in JIRA. > I also recommend moving it to its own git repository, to make it easier to > improve the plugin between THRIFT releases.) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (THRIFT-4229) Make thrift-maven-plugin threadSafe
[
https://issues.apache.org/jira/browse/THRIFT-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745435#comment-16745435
]
James E. King III commented on THRIFT-4229:
---
The thrift-maven-plugin is a contributed component and not actively maintained
by the thrift project. If you have a pull request that fixes this, please
consider contributing it.
> Make thrift-maven-plugin threadSafe
> ---
>
> Key: THRIFT-4229
> URL: https://issues.apache.org/jira/browse/THRIFT-4229
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
>Affects Versions: 0.9.3, 0.10.0
> Environment: Maven 3.5
> org.apache.thrift:thrift-maven-plugin:0.9.3
> org.apache.thrift
> thrift-maven-plugin
> 0.9.3
>Reporter: Ahmet Bolac
>Priority: Major
> Labels: Third-party
> Attachments: screenshot-1.png
>
>
> We are seeing a warning in our build using Maven 3.5 as following:
> {noformat}
> [WARNING] *
> [WARNING] * Your build is requesting parallel execution, but project *
> [WARNING] * contains the following plugin(s) that have goals not marked *
> [WARNING] * as @threadSafe to support parallel building. *
> [WARNING] * While this /may/ work fine, please look for plugin updates*
> [WARNING] * and/or request plugins be made thread-safe. *
> [WARNING] * If reporting an issue, report it against the plugin in*
> [WARNING] * question, not against maven-core *
> [WARNING] *
> [WARNING] The following plugins are not marked @threadSafe in drive-thrift:
> [WARNING] org.apache.thrift.tools:maven-thrift-plugin:0.1.11
> [WARNING] Enable debug to see more precisely which goals are not marked
> @threadSafe.
> [WARNING] *
> {noformat}
> which indicates the plugin is not thread-safe.
> Is it possible to address this in the next version so it is thread-safe (and
> marked as such) and does not trigger this warning anymore?
> Thanks
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (THRIFT-4229) Make thrift-maven-plugin threadSafe
[
https://issues.apache.org/jira/browse/THRIFT-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King III updated THRIFT-4229:
--
Labels: contrib (was: Third-party)
> Make thrift-maven-plugin threadSafe
> ---
>
> Key: THRIFT-4229
> URL: https://issues.apache.org/jira/browse/THRIFT-4229
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
>Affects Versions: 0.9.3, 0.10.0
> Environment: Maven 3.5
> org.apache.thrift:thrift-maven-plugin:0.9.3
> org.apache.thrift
> thrift-maven-plugin
> 0.9.3
>Reporter: Ahmet Bolac
>Priority: Major
> Labels: contrib
> Attachments: screenshot-1.png
>
>
> We are seeing a warning in our build using Maven 3.5 as following:
> {noformat}
> [WARNING] *
> [WARNING] * Your build is requesting parallel execution, but project *
> [WARNING] * contains the following plugin(s) that have goals not marked *
> [WARNING] * as @threadSafe to support parallel building. *
> [WARNING] * While this /may/ work fine, please look for plugin updates*
> [WARNING] * and/or request plugins be made thread-safe. *
> [WARNING] * If reporting an issue, report it against the plugin in*
> [WARNING] * question, not against maven-core *
> [WARNING] *
> [WARNING] The following plugins are not marked @threadSafe in drive-thrift:
> [WARNING] org.apache.thrift.tools:maven-thrift-plugin:0.1.11
> [WARNING] Enable debug to see more precisely which goals are not marked
> @threadSafe.
> [WARNING] *
> {noformat}
> which indicates the plugin is not thread-safe.
> Is it possible to address this in the next version so it is thread-safe (and
> marked as such) and does not trigger this warning anymore?
> Thanks
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (THRIFT-3945) thrift-maven-plugin needs docs
[ https://issues.apache.org/jira/browse/THRIFT-3945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745434#comment-16745434 ] James E. King III commented on THRIFT-3945: --- The thrift-maven-plugin is a contributed component and not actively maintained by the thrift project. If you have a pull request that fixes this, please consider contributing it. > thrift-maven-plugin needs docs > -- > > Key: THRIFT-3945 > URL: https://issues.apache.org/jira/browse/THRIFT-3945 > Project: Thrift > Issue Type: Documentation > Components: Contributed >Reporter: Christopher Tubbs >Priority: Major > Labels: contrib > > The thrift-maven-plugin contrib module needs documentation. The project > should generate and publish maven-site-plugin style plugin documentation, so > users can learn how to properly use the plugin's goals and configuration > options. > (Also, a JIRA component should be created for the thrift-maven-plugin, so > that issues related to the plugin can be quickly found by component in JIRA. > I also recommend moving it to its own git repository, to make it easier to > improve the plugin between THRIFT releases.) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (THRIFT-3581) Pure Java build of the Thrift compiler using NestedVM [WIP]
[ https://issues.apache.org/jira/browse/THRIFT-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III closed THRIFT-3581. - Resolution: Auto Closed This has been open for a couple years without action. My guess is if we were going to redo the compiler today, we would use python. > Pure Java build of the Thrift compiler using NestedVM [WIP] > --- > > Key: THRIFT-3581 > URL: https://issues.apache.org/jira/browse/THRIFT-3581 > Project: Thrift > Issue Type: New Feature > Components: Compiler (General) >Reporter: Benjamin Gould >Assignee: Benjamin Gould >Priority: Minor > Attachments: thrift-compiler-0.9.4-SNAPSHOT-sources.jar, > thrift-compiler-0.9.4-SNAPSHOT.jar > > > I've developed a build process for building the Thrift compiler as a JAR file > that can be run on a JVM and requires no dependencies by cross-compiling the > executable with NestedVM. > I think this could be use for the following, among other things: > 1) Building Thrift plugins for IDEs written in Java > 2) Integration into Java build tools like Ant and Maven > 3) Calling the compiler from a Java program when the host platform is unknown > Also, I see this as providing a way to potentially allow people to create > third party "plugins" for the compiler... Java and the plethora of JVM > language available might make creating new generators much more approachable > for people not comfortable with C++... and also in Java it is not complicated > to load code dynamically based on a class name as long as it is on the > classpath. > In any case, I have a working prototype, but it is far from battle tested. > For the inpatient, I'm attaching a snapshot build to this ticket, but you can > also find the source and build instructions here: > https://github.com/bgould/thrift/tree/nestedvm/contrib/nestedvm > Will open a pull request when I feel all of the wrinkles have been ironed out > (it is close, and quite usuable already) to see if it might be appropriate to > bring this into the contrib/ folder, or even include as an artifact in the > Maven repos for a future release. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (THRIFT-4635) Please target VS2017 and v141 cpp toolchain
[ https://issues.apache.org/jira/browse/THRIFT-4635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III closed THRIFT-4635. - Resolution: Invalid Assignee: James E. King III This sounds like a cmake environmental error in your container and/or wherever you are running it. This is not an Apache Thrift issue as far as I can tell. I recently added a docker container build to the project in build/docker/msvc2017. > Please target VS2017 and v141 cpp toolchain > --- > > Key: THRIFT-4635 > URL: https://issues.apache.org/jira/browse/THRIFT-4635 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.11.0 >Reporter: Rodney Aaron Stainback >Assignee: James E. King III >Priority: Major > > I'm am trying to automate builds on docker and right now the project targets > v100 i.e. VS2010 cpp toolchain. This can not be changed via the command > line. Please upgrade the solution. Thanks. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (THRIFT-4163) The debian package / autoconf build environment is not setting NDEBUG on production builds, leaving assertions active
[
https://issues.apache.org/jira/browse/THRIFT-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King III reassigned THRIFT-4163:
-
Assignee: (was: James E. King III)
> The debian package / autoconf build environment is not setting NDEBUG on
> production builds, leaving assertions active
> -
>
> Key: THRIFT-4163
> URL: https://issues.apache.org/jira/browse/THRIFT-4163
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
>Affects Versions: 0.10.0
>Reporter: James E. King III
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In a project that uses thrift I was looking at a core and found an assertion
> inside thrift triggered it. This was rather strange being in a release build
> of thrift.
> To understand if assertions are active in release builds, I modified
> PlatformSocket.h and added this close to the top:
> {noformat}
> #ifdef NDEBUG
> #error "NDEBUG IS SET: ASSERTIONS ARE IGNORED"
> #else
> #error "NDEBUG IS NOT SET: ASSERTIONS ARE ACTIVE"
> #endif
> {noformat}
> Then I built the ubuntu dockerfile and started a debian package distribution
> build:
> {noformat}
> # docker build -t thrift build/docker/ubuntu
> # docker run -v $(pwd):/thrift/src -it thrift /bin/bash
> # dpkg-buildpackage -d -tc 2>&1 | grep NDEBUG
> ./src/thrift/transport/PlatformSocket.h:25:2: error: #error "NDEBUG IS NOT
> SET: ASSERTIONS ARE ACTIVE"
> #error "NDEBUG IS NOT SET: ASSERTIONS ARE ACTIVE"
> {noformat}
> Assertions should not be active in release builds.
> Assertions really shouldn't be used; exceptions are much better for C++.
> That's covered in THRIFT-3978 however. To fix this issue, the autoconf
> system needs to set NDEBUG for release builds.
> I checked the cmake build environment and it does not suffer from this issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (THRIFT-4743) Remove the compiler plug-in mode
James E. King III created THRIFT-4743: - Summary: Remove the compiler plug-in mode Key: THRIFT-4743 URL: https://issues.apache.org/jira/browse/THRIFT-4743 Project: Thrift Issue Type: Improvement Components: Compiler (General) Affects Versions: 1.0 Reporter: James E. King III Vote passed on the development mailing list to remove the dynamic compiler plug-in mechanism. It has been disabled in the majority of all CI builds, and the mode is already disabled by default in the build systems. This will simplify the project and remove some compile-time and packaging-time branches. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[VOTE] [RESULT] Remove compiler plug-in mode [PASSED]
On Sunday I called a vote on removing the compiler plug-in mode, which would result in simplifying the project. Results: [+1] 3 binding votes (Jens, Randy, myself) [0] none [-1] none The vote is successful, the plug-in compiler mode can be removed. - Jim
