Re: Next release
Hi, branch 0.19.0 cut, version number bumped to 0.20.0 master. Have fun, JensG Am 05.07.2023 um 10:15 schrieb Jens Geyer: Hi all, unless there are objections to it, I am going to create a release branch around saturday, and the release candidate a week later. Have fun, JensG
[jira] [Updated] (THRIFT-5725) Thrift SSL server stops working if the file descriptor returned is zero
[ https://issues.apache.org/jira/browse/THRIFT-5725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5725: --- Fix Version/s: 0.19.0 > Thrift SSL server stops working if the file descriptor returned is zero > --- > > Key: THRIFT-5725 > URL: https://issues.apache.org/jira/browse/THRIFT-5725 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.19.0 >Reporter: Prasenjit Sarkar >Assignee: Prasenjit Sarkar >Priority: Critical > Fix For: 0.19.0 > > Time Spent: 40m > Remaining Estimate: 0h > > When the Thrift OpenSSL server gets a file descriptor of 0 (which is valid), > the server stops working and cannot accept new connections because of the > following code in TSSLSocket.cpp: > > {code:java} > if (BIO_get_fd(bio, ) <= 0) > { throw TSSLException("BIO_get_fd failed"); } > {code} > > The fix would be to just change the comparison from <= to < -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (THRIFT-5725) Thrift SSL server stops working if the file descriptor returned is zero
[ https://issues.apache.org/jira/browse/THRIFT-5725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-5725: -- Assignee: Prasenjit Sarkar > Thrift SSL server stops working if the file descriptor returned is zero > --- > > Key: THRIFT-5725 > URL: https://issues.apache.org/jira/browse/THRIFT-5725 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.19.0 >Reporter: Prasenjit Sarkar >Assignee: Prasenjit Sarkar >Priority: Critical > Time Spent: 40m > Remaining Estimate: 0h > > When the Thrift OpenSSL server gets a file descriptor of 0 (which is valid), > the server stops working and cannot accept new connections because of the > following code in TSSLSocket.cpp: > > {code:java} > if (BIO_get_fd(bio, ) <= 0) > { throw TSSLException("BIO_get_fd failed"); } > {code} > > The fix would be to just change the comparison from <= to < -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [thrift] Jens-G closed pull request #2831: THRIFT-5725: Fix the comparison check for bio_get_fd
Jens-G closed pull request #2831: THRIFT-5725: Fix the comparison check for bio_get_fd URL: https://github.com/apache/thrift/pull/2831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org