[GitHub] thrift pull request #1530: THRIFT-4540 buffered transport broken when trying...

2018-04-02 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1530

THRIFT-4540 buffered transport broken when trying to re-open a former…

…ly closed transport

Client: Delphi
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4540

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1530.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1530


commit 4d55a6c9ead4ce07bcbcacfa447ab03a424f8aeb
Author: Jens Geyer <jensg@...>
Date:   2018-04-02T11:57:55Z

THRIFT-4540 buffered transport broken when trying to re-open a formerly 
closed transport
Client: Delphi
Patch: Jens Geyer




---

[GitHub] thrift pull request #1529: THRIFT-4539 Allow TBufferedTransport to be used a...

2018-04-02 Thread Jens-G 
Github user Jens-G closed the pull request at:

https://github.com/apache/thrift/pull/1529


---

[GitHub] thrift pull request #1529: THRIFT-4539 Allow TBufferedTransport to be used a...

2018-04-01 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1529

THRIFT-4539 Allow TBufferedTransport to be used as base class

Client: C#
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4539

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1529.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1529


commit 4ab2f4a8d578608903d325f3149fcbbcd7575726
Author: Jens Geyer <jensg@...>
Date:   2018-04-01T23:30:22Z

THRIFT-4539 Allow TBufferedTransport to be used as base class
Client: C#
Patch: Jens Geyer




---

[GitHub] thrift pull request #1528: Thrift 4538

2018-03-31 Thread Jens-G 
Github user Jens-G closed the pull request at:

https://github.com/apache/thrift/pull/1528


---

[GitHub] thrift pull request #1528: Thrift 4538

2018-03-31 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1528

Thrift 4538



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4538

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1528.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1528


commit d4fb364d30b0d01bbe8bdcab34f32ccfb539d564
Author: Jens Geyer <jensg@...>
Date:   2018-03-30T17:14:31Z

ignores modified

commit ed3a7a6aef253a6a996c2c58f18e9e14a3cecef3
Author: Jens Geyer <jensg@...>
Date:   2018-03-30T17:29:02Z

THRIFT-4538 TZLibTransport for C#
Client: C#
Patch: Jens Geyer




---

[GitHub] thrift issue #1524: THRIFT-4535: XML docs; code cleanup (tabs->spaces; Strin...

2018-03-31 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1524
  
Squash please.


---

[GitHub] thrift issue #1524: THRIFT-4535: XML docs; code cleanup (tabs->spaces; Strin...

2018-03-31 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1524
  
Disclaimer: I did not look at every line and I did not look into the 
AppVeyor failure. 

Aside from one minor thing everything that I skimmed through LTGM, and my 
code still compiles :-) so I'm basically fine with.


---

[GitHub] thrift pull request #1524: THRIFT-4535: XML docs; code cleanup (tabs->spaces...

2018-03-31 Thread Jens-G 
Github user Jens-G commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1524#discussion_r178426941
  
--- Diff: lib/csharp/src/Protocol/TCompactProtocol.cs ---
@@ -7,7 +7,7 @@
  * "License"); you may not use this file except in compliance
  * with the License. You may obtain a copy of the License at
  *
- *   http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
--- End diff --

Why are we doing that change?


---

[GitHub] thrift issue #1527: Merge pull request #1 from apache/master

2018-03-31 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1527
  
@jfarrell: could you close that?


---

[GitHub] thrift issue #1527: Merge pull request #1 from apache/master

2018-03-31 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1527
  
@zengqinglong: could you please stop opening meaningless PRs? Thank you.


---

[GitHub] thrift pull request #1492: THRIFT-4492 protected ExceptionType type member o...

2018-02-10 Thread Jens-G 
Github user Jens-G closed the pull request at:

https://github.com/apache/thrift/pull/1492


---

[GitHub] thrift pull request #1492: THRIFT-4492 protected ExceptionType type member o...

2018-02-10 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1492

THRIFT-4492 protected ExceptionType type member of TApplicationExcept…

…ion cannot be accessed

Client: C#
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4492

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1492.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1492


commit b6ff1a8e857f9fcb04f113e71c4f3cd475454aa7
Author: Jens Geyer <jensg@...>
Date:   2018-02-09T19:26:11Z

THRIFT-4492 protected ExceptionType type member of TApplicationException 
cannot be accessed
Client: C#
Patch: Jens Geyer




---

[GitHub] thrift pull request #1490: THRIFT-4454 Large writes/reads may cause range ch...

2018-02-01 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1490

THRIFT-4454 Large writes/reads may cause range check errors in debug …

…mode

Client: Delphi
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4454

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1490.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1490


commit df265ad7de0ee7f8faf89e32a3f05bbc75f5343b
Author: Jens Geyer <jensg@...>
Date:   2018-02-01T21:37:18Z

THRIFT-4454 Large writes/reads may cause range check errors in debug mode
Client: Delphi
Patch: Jens Geyer




---

[GitHub] thrift pull request #1489: THRIFT-4485 Possible invalid ptr AV with overlapp...

2018-02-01 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1489

THRIFT-4485 Possible invalid ptr AV with overlapped read/write on pipes

Client: Delphi
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4485

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1489.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1489


commit 10f90c16a0d9e6275b33086fc90bc2e6ae2d81cd
Author: Jens Geyer <jensg@...>
Date:   2018-02-01T22:38:10Z

THRIFT-4485 Possible invalid ptr AV with overlapped read/write on pipes
Client: Delphi
Patch: Jens Geyer




---

[GitHub] thrift issue #1474: Recognize fbthrift TApplicationException codes

2018-01-25 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1474
  
Not sure. 

We had that discussion in the past IIRC and the outcome was that we leave 
it as it is. It's somewhere buried in the archives, maybe we heven had (or 
still have) a ticket for it. Nevertheless, the idea has some clear advantages, 
I agreee with that.

One question that immediately came to my mind was: why don't we include the 
version number as well? That thing is a constant hassle with any release. 

@jfarrell ?


---

[GitHub] thrift pull request #1478: THRIFT-4473 Move Thrift.Console.pas out of the Li...

2018-01-24 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1478

THRIFT-4473 Move Thrift.Console.pas out of the Library

Client: Delphi
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4473

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1478.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1478


commit cf753348438bf800446e393a6d114408b314f438
Author: Jens Geyer <jensg@...>
Date:   2018-01-24T18:14:32Z

THRIFT-4473 Move Thrift.Console.pas out of the Library
Client: Delphi
Patch: Jens Geyer




---

[GitHub] thrift issue #1474: Recognize fbthrift TApplicationException codes

2018-01-19 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1474
  
I see the point but I'm not sure if Inunderstzand it right. Who doies what 
before we add new codes? We ask FB? Or they ask us? And what ist your plan to 
convince FB that they have to ask us?


---

[GitHub] thrift pull request #1466: THRIFT-4454 Large writes/reads may cause range ch...

2018-01-12 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1466

THRIFT-4454 Large writes/reads may cause range check errors in debug …

…mode

Client: Delphi
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4454

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1466.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1466


commit b27498128b28bfab2b7951254798d4832d775e06
Author: Jens Geyer <jensg@...>
Date:   2018-01-12T20:20:59Z

THRIFT-4454 Large writes/reads may cause range check errors in debug mode
Client: Delphi
Patch: Jens Geyer




---

[GitHub] thrift issue #1461: Golang: fix for (deprecated) New*ClientFactory and New*C...

2018-01-09 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1461
  
Hi John,

Questions:
* Why are they deprecated? I probably only overlook sth, so bear with me
* Do we have a JIRA Ticket for this? If not, could you create one?





---

[GitHub] thrift issue #1444: THRIFT-4422 Add Async implementation via IFuture

2017-12-13 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1444
  
Travis errors seem unrelated. Go library? C++ library? I didn't even touch 
those ...


---

[GitHub] thrift issue #1440: Enhancement binary_protocol with frametransport

2017-12-12 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1440
  
Plus chinese comments should be english.


---

[GitHub] thrift pull request #1444: THRIFT-4422 Add Async implementation via IFuture

2017-12-12 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1444

THRIFT-4422 Add Async implementation via IFuture

Client: Delphi
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4422

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1444.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1444


commit 6b1b9bc3a6bc3709c86b3f6ff55c32636ae23c93
Author: Jens Geyer <je...@apache.org>
Date:   2017-12-09T12:47:09Z

THRIFT-4422 Add Async implementation via IFuture
Client: Delphi
Patch: Jens Geyer




---

[GitHub] thrift pull request #1432: 0.11.0 rc1

2017-12-02 Thread Jens-G 
Github user Jens-G closed the pull request at:

https://github.com/apache/thrift/pull/1432


---

[GitHub] thrift issue #1433: fix plugin.thrift, plugin{,output}.cc to use t_const_val...

2017-12-02 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1433
  
> , unless we ONLY use the plug-in method

I personally don't think that is a good idea. I just went through that pain 
with grpc a while ago and I remember it as being utterly complicated to set up. 
Monolithic is good.


---

[GitHub] thrift pull request #1436: THRIFT-4400 Visual Studio Compiler project should...

2017-12-02 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1436

THRIFT-4400 Visual Studio Compiler project should link runtime static…

…ally in release builds

Client: Compiler (general)
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4400

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1436.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1436


commit c84154bd16a75c09ff99ec34a3a52c982fe2194e
Author: Jens Geyer <je...@apache.org>
Date:   2017-12-02T09:28:25Z

THRIFT-4400 Visual Studio Compiler project should link runtime statically 
in release builds
Client: Compiler (general)
Patch: Jens Geyer




---

[GitHub] thrift issue #1430: Fix generated maven packaging

2017-12-01 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1430
  
Hi @slandelle, 
thank you for the patch!

[If you could also create a ticket for it as 
well](https://thrift.apache.org/docs/committers/HowToRelease), that would be 
awesome. 


---

[GitHub] thrift pull request #1432: 0.11.0 rc1

2017-12-01 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1432

0.11.0 rc1

Versioning for 0.11.0 release candidate

**Caution: Do NOT merge this to master.** 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift 0.11.0-rc1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1432.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1432


commit 1310dc1eb4014457a667a7287d1fa113432c7a54
Author: Jens Geyer <je...@apache.org>
Date:   2017-11-29T21:35:29Z

Version 0.11.0

commit 1c7bf3ebc43b8f2f2a800f6ed43643d001e12040
Author: Jens Geyer <je...@apache.org>
Date:   2017-11-30T21:30:03Z

THRIFT-4398 Update EXTRA_DIST for "make dist"
Client: Build process
Patch: Jens Geyer

This closes #1431




---

[GitHub] thrift pull request #1431: THRIFT-4398 Update EXTRA_DIST for "make dist"

2017-12-01 Thread Jens-G 
Github user Jens-G commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1431#discussion_r154285598
  
--- Diff: test/haxe/Makefile.am ---
@@ -96,7 +96,9 @@ EXTRA_DIST = \
  neko.hxml \
  php.hxml \
  python.hxml \
+ router.php \
  project.hide \
+php-web-server.hxml \
--- End diff --

Thanks, fixed.


---

[GitHub] thrift pull request #1431: THRIFT-4398 Update EXTRA_DIST for "make dist"

2017-11-30 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1431

THRIFT-4398 Update EXTRA_DIST for "make dist"

Client: Build process
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4398

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1431.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1431


commit 9f44365d59693b2032393fe0807575cbb8b5384c
Author: Jens Geyer <je...@apache.org>
Date:   2017-11-30T21:30:03Z

THRIFT-4398 Update EXTRA_DIST for "make dist"
Client: Build process
Patch: Jens Geyer




---

[GitHub] thrift pull request #1422: THRIFT-4396 inconsistent (or plain wrong) version...

2017-11-29 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1422

THRIFT-4396 inconsistent (or plain wrong) version numbers in master/t…

…runk

Client: (multiple)
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4396

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1422.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1422


commit 21f92941ab2561c81124e59751049796542e3243
Author: Jens Geyer <je...@apache.org>
Date:   2017-11-29T21:54:49Z

THRIFT-4396 inconsistent (or plain wrong) version numbers in master/trunk
Client: (multiple)
Patch: Jens Geyer




---

[GitHub] thrift issue #1413: 0.8.x

2017-11-13 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1413
  
@jfarrell, could you please close this?


---

[GitHub] thrift pull request #1410: THRIFT-82: Add Common Lisp support

2017-11-07 Thread Jens-G 
Github user Jens-G commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1410#discussion_r149504639
  
--- Diff: lib/cl/framed-transport.lisp ---
@@ -0,0 +1,136 @@
+(in-package #:org.apache.thrift.implementation)
+
+ Copyright 2017 Rigetti Computing 
--- End diff --

Well, the term "sponsored" is a bit broad to derive that particular 
conclusion from it. So I asked for further clarification.  



---

[GitHub] thrift issue #1410: THRIFT-82: Add Common Lisp support

2017-11-07 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1410
  
@jfarrell: What's your opinion re the (c) things above?


---

[GitHub] thrift pull request #1410: THRIFT-82: Add Common Lisp support

2017-11-07 Thread Jens-G 
Github user Jens-G commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1410#discussion_r149475953
  
--- Diff: lib/cl/framed-transport.lisp ---
@@ -0,0 +1,136 @@
+(in-package #:org.apache.thrift.implementation)
+
+ Copyright 2017 Rigetti Computing 
--- End diff --

> Our work on Thrift is sponsored by Rigetti, so there is no need for that.

That sounds ... strange.


---

[GitHub] thrift issue #1402: THRIFT-4372 Pipe write operations across a network are l...

2017-10-26 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1402
  
> Why not actually use (2^16)-1 which is the limit?

Several reasons. First, aligned memory access is always faster. If we 
subtract 1 byte, we get the worst case. Next, at least on Windows a number of 
system resources use multiples of 4096, so it is probably not a bad idea to 
follow that model. That's why I picked this particular value.


---

[GitHub] thrift pull request #1402: THRIFT-4372 Pipe write operations across a networ...

2017-10-25 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1402

THRIFT-4372 Pipe write operations across a network are limited to 65,…

…535 bytes per write

Client: C#
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4372

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1402.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1402


commit ccfc002a480c9ed23b50674c3fd76a280750bbb0
Author: Jens Geyer <je...@apache.org>
Date:   2017-10-25T20:30:23Z

THRIFT-4372 Pipe write operations across a network are limited to 65,535 
bytes per write
Client: C#
Patch: Jens Geyer




---

[GitHub] thrift issue #782: THRIFT-2790 thrift -gen all => an option to generate all ...

2017-10-25 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/782
  
This will not generate nodejs code, to name just one case.


---

[GitHub] thrift issue #1370: THRIFT-3766: add zlib getUnderlyingTransport method

2017-09-22 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1370
  
Yeah, test. I got only 2 mails this time. Your comment generated 3 mails. I 
had cases where I got up to 7 mails for one github comment.


---

[GitHub] thrift issue #1370: THRIFT-3766: add zlib getUnderlyingTransport method

2017-09-22 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1370
  
Test


---

[GitHub] thrift issue #1355: Minimal C# library version for .NET Standard 1.4, 1.6, ....

2017-09-12 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1355
  
Jake does that.


---

[GitHub] thrift issue #1355: Minimal C# library version for .NET Standard 1.4, 1.6, ....

2017-09-12 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1355
  
I'm fine with combining both flavours into one single c# library etc, as 
long as you don't break the c# library. The netcore lib is quite new and 
there's a lot of movement so we surely can throw it out and replace it by sth 
else. I don't see any conflicts here. Would you say that you two guys able to 
do that as a team and provide a suitable PR that meets that goal? 


---

[GitHub] thrift issue #1355: Minimal C# library version for .NET Standard 1.4, 1.6, ....

2017-09-12 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1355
  
What is THRIFTCORE? Is this intended tom become another netcore library? 
What about the existing one? Please explain.


---

[GitHub] thrift pull request #1348: THRIFT-4318 Delphi performance improvements

2017-09-07 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1348

THRIFT-4318 Delphi performance improvements

Client: Delphi
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4318

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1348.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1348


commit 11c887f1a61c367c83cf7e90d28f74d06a81b17f
Author: Jens Geyer <je...@apache.org>
Date:   2017-09-05T18:31:27Z

THRIFT-4318 Delphi performance improvements
Client: Delphi
Patch: Jens Geyer




---

[GitHub] thrift issue #1338: Make ssl-open timeout effective in golang client

2017-09-03 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1338
  
http://thrift.apache.org/docs/HowToContribute


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1339: Python print() function

2017-09-03 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1339
  
http://thrift.apache.org/docs/HowToContribute



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1323: THRIFT-3775: 0.10.0 release

2017-08-02 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1323
  
No idea what you think you can achieve with that. Please close this PR, as 
it will never get merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1311: Fix for constant assignments to optional fields in Go.

2017-07-27 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1311
  
Ping


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1316: THRIFT-4266: Erlang skip fix

2017-07-27 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1316
  
Anyone amongst the fluently Erlang speaking people who wants to review this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1309: Use build tags to support context.

2017-07-23 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1309
  
go version go1.8.3 windows/amd64


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1311: Fix for constant assignments to optional fields i...

2017-07-22 Thread Jens-G 
Github user Jens-G commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1311#discussion_r128901829
  
--- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc ---
@@ -424,6 +424,52 @@ bool t_go_generator::is_pointer_field(t_field* tfield, 
bool in_container_value)
   throw "INVALID TYPE IN type_to_go_type: " + type->get_name();
 }
 
+string t_go_generator::gen_opt_const_values_(t_base_type::t_base tbase, 
t_const_value *value) {
+  string go_value_str = "&({x ";
+  switch (tbase) {
+case t_base_type::TYPE_BOOL:
+  go_value_str += "bool}{";
+  go_value_str += (value->get_integer() > 0 ? "true" : "false");
+  break;
+
+case t_base_type::TYPE_I8:
+  go_value_str += "int8}{";
+  go_value_str += std::to_string(static_cast(value->get_integer()));
+  break;
--- End diff --

Three questions:
a) Why are these casts needed?
b) Can we move that whole method next to the other method? 
c) Why do we need two separate methods at all?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1309: Use build tags to support context.

2017-07-22 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1309
  
> I'll also be sending a PR to update the Go tutorial with the new handler 
signature.

Please do. Right now the tutorial does not build.

```
handler.go:30:2: cannot find package "golang.org/x/net/context" in any of:
C:\Go\src\golang.org\x\net\context (from $GOROOT)
D:\Workdir\src\golang.org\x\net\context (from $GOPATH)
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1304: THRIFT-4237 Fix effective deadlock introduced by ...

2017-07-07 Thread Jens-G 
Github user Jens-G commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1304#discussion_r126221534
  
--- Diff: lib/go/thrift/server_socket.go ---
@@ -68,15 +68,18 @@ func (p *TServerSocket) Listen() error {
 
 func (p *TServerSocket) Accept() (TTransport, error) {
p.mu.RLock()
-   defer p.mu.RUnlock()
+   listener := p.listener
+   interrupted := p.interrupted
+   p.mu.RUnlock()
 
--- End diff --

Agree. Looks strange. and the comment even says

  // Protects the interrupted value to make it thread safe.

What about moving the ```listener := p.listener``` line down just before it 
is used? Or do I overlook sth?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1293: THRIFT-2642 Recursive structs don't work in pytho...

2017-07-05 Thread Jens-G 
Github user Jens-G commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1293#discussion_r125749743
  
--- Diff: lib/py/src/TRecursive.py ---
@@ -0,0 +1,63 @@
+# MODIFIED June 20, 2017, Eric Conner
+#
+#
+# Original source copyright 2014-present Facebook, Inc.
+#
--- End diff --

Where does line 1 to 5 come from? That's not part of the standard ASF 
license header.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1303: fix framed_transport memory increase when write transpor...

2017-07-05 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1303
  
Tracked in THRIFT-4245
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1186: THRIFT-1805 Provide option for handling RTEs

2017-07-01 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1186
  
@ctubbsii: Could you please have a look at 
[THRIFT-4239](https://issues.apache.org/jira/browse/THRIFT-4239)? Not sure if 
it has sth. to do with your patch, but it came up while looking for the cause, 
so maybe you do have some input.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1298: THRIFT-4236: Add context support for go server.

2017-07-01 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1298
  
I look at it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1287: THRIFT-4219 Refactor Go HTTP Client

2017-07-01 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1287
  
If nobody else wants to vote against it, I'll commit this soon. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1297: handleRuntimeExceptions

2017-06-26 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1297
  
Something is wrong here. Could you please review your pull request? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1296: THRIFT-4234 Travis build fails cross language tests with...

2017-06-26 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1296
  
Nice, but not 100%. Still two are saying ..

> npm install
> /bin/bash: npm: command not found
> 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1292: Using PHP56 const property for contant variables.

2017-06-20 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1292
  
1) We have a [nice, short & concise contrib 
guide](http://thrift.apache.org/docs/HowToContribute) that covers all the 
formalities

2) We also have a [test 
suite](https://github.com/apache/thrift/tree/master/test) that may be helpful 
with testing this. It is also run through the pre-commit checks. If you feel 
additional specific tests should be added, these are usually placed somewhere 
under [`/lib/php`](https://github.com/apache/thrift/tree/master/lib/php/test)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1291: THRIFT-4231 TJSONProtocol throws unexpected non-T...

2017-06-16 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1291

THRIFT-4231 TJSONProtocol throws unexpected non-Thrift-exception on n…

…ull strings

Client: C#
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4231

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1291.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1291


commit 658fad07ffe4db2932a0448b0f33ab0f55ca54db
Author: Jens Geyer <je...@apache.org>
Date:   2017-06-16T21:10:54Z

THRIFT-4231 TJSONProtocol throws unexpected non-Thrift-exception on null 
strings
Client: C#
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1288: THRIFT-3775: 0.10.0 release

2017-06-13 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1288
  
Can someone with adequate privileges please close this bull, ehm - PULL 
request?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1284: THRIFT-4222: Add Golang NewTServerSocketFromAddrTimeout

2017-06-06 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1284
  
Ok, I'll look at it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1284: Add Golang NewTServerSocketFromAddrTimeout

2017-06-04 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1284
  
If you could file a JIRA ticket, that would be awesome :-)
http://thrift.apache.org/docs/HowToContribute 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1283: THRIFT-4218: Set TCP_NODELAY for PHP client socket

2017-05-31 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1283
  
Anyone from the PHP experts who can confirm this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1282: THRIFT-4217 HttpClient should support gzip and de...

2017-05-30 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1282

THRIFT-4217 HttpClient should support gzip and deflate

Client: C#
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4217

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1282.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1282


commit 8ce21f8822cf7f80adf039a6112bdc2d8b304c99
Author: Jens Geyer <je...@apache.org>
Date:   2017-05-30T20:32:01Z

THRIFT-4217 HttpClient should support gzip and deflate
Client: C#
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1280: THRIFT-4213 Travis build fails at curl -sSL https...

2017-05-27 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1280

THRIFT-4213 Travis build fails at curl -sSL https://www.npmjs.com/ins…

…tall.sh | sh

Client: Build process
Patch: Jens Geyer

Temporarily removed nodejs from travis builds to get the previous commit 
tested. This is NOT the fix, only a workaround to minimize the impact of the 
problem.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4213

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1280.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1280






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1276: THRIFT-4208 C# NamedPipesServer not really workin...

2017-05-27 Thread Jens-G 
Github user Jens-G closed the pull request at:

https://github.com/apache/thrift/pull/1276


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1275: THRIFT-4209 warning CS0414 in T[TLS]ServerSocket....

2017-05-27 Thread Jens-G 
Github user Jens-G closed the pull request at:

https://github.com/apache/thrift/pull/1275


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1275: THRIFT-4209 warning CS0414 in T[TLS]ServerSocket....

2017-05-24 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1275

THRIFT-4209 warning CS0414 in T[TLS]ServerSocket.cs

Client: C#
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4209

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1275.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1275


commit 3940d3e1e3b48e554990095fe7581c0508c2d828
Author: Jens Geyer <je...@apache.org>
Date:   2017-05-24T19:32:28Z

THRIFT-4209 warning CS0414 in T[TLS]ServerSocket.cs
Client: C#
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1277: THRIFT-4210 include Thrift.45.csproj into CI runs

2017-05-24 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1277

THRIFT-4210 include Thrift.45.csproj into CI runs

Client: C#
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4210

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1277.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1277


commit 394d4816d6424535cd181c9a2b0ce0fa65ca5aaa
Author: Jens Geyer <je...@apache.org>
Date:   2017-05-23T20:28:24Z

THRIFT-4210 include Thrift.45.csproj into CI runs
Client: C#
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1276: THRIFT-4208 C# NamedPipesServer not really workin...

2017-05-24 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1276

THRIFT-4208 C# NamedPipesServer not really working in some scenarios …

…Client: C# Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4208

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1276.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1276


commit 40e1417e983743f419aeb7b9e385cfffb5d8d85c
Author: Jens Geyer <je...@apache.org>
Date:   2017-05-24T13:27:02Z

THRIFT-4208 C# NamedPipesServer not really working in some scenarios 
Client: C# Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1270: Fix typo in compat protocol spec

2017-05-18 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1270
  
THRIFT-4204


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1268: THRIFT-4190 Improve C# TThreadPoolServer defaults (part ...

2017-05-13 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1268
  
The NPM timed out, no other errors. If there are no objections against it, 
I'll commit that shortly. 
So please speak now (or be quiet forever, as they say) ... :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1252: [Ruby] Logging server-side exception message on Applicat...

2017-05-12 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1252
  
Tracked in THRIFT-4198. See [our contrib 
guide](http://thrift.apache.org/docs/HowToContribute) for details.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1268: THRIFT-4190 Improve C# TThreadPoolServer defaults...

2017-05-12 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1268

THRIFT-4190 Improve C# TThreadPoolServer defaults (part 2 of 2)

Client: C#
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4190

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1268.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1268


commit 6f1a3c23744d573488dc64c196ba4e8932c33d3b
Author: Jens Geyer <je...@apache.org>
Date:   2017-05-12T20:49:57Z

THRIFT-4190 Improve C# TThreadPoolServer defaults (part 2 of 2)
Client: C#
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1266: THRIFT-4197 [Go] Transparent gzip support for HTTP trans...

2017-05-12 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1266
  
Don't panic, I already planned to look into this. I have a life 
besidesThrift, you know ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1262: THRIFT-4190 Improve C# TThreadPoolServer defaults

2017-05-07 Thread Jens-G 
Github user Jens-G closed the pull request at:

https://github.com/apache/thrift/pull/1262


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1262: THRIFT-4190 Improve C# TThreadPoolServer defaults

2017-05-06 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1262

THRIFT-4190 Improve C# TThreadPoolServer defaults

Client: C#
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4190

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1262.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1262






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1258: THRIFT-4183 Named pipe client blocks forever on Open() w...

2017-04-26 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1258
  
That travis thing seems pretty reliable. The pobkly difference is in  the 
commit message, yet it fails where it succeeded minutes ago. Compare 
https://travis-ci.org/apache/thrift/builds/226143091 against 
https://travis-ci.org/apache/thrift/builds/226192720.

@jeking3: Maybe. On the other hand, timeouts in C# are always msec, and the 
name is self-documenting. More comments would be helpful nevertheless, but that 
would be a much larger task to do it right. Too much for my little addition :-) 
Appreciate both review & comments though. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1258: THRIFT-4183 Named pipe client blocks forever on O...

2017-04-26 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1258

THRIFT-4183 Named pipe client blocks forever on Open() when there is …

…no server at the other end

Client: C#
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4183

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1258.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1258


commit cee63d76b2847ecd4e844aded75cf546c88c33b3
Author: Jens Geyer <je...@apache.org>
Date:   2017-04-26T19:26:01Z

THRIFT-4183 Named pipe client blocks forever on Open() when there is no 
server at the other end
Client: C#
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1045: THRIFT-3876 haxe js/nodejs client

2017-04-06 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1045
  
After I read that the cross tests doesn't need to be made because "it 
doesn't work anyway" my enthusiasm for this patch was basically send to zero . 
First, this is a plain lie. Second, when I read such statements it gives great 
insight into the attitude of the contributor. I'm not willing to even look at 
it anymore under that premise.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1234: THRIFT-4157 outdated readme about Haxe installation on L...

2017-04-02 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1234
  
THRIFT-4157


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1234: THRIFT-4157 outdated readme about Haxe installati...

2017-04-02 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1234

THRIFT-4157 outdated readme about Haxe installation on Linux

Client: Haxe
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4175

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1234.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1234


commit 3d371df1bbe08de0e353bb13d48f2b1568bd33d3
Author: Jens Geyer <je...@apache.org>
Date:   2017-04-02T14:01:11Z

THRIFT-4157 outdated readme about Haxe installation on Linux
Client: Haxe
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1230: Make a patch to fix #4152 at least for structs

2017-04-01 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1230
  
THRIFT-4152


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1223: THRIFT-4137 vptr @ compiler

2017-03-27 Thread Jens-G 
Github user Jens-G closed the pull request at:

https://github.com/apache/thrift/pull/1223


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1223: THRIFT-4137 vptr @ compiler

2017-03-27 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1223
  
Yeah, but at least it looks as if we get the compiler ready. 

If there are no objections, I am going commit that part today, With UBSAN 
still left disabled of course. I only enabled it in the PR to have travis run 
these tests. 

Since you already made some proposals, could you take care about the boost 
/ libraries part? @jeking3 and me will be happy reviewers, that's for sure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1223: THRIFT-4137 vptr @ compiler

2017-03-26 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1223

THRIFT-4137 vptr @ compiler



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4137

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1223.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1223


commit 4dca9e6b256fa831689e386abf09471867a2e009
Author: Jens Geyer <je...@apache.org>
Date:   2017-03-26T12:52:35Z

THRIFT-4134-Fix-remaining-undefined-behavior-invalid.patch

commit 0d3cc7204d2d531623f35624e80a83c91b03c8e8
Author: Jens Geyer <je...@apache.org>
Date:   2017-03-26T15:27:59Z

THRIFT-4134-Fix-remaining-undefined-behavior-invalid.patch

commit e67ee35eadb62774fdf967e332d9bc6711a0177e
Author: Jens Geyer <je...@apache.org>
Date:   2017-03-26T17:41:24Z

THRIFT-4134 Fix remaining undefined behavior invalid vptr




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1222: THRIFT-4134-Fix-remaining-undefined-behavior-invalid.pat...

2017-03-26 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1222
  
To be honest, my intention is to fix the actual problem, not to refactor 
the whole app.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1222: THRIFT-4134-Fix-remaining-undefined-behavior-invalid.pat...

2017-03-26 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1222
  
No, the intention is to patch everything. A few things are still open, but 
I will update the PR until we have it all.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1222: THRIFT-4134-Fix-remaining-undefined-behavior-invalid.pat...

2017-03-26 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1222
  
```
void t_json_generator::write_type_spec(t_type* ttype) {
  ttype = ttype->get_true_type();

  write_string(get_type_name(ttype));

  if (ttype->is_struct() || ttype->is_xception()) {
write_key_and_string("class", get_qualified_name(ttype));
return;
  }

  if (ttype->is_map()) {
t_type* ktype = ((t_map*)ttype)->get_key_type();
t_type* vtype = ((t_map*)ttype)->get_val_type();
write_key_and_string("keyTypeId", get_type_name(ktype));
write_key_and_string("valueTypeId", get_type_name(vtype));
write_type_spec_object("keyType", ktype);
write_type_spec_object("valueType", vtype);
return;
  }

  t_type* etype;
  if (ttype->is_list()) {
etype = ((t_list*)ttype)->get_elem_type();
  } else if (ttype->is_set()) {
etype = ((t_set*)ttype)->get_elem_type();
  } else {
etype = NULL;
  }
  if( etype != NULL) {
write_key_and_string("elemTypeId", get_type_name(etype));
write_type_spec_object("elemType", etype);
return;
  }
}

```

Mmmh. I think I go with the duplicates. Feel free to make it better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1222: THRIFT-4134-Fix-remaining-undefined-behavior-inva...

2017-03-26 Thread Jens-G 
Github user Jens-G commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1222#discussion_r108063013
  
--- Diff: build/docker/scripts/ubsan.sh ---
@@ -15,7 +15,7 @@ export CXX=clang++-3.8
 # undefined casting, aka "vptr".
 #
 # TODO: fix undefined vptr behavior and turn this option back on.
-export CFLAGS="-fsanitize=undefined -fno-sanitize-recover=undefined 
-fno-sanitize=vptr"
--- End diff --

I just used your proposal.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1222: THRIFT-4134-Fix-remaining-undefined-behavior-inva...

2017-03-26 Thread Jens-G 
Github user Jens-G commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1222#discussion_r108062987
  
--- Diff: compiler/cpp/src/thrift/generate/t_xml_generator.cc ---
@@ -391,11 +391,16 @@ void t_xml_generator::write_type(t_type* ttype) {
   if (type == "id") {
 write_attribute("type-module", ttype->get_program()->get_name());
 write_attribute("type-id", ttype->get_name());
-  } else if (type == "list" || type == "set") {
+  } else if (type == "list") {
 t_type* etype = ((t_list*)ttype)->get_elem_type();
 write_element_start("elemType");
 write_type(etype);
 write_element_end();
+  } else if (type == "set") {
+t_type* etype = ((t_set*)ttype)->get_elem_type();
+write_element_start("elemType");
--- End diff --

I know they are duplicates because I duplicated them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1222: THRIFT-4134-Fix-remaining-undefined-behavior-inva...

2017-03-26 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1222

THRIFT-4134-Fix-remaining-undefined-behavior-invalid.patch



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4134

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1222.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1222


commit b82e0b63c7a9737ff33a6aded0fe678b89daa4ad
Author: Jens Geyer <je...@apache.org>
Date:   2017-03-26T12:52:35Z

THRIFT-4134-Fix-remaining-undefined-behavior-invalid.patch




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1221: THRIFT-4136

2017-03-26 Thread Jens-G 
GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/1221

THRIFT-4136



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-4136

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1221.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1221


commit 6782f1af7687915d43fd778800bba6684a6b2b7b
Author: Jens Geyer <je...@apache.org>
Date:   2014-12-28T23:54:36Z

Setup for VS 2015 + workarounds for some open tickets:
- THRIFT-2913 Ruby Server Thrift::ThreadPoolServer should serve inside a 
thread  -->  commented out
- (NO TICKET) gjslint fails with invalid syntax in 
closure_linter/gjslint.py", line 168 -> commented, need Python 2.7.3

commit 3d940da0bbf01fce779d0a8d437a3ba26f2dc793
Author: Jens Geyer <je...@apache.org>
Date:   2017-03-26T12:52:35Z

THRIFT-4134-Fix-remaining-undefined-behavior-invalid.patch

commit b87460c806696d393a5f870d30252e55927212fb
Author: Jens Geyer <je...@apache.org>
Date:   2017-03-26T12:53:00Z

THRIFT-4134-Fix-remaining-undefined-behavior-invalid.patch

commit 2f71de6bde1333d3e9da7ae38d2c0a3b13283bdf
Author: Jens Geyer <je...@apache.org>
Date:   2017-03-26T13:54:30Z

THRIFT-4136 align is_binary() function with all other types
Client: Compiler (general)
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1163: THRIFT-4039: Update of Apache Thrift .Net Core lib

2017-03-19 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1163
  
> because .Net Core generator still not included into Thrift.exe.

It's included in trunk, not in 0.10. The release was already at the door so 
I didn't want to pollute it with a newly included target that may need some 
time to be thorougly tested and stable. It will be in the next release. When 
you build the compiler from trunk, you get it right now.

> The only question for me - how do you build libraries on build server and 
also how I can find some basic help about how to do that. It will be good to 
know to avoid issues with changes.

Automake scripts do still work, and to my knowledge it is also included in 
the CMake scripts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1208: THRIFT-4108 : Fix several problems found on library.

2017-03-07 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1208
  
The careful reader will notice that it says "asfgit closed this in b79396f 
19 hours ago". The b79396f is a link to the commit you are looking for.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #124: THRIFT-2522 TypeScript extension for Thrift Compiler

2017-02-26 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/124
  
We have a ts target?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1156: THRIFT-4011 Use slices for Thrift sets

2017-02-20 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1156
  
Ok, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1156: THRIFT-4011 Use slices for Thrift sets

2017-02-18 Thread Jens-G 
Github user Jens-G commented on the issue:

https://github.com/apache/thrift/pull/1156
  
```
src/common/clientserver_test.go:61: cannot use handler (type 
*MockThriftTest) as type thrifttest.ThriftTest in argument to GetServerParams:
*MockThriftTest does not implement thrifttest.ThriftTest (wrong type 
for TestSet method)
have TestSet(map[int32]struct {}) (map[int32]struct {}, error)
want TestSet([]int32) ([]int32, error)
src/common/clientserver_test.go:226: cannot use s (type map[int32]struct 
{}) as type []int32 in argument to client.TestSet
FAILcommon [build failed]
make[2]: *** [check] Error 2
make[2]: Leaving directory `/thrift/src/test/go'
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory `/thrift/src/test'
make: *** [check-recursive] Error 1

```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

  1   2   3   4   >