[jira] [Commented] (THRIFT-5775) Kotlin build failed
[
https://issues.apache.org/jira/browse/THRIFT-5775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847067#comment-17847067
]
Volodymyr Panivko commented on THRIFT-5775:
---
[~jensg] can you help with this troubles?
> Kotlin build failed
> ---
>
> Key: THRIFT-5775
> URL: https://issues.apache.org/jira/browse/THRIFT-5775
> Project: Thrift
> Issue Type: Bug
> Components: Kotlin - Compiler, Kotlin - Library
>Reporter: Volodymyr Panivko
>Priority: Major
>
> I'm trying to run cross test in docker but i'm getting an error
>
>
> {code:java}
> Making all in kotlin
> make[3]: Entering directory '/thrift/src/lib/kotlin'
> /usr/local/bin/gradle assemble \
> -Pthrift.version=0.21.0 \
> -Pthrift.compiler=/thrift/src/compiler/cpp/thrift \
> --console=plain
> FAILURE: Build failed with an exception.
> * What went wrong:
> A problem occurred configuring root project 'libthrift-kotlin'.
> > Failed to calculate the value of task ':compileJava' property
> > 'javaCompiler'.
> > No matching toolchains found for requested specification:
> {languageVersion=8, vendor=any, implementation=vendor-specific} for LINUX on
> x86_64.
> > No locally installed toolchains match and toolchain download
> repositories have not been configured.
> * Try:
> > Learn more about toolchain auto-detection at
> > https://docs.gradle.org/8.4/userguide/toolchains.html#sec:auto_detection.
> > Learn more about toolchain repositories at
> > https://docs.gradle.org/8.4/userguide/toolchains.html#sub:download_repositories.
> > Run with --stacktrace option to get the stack trace.
> > Run with --info or --debug option to get more log output.
> > Run with --scan to get full insights.
> > Get more help at https://help.gradle.org.
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (THRIFT-5776) Cpp cross test fail
[
https://issues.apache.org/jira/browse/THRIFT-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842848#comment-17842848
]
Volodymyr Panivko commented on THRIFT-5776:
---
In ubuntu-focal situation is better, tests are running
After running build/docker/scripts/autotools.sh I get such result:
{code:java}
*** No errors detected
PASS: UnitTests
Thrift: Thu May 2 06:22:30 2024 ~TFDTransport TTransportException:
'TFDTransport::close(): Bad file descriptor'*** No errors detected
PASS: TFDTransportTest*** No errors detected
PASS: TPipedTransportTest*** No errors detected
PASS: DebugProtoTest*** No errors detected
PASS: JSONProtoTest*** No errors detected
PASS: OptionalRequiredTest*** No errors detected
PASS: RecursiveTest*** No errors detected
PASS: SpecializationTest
TBinaryProtocol => OK
TLEBinaryProtocol => OK
TCompactProtocol => OK*** No errors detected
PASS: AllProtocolsTest
Timeout alarm expired; attempting to unblock transport
Timeout alarm expired; attempting to unblock transport
Timeout alarm expired; attempting to unblock transport
Timeout alarm expired; attempting to unblock transport
Timeout alarm expired; attempting to unblock transport
Timeout alarm expired; attempting to unblock transport
Timeout alarm expired; attempting to unblock transport
Timeout alarm expired; attempting to unblock transport
Timeout alarm expired; attempting to unblock transport
Timeout alarm expired; attempting to unblock transport*** No errors detected
PASS: TransportTest
Thrift: Thu May 2 06:23:12 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)*** No errors detected
PASS: TInterruptTest*** No errors detected
PASS: TServerIntegrationTest
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)*** 6 failures are detected in the test module
"SecurityTest"
FAIL: SecurityTest
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024 SSL_shutdown: shutdown while in init
(SSL_error_code = 1)
Thrift: Thu May 2 06:23:30 2024
[jira] [Commented] (THRIFT-5776) Cpp cross test fail
[
https://issues.apache.org/jira/browse/THRIFT-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842847#comment-17842847
]
Volodymyr Panivko commented on THRIFT-5776:
---
ubuntu-jammy
> Cpp cross test fail
> ---
>
> Key: THRIFT-5776
> URL: https://issues.apache.org/jira/browse/THRIFT-5776
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Reporter: Volodymyr Panivko
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When running cross test in docker I'm getting an error
> {code:java}
> ibs/ThriftTest_extras.o
> Benchmark.cpp: In function 'int main()':
> Benchmark.cpp:69:7: error: 'class thrift::test::debug::OneOfEach' has no
> member named 'rfc4122_uuid'
> 69 | ooe.rfc4122_uuid = "{5e2ab188-1726-4e75-a04f-1ed9a6a89c4c}";
> | ^~~~
> make[5]: *** [Makefile:1408: Benchmark.o] Error 1
> {code}
> if i comment 69 line in Benchmark.cpp this error doe not appear but i'm
> getting a new one THRIFT-5775
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (THRIFT-5776) Cpp cross test fail
[
https://issues.apache.org/jira/browse/THRIFT-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842154#comment-17842154
]
Volodymyr Panivko commented on THRIFT-5776:
---
[~cjcombrink] thanks for helping.
I applied your fix, than run build/docker/scripts/autotools.sh and get such
result:
{code:java}
g++ -std=c++11 -DHAVE_CONFIG_H -I../../cpp/src -I/usr/include -I./gen-cpp
-I../src -I./gen-c_glib -I/usr/include/glib-2.0
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -g -Wall -Wextra -pedantic
-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -g -O2
-MT testthrifttestclient-testthrifttestclient.o -MD -MP -MF
.deps/testthrifttestclient-testthrifttestclient.Tpo -c -o
testthrifttestclient-testthrifttestclient.o `test -f 'testthrifttestclient.cpp'
|| echo './'`testthrifttestclient.cpp
g++ -std=c++11 -DHAVE_CONFIG_H -I../../cpp/src -I/usr/include -I./gen-cpp
-I../src -I./gen-c_glib -I/usr/include/glib-2.0
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -g -Wall -Wextra -pedantic
-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -g -O2
-MT testthrifttestzlibclient-testthrifttestzlibclient.o -MD -MP -MF
.deps/testthrifttestzlibclient-testthrifttestzlibclient.Tpo -c -o
testthrifttestzlibclient-testthrifttestzlibclient.o `test -f
'testthrifttestzlibclient.cpp' || echo './'`testthrifttestzlibclient.cpp
testthrifttestzlibclient.cpp:295:5: warning: dynamic exception specifications
are deprecated in C++11 [-Wdeprecated]
295 | throw(Xception, apache::thrift::TException) override
| ^
testthrifttestzlibclient.cpp:313:93: warning: dynamic exception specifications
are deprecated in C++11 [-Wdeprecated]
313 | void testMultiException(Xtruct , const std::string ,
const std::string ) throw(Xception, Xception2) override {
|
^
testthrifttestclient.cpp: In function 'int main()':
testthrifttestclient.cpp:628:62: error: invalid new-expression of abstract
class type 'TestHandler'
628 | std::shared_ptr testHandler(new TestHandler());
| ^
testthrifttestclient.cpp:74:7: note: because the following virtual functions
are pure within 'TestHandler':
74 | class TestHandler : public ThriftTestIf {
| ^~~
In file included from testthrifttestclient.cpp:36:
./gen-cpp/ThriftTest.h:102:23: note: 'virtual std::string
thrift::test::ThriftTestIf::testUuid(std::string)'
102 | virtual std::string testUuid(const std::string thing) = 0;
| ^~~~
testthrifttestzlibclient.cpp: In function 'int main()':
testthrifttestzlibclient.cpp:627:62: error: invalid new-expression of abstract
class type 'TestHandler'
627 | std::shared_ptr testHandler(new TestHandler());
| ^
testthrifttestzlibclient.cpp:69:7: note: because the following virtual
functions are pure within 'TestHandler':
69 | class TestHandler : public ThriftTestIf {
| ^~~
In file included from testthrifttestzlibclient.cpp:31:
./gen-cpp/ThriftTest.h:102:23: note: 'virtual std::string
thrift::test::ThriftTestIf::testUuid(std::string)'
102 | virtual std::string testUuid(const std::string thing) = 0;
| ^~~~
make[6]: *** [Makefile:1620: testthrifttestclient-testthrifttestclient.o] Error
1
make[6]: *** Waiting for unfinished jobs
make[6]: *** [Makefile:1634:
testthrifttestzlibclient-testthrifttestzlibclient.o] Error 1
mv -f gen-c_glib/.deps/libtestgenc_la-t_test_thrift_test_types.Tpo
gen-c_glib/.deps/libtestgenc_la-t_test_thrift_test_types.Plo
make[6]: Leaving directory '/thrift/src/lib/c_glib/test'
make[5]: *** [Makefile:1904: check-am] Error 2
make[5]: Leaving directory '/thrift/src/lib/c_glib/test'
make[4]: *** [Makefile:1662: check-recursive] Error 1
make[4]: Leaving directory '/thrift/src/lib/c_glib/test'
make[3]: *** [Makefile:1907: check] Error 2
make[3]: Leaving directory '/thrift/src/lib/c_glib/test'
make[2]: *** [Makefile:1373: check-recursive] Error 1
make[2]: Leaving directory '/thrift/src/lib/c_glib'
make[1]: *** [Makefile:572: check-recursive] Error 1
make[1]: Leaving directory '/thrift/src/lib'
make: *** [Makefile:692: check-recursive] Error 1
{code}
> Cpp cross test fail
> ---
>
> Key: THRIFT-5776
> URL: https://issues.apache.org/jira/browse/THRIFT-5776
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Reporter: Volodymyr Panivko
>Priority: Major
> Time Spent: 10m
> Remaining
[jira] [Commented] (THRIFT-5776) Cpp cross test fail
[
https://issues.apache.org/jira/browse/THRIFT-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841423#comment-17841423
]
Volodymyr Panivko commented on THRIFT-5776:
---
[~cjcombrink] can you check?
> Cpp cross test fail
> ---
>
> Key: THRIFT-5776
> URL: https://issues.apache.org/jira/browse/THRIFT-5776
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Reporter: Volodymyr Panivko
>Priority: Major
>
> When running cross test in docker I'm getting an error
> {code:java}
> ibs/ThriftTest_extras.o
> Benchmark.cpp: In function 'int main()':
> Benchmark.cpp:69:7: error: 'class thrift::test::debug::OneOfEach' has no
> member named 'rfc4122_uuid'
> 69 | ooe.rfc4122_uuid = "{5e2ab188-1726-4e75-a04f-1ed9a6a89c4c}";
> | ^~~~
> make[5]: *** [Makefile:1408: Benchmark.o] Error 1
> {code}
> if i comment 69 line in Benchmark.cpp this error doe not appear but i'm
> getting a new one THRIFT-5775
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (THRIFT-5776) Cpp cross test fail
[
https://issues.apache.org/jira/browse/THRIFT-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840081#comment-17840081
]
Volodymyr Panivko commented on THRIFT-5776:
---
Maybe. But I am not so good in c++ to solve this trouble...
> Cpp cross test fail
> ---
>
> Key: THRIFT-5776
> URL: https://issues.apache.org/jira/browse/THRIFT-5776
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Reporter: Volodymyr Panivko
>Priority: Major
>
> When running cross test in docker I'm getting an error
> {code:java}
> ibs/ThriftTest_extras.o
> Benchmark.cpp: In function 'int main()':
> Benchmark.cpp:69:7: error: 'class thrift::test::debug::OneOfEach' has no
> member named 'rfc4122_uuid'
> 69 | ooe.rfc4122_uuid = "{5e2ab188-1726-4e75-a04f-1ed9a6a89c4c}";
> | ^~~~
> make[5]: *** [Makefile:1408: Benchmark.o] Error 1
> {code}
> if i comment 69 line in Benchmark.cpp this error doe not appear but i'm
> getting a new one THRIFT-5775
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (THRIFT-5776) Cpp cross test fail
[
https://issues.apache.org/jira/browse/THRIFT-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839396#comment-17839396
]
Volodymyr Panivko commented on THRIFT-5776:
---
[~jensg] can you help with this troubles?
> Cpp cross test fail
> ---
>
> Key: THRIFT-5776
> URL: https://issues.apache.org/jira/browse/THRIFT-5776
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Reporter: Volodymyr Panivko
>Priority: Major
>
> When running cross test in docker I'm getting an error
> {code:java}
> ibs/ThriftTest_extras.o
> Benchmark.cpp: In function 'int main()':
> Benchmark.cpp:69:7: error: 'class thrift::test::debug::OneOfEach' has no
> member named 'rfc4122_uuid'
> 69 | ooe.rfc4122_uuid = "{5e2ab188-1726-4e75-a04f-1ed9a6a89c4c}";
> | ^~~~
> make[5]: *** [Makefile:1408: Benchmark.o] Error 1
> {code}
> if i comment 69 line in Benchmark.cpp this error doe not appear but i'm
> getting a new one THRIFT-5775
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (THRIFT-5776) Cpp cross test fail
Volodymyr Panivko created THRIFT-5776:
-
Summary: Cpp cross test fail
Key: THRIFT-5776
URL: https://issues.apache.org/jira/browse/THRIFT-5776
Project: Thrift
Issue Type: Bug
Components: C++ - Library
Reporter: Volodymyr Panivko
When running cross test in docker I'm getting an error
{code:java}
ibs/ThriftTest_extras.o
Benchmark.cpp: In function 'int main()':
Benchmark.cpp:69:7: error: 'class thrift::test::debug::OneOfEach' has no member
named 'rfc4122_uuid'
69 | ooe.rfc4122_uuid = "{5e2ab188-1726-4e75-a04f-1ed9a6a89c4c}";
| ^~~~
make[5]: *** [Makefile:1408: Benchmark.o] Error 1
{code}
if i comment 69 line in Benchmark.cpp this error doe not appear but i'm getting
a new one THRIFT-5775
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (THRIFT-5775) Kotlin build failed
Volodymyr Panivko created THRIFT-5775:
-
Summary: Kotlin build failed
Key: THRIFT-5775
URL: https://issues.apache.org/jira/browse/THRIFT-5775
Project: Thrift
Issue Type: Bug
Components: Kotlin - Compiler, Kotlin - Library
Reporter: Volodymyr Panivko
I'm trying to run cross test in docker but i'm getting an error
{code:java}
Making all in kotlin
make[3]: Entering directory '/thrift/src/lib/kotlin'
/usr/local/bin/gradle assemble \
-Pthrift.version=0.21.0 \
-Pthrift.compiler=/thrift/src/compiler/cpp/thrift \
--console=plain
FAILURE: Build failed with an exception.
* What went wrong:
A problem occurred configuring root project 'libthrift-kotlin'.
> Failed to calculate the value of task ':compileJava' property 'javaCompiler'.
> No matching toolchains found for requested specification:
{languageVersion=8, vendor=any, implementation=vendor-specific} for LINUX on
x86_64.
> No locally installed toolchains match and toolchain download
repositories have not been configured.
* Try:
> Learn more about toolchain auto-detection at
> https://docs.gradle.org/8.4/userguide/toolchains.html#sec:auto_detection.
> Learn more about toolchain repositories at
> https://docs.gradle.org/8.4/userguide/toolchains.html#sub:download_repositories.
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (THRIFT-5770) Inf and Nan values does not encoded in php library
Volodymyr Panivko created THRIFT-5770: - Summary: Inf and Nan values does not encoded in php library Key: THRIFT-5770 URL: https://issues.apache.org/jira/browse/THRIFT-5770 Project: Thrift Issue Type: Bug Components: PHP - Library Affects Versions: 0.20.0 Reporter: Volodymyr Panivko Methods \Thrift\Protocol\TJSONProtocol::writeJSONDouble and \Thrift\Protocol\TSimpleJSONProtocol::writeJSONDouble uses for value encoding function json_encode which give an error "Inf and NaN cannot be JSON encoded". Because json_encode does not throw exception code works. This error can be seen by function json_last_error_msg or if flag THROW_ERROR_ON_EXCEPTION will be provided to json_encode Founded during writing tests for php library https://github.com/apache/thrift/pull/2951/files#r1536763203 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (THRIFT-5763) Go Cross test fails
[ https://issues.apache.org/jira/browse/THRIFT-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volodymyr Panivko updated THRIFT-5763: -- Summary: Go Cross test fails (was: Cross test fails) > Go Cross test fails > --- > > Key: THRIFT-5763 > URL: https://issues.apache.org/jira/browse/THRIFT-5763 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Reporter: Volodymyr Panivko >Priority: Major > > Filed cross tests on github actions > [https://github.com/apache/thrift/actions/runs/8140219811] > All cross tests on go is failed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (THRIFT-5763) Cross test fails
Volodymyr Panivko created THRIFT-5763: - Summary: Cross test fails Key: THRIFT-5763 URL: https://issues.apache.org/jira/browse/THRIFT-5763 Project: Thrift Issue Type: Bug Components: Go - Library Reporter: Volodymyr Panivko Filed cross tests on github actions [https://github.com/apache/thrift/actions/runs/8140219811] All cross tests on go is failed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (THRIFT-5755) Docker image build fail
[
https://issues.apache.org/jira/browse/THRIFT-5755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820376#comment-17820376
]
Volodymyr Panivko commented on THRIFT-5755:
---
And what about removing of travis support?
> Docker image build fail
> ---
>
> Key: THRIFT-5755
> URL: https://issues.apache.org/jira/browse/THRIFT-5755
> Project: Thrift
> Issue Type: Bug
> Environment: Ubuntu 22.04
>Reporter: Volodymyr Panivko
>Priority: Major
>
> When I'm trying to build an docker image and run command
> {code:java}
> docker build -t thrift build/docker/ubuntu-bionic{code}
> I get such error
>
> {code:java}
>
> => ERROR [13/35] RUN apt-get install -y --no-install-recommends `#
> dotnet core dependencies` dotnet-sdk-8.0 dotnet-runtime-8.0
> aspnetcore-runtime-8.0 dotnet-apphost-pack-8.0 1.3s
> --
> > [13/35] RUN apt-get install -y --no-install-recommends `# dotnet
> core dependencies` dotnet-sdk-8.0 dotnet-runtime-8.0
> aspnetcore-runtime-8.0 dotnet-apphost-pack-8.0:
> 0.350 Reading package lists...
> 1.113 Building dependency tree...
> 1.216 Reading state information...
> 1.311 E: Unable to locate package dotnet-sdk-8.0
> 1.311 E: Couldn't find any package by glob 'dotnet-sdk-8.0'
> 1.311 E: Couldn't find any package by regex 'dotnet-sdk-8.0'
> 1.311 E: Unable to locate package dotnet-runtime-8.0
> 1.311 E: Couldn't find any package by glob 'dotnet-runtime-8.0'
> 1.311 E: Couldn't find any package by regex 'dotnet-runtime-8.0'
> 1.311 E: Unable to locate package aspnetcore-runtime-8.0
> 1.311 E: Couldn't find any package by glob 'aspnetcore-runtime-8.0'
> 1.311 E: Couldn't find any package by regex 'aspnetcore-runtime-8.0'
> 1.311 E: Unable to locate package dotnet-apphost-pack-8.0
> 1.311 E: Couldn't find any package by glob 'dotnet-apphost-pack-8.0'
> 1.311 E: Couldn't find any package by regex 'dotnet-apphost-pack-8.0'
> --
> Dockerfile:134
>
> 133 |
> 134 | >>> RUN apt-get install -y --no-install-recommends \
> 135 | >>> `# dotnet core dependencies` \
> 136 | >>> dotnet-sdk-8.0 \
> 137 | >>> dotnet-runtime-8.0 \
> 138 | >>> aspnetcore-runtime-8.0 \
> 139 | >>> dotnet-apphost-pack-8.0
> 140 |
>
> ERROR: failed to solve: process "/bin/sh -c apt-get install -y
> --no-install-recommends `# dotnet core dependencies`
> dotnet-sdk-8.0 dotnet-runtime-8.0 aspnetcore-runtime-8.0
> dotnet-apphost-pack-8.0" did not complete successfully: exit code: 100
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (THRIFT-5755) Docker image build fail
[
https://issues.apache.org/jira/browse/THRIFT-5755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820375#comment-17820375
]
Volodymyr Panivko edited comment on THRIFT-5755 at 2/24/24 4:36 PM:
directory with old docker appears in tasks
THRIFT-5633
THRIFT-4717
THRIFT-4579
[https://github.com/apache/thrift/pull/2663]
Maybe we can fully remove old directory?
was (Author: sveneld):
directory with old docker appears in tasks
THRIFT-5633
THRIFT-4717
THRIFT-4579
https://github.com/apache/thrift/pull/2663
> Docker image build fail
> ---
>
> Key: THRIFT-5755
> URL: https://issues.apache.org/jira/browse/THRIFT-5755
> Project: Thrift
> Issue Type: Bug
> Environment: Ubuntu 22.04
>Reporter: Volodymyr Panivko
>Priority: Major
>
> When I'm trying to build an docker image and run command
> {code:java}
> docker build -t thrift build/docker/ubuntu-bionic{code}
> I get such error
>
> {code:java}
>
> => ERROR [13/35] RUN apt-get install -y --no-install-recommends `#
> dotnet core dependencies` dotnet-sdk-8.0 dotnet-runtime-8.0
> aspnetcore-runtime-8.0 dotnet-apphost-pack-8.0 1.3s
> --
> > [13/35] RUN apt-get install -y --no-install-recommends `# dotnet
> core dependencies` dotnet-sdk-8.0 dotnet-runtime-8.0
> aspnetcore-runtime-8.0 dotnet-apphost-pack-8.0:
> 0.350 Reading package lists...
> 1.113 Building dependency tree...
> 1.216 Reading state information...
> 1.311 E: Unable to locate package dotnet-sdk-8.0
> 1.311 E: Couldn't find any package by glob 'dotnet-sdk-8.0'
> 1.311 E: Couldn't find any package by regex 'dotnet-sdk-8.0'
> 1.311 E: Unable to locate package dotnet-runtime-8.0
> 1.311 E: Couldn't find any package by glob 'dotnet-runtime-8.0'
> 1.311 E: Couldn't find any package by regex 'dotnet-runtime-8.0'
> 1.311 E: Unable to locate package aspnetcore-runtime-8.0
> 1.311 E: Couldn't find any package by glob 'aspnetcore-runtime-8.0'
> 1.311 E: Couldn't find any package by regex 'aspnetcore-runtime-8.0'
> 1.311 E: Unable to locate package dotnet-apphost-pack-8.0
> 1.311 E: Couldn't find any package by glob 'dotnet-apphost-pack-8.0'
> 1.311 E: Couldn't find any package by regex 'dotnet-apphost-pack-8.0'
> --
> Dockerfile:134
>
> 133 |
> 134 | >>> RUN apt-get install -y --no-install-recommends \
> 135 | >>> `# dotnet core dependencies` \
> 136 | >>> dotnet-sdk-8.0 \
> 137 | >>> dotnet-runtime-8.0 \
> 138 | >>> aspnetcore-runtime-8.0 \
> 139 | >>> dotnet-apphost-pack-8.0
> 140 |
>
> ERROR: failed to solve: process "/bin/sh -c apt-get install -y
> --no-install-recommends `# dotnet core dependencies`
> dotnet-sdk-8.0 dotnet-runtime-8.0 aspnetcore-runtime-8.0
> dotnet-apphost-pack-8.0" did not complete successfully: exit code: 100
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (THRIFT-5755) Docker image build fail
[
https://issues.apache.org/jira/browse/THRIFT-5755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820375#comment-17820375
]
Volodymyr Panivko commented on THRIFT-5755:
---
directory with old docker appears in tasks
THRIFT-5633
THRIFT-4717
THRIFT-4579
https://github.com/apache/thrift/pull/2663
> Docker image build fail
> ---
>
> Key: THRIFT-5755
> URL: https://issues.apache.org/jira/browse/THRIFT-5755
> Project: Thrift
> Issue Type: Bug
> Environment: Ubuntu 22.04
>Reporter: Volodymyr Panivko
>Priority: Major
>
> When I'm trying to build an docker image and run command
> {code:java}
> docker build -t thrift build/docker/ubuntu-bionic{code}
> I get such error
>
> {code:java}
>
> => ERROR [13/35] RUN apt-get install -y --no-install-recommends `#
> dotnet core dependencies` dotnet-sdk-8.0 dotnet-runtime-8.0
> aspnetcore-runtime-8.0 dotnet-apphost-pack-8.0 1.3s
> --
> > [13/35] RUN apt-get install -y --no-install-recommends `# dotnet
> core dependencies` dotnet-sdk-8.0 dotnet-runtime-8.0
> aspnetcore-runtime-8.0 dotnet-apphost-pack-8.0:
> 0.350 Reading package lists...
> 1.113 Building dependency tree...
> 1.216 Reading state information...
> 1.311 E: Unable to locate package dotnet-sdk-8.0
> 1.311 E: Couldn't find any package by glob 'dotnet-sdk-8.0'
> 1.311 E: Couldn't find any package by regex 'dotnet-sdk-8.0'
> 1.311 E: Unable to locate package dotnet-runtime-8.0
> 1.311 E: Couldn't find any package by glob 'dotnet-runtime-8.0'
> 1.311 E: Couldn't find any package by regex 'dotnet-runtime-8.0'
> 1.311 E: Unable to locate package aspnetcore-runtime-8.0
> 1.311 E: Couldn't find any package by glob 'aspnetcore-runtime-8.0'
> 1.311 E: Couldn't find any package by regex 'aspnetcore-runtime-8.0'
> 1.311 E: Unable to locate package dotnet-apphost-pack-8.0
> 1.311 E: Couldn't find any package by glob 'dotnet-apphost-pack-8.0'
> 1.311 E: Couldn't find any package by regex 'dotnet-apphost-pack-8.0'
> --
> Dockerfile:134
>
> 133 |
> 134 | >>> RUN apt-get install -y --no-install-recommends \
> 135 | >>> `# dotnet core dependencies` \
> 136 | >>> dotnet-sdk-8.0 \
> 137 | >>> dotnet-runtime-8.0 \
> 138 | >>> aspnetcore-runtime-8.0 \
> 139 | >>> dotnet-apphost-pack-8.0
> 140 |
>
> ERROR: failed to solve: process "/bin/sh -c apt-get install -y
> --no-install-recommends `# dotnet core dependencies`
> dotnet-sdk-8.0 dotnet-runtime-8.0 aspnetcore-runtime-8.0
> dotnet-apphost-pack-8.0" did not complete successfully: exit code: 100
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (THRIFT-5755) Docker image build fail
[
https://issues.apache.org/jira/browse/THRIFT-5755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820373#comment-17820373
]
Volodymyr Panivko commented on THRIFT-5755:
---
{code:java}
$ docker run -v $(pwd):/thrift/src:rw -it thrift/thrift-build:ubuntu-bionic
/bin/bash
root@8b4101188aa2:/thrift/src# ./bootstrap.sh && ./configure && make dist {code}
this command download a prepared container, but also give an error
{code:java}
.
make dist-gzip am__post_remove_distdir='@:'
make[1]: Entering directory '/thrift/src'
if test -d "thrift-0.21.0"; then find "thrift-0.21.0" -type d ! -perm -200
-exec chmod u+w {} ';' && rm -rf "thrift-0.21.0" || { sleep 5 && rm -rf
"thrift-0.21.0"; }; else :; fi
test -d "thrift-0.21.0" || mkdir "thrift-0.21.0"
(cd compiler/cpp && make top_distdir=../../thrift-0.21.0
distdir=../../thrift-0.21.0/compiler/cpp \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory '/thrift/src/compiler/cpp'
(cd src && make top_distdir=../../../thrift-0.21.0
distdir=../../../thrift-0.21.0/compiler/cpp/src \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory '/thrift/src/compiler/cpp/src'
/bin/bash ../../../ylwrap thrift/thriftl.ll lex.yy.c thrift/thriftl.cc -- flex
/bin/bash ../../../ylwrap thrift/thrifty.yy y.tab.c thrift/thrifty.cc y.tab.h
`echo thrift/thrifty.cc | sed -e s/cc$/hh/ -e s/cpp$/hpp/ -e s/cxx$/hxx/ -e
s/c++$/h++/ -e s/c$/h/` y.output thrift/thrifty.output -- bison -y -d
updating thrift/thrifty.hh
make[3]: Leaving directory '/thrift/src/compiler/cpp/src'
(cd test && make top_distdir=../../../thrift-0.21.0
distdir=../../../thrift-0.21.0/compiler/cpp/test \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory '/thrift/src/compiler/cpp/test'
make[3]: Leaving directory '/thrift/src/compiler/cpp/test'
make[2]: Leaving directory '/thrift/src/compiler/cpp'
(cd lib && make top_distdir=../thrift-0.21.0 distdir=../thrift-0.21.0/lib \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory '/thrift/src/lib'
(cd json && make top_distdir=../../thrift-0.21.0
distdir=../../thrift-0.21.0/lib/json \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory '/thrift/src/lib/json'
(cd test && make top_distdir=../../../thrift-0.21.0
distdir=../../../thrift-0.21.0/lib/json/test \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory '/thrift/src/lib/json/test'
make[4]: Leaving directory '/thrift/src/lib/json/test'
make \
top_distdir="../../thrift-0.21.0" distdir="../../thrift-0.21.0/lib/json" \
dist-hook
make[4]: Entering directory '/thrift/src/lib/json'
rm -f -r ../../thrift-0.21.0/lib/json/test/build/
make[4]: Leaving directory '/thrift/src/lib/json'
make[3]: Leaving directory '/thrift/src/lib/json'
(cd xml && make top_distdir=../../thrift-0.21.0
distdir=../../thrift-0.21.0/lib/xml \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory '/thrift/src/lib/xml'
(cd test && make top_distdir=../../../thrift-0.21.0
distdir=../../../thrift-0.21.0/lib/xml/test \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory '/thrift/src/lib/xml/test'
make[4]: Leaving directory '/thrift/src/lib/xml/test'
make[3]: Leaving directory '/thrift/src/lib/xml'
(cd cpp && make top_distdir=../../thrift-0.21.0
distdir=../../thrift-0.21.0/lib/cpp \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory '/thrift/src/lib/cpp'
(cd test && make top_distdir=../../../thrift-0.21.0
distdir=../../../thrift-0.21.0/lib/cpp/test \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory '/thrift/src/lib/cpp/test'
make[4]: Leaving directory '/thrift/src/lib/cpp/test'
make[3]: Leaving directory '/thrift/src/lib/cpp'
(cd c_glib && make top_distdir=../../thrift-0.21.0
distdir=../../thrift-0.21.0/lib/c_glib \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory '/thrift/src/lib/c_glib'
(cd test && make top_distdir=../../../thrift-0.21.0
distdir=../../../thrift-0.21.0/lib/c_glib/test \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory '/thrift/src/lib/c_glib/test'
make[4]: Leaving directory '/thrift/src/lib/c_glib/test'
make[3]: Leaving directory '/thrift/src/lib/c_glib'
(cd java && make top_distdir=../../thrift-0.21.0
distdir=../../thrift-0.21.0/lib/java \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory
[jira] [Assigned] (THRIFT-5759) PHP mbstring.func_overload is deprecated
[ https://issues.apache.org/jira/browse/THRIFT-5759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volodymyr Panivko reassigned THRIFT-5759: - Assignee: Volodymyr Panivko > PHP mbstring.func_overload is deprecated > > > Key: THRIFT-5759 > URL: https://issues.apache.org/jira/browse/THRIFT-5759 > Project: Thrift > Issue Type: Improvement > Components: PHP - Library >Reporter: Volodymyr Panivko >Assignee: Volodymyr Panivko >Priority: Major > > During implementation of unit tests for PHP lib was discovered that lib using > deprecated functionality. It should be fixed > [https://www.php.net/manual/en/mbstring.overload.php] > *Warning* > This feature has been _DEPRECATED_ as of PHP 7.2.0, and _REMOVED_ as of PHP > 8.0.0. Relying on this feature is highly discouraged. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (THRIFT-5760) Update minimal version of php
[ https://issues.apache.org/jira/browse/THRIFT-5760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volodymyr Panivko reassigned THRIFT-5760: - Assignee: Volodymyr Panivko > Update minimal version of php > - > > Key: THRIFT-5760 > URL: https://issues.apache.org/jira/browse/THRIFT-5760 > Project: Thrift > Issue Type: Improvement > Components: PHP - Library >Reporter: Volodymyr Panivko >Assignee: Volodymyr Panivko >Priority: Major > Labels: breaking_change > Time Spent: 20m > Remaining Estimate: 0h > > Update minimal version of php to 7.1 > I know that currently 8.* is main version, but current code has to much > dependencies on version 5, so let's move step by step. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (THRIFT-5757) Unit tests for php lib
[ https://issues.apache.org/jira/browse/THRIFT-5757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820368#comment-17820368 ] Volodymyr Panivko commented on THRIFT-5757: --- [~jensg] i create task on update minimal php version THRIFT-5760 and pull request for it https://github.com/apache/thrift/pull/2936 > Unit tests for php lib > -- > > Key: THRIFT-5757 > URL: https://issues.apache.org/jira/browse/THRIFT-5757 > Project: Thrift > Issue Type: New Feature > Components: PHP - Library >Reporter: Volodymyr Panivko >Assignee: Volodymyr Panivko >Priority: Major > Attachments: image-2024-02-24-10-41-37-836.png > > Time Spent: 3h > Remaining Estimate: 0h > > After running PHP unit tests for each pull request THRIFT-5756 > Next step is writing test for php lib. > It will be several pull request for this task. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (THRIFT-5760) Update minimal version of php
[ https://issues.apache.org/jira/browse/THRIFT-5760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820365#comment-17820365 ] Volodymyr Panivko commented on THRIFT-5760: --- I mark issue with label breaking_change because it will drop supporting of php version less than 7.1 > Update minimal version of php > - > > Key: THRIFT-5760 > URL: https://issues.apache.org/jira/browse/THRIFT-5760 > Project: Thrift > Issue Type: Improvement > Components: PHP - Library >Reporter: Volodymyr Panivko >Priority: Major > Labels: breaking_change > > Update minimal version of php to 7.1 > I know that currently 8.* is main version, but current code has to much > dependencies on version 5, so let's move step by step. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (THRIFT-5760) Update minimal version of php
[ https://issues.apache.org/jira/browse/THRIFT-5760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volodymyr Panivko updated THRIFT-5760: -- Labels: breaking_change (was: ) > Update minimal version of php > - > > Key: THRIFT-5760 > URL: https://issues.apache.org/jira/browse/THRIFT-5760 > Project: Thrift > Issue Type: Improvement > Components: PHP - Library >Reporter: Volodymyr Panivko >Priority: Major > Labels: breaking_change > > Update minimal version of php to 7.1 > I know that currently 8.* is main version, but current code has to much > dependencies on version 5, so let's move step by step. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (THRIFT-5760) Update minimal version of php
Volodymyr Panivko created THRIFT-5760: - Summary: Update minimal version of php Key: THRIFT-5760 URL: https://issues.apache.org/jira/browse/THRIFT-5760 Project: Thrift Issue Type: Improvement Components: PHP - Library Reporter: Volodymyr Panivko Update minimal version of php to 7.1 I know that currently 8.* is main version, but current code has to much dependencies on version 5, so let's move step by step. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (THRIFT-5757) Unit tests for php lib
[
https://issues.apache.org/jira/browse/THRIFT-5757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820318#comment-17820318
]
Volodymyr Panivko commented on THRIFT-5757:
---
{quote}Could you try to contact INFRA about this?
{quote}
I create an issue INFRA-25541
> Unit tests for php lib
> --
>
> Key: THRIFT-5757
> URL: https://issues.apache.org/jira/browse/THRIFT-5757
> Project: Thrift
> Issue Type: New Feature
> Components: PHP - Library
>Reporter: Volodymyr Panivko
>Assignee: Volodymyr Panivko
>Priority: Major
> Attachments: image-2024-02-24-10-41-37-836.png
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> After running PHP unit tests for each pull request THRIFT-5756
> Next step is writing test for php lib.
> It will be several pull request for this task.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (THRIFT-5757) Unit tests for php lib
[
https://issues.apache.org/jira/browse/THRIFT-5757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820298#comment-17820298
]
Volodymyr Panivko commented on THRIFT-5757:
---
{quote}If it is EOL and makes problems why don't we drop support for it from
current development branch?
{quote}
It will be great to remove support php5.6 and make min supported version 7.0.
It will make much easy migration to php8. We still need 7.0 for a migration
process
> Unit tests for php lib
> --
>
> Key: THRIFT-5757
> URL: https://issues.apache.org/jira/browse/THRIFT-5757
> Project: Thrift
> Issue Type: New Feature
> Components: PHP - Library
>Reporter: Volodymyr Panivko
>Assignee: Volodymyr Panivko
>Priority: Major
> Attachments: image-2024-02-24-10-41-37-836.png
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> After running PHP unit tests for each pull request THRIFT-5756
> Next step is writing test for php lib.
> It will be several pull request for this task.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (THRIFT-5757) Unit tests for php lib
[ https://issues.apache.org/jira/browse/THRIFT-5757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820297#comment-17820297 ] Volodymyr Panivko commented on THRIFT-5757: --- I'm subscribed, and already write a letter the list, but i does not appear in it. !image-2024-02-24-10-41-37-836.png! > Unit tests for php lib > -- > > Key: THRIFT-5757 > URL: https://issues.apache.org/jira/browse/THRIFT-5757 > Project: Thrift > Issue Type: New Feature > Components: PHP - Library >Reporter: Volodymyr Panivko >Assignee: Volodymyr Panivko >Priority: Major > Attachments: image-2024-02-24-10-41-37-836.png > > Time Spent: 3h > Remaining Estimate: 0h > > After running PHP unit tests for each pull request THRIFT-5756 > Next step is writing test for php lib. > It will be several pull request for this task. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (THRIFT-5757) Unit tests for php lib
[ https://issues.apache.org/jira/browse/THRIFT-5757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volodymyr Panivko updated THRIFT-5757: -- Attachment: image-2024-02-24-10-41-37-836.png > Unit tests for php lib > -- > > Key: THRIFT-5757 > URL: https://issues.apache.org/jira/browse/THRIFT-5757 > Project: Thrift > Issue Type: New Feature > Components: PHP - Library >Reporter: Volodymyr Panivko >Assignee: Volodymyr Panivko >Priority: Major > Attachments: image-2024-02-24-10-41-37-836.png > > Time Spent: 3h > Remaining Estimate: 0h > > After running PHP unit tests for each pull request THRIFT-5756 > Next step is writing test for php lib. > It will be several pull request for this task. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (THRIFT-5759) PHP mbstring.func_overload is deprecated
[ https://issues.apache.org/jira/browse/THRIFT-5759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volodymyr Panivko updated THRIFT-5759: -- Issue Type: Improvement (was: New Feature) > PHP mbstring.func_overload is deprecated > > > Key: THRIFT-5759 > URL: https://issues.apache.org/jira/browse/THRIFT-5759 > Project: Thrift > Issue Type: Improvement > Components: PHP - Library >Reporter: Volodymyr Panivko >Priority: Major > > During implementation of unit tests for PHP lib was discovered that lib using > deprecated functionality. It should be fixed > [https://www.php.net/manual/en/mbstring.overload.php] > *Warning* > This feature has been _DEPRECATED_ as of PHP 7.2.0, and _REMOVED_ as of PHP > 8.0.0. Relying on this feature is highly discouraged. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (THRIFT-5759) PHP mbstring.func_overload is deprecated
Volodymyr Panivko created THRIFT-5759: - Summary: PHP mbstring.func_overload is deprecated Key: THRIFT-5759 URL: https://issues.apache.org/jira/browse/THRIFT-5759 Project: Thrift Issue Type: New Feature Components: PHP - Library Reporter: Volodymyr Panivko During implementation of unit tests for PHP lib was discovered that lib using deprecated functionality. It should be fixed [https://www.php.net/manual/en/mbstring.overload.php] *Warning* This feature has been _DEPRECATED_ as of PHP 7.2.0, and _REMOVED_ as of PHP 8.0.0. Relying on this feature is highly discouraged. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (THRIFT-5757) Unit tests for php lib
[ https://issues.apache.org/jira/browse/THRIFT-5757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819987#comment-17819987 ] Volodymyr Panivko commented on THRIFT-5757: --- [~jensg] i have no rights to write to dev list so i will write it here. It will be great if this information will appear in dev maillist *PHP Lib update road map* PHP Lib in Thrift project currently supports many PHP versions, which is EOL, it gives many troubles, because in the new PHP version many changes are provided and many old possibilities become deprecated. Some examples of such errors: https://issues.apache.org/jira/browse/THRIFT-5723 https://issues.apache.org/jira/browse/THRIFT-5758 https://issues.apache.org/jira/browse/THRIFT-5754 https://issues.apache.org/jira/browse/THRIFT-5753 So I offer to remove support of php less than 8.0 My plan is: - add running of unit tests in php lib for every pull request (done https://issues.apache.org/jira/browse/THRIFT-5756) - add full coverage by tests for php lib (start https://issues.apache.org/jira/browse/THRIFT-5757) - remove old autoload code, one big Thrift.php from scr and use only lib as only one source of code - remove support of php5 in composer.json and set minimal version to php7.4 - update code for using new features from php7 syntax - update generation of code to new php7 syntax - remove support of php7 in composer.json and set minimal version to php8.1 - update code for using new features from php8 syntax - update generation of code to new php8 syntax - add PSR-12 as code style for project - add check of code style to github actions - add PSR-12 as code style for generated classes Please write your opinion. And I will be very glad if someone will help me with test writing. > Unit tests for php lib > -- > > Key: THRIFT-5757 > URL: https://issues.apache.org/jira/browse/THRIFT-5757 > Project: Thrift > Issue Type: New Feature > Components: PHP - Library >Reporter: Volodymyr Panivko >Assignee: Volodymyr Panivko >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > After running PHP unit tests for each pull request THRIFT-5756 > Next step is writing test for php lib. > It will be several pull request for this task. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (THRIFT-5755) Docker image build fail
[
https://issues.apache.org/jira/browse/THRIFT-5755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819923#comment-17819923
]
Volodymyr Panivko commented on THRIFT-5755:
---
I have a few questions:
* if travis does not use anymore for release procedure, maybe configuration
files of travis should be removed from project?
* build/docker/old - what about this folder, does this docker images is still
needed?
* and what about the original problem, i cannot build container due to the
error, who can help with it?
> Docker image build fail
> ---
>
> Key: THRIFT-5755
> URL: https://issues.apache.org/jira/browse/THRIFT-5755
> Project: Thrift
> Issue Type: Bug
> Environment: Ubuntu 22.04
>Reporter: Volodymyr Panivko
>Priority: Major
>
> When I'm trying to build an docker image and run command
> {code:java}
> docker build -t thrift build/docker/ubuntu-bionic{code}
> I get such error
>
> {code:java}
>
> => ERROR [13/35] RUN apt-get install -y --no-install-recommends `#
> dotnet core dependencies` dotnet-sdk-8.0 dotnet-runtime-8.0
> aspnetcore-runtime-8.0 dotnet-apphost-pack-8.0 1.3s
> --
> > [13/35] RUN apt-get install -y --no-install-recommends `# dotnet
> core dependencies` dotnet-sdk-8.0 dotnet-runtime-8.0
> aspnetcore-runtime-8.0 dotnet-apphost-pack-8.0:
> 0.350 Reading package lists...
> 1.113 Building dependency tree...
> 1.216 Reading state information...
> 1.311 E: Unable to locate package dotnet-sdk-8.0
> 1.311 E: Couldn't find any package by glob 'dotnet-sdk-8.0'
> 1.311 E: Couldn't find any package by regex 'dotnet-sdk-8.0'
> 1.311 E: Unable to locate package dotnet-runtime-8.0
> 1.311 E: Couldn't find any package by glob 'dotnet-runtime-8.0'
> 1.311 E: Couldn't find any package by regex 'dotnet-runtime-8.0'
> 1.311 E: Unable to locate package aspnetcore-runtime-8.0
> 1.311 E: Couldn't find any package by glob 'aspnetcore-runtime-8.0'
> 1.311 E: Couldn't find any package by regex 'aspnetcore-runtime-8.0'
> 1.311 E: Unable to locate package dotnet-apphost-pack-8.0
> 1.311 E: Couldn't find any package by glob 'dotnet-apphost-pack-8.0'
> 1.311 E: Couldn't find any package by regex 'dotnet-apphost-pack-8.0'
> --
> Dockerfile:134
>
> 133 |
> 134 | >>> RUN apt-get install -y --no-install-recommends \
> 135 | >>> `# dotnet core dependencies` \
> 136 | >>> dotnet-sdk-8.0 \
> 137 | >>> dotnet-runtime-8.0 \
> 138 | >>> aspnetcore-runtime-8.0 \
> 139 | >>> dotnet-apphost-pack-8.0
> 140 |
>
> ERROR: failed to solve: process "/bin/sh -c apt-get install -y
> --no-install-recommends `# dotnet core dependencies`
> dotnet-sdk-8.0 dotnet-runtime-8.0 aspnetcore-runtime-8.0
> dotnet-apphost-pack-8.0" did not complete successfully: exit code: 100
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (THRIFT-5758) PHP 8.2 Deprecate dynamic properties
Volodymyr Panivko created THRIFT-5758: - Summary: PHP 8.2 Deprecate dynamic properties Key: THRIFT-5758 URL: https://issues.apache.org/jira/browse/THRIFT-5758 Project: Thrift Issue Type: New Feature Components: PHP - Library Reporter: Volodymyr Panivko In php 8.2 dynamic properties will generate a deprecation [https://www.php.net/releases/8.2/en.php#deprecate_dynamic_properties] In Tbase and TException dynamic properties is used. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (THRIFT-5758) PHP 8.2 Deprecate dynamic properties
[ https://issues.apache.org/jira/browse/THRIFT-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volodymyr Panivko reassigned THRIFT-5758: - Assignee: Volodymyr Panivko > PHP 8.2 Deprecate dynamic properties > > > Key: THRIFT-5758 > URL: https://issues.apache.org/jira/browse/THRIFT-5758 > Project: Thrift > Issue Type: New Feature > Components: PHP - Library >Reporter: Volodymyr Panivko >Assignee: Volodymyr Panivko >Priority: Major > > In php 8.2 dynamic properties will generate a deprecation > [https://www.php.net/releases/8.2/en.php#deprecate_dynamic_properties] > > In Tbase and TException dynamic properties is used. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (THRIFT-5757) Unit tests for php lib
Volodymyr Panivko created THRIFT-5757: - Summary: Unit tests for php lib Key: THRIFT-5757 URL: https://issues.apache.org/jira/browse/THRIFT-5757 Project: Thrift Issue Type: New Feature Components: PHP - Library Reporter: Volodymyr Panivko Assignee: Volodymyr Panivko After running PHP unit tests for each pull request THRIFT-5756 Next step is writing test for php lib. It will be several pull request for this task. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (THRIFT-5756) Run php tests in github actions
Volodymyr Panivko created THRIFT-5756: - Summary: Run php tests in github actions Key: THRIFT-5756 URL: https://issues.apache.org/jira/browse/THRIFT-5756 Project: Thrift Issue Type: New Feature Components: PHP - Library Reporter: Volodymyr Panivko Assignee: Volodymyr Panivko Before updating minimum version of php to 7.4 or 8.0 we should start running php tests on every pull request. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (THRIFT-5755) Docker image build fail
[
https://issues.apache.org/jira/browse/THRIFT-5755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818543#comment-17818543
]
Volodymyr Panivko commented on THRIFT-5755:
---
But what about development on local machines? Using Docker it's very comfortable
> Docker image build fail
> ---
>
> Key: THRIFT-5755
> URL: https://issues.apache.org/jira/browse/THRIFT-5755
> Project: Thrift
> Issue Type: Bug
> Environment: Ubuntu 22.04
>Reporter: Volodymyr Panivko
>Priority: Major
>
> When I'm trying to build an docker image and run command
> {code:java}
> docker build -t thrift build/docker/ubuntu-bionic{code}
> I get such error
>
> {code:java}
>
> => ERROR [13/35] RUN apt-get install -y --no-install-recommends `#
> dotnet core dependencies` dotnet-sdk-8.0 dotnet-runtime-8.0
> aspnetcore-runtime-8.0 dotnet-apphost-pack-8.0 1.3s
> --
> > [13/35] RUN apt-get install -y --no-install-recommends `# dotnet
> core dependencies` dotnet-sdk-8.0 dotnet-runtime-8.0
> aspnetcore-runtime-8.0 dotnet-apphost-pack-8.0:
> 0.350 Reading package lists...
> 1.113 Building dependency tree...
> 1.216 Reading state information...
> 1.311 E: Unable to locate package dotnet-sdk-8.0
> 1.311 E: Couldn't find any package by glob 'dotnet-sdk-8.0'
> 1.311 E: Couldn't find any package by regex 'dotnet-sdk-8.0'
> 1.311 E: Unable to locate package dotnet-runtime-8.0
> 1.311 E: Couldn't find any package by glob 'dotnet-runtime-8.0'
> 1.311 E: Couldn't find any package by regex 'dotnet-runtime-8.0'
> 1.311 E: Unable to locate package aspnetcore-runtime-8.0
> 1.311 E: Couldn't find any package by glob 'aspnetcore-runtime-8.0'
> 1.311 E: Couldn't find any package by regex 'aspnetcore-runtime-8.0'
> 1.311 E: Unable to locate package dotnet-apphost-pack-8.0
> 1.311 E: Couldn't find any package by glob 'dotnet-apphost-pack-8.0'
> 1.311 E: Couldn't find any package by regex 'dotnet-apphost-pack-8.0'
> --
> Dockerfile:134
>
> 133 |
> 134 | >>> RUN apt-get install -y --no-install-recommends \
> 135 | >>> `# dotnet core dependencies` \
> 136 | >>> dotnet-sdk-8.0 \
> 137 | >>> dotnet-runtime-8.0 \
> 138 | >>> aspnetcore-runtime-8.0 \
> 139 | >>> dotnet-apphost-pack-8.0
> 140 |
>
> ERROR: failed to solve: process "/bin/sh -c apt-get install -y
> --no-install-recommends `# dotnet core dependencies`
> dotnet-sdk-8.0 dotnet-runtime-8.0 aspnetcore-runtime-8.0
> dotnet-apphost-pack-8.0" did not complete successfully: exit code: 100
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (THRIFT-5755) Docker image build fail
Volodymyr Panivko created THRIFT-5755:
-
Summary: Docker image build fail
Key: THRIFT-5755
URL: https://issues.apache.org/jira/browse/THRIFT-5755
Project: Thrift
Issue Type: Bug
Environment: Ubuntu 22.04
Reporter: Volodymyr Panivko
When I'm trying to build an docker image and run command
{code:java}
docker build -t thrift build/docker/ubuntu-bionic{code}
I get such error
{code:java}
=> ERROR [13/35] RUN apt-get install -y --no-install-recommends `#
dotnet core dependencies` dotnet-sdk-8.0 dotnet-runtime-8.0
aspnetcore-runtime-8.0 dotnet-apphost-pack-8.0 1.3s
--
> [13/35] RUN apt-get install -y --no-install-recommends `# dotnet core
dependencies` dotnet-sdk-8.0 dotnet-runtime-8.0
aspnetcore-runtime-8.0 dotnet-apphost-pack-8.0:
0.350 Reading package lists...
1.113 Building dependency tree...
1.216 Reading state information...
1.311 E: Unable to locate package dotnet-sdk-8.0
1.311 E: Couldn't find any package by glob 'dotnet-sdk-8.0'
1.311 E: Couldn't find any package by regex 'dotnet-sdk-8.0'
1.311 E: Unable to locate package dotnet-runtime-8.0
1.311 E: Couldn't find any package by glob 'dotnet-runtime-8.0'
1.311 E: Couldn't find any package by regex 'dotnet-runtime-8.0'
1.311 E: Unable to locate package aspnetcore-runtime-8.0
1.311 E: Couldn't find any package by glob 'aspnetcore-runtime-8.0'
1.311 E: Couldn't find any package by regex 'aspnetcore-runtime-8.0'
1.311 E: Unable to locate package dotnet-apphost-pack-8.0
1.311 E: Couldn't find any package by glob 'dotnet-apphost-pack-8.0'
1.311 E: Couldn't find any package by regex 'dotnet-apphost-pack-8.0'
--
Dockerfile:134
133 |
134 | >>> RUN apt-get install -y --no-install-recommends \
135 | >>> `# dotnet core dependencies` \
136 | >>> dotnet-sdk-8.0 \
137 | >>> dotnet-runtime-8.0 \
138 | >>> aspnetcore-runtime-8.0 \
139 | >>> dotnet-apphost-pack-8.0
140 |
ERROR: failed to solve: process "/bin/sh -c apt-get install -y
--no-install-recommends `# dotnet core dependencies` dotnet-sdk-8.0
dotnet-runtime-8.0 aspnetcore-runtime-8.0
dotnet-apphost-pack-8.0" did not complete successfully: exit code: 100
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (THRIFT-5753) PHP 8.1 deprecated warning about return type in jsonSerialize functions
[
https://issues.apache.org/jira/browse/THRIFT-5753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805907#comment-17805907
]
Volodymyr Panivko commented on THRIFT-5753:
---
In current version of php many functions received more strict type hint, some
functions become deprecated. It will be better to remove support of php5 and
move to 7.4 for better compatibility in future.
I think it's better to start with writing unit test for current realization and
after that we can change code for 7.4
> PHP 8.1 deprecated warning about return type in jsonSerialize functions
> ---
>
> Key: THRIFT-5753
> URL: https://issues.apache.org/jira/browse/THRIFT-5753
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Library
>Reporter: Pavel Kvach
>Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In PHP 8.1 a "mixed" return type was added to the
> "JsonSerializable::jsonSerialize()" method.
> This triggers a deprecation warning for generated PHP classes:
> {code:java}
> Return type of TestClass::jsonSerialize() should either be compatible with
> JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange]
> attribute should be used to temporarily suppress the notice in ...{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (THRIFT-5753) PHP 8.1 deprecated warning about return type in jsonSerialize functions
[
https://issues.apache.org/jira/browse/THRIFT-5753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805415#comment-17805415
]
Volodymyr Panivko commented on THRIFT-5753:
---
I also get such error
PHP Deprecated: strlen(): Passing null to parameter #1 ($string) of type string
is deprecated in Thrift/StringFunc/Core.php on line 38
Maybe code should be inspected on compatibility with php8.1? And maybe the
minimal version of php should be updated to 7.4 or better 8.0?
> PHP 8.1 deprecated warning about return type in jsonSerialize functions
> ---
>
> Key: THRIFT-5753
> URL: https://issues.apache.org/jira/browse/THRIFT-5753
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Library
>Reporter: Pavel Kvach
>Priority: Minor
>
> In PHP 8.1 a "mixed" return type was added to the
> "JsonSerializable::jsonSerialize()" method.
> This triggers a deprecation warning for generated PHP classes:
> {code:java}
> Return type of TestClass::jsonSerialize() should either be compatible with
> JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange]
> attribute should be used to temporarily suppress the notice in ...{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (THRIFT-5752) Add TTransportFactoryInterface
Volodymyr Panivko created THRIFT-5752: - Summary: Add TTransportFactoryInterface Key: THRIFT-5752 URL: https://issues.apache.org/jira/browse/THRIFT-5752 Project: Thrift Issue Type: Improvement Components: PHP - Library Affects Versions: 0.19.0 Reporter: Volodymyr Panivko Assignee: Volodymyr Panivko Fix For: 0.20.0 I'm offer to add TTransportFactoryInterface for having a possibility to use own implementation of TTransportFactory in TServer. I have a problem when I'm tried to make a TSimpleServer for client who used a TFramedTransport. Current realization of TTransportFactory does not give me a possibility to add a TFramedTransport as a decorator for use TTransport -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (THRIFT-5723) Php8.1 fix warnings
Volodymyr Panivko created THRIFT-5723: - Summary: Php8.1 fix warnings Key: THRIFT-5723 URL: https://issues.apache.org/jira/browse/THRIFT-5723 Project: Thrift Issue Type: Improvement Reporter: Volodymyr Panivko Assignee: Volodymyr Panivko In PHP 8.1 when creating new Exception with null message you will receive warning E_DEPRECATED: Exception::__construct(): Passing null to parameter #1 ($message) of type string is deprecated -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (THRIFT-4793) Drop PHP support for versions before 7.1
[ https://issues.apache.org/jira/browse/THRIFT-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17274025#comment-17274025 ] Volodymyr Panivko commented on THRIFT-4793: --- Maybe it is time for reopen this task? > Drop PHP support for versions before 7.1 > > > Key: THRIFT-4793 > URL: https://issues.apache.org/jira/browse/THRIFT-4793 > Project: Thrift > Issue Type: Improvement > Components: PHP - Library >Affects Versions: 0.12.0 >Reporter: James E. King III >Assignee: James E. King III >Priority: Major > Labels: Breaking-Change > > Support for PHP 7.1 ended December 2018 Security support runs until DEC 2019. > All PHP development should be on PHP 7.2 or later. > phpunit version 8 is the current version and we're using 4.8. phpunit8 > requires PHP 7.2. > phpunit7 requires php 7.1 and has fewer breaking changes. > These changes will drop support for PHP < 7.1. Ubuntu xenial build job will > stop building php. > Folks who need PHP support for versions before 7.1 can use version 0.12.0 > which is already released. > The code may actually work, but we should keep up with the ecosystem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (THRIFT-5336) Add possibility to setup connection timeout in TCurlClient
Volodymyr Panivko created THRIFT-5336: - Summary: Add possibility to setup connection timeout in TCurlClient Key: THRIFT-5336 URL: https://issues.apache.org/jira/browse/THRIFT-5336 Project: Thrift Issue Type: Improvement Components: PHP - Library Affects Versions: 0.13.0 Reporter: Volodymyr Panivko In TCurlClient we can set only total timeout, it will be great to have opportunity to set connection timeout -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (THRIFT-5132) Warning in TSocket when using ssl connection
Volodymyr Panivko created THRIFT-5132:
-
Summary: Warning in TSocket when using ssl connection
Key: THRIFT-5132
URL: https://issues.apache.org/jira/browse/THRIFT-5132
Project: Thrift
Issue Type: Bug
Components: PHP - Library
Affects Versions: 0.13.0
Reporter: Volodymyr Panivko
When you using ssl host in
new TSocket('ssl://test.com')
you will get a warning
PHP Warning: socket_import_stream(): cannot represent a stream of type
tcp_socket/ssl as a Socket Descriptor in
/usr/share/php/Thrift/Transport/TSocket.php on line 254
due to the bug [https://bugs.php.net/bug.php?id=70939]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (THRIFT-5130) Use Apcu instead of APC
Volodymyr Panivko created THRIFT-5130: - Summary: Use Apcu instead of APC Key: THRIFT-5130 URL: https://issues.apache.org/jira/browse/THRIFT-5130 Project: Thrift Issue Type: Improvement Components: PHP - Library Affects Versions: 0.13.0 Reporter: Volodymyr Panivko [https://pecl.php.net/package/APC] does not maintained anymore, so it's better to change using it to [https://pecl.php.net/package/APCu] -- This message was sent by Atlassian Jira (v8.3.4#803005)
