[GitHub] thrift issue #1522: THRIFT-4530: add @Nullable annotations to generated Java...
Github user msridhar commented on the issue: https://github.com/apache/thrift/pull/1522 Hrm, now I see a concurrency test failure on appveyor. Doesn't seem related to my change, though I'm not 100% sure. ---
[GitHub] thrift issue #1522: THRIFT-4530: add @Nullable annotations to generated Java...
Github user msridhar commented on the issue: https://github.com/apache/thrift/pull/1522 I just pushed up another commit with the renaming. I assume you can do a squash and merge, but if you'd like me to squash just let me know. ---
[GitHub] thrift issue #1522: THRIFT-4530: add @Nullable annotations to generated Java...
Github user msridhar commented on the issue: https://github.com/apache/thrift/pull/1522 Looks like the Travis failure is on Common Lisp codegen (https://api.travis-ci.org/v3/job/359136811/log.txt), which has nothing to do with this PR ---
[GitHub] thrift issue #1522: THRIFT-4530: add @Nullable annotations to generated Java...
Github user msridhar commented on the issue: https://github.com/apache/thrift/pull/1522 Note that while there are no new tests, the code under `tutorial/java/gen-java` includes the annotations and compiles without issue. Since this change doesn't affect runtime behavior of the generated code I think this might be sufficient. ---
[GitHub] thrift pull request #1522: THRIFT-4530: add @Nullable annotations to generat...
GitHub user msridhar opened a pull request: https://github.com/apache/thrift/pull/1522 THRIFT-4530: add @Nullable annotations to generated Java code Use our own `org.apache.thrift.annotations.Nullable` annotation to avoid introducing a third-party dependency You can merge this pull request into a Git repository by running: $ git pull https://github.com/msridhar/thrift THRIFT-4530 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1522.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1522 commit 6bc560a1a55a1fca720b4fe7057f25c06fc358d1 Author: Manu Sridharan <msridhar@...> Date: 2018-03-20T21:45:22Z THRIFT-4530: add @Nullable annotations to generated Java code Use our own `org.apache.thrift.annotations.Nullable` type to avoid introducing a third-party dependency ---
