[GitHub] thrift issue #1084: THRIFT-3773 Swift 3 Native Library
Github user tbartelmess commented on the issue: https://github.com/apache/thrift/pull/1084 Any movement on this? I'd love to see this merged. ---
[GitHub] thrift pull request: THRIFT-3538 Removed UnboundMethodType
GitHub user tbartelmess opened a pull request: https://github.com/apache/thrift/pull/783 THRIFT-3538 Removed UnboundMethodType https://issues.apache.org/jira/browse/THRIFT-3538 You can merge this pull request into a Git repository by running: $ git pull https://github.com/tbartelmess/thrift THRIFT-3538 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/783.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #783 commit 05524dc16bddb60868d1bab4a0376a3182e737e0 Author: Thomas Bartelmess <tbartelm...@marketcircle.com> Date: 2016-01-10T16:34:19Z Removed UnboundMethodType https://issues.apache.org/jira/browse/THRIFT-3538 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: THRIFT-3539 Use self.process_foo instead of P...
GitHub user tbartelmess opened a pull request: https://github.com/apache/thrift/pull/784 THRIFT-3539 Use self.process_foo instead of Processor.process_foo https://issues.apache.org/jira/browse/THRIFT-3539 You can merge this pull request into a Git repository by running: $ git pull https://github.com/tbartelmess/thrift THRIFT-3539 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/784.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #784 commit 07e13aeda01387114d06ccfd6b57b21d81855c48 Author: Thomas Bartelmess <tbartelm...@marketcircle.com> Date: 2016-01-10T16:48:02Z Use self.process_foo instead of Processor.process_foo THRIFT-3539 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: THRIFT-3121 Librt does not exist on OSX
GitHub user tbartelmess opened a pull request: https://github.com/apache/thrift/pull/475 THRIFT-3121 Librt does not exist on OSX librt does not exist on Mac OS X. Compilation with CMake failed. THRIFT-3121 You can merge this pull request into a Git repository by running: $ git pull https://github.com/tbartelmess/thrift THRIFT-3121 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/475.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #475 commit eef499b9ce0824625f30eb35b8fb39051938e638 Author: Thomas Bartelmess tbartelm...@marketcircle.com Date: 2015-05-01T17:57:44Z THRIFT-3121 Librt does not exist on OSX --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: Python 3 support
Github user tbartelmess commented on a diff in the pull request: https://github.com/apache/thrift/pull/144#discussion_r14326386 --- Diff: lib/py/src/protocol/TBinaryProtocol.py --- @@ -119,8 +119,8 @@ def writeDouble(self, dub): self.trans.write(buff) def writeString(self, str): -self.writeI32(len(str)) -self.trans.write(str) +self.writeI32(len(bytearray(str,'utf-8'))) +self.trans.write(bytearray(str,'utf-8')) --- End diff -- @eevee In Python3 not explicitly encoding it will cause it use the return value of __str__ which will cause it to return b'value' --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
