[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...

[xiaohu-zhang]

Github user xiaohu-zhang commented on the issue:

https://github.com/apache/thrift/pull/1313
  
Thank you ! honestly speaking , netty and lots of framework implementing 
this fix. I also doubt
It is useful in jdk7. I agree with you ,But if I was you , I will not 
change the original code,unless give
the unit test to prove it happend in jdk7


---

[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...

[jeking3]

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1313
  
It means nobody replied to my requests for comments, so I assumed nobody
has an issue or nobody cares; whatever the case, I committed it to the
project. :)

On Thu, Sep 21, 2017 at 9:33 PM, xiaohu-zhang 
wrote:

> MY english is poor. could you please explain what is the it's been
> crickets mean ? thank you very much!
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---

[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...

[xiaohu-zhang]

Github user xiaohu-zhang commented on the issue:

https://github.com/apache/thrift/pull/1313
  
MY english is poor. could you please explain what is the it's been crickets 
mean ? thank you very much!


---

[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...

[jeking3]

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1313
  
So I asked on the mailing list and it's been crickets, so I'm going to 
merge this.  It passed all the tests.


---

[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...

[jeking3]

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1313
  
I'd like additional feedback from folks who use Thrift with Java on this.  
It seems like the wrong place to fix the issue, but it sounds like many 
projects are implementing their own fix for it.  I've never seen it happen.


---

[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...

[xiaohu-zhang]

Github user xiaohu-zhang commented on the issue:

https://github.com/apache/thrift/pull/1313
  
http://bugs.java.com/bugdatabase/view_bug.do?bug_id=6403933
it sounds like have been resolved yet in jdk7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...

[xiaohu-zhang]

Github user xiaohu-zhang commented on the issue:

https://github.com/apache/thrift/pull/1313
  
http://bugs.java.com/bugdatabase/view_bug.do?bug_id=6403933


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...

[Johnny-Liao]

Github user Johnny-Liao commented on the issue:

https://github.com/apache/thrift/pull/1313
  
It's not elegant way to rebuild Selector in every Java program, but it's a 
effective way to fix this bug.  And so many year passed it not really fixed in 
JDK or kernel. This is one reason for some Frameworks implemented this 
solution.  After all, the consequences of this bug are too serious.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...

[jeking3]

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1313
  
However, as with all the other issues, they were already resolved, so the 
fact you are still seeing this with a recent kernel and java version means 
there's still a bug that needs to be fixed somewhere.  There shouldn't be a 
workaround in every Java program that uses a Selector().  I would still 
encourage you to come up with a simple example that demonstrates it without 
Thrift involved and report it upstream.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...

[Johnny-Liao]

Github user Johnny-Liao commented on the issue:

https://github.com/apache/thrift/pull/1313
  
I found a report maybe more relevant with this issue. 
See : 
[http://bugs.java.com/bugdatabase/view_bug.do?bug_id=6403933](http://bugs.java.com/bugdatabase/view_bug.do?bug_id=6403933)
It gives a solution what is creates a new Selector to replace the old one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...

[Johnny-Liao]

Github user Johnny-Liao commented on the issue:

https://github.com/apache/thrift/pull/1313
  
My linux kernel is 3.10.0 when this bug occured. And I'm pretty sure that 
still trouble many people who dependence Thrift to implements theirs server 
program. Netty uses this approach to mask the underlying problem and why can't 
we.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...

[jeking3]

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1313
  
According to the documentation of the defect that triggered this 
(http://bugs.java.com/bugdatabase/view_bug.do?bug_id=6670302), it indicates 
this only occurs in kernel 2.4 series, and if you move to kernel 2.6 this issue 
goes away.  Given this is an operating system defect, I'm inclined to recommend 
we do not merge this and resolve it as won't fix, because it isn't a defect in 
Thrift or in Java, but rather in the operating system it is running on.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---