[GitHub] thrift issue #1454: THRIFT-4436: port nodejs changes from THRIFT-3748 to js ...

2018-01-05 Thread bananer 
Github user bananer commented on the issue:

https://github.com/apache/thrift/pull/1454
  
rebased as https://github.com/apache/thrift/pull/1457


---

[GitHub] thrift issue #1454: THRIFT-4436: port nodejs changes from THRIFT-3748 to js ...

2018-01-04 Thread jeking3 
Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1454
  
Suggest you rebase on master, as the fix for the build issue with dart was 
merged, and it would be nice to see a clean build.


---