[GitHub] thrift issue #1458: THRIFT-4390: Fix bug where binary/buffered messages > 4K...

2018-01-12 Thread allengeorge 
Github user allengeorge commented on the issue:

https://github.com/apache/thrift/pull/1458
  
@jeking3 Looks like everything passed, so this patch is good to go. TY!


---

[GitHub] thrift issue #1458: THRIFT-4390: Fix bug where binary/buffered messages > 4K...

2018-01-11 Thread allengeorge 
Github user allengeorge commented on the issue:

https://github.com/apache/thrift/pull/1458
  
@jeking3 Thank you!

So...updated the PR to re-add the three failing tests. Created 
[THRIFT-4451](https://issues.apache.org/jira/browse/THRIFT-4451) to track this. 
I'm going to fix up the framed transport first, circle back to 4451, and then 
handle dart/c++ issues.


---

[GitHub] thrift issue #1458: THRIFT-4390: Fix bug where binary/buffered messages > 4K...

2018-01-10 Thread jeking3 
Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1458
  
Sure - I like progress. :)


---

[GitHub] thrift issue #1458: THRIFT-4390: Fix bug where binary/buffered messages > 4K...

2018-01-09 Thread allengeorge 
Github user allengeorge commented on the issue:

https://github.com/apache/thrift/pull/1458
  
@jeking3 This seems like a separate problem unfortunately. I'd removed 
three tests from the "known failures list" and it appears there's a specific 
problem related to multiplexed processors and c_glib/perl. That was an 
oversight :/

I'd suggest the following course of action:

1. I re-add those three test failures to the "known failures" list
2. I fix up the framed test failures with > 4k long messages; I have a 
patch for this already
3. I add a JIRA for the multiplexed failures and fix that in a separate PR

Let me know if this is acceptable to you, and I'll go about doing that.


---

[GitHub] thrift issue #1458: THRIFT-4390: Fix bug where binary/buffered messages > 4K...

2018-01-07 Thread allengeorge 
Github user allengeorge commented on the issue:

https://github.com/apache/thrift/pull/1458
  
@jeking3 This seems like a separate problem unfortunately. I'd removed 
three tests from the "known failures list" and it appears there's a specific 
problem related to multiplexed processors and c_glib/perl. That was an 
oversight :/

I'd suggest the following course of action:

1. I re-add those three test failures to the "known failures" list
2. I fix up the framed test failures with > 4k long messages; I have a 
patch for this already
3. I add a JIRA for the multiplexed failures and fix that in a separate PR

Let me know if this is acceptable to you, and I'll go about doing that.


---

[GitHub] thrift issue #1458: THRIFT-4390: Fix bug where binary/buffered messages > 4K...

2018-01-05 Thread jeking3 
Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1458
  
There were related cross test errors:
```

===
*** Following 3 failures were unexpected ***:
If it is introduced by you, please fix it before submitting the code.

===
server-client:  protocol: transport:   result:
c_glib-rs   multi buffered-ip  
failure(timeout)
c_glib-rs   multicbuffered-ip  
failure(timeout)
perl-rs multi buffered-ip  
failure(timeout)
```


---

[GitHub] thrift issue #1458: THRIFT-4390: Fix bug where binary/buffered messages > 4K...

2018-01-05 Thread allengeorge 
Github user allengeorge commented on the issue:

https://github.com/apache/thrift/pull/1458
  
One of two fixes for problems noticed by others during cross-tests. I've a 
separate PR for framed transports.


---