[GitHub] thrift issue #1497: Do not call workSocket() in TNonblockigServer without en...
Github user bgedik commented on the issue: https://github.com/apache/thrift/pull/1497 @jeking3 There is already a Jira item: https://issues.apache.org/jira/browse/THRIFT-4465 Btw, it makes sense that the fix resolves the framed transport failures. Because the bug was about the transition from the frame size reading to the frame content reading. ---
[GitHub] thrift issue #1497: Do not call workSocket() in TNonblockigServer without en...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1497 Cool so that last test run was without the fix (I thought it had it, but it only had my fixes to TestServer.cpp), and adding your fix seems to have taken care of the header failures somehow: ``` root@1dcb0ce83732:/thrift/src# test/test.py --server cpp --client cpp --regex='.*framed.*-ip.*' Apache Thrift - Integration Test Suite Sun Mar 11 19:39:18 2018 === server-client: protocol: transport: result: cpp-cpp compact framed-ipsuccess cpp-cpp multi-binary framed-ip-sslsuccess cpp-cpp compact framed-ip-sslsuccess cpp-cpp multi-binary framed-ipsuccess cpp-cpp multihframed-ipsuccess cpp-cpp multihframed-ip-sslsuccess cpp-cpp multih-header framed-ip-sslsuccess cpp-cpp multih-header framed-ipsuccess cpp-cpp multij-json framed-ip-sslsuccess cpp-cpp multij-json framed-ipsuccess cpp-cpp json framed-ip-sslsuccess cpp-cpp json framed-ipsuccess cpp-cpp multicframed-ipsuccess cpp-cpp multicframed-ip-sslsuccess cpp-cpp multic-compactframed-ip-sslsuccess cpp-cpp multic-compactframed-ipsuccess cpp-cpp multij-json framed-ip-sslsuccess cpp-cpp multij-json framed-ipsuccess cpp-cpp multijframed-ip-sslsuccess cpp-cpp multijframed-ipsuccess cpp-cpp headerframed-ip-sslsuccess cpp-cpp headerframed-ipsuccess cpp-cpp multic-compactframed-ip-sslsuccess cpp-cpp multic-compactframed-ipsuccess cpp-cpp multi-binary framed-ip-sslsuccess cpp-cpp multi-binary framed-ipsuccess cpp-cpp multi framed-ipsuccess cpp-cpp multi framed-ip-sslsuccess cpp-cpp multih-header framed-ip-sslsuccess cpp-cpp multih-header framed-ipsuccess cpp-cpp binaryframed-ipsuccess cpp-cpp binaryframed-ip-sslsuccess === No unexpected failures. ``` ---
[GitHub] thrift issue #1497: Do not call workSocket() in TNonblockigServer without en...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1497 You need to create a Jira ticket in the THRIFT project (https://issues.apache.org/jira/projects/THRIFT/issues) that describes the bug and resolution so that I can merge it. --- I was able to test these changes out by making some changes to the cpp TestServer for crosstest which I will check in today. I changed my local tests.json file to add "--server-type=nonblocking" to each cpp server and changed some code to make additional cases work: ``` root@8d560c4cc0fa:/thrift/src# test/test.py --server cpp --client cpp --regex='.*framed.*-ip.*' Apache Thrift - Integration Test Suite Sun Mar 11 14:49:02 2018 === server-client: protocol: transport: result: cpp-cpp compact framed-ipsuccess cpp-cpp multi-binary framed-ipsuccess cpp-cpp compact framed-ip-sslsuccess cpp-cpp multihframed-ip-sslsuccess cpp-cpp multihframed-ipsuccess cpp-cpp multi-binary framed-ip-sslsuccess cpp-cpp multih-header framed-ipsuccess cpp-cpp multih-header framed-ip-sslsuccess cpp-cpp multij-json framed-ip-sslsuccess cpp-cpp multij-json framed-ipsuccess cpp-cpp json framed-ipsuccess cpp-cpp json framed-ip-sslsuccess cpp-cpp multicframed-ipsuccess cpp-cpp multicframed-ip-sslsuccess cpp-cpp multic-compactframed-ipsuccess cpp-cpp multic-compactframed-ip-sslsuccess cpp-cpp multij-json framed-ip-sslsuccess cpp-cpp multij-json framed-ipsuccess cpp-cpp headerframed-ip failure(-6) cpp-cpp multijframed-ipsuccess cpp-cpp multijframed-ip-sslsuccess cpp-cpp headerframed-ip-ssl failure(-6) cpp-cpp multic-compactframed-ipsuccess cpp-cpp multic-compactframed-ip-sslsuccess cpp-cpp multi-binary framed-ip-sslsuccess cpp-cpp multi-binary framed-ipsuccess cpp-cpp multi framed-ip-sslsuccess cpp-cpp multi framed-ipsuccess cpp-cpp multih-header framed-ip-sslsuccess cpp-cpp multih-header framed-ipsuccess cpp-cpp binaryframed-ip-sslsuccess cpp-cpp binaryframed-ipsuccess === ``` (I think you can ignore the header failures) ---
[GitHub] thrift issue #1497: Do not call workSocket() in TNonblockigServer without en...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1497 What's the Jira ticket ID for this work? ---
[GitHub] thrift issue #1497: Do not call workSocket() in TNonblockigServer without en...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1497 Wow, haven't seen a green build in a while. Of course, none of the cross tests exercise nonblocking code. :( Would be nice to add this as another matrix option. ---
[GitHub] thrift issue #1497: Do not call workSocket() in TNonblockigServer without en...
Github user bgedik commented on the issue: https://github.com/apache/thrift/pull/1497 @jeking3 I think all tests have passed. ---
[GitHub] thrift issue #1497: Do not call workSocket() in TNonblockigServer without en...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1497 Rebase on master and let's see what happens, thanks. ---
[GitHub] thrift issue #1497: Do not call workSocket() in TNonblockigServer without en...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1497 I'm not aware of those being common or known. I have a bit of work to do in order to stabilize the CI builds and get them back to green... ---
[GitHub] thrift issue #1497: Do not call workSocket() in TNonblockigServer without en...
Github user ozymaxx commented on the issue: https://github.com/apache/thrift/pull/1497 I also encounter the same error, but it does not show up every time I run the tests on Travis CI. ---
[GitHub] thrift issue #1497: Do not call workSocket() in TNonblockigServer without en...
Github user bgedik commented on the issue: https://github.com/apache/thrift/pull/1497 @jeking3 The ``client_pool_tests`` failed in 2 of the bots within Travis-CI. I don't think it is related to my change. Are these known to fail every now and then? ``` thrift.transport.base.TTransportException@src/thrift/transport/socket.d(255): Failed to connect to 127.0.0.1:9090. ??:? void thrift.transport.socket.TSocket.open() [0x29e331ca] ??:? int thrift.codegen.client_pool.TClientPool!(client_pool_test.ExTestService).TClientPool.executeOnPool!(int).executeOnPool(scope int delegate(thrift.codegen.client.TClientBase!(client_pool_test.ExTestService).TClientBase)) [0x29e204ca] ??:? int thrift.codegen.client_pool.TClientPool!(client_pool_test.ExTestService).TClientPool.getPort() [0x29e08916] ??:? void client_pool_test.syncClientPoolTest(const(ushort)[], client_pool_test.ExTestHandler[]) [0x29df090a] ??:? _Dmain [0x29df077b] thrift.base.TCompoundOperationException@src/thrift/transport/socket.d(256): All addresses tried failed (127.0.0.1:9090: "Unable to connect socket: Connection refused", 127.0.0.1:9090: "Unable to connect socket: Connection refused", 127.0.0.1:9090: "Unable to connect socket: Connection refused"). FAIL: client_pool_test ``` ---
