[GitHub] thrift issue #672: Fix package.json to include only the needed files
Github user zertosh commented on the issue: https://github.com/apache/thrift/pull/672 @jfarrell will do. Made an issue https://issues.apache.org/jira/browse/THRIFT-4064 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #672: Fix package.json to include only the needed files
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/672 @zertosh if you can submit a patch to update the version of ws in use we can look at turning around a 0.11.0 to help out --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #672: Fix package.json to include only the needed files
Github user zertosh commented on the issue: https://github.com/apache/thrift/pull/672 Thanks @jfarrell! @modocache, unfortunately we still can't use this lib. The version of `ws` that it uses is crazy old (v0.4.32 from Aug 2014). Any version prior to [ws@1.0.0](https://github.com/websockets/ws/releases/tag/1.0.0) requires that you compile a few of its third-party deps - major blocker for using internally at FB (toolchain problems, node ABI issues, etc). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #672: Fix package.json to include only the needed files
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/672 done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #672: Fix package.json to include only the needed files
Github user bufferoverflow commented on the issue: https://github.com/apache/thrift/pull/672 @jfarrell you are the npm publisher, could you please push 0.10.0 to the npm registry? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #672: Fix package.json to include only the needed files
Github user modocache commented on the issue: https://github.com/apache/thrift/pull/672 +1 for @zertosh's comment. @bufferoverflow, is there any way for me, a third-party contributor, to help you or other maintainers publish a new version on npm? I'd love to use a version without these unneeded dependencies. Plus, the npm version is 0.9.3, but the Apache Thrift website only provides direct links to 0.10.0 downloads. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
