[GitHub] thrift pull request: Fix THRIFT-3090 (cmake build is broken)
Github user marco-m commented on a diff in the pull request:
https://github.com/apache/thrift/pull/434#discussion_r28203820
--- Diff: lib/cpp/CMakeLists.txt ---
@@ -26,7 +26,7 @@ if(WITH_BOOSTTHREADS)
else()
find_package(Boost 1.53.0 REQUIRED)
endif()
-include_directories(SYSTEM ${Boost_INCLUDE_DIRS})
--- End diff --
I don't need to remove SYSTEM to fix the cmake build on Mac OS X. On the
other hand, I don't see why SYSTEM is needed :-) In any case, this change can
be reverted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Fix THRIFT-3090 (cmake build is broken)
Github user marco-m commented on a diff in the pull request: https://github.com/apache/thrift/pull/434#discussion_r28203837 --- Diff: build/cmake/DefinePlatformSpecifc.cmake --- @@ -58,8 +58,9 @@ if(MSVC) endif(WITH_MT) endif(MSVC) -# GCC Specific -if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX) +# GCC or Clang specific +if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES Clang) --- End diff -- Unfortunately CMAKE_COMPILER_IS_CLANG doesn't exist (or at least didn't exist last time I researched the topic). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: Fix THRIFT-3090 (cmake build is broken)
Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/434#discussion_r28203488 --- Diff: build/cmake/DefinePlatformSpecifc.cmake --- @@ -58,8 +58,9 @@ if(MSVC) endif(WITH_MT) endif(MSVC) -# GCC Specific -if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX) +# GCC or Clang specific +if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES Clang) --- End diff -- does CMAKE_COMPILER_IS_CLANG work as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: Fix THRIFT-3090 (cmake build is broken)
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/434#discussion_r28205720
--- Diff: lib/cpp/CMakeLists.txt ---
@@ -26,7 +26,7 @@ if(WITH_BOOSTTHREADS)
else()
find_package(Boost 1.53.0 REQUIRED)
endif()
-include_directories(SYSTEM ${Boost_INCLUDE_DIRS})
--- End diff --
SYSTEM implies -isystem for gcc/clang thus can avoid polluting log with
warnings from boost.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Fix THRIFT-3090 (cmake build is broken)
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/434#discussion_r28195428
--- Diff: lib/cpp/CMakeLists.txt ---
@@ -26,7 +26,7 @@ if(WITH_BOOSTTHREADS)
else()
find_package(Boost 1.53.0 REQUIRED)
endif()
-include_directories(SYSTEM ${Boost_INCLUDE_DIRS})
--- End diff --
Why do you need to remove SYSTEM ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Fix THRIFT-3090 (cmake build is broken)
GitHub user marco-m opened a pull request: https://github.com/apache/thrift/pull/434 Fix THRIFT-3090 (cmake build is broken) Problem found and fixed on Mac OS X 10.10.3, but at least the link problems must happen on every OS. You can merge this pull request into a Git repository by running: $ git pull https://github.com/marco-m/thrift THRIFT-3090 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/434.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #434 commit 73821578c4f54c36331d522b4cd685af7d539e18 Author: Marco Molteni marco.molt...@laposte.net Date: 2015-04-10T21:51:19Z Fix THRIFT-3090 (cmake build is broken) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
