[GitHub] thrift pull request: Implement Thrift.Protocol.prototype.skip() fo...

2014-06-14 Thread hyungsul 
Github user hyungsul closed the pull request at:

https://github.com/apache/thrift/pull/139


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Implement Thrift.Protocol.prototype.skip() fo...

2014-06-14 Thread hyungsul 
Github user hyungsul commented on the pull request:

https://github.com/apache/thrift/pull/139#issuecomment-46080230
  
I added a ticket in JIRA.
I will pull request again with a proper branch name.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Implement Thrift.Protocol.prototype.skip() fo...

2014-06-12 Thread hyungsul 
GitHub user hyungsul opened a pull request:

https://github.com/apache/thrift/pull/139

Implement Thrift.Protocol.prototype.skip() for JavaScript library

Thrift.Protocol.prototype.skip was not implemented yet. 
Due to the exception that the previous implementation throws, Thrift client 
in JavaScript has issues on backward compatibility.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hyungsul/thrift master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/139.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #139


commit 38009c61735c5a16bbeb215d2db6a95daaa4d734
Author: Hyungsul Kim hyungsul@gmail.com
Date:   2014-06-12T14:16:43Z

Implement Thrift.Protocol.prototype.skip() for JavaScript library

commit 0bf49f5add3f0161347d26230069a070ab220379
Author: Hyungsul Kim hyungsul@gmail.com
Date:   2014-06-12T14:20:10Z

Update the comments




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Implement Thrift.Protocol.prototype.skip() fo...

2014-06-12 Thread hyungsul 
Github user hyungsul closed the pull request at:

https://github.com/apache/thrift/pull/139


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Implement Thrift.Protocol.prototype.skip() fo...

2014-06-12 Thread Jens-G 
Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/139#issuecomment-45955651
  
[Could you add an JIRA 
ticket?](http://thrift.apache,.org/docs/HowToContribute)? 
Furthermore, an associated test case would be great as well!
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---