[GitHub] thrift pull request: THRIFT-3214 Add Erlang option for using maps ...
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/535 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request: THRIFT-3214 Add Erlang option for using maps ...
Github user jparise commented on a diff in the pull request:
https://github.com/apache/thrift/pull/535#discussion_r33729457
--- Diff: compiler/cpp/src/generate/t_erl_generator.cc ---
@@ -55,6 +55,7 @@ class t_erl_generator : public t_generator {
out_dir_base_ = gen-erl;
legacy_names_ = (parsed_options.find(legacynames) !=
parsed_options.end());
+use_maps_ = (parsed_options.find(usemaps) != parsed_options.end());
--- End diff --
I think `maps` would be a more consistent option name. Similar existing
options are `slots` (for Python) and `templates` (for C++), which don't include
a **use** prefix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3214 Add Erlang option for using maps ...
Github user thecodeboss commented on a diff in the pull request:
https://github.com/apache/thrift/pull/535#discussion_r33730165
--- Diff: compiler/cpp/src/generate/t_erl_generator.cc ---
@@ -55,6 +55,7 @@ class t_erl_generator : public t_generator {
out_dir_base_ = gen-erl;
legacy_names_ = (parsed_options.find(legacynames) !=
parsed_options.end());
+use_maps_ = (parsed_options.find(usemaps) != parsed_options.end());
--- End diff --
Great catch @jparise, the PR has been modified with your suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3214 Add Erlang option for using maps ...
GitHub user thecodeboss opened a pull request: https://github.com/apache/thrift/pull/535 THRIFT-3214 Add Erlang option for using maps instead of dicts Erlang OTP 18 introduces significant performance improvements when using maps instead of dicts. Here is a benchmark showing the gains: https://gist.github.com/BinaryMuse/bb9f2cbf692e6cfa4841 Thrift should support an option for the Erlang compiler to produce maps instead of dicts, to take advantage of these performance improvements. You can merge this pull request into a Git repository by running: $ git pull https://github.com/thecodeboss/thrift THRIFT-3214 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/535.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #535 commit 969e1fb45ca6423d2d4353d154f7cb6f861f4bb5 Author: Michael Oliver mikemboli...@gmail.com Date: 2015-07-01T00:22:54Z THRIFT-3214 Add Erlang option for using maps instead of dicts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
