[GitHub] thrift pull request #1522: THRIFT-4530: add @Nullable annotations to generat...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1522


---

[GitHub] thrift pull request #1522: THRIFT-4530: add @Nullable annotations to generat...

[jeking3]

Github user jeking3 commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1522#discussion_r177720513
  
--- Diff: lib/java/src/org/apache/thrift/annotations/Nullable.java ---
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.thrift.annotations;
--- End diff --

Any reason why java language uses "annotation" but you selected 
"annotations" for thrift?  Seems like we should be using "annotation".


---

[GitHub] thrift pull request #1522: THRIFT-4530: add @Nullable annotations to generat...

[msridhar]

GitHub user msridhar opened a pull request:

https://github.com/apache/thrift/pull/1522

THRIFT-4530: add @Nullable annotations to generated Java code

Use our own `org.apache.thrift.annotations.Nullable` annotation to avoid
introducing a third-party dependency

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/msridhar/thrift THRIFT-4530

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1522.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1522


commit 6bc560a1a55a1fca720b4fe7057f25c06fc358d1
Author: Manu Sridharan 
Date:   2018-03-20T21:45:22Z

THRIFT-4530: add @Nullable annotations to generated Java code

Use our own `org.apache.thrift.annotations.Nullable` type to avoid
introducing a third-party dependency




---