[jira] [Commented] (THRIFT-2145) Rack and Thin are not just development dependencies
[ https://issues.apache.org/jira/browse/THRIFT-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14195629#comment-14195629 ] Adam Duke commented on THRIFT-2145: --- Any progress on releasing this? Coming up on a year since it was committed according to https://github.com/apache/thrift/commit/cba92b308f894ef02b89c23ea6179faff6138772, but I don't see it in rubygems. Rack and Thin are not just development dependencies --- Key: THRIFT-2145 URL: https://issues.apache.org/jira/browse/THRIFT-2145 Project: Thrift Issue Type: Bug Components: Ruby - Library Affects Versions: 0.9.1 Environment: Mac OS X and Linux, Ruby v1.9.3 Reporter: Keith Barrette Assignee: Jake Farrell Fix For: 0.9.2 Attachments: 0001-Require-thin-server-in-spec-that-uses-it.patch, thrift-0.9.1-rack-thin-dependency.patch The rack and thin gems should be specified as full dependencies, not just development dependencies. This is causing runtime errors when requiring thrift. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2145) Rack and Thin are not just development dependencies
[ https://issues.apache.org/jira/browse/THRIFT-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14195689#comment-14195689 ] Jake Farrell commented on THRIFT-2145: -- 0.9.2-rc0 had some issues with it and we have worked through them, i'm testing the 0.9.2-rc1 as we speak and hope to have it out for a vote in the next day or so Rack and Thin are not just development dependencies --- Key: THRIFT-2145 URL: https://issues.apache.org/jira/browse/THRIFT-2145 Project: Thrift Issue Type: Bug Components: Ruby - Library Affects Versions: 0.9.1 Environment: Mac OS X and Linux, Ruby v1.9.3 Reporter: Keith Barrette Assignee: Jake Farrell Fix For: 0.9.2 Attachments: 0001-Require-thin-server-in-spec-that-uses-it.patch, thrift-0.9.1-rack-thin-dependency.patch The rack and thin gems should be specified as full dependencies, not just development dependencies. This is causing runtime errors when requiring thrift. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2145) Rack and Thin are not just development dependencies
[ https://issues.apache.org/jira/browse/THRIFT-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955645#comment-13955645 ] Jared Szechy commented on THRIFT-2145: -- This resolves the issue of not requiring thin however this is still broken as it has not been released yet. It's been 4 months since this was fixed and no release? As far as I can tell there is no development gem that I can use in my Gemfile either. I'm running in an environment where I CANNOT use thin so this whole gem is unusable until this require is removed. Rack and Thin are not just development dependencies --- Key: THRIFT-2145 URL: https://issues.apache.org/jira/browse/THRIFT-2145 Project: Thrift Issue Type: Bug Components: Ruby - Library Affects Versions: 0.9.1 Environment: Mac OS X and Linux, Ruby v1.9.3 Reporter: Keith Barrette Assignee: Jake Farrell Fix For: 0.9.2 Attachments: 0001-Require-thin-server-in-spec-that-uses-it.patch, thrift-0.9.1-rack-thin-dependency.patch The rack and thin gems should be specified as full dependencies, not just development dependencies. This is causing runtime errors when requiring thrift. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (THRIFT-2145) Rack and Thin are not just development dependencies
[ https://issues.apache.org/jira/browse/THRIFT-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13955666#comment-13955666 ] Jake Farrell commented on THRIFT-2145: -- we are preparing for our 0.9.2 release candidate and would expect this to be available soon Rack and Thin are not just development dependencies --- Key: THRIFT-2145 URL: https://issues.apache.org/jira/browse/THRIFT-2145 Project: Thrift Issue Type: Bug Components: Ruby - Library Affects Versions: 0.9.1 Environment: Mac OS X and Linux, Ruby v1.9.3 Reporter: Keith Barrette Assignee: Jake Farrell Fix For: 0.9.2 Attachments: 0001-Require-thin-server-in-spec-that-uses-it.patch, thrift-0.9.1-rack-thin-dependency.patch The rack and thin gems should be specified as full dependencies, not just development dependencies. This is causing runtime errors when requiring thrift. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (THRIFT-2145) Rack and Thin are not just development dependencies
[ https://issues.apache.org/jira/browse/THRIFT-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13831643#comment-13831643 ] Matt Gillooly commented on THRIFT-2145: --- +1 Nick and Andrew. I've got a gem which requires thrift. We had added rack and thin as dependencies of that gem to get around this issue. We now wish to use that gem in a JRuby environment, where thin is not available, so I'm forced to either fork the thrift gem or add a dummy thin.rb to my gem. Neither of these seem reasonable, when there is a simple fix in the attached patch above. Rack and Thin are not just development dependencies --- Key: THRIFT-2145 URL: https://issues.apache.org/jira/browse/THRIFT-2145 Project: Thrift Issue Type: Bug Components: Ruby - Library Affects Versions: 0.9.1 Environment: Mac OS X and Linux, Ruby v1.9.3 Reporter: Keith Barrette Assignee: Jake Farrell Attachments: 0001-Require-thin-server-in-spec-that-uses-it.patch, thrift-0.9.1-rack-thin-dependency.patch The rack and thin gems should be specified as full dependencies, not just development dependencies. This is causing runtime errors when requiring thrift. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (THRIFT-2145) Rack and Thin are not just development dependencies
[ https://issues.apache.org/jira/browse/THRIFT-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13831683#comment-13831683 ] Andrew Bloomgarden commented on THRIFT-2145: That would probably work, but I don't think it's necessary. I don't think it's asking too much of people who need a Thin-based server to require it themselves. Rack and Thin are not just development dependencies --- Key: THRIFT-2145 URL: https://issues.apache.org/jira/browse/THRIFT-2145 Project: Thrift Issue Type: Bug Components: Ruby - Library Affects Versions: 0.9.1 Environment: Mac OS X and Linux, Ruby v1.9.3 Reporter: Keith Barrette Assignee: Jake Farrell Attachments: 0001-Require-thin-server-in-spec-that-uses-it.patch, thrift-0.9.1-rack-thin-dependency.patch The rack and thin gems should be specified as full dependencies, not just development dependencies. This is causing runtime errors when requiring thrift. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (THRIFT-2145) Rack and Thin are not just development dependencies
[ https://issues.apache.org/jira/browse/THRIFT-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13831678#comment-13831678 ] Jake Farrell commented on THRIFT-2145: -- Instead of removing from thrift.rb we could check for thin with something like the following, thoughts? require 'thrift/server/thin_http_server' if defined?(Rack::Handler::Thin) Rack and Thin are not just development dependencies --- Key: THRIFT-2145 URL: https://issues.apache.org/jira/browse/THRIFT-2145 Project: Thrift Issue Type: Bug Components: Ruby - Library Affects Versions: 0.9.1 Environment: Mac OS X and Linux, Ruby v1.9.3 Reporter: Keith Barrette Assignee: Jake Farrell Attachments: 0001-Require-thin-server-in-spec-that-uses-it.patch, thrift-0.9.1-rack-thin-dependency.patch The rack and thin gems should be specified as full dependencies, not just development dependencies. This is causing runtime errors when requiring thrift. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (THRIFT-2145) Rack and Thin are not just development dependencies
[ https://issues.apache.org/jira/browse/THRIFT-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13831685#comment-13831685 ] Matt Gillooly commented on THRIFT-2145: --- I agree with Andrew. 0001-Require-thin-server-in-spec-that-uses-it.patch looks like a simple fix which has been sitting around for 3 months. Rack and Thin are not just development dependencies --- Key: THRIFT-2145 URL: https://issues.apache.org/jira/browse/THRIFT-2145 Project: Thrift Issue Type: Bug Components: Ruby - Library Affects Versions: 0.9.1 Environment: Mac OS X and Linux, Ruby v1.9.3 Reporter: Keith Barrette Assignee: Jake Farrell Attachments: 0001-Require-thin-server-in-spec-that-uses-it.patch, thrift-0.9.1-rack-thin-dependency.patch The rack and thin gems should be specified as full dependencies, not just development dependencies. This is causing runtime errors when requiring thrift. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (THRIFT-2145) Rack and Thin are not just development dependencies
[ https://issues.apache.org/jira/browse/THRIFT-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13831768#comment-13831768 ] Andrew Bloomgarden commented on THRIFT-2145: Thank you! Rack and Thin are not just development dependencies --- Key: THRIFT-2145 URL: https://issues.apache.org/jira/browse/THRIFT-2145 Project: Thrift Issue Type: Bug Components: Ruby - Library Affects Versions: 0.9.1 Environment: Mac OS X and Linux, Ruby v1.9.3 Reporter: Keith Barrette Assignee: Jake Farrell Fix For: 0.9.2 Attachments: 0001-Require-thin-server-in-spec-that-uses-it.patch, thrift-0.9.1-rack-thin-dependency.patch The rack and thin gems should be specified as full dependencies, not just development dependencies. This is causing runtime errors when requiring thrift. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (THRIFT-2145) Rack and Thin are not just development dependencies
[ https://issues.apache.org/jira/browse/THRIFT-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13831797#comment-13831797 ] Matt Gillooly commented on THRIFT-2145: --- Thanks! Rack and Thin are not just development dependencies --- Key: THRIFT-2145 URL: https://issues.apache.org/jira/browse/THRIFT-2145 Project: Thrift Issue Type: Bug Components: Ruby - Library Affects Versions: 0.9.1 Environment: Mac OS X and Linux, Ruby v1.9.3 Reporter: Keith Barrette Assignee: Jake Farrell Fix For: 0.9.2 Attachments: 0001-Require-thin-server-in-spec-that-uses-it.patch, thrift-0.9.1-rack-thin-dependency.patch The rack and thin gems should be specified as full dependencies, not just development dependencies. This is causing runtime errors when requiring thrift. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (THRIFT-2145) Rack and Thin are not just development dependencies
[ https://issues.apache.org/jira/browse/THRIFT-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832095#comment-13832095 ] Hudson commented on THRIFT-2145: FAILURE: Integrated in Thrift #944 (See [https://builds.apache.org/job/Thrift/944/]) THRIFT-2145:Rack and Thin are not just development dependencies (jfarrell: rev cba92b308f894ef02b89c23ea6179faff6138772) * lib/rb/spec/thin_http_server_spec.rb * lib/rb/lib/thrift.rb * lib/rb/thrift.gemspec Rack and Thin are not just development dependencies --- Key: THRIFT-2145 URL: https://issues.apache.org/jira/browse/THRIFT-2145 Project: Thrift Issue Type: Bug Components: Ruby - Library Affects Versions: 0.9.1 Environment: Mac OS X and Linux, Ruby v1.9.3 Reporter: Keith Barrette Assignee: Jake Farrell Fix For: 0.9.2 Attachments: 0001-Require-thin-server-in-spec-that-uses-it.patch, thrift-0.9.1-rack-thin-dependency.patch The rack and thin gems should be specified as full dependencies, not just development dependencies. This is causing runtime errors when requiring thrift. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (THRIFT-2145) Rack and Thin are not just development dependencies
[ https://issues.apache.org/jira/browse/THRIFT-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794338#comment-13794338 ] Andrew Bloomgarden commented on THRIFT-2145: Note that MongrelHttpServer wasn't being required by thrift.rb, so you didn't need to install Mongrel to use thrift. Since the thin-based server is meant to replace the Mongrel-based one, it should act the same way. Anyways, this change broke backwards compatibility in a point release. Please fix it, and not by just adding thin as a runtime dependency. Rack and Thin are not just development dependencies --- Key: THRIFT-2145 URL: https://issues.apache.org/jira/browse/THRIFT-2145 Project: Thrift Issue Type: Bug Components: Ruby - Library Affects Versions: 0.9.1 Environment: Mac OS X and Linux, Ruby v1.9.3 Reporter: Keith Barrette Attachments: 0001-Require-thin-server-in-spec-that-uses-it.patch, thrift-0.9.1-rack-thin-dependency.patch The rack and thin gems should be specified as full dependencies, not just development dependencies. This is causing runtime errors when requiring thrift. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (THRIFT-2145) Rack and Thin are not just development dependencies
[ https://issues.apache.org/jira/browse/THRIFT-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13748925#comment-13748925 ] Jake Farrell commented on THRIFT-2145: -- We cant just remove entirely and only offer as a testing dependency as thin_http_server.rb uses it, probably should be moved to a dependency. Also should delete the deprecated mongrel_http_server.rb Rack and Thin are not just development dependencies --- Key: THRIFT-2145 URL: https://issues.apache.org/jira/browse/THRIFT-2145 Project: Thrift Issue Type: Bug Components: Ruby - Library Affects Versions: 0.9.1 Environment: Mac OS X and Linux, Ruby v1.9.3 Reporter: Keith Barrette Attachments: 0001-Require-thin-server-in-spec-that-uses-it.patch, thrift-0.9.1-rack-thin-dependency.patch The rack and thin gems should be specified as full dependencies, not just development dependencies. This is causing runtime errors when requiring thrift. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-2145) Rack and Thin are not just development dependencies
[ https://issues.apache.org/jira/browse/THRIFT-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13748933#comment-13748933 ] Nick Sieger commented on THRIFT-2145: - It would be up to the consumer of thrift to require thin if they are going to use thin_http_server.rb. If I have no plan to use thin at runtime why should Thrift require me to install it? Rack and Thin are not just development dependencies --- Key: THRIFT-2145 URL: https://issues.apache.org/jira/browse/THRIFT-2145 Project: Thrift Issue Type: Bug Components: Ruby - Library Affects Versions: 0.9.1 Environment: Mac OS X and Linux, Ruby v1.9.3 Reporter: Keith Barrette Attachments: 0001-Require-thin-server-in-spec-that-uses-it.patch, thrift-0.9.1-rack-thin-dependency.patch The rack and thin gems should be specified as full dependencies, not just development dependencies. This is causing runtime errors when requiring thrift. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
