[jira] [Commented] (THRIFT-3225) Fix TPipeServer unpredictable behavior on interrupt()
[ https://issues.apache.org/jira/browse/THRIFT-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14629697#comment-14629697 ] Ben Craig commented on THRIFT-3225: --- Resolved in the same patch as THRIFT-3224 Fix TPipeServer unpredictable behavior on interrupt() - Key: THRIFT-3225 URL: https://issues.apache.org/jira/browse/THRIFT-3225 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.2 Environment: Windows Reporter: Paweł Janicki Assignee: Paweł Janicki Priority: Critical Labels: patch Fix For: 0.9.3 Attachments: 0001-THRIFT-3225.-cpp-Fix-TPipeServer-unpredictable-behav.patch, 0002-THRIFT-3225.-cpp-Fix-TPipeServer-unpredictable-behav.patch If TPipeServer::interrupt() is invoked from other thread than the thread that is blocked on TPipeServer::serve() the handle may be closed by interrupting thread while still used by servicing thread. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3225) Fix TPipeServer unpredictable behavior on interrupt()
[ https://issues.apache.org/jira/browse/THRIFT-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623326#comment-14623326 ] Jens Geyer commented on THRIFT-3225: Not really, no. Could be worth to include them into the cross test. We don't have that much languages with Anon/Named Pipes support yet, but since they are just great for Windows-based programs, I expect to get more support for them sooner or later. Today we have them in C++, C# and Delphi - the latter not being covered by the cross test at all, unfortunately. But that's another story. Fix TPipeServer unpredictable behavior on interrupt() - Key: THRIFT-3225 URL: https://issues.apache.org/jira/browse/THRIFT-3225 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.2 Environment: Windows Reporter: Paweł Janicki Assignee: Paweł Janicki Priority: Critical Labels: patch Fix For: 0.9.3 Attachments: 0001-THRIFT-3225.-cpp-Fix-TPipeServer-unpredictable-behav.patch, 0002-THRIFT-3225.-cpp-Fix-TPipeServer-unpredictable-behav.patch If TPipeServer::interrupt() is invoked from other thread than the thread that is blocked on TPipeServer::serve() the handle may be closed by interrupting thread while still used by servicing thread. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3225) Fix TPipeServer unpredictable behavior on interrupt()
[ https://issues.apache.org/jira/browse/THRIFT-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621951#comment-14621951 ] Paweł Janicki commented on THRIFT-3225: --- Are there any existing tests for NamedPipes while now I'm writing my own ad-hoc tests. The implementation seems to have very low coverage. Fix TPipeServer unpredictable behavior on interrupt() - Key: THRIFT-3225 URL: https://issues.apache.org/jira/browse/THRIFT-3225 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.2 Environment: Windows Reporter: Paweł Janicki Assignee: Paweł Janicki Priority: Critical Labels: patch Fix For: 0.9.3 Attachments: 0001-THRIFT-3225.-cpp-Fix-TPipeServer-unpredictable-behav.patch, 0002-THRIFT-3225.-cpp-Fix-TPipeServer-unpredictable-behav.patch If TPipeServer::interrupt() is invoked from other thread than the thread that is blocked on TPipeServer::serve() the handle may be closed by interrupting thread while still used by servicing thread. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3225) Fix TPipeServer unpredictable behavior on interrupt()
[ https://issues.apache.org/jira/browse/THRIFT-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621624#comment-14621624 ] Ben Craig commented on THRIFT-3225: --- This might be right. I'm going to try to dig up (and main line) some TPipe tests. I'll then stare at the code some more. At first glance though, it seems reasonable. Fix TPipeServer unpredictable behavior on interrupt() - Key: THRIFT-3225 URL: https://issues.apache.org/jira/browse/THRIFT-3225 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.2 Environment: Windows Reporter: Paweł Janicki Assignee: Paweł Janicki Priority: Critical Labels: patch Fix For: 0.9.3 Attachments: 0001-THRIFT-3225.-cpp-Fix-TPipeServer-unpredictable-behav.patch, 0002-THRIFT-3225.-cpp-Fix-TPipeServer-unpredictable-behav.patch If TPipeServer::interrupt() is invoked from other thread than the thread that is blocked on TPipeServer::serve() the handle may be closed by interrupting thread while still used by servicing thread. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3225) Fix TPipeServer unpredictable behavior on interrupt()
[ https://issues.apache.org/jira/browse/THRIFT-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14620025#comment-14620025 ] Paweł Janicki commented on THRIFT-3225: --- I rebased to latest master. The patch 0001 is to be abadoned then. Changed description. (for future: Should I open new issue and abadon this or update this issue, if changed the issue description?) There is similiar problem with interrupt() then. The handle may be closed by interrupting thread while still used by servicing thread. Fix TPipeServer unpredictable behavior on interrupt() - Key: THRIFT-3225 URL: https://issues.apache.org/jira/browse/THRIFT-3225 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.2 Environment: Windows Reporter: Paweł Janicki Assignee: Paweł Janicki Priority: Critical Labels: patch Fix For: 0.9.3 Attachments: 0001-THRIFT-3225.-cpp-Fix-TPipeServer-unpredictable-behav.patch, 0002-THRIFT-3225.-cpp-Fix-TPipeServer-unpredictable-behav.patch If TPipeServer::interrupt() is invoked from other thread than the thread that is blocked on TPipeServer::serve() the handle may be closed by interrupting thread while still used by servicing thread. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3225) Fix TPipeServer unpredictable behavior on interrupt()
[ https://issues.apache.org/jira/browse/THRIFT-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14620076#comment-14620076 ] Paweł Janicki commented on THRIFT-3225: --- Posted patch 0002 Fix TPipeServer unpredictable behavior on interrupt() - Key: THRIFT-3225 URL: https://issues.apache.org/jira/browse/THRIFT-3225 Project: Thrift Issue Type: Bug Components: C++ - Library Affects Versions: 0.9.2 Environment: Windows Reporter: Paweł Janicki Assignee: Paweł Janicki Priority: Critical Labels: patch Fix For: 0.9.3 Attachments: 0001-THRIFT-3225.-cpp-Fix-TPipeServer-unpredictable-behav.patch, 0002-THRIFT-3225.-cpp-Fix-TPipeServer-unpredictable-behav.patch If TPipeServer::interrupt() is invoked from other thread than the thread that is blocked on TPipeServer::serve() the handle may be closed by interrupting thread while still used by servicing thread. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
